bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

test: Fix cql_test_env to use updateable cql_config from db::config

Browse Source 
The test environment was creating cql_config with hardcoded default values that
were never updated when system.config was modified via CQL. This broke tests
that dynamically change configuration values (e.g., TWCS tests).

Fix by creating cql_config from db::config using sharded_parameter, which
ensures updateable_value fields track the actual db::config sources and reflect
changes made during test execution.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
This commit is contained in:
Pavel Emelyanov
2026-04-09 22:46:39 +03:00
parent 60a834d9fa
commit 728eb20b42
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/lib/cql_test_env.cc
View File

@@ -740,7 +740,7 @@ private:
_proxy.start(std::ref(_db), spcfg, std::ref(b), scheduling_group_key_create(sg_conf).get(), std::ref(_feature_service), std::ref(_token_metadata), std::ref(_erm_factory)).get();
auto stop_proxy = defer_verbose_shutdown("storage proxy", [this] { _proxy.stop().get(); });
_cql_config.start(cql3::cql_config::default_tag{}).get();
_cql_config.start(seastar::sharded_parameter([&] { return cql3::cql_config(*cfg); })).get();
auto stop_cql_config = defer_verbose_shutdown("cql config", [this] { _cql_config.stop().get(); });
cql3::query_processor::memory_config qp_mcfg;