From 728eb20b4240d30eb0ac2324714d6c7d1edb443e Mon Sep 17 00:00:00 2001 From: Pavel Emelyanov Date: Thu, 9 Apr 2026 22:46:39 +0300 Subject: [PATCH] test: Fix cql_test_env to use updateable cql_config from db::config The test environment was creating cql_config with hardcoded default values that were never updated when system.config was modified via CQL. This broke tests that dynamically change configuration values (e.g., TWCS tests). Fix by creating cql_config from db::config using sharded_parameter, which ensures updateable_value fields track the actual db::config sources and reflect changes made during test execution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Pavel Emelyanov --- test/lib/cql_test_env.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/lib/cql_test_env.cc b/test/lib/cql_test_env.cc index c8f93be45f..f92037e3a4 100644 --- a/test/lib/cql_test_env.cc +++ b/test/lib/cql_test_env.cc @@ -740,7 +740,7 @@ private: _proxy.start(std::ref(_db), spcfg, std::ref(b), scheduling_group_key_create(sg_conf).get(), std::ref(_feature_service), std::ref(_token_metadata), std::ref(_erm_factory)).get(); auto stop_proxy = defer_verbose_shutdown("storage proxy", [this] { _proxy.stop().get(); }); - _cql_config.start(cql3::cql_config::default_tag{}).get(); + _cql_config.start(seastar::sharded_parameter([&] { return cql3::cql_config(*cfg); })).get(); auto stop_cql_config = defer_verbose_shutdown("cql config", [this] { _cql_config.stop().get(); }); cql3::query_processor::memory_config qp_mcfg;