bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

db,view: drop default parameter for mutate_MV::allow_hints

Browse Source 
Default parameters are considered harmful, and as part of a cleanup
before editing view.cc code, a default value for allow_hints parameter
is removed.
This commit is contained in:
Piotr Sarna
2020-01-29 15:40:39 +01:00
parent 0cb7182768
commit 3b3659e8cd
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
db/view/view.hh
View File

@@ -122,7 +122,7 @@ future<> mutate_MV(
db::view::stats& stats,
cf_stats& cf_stats,
db::timeout_semaphore_units pending_view_updates,
service::allow_hints allow_hints = service::allow_hints::yes);
service::allow_hints allow_hints);
/**
* create_virtual_column() adds a "virtual column" to a schema builder.

2
table.cc
View File

@@ -2108,7 +2108,7 @@ future<> table::generate_and_propagate_view_updates(const schema_ptr& base,
std::move(existings)).then([this, base_token = std::move(base_token)] (std::vector<frozen_mutation_and_schema>&& updates) mutable {
auto units = seastar::consume_units(*_config.view_update_concurrency_semaphore, memory_usage_of(updates));
//FIXME: discarded future.
(void)db::view::mutate_MV(std::move(base_token), std::move(updates), _view_stats, *_config.cf_stats, std::move(units)).handle_exception([] (auto ignored) { });
(void)db::view::mutate_MV(std::move(base_token), std::move(updates), _view_stats, *_config.cf_stats, std::move(units), service::allow_hints::yes).handle_exception([] (auto ignored) { });
});
}