From 3b3659e8cd847758abb5f5679dc9505316ad13a6 Mon Sep 17 00:00:00 2001
From: Piotr Sarna <sarna@scylladb.com>
Date: Wed, 29 Jan 2020 15:40:39 +0100
Subject: [PATCH] db,view: drop default parameter for mutate_MV::allow_hints

Default parameters are considered harmful, and as part of a cleanup
before editing view.cc code, a default value for allow_hints parameter
is removed.
---
 db/view/view.hh | 2 +-
 table.cc        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/db/view/view.hh b/db/view/view.hh
index 3b40d538d9..1f2096b8cd 100644
--- a/db/view/view.hh
+++ b/db/view/view.hh
@@ -122,7 +122,7 @@ future<> mutate_MV(
         db::view::stats& stats,
         cf_stats& cf_stats,
         db::timeout_semaphore_units pending_view_updates,
-        service::allow_hints allow_hints = service::allow_hints::yes);
+        service::allow_hints allow_hints);
 
 /**
  * create_virtual_column() adds a "virtual column" to a schema builder.
diff --git a/table.cc b/table.cc
index f002876025..204c039cba 100644
--- a/table.cc
+++ b/table.cc
@@ -2108,7 +2108,7 @@ future<> table::generate_and_propagate_view_updates(const schema_ptr& base,
             std::move(existings)).then([this, base_token = std::move(base_token)] (std::vector<frozen_mutation_and_schema>&& updates) mutable {
         auto units = seastar::consume_units(*_config.view_update_concurrency_semaphore, memory_usage_of(updates));
         //FIXME: discarded future.
-        (void)db::view::mutate_MV(std::move(base_token), std::move(updates), _view_stats, *_config.cf_stats, std::move(units)).handle_exception([] (auto ignored) { });
+        (void)db::view::mutate_MV(std::move(base_token), std::move(updates), _view_stats, *_config.cf_stats, std::move(units), service::allow_hints::yes).handle_exception([] (auto ignored) { });
     });
 }