bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

cql3: fix false-positive "used-after-move" warning in clang-tidy

Browse Source 
`slice.is_reversed()` was falsely flagged as accessing moved data, since
the underlying enum_set remains valid after move. However, to improve code
clarity and silence the warning, now reference `command->slice` directly
instead, which is guaranteed to be valid as the move target.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#22971
This commit is contained in:
Kefu Chai
2025-02-21 14:46:11 +08:00
committed by Avi Kivity
parent f34ea308b3
commit fd52b0a3cc
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cql3/statements/select_statement.cc
View File

@@ -419,8 +419,8 @@ select_statement::do_execute(query_processor& qp,
options.get_timestamp(state));
command->allow_limit = db::allow_per_partition_rate_limit::yes;
logger.trace("Executing read query (reversed {}): table schema {}, query schema {}",
slice.is_reversed(), _schema->version(), _query_schema->version());
tracing::trace(state.get_trace_state(), "Executing read query (reversed {})", slice.is_reversed());
command->slice.is_reversed(), _schema->version(), _query_schema->version());
tracing::trace(state.get_trace_state(), "Executing read query (reversed {})", command->slice.is_reversed());
int32_t page_size = options.get_page_size();