bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

service: storage_proxy: encode abort_requested_exception in handle_read

Browse Source 
storage_proxy::handle_read now makes sure that abort_requested_exception
is encoded in a way that preserves its type information. This allows
the coordinator to properly deserialize and handle it.

Before this change, if a drained replica was still receiving the read
RPCs, it would flood the coordinator's logs with std::runtime_error
reports.
This commit is contained in:
Patryk Jędrzejczak
2023-07-12 11:59:12 +02:00
parent 68bd0424c2
commit f9db9f5943
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
service/storage_proxy.cc
View File

@@ -659,7 +659,11 @@ private:
auto cmd = make_lw_shared<query::read_command>(std::move(cmd1));
auto src_ip = src_addr.addr;
auto timeout = t ? *t : db::no_timeout;
schema_ptr s = co_await get_schema_for_read(cmd->schema_version, std::move(src_addr), timeout);
auto f_s = co_await coroutine::as_future(get_schema_for_read(cmd->schema_version, std::move(src_addr), timeout));
if (f_s.failed()) {
co_return co_await encode_replica_exception_for_rpc<Result>(p->features(), f_s.get_exception());
}
schema_ptr s = f_s.get();
auto pr2 = ::compat::unwrap(std::move(pr), *s);
auto do_query = [&]() {
if constexpr (verb == read_verb::read_data) {