bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

system_keyspace: drop redundant save_truncation_record overload

Browse Source
This commit is contained in:
Petr Gusev
2023-09-22 23:13:47 +04:00
parent da1e6751e9
commit f7d2300cf9
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
db/system_keyspace.cc
View File

@@ -1503,18 +1503,14 @@ future<> system_keyspace::load_truncation_times() {
});
}
future<> system_keyspace::save_truncation_record(table_id id, db_clock::time_point truncated_at, db::replay_position rp) {
future<> system_keyspace::save_truncation_record(const replica::column_family& cf, db_clock::time_point truncated_at, db::replay_position rp) {
sstring req = format("INSERT INTO system.{} (table_uuid, shard, position, segment_id, truncated_at) VALUES(?,?,?,?,?)", TRUNCATED);
co_await _qp.execute_internal(req, {id.uuid(), int32_t(rp.shard_id()), int32_t(rp.pos), int64_t(rp.base_id()), truncated_at}, cql3::query_processor::cache_internal::yes);
co_await _qp.execute_internal(req, {cf.schema()->id().uuid(), int32_t(rp.shard_id()), int32_t(rp.pos), int64_t(rp.base_id()), truncated_at}, cql3::query_processor::cache_internal::yes);
// Flush the table so that the value is available on boot before commitlog replay.
// Commit log replay depends on truncation records to determine the minimum replay position.
co_await force_blocking_flush(TRUNCATED);
}
future<> system_keyspace::save_truncation_record(const replica::column_family& cf, db_clock::time_point truncated_at, db::replay_position rp) {
return save_truncation_record(cf.schema()->id(), truncated_at, rp);
}
future<replay_positions> system_keyspace::get_truncated_positions(table_id cf_id) {
return get_truncation_record(cf_id).then([](truncation_record e) {
return make_ready_future<replay_positions>(e.positions);

1
db/system_keyspace.hh
View File

@@ -354,7 +354,6 @@ public:
typedef std::vector<db::replay_position> replay_positions;
future<> save_truncation_record(table_id, db_clock::time_point truncated_at, db::replay_position);
future<> save_truncation_record(const replica::column_family&, db_clock::time_point truncated_at, db::replay_position);
future<replay_positions> get_truncated_positions(table_id);
future<db_clock::time_point> get_truncated_at(table_id);