bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

sstables_manager: rename _sstable_deleted_event condition variable

Browse Source 
Rename the `_sstable_deleted_event` condition variable to
`_components_memory_change_event` as it will be used by future patches
to signal changes in sstable component memory consumption, (i.e.)
during sstable create and delete, and also when the
`components_memory_reclaim_threshold` config value is changed.

Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com>
This commit is contained in:
Lakshmi Narayanan Sreethar
2025-01-30 17:42:01 +05:30
parent 35a4de3eeb
commit f73b6abcc7
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sstables/sstables_manager.cc
View File

@@ -189,7 +189,7 @@ future<> sstables_manager::components_reclaim_reload_fiber() {
sstlog.trace("components_reloader_fiber start");
while (true) {
co_await _sstable_deleted_event.when();
co_await _components_memory_change_event.when();
if (_closing) {
co_return;
@@ -269,7 +269,7 @@ void sstables_manager::deactivate(sstable* sst) {
void sstables_manager::remove(sstable* sst) {
_undergoing_close.erase(_undergoing_close.iterator_to(*sst));
delete sst;
_sstable_deleted_event.signal();
_components_memory_change_event.signal();
maybe_done();
}
@@ -304,7 +304,7 @@ future<> sstables_manager::close() {
co_await _done.get_future();
co_await _sstable_metadata_concurrency_sem.stop();
// stop the components reload fiber
_sstable_deleted_event.signal();
_components_memory_change_event.signal();
co_await std::move(_components_reloader_status);
}

4
sstables/sstables_manager.hh
View File

@@ -108,8 +108,8 @@ private:
size_t _total_memory_reclaimed{0};
// Set of sstables from which memory has been reclaimed
set_type _reclaimed;
// Condition variable that gets notified when an sstable is deleted
seastar::condition_variable _sstable_deleted_event;
// Condition variable that needs to be notified when an sstable is created or deleted
seastar::condition_variable _components_memory_change_event;
future<> _components_reloader_status = make_ready_future<>();
bool _closing = false;