bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

schema: column_mapping::{static,regular}_column_at(): use on_internal_error()

Browse Source 
Instead of std::out_of_range(). Accessing a non-existing column is a
serious bug and the backtrace coming with on_internal_error() can be
very valuable when debugging it. As can be the coredump that is possible
to trigger with --abort-on-internal-error.

This change follows another similar change to schema::column_at().
This commit is contained in:
Botond Dénes
2024-01-31 05:09:02 -05:00
parent 03ed9f77ff
commit ecf654ea11
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
schema/schema.cc
View File

@@ -94,7 +94,7 @@ const column_mapping_entry& column_mapping::column_at(column_kind kind, column_i
const column_mapping_entry& column_mapping::static_column_at(column_id id) const {
if (id >= _n_static) {
throw std::out_of_range(format("static column id {:d} >= {:d}", id, _n_static));
on_internal_error(dblog, format("static column id {:d} >= {:d}", id, _n_static));
}
return _columns[id];
}
@@ -102,7 +102,7 @@ const column_mapping_entry& column_mapping::static_column_at(column_id id) const
const column_mapping_entry& column_mapping::regular_column_at(column_id id) const {
auto n_regular = _columns.size() - _n_static;
if (id >= n_regular) {
throw std::out_of_range(format("regular column id {:d} >= {:d}", id, n_regular));
on_internal_error(dblog, format("regular column id {:d} >= {:d}", id, n_regular));
}
return _columns[id + _n_static];
}