service: do not include unused headers

these unused includes were identified by clangd. see
https://clangd.llvm.org/guides/include-cleaner#unused-include-warning
for more details on the "Unused include" warning.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#16764

api/storage_service.cc

@@ -22,6 +22,7 @@
 #include <boost/algorithm/string/trim_all.hpp>
 #include <boost/algorithm/string/case_conv.hpp>
 #include <boost/functional/hash.hpp>
+#include "service/raft/raft_group0_client.hh"
 #include "service/storage_service.hh"
 #include "service/load_meter.hh"
 #include "db/commitlog/commitlog.hh"

service/broadcast_tables/experimental/lang.cc

@@ -11,9 +11,7 @@
 #include <seastar/core/future.hh>
 
 #include "data_dictionary/data_dictionary.hh"
-#include "db/config.hh"
 #include "db/system_keyspace.hh"
-#include "exceptions/exceptions.hh"
 #include "service/broadcast_tables/experimental/query_result.hh"
 #include "service/raft/raft_group0_client.hh"
 #include "partition_slice_builder.hh"

service/client_state.cc

@@ -9,12 +9,10 @@
  */
 
 #include "client_state.hh"
-#include "auth/authorizer.hh"
 #include "auth/authenticator.hh"
 #include "auth/common.hh"
 #include "auth/resource.hh"
 #include "exceptions/exceptions.hh"
-#include "validation.hh"
 #include "db/system_keyspace.hh"
 #include "db/schema_tables.hh"
 #include "tracing/trace_keyspace_helper.hh"

service/client_state.hh

@@ -12,18 +12,13 @@
 
 #include "auth/service.hh"
 #include "exceptions/exceptions.hh"
-#include "unimplemented.hh"
 #include "timeout_config.hh"
 #include "timestamp.hh"
-#include "db_clock.hh"
 #include "replica/database_fwd.hh"
 #include "auth/authenticated_user.hh"
 #include "auth/authenticator.hh"
 #include "auth/permission.hh"
-#include "tracing/tracing.hh"
-#include "tracing/trace_state.hh"
 
-#include "enum_set.hh"
 #include "transport/cql_protocol_extension.hh"
 #include "service/qos/service_level_controller.hh"
 

service/forward_service.cc

@@ -15,7 +15,6 @@
 #include <stdexcept>
 
 #include "db/consistency_level.hh"
-#include "dht/i_partitioner.hh"
 #include "dht/sharder.hh"
 #include "gms/gossiper.hh"
 #include "idl/forward_request.dist.hh"
@@ -37,16 +36,13 @@
 #include "types/types.hh"
 #include "service/storage_proxy.hh"
 
-#include "cql3/functions/aggregate_function.hh"
 #include "cql3/column_identifier.hh"
 #include "cql3/cql_config.hh"
 #include "cql3/query_options.hh"
 #include "cql3/result_set.hh"
 #include "cql3/selection/raw_selector.hh"
-#include "cql3/selection/selectable-expr.hh"
 #include "cql3/selection/selection.hh"
 #include "cql3/functions/functions.hh"
-#include "cql3/functions/user_aggregate.hh"
 #include "cql3/expr/expr-utils.hh"
 
 namespace service {

service/migration_manager.hh

@@ -10,7 +10,6 @@
 
 #pragma once
 
-#include <type_traits>
 #include "service/migration_listener.hh"
 #include "gms/endpoint_state.hh"
 #include <seastar/core/distributed.hh>

service/pager/query_pager.hh

@@ -14,8 +14,6 @@
 #include "cql3/result_set.hh"
 #include "cql3/selection/selection.hh"
 #include "service/query_state.hh"
-#include "utils/result.hh"
-#include "exceptions/exceptions.hh"
 #include "exceptions/coordinator_result.hh"
 
 namespace service {

service/pager/query_pagers.cc

@@ -15,9 +15,7 @@
 #include "cql3/restrictions/statement_restrictions.hh"
 #include "log.hh"
 #include "service/storage_proxy.hh"
-#include "utils/to_string.hh"
 #include "utils/result_combinators.hh"
-#include "view_info.hh"
 #include "db/view/delete_ghost_rows_visitor.hh"
 
 template<typename T = void>

service/pager/query_pagers.hh

@@ -10,11 +10,9 @@
 
 #pragma once
 
-#include <vector>
 #include <seastar/core/shared_ptr.hh>
 
 #include "schema/schema_fwd.hh"
-#include "query-result.hh"
 #include "query-request.hh"
 #include "service/query_state.hh"
 #include "cql3/selection/selection.hh"

service/paxos/paxos_state.cc

@@ -12,7 +12,6 @@
 #include "service/paxos/proposal.hh"
 #include "service/paxos/paxos_state.hh"
 #include "db/system_keyspace.hh"
-#include "schema/schema_registry.hh"
 #include "replica/database.hh"
 
 #include "utils/error_injection.hh"

service/paxos/proposal.hh

@@ -7,7 +7,7 @@
  * SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
  */
 #pragma once
-#include "utils/UUID_gen.hh"
+
 #include "mutation/frozen_mutation.hh"
 
 namespace service {

service/qos/service_level_controller.cc

@@ -6,11 +6,9 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-#include <algorithm>
 #include <seastar/core/sleep.hh>
 #include <seastar/core/thread.hh>
 #include "service_level_controller.hh"
-#include "message/messaging_service.hh"
 #include "db/system_distributed_keyspace.hh"
 #include "cql3/query_processor.hh"
 #include "service/storage_proxy.hh"

service/qos/service_level_controller.hh

@@ -9,15 +9,12 @@
 #pragma once
 
 #include "seastarx.hh"
-#include "log.hh"
 #include "auth/role_manager.hh"
-#include "auth/authenticated_user.hh"
 #include <seastar/core/sstring.hh>
 #include <seastar/core/distributed.hh>
 #include <seastar/core/abort_source.hh>
 #include "auth/service.hh"
 #include <map>
-#include <unordered_set>
 #include "qos_common.hh"
 #include "service/endpoint_lifecycle_subscriber.hh"
 #include "qos_configuration_change_subscriber.hh"

service/query_state.hh

@@ -12,6 +12,7 @@
 
 #include "service/client_state.hh"
 #include "tracing/tracing.hh"
+#include "tracing/trace_state.hh"
 #include "service_permit.hh"
 
 namespace qos {

service/storage_proxy.cc

@@ -18,11 +18,9 @@
 #include "unimplemented.hh"
 #include "mutation/mutation.hh"
 #include "mutation/frozen_mutation.hh"
-#include "supervisor.hh"
 #include "query_result_merger.hh"
 #include <seastar/core/do_with.hh>
 #include "message/messaging_service.hh"
-#include "locator/tablets.hh"
 #include "gms/gossiper.hh"
 #include <seastar/core/future-util.hh>
 #include "db/read_repair_decision.hh"
@@ -83,14 +81,11 @@
 #include "gms/feature_service.hh"
 #include "db/virtual_table.hh"
 #include "mutation/canonical_mutation.hh"
-#include "schema_mutations.hh"
 #include "idl/frozen_schema.dist.hh"
 #include "idl/frozen_schema.dist.impl.hh"
 #include "idl/storage_proxy.dist.hh"
-#include "utils/result.hh"
 #include "utils/result_combinators.hh"
 #include "utils/result_loop.hh"
-#include "utils/overloaded_functor.hh"
 #include "utils/result_try.hh"
 #include "utils/error_injection.hh"
 #include "utils/exceptions.hh"

service/storage_service.cc

@@ -18,7 +18,6 @@
 #include <seastar/coroutine/as_future.hh>
 #include "gms/endpoint_state.hh"
 #include "locator/snitch_base.hh"
-#include "locator/production_snitch_base.hh"
 #include "db/system_keyspace.hh"
 #include "db/system_distributed_keyspace.hh"
 #include "db/consistency_level.hh"
@@ -30,31 +29,23 @@
 #include <seastar/core/smp.hh>
 #include "mutation/canonical_mutation.hh"
 #include "seastar/core/on_internal_error.hh"
-#include "seastar/core/scollectd.hh"
 #include "service/raft/group0_state_machine.hh"
 #include "service/raft/raft_group0_client.hh"
 #include "service/topology_state_machine.hh"
 #include "utils/UUID.hh"
 #include "gms/inet_address.hh"
-#include "locator/load_sketch.hh"
 #include "log.hh"
 #include "service/migration_manager.hh"
 #include "service/raft/raft_group0.hh"
-#include "utils/to_string.hh"
 #include "gms/gossiper.hh"
 #include "gms/feature_service.hh"
 #include <seastar/core/thread.hh>
-#include <sstream>
 #include <algorithm>
 #include "locator/local_strategy.hh"
 #include "version.hh"
-#include "unimplemented.hh"
-#include "streaming/stream_plan.hh"
-#include "streaming/stream_state.hh"
 #include "dht/range_streamer.hh"
 #include <boost/range/adaptors.hpp>
 #include <boost/range/algorithm.hpp>
-#include "service/load_broadcaster.hh"
 #include "transport/server.hh"
 #include <seastar/core/rwlock.hh>
 #include "db/batchlog_manager.hh"

service/storage_service.hh

@@ -30,13 +30,13 @@
 #include "replica/database_fwd.hh"
 #include "streaming/stream_reason.hh"
 #include <seastar/core/distributed.hh>
-#include "utils/disk-error-handler.hh"
 #include "service/migration_listener.hh"
 #include <seastar/core/metrics_registration.hh>
 #include <seastar/core/rwlock.hh>
 #include <seastar/core/shared_ptr.hh>
 #include <seastar/core/lowres_clock.hh>
 #include "cdc/generation_id.hh"
+#include "db/system_keyspace.hh"
 #include "raft/raft.hh"
 #include "node_ops/id.hh"
 #include "raft/server.hh"
@@ -90,6 +90,7 @@ class storage_service;
 class storage_proxy;
 class migration_manager;
 class raft_group0;
+class group0_guard;
 class group0_info;
 
 struct join_node_request_params;

service/tablet_allocator.cc

@@ -10,13 +10,12 @@
 #include "replica/tablets.hh"
 #include "locator/tablet_replication_strategy.hh"
 #include "replica/database.hh"
-#include "service/migration_manager.hh"
+#include "service/migration_listener.hh"
 #include "service/tablet_allocator.hh"
 #include "utils/error_injection.hh"
 #include "utils/stall_free.hh"
 #include "db/config.hh"
 #include "locator/load_sketch.hh"
-#include "utils/div_ceil.hh"
 
 using namespace locator;
 using namespace replica;

service/tablet_allocator.hh

@@ -9,9 +9,7 @@
 #pragma once
 
 #include "replica/database.hh"
-#include "service/migration_manager.hh"
 #include "locator/tablets.hh"
-#include <any>
 
 namespace service {
 

service/topology_state_machine.hh

@@ -10,7 +10,6 @@
 #pragma once
 
 #include <boost/range/algorithm/find_if.hpp>
-#include "boost/range/join.hpp"
 #include <iostream>
 #include <unordered_set>
 #include <unordered_map>