bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

treewide: catch by reference

Browse Source 
gcc rightly warns about capturing by value, so capture by
reference.
This commit is contained in:
Avi Kivity
2023-03-19 19:25:26 +02:00
parent eaad38c682
commit e75009cd49
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/raft/randomized_nemesis_test.cc
View File

@@ -312,15 +312,15 @@ future<call_result_t<M>> call(
}).handle_exception([] (std::exception_ptr eptr) {
try {
std::rethrow_exception(eptr);
} catch (raft::not_a_leader e) {
} catch (raft::not_a_leader& e) {
return make_ready_future<call_result_t<M>>(e);
} catch (raft::not_a_member e) {
} catch (raft::not_a_member& e) {
return make_ready_future<call_result_t<M>>(e);
} catch (raft::dropped_entry e) {
} catch (raft::dropped_entry& e) {
return make_ready_future<call_result_t<M>>(e);
} catch (raft::commit_status_unknown e) {
} catch (raft::commit_status_unknown& e) {
return make_ready_future<call_result_t<M>>(e);
} catch (raft::stopped_error e) {
} catch (raft::stopped_error& e) {
return make_ready_future<call_result_t<M>>(e);
} catch (raft::request_aborted&) {
return make_ready_future<call_result_t<M>>(timed_out_error{});

2
transport/server.cc
View File

@@ -677,7 +677,7 @@ future<> cql_server::connection::process_request() {
? get_units(_server._memory_available, mem_estimate, shedding_timeout).then_wrapped([this, length = f.length] (auto f) {
try {
return make_ready_future<semaphore_units<>>(f.get0());
} catch (semaphore_timed_out sto) {
} catch (semaphore_timed_out& sto) {
// Cancel shedding in case no more requests are going to do that on completion
if (_pending_requests_gate.get_count() == 0) {
_shed_incoming_requests = false;