treewide: add missing headers and/or forward declarations

alternator/rmw_operation.hh

@@ -23,6 +23,9 @@
 
 #include <seastarx.hh>
 #include <service/storage_proxy.hh>
+#include <service/storage_proxy.hh>
+#include "rjson.hh"
+#include "executor.hh"
 
 namespace alternator {
 

alternator/tags_extension.hh

@@ -22,6 +22,7 @@
 #pragma once
 
 #include "serializer.hh"
+#include "schema.hh"
 #include "db/extensions.hh"
 
 namespace alternator {

backlog_controller.hh

@@ -23,7 +23,11 @@
 #include <seastar/core/scheduling.hh>
 #include <seastar/core/timer.hh>
 #include <seastar/core/gate.hh>
+#include <seastar/core/file.hh>
 #include <chrono>
+#include <cmath>
+
+#include "seastarx.hh"
 
 // Simple proportional controller to adjust shares for processes for which a backlog can be clearly
 // defined.

cartesian_product.hh

@@ -22,6 +22,9 @@
 
 #pragma once
 
+#include <vector>
+#include <sys/types.h>
+
 // Single-pass range over cartesian product of vectors.
 
 // Note:

cdc/split.hh

@@ -23,6 +23,8 @@
 
 #include <vector>
 #include "schema_fwd.hh"
+#include "timestamp.hh"
+#include "bytes.hh"
 #include <seastar/util/noncopyable_function.hh>
 
 class mutation;

checked-file-impl.hh

@@ -22,8 +22,11 @@
 #pragma once
 
 #include "seastar/core/file.hh"
+#include "seastar/core/reactor.hh"
 #include "utils/disk-error-handler.hh"
 
+#include "seastarx.hh"
+
 class checked_file_impl : public file_impl {
 public:
 

column_computation.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <json/json.h>
+
 #include "bytes.hh"
 
 class schema;

combine.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <algorithm>
+
 // combine two sorted uniqued sequences into a single sorted sequence
 // unique elements are copied, duplicate elements are merged with a
 // binary function.

cql3/functions/native_aggregate_function.hh

@@ -43,6 +43,7 @@
 
 #include "types.hh"
 #include "native_function.hh"
+#include "aggregate_function.hh"
 #include <seastar/core/shared_ptr.hh>
 
 namespace cql3 {

cql3/functions/scalar_function.hh

@@ -42,6 +42,7 @@
 #pragma once
 
 #include "bytes.hh"
+#include "function.hh"
 #include <vector>
 
 namespace cql3 {

cql3/statements/cas_request.hh

@@ -39,6 +39,7 @@
  */
 #pragma once
 #include "service/storage_proxy.hh"
+#include "cql3/statements/modification_statement.hh"
 
 namespace cql3::statements {
 

cql3/statements/cf_properties.hh

@@ -40,6 +40,7 @@
 #pragma once
 
 #include "cql3/statements/cf_prop_defs.hh"
+#include "cql3/column_identifier.hh"
 
 namespace cql3 {
 

cql3/statements/request_validations.hh

@@ -45,6 +45,8 @@
 
 #include <boost/range/algorithm/count_if.hpp>
 
+#include <set>
+
 namespace cql3 {
 namespace statements {
 

cql_serialization_format.hh

@@ -21,7 +21,8 @@
 
 #pragma once
 
-#include <iosfwd>
+#include <iostream>
+#include <cstdint>
 
 using cql_protocol_version_type = uint8_t;
 

db/commitlog/commitlog_replayer.hh

@@ -45,6 +45,8 @@
 #include <seastar/core/future.hh>
 #include <seastar/core/sharded.hh>
 
+#include "seastarx.hh"
+
 class database;
 
 namespace db {

db/commitlog/replay_position.hh

@@ -41,6 +41,7 @@
 #pragma once
 
 #include <stdint.h>
+#include <seastar/core/shared_ptr.hh>
 #include "utils/UUID.hh"
 #include "utils/hash.hh"
 #include "sstables/version.hh"

db/consistency_level_validations.hh

@@ -41,8 +41,11 @@
 
 #pragma once
 
+#include <seastar/core/sstring.hh>
 #include "consistency_level_type.hh"
 
+#include "seastarx.hh"
+
 class schema;
 
 namespace db {

db/cql_type_parser.hh

@@ -46,7 +46,11 @@
 
 #include "types.hh"
 
+#include "seastarx.hh"
+
 class user_types_metadata;
+class types_metadata;
+class keyspace_metadata;
 
 namespace db {
 namespace cql_type_parser {

db/legacy_schema_migrator.hh

@@ -41,6 +41,9 @@
 #pragma once
 
 #include <seastar/core/future.hh>
+#include <seastar/core/sharded.hh>
+
+#include "seastarx.hh"
 
 class database;
 

db/size_estimates_virtual_reader.hh

@@ -22,6 +22,7 @@
  */
 
 #include "mutation_reader.hh"
+#include "db/system_keyspace.hh"
 
 namespace db {
 

db/system_keyspace_view_types.hh

@@ -25,6 +25,7 @@
 #include <seastar/core/sstring.hh>
 #include <utility>
 #include <optional>
+#include "dht/token.hh"
 #include "seastarx.hh"
 
 namespace dht {

db/view/view_builder.hh

@@ -21,7 +21,7 @@
 
 #pragma once
 
-#include "database_fwd.hh"
+#include "database.hh"
 #include "db/system_distributed_keyspace.hh"
 #include "dht/i_partitioner.hh"
 #include "keys.hh"

db/write_type.hh

@@ -42,6 +42,7 @@
 
 #include <assert.h>
 #include <cstdint>
+#include <iosfwd>
 
 namespace db {
 

dht/token_range_endpoints.hh

@@ -21,6 +21,9 @@
 
 #pragma once
 #include <vector>
+#include <seastar/core/sstring.hh>
+
+#include "seastarx.hh"
 
 namespace dht {
 struct endpoint_details {

digest_algorithm.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <cstdint>
+
 namespace query {
 
 enum class digest_algorithm : uint8_t {

gms/failure_detector.hh

@@ -48,9 +48,10 @@
 #include <map>
 #include <optional>
 
+#include "gms/inet_address.hh"
+
 
 namespace gms {
-class inet_address;
 class i_failure_detection_event_listener;
 class endpoint_state;
 

gms/feature.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <any>
+
 #include <boost/signals2.hpp>
 #include <boost/signals2/dummy_mutex.hpp>
 

gms/feature_service.hh

@@ -26,16 +26,17 @@
 #include <seastar/core/shared_future.hh>
 #include <unordered_map>
 #include <functional>
+#include <set>
+#include <any>
 #include "seastarx.hh"
 #include "db/schema_features.hh"
+#include "gms/feature.hh"
 
 namespace db { class config; }
 namespace service { class storage_service; }
 
 namespace gms {
 
-class feature;
-
 struct feature_config {
     bool enable_sstables_mc_format = false;
     bool enable_user_defined_functions = false;

imr/methods.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include "compound.hh"
+
 namespace imr {
 namespace methods {
 

marshal_exception.hh

@@ -22,6 +22,9 @@
 #pragma once
 
 #include <stdexcept>
+#include <seastar/core/sstring.hh>
+
+#include "seastarx.hh"
 
 class marshal_exception : public std::exception {
     sstring _why;

memtable-sstable.hh

@@ -33,7 +33,10 @@
 #include <seastar/core/thread.hh>
 #include <seastar/core/shared_ptr.hh>
 
-namespace sstables { class sstables_manager; }
+namespace sstables {
+class sstables_manager;
+class sstable_writer_config;
+}
 
 future<>
 write_memtable_to_sstable(memtable& mt,

noexcept_traits.hh

@@ -23,6 +23,8 @@
 #include <memory>
 #include <seastar/core/future.hh>
 
+#include "seastarx.hh"
+
 #pragma once
 
 //

redis/exceptions.hh

@@ -24,6 +24,10 @@
 #include <stdexcept>
 #include <seastar/core/print.hh>
 
+#include "bytes.hh"
+
+#include "seastarx.hh"
+
 class redis_exception : public std::exception {
     sstring _message;
 public:

repair/row_level.hh

@@ -24,6 +24,7 @@
 #include <vector>
 #include "gms/inet_address.hh"
 #include "db/system_distributed_keyspace.hh"
+#include "repair/repair.hh"
 #include <seastar/core/distributed.hh>
 
 class row_level_repair_gossip_helper;

serializer.hh

@@ -39,6 +39,7 @@
 #include <variant>
 
 #include <boost/range/algorithm/for_each.hpp>
+#include <boost/type.hpp>
 
 namespace ser {
 

service/cache_hitrate_calculator.hh

@@ -22,6 +22,7 @@
 #pragma  once
 
 #include "database_fwd.hh"
+#include "utils/UUID.hh"
 #include <seastar/core/timer.hh>
 #include <seastar/core/sharded.hh>
 

service/migration_listener.hh

@@ -57,6 +57,8 @@ using schema_ptr = seastar::lw_shared_ptr<const schema>;
 
 #include "timestamp.hh"
 
+#include "seastarx.hh"
+
 class mutation;
 class schema;
 

service/pager/query_pager.hh

@@ -45,6 +45,7 @@
 #include "cql3/result_set.hh"
 #include "cql3/selection/selection.hh"
 #include "service/storage_proxy.hh"
+#include "service/query_state.hh"
 
 namespace service {
 

sstables/component_type.hh

@@ -22,6 +22,8 @@
 
 #pragma once
 
+#include <iosfwd>
+
 namespace sstables {
 
 enum class component_type {

sstables/downsampling.hh

@@ -47,6 +47,7 @@
 #include <vector>
 #include <algorithm>
 #include <iterator>
+#include <cassert>
 
 namespace sstables {
 

sstables/exceptions.hh

@@ -24,6 +24,8 @@
 
 #include <seastar/core/print.hh>
 
+#include "seastarx.hh"
+
 namespace sstables {
 class malformed_sstable_exception : public std::exception {
     sstring _msg;

sstables/filter.hh

@@ -22,6 +22,8 @@
  */
 #pragma once
 
+#include <cstdint>
+
 namespace sstables {
 class sstable;
 }

sstables/hyperloglog.hh

@@ -63,6 +63,10 @@
 #include <stdexcept>
 #include <algorithm>
 #include <seastar/core/byteorder.hh>
+#include <seastar/core/temporary_buffer.hh>
+
+#include "seastarx.hh"
+
 #if 0
 #include "murmur3.h"
 #endif

sstables/random_access_reader.hh

@@ -26,8 +26,10 @@
 #include <seastar/core/gate.hh>
 #include <seastar/core/iostream.hh>
 #include <seastar/core/temporary_buffer.hh>
+#include <seastar/core/temporary_buffer.hh>
 
 #include "utils/disk-error-handler.hh"
+#include "log.hh"
 
 namespace sstables {
 

sstables/remove.hh

@@ -25,6 +25,10 @@
 #include <seastar/core/sstring.hh>
 #include <seastar/core/future.hh>
 
+#include "utils/disk-error-handler.hh"
+
+#include "seastarx.hh"
+
 namespace sstables {
 
 future<> remove_by_toc_name(sstring sstable_toc_name, const io_error_handler& error_handler = sstable_write_error_handler);

sstables/stats.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <cstdint>
+
 namespace sstables {
 
 class sstables_stats {

streaming/stream_mutation_fragments_cmd.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <cstdint>
+
 namespace streaming {
 
 enum class stream_mutation_fragments_cmd : uint8_t {

streaming/stream_reason.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <cstdint>
+
 namespace streaming {
 
 enum class stream_reason : uint8_t {

test/boost/sstable_run_based_compaction_strategy_for_tests.hh

@@ -25,6 +25,7 @@
 #include "sstables/compaction_strategy_impl.hh"
 #include "sstables/sstable_set.hh"
 #include "sstables/compaction.hh"
+#include "database.hh"
 
 namespace sstables {
 

test/lib/eventually.hh

@@ -24,6 +24,8 @@
 #include <seastar/core/sleep.hh>
 #include <seastar/util/noncopyable_function.hh>
 
+#include "seastarx.hh"
+
 inline
 void eventually(noncopyable_function<void ()> f, size_t max_attempts = 17) {
     size_t attempts = 0;

test/lib/index_reader_assertions.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <boost/test/unit_test.hpp>
+
 #include "dht/i_partitioner.hh"
 #include "schema.hh"
 #include "sstables/index_reader.hh"

test/lib/random_utils.hh

@@ -28,6 +28,8 @@
 
 #include <seastar/testing/test_runner.hh>
 
+#include "bytes.hh"
+
 namespace tests::random {
 
 inline std::default_random_engine& gen() {

test/lib/reader_lifecycle_policy.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include "mutation_reader.hh"
+
 class test_reader_lifecycle_policy
         : public reader_lifecycle_policy
         , public enable_shared_from_this<test_reader_lifecycle_policy> {

thrift/utils.hh

@@ -21,6 +21,8 @@
 
 #pragma once
 
+#include <utility>
+
 namespace thrift {
 
 template <typename Ex, typename... Args>

to_string.hh

@@ -27,6 +27,7 @@
 #include <unordered_set>
 #include <set>
 #include <optional>
+#include <list>
 
 #include "seastarx.hh"
 #include "utils/chunked_vector.hh"

transport/messages/result_message_base.hh

@@ -22,6 +22,11 @@
 
 #pragma once
 
+#include <vector>
+#include <seastar/core/sstring.hh>
+
+#include "seastarx.hh"
+
 namespace cql_transport {
 namespace messages {
 

utils/bounded_stats_deque.hh

@@ -38,10 +38,10 @@
 
 #pragma once
 
-namespace utils {
-
 #include <deque>
 
+namespace utils {
+
 /**
  * bounded threadsafe deque
  */

utils/class_registrator.hh

@@ -23,8 +23,11 @@
 
 #include <memory>
 #include <seastar/core/shared_ptr.hh>
+#include <seastar/core/sstring.hh>
 #include <boost/range/algorithm/find_if.hpp>
 
+#include "seastarx.hh"
+
 class no_such_class : public std::runtime_error {
 public:
     using runtime_error::runtime_error;

utils/config_file.hh

@@ -33,6 +33,7 @@
 #include <seastar/core/sstring.hh>
 #include <seastar/core/future.hh>
 #include <seastar/util/defer.hh>
+#include <seastar/util/log.hh>
 
 #include "utils/updateable_value.hh"
 

utils/coroutine.hh

@@ -25,6 +25,8 @@
 #include <seastar/core/future-util.hh>
 #include <seastar/util/noncopyable_function.hh>
 
+#include "seastarx.hh"
+
 // Represents a deferring operation which defers cooperatively with the caller.
 //
 // The operation is started and resumed by calling run(), which returns

utils/directories.hh

@@ -28,6 +28,10 @@
 
 using namespace seastar;
 
+namespace db {
+class config;
+}
+
 namespace utils {
 
 class directories {

utils/estimated_histogram.hh

@@ -48,6 +48,10 @@
 #include <seastar/core/metrics_types.hh>
 #include <seastar/core/print.hh>
 
+#include <seastar/core/print.hh>
+
+#include "seastarx.hh"
+
 namespace utils {
 
 struct estimated_histogram {

utils/exponential_backoff_retry.hh

@@ -24,6 +24,8 @@
 
 #include <seastar/core/abort_source.hh>
 #include <seastar/core/sleep.hh>
+#include <seastar/core/do_with.hh>
+#include <seastar/core/future-util.hh>
 #include "seastarx.hh"
 #include <chrono>
 

utils/flush_queue.hh

@@ -27,6 +27,8 @@
 #include <seastar/core/gate.hh>
 #include <seastar/core/shared_future.hh>
 
+#include "seastarx.hh"
+
 namespace utils {
 
 /*

utils/int_range.hh

@@ -24,6 +24,8 @@
 #include "range.hh"
 #include <seastar/core/print.hh>
 
+#include "seastarx.hh"
+
 using int_range = nonwrapping_range<int>;
 
 inline

utils/joinpoint.hh

@@ -25,6 +25,9 @@
 #include <optional>
 #include <seastar/core/semaphore.hh>
 #include <seastar/core/shared_ptr.hh>
+#include <seastar/core/reactor.hh>
+
+#include "seastarx.hh"
 
 /**
  * Joinpoint:

utils/memory_data_sink.hh

@@ -20,8 +20,11 @@
  */
 
 #include <seastar/core/iostream.hh>
+#include <seastar/core/temporary_buffer.hh>
 #include "utils/small_vector.hh"
 
+#include "seastarx.hh"
+
 #pragma once
 
 // Accumulates data sent to the memory_data_sink allowing it

utils/meta.hh

@@ -21,6 +21,11 @@
 
 #pragma once
 
+#include <sys/types.h>
+#include <cstddef>
+#include <type_traits>
+#include <utility>
+
 namespace meta {
 
 // Wrappers that allows returning a list of types. All helpers defined in this

utils/mutable_view.hh

@@ -24,6 +24,8 @@
 #include <string_view>
 #include <seastar/core/sstring.hh>
 
+#include "seastarx.hh"
+
 template<typename CharT>
 class basic_mutable_view {
     CharT* _begin = nullptr;

utils/preempt.hh

@@ -23,5 +23,7 @@
 
 #include <seastar/util/bool_class.hh>
 
+#include "seastarx.hh"
+
 class is_preemptible_tag;
 using is_preemptible = bool_class<is_preemptible_tag>;

utils/sequenced_set.hh

@@ -19,6 +19,11 @@
  * along with Scylla.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#pragma once
+
+#include <vector>
+#include <unordered_set>
+
 namespace utils {
 /**
  * This class implements an add-only vector that ensures that the elements are