bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge 'treewide: remove implicitly deleted copy ctor and assignment operator' from Kefu Chai

Browse Source 
clang 17 trunk helped to identify these issues. so let's fix them.

Closes #12842

* github.com:scylladb/scylladb:
  row_cache: drop defaulted move assignment operator
  utils/histogram: drop defaulted copy ctor and assignment operator
  range_tombstone_list: remove defaulted move assignment operator
  query-result: remove implicitly deleted copy ctor
This commit is contained in:
Avi Kivity
2023-02-14 20:24:26 +02:00
parent 4f5a460db9 89542232c9
commit df497a5a94
4 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
mutation/range_tombstone_list.hh
View File

@@ -119,7 +119,6 @@ class range_tombstone_list final {
revert();
}
reverter(reverter&&) = default;
reverter& operator=(reverter&&) = default;
reverter(const reverter&) = delete;
reverter& operator=(reverter&) = delete;
virtual range_tombstones_type::iterator insert(range_tombstones_type::iterator it, range_tombstone_entry& new_rt);

2
query-result.hh
View File

@@ -382,9 +382,7 @@ public:
w.reduce_chunk_count();
}
result(result&&) = default;
result(const result&) = default;
result& operator=(result&&) = default;
result& operator=(const result&) = default;
const bytes_ostream& buf() const {
return _w;

1
row_cache.hh
View File

@@ -356,7 +356,6 @@ public:
row_cache(schema_ptr, snapshot_source, cache_tracker&, is_continuous = is_continuous::no);
row_cache(row_cache&&) = default;
row_cache(const row_cache&) = delete;
row_cache& operator=(row_cache&&) = default;
public:
// Implements mutation_source for this cache, see mutation_reader.hh
// User needs to ensure that the row_cache object stays alive

4
utils/histogram.hh
View File

@@ -437,9 +437,7 @@ public:
timed_rate_moving_average met;
timed_rate_moving_average_and_histogram() = default;
timed_rate_moving_average_and_histogram(timed_rate_moving_average_and_histogram&&) = default;
timed_rate_moving_average_and_histogram(const timed_rate_moving_average_and_histogram&) = default;
timed_rate_moving_average_and_histogram(size_t size, int64_t _sample_mask = 0x80) : hist(size, _sample_mask) {}
timed_rate_moving_average_and_histogram& operator=(const timed_rate_moving_average_and_histogram&) = default;
template <typename Rep, typename Ratio>
void mark(std::chrono::duration<Rep, Ratio> dur) {
@@ -505,7 +503,6 @@ public:
}
timed_rate_moving_average_summary_and_histogram(timed_rate_moving_average_summary_and_histogram&&) = default;
timed_rate_moving_average_summary_and_histogram(const timed_rate_moving_average_summary_and_histogram&) = default;
timed_rate_moving_average_summary_and_histogram(size_t size) : _timer([this]{
_rates.update();
_last_update++;
@@ -515,7 +512,6 @@ public:
_last_update = 0;
_summary.update();}), hist(size, 0) {
}
timed_rate_moving_average_summary_and_histogram& operator=(const timed_rate_moving_average_summary_and_histogram&) = default;
template <typename Rep, typename Ratio>
void mark(std::chrono::duration<Rep, Ratio> dur) noexcept {