bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

test: lib: use unique container name per retry attempt

Browse Source 
The container name is generated once before the retry loop, so
all retry attempts reuse the same name. Move the name generation
inside the loop so each attempt gets a fresh name via the
incrementing counter, consistent with the comment "publish port
ephemeral, allows parallel instances".

Formatting changes (indentation) of lines 208-225 in test/lib/proc_utils.cc
will be fixed in the next commit.

Refs SCYLLADB-1542
This commit is contained in:
Dario Mirovic
2026-04-15 15:24:49 +02:00
parent 336dab1eec
commit be4d32c474
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/lib/proc_utils.cc
View File

@@ -200,6 +200,11 @@ future<std::tuple<tests::proc::process_fixture, int>> tests::proc::start_docker_
}
static int counter = 0;
struct in_use{};
constexpr auto max_retries = 8;
for (int retries = 0;; ++retries) {
container_name = fmt::format("{}-{}-{}", name, ::getpid(), ++counter);
// publish port ephemeral, allows parallel instances
@@ -219,10 +224,6 @@ future<std::tuple<tests::proc::process_fixture, int>> tests::proc::start_docker_
params.emplace_back(image);
params.append_range(image_args);
struct in_use{};
constexpr auto max_retries = 8;
for (int retries = 0;; ++retries) {
BOOST_TEST_MESSAGE(fmt::format("Will run {}", params));
std::vector<std::string> env;