bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

tools/scylla-nodetool: implement the rebuild command

Browse Source
This commit is contained in:
Botond Dénes
2023-12-08 06:12:52 -05:00
parent ea62f7c848
commit 9a484cb145
2 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/nodetool/test_nodeops.py
View File

@@ -10,3 +10,13 @@ from rest_api_mock import expected_request
def test_decommission(nodetool):
nodetool("decommission", expected_requests=[
expected_request("POST", "/storage_service/decommission")])
def test_rebuild(nodetool):
nodetool("rebuild", expected_requests=[
expected_request("POST", "/storage_service/rebuild")])
def test_rebuild_with_dc(nodetool):
nodetool("rebuild", "DC1", expected_requests=[
expected_request("POST", "/storage_service/rebuild", params={"source_dc": "DC1"})])

28
tools/scylla-nodetool.cc
View File

@@ -540,6 +540,14 @@ void help_operation(const tool_app_template::config& cfg, const bpo::variables_m
}
}
void rebuild_operation(scylla_rest_client& client, const bpo::variables_map& vm) {
std::unordered_map<sstring, sstring> params;
if (vm.count("source-dc")) {
params["source_dc"] = vm["source-dc"].as<sstring>();
}
client.post("/storage_service/rebuild", std::move(params));
}
void settraceprobability_operation(scylla_rest_client& client, const bpo::variables_map& vm) {
if (!vm.count("trace_probability")) {
throw std::invalid_argument("required parameters are missing: trace_probability");
@@ -956,6 +964,26 @@ Fore more information, see: https://opensource.docs.scylladb.com/stable/operatin
},
listsnapshots_operation
},
{
{
"rebuild",
"Rebuilds a node’s data by streaming data from other nodes in the cluster (similarly to bootstrap)",
R"(
Rebuild operates on multiple nodes in a Scylla cluster. It streams data from a
single source replica when rebuilding a token range. When executing the command,
Scylla first figures out which ranges the local node (the one we want to rebuild)
is responsible for. Then which node in the cluster contains the same ranges.
Finally, Scylla streams the data to the local node.
Fore more information, see: https://opensource.docs.scylladb.com/stable/operating-scylla/nodetool-commands/rebuild.html
)",
{ },
{
typed_option<sstring>("source-dc", "DC from which to stream data (default: any DC)", 1),
},
},
rebuild_operation
},
{
{
"settraceprobability",