bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

counters: move fmt::formatter<counter_{shard,cell}_view>::format() to .cc

Browse Source 
to reduce the size of header file, in hope to speed the compilation. let's
implement the implementation of format() function into .cc file.

Refs #13245

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes #14010
This commit is contained in:
Kefu Chai
2023-05-20 17:36:14 +08:00
committed by Botond Dénes
parent 132260973a
commit 8efb5c30ce
2 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
counters.cc
View File

@@ -12,6 +12,18 @@
#include <boost/range/algorithm/sort.hpp>
auto fmt::formatter<counter_shard_view>::format(const counter_shard_view& csv,
fmt::format_context& ctx) const -> decltype(ctx.out()) {
return fmt::format_to(ctx.out(), "{{global_shard id: {} value: {}, clock: {}}}",
csv.id(), csv.value(), csv.logical_clock());
}
auto fmt::formatter<counter_cell_view>::format(const counter_cell_view& ccv,
fmt::format_context& ctx) const -> decltype(ctx.out()) {
return fmt::format_to(ctx.out(), "{{counter_cell timestamp: {} shards: {{{}}}}}",
ccv.timestamp(), fmt::join(ccv.shards(), ", "));
}
void counter_cell_builder::do_sort_and_remove_duplicates()
{
boost::range::sort(_shards, [] (auto& a, auto& b) { return a.id() < b.id(); });

12
counters.hh
View File

@@ -90,11 +90,7 @@ using counter_shard_view = basic_counter_shard_view<mutable_view::no>;
template <>
struct fmt::formatter<counter_shard_view> : fmt::formatter<std::string_view> {
template <typename FormatContext>
auto format(const counter_shard_view& csv, FormatContext& ctx) const {
return fmt::format_to(ctx.out(), "{{global_shard id: {} value: {}, clock: {}}}",
csv.id(), csv.value(), csv.logical_clock());
}
auto format(const counter_shard_view&, fmt::format_context& ctx) const -> decltype(ctx.out());
};
class counter_shard {
@@ -357,11 +353,7 @@ struct counter_cell_view : basic_counter_cell_view<mutable_view::no> {
template <>
struct fmt::formatter<counter_cell_view> : fmt::formatter<std::string_view> {
template <typename FormatContext>
auto format(const counter_cell_view& ccv, FormatContext& ctx) const {
return fmt::format_to(ctx.out(), "{{counter_cell timestamp: {} shards: {{{}}}}}",
ccv.timestamp(), fmt::join(ccv.shards(), ", "));
}
auto format(const counter_cell_view&, fmt::format_context& ctx) const -> decltype(ctx.out());
};
struct counter_cell_mutable_view : basic_counter_cell_view<mutable_view::yes> {