bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

cql: Add test for invalid unbounded DELETE

Browse Source 
In add40d4e59, we relaxed the prohibition of unbounded DELETE and
stopped testing the failure message.  But there are still scenarios
when unbounded DELETE is prohibited, so add a test to ensure we
continue to catch it where appropriate.

Signed-off-by: Dejan Mircevski <dejan@scylladb.com>
This commit is contained in:
Dejan Mircevski
2020-05-13 12:18:12 -04:00
committed by Avi Kivity
parent b155eef726
commit 8db7e4cc96
1 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
test/boost/cql_query_test.cc
View File

@@ -52,6 +52,7 @@
#include "schema_builder.hh"
#include "service/migration_manager.hh"
#include <regex>
#include "gms/feature.hh"
using namespace std::literals::chrono_literals;
@@ -1091,6 +1092,32 @@ SEASTAR_TEST_CASE(test_range_deletion_scenarios_with_compact_storage) {
});
}
SEASTAR_TEST_CASE(test_invalid_range_deletion) {
cql_test_config cfg;
cfg.disabled_features.insert(sstring(gms::features::UNBOUNDED_RANGE_TOMBSTONES));
return do_with_cql_env_thread([] (cql_test_env& e) {
cquery_nofail(e, "create table cf (p int, c1 int, c2 int, c3 int, primary key (p, c1, c2, c3));");
const auto q = [&] (const char* stmt) { return e.execute_cql(stmt).get(); };
using ire = exceptions::invalid_request_exception;
const auto expected = exception_predicate::message_contains("specify both bounds");
cquery_nofail(e, "delete from cf where p = 1");
cquery_nofail(e, "delete from cf where p = 1 and c1 = 2");
BOOST_REQUIRE_EXCEPTION(q("delete from cf where p = 1 and c1 < 2"), ire, expected);
BOOST_REQUIRE_EXCEPTION(q("delete from cf where p = 1 and c1 >= 0"), ire, expected);
cquery_nofail(e, "delete from cf where p = 1 and c1 < 2 and c1 >= 0");
// TODO: enable when supported:
// cquery_nofail(e, "delete from cf where p = 1 and c1 = 2 and c1 < 2");
BOOST_REQUIRE_EXCEPTION(q("delete from cf where p = 1 and c1 = 2 and c2 >= 0"), ire, expected);
cquery_nofail(e, "delete from cf where p = 1 and c1 = 2 and c2 >= 0 and c2 < 2");
BOOST_REQUIRE_EXCEPTION(q("delete from cf where p = 1 and (c1)>(0)"), ire, expected);
BOOST_REQUIRE_EXCEPTION(q("delete from cf where p = 1 and (c1,c2)>(0,0)"), ire, expected);
BOOST_REQUIRE_EXCEPTION(q("delete from cf where p = 1 and (c1,c2,c3)<=(5,5,5)"), ire, expected);
cquery_nofail(e, "delete from cf where p = 1 and (c1,c2)>(0,0) and (c1,c2)<=(5,5)");
cquery_nofail(e, "delete from cf where p = 1 and (c1,c2)>(0,0) and (c1)<=(5)");
cquery_nofail(e, "delete from cf where p = 1 and (c1,c2)=(1,1)");
}, cfg);
}
SEASTAR_TEST_CASE(test_map_insert_update) {
return do_with_cql_env([] (cql_test_env& e) {
auto make_my_map_type = [] { return map_type_impl::get_instance(int32_type, int32_type, true); };