gms: do not include unused headers

these unused includes were identified by clangd. see
https://clangd.llvm.org/guides/include-cleaner#unused-include-warning
for more details on the "Unused include" warning.

because the removal of `#include "unimplemented.hh"`,
`service/migration_manager.cc` misses the definition of
`unimplemented::cause::VALIDATION`, so include the header where it is
used.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#16654

gms/endpoint_state.hh

@@ -10,7 +10,6 @@
 
 #pragma once
 
-#include "utils/serialization.hh"
 #include "gms/heart_beat_state.hh"
 #include "gms/application_state.hh"
 #include "gms/versioned_value.hh"

gms/feature_service.cc

@@ -4,7 +4,6 @@
  * Copyright (C) 2020-present ScyllaDB
  */
 
-#include <any>
 #include <seastar/core/sstring.hh>
 #include <seastar/core/seastar.hh>
 #include <seastar/core/smp.hh>
@@ -13,7 +12,6 @@
 #include "gms/feature.hh"
 #include "gms/feature_service.hh"
 #include "db/system_keyspace.hh"
-#include "utils/to_string.hh"
 #include <boost/algorithm/string/classification.hpp>
 #include <boost/algorithm/string/split.hpp>
 #include <boost/range/adaptor/map.hpp>

gms/generation-number.cc

@@ -9,7 +9,6 @@
 #include <cassert>
 #include <chrono>
 #include <utility>
-#include <exception>
 
 #include <fmt/format.h>
 

gms/gossip_digest.hh

@@ -11,7 +11,6 @@
 #pragma once
 
 #include <seastar/core/sstring.hh>
-#include "utils/serialization.hh"
 #include "gms/inet_address.hh"
 #include "gms/generation-number.hh"
 #include "gms/version_generator.hh"

gms/gossiper.hh

@@ -10,7 +10,6 @@
 
 #pragma once
 
-#include "unimplemented.hh"
 #include <seastar/core/distributed.hh>
 #include <seastar/core/shared_ptr.hh>
 #include <seastar/core/gate.hh>
@@ -23,7 +22,6 @@
 #include "gms/versioned_value.hh"
 #include "gms/application_state.hh"
 #include "gms/endpoint_state.hh"
-#include "gms/feature.hh"
 #include "gms/gossip_digest_syn.hh"
 #include "gms/gossip_digest.hh"
 #include "utils/loading_shared_values.hh"
@@ -31,7 +29,6 @@
 #include "utils/in.hh"
 #include "message/messaging_service_fwd.hh"
 #include <optional>
-#include <algorithm>
 #include <chrono>
 #include <set>
 #include <seastar/core/condition-variable.hh>

gms/heart_beat_state.hh

@@ -12,7 +12,6 @@
 
 #include "gms/generation-number.hh"
 #include "gms/version_generator.hh"
-#include "utils/serialization.hh"
 #include <ostream>
 #include <limits>
 

gms/inet_address.hh

@@ -18,7 +18,6 @@
 #include <functional>
 
 #include "bytes.hh"
-#include "seastarx.hh"
 
 namespace gms {
 

service/migration_manager.cc

@@ -33,6 +33,7 @@
 #include "cql3/functions/user_aggregate.hh"
 #include "cql3/functions/user_function.hh"
 #include "cql3/functions/function_name.hh"
+#include "unimplemented.hh"
 
 namespace service {