db::commitlog::descriptor::descriptor(filename): pass a filename as a const ref

Avoid not needed copy by passing a file name as a reference.

Signed-off-by: Vlad Zolotarov <vladz@scylladb.com>

db/commitlog/commitlog.cc

@@ -132,8 +132,8 @@ db::commitlog::descriptor::descriptor(std::pair<uint64_t, uint32_t> p)
         : descriptor(p.first, p.second) {
 }
 
-db::commitlog::descriptor::descriptor(sstring filename)
-        : descriptor([filename]() {
+db::commitlog::descriptor::descriptor(const sstring& filename)
+        : descriptor([&filename] () {
             std::smatch m;
             // match both legacy and new version of commitlogs Ex: CommitLog-12345.log and CommitLog-4-12345.log.
                 std::regex rx("(?:.*/)?" + FILENAME_PREFIX + "((\\d+)(" + SEPARATOR + "\\d+)?)" + FILENAME_EXTENSION);

db/commitlog/commitlog.hh

@@ -139,7 +139,7 @@ public:
         descriptor(const descriptor&) = default;
         descriptor(segment_id_type i, uint32_t v = 1);
         descriptor(replay_position p);
-        descriptor(sstring filename);
+        descriptor(const sstring& filename);
 
         sstring filename() const;
         operator replay_position() const;