bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

sstables: Add debug info when create_sharding_metadata generates zero ranges

Browse Source 
The range passed to create_sharding_metadata is supposed to be owned or
at least partially owned by the shard. Log keys, range and split
ranges for debugging if the range does not belong to the shard.

This is helpful for debugging "Failed to generate sharding
metadata for foo.db" issues reported.

Refs #7056

Closes #8557
This commit is contained in:
Asias He
2021-04-27 17:03:43 +08:00
committed by Avi Kivity
parent abb111297a
commit 60ba8eb9b8
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sstables/sstables.cc
View File

@@ -1515,6 +1515,11 @@ create_sharding_metadata(schema_ptr schema, const dht::decorated_key& first_key,
auto prange = dht::partition_range::make(dht::ring_position(first_key), dht::ring_position(last_key));
auto sm = sharding_metadata();
auto&& ranges = dht::split_range_to_single_shard(*schema, prange, shard).get0();
if (ranges.empty()) {
auto split_ranges_all_shards = dht::split_range_to_shards(prange, *schema);
sstlog.warn("create_sharding_metadata: range={} has no intersection with shard={} first_key={} last_key={} ranges_single_shard={} ranges_all_shards={}",
prange, shard, first_key, last_key, ranges, split_ranges_all_shards);
}
sm.token_ranges.elements.reserve(ranges.size());
for (auto&& range : std::move(ranges)) {
if (true) { // keep indentation