bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

raft: server: use visit instead of holds_alternative+get

Browse Source 
In `std::holds_alternative`+`std::get` version, the `get` performs a
redundant check. Also `std::visit` gives a compile-time exhaustiveness
check (whether we handled all possible cases of the `variant`).
This commit is contained in:
Kamil Braun
2022-08-18 17:54:14 +02:00
parent afa7960926
commit 5badf20c7a
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
raft/server.cc
View File

@@ -987,11 +987,11 @@ future<> server_impl::applier_fiber() {
while (true) {
auto v = co_await _apply_entries.pop_eventually();
if (std::holds_alternative<std::vector<log_entry_ptr>>(v)) {
auto& batch = std::get<0>(v);
co_await std::visit(make_visitor(
[this] (std::vector<log_entry_ptr>& batch) -> future<> {
if (batch.empty()) {
logger.trace("[{}] applier fiber: received empty batch", _id);
continue;
co_return;
}
// Completion notification code assumes that previous snapshot is applied
@@ -1049,8 +1049,8 @@ future<> server_impl::applier_fiber() {
}
_stats.snapshots_taken++;
}
} else {
snapshot_descriptor& snp = std::get<1>(v);
},
[this] (snapshot_descriptor& snp) -> future<> {
assert(snp.idx >= _applied_idx);
// Apply snapshot it to the state machine
logger.trace("[{}] apply_fiber applying snapshot {}", _id, snp.id);
@@ -1060,6 +1060,8 @@ future<> server_impl::applier_fiber() {
_applied_index_changed.broadcast();
_stats.sm_load_snapshot++;
}
), v);
signal_applied();
}
} catch(stop_apply_fiber& ex) {