bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

token_metadata: get_endpoint_to_host_id_map_for_reading: just inform that normal node has null host_id

Browse Source 
It is too early to require that all nodes in normal state
have a non-null host_id.

The assertion was added in 44c14f3e2b
but unfortunately there are several call sites where
we add the node as normal, but without a host_id
and we patch it in later on.

In the future we should be able to require that
once we identify nodes by host_id over gossiper
and in token_metadata.

Fixes scylladb/scylladb#15181

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>

Closes #15184
This commit is contained in:
Benny Halevy
2023-08-27 16:51:24 +03:00
committed by Nadav Har'El
parent 47ce69e9bf
commit 5afc242814
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
locator/token_metadata.cc
View File

@@ -568,7 +568,7 @@ std::unordered_map<inet_address, host_id> token_metadata_impl::get_endpoint_to_h
if (const auto& host_id = node->host_id()) {
map[endpoint] = host_id;
} else {
on_internal_error_noexcept(tlogger, fmt::format("get_endpoint_to_host_id_map_for_reading: endpoint {} has null host_id", endpoint));
tlogger.info("get_endpoint_to_host_id_map_for_reading: endpoint {} has null host_id: state={}", endpoint, node->get_state());
}
}
return map;