From 5afc2428140f543fd01790349dfba2f8eacc3d18 Mon Sep 17 00:00:00 2001 From: Benny Halevy Date: Sun, 27 Aug 2023 16:51:24 +0300 Subject: [PATCH] token_metadata: get_endpoint_to_host_id_map_for_reading: just inform that normal node has null host_id It is too early to require that all nodes in normal state have a non-null host_id. The assertion was added in 44c14f3e2b779409d9c73e4cddd32d0c741bc14c but unfortunately there are several call sites where we add the node as normal, but without a host_id and we patch it in later on. In the future we should be able to require that once we identify nodes by host_id over gossiper and in token_metadata. Fixes scylladb/scylladb#15181 Signed-off-by: Benny Halevy Closes #15184 --- locator/token_metadata.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/locator/token_metadata.cc b/locator/token_metadata.cc index 4e11e95390..abc7507859 100644 --- a/locator/token_metadata.cc +++ b/locator/token_metadata.cc @@ -568,7 +568,7 @@ std::unordered_map token_metadata_impl::get_endpoint_to_h if (const auto& host_id = node->host_id()) { map[endpoint] = host_id; } else { - on_internal_error_noexcept(tlogger, fmt::format("get_endpoint_to_host_id_map_for_reading: endpoint {} has null host_id", endpoint)); + tlogger.info("get_endpoint_to_host_id_map_for_reading: endpoint {} has null host_id: state={}", endpoint, node->get_state()); } } return map;