bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

test/boost/row_cache_test: test_exception_safety_of_reads: also cover single-partition reads

Browse Source 
The test currently only covers scans. Single partition reads have a
different code-path, make sure it is also covered.
This commit is contained in:
Botond Dénes
2023-10-03 06:56:41 -04:00
parent ffefa623f4
commit 460bc7d8e1
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/boost/row_cache_test.cc
View File

@@ -2613,9 +2613,22 @@ SEASTAR_TEST_CASE(test_exception_safety_of_reads) {
row_cache cache(s, snapshot_source([&] { return underlying(); }), tracker);
auto run_queries = [&] {
auto singular_pr = dht::partition_range::make_singular(mut.decorated_key());
auto slice = partition_slice_builder(*s).with_ranges(gen.make_random_ranges(3)).build();
auto&& ranges = slice.row_ranges(*s, mut.key());
memory::with_allocation_failures([&] {
auto rd = cache.make_reader(s, semaphore.make_permit(), singular_pr, slice);
auto close_rd = deferred_close(rd);
auto got_opt = read_mutation_from_flat_mutation_reader(rd).get0();
BOOST_REQUIRE(got_opt);
BOOST_REQUIRE(!read_mutation_from_flat_mutation_reader(rd).get0());
assert_that(*got_opt).is_equal_to_compacted(mut, ranges);
assert_that(cache.make_reader(s, semaphore.make_permit(), singular_pr, slice))
.produces(mut, ranges);
});
memory::with_allocation_failures([&] {
auto rd = cache.make_reader(s, semaphore.make_permit(), query::full_partition_range, slice);
auto close_rd = deferred_close(rd);