bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

locator/reconnectable_snitch_helper: Avoid versioned_value copies

Browse Source 
Signed-off-by: Duarte Nunes <duarte@scylladb.com>
This commit is contained in:
Duarte Nunes
2017-10-10 17:45:55 +01:00
parent 28d63a76df
commit 2f05d7423a
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
locator/reconnectable_snitch_helper.hh
View File

@@ -56,7 +56,7 @@ private:
private:
void reconnect(gms::inet_address public_address, gms::versioned_value local_address_value) {
void reconnect(gms::inet_address public_address, const gms::versioned_value& local_address_value) {
reconnect(public_address, gms::inet_address(local_address_value.value));
}
@@ -97,10 +97,9 @@ public:
}
void on_join(gms::inet_address endpoint, gms::endpoint_state ep_state) override {
auto internal_ip_state_opt = ep_state.get_application_state(gms::application_state::INTERNAL_IP);
if (internal_ip_state_opt) {
reconnect(endpoint, *internal_ip_state_opt);
auto* internal_ip_state = ep_state.get_application_state_ptr(gms::application_state::INTERNAL_IP);
if (internal_ip_state) {
reconnect(endpoint, *internal_ip_state);
}
}
@@ -111,11 +110,7 @@ public:
}
void on_alive(gms::inet_address endpoint, gms::endpoint_state ep_state) override {
auto internal_ip_state_opt = ep_state.get_application_state(gms::application_state::INTERNAL_IP);
if (internal_ip_state_opt) {
reconnect(endpoint, *internal_ip_state_opt);
}
on_join(std::move(endpoint), std::move(ep_state));
}
void on_dead(gms::inet_address endpoint, gms::endpoint_state ep_state) override {