treewide: use #include <seastar/...> for seastar headers

We treat Seastar as an external library, so fix the few places
that didn't do so to use angle brackets.

Closes #14037

cql3/expr/restrictions.cc

@@ -9,7 +9,7 @@
 #include "cql3/statements/request_validations.hh"
 #include "exceptions/exceptions.hh"
 #include "schema/schema.hh"
-#include "seastar/util/defer.hh"
+#include <seastar/util/defer.hh>
 #include "cql3/prepare_context.hh"
 #include "types/list.hh"
 #include <iterator>

cql3/statements/describe_statement.cc

@@ -18,15 +18,15 @@
 #include "cql3/statements/prepared_statement.hh"
 #include "exceptions/exceptions.hh"
 #include "keys.hh"
-#include "seastar/core/on_internal_error.hh"
-#include "seastar/coroutine/maybe_yield.hh"
+#include <seastar/core/on_internal_error.hh>
+#include <seastar/coroutine/maybe_yield.hh>
 #include "service/client_state.hh"
 #include "types/types.hh"
 #include "cql3/query_processor.hh"
 #include "cql3/cql_statement.hh"
 #include "cql3/statements/raw/describe_statement.hh"
 #include "cql3/statements/describe_statement.hh"
-#include "seastar/core/shared_ptr.hh"
+#include <seastar/core/shared_ptr.hh>
 #include "transport/messages/result_message.hh"
 #include "transport/messages/result_message_base.hh"
 #include "service/query_state.hh"

cql3/statements/describe_statement.hh

@@ -8,7 +8,7 @@
 
 #pragma once
 
-#include "seastar/core/sstring.hh"
+#include <seastar/core/sstring.hh>
 #include "cql3/cql_statement.hh"
 #include "cql3/statements/raw/describe_statement.hh"
 #include <memory>

data_dictionary/keyspace_element.hh

@@ -9,7 +9,7 @@
 #pragma once
 
 #include <ostream>
-#include "seastar/core/sstring.hh"
+#include <seastar/core/sstring.hh>
 
 namespace replica {
 class database;

lang/wasm_alien_thread_runner.cc

@@ -15,7 +15,7 @@
 #include "log.hh"
 #include "lang/wasm.hh"
 #include "lang/wasm_alien_thread_runner.hh"
-#include "seastar/core/posix.hh"
+#include <seastar/core/posix.hh>
 
 extern logging::logger wasm_logger;
 

lang/wasm_instance_cache.cc

@@ -8,8 +8,8 @@
 
 #include "lang/wasm_instance_cache.hh"
 #include "lang/wasm.hh"
-#include "seastar/core/metrics.hh"
-#include "seastar/core/scheduling.hh"
+#include <seastar/core/metrics.hh>
+#include <seastar/core/scheduling.hh>
 #include <exception>
 #include <seastar/core/units.hh>
 #include <seastar/core/shared_mutex.hh>

locator/token_metadata.cc

@@ -20,7 +20,7 @@
 #include <seastar/core/coroutine.hh>
 #include <seastar/coroutine/maybe_yield.hh>
 #include <boost/range/adaptors.hpp>
-#include "seastar/core/smp.hh"
+#include <seastar/core/smp.hh>
 #include "utils/stall_free.hh"
 #include "utils/fb_utilities.hh"
 

query.cc

@@ -13,8 +13,8 @@
 #include "query-result.hh"
 #include "query-result-writer.hh"
 #include "query-result-set.hh"
-#include "seastar/core/shared_ptr.hh"
-#include "seastar/core/thread.hh"
+#include <seastar/core/shared_ptr.hh>
+#include <seastar/core/thread.hh>
 #include "utils/to_string.hh"
 #include "bytes.hh"
 #include "mutation/mutation_partition_serializer.hh"

replica/exceptions.hh

@@ -13,8 +13,8 @@
 #include <optional>
 #include <variant>
 
-#include "seastar/core/sstring.hh"
-#include "seastar/core/timed_out_error.hh"
+#include <seastar/core/sstring.hh>
+#include <seastar/core/timed_out_error.hh>
 
 #include "utils/exception_container.hh"
 #include "utils/result.hh"

schema/schema.hh

@@ -19,7 +19,7 @@
 #include "cql3/column_specification.hh"
 #include <seastar/core/shared_ptr.hh>
 #include <seastar/util/backtrace.hh>
-#include "seastar/core/sstring.hh"
+#include <seastar/core/sstring.hh>
 #include "types/types.hh"
 #include "compound.hh"
 #include "gc_clock.hh"

service/forward_service.cc

@@ -27,10 +27,10 @@
 #include "replica/database.hh"
 #include "schema/schema.hh"
 #include "schema/schema_registry.hh"
-#include "seastar/core/do_with.hh"
-#include "seastar/core/future.hh"
-#include "seastar/core/on_internal_error.hh"
-#include "seastar/core/when_all.hh"
+#include <seastar/core/do_with.hh>
+#include <seastar/core/future.hh>
+#include <seastar/core/on_internal_error.hh>
+#include <seastar/core/when_all.hh>
 #include "service/pager/query_pagers.hh"
 #include "tracing/trace_state.hh"
 #include "tracing/tracing.hh"

streaming/stream_session.cc

@@ -10,7 +10,7 @@
 
 #include "log.hh"
 #include "message/messaging_service.hh"
-#include "seastar/coroutine/maybe_yield.hh"
+#include <seastar/coroutine/maybe_yield.hh>
 #include "streaming/stream_session.hh"
 #include "streaming/prepare_message.hh"
 #include "streaming/stream_result_future.hh"

test/boost/expr_test.cc

@@ -1,6 +1,6 @@
 #include "cql3/column_identifier.hh"
 #include "cql3/util.hh"
-#include "seastar/core/shared_ptr.hh"
+#include <seastar/core/shared_ptr.hh>
 #include "types/types.hh"
 #include "types/list.hh"
 #include "types/map.hh"

test/boost/group0_test.cc

@@ -16,7 +16,7 @@
 #include "utils/error_injection.hh"
 #include "transport/messages/result_message.hh"
 #include "service/migration_manager.hh"
-#include "seastar/core/metrics_api.hh"
+#include <seastar/core/metrics_api.hh>
 
 static future<utils::chunked_vector<std::vector<managed_bytes_opt>>> fetch_rows(cql_test_env& e, std::string_view cql) {
     auto msg = co_await e.execute_cql(cql);

test/boost/row_cache_test.cc

@@ -39,7 +39,7 @@
 #include "readers/from_mutations_v2.hh"
 #include "readers/delegating_v2.hh"
 #include "readers/empty_v2.hh"
-#include "seastar/testing/thread_test_case.hh"
+#include <seastar/testing/thread_test_case.hh>
 
 using namespace std::chrono_literals;
 

test/boost/wasm_alloc_test.cc

@@ -9,7 +9,7 @@
 #include "lang/wasm.hh"
 #include "lang/wasm_instance_cache.hh"
 #include "rust/wasmtime_bindings.hh"
-#include "seastar/core/reactor.hh"
+#include <seastar/core/reactor.hh>
 #include "test/lib/scylla_test_case.hh"
 #include <seastar/core/coroutine.hh>
 

test/boost/wasm_test.cc

@@ -9,7 +9,7 @@
 #include "lang/wasm.hh"
 #include "lang/wasm_instance_cache.hh"
 #include "rust/wasmtime_bindings.hh"
-#include "seastar/coroutine/maybe_yield.hh"
+#include <seastar/coroutine/maybe_yield.hh>
 #include <chrono>
 #include <seastar/core/lowres_clock.hh>
 #include "test/lib/scylla_test_case.hh"

thrift/controller.cc

@@ -7,7 +7,7 @@
  */
 
 #include "thrift/controller.hh"
-#include "seastar/core/sharded.hh"
+#include <seastar/core/sharded.hh>
 #include "thrift/server.hh"
 #include "replica/database.hh"
 #include "db/config.hh"

transport/controller.cc

@@ -7,7 +7,7 @@
  */
 
 #include "transport/controller.hh"
-#include "seastar/core/sharded.hh"
+#include <seastar/core/sharded.hh>
 #include "transport/server.hh"
 #include "service/memory_limiter.hh"
 #include "db/config.hh"