bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

shared_token_metadata: update_fence_version: on_internal_error -> throw

Browse Source 
on_internal_error is wrong for fence_version
condition violation, since in case of
topology change coordinator migrating to another
node we can have raft_topology_cmd::command::fence
command from the old coordinator running in
parallel with the fence command (or topology version
upgrading raft command) from the new one.
The comment near the raft_topology_cmd::command::fence
handling describes this situation, assuming an exception
is thrown in this case.
This commit is contained in:
Petr Gusev
2023-06-16 16:26:51 +04:00
parent 1770feebda
commit 246eaec14e
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
locator/token_metadata.cc
View File

@@ -1192,13 +1192,22 @@ void shared_token_metadata::set(mutable_token_metadata_ptr tmptr) noexcept {
void shared_token_metadata::update_fence_version(token_metadata::version_t version) {
if (const auto current_version = _shared->get_version(); version > current_version) {
// The token_metadata::version under no circumstance can go backwards.
// Even in case of topology change coordinator moving to another node
// this condition must hold, that is why we treat its violation
// as an internal error.
on_internal_error(tlogger,
format("shared_token_metadata: invalid new fence version, can't be greater than the current version, "
"current version {}, new fence version {}", current_version, version));
}
if (version < _fence_version) {
on_internal_error(tlogger,
format("shared_token_metadata: must not set decreasing fence version: {} -> {}", _fence_version, version));
// If topology change coordinator moved to another node,
// it can get ahead and increment the fence version
// while we are handling raft_topology_cmd::command::fence,
// so we just throw an error in this case.
throw std::runtime_error(
format("shared_token_metadata: can't set decreasing fence version: {} -> {}",
_fence_version, version));
}
_fence_version = version;
}