treewide: make headers self-sufficient

In preparation for some large header changes, fix up any headers
that aren't self-sufficient by adding needed includes or forward
declarations.

cdc/generation_service.hh

@@ -22,18 +22,28 @@
 
 #pragma once
 
+#include <seastar/core/sharded.hh>
 #include "cdc/metadata.hh"
 #include "cdc/generation_id.hh"
 #include "gms/i_endpoint_state_change_subscriber.hh"
 
 namespace db {
 class system_distributed_keyspace;
+class config;
 }
 
 namespace gms {
 class gossiper;
 }
 
+namespace seastar {
+class abort_source;
+}
+
+namespace locator {
+class shared_token_metadata;
+}
+
 namespace cdc {
 
 class generation_service : public peering_sharded_service<generation_service>

cdc/split.hh

@@ -24,6 +24,7 @@
 #include <vector>
 #include <boost/dynamic_bitset.hpp>
 #include "schema_fwd.hh"
+#include "database_fwd.hh"
 #include "timestamp.hh"
 #include "bytes.hh"
 #include <seastar/util/noncopyable_function.hh>

db/view/view_update_checks.hh

@@ -21,9 +21,13 @@
 
 #pragma once
 
+#include <seastar/core/future.hh>
 #include "streaming/stream_reason.hh"
 #include <boost/range/adaptor/map.hpp>
 #include <boost/algorithm/cxx11/any_of.hpp>
+#include "seastarx.hh"
+
+class table;
 
 namespace db {
 

raft/logical_clock.hh

@@ -21,6 +21,7 @@
 #pragma once
 
 #include <chrono>
+#include <ostream>
 
 namespace raft {
 

sstables/kl/writer.hh

@@ -20,6 +20,7 @@
  */
 
 #include "sstables/writer_impl.hh"
+#include "sstables/writer.hh"
 
 namespace sstables {
 

sstables/scanning_clustered_index_cursor.hh

@@ -24,9 +24,12 @@
 #include "sstables/index_entry.hh"
 #include "sstables/promoted_index_blocks_reader.hh"
 #include "schema.hh"
+#include "log.hh"
 
 namespace sstables {
 
+extern logging::logger sstlog;
+
 // Cursor implementation which incrementally consumes promoted index entries
 // from an input stream.
 //

test/lib/index_reader_assertions.hh

@@ -26,6 +26,7 @@
 #include "dht/i_partitioner.hh"
 #include "schema.hh"
 #include "sstables/index_reader.hh"
+#include "reader_permit.hh"
 
 class index_reader_assertions {
     std::unique_ptr<sstables::index_reader> _r;

test/lib/reader_lifecycle_policy.hh

@@ -22,6 +22,7 @@
 #pragma once
 
 #include "mutation_reader.hh"
+#include <seastar/core/gate.hh>
 
 class test_reader_lifecycle_policy
         : public reader_lifecycle_policy

test/lib/select_statement_utils.hh

@@ -22,6 +22,7 @@
 #pragma once
 
 #include <seastar/core/future.hh>
+#include "seastarx.hh"
 
 namespace cql3 {
 

test/unit/bptree_validation.hh

@@ -21,6 +21,9 @@
 
 #pragma once
 
+#include <stddef.h>
+#include "utils/bptree.hh"
+
 namespace bplus {
 
 template <typename K, typename T, typename Less, size_t NodeSize>

test/unit/btree_validation.hh

@@ -21,6 +21,9 @@
 
 #pragma once
 
+#include <stddef.h>
+#include "utils/intrusive_btree.hh"
+
 namespace intrusive_b {
 
 class member_hook;

test/unit/collection_stress.hh

@@ -24,6 +24,7 @@
 #include <vector>
 #include <random>
 #include <string>
+#include <seastar/core/thread.hh>
 #include "utils/logalloc.hh"
 
 struct stress_config {

test/unit/radix_tree_printer.hh

@@ -22,6 +22,7 @@
 #pragma once
 
 #include <fmt/core.h>
+#include "utils/compact-radix-tree.hh"
 
 namespace compact_radix_tree {
 

test/unit/tree_test_key.hh

@@ -21,6 +21,10 @@
 
 #pragma once
 
+#include <fmt/core.h>
+#include <cassert>
+#include "utils/bptree.hh"
+
 /*
  * Helper class that helps to check that tree
  * - works with keys without default contstuctor

types/listlike_partial_deserializing_iterator.hh

@@ -25,6 +25,7 @@
 #include "cql_serialization_format.hh"
 #include "utils/fragment_range.hh"
 #include "utils/managed_bytes.hh"
+#include "types.hh"
 
 int read_collection_size(bytes_view& in, cql_serialization_format sf);
 bytes_view read_collection_value(bytes_view& in, cql_serialization_format sf);

utils/compact-radix-tree.hh

@@ -27,6 +27,7 @@
 #include <fmt/core.h>
 #include "utils/allocation_strategy.hh"
 #include "utils/array-search.hh"
+#include <boost/intrusive/parent_from_member.hpp>
 
 class size_calculator;
 

utils/fragment_range.hh

@@ -26,6 +26,7 @@
 #include <boost/range/algorithm/for_each.hpp>
 #include <seastar/net/byteorder.hh>
 #include <seastar/core/print.hh>
+#include <seastar/util/backtrace.hh>
 
 #include "marshal_exception.hh"
 #include "bytes.hh"

utils/histogram_metrics_helper.hh

@@ -23,6 +23,7 @@
 
 #pragma once
 
+#include <cstdint>
 #include <seastar/core/metrics_types.hh>
 #include "seastarx.hh"
 #include "estimated_histogram.hh"