partitioners: Make it impossible to use ByteOrderedPartitioner

ByteOrderedPartitioner has been deprecated for 2.5 year.
Now we drop the support for it. There are two reasons for this.
First, this partitioner can lead to uneven distribution of partitions
among the nodes in the cluster which leads to hot nodes.
Second, we're planning to unify the representation of tokens and
fix it as int64_t. ByteOrderPartitioner does not comply with this.

Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>

conf/scylla.yaml

@@ -289,7 +289,7 @@ batch_size_fail_threshold_in_kb: 50
 # same partitioner you were already using.
 #
 # Besides Murmur3Partitioner, partitioners included for backwards
-# compatibility include RandomPartitioner and ByteOrderedPartitioner.
+# compatibility include RandomPartitioner.
 #
 partitioner: org.apache.cassandra.dht.Murmur3Partitioner
 

db/config.cc

@@ -429,10 +429,9 @@ db::config::config(std::shared_ptr<db::extensions> exts)
         "Scylla provides the following partitioners for backwards compatibility:\n"
         "\n"
         "\tRandomPartitioner\n"
-        "\tByteOrderedPartitioner\n"
         "\n"
         "Related information: Partitioners"
-        , {"org.apache.cassandra.dht.Murmur3Partitioner", "org.apache.cassandra.dht.RandomPartitioner", "org.apache.cassandra.dht.ByteOrderedPartitioner"})
+        , {"org.apache.cassandra.dht.Murmur3Partitioner", "org.apache.cassandra.dht.RandomPartitioner"})
     , storage_port(this, "storage_port", value_status::Used, 7000,
         "The port for inter-node communication.")
     /* Advanced automatic backup setting */

test/boost/config_test.cc

@@ -154,7 +154,7 @@ permissions_validity_in_ms: 2000
 # same partitioner you were already using.
 #
 # Besides Murmur3Partitioner, partitioners included for backwards
-# compatibility include RandomPartitioner and ByteOrderedPartitioner.
+# compatibility include RandomPartitioner.
 #
 partitioner: org.apache.cassandra.dht.Murmur3Partitioner