cross-tree: allow std::source_location in clang 14

We recently (commit 6a5d9ff261) started
to use std::source_location instead of std::experimental::source_location.
However, this does not work on clang 14, because libc++ 12's
<source_location> only works if __builtin_source_location, and that is
not available on clang 14.

clang 15 is just three months old, and several relatively-recent
distributions still carry clang 14 so it would be nice to support it
as well.

So this patch adds a trivial compatibility header file, which, when
included and compiled with clang 14, it aliases the functional
std::experimental::source_location to std::source_location.

It turns out it's enough to include the new header file from three
headers that included <source_location> -  I guess all other uses
of source_location depend on those header files directly or indirectly.
We may later need to include the compatibility header file in additional
places, bug for now we don't.

Refs #12259

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

Closes #12265
This commit is contained in:
Nadav Har'El
2022-12-11 17:29:22 +02:00
committed by Avi Kivity
parent e6ffc22053
commit 09a3c63345
4 changed files with 27 additions and 0 deletions

View File

@@ -11,6 +11,7 @@
#include <unordered_set>
#include <functional>
#include <source_location>
#include "utils/source_location-compat.hh"
#include <boost/container/deque.hpp>
#include <seastar/core/lowres_clock.hh>
#include <seastar/core/future.hh>

View File

@@ -9,6 +9,7 @@
#pragma once
#include <source_location>
#include "utils/source_location-compat.hh"
#include <functional>
#include <seastar/core/sstring.hh>

View File

@@ -9,6 +9,7 @@
#pragma once
#include <source_location>
#include "utils/source_location-compat.hh"
#include <string>
#include <fmt/format.h>

View File

@@ -0,0 +1,24 @@
/*
* Copyright (C) 2022-present ScyllaDB
*/
/*
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
// Define std::source_location, introduced in clang 15, even in clang 14
// where it was called std::experimental::source_location.
//
// When we don't need to support clang 14 any more, this file and all
// its inclusions can be removed.
#pragma once
#if defined(__clang_major__) && __clang_major__ <= 14
#include <experimental/source_location>
namespace std {
using source_location = std::experimental::source_location;
}
#endif