react

Author	SHA1	Message	Date
Joe Savona	4573abc7e3	[compiler] Remove local CompilerError accumulators, emit directly to env.recordError() Removes unnecessary indirection in 17 compiler passes that previously accumulated errors in a local `CompilerError` instance before flushing them to `env.recordErrors()` at the end of each pass. Errors are now emitted directly via `env.recordError()` as they're discovered. For passes with recursive error-detection patterns (ValidateNoRefAccessInRender, ValidateNoSetStateInRender), the internal accumulator is kept but flushed via individual `recordError()` calls. For InferMutationAliasingRanges, a `shouldRecordErrors` flag preserves the conditional suppression logic. For TransformFire, the throw-based error propagation is replaced with direct recording plus an early-exit check in Pipeline.ts.	2026-02-21 13:08:10 -08:00
Joe Savona	deca1ebd8b	[compiler] Remove tryRecord, add catch-all error handling, fix remaining throws Remove `tryRecord()` from the compilation pipeline now that all passes record errors directly via `env.recordError()` / `env.recordErrors()`. A single catch-all try/catch in Program.ts provides the safety net for any pass that incorrectly throws instead of recording. Key changes: - Remove all ~64 `env.tryRecord()` wrappers in Pipeline.ts - Delete `tryRecord()` method from Environment.ts - Add `CompileUnexpectedThrow` logger event so thrown errors are detectable - Log `CompileUnexpectedThrow` in Program.ts catch-all for non-invariant throws - Fail snap tests on `CompileUnexpectedThrow` to surface pass bugs in dev - Convert throwTodo/throwDiagnostic calls in HIRBuilder (fbt, this), CodegenReactiveFunction (for-in/for-of), and BuildReactiveFunction to record errors or use invariants as appropriate - Remove try/catch from BuildHIR's lower() since inner throws are now recorded - CollectOptionalChainDependencies: return null instead of throwing on unsupported optional chain patterns (graceful optimization skip)	2026-02-21 13:07:26 -08:00
Joe Savona	3dc96d6a49	[compiler] Cleanup: consistent tryRecord() wrapping and error recording	2026-02-21 13:04:36 -08:00
Joe Savona	d371f07622	[compiler] Add fault tolerance test fixtures	2026-02-21 13:04:12 -08:00
Joe Savona	d401744f03	[compiler] Phase 3: Make lower() always produce HIRFunction	2026-02-21 13:04:10 -08:00
Joe Savona	f92560c498	[compiler] Phase 8: Add multi-error test fixture and update plan Add test fixture demonstrating fault tolerance: the compiler now reports both a mutation error and a ref access error in the same function, where previously only one would be reported before bailing out. Update plan doc to mark all phases as complete.	2026-02-21 13:03:56 -08:00
Joe Savona	bb174a5230	[compiler] Phase 4 (batch 2), 5, 6: Update remaining passes for fault tolerance Update remaining validation passes to record errors on env: - validateMemoizedEffectDependencies - validatePreservedManualMemoization - validateSourceLocations (added env parameter) - validateContextVariableLValues (changed throwTodo to recordError) - validateLocalsNotReassignedAfterRender (changed throw to recordError) - validateNoDerivedComputationsInEffects (changed throw to recordError) Update inference passes: - inferMutationAliasingEffects: return void, errors on env - inferMutationAliasingRanges: return Array<AliasingEffect> directly, errors on env Update codegen: - codegenFunction: return CodegenFunction directly, errors on env - codegenReactiveFunction: same pattern Update Pipeline.ts to call all passes directly without tryRecord/unwrap. Also update AnalyseFunctions.ts which called inferMutationAliasingRanges.	2026-02-21 13:03:54 -08:00
Joe Savona	70ae844c65	[compiler] Phase 4 (batch 1): Update validation passes to record errors on env Update 9 validation passes to record errors directly on fn.env instead of returning Result<void, CompilerError>: - validateHooksUsage - validateNoCapitalizedCalls (also changed throwInvalidReact to recordError) - validateUseMemo - dropManualMemoization - validateNoRefAccessInRender - validateNoSetStateInRender - validateNoImpureFunctionsInRender - validateNoFreezingKnownMutableFunctions - validateExhaustiveDependencies Each pass now calls fn.env.recordErrors() instead of returning errors.asResult(). Pipeline.ts call sites updated to remove tryRecord() wrappers and .unwrap().	2026-02-21 13:03:38 -08:00
Joe Savona	2bf8fa8e91	[compiler] Phase 2+7: Wrap pipeline passes in tryRecord for fault tolerance - Change runWithEnvironment/run/compileFn to return Result<CodegenFunction, CompilerError> - Wrap all pipeline passes in env.tryRecord() to catch and record CompilerErrors - Record inference pass errors via env.recordErrors() instead of throwing - Handle codegen Result explicitly, returning Err on failure - Add final error check: return Err(env.aggregateErrors()) if any errors accumulated - Update tryCompileFunction and retryCompileFunction in Program.ts to handle Result - Keep lint-only passes using env.logErrors() (non-blocking) - Update 52 test fixture expectations that now report additional errors This is the core integration that enables fault tolerance: errors are caught, recorded, and the pipeline continues to discover more errors.	2026-02-21 13:03:35 -08:00
Joe Savona	8593874f38	[compiler] Phase 1: Add error accumulation infrastructure to Environment Add error accumulation methods to the Environment class: - #errors field to accumulate CompilerErrors across passes - recordError() to record a single diagnostic (throws if Invariant) - recordErrors() to record all diagnostics from a CompilerError - hasErrors() to check if any errors have been recorded - aggregateErrors() to retrieve the accumulated CompilerError - tryRecord() to wrap callbacks and catch CompilerErrors	2026-02-21 13:01:33 -08:00
Joe Savona	00ae726dd3	[compiler] Add fault tolerance plan document Add detailed plan for making the React Compiler fault-tolerant by accumulating errors across all passes instead of stopping at the first error. This enables reporting multiple compilation errors at once.	2026-02-21 13:01:33 -08:00

2 changed files with 3 additions and 2 deletions

									
										1

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts
									
												View File
												
				@@ -738,6 +738,7 @@ function tryCompileFunction(

				  }

				}

				/**

				 * Applies React Compiler generated functions to the babel AST by replacing

				 * existing functions in place or inserting new declarations.

									
										4

compiler/packages/babel-plugin-react-compiler/src/Validation/ValidatePreservedManualMemoization.ts
									
												View File
												
				@@ -230,7 +230,7 @@ function validateInferredDep(

				  temporaries: Map<IdentifierId, ManualMemoDependency>,

				  declsWithinMemoBlock: Set<DeclarationId>,

				  validDepsInMemoBlock: Array<ManualMemoDependency>,

				  env: Environment,

				  errorState: Environment,

				  memoLocation: SourceLocation,

				): void {

				  let normalizedDep: ManualMemoDependency;

				@@ -280,7 +280,7 @@ function validateInferredDep(

				      errorDiagnostic = merge(errorDiagnostic ?? compareResult, compareResult);

				    }

				  }

				  env.recordError(

				  errorState.recordError(

				    CompilerDiagnostic.create({

				      category: ErrorCategory.PreserveManualMemo,

				      reason: 'Existing memoization could not be preserved',

Compare commits

11 Commits

pr35852 ... pr35838

1

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts

View File

4

compiler/packages/babel-plugin-react-compiler/src/Validation/ValidatePreservedManualMemoization.ts

View File

Compare commits

11 Commits pr35852 ... pr35838

1 compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts Unescape Escape View File

4 compiler/packages/babel-plugin-react-compiler/src/Validation/ValidatePreservedManualMemoization.ts Unescape Escape View File

11 Commits

pr35852 ... pr35838

1

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts

View File

4

compiler/packages/babel-plugin-react-compiler/src/Validation/ValidatePreservedManualMemoization.ts

View File