react

Author	SHA1	Message	Date
Joe Savona	cd207083ee	[compiler] Phase 8: Add multi-error test fixture and update plan Add test fixture demonstrating fault tolerance: the compiler now reports both a mutation error and a ref access error in the same function, where previously only one would be reported before bailing out. Update plan doc to mark all phases as complete.	2026-02-20 18:02:42 -08:00
Joe Savona	a6d3d93d4f	[compiler] Phase 4 (batch 2), 5, 6: Update remaining passes for fault tolerance Update remaining validation passes to record errors on env: - validateMemoizedEffectDependencies - validatePreservedManualMemoization - validateSourceLocations (added env parameter) - validateContextVariableLValues (changed throwTodo to recordError) - validateLocalsNotReassignedAfterRender (changed throw to recordError) - validateNoDerivedComputationsInEffects (changed throw to recordError) Update inference passes: - inferMutationAliasingEffects: return void, errors on env - inferMutationAliasingRanges: return Array<AliasingEffect> directly, errors on env Update codegen: - codegenFunction: return CodegenFunction directly, errors on env - codegenReactiveFunction: same pattern Update Pipeline.ts to call all passes directly without tryRecord/unwrap. Also update AnalyseFunctions.ts which called inferMutationAliasingRanges.	2026-02-20 18:02:42 -08:00
Joe Savona	821d6a8be2	[compiler] Phase 4 (batch 1): Update validation passes to record errors on env Update 9 validation passes to record errors directly on fn.env instead of returning Result<void, CompilerError>: - validateHooksUsage - validateNoCapitalizedCalls (also changed throwInvalidReact to recordError) - validateUseMemo - dropManualMemoization - validateNoRefAccessInRender - validateNoSetStateInRender - validateNoImpureFunctionsInRender - validateNoFreezingKnownMutableFunctions - validateExhaustiveDependencies Each pass now calls fn.env.recordErrors() instead of returning errors.asResult(). Pipeline.ts call sites updated to remove tryRecord() wrappers and .unwrap().	2026-02-20 18:01:44 -08:00
Joe Savona	966a5195ab	[compiler] Phase 2+7: Wrap pipeline passes in tryRecord for fault tolerance - Change runWithEnvironment/run/compileFn to return Result<CodegenFunction, CompilerError> - Wrap all pipeline passes in env.tryRecord() to catch and record CompilerErrors - Record inference pass errors via env.recordErrors() instead of throwing - Handle codegen Result explicitly, returning Err on failure - Add final error check: return Err(env.aggregateErrors()) if any errors accumulated - Update tryCompileFunction and retryCompileFunction in Program.ts to handle Result - Keep lint-only passes using env.logErrors() (non-blocking) - Update 52 test fixture expectations that now report additional errors This is the core integration that enables fault tolerance: errors are caught, recorded, and the pipeline continues to discover more errors.	2026-02-20 18:01:15 -08:00
Joe Savona	05243074f3	[compiler] Phase 1: Add error accumulation infrastructure to Environment Add error accumulation methods to the Environment class: - #errors field to accumulate CompilerErrors across passes - recordError() to record a single diagnostic (throws if Invariant) - recordErrors() to record all diagnostics from a CompilerError - hasErrors() to check if any errors have been recorded - aggregateErrors() to retrieve the accumulated CompilerError - tryRecord() to wrap callbacks and catch CompilerErrors	2026-02-20 17:57:42 -08:00
Joe Savona	056a8e127f	[compiler] Add fault tolerance plan document Add detailed plan for making the React Compiler fault-tolerant by accumulating errors across all passes instead of stopping at the first error. This enables reporting multiple compilation errors at once.	2026-02-20 17:57:41 -08:00

1 changed files with 0 additions and 1 deletions

									
										1

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts
									
												View File
												
				@@ -724,7 +724,6 @@ function tryCompileFunction(

				  }

				}

				/**

				 * Applies React Compiler generated functions to the babel AST by replacing

				 * existing functions in place or inserting new declarations.

Compare commits

6 Commits

pr35833 ... pr35845

1

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts

View File

Compare commits

6 Commits pr35833 ... pr35845

1 compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts Unescape Escape View File

6 Commits

pr35833 ... pr35845

1

compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts

View File