Paul O’Shannessy
3603d45157
v0.14.0
2015-10-07 10:19:56 -07:00
Paul O’Shannessy
0811e63e22
[docs] Update acknowledgements for 0.14
2015-10-07 10:16:55 -07:00
Paul O’Shannessy
3917c04f16
npm shrinkwrap
2015-10-07 10:01:04 -07:00
Paul O’Shannessy
c8374d6db8
Merge pull request #4785 from zpao/0.14-authors
...
Update AUTHORS for 0.14
2015-10-07 09:50:42 -07:00
Paul O’Shannessy
e2211ab826
Update AUTHORS for 0.14
2015-10-07 09:49:10 -07:00
Ben Alpert
55cab74312
Merge pull request #5072 from spicyj/14blog
...
0.14 blog post
2015-10-07 09:46:44 -07:00
Ben Alpert
2bedb4ae96
Write 0.14 blog post
2015-10-06 23:59:20 -07:00
Ben Alpert
e292df781e
Copy 0.14 RC blog post to 0.14 blog post
2015-10-06 23:19:50 -07:00
Ben Alpert
84dff0be5d
Fix bower info in RC blog post
...
Fixes #5054 .
2015-10-06 23:19:46 -07:00
Ben Alpert
1711c7aae3
Merge pull request #5065 from spicyj/docs-pkgs
...
Update some more docs for package split
2015-10-06 18:38:19 -07:00
Ben Alpert
26bde37cf8
Updat docs for refs/findDOMNode
2015-10-06 17:53:38 -07:00
Ben Alpert
0faf4b752f
Update some more docs for package split
2015-10-06 17:36:16 -07:00
Jim
ff533cb4db
Merge pull request #5055 from jimfb/reactdom-render
...
React -> ReactDOM for render() and findDOMNode()
2015-10-06 15:04:15 -07:00
Sebastian Markbåge
6d3a11e602
Merge pull request #4943 from bspaulding/throw-stateless-ref
...
Composite component throws on attaching ref to stateless component #4939
2015-10-06 14:33:48 -07:00
Jim
6446a45a00
Merge pull request #5062 from facebook/revert-4959-no-shams
...
Revert "Remove dependence on ES5 shams per #4189 "
2015-10-06 14:30:26 -07:00
Jim
571edd85c2
Revert "Remove dependence on ES5 shams per #4189 "
2015-10-06 14:30:03 -07:00
Jim
0b73099301
Merge pull request #4959 from dgreensp/no-shams
...
Remove dependence on ES5 shams per #4189
2015-10-06 13:57:49 -07:00
David Greenspan
f95747b929
Remove dependence on ES5 shams per #4189
...
Docs not updated
2015-10-06 13:49:47 -07:00
Bradley Spaulding
c6a3eb14db
Wrapping StatelessComponent ref warning in __DEV__ block
2015-10-05 21:44:42 -07:00
Jim
712199ef98
React -> ReactDOM for render() and findDOMNode()
2015-10-05 17:46:58 -07:00
Jim
870a15adec
Merge pull request #5056 from jimfb/reactdom-in-src
...
React->ReactDOM in src/
2015-10-05 16:30:25 -07:00
Jim
5a9dea00b9
React->ReactDOM in src/
2015-10-05 16:29:33 -07:00
Ben Alpert
94ccda8543
Merge pull request #5041 from spicyj/val-key-err
...
Don't blow up in key warning for undefined type
2015-10-05 13:57:25 -07:00
Paul O’Shannessy
d1065355a9
Merge pull request #5045 from CoderK/master
...
rename renderSubtreeIntoContainer.js to renderSubtreeIntoContainer-test.js
2015-10-03 07:57:26 -07:00
KimCoding
f316839b90
rename renderSubtreeIntoContainer.js to renderSubtreeIntoContainer-test.js
...
To distinguish between testing file and implementation file.
2015-10-03 18:11:48 +09:00
Ben Alpert
1959aaa1f9
Don't blow up in key warning for undefined type
2015-10-02 11:31:28 -07:00
Jim
a71a06077f
Merge pull request #5019 from jimfb/renderer-blog-post
...
Blog post for react render and top level API
2015-10-02 10:42:48 -07:00
Jim
e25753fdf1
Merge pull request #5038 from chicoxyzzy/docs-notation-fixes
...
make properties notation consistent over docs
2015-10-01 19:01:37 -07:00
chico
89e28a3fbe
make properties notation in docs consistent
2015-10-02 03:44:47 +03:00
Paul O’Shannessy
95c5491781
Merge pull request #5001 from claudiopro/master
...
[docs] Italian localization of documentation
2015-10-01 14:46:21 -07:00
claudiopro
a4ec19500a
Translate documentation to Italian
2015-10-01 23:40:14 +02:00
Paul O’Shannessy
9aa4546410
Merge pull request #5034 from zpao/fbjs-0.3
...
Update to fbjs@0.3
2015-10-01 14:33:40 -07:00
Paul O’Shannessy
693dd3567b
Update to fbjs@0.3
...
As far as we're concerned, the only difference is that we moved some files from React to fbjs.
2015-10-01 14:30:05 -07:00
Ben Alpert
2a51d1bf93
Merge pull request #5016 from spicyj/tu-stateless
...
Make scry* look through stateless components
2015-10-01 14:13:32 -07:00
Jim
c0f951665d
Blog post for react render and top level API
2015-10-01 14:12:01 -07:00
Sebastian Markbåge
4fa3ce48e8
Merge pull request #5021 from sebmarkbage/prototypetag
...
isReactClass -> .prototype.isReactComponent
2015-10-01 14:05:13 -07:00
Ben Alpert
3606702245
Merge pull request #5026 from chicoxyzzy/clarify-events-doc
...
clarify that events work for elements not for components
2015-10-01 10:49:25 -07:00
Jim
b53df5446e
Merge pull request #5029 from jabbrass/patch-1
...
[docs] Fix typo in videos.md
2015-10-01 10:38:39 -07:00
J. Andrew Brassington
32b8135f94
[docs] Fix typo in videos.md
...
Line 111: "integate" => "integrate".
Thanks to all core contribs for open sourcing such a great tool!
2015-10-01 09:38:02 -07:00
Jim
1c385c0484
Merge pull request #5025 from chicoxyzzy/fix-event-methods-notation
...
fix methods notation of SyntheticEvent in docs
2015-10-01 06:18:50 -07:00
chico
e6314641ce
fix isDefaultPrevented() and isPropagationStopped() methods of SyntheticEvent notation
2015-10-01 14:06:30 +03:00
chico
38a3150f62
clarify that events work for elements not for components
2015-10-01 14:00:05 +03:00
Jim
6dbdea15b2
Merge pull request #4964 from jimfb/stateless-functions-and-render-docs
...
Documentation for stateless functions/components, condensed two pages about refs into one
2015-09-30 20:59:29 -07:00
Jim
5ee8a93280
Added documentation for stateless components, condensed the two pages about refs into a single page.
2015-09-30 18:54:19 -07:00
Sebastian Markbage
83644185f4
isReactClass -> .prototype.isReactComponent
...
Put the flag on the prototype instead to help certain limited forms
of class extensions that doesn't properly transfer static properties.
Fixes #4836
2015-09-30 18:28:49 -07:00
Sebastian Markbåge
401e6f1058
Merge pull request #5020 from sebmarkbage/fixjestcli
...
Enforce NODE_ENV=test
2015-09-30 17:57:52 -07:00
Sebastian Markbage
41cba2e77b
Enforce NODE_ENV=test
...
You could make the argument that this should be optional, but it doesn't
work without it so we might as well just enforce it.
Makes `jest` work by default.
2015-09-30 17:43:06 -07:00
Ben Alpert
29fbbe7263
Merge pull request #5017 from spicyj/gh-5005
...
Fix dev/prod mismatch in context === bailout
2015-09-30 17:05:25 -07:00
Ben Alpert
3ad5419ce5
Merge pull request #5018 from spicyj/ev-l-bool
...
Don't throw for onClick={false} in initial render
2015-09-30 17:05:20 -07:00
Ben Alpert
2b63601472
Don't throw for onClick={false} in initial render
...
I accidentally regressed this in #3246 . Now this matches what we already checked for updates.
2015-09-30 16:53:47 -07:00
Ben Alpert
cf86cd8ebf
Fix dev/prod mismatch in context === bailout
...
Fixes #5005 .
2015-09-30 16:47:40 -07:00
Ben Alpert
7bd51659d6
Make scry* look through stateless components
...
Fixes #4882 .
2015-09-30 16:00:21 -07:00
Paul O’Shannessy
249e0f7331
Merge pull request #5008 from james4388/patch-3
...
Add missing comma (,) between propTypes and render
2015-09-30 14:34:08 -07:00
Paul O’Shannessy
45b63c55a0
Merge pull request #4736 from yhagio/patch-1
...
Update 02-displaying-data.ja-JP.md
2015-09-30 14:22:53 -07:00
Paul O’Shannessy
cf0e6dfae7
Merge pull request #4980 from edvinerikson/add-window-document-note
...
Added a note about needing document globally available
2015-09-30 11:08:29 -07:00
Edvin Erikson
f9417a5da1
Added a note about needing document globally available
...
Added a note in ``10.4-test-utils.md` about needing window, document and
document.createElement globally available before importing React.
2015-09-30 14:28:57 +02:00
Trinh Hoang Nhu
3c56146a44
Add missing comma (,) between propTypes and render
...
Add missing comma (,) between `propTypes` and `render`
2015-09-30 03:48:51 -05:00
Ben Alpert
5a4b92d8c5
Merge pull request #5003 from spicyj/gh-4996
...
Improve warning for old element objects
2015-09-29 22:52:08 -07:00
Ben Alpert
35f731b012
Merge pull request #5002 from spicyj/check-no-warn-jest
...
Fail jest tests on any un-spied warnings
2015-09-29 22:51:47 -07:00
Ben Alpert
d561949711
Improve warning for old element objects
...
Fixes #4996 .
2015-09-29 18:02:47 -07:00
Ben Alpert
b8c7b13042
Fail jest tests on any un-spied warnings
...
Originally #4223 -- we lost this when we switched to jest.
2015-09-29 17:35:39 -07:00
Ben Alpert
9a234e1d48
Merge pull request #4995 from gregrperkins/master
...
Rename TYPE_SYMBOL to REACT_ELEMENT_TYPE
2015-09-28 14:18:18 -07:00
Greg Perkins
c9320142ec
Rename TYPE_SYMBOL to REACT_ELEMENT_TYPE
...
See D2454031 for context.
2015-09-28 14:11:40 -07:00
Ben Alpert
c512603a8c
Merge pull request #4987 from spicyj/perf
...
Add unit test to ensure DOM mutations are instrumented
2015-09-28 11:48:18 -07:00
Paul O’Shannessy
1b5cd36f03
Merge pull request #4901 from zpao/npm-react-dom-dist
...
Build ReactDOM browser builds into react-dom/dist
2015-09-28 11:41:00 -07:00
Paul O’Shannessy
ed264b548b
Merge pull request #4953 from zpao/test-utils-scry
...
Make ReactTestUtils.scryRenderedComponentWithClass find multiple classes
2015-09-28 10:31:21 -07:00
Paul O’Shannessy
e9c571acc6
Make ReactTestUtils.scryRenderedComponentWithClass find multiple classes
2015-09-28 10:06:54 -07:00
Ben Alpert
013bf16501
Merge pull request #4985 from mbrookes/patch-1
...
Correct the CSS example for 'appear' transition
2015-09-27 16:23:09 -07:00
Ben Alpert
7938650ca9
Make new perf unit test pass
2015-09-27 14:26:26 -07:00
Ben Alpert
47de0a8ce6
Add unit test to ensure DOM mutations are instrumented
2015-09-27 14:26:01 -07:00
Matt
208f20b787
Correct the CSS example for 'appear' transition
...
Move transition from `.example-appear` to `.example-appear.example-appear-active`
2015-09-27 17:33:16 +01:00
cpojer
2c973796e3
Add trailing commas to react-codemod output by default.
2015-09-26 22:58:45 +02:00
Paul O’Shannessy
ce8fed7592
Merge pull request #4893 from jw-00000/patch-1
...
Fix documentation of behavior of v0.12 and v0.13
2015-09-26 10:46:07 -07:00
JW
3b6697f177
Fix documentation of event propagation: 0.13 to 0.14
2015-09-26 12:31:48 +02:00
Vipul A M
1d4371a1d2
[docs] Replace JSXTransformer with babel/browser
...
Closes #4131
2015-09-25 20:13:19 -07:00
Paul O’Shannessy
d3d2504e72
Merge pull request #4846 from zpao/docs-use-babel
...
[docs] Remove references to react-tools, JSXTransformer, replace with Babel.
2015-09-25 20:06:47 -07:00
Paul O’Shannessy
105554fe5c
[docs] Remove JSXTransformer, react-tools from downloads page
2015-09-25 17:58:07 -07:00
Paul O’Shannessy
bef8942cb7
[docs] Remove JSXTransformer from tutorial
2015-09-25 17:58:07 -07:00
Paul O’Shannessy
4d9c1d1126
[docs] Update script mimetypes: text/jsx -> text/babel
2015-09-25 17:56:42 -07:00
Paul O’Shannessy
097b32b7d2
[docs] Remove mentions of react-tools/jsx command
2015-09-25 17:56:42 -07:00
Paul O’Shannessy
411ed31cb1
[docs] Stop supporting our JSX compiler page
...
Link to Babel REPL directly instead.
2015-09-25 17:56:42 -07:00
Paul O’Shannessy
6ff4ba9512
Merge pull request #4978 from zpao/tutorial-server
...
[docs] Make the server required for the tutorial
2015-09-25 17:54:47 -07:00
Paul O’Shannessy
a440f40713
[docs] Make the server required for the tutorial
2015-09-25 17:52:45 -07:00
Bradley Spaulding
63cfcca74e
Updated stateless ref warning message with more info
2015-09-25 16:21:59 -07:00
Ben Alpert
59466a0b52
Merge pull request #4977 from spicyj/gh-4870
...
Actually don't store <input> until mount-ready
2015-09-25 13:41:45 -07:00
Ben Alpert
6e62a010dd
Actually don't store <input> until mount-ready
...
So #4976 was a lie. Fixes #4870 for real (thanks @STRML).
2015-09-25 13:39:05 -07:00
Ben Alpert
b82f3ab55d
Merge pull request #4976 from spicyj/gh-4870
...
Don't store <input> instance until mount-ready
2015-09-25 13:30:01 -07:00
Ben Alpert
c04d10f033
Don't store <input> instance until mount-ready
...
Fixes #4870 .
This more or less matches what we were doing with the old wrapper components (not storing until componentDidMount).
2015-09-25 13:20:40 -07:00
Ben Alpert
c05a6570ec
Merge pull request #4975 from spicyj/gh-3285
...
Don't blow up on missing _store in element validation
2015-09-25 13:11:40 -07:00
Ben Alpert
e352475ddc
Don't blow up on missing _store in element validation
...
Seems better to fail gracefully, especially now that we support inlining. If people do this by accident we can figure out how to add a helpful warning instead.
Fixes #3285 .
2015-09-25 13:09:03 -07:00
Paul O’Shannessy
530b6332ed
Merge pull request #4973 from zpao/lint-again
...
[lint] Update and fix
2015-09-25 13:05:38 -07:00
Paul O’Shannessy
7037ef9d8b
[lint] Update and fix
2015-09-25 12:32:51 -07:00
Jim
4215002200
Merge pull request #4965 from iamchenxin/translate
...
[docs] Update zh-CN docs.
2015-09-25 11:34:05 -07:00
Jim
3936e3fddb
Merge pull request #4967 from zhangjg/zhangjg-br
...
Translation 08.1-more-about-ref.md to Chinese
2015-09-25 11:33:36 -07:00
Sebastian Markbåge
8854a31e31
Merge pull request #4942 from darobin/rdfa-attributes
...
Add RDFa attributes not already covered (fixes #3459 )
2015-09-25 09:32:40 -07:00
zhangjg
1dbde787d0
Published with https://stackedit.io/
2015-09-25 09:34:37 +08:00
Paul O’Shannessy
707ffc74fd
Merge pull request #4966 from zpao/examples-rm-server-rendering
...
[examples] Remove Server Rendering Example
2015-09-24 18:06:07 -07:00
iamchenxin
6094739757
[docs] Update zh-CN docs
...
Update
09-tooling-integration.zh-CN.md
10-addons.zh-CN.md
10.1-animation.zh-CN.md
2015-09-25 06:55:34 +08:00
Paul O’Shannessy
c529e652bd
[examples] Remove Server Rendering
2015-09-24 15:12:15 -07:00
Paul O’Shannessy
99b9ece565
Merge pull request #4914 from zpao/0.14-examples
...
Update examples for Babel, 0.14; remove 3rd party code
2015-09-24 15:11:40 -07:00
Paul O’Shannessy
3c0f46e3da
[examples] Use refs instead of findDOMNode
2015-09-24 15:08:28 -07:00
Paul O’Shannessy
145ca279f9
[examples] Update basic-commonjs for new React, watchify
2015-09-24 15:08:28 -07:00
Paul O’Shannessy
f1ede3e6d2
[examples] Fix transtion example with timeout prop
2015-09-24 15:08:28 -07:00
Paul O’Shannessy
c475699d6b
[examples] Use ReactDOM for appropriate APIs
2015-09-24 15:08:28 -07:00
Paul O’Shannessy
715dea085b
[examples] Use Babel
2015-09-24 15:08:27 -07:00
Paul O’Shannessy
4d3d14af78
[exmaples] Remove local 3rd party code, use CDN (mostly)
2015-09-24 14:57:50 -07:00
Paul O’Shannessy
16608e3688
[examples] Assume es5 compatible browsers with console
2015-09-24 14:57:50 -07:00
Paul O’Shannessy
78b50485f6
Merge pull request #4853 from zpao/jsfiddle-babel
...
[docs] Add jsfiddle integration for Babel
2015-09-24 14:54:13 -07:00
iamchenxin
3fd7686d22
[docs] Update zh-CN docs.
...
add 08.1-more-about-refs.zh-CN.md
2015-09-25 03:11:58 +08:00
Bradley Spaulding
af79118148
attachRef to a stateless component warns instead of throwing #4939
2015-09-24 11:52:46 -07:00
Bradley Spaulding
8b4663d722
Renamed componentInstance to publicComponentInstance
2015-09-24 11:46:41 -07:00
Paul O’Shannessy
4b6e5d06cf
Merge pull request #4961 from iamchenxin/en_docs
...
[docs] Fix syntac error
2015-09-24 09:48:34 -07:00
iamchenxin
82637eae45
Fix syntac error
...
Split {{ in example code to avoid an Exception in jekyll.
> Liquid Exception: Variable '{{' was not properly terminated with regexp: /\}\}/ in docs/10.1-animation.md
2015-09-24 23:46:22 +08:00
Jim
f988511b0a
Merge pull request #4960 from iamchenxin/translate
...
[docs] Sync up zh-CN docs
2015-09-24 08:03:14 -07:00
iamchenxin
7a316ab034
[docs] Sync up zh-CN docs
...
Sync up with current en docs.
2015-09-24 22:48:20 +08:00
Paul O’Shannessy
1ce5ba4c56
Merge pull request #4956 from reggi/patch-1
...
doc: typo existant to existent
2015-09-24 01:35:28 -07:00
Thomas Reggi
648cb52b72
doc: typo existant to existent
2015-09-23 19:56:26 -04:00
Paul O’Shannessy
d12ec60dd5
Merge pull request #4658 from zpao/iojs
...
Upgrade to node@4, jest@0.5
2015-09-23 14:01:48 -07:00
Paul O’Shannessy
873e3a9816
Cleanup Jest preprocessor, use cache key
2015-09-23 13:46:41 -07:00
Paul O’Shannessy
8857e12c9e
Use main document for getTestDocument
...
This should be fine in a jest environment, which is all we really care about now.
2015-09-23 13:46:41 -07:00
Paul O’Shannessy
2afc9a445f
Upgrade to node@4, jest@0.5
2015-09-23 13:46:41 -07:00
Ben Alpert
ab03f34965
Merge pull request #4951 from spicyj/gh-4840
...
Improve traverseAllChildren object error message
2015-09-23 12:17:35 -07:00
Ben Alpert
1922db1711
Improve traverseAllChildren object error message
...
Fixes #4840 .
2015-09-23 12:17:20 -07:00
Paul O’Shannessy
33e44f041b
Merge pull request #4944 from zpao/rm-event-path
...
Remove SyntheticEvent.path
2015-09-23 10:03:19 -07:00
Ben Alpert
7398606ccf
Merge pull request #4683 from JaeHunRo/master
...
temporarily fixes printWasted abnormality
2015-09-23 00:34:51 -07:00
Paul O’Shannessy
96b3ef54bf
Merge pull request #4935 from saifelse/fix-firefox-dom-sel
...
Fix ReactDOMSelection to avoid erroring on Firefox's anonymous divs
2015-09-22 17:57:24 -07:00
JaeHunRo
6244a985c4
updates printWasted
2015-09-23 01:46:31 +01:00
Ben Alpert
b06be9bc2d
Merge pull request #4946 from spicyj/nan
...
Improve error for style mutation
2015-09-22 16:34:05 -07:00
Ben Alpert
9faf1f3969
Improve error for style mutation
...
Fixes #4877 . I opted not to change shallowEqual for this since it seems relatively one-off.
2015-09-22 16:29:40 -07:00
Ben Alpert
8c75e792ab
Merge pull request #4945 from spicyj/nocatch-sim
...
Don't use magic browser event dispatching for simulated events
2015-09-22 15:41:00 -07:00
Ben Alpert
838b963f55
Merge pull request #4916 from spicyj/hwc
...
Add perf-counters npm module to scripts
2015-09-22 15:39:56 -07:00
Ben Alpert
57c516cb0e
Don't use magic browser event dispatching for simulated events
...
When calling ReactTestUtils.Simulate, sometimes you want to test that an exception is thrown by the event handler. This lets you do that without relying on the fact that old jsdom doesn't implement `Event`.
2015-09-22 15:31:08 -07:00
Saif Hakim
0267cfbb8f
Fix ReactDOMSelection to avoid erroring on Firefox's anonymous divs
2015-09-22 15:28:33 -07:00
Paul O’Shannessy
8a837cbd3f
Remove SyntheticEvent.path
2015-09-22 15:12:19 -07:00
Ben Alpert
0f67febad7
Merge pull request #3069 from WickyNilliams/patch-1
...
document checkbox using click handlers for change events
2015-09-22 14:34:40 -07:00
Bradley Spaulding
650fa58ab9
Composite component throws on attaching ref to stateless component #4939
2015-09-22 14:28:38 -07:00
Robin Berjon
fd682b5cac
add RDFa attributes not already covered
2015-09-22 16:58:48 -04:00
Paul O’Shannessy
06568114f3
Merge pull request #4931 from bspaulding/safe-taint-docs
...
Extracted "safe taint" in docs/homepage to align with best practice
2015-09-22 10:53:50 -07:00
Ben Alpert
c561324e7e
Merge pull request #4903 from spicyj/event-unmounted
...
Just ignore events on unmounted components
2015-09-22 09:54:04 -07:00
Bradley Spaulding
52d8d3b2ff
Extracted "safe taint" in docs/homepage to align with best practice #4212
2015-09-21 22:24:51 -07:00
Paul O’Shannessy
56ccd82374
Merge pull request #4921 from benjaffe/master
...
[docs] Clarify when autobinding does(n't) happens
2015-09-20 16:42:48 -07:00
Ben Jaffe
0203071251
Update 03-interactivity-and-dynamic-uis.md
...
This clarifies when autobinding does and does not happen. I spun my wheels on this for a while.
https://medium.com/@goatslacker/react-0-13-x-and-autobinding-b4906189425d
2015-09-20 09:38:50 -07:00
Ben Alpert
b3bccf2273
Add node bindings
2015-09-19 11:30:28 -07:00
Ben Alpert
e922f869e6
Make hardware-counter.cpp compile
...
`g++ -std=c++11 -lpthread src/hardware-counter.cpp
src/thread-local.cpp src/test.cpp` works and runs where `src/test.cpp` is:
```
int main() {
bool enable = true;
std::string events = "";
bool recordSubprocesses = false;
HPHP::HardwareCounter::Init(enable, events, recordSubprocesses);
HPHP::HardwareCounter::s_counter.getCheck();
int64_t start = HPHP::HardwareCounter::GetInstructionCount();
volatile int x;
for (int i = 0; i < 1000000; i++) {
x += i;
}
int64_t end = HPHP::HardwareCounter::GetInstructionCount();
printf("%d\n", end - start);
}
```
2015-09-19 11:00:27 -07:00
Ben Alpert
42e523ea4d
Update license to match React repo license
2015-09-19 11:00:27 -07:00
Ben Alpert
cfbf115b26
Add hardware-counter.cpp and deps from HHVM
2015-09-18 22:10:10 -07:00
Paul O’Shannessy
ff542de59d
Build ReactDOM browser builds into react-dom/dist
2015-09-18 14:02:31 -07:00
Ben Alpert
88cdc27618
Merge pull request #4904 from spicyj/npm-2
...
Don't install npm 3 on Travis
2015-09-17 21:23:41 -07:00
Ben Alpert
45f85a6cc5
Just ignore events on unmounted components
...
Fixes #4865 and also seems to fixes #3790 .
2015-09-17 17:42:01 -07:00
Ben Alpert
41e4bfb41a
Don't install npm 3 on Travis
2015-09-17 17:37:00 -07:00
Paul O’Shannessy
aac4219e80
Merge pull request #4899 from iamchenxin/master
...
Update zh-CN docs.
2015-09-17 12:22:04 -07:00
iamchenxin
2a5e6b3c91
Update zh-CN translation.
...
To keep up with en docs.
2015-09-18 02:31:11 +08:00
Paul O’Shannessy
e147c4942b
[docs] Remove unused file
2015-09-16 14:09:52 -07:00
Paul O’Shannessy
d42254c40f
Merge pull request #4891 from igncp/documentation-fix
...
Fix documentation errata
2015-09-16 13:48:09 -07:00
Ignacio Carbajo
e11631eea7
Fix documentation errata
2015-09-16 22:25:46 +02:00
Paul O’Shannessy
f9bbc06960
Merge pull request #4858 from zpao/eslint-1.4
...
Upgrade eslint to 1.4.1
2015-09-16 12:35:12 -07:00
Paul O’Shannessy
20f0b0f464
Upgrade eslint to 1.4.1
2015-09-16 12:16:46 -07:00
Paul O’Shannessy
0fb49fc4dc
Merge pull request #4859 from zpao/stateless-arrow-functions
...
Support native arrow functions as stateless components
2015-09-16 12:02:38 -07:00
Paul O’Shannessy
e5c3fb14fa
Support arrow functions as stateless components
2015-09-16 11:39:41 -07:00
Ben Alpert
2db38bf935
Merge pull request #4887 from spicyj/form-proptypes-dev
...
Check input and textarea propTypes only in DEV
2015-09-16 11:31:08 -07:00
Ben Alpert
65370ff752
Check input and textarea propTypes only in DEV
2015-09-15 21:46:37 -07:00
Paul O’Shannessy
a48ffb04dc
Merge pull request #4884 from moretti/patch-1
...
[docs] Fix syntax errors in Animation
2015-09-15 11:30:20 -07:00
Paolo Moretti
fb45ef3679
Fix syntax errors
2015-09-15 18:12:42 +01:00
Paul O’Shannessy
609f14eed4
Merge pull request #4874 from brigand/patch-6
...
Clarifies "Fetching from the server"
2015-09-14 20:42:54 -07:00
Frankie Bagnardi
584a7c5f1c
Clarifies "Fetching from the server"
2015-09-14 20:21:52 -07:00
Paul O’Shannessy
0bb906ed8c
Merge pull request #4829 from zpao/docs-jekyll-feed
...
[docs] Use a generator to assign complete author data before generating site
2015-09-14 20:18:27 -07:00
Paul O’Shannessy
b0bf35a361
[docs] Use a generator to assign complete author data before generating site
...
This makes sure that `post.author` will be the actual data we want and we don't have to assign it every time, potentially messing it up.
2015-09-14 19:55:01 -07:00
Paul O’Shannessy
e97da42b67
Merge pull request #4868 from AnSavvides/docs-readability
...
Make docs more consistent
2015-09-14 13:10:57 -07:00
Paul O’Shannessy
b53dfa6d27
Merge pull request #4869 from arush/patch-1
...
DOCS - typo in ref callback example
2015-09-14 11:42:08 -07:00
arush
29551f84b8
DOCS - typo in ref callback example
...
deleted extra ending curly brace in arrow function
2015-09-14 11:40:44 -07:00
Christoph Pojer
95eee11b66
Merge pull request #4866 from andrewsokolov/bug/--no-explicit-require-didnt-works
...
[react-codemod] --no* options automatically set to false
2015-09-14 11:05:19 -07:00
Andreas Savvides
e04602f8ee
Use same type of markdown as everywhere else for Glossary
2015-09-14 18:55:34 +01:00
Andreas Savvides
3c5a91c3c3
Make it easier to create an issue
2015-09-14 18:45:29 +01:00
Andreas Savvides
c207ab2901
Make "Component Specs and Lifecycle" more readable
2015-09-14 18:43:16 +01:00
Andreas Savvides
f98112f24d
Make "Component API" more readable
2015-09-14 18:23:00 +01:00
Steven Luscher
15b57b1658
Merge pull request #4845 from steveluscher/community-roundup-27-relay-edition
...
Community Roundup #27 – Relay Edition
2015-09-14 08:14:43 -07:00
andrewsokolov
0610fd93b4
--no* options automatically set to false
2015-09-14 17:30:25 +03:00
Steven Luscher
f30b0d1f1c
Community Roundup #27 – Relay Edition
2015-09-13 21:26:34 -07:00
Paul O’Shannessy
0cc8af37c3
Merge pull request #4861 from zpao/symbol-test-node4
...
Better simulate Symbol-less environment
2015-09-13 13:55:26 -07:00
Paul O’Shannessy
d54fa9e563
Better simulate Symbol-less environment
...
This ensures that our tests expecting Symbol not to exist pass.
2015-09-13 13:15:26 -07:00
Jim
2fcf54939b
Merge pull request #4855 from iamchenxin/master
...
Maintain why-react-zh-CN sync to the current why-react
2015-09-12 08:57:31 -07:00
iamchenxin
d92f4782ac
Update translation for jsx-in-depth-zh-CN
2015-09-12 18:09:58 +08:00
iamchenxin
787b49ae78
Maintain why-react-zh-CN sync to the current why-react
2015-09-12 16:29:46 +08:00
Paul O’Shannessy
4a45ad38b3
[docs] Add jsfiddle integration for Babel
2015-09-11 11:19:23 -07:00
Paul O’Shannessy
ed11f83763
Merge pull request #4833 from youngminz/master
...
Update Korean translation
2015-09-10 16:25:58 -07:00
Paul O’Shannessy
c6ecda7503
Merge pull request #4802 from 8398a7/patch-1
...
Update Japanese translation to 75fafe1
2015-09-10 15:35:06 -07:00
839
852753c13a
Update Japanese translation to 75fafe1
2015-09-10 15:33:34 -07:00
Ben Alpert
4b3b56f36a
Add Babel version to blog post
2015-09-10 13:28:46 -07:00
Ben Alpert
04e5ee70cc
Merge pull request #4797 from spicyj/rc14blog
...
0.14 RC blog post
2015-09-10 09:50:56 -07:00
Ben Alpert
5bf56134be
0.14 RC blog post
2015-09-10 09:21:56 -07:00
Ben Alpert
4a4174b9e8
0.14.0-rc1
2015-09-10 08:47:40 -07:00
Ben Alpert
21a1f7e6fd
Don't copy JSXTransformer in grunt release
2015-09-10 08:47:40 -07:00
Paul O’Shannessy
31f25255b9
Stop building JSXTransformer
...
Pick of/closes #4148 .
2015-09-10 08:45:04 -07:00
Koo Youngmin
2ae036123c
Update Korean translation
2015-09-10 16:47:15 +09:00
Sebastian Markbåge
7a00239b1f
Merge pull request #4832 from sebmarkbage/xssfix
...
Use a Symbol to tag every ReactElement
2015-09-09 23:19:33 -07:00
Sebastian Markbage
031fc24dae
Use a Symbol to tag every ReactElement
...
Fixes #3473
I tag each React element with `$$typeof: Symbol.for('react.element')`. We need
this to be able to safely distinguish these from plain objects that might have
come from user provided JSON.
The idiomatic JavaScript way of tagging an object is for it to inherent some
prototype and then use `instanceof` to test for it.
However, this has limitations since it doesn't work with value types which
require `typeof` checks. They also don't work across realms. Which is why there
are alternative tag checks like `Array.isArray` or the `toStringTag`. Another
problem is that different instances of React that might have been created not knowing about eachother. npm tends to make this kind of problem occur a lot.
Additionally, it is our hope that ReactElement will one day be specified in
terms of a "Value Type" style record instead of a plain Object.
This Value Types proposal by @nikomatsakis is currently on hold but does satisfy all these requirements:
https://github.com/nikomatsakis/typed-objects-explainer/blob/master/valuetypes.md#the-typeof-operator
Additionally, there is already a system for coordinating tags across module
systems and even realms in ES6. Namely using `Symbol.for`.
Currently these objects are not able to transfer between Workers but there is
nothing preventing that from being possible in the future. You could imagine
even `Symbol.for` working across Worker boundaries. You could also build a
system that coordinates Symbols and Value Types from server to client or through
serialized forms. That's beyond the scope of React itself, and if it was built
it seems like it would belong with the `Symbol` system. A system could override
the `Symbol.for('react.element')` to return a plain yet
cryptographically random or unique number. That would allow ReactElements to
pass through JSON without risking the XSS issue.
The fallback solution is a plain well-known number. This makes it unsafe with
regard to the XSS issue described in #3473 . We could have used a much more
convoluted solution to protect against JSON specifically but that would require
some kind of significant coordination, or change the check to do a
`typeof element.$$typeof === 'function'` check which would not make it unique to
React. It seems cleaner to just use a fixed number since the protection is just
a secondary layer anyway. I'm not sure if this is the right tradeoff.
In short, if you want the XSS protection, use a proper Symbol polyfill.
Finally, the reason for calling it `$$typeof` is to avoid confusion with `.type`
and the use case is to add a tag that the `typeof` operator would refer to.
I would use `@@typeof` but that seems to deopt in JSC. I also don't use
`__typeof` because this is more than a framework private. It should really be
part of the polyfilling layer.
2015-09-09 23:19:00 -07:00
Ben Alpert
a05691f0ad
Merge pull request #4747 from spicyj/gh-1939
...
Don't crash in event handling when mixing React copies
2015-09-09 22:10:19 -07:00
Ben Alpert
dc2570e1ce
Merge pull request #4825 from spicyj/gh-2770
...
Preserve DOM node when updating empty component
2015-09-09 22:09:34 -07:00
Ben Alpert
14ede77123
Merge pull request #4827 from spicyj/occured
...
occured -> occurred
2015-09-09 16:29:43 -07:00
Ben Alpert
0b857a473a
occured -> occurred
2015-09-09 16:19:40 -07:00
Ben Alpert
db589a7175
Preserve DOM node when updating empty component
...
Fixes #2770 .
2015-09-09 14:00:59 -07:00
Ben Alpert
999b0f9b3e
Refactor empty component handling
...
Now doesn't use ReactCompositeComponent and `._currentElement` is actually null/false.
2015-09-09 14:00:58 -07:00
Ben Alpert
3dbdb63a7d
Merge pull request #4823 from spicyj/gh-4776
...
Don't try to iterate over non-objects
2015-09-09 12:55:20 -07:00
Ben Alpert
35b7fe175d
Merge pull request #4821 from spicyj/dom-dist
...
Add react-dom to dist/ in npm package
2015-09-09 12:02:47 -07:00
Paul O’Shannessy
12b6f3d03c
Merge pull request #4824 from facebook/prefill-stack-overflow-tag
...
Pre-fill tag when asking a Stack Overflow question
2015-09-09 11:31:00 -07:00
Steven Luscher
9ca4dd6024
Pre-fill tag when asking a Stack Overflow question
2015-09-09 11:28:14 -07:00
Ben Alpert
b004bc5f22
Don't try to iterate over non-objects
...
Fixes #4776 .
2015-09-09 09:03:05 -07:00
Ben Alpert
a87c8555fa
Merge pull request #4719 from djrodgerspryor/fix_css_transition_group_child_props
...
Fix transitionName prop-type on CSS transition group child
Closes #4719 .
2015-09-09 08:35:44 -07:00
Ben Alpert
324bec17e3
Fix up style in #4719
2015-09-09 08:35:04 -07:00
Ben Alpert
0cce198c28
Merge pull request #4796 from spicyj/lazy-node
...
Fetch DOM node lazily for updates
2015-09-09 08:29:56 -07:00
Ben Alpert
cdd8096974
Add react-dom to dist/ in npm package
2015-09-09 07:58:28 -07:00
Daniel Rodgers-Pryor
91555f6f9e
Fix name prop-type on CSS transition group child
...
And share it with the parent. There's now a test for varying class names by transition-type.
2015-09-09 23:21:15 +10:00
Paul O’Shannessy
6eda65209a
Merge pull request #4818 from gdi2290/patch-1
...
Fix typo combatibility => compatibility
2015-09-09 00:52:19 -07:00
PatrickJS
ab0c84f53f
Fix typo combatibility => compatibility
2015-09-09 00:47:01 -07:00
Paul O’Shannessy
77703dbb80
Merge pull request #4724 from AnSavvides/test-util-readability
...
Make definitions more readable & optional params more obvious
2015-09-09 00:02:18 -07:00
Paul O’Shannessy
011c2a2e07
Merge pull request #4793 from edvinerikson/document-svg-attributes
...
[docs] Updated SVG attributes
2015-09-08 23:24:54 -07:00
Paul O’Shannessy
2f1b08347c
Fix lint warning in react-dom codemod
2015-09-08 23:06:25 -07:00
Paul O’Shannessy
b5b74c5f22
Fix travis cURL call
2015-09-08 22:56:59 -07:00
Paul O’Shannessy
69ab7145bc
Merge pull request #4814 from zpao/build-react-dom-browser-2
...
Build react dom browser 2
2015-09-08 22:33:08 -07:00
Paul O’Shannessy
3e672017a7
Upload new build files to build server
2015-09-08 22:18:45 -07:00
Paul O’Shannessy
353a01cf5e
Add react-dom to bower when releasing
2015-09-08 22:18:44 -07:00
Paul O’Shannessy
b2ca3349c2
Actually build react-dom file with the build
2015-09-08 22:18:44 -07:00
Paul O’Shannessy
135c554b23
Move headers to shared location, use grunt templates
2015-09-08 22:00:05 -07:00
Ben Alpert
e7ce46ff28
Don't crash in event handling when mixing React copies
...
Should fix #1939 .
Test Plan:
With two copies of React, render a div using React1 and use that as a container to render a div with React2. Add onMouseEnter/onMouseLeave to both divs that log. Mouse around and see correct logs (as if each React was isolated), no errors.
2015-09-08 17:40:20 -07:00
Paul O’Shannessy
c0270a1673
Merge pull request #4798 from zpao/pull-out-version
...
Move version to standalone module in preparation for reuse
2015-09-08 16:30:05 -07:00
Ben Alpert
27996377e0
Fetch DOM node lazily for updates
...
Previously, we fetched the node once for every changed attribute. In my createElement diff, I changed it to fetch the node (once) regardless of if there were changes -- fetching it once only if there are changes is even better.
2015-09-08 14:53:41 -07:00
Paul O’Shannessy
58d62989bd
Move version to standalone module in preparation for reuse
2015-09-08 10:18:41 -07:00
Ben Alpert
b01af40ae6
Merge pull request #4663 from spicyj/isreactclass
...
Require instantiable components to extend React.Component
2015-09-08 10:01:15 -07:00
Ben Alpert
f3b7749c37
Require instantiable components to extend React.Component
2015-09-08 10:01:13 -07:00
Paul O’Shannessy
2fa59aa2d2
Merge pull request #4787 from Simek/patch-5
...
simplify valid attribute regex in DOMPropertyOperations
2015-09-04 17:42:32 -07:00
Ben Alpert
be36dbd88d
Merge pull request #4786 from jontewks/master
...
Resolve eslint error
2015-09-04 17:35:02 -07:00
Jon Tewksbury
87963c4d01
Resolve eslint error
2015-09-04 17:31:12 -07:00
Ben Alpert
4fb7df1733
Merge pull request #4767 from spicyj/com
...
Add react-to-react-dom codemod
2015-09-04 13:55:04 -07:00
Edvin Erikson
a3b0b7ca25
[docs] Updated SVG attributes
...
Added all properties listed in the SVGDOMPropertyConfig.js file to the SVG attributes
section in the docs.
2015-09-04 18:26:47 +02:00
Jim
48942b85ea
Merge pull request #4788 from jontewks/html-attribute-docs
...
Update docs to match standard HTML attribute support
2015-09-04 03:04:58 -07:00
Jon Tewksbury
f445dd91b0
Update docs to match standard HTML attribute support
2015-09-03 22:59:29 -07:00
Bartosz Kaszubowski
f99c83ba06
simplify valid attribute regex in DOMPropertyOperations
2015-09-04 07:41:19 +02:00
cpojer
cfe0351b8f
Do not codemod classes with invalid fields, fixes #4628
2015-09-03 17:04:19 -07:00
Ben Alpert
10ab0c8915
Merge pull request #2065 from crm416/container-warnings
...
Warn when passing invalid containers to render and unmountComponentAtNode
2015-09-03 17:00:55 -07:00
Ben Alpert
9d93693b2e
Update wording and style for #2065
2015-09-03 17:00:16 -07:00
Charles Marsh
270a805369
Warn when passing invalid containers to render and unmountComponentAtNode
2015-09-03 17:00:11 -07:00
Ben Alpert
4139b2e223
Merge pull request #3942 from spicyj/el-plain-obj
...
Make ReactElement really a plain object and freeze it
2015-09-03 15:02:56 -07:00
Ben Alpert
750338ef47
Make ReactElement really a plain object
...
This should guarantee that the hidden class is the same after inlining.
2015-09-03 14:58:52 -07:00
Ben Alpert
189f42f56a
Merge pull request #4781 from jontewks/master
...
Add console message to get devtools for firefox
2015-09-03 14:26:37 -07:00
Jon Tewksbury
a4bd998edc
Update console messages regarding devtools
2015-09-03 14:16:26 -07:00
Paul O’Shannessy
341f26a662
Add insert_final_newline to editorconfig
2015-09-03 13:43:42 -07:00
Paul O’Shannessy
ea8e06283c
Merge pull request #4780 from matchu/patch-1
...
avoid the phrase "key property"
2015-09-03 12:50:36 -07:00
matchu
6541903bc4
avoid the phrase "key property"
...
React components can be assigned a special property named `key`. Therefore, it's helpful to avoid the phrase "key property" unless you're talking about the `key` property :)
I'm not sold on the replacement phrase, though... I think it's solid, but two fancy words like "fundamental" and "invariant" next to each other just seem a bit unwelcoming xP then again, we're talking about some heavy technical stuff; if there aren't any lighter words that are equally precise, then these should probably stand.
2015-09-03 12:03:15 -07:00
Ben Alpert
566dba25ef
Merge pull request #4773 from spicyj/new-dt-blog
...
New devtools blog post
2015-09-02 15:15:27 -07:00
Ben Alpert
f5bd8fc0ad
New devtools blog post
2015-09-02 12:34:10 -07:00
Ben Alpert
fb7e566b12
Add react-to-react-dom codemod
...
I ran it over Facebook so it probably works.
2015-09-01 17:44:27 -07:00
Ben Alpert
697c09a26e
Merge pull request #4759 from spicyj/devprod
...
Fix diverging behavior of ReactFragment in `__DEV__`
2015-09-01 17:35:14 -07:00
Ben Alpert
4b9c349fd0
Merge pull request #4702 from spicyj/react-mod-depr
...
Add deprecation warnings to React module
2015-09-01 14:40:48 -07:00
Ben Alpert
4d29125d39
Merge pull request #4764 from spicyj/pre-commit
...
Remove leftover env variable logic in pre-commit hook
2015-09-01 14:39:53 -07:00
Ben Alpert
c04d02e5e8
Add warnings to React module
2015-09-01 14:36:41 -07:00
Ben Alpert
c74977c091
Remove leftover env variable logic in pre-commit hook
2015-09-01 14:35:47 -07:00
Ben Alpert
b1e16b9d7e
React -> ReactDOM in test files
2015-09-01 14:34:37 -07:00
Ben Alpert
d9d8aae33e
Merge pull request #4763 from spicyj/pre-commit
...
Add linting pre-commit hook
2015-09-01 14:33:49 -07:00
Ben Alpert
31cb102650
Merge pull request #4762 from spicyj/ts
...
Make TypeScript test work with ReactDOM
2015-09-01 14:30:56 -07:00
Ben Alpert
25fec05ab4
Add linting pre-commit hook
...
Anyone who wants it will have to do
```
ln -s scripts/git/pre-commit .git/hooks/pre-commit
```
or similar.
2015-09-01 14:29:52 -07:00
Ben Alpert
589c8364b0
Make TypeScript test work with ReactDOM
2015-09-01 14:28:12 -07:00
Ben Alpert
7e5ce19a94
Fix diverging behavior of ReactFragment in __DEV__
...
We could also remove the return statements but this is not a hot path and this seems safer.
2015-09-01 13:27:17 -07:00
Paul O’Shannessy
9400b34363
Merge pull request #4746 from zpao/use-fbjs-lint
...
Use eslintrc from fbjs
2015-08-31 23:21:29 -07:00
Paul O’Shannessy
7645c07720
Use eslintrc from fbjs
2015-08-31 23:05:04 -07:00
Ben Alpert
2d63dfd73c
Merge pull request #4755 from MichelleTodd/react-warnings-0.14
...
Update warning messages to use ReactDOM and ReactDOMServer as appropriate
2015-08-31 23:03:10 -07:00
Michelle Todd
719fe15b9e
Update warning messages to use ReactDOM and ReactDOMServer as appropriate
...
Fixes #4710 .
- `React.findDOMNode` => `ReactDOM.findDOMNode`
- `React.render` => `ReactDOM.render` or "top-level render" (depends on whether we're in DOM-specific usage or generic cases)
- `React.renderToString` => `ReactDOMServer.renderToString`
- `React.renderToStaticMarkup` => `ReactDOMServer.renderToStaticMarkup`
2015-08-31 22:55:27 -07:00
Paul O’Shannessy
f118e5ebe7
Merge pull request #4750 from zpao/fbjs-0.2
...
Upgrade to fbjs, fbjs-scripts @ 0.2
2015-08-31 22:47:02 -07:00
Ben Alpert
487cc586f7
Merge pull request #4731 from spicyj/map-one-pass
...
Make React.Children.map do one pass only
2015-08-31 18:52:51 -07:00
Ben Alpert
6013105a9c
Make React.Children.map do one pass only
...
Changed: createFragment no longer includes nulls in its output (since toArray doesn't and they share code).
Changed: React.Children.map no longer warns for clashing keys; traverseAllChildren will later when rendering.
Also change the generated key format around to accomodate. My keys are probably not bulletproof but should definitely be safe against accidental collisions.
2015-08-31 18:47:09 -07:00
Paul O’Shannessy
52b4c9eabf
Upgrade to fbjs, fbjs-scripts @ 0.2
2015-08-31 17:19:42 -07:00
Ben Alpert
dc4f011f57
Merge pull request #4735 from spicyj/shallow-error
...
Better error for invalid element when shallow rendering
2015-08-31 13:30:56 -07:00
Ben Alpert
0e2bf2fe75
Merge pull request #4744 from spicyj/gh-4635-f
...
Fix code style/grammar on synthetic event warning
2015-08-31 13:06:46 -07:00
Paul O’Shannessy
dc23faf64d
Merge pull request #4739 from henrik/patch-1
...
docs: "also lets pass" -> "also lets you pass"
2015-08-31 11:44:29 -07:00
Ben Alpert
42602a8922
Fix code style/grammar on synthetic event warning
2015-08-31 11:32:12 -07:00
Jim
0ff65cc892
Merge pull request #4635 from edvinerikson/event-pooling-warning
...
Added warning when calling methods on a released event.
2015-08-31 10:49:01 -07:00
Henrik Nyh
01151c1dea
docs: "also lets pass" -> "also lets you pass"
2015-08-30 10:19:34 +02:00
Ben Alpert
f641f29db0
Merge pull request #4737 from oliviertassinari/patch-1
...
[adler32] fix wrong name
2015-08-29 11:18:18 -07:00
Olivier Tassinari
0304051591
[adler32] fix wrong name
2015-08-29 19:07:36 +01:00
Yuichi Hagio
d724393f0e
Update 02-displaying-data.ja-JP.md
...
1. Fixed a spelling mistake to be more readable.
2. Removed the English lines that were already translated below.
2015-08-29 14:02:06 -04:00
Ben Alpert
f4d7feb8be
Better error for invalid element when shallow rendering
...
Fixes #4721 , fixes #4730 .
2015-08-28 18:21:30 -07:00
Ben Alpert
a7230de902
Merge pull request #4727 from spicyj/gh-4233
...
Make findDOMNode error clearer
2015-08-28 12:52:18 -07:00
Paul O’Shannessy
e53cee9af6
Merge pull request #4734 from zpao/reverse-logic
...
Reverse condition of a ternary for readability
2015-08-28 11:39:48 -07:00
Paul O’Shannessy
2e5b047f04
Reverse condition of a ternary for readability
2015-08-28 11:34:50 -07:00
Ben Alpert
024f71535c
Merge pull request #4720 from spicyj/destructor
...
Add destructors to pooled classes in ReactChildren
2015-08-27 19:06:11 -07:00
Ben Alpert
16d8f20576
Add destructors to pooled classes in ReactChildren
...
And make destructors mandatory so we're less likely to forget again.
2015-08-27 19:05:56 -07:00
Paul O’Shannessy
bdc7ce9f01
Merge pull request #4482 from niole/issue4168
...
Add additional contextual information to invalid-style-prop warning
2015-08-27 18:13:29 -07:00
Niole Nelson
70c07c67b7
resolves issue #4168 , style prop error now names React class that erroring element is a child of.
2015-08-27 18:10:51 -07:00
Ben Alpert
8b967052d8
Merge pull request #4732 from spicyj/eslint-undef
...
Enable no-undef for eslint
2015-08-27 18:07:51 -07:00
Ben Alpert
75873707f9
Enable no-undef for eslint
2015-08-27 18:03:14 -07:00
Andreas Savvides
807c62851c
Make definitions more readable & optional params more obvious
2015-08-27 16:32:07 +01:00
Ben Alpert
72d5b8f116
Merge pull request #4700 from spicyj/frag-array
...
Make createFragment return an array, disallow objects as children
2015-08-26 11:12:06 -07:00
Ben Alpert
127917d454
Merge pull request #4701 from spicyj/gh-4525
...
Add deprecation notice for React.addons.batchedUpdates
2015-08-25 11:40:33 -07:00
Ben Alpert
d4f38933f2
Merge pull request #4703 from spicyj/rarr
...
Clarify use of arrow functions
2015-08-25 11:38:13 -07:00
Ben Alpert
66881ae083
Fix formatting in test utils docs
2015-08-25 09:47:38 -07:00
Edvin Erikson
34af8f8597
Added warning when calling methods on a released event.
2015-08-25 14:45:56 +02:00
Ben Alpert
d15938cd92
Clarify use of arrow functions
...
Per 1db20999f0 (commitcomment-12865588) .
2015-08-24 17:21:10 -07:00
Ben Alpert
e64b402df9
Add deprecation notice for React.addons.batchedUpdates
...
Fixes #4525 .
2015-08-24 16:20:56 -07:00
Ben Alpert
6a2cdd58a4
Make findDOMNode error clearer
...
Fixes #4233 .
2015-08-24 16:15:44 -07:00
Ben Alpert
6abf025d46
Make createFragment return an array, disallow objects as children
2015-08-24 16:09:08 -07:00
Paul O’Shannessy
10c8166043
Merge pull request #4682 from lyip1992/patch-2
...
Update Gruntfile.js
2015-08-22 16:11:04 -07:00
Paul O’Shannessy
27e5a563db
Merge pull request #4684 from lyip1992/patch-3
...
Update 10.1-animation.md
2015-08-22 16:10:05 -07:00
Paul O’Shannessy
d5e5261e38
Merge pull request #4686 from lyip1992/patch-5
...
Update 06-transferring-props.md
2015-08-22 16:09:02 -07:00
Paul O’Shannessy
7dbcff2df4
Merge pull request #4687 from lyip1992/patch-6
...
Update 04-multiple-components.md
2015-08-22 16:08:27 -07:00
Paul O’Shannessy
cca1065183
Merge pull request #4688 from lyip1992/patch-7
...
Update 02.3-jsx-gotchas.md
2015-08-22 16:08:02 -07:00
Paul O’Shannessy
adfbc64d4b
Merge pull request #4685 from lyip1992/patch-4
...
Update 08.1-more-about-refs.md
2015-08-22 16:07:20 -07:00
Leon Yip
71454365f2
Update 02.3-jsx-gotchas.md
...
Fix typo.
2015-08-22 00:57:51 -07:00
Leon Yip
2f4ea60571
Update 04-multiple-components.md
...
Added an extra word to make the sentence read a little easier.
2015-08-22 00:56:23 -07:00
Leon Yip
f8fe717ea2
Update 06-transferring-props.md
...
"This ensures that" sounds a better than "That ensures that." This change is just my personal opinion, so I totally understand my change doesn't get merged.
2015-08-22 00:51:38 -07:00
Leon Yip
3849710d8b
Update 08.1-more-about-refs.md
...
Change render to `render()` for consistency within the paragraph.
2015-08-22 00:46:18 -07:00
Leon Yip
c0e21d1b85
Update 10.1-animation.md
...
Changed "if" to "even when" for clarity.
2015-08-22 00:42:25 -07:00
Leon Yip
e99e8b66b2
Update Gruntfile.js
...
Added punctuation to make the comment consistent with other comments.
2015-08-21 18:06:55 -07:00
Paul O’Shannessy
6508b1ad27
Merge pull request #4678 from ning-github/patch-1
...
Remove redundancy regarding 'latest React news'
2015-08-21 17:48:57 -07:00
Ning Xia
b629289cea
Fix repetition by editing second sentence
...
edited based on paul's input
2015-08-21 16:33:20 -07:00
Jim
b36ee449cb
Merge pull request #4679 from ning-github/patch-2
...
Fix typo
2015-08-21 13:28:33 -07:00
Ning Xia
3232a59743
Fix typo
...
Can not should be a single word: 'cannot'
2015-08-21 13:26:58 -07:00
Ning Xia
5ba1831d76
Remove redundancy regarding 'latest React news'
...
Previously, it repeated 'latest React news' when the first sentence already begins with the same words.
2015-08-21 13:00:24 -07:00
Ben Alpert
80b7391d64
Merge pull request #2081 from rexxars/search-input-attributes
...
Allow `results` and `autosave` attributes (WebKit/Blink)
2015-08-21 09:27:06 -07:00
Espen Hovlandsdal
75805e4835
Allow results and autosave attributes (WebKit/Blink)
2015-08-21 10:10:32 +02:00
Paul O’Shannessy
b38509cade
Merge pull request #4540 from scottburch/ie8-fix
...
removed dangling comma that messes up loading in IE8
2015-08-20 14:37:20 -07:00
Paul O’Shannessy
0f963bb478
Merge pull request #4654 from zpao/checkversionsoninstall
...
Check for compatible node,npm versions on install
2015-08-20 14:36:09 -07:00
Ben Alpert
61962c1751
Capitalize Babel
2015-08-20 13:34:04 -07:00
Ben Alpert
cd268fdfcd
Merge pull request #4546 from rgbkrk/patch-1
...
Update tooling docs to suggest babel
2015-08-20 13:16:11 -07:00
Kyle Kelley
009902bcd0
Update tooling docs to suggest babel
...
`react-tools` is deprecated, `babel` is our future
* https://facebook.github.io/react/blog/2015/06/12/deprecating-jstransform-and-react-tools.html
* https://babeljs.io/docs/usage/jsx/
2015-08-20 14:24:20 -05:00
Ben Alpert
5fa72c2659
Merge pull request #4666 from spicyj/prod
...
Add a simple production-mode sanity check test
2015-08-20 11:03:09 -07:00
Ben Alpert
102fafce7f
Add a simple production-mode sanity check test
2015-08-19 22:26:42 -07:00
Ben Alpert
ea827eb39d
Merge pull request #4561 from djrodgerspryor/css_transition_group_robust_cleanup
...
Robust animation-end handling in ReactCSSTransitionGroup
2015-08-19 19:15:51 -07:00
Daniel Rodgers-Pryor
6bd6ef208b
ReactCSSTransitionGroup timeouts
...
As discussed in issue 1326
(https://github.com/facebook/react/issues/1326 ) transitionend events are
unreliable; they may not fire because the element is no longer painted,
the browser tab is no longer focused or for a range of other reasons.
This is particularly harmful during leave transitions since the leaving
element will be permanently stuck in the DOM (and possibly visible).
The ReactCSSTransitionGroup now requires timeouts to be passed in
explicitly for each type of animation. Omitting the timeout duration
for a transition now triggers a PropTypes warning with a link to the
updated documentation.
2015-08-20 11:38:27 +10:00
Ben Alpert
b88592a354
Merge pull request #4665 from spicyj/gh-2407
...
Ensure IE8 style expansion list is up to date
2015-08-19 17:38:32 -07:00
Ben Alpert
b126926390
Ensure IE8 style expansion list is up to date
...
In conjunction with #1953 , fixes #2407 . This seems to be all of the shorthand style properties that IE8 supports, excluding a few nonstandard ones.
2015-08-19 17:22:37 -07:00
Andreas Svensson
f4f22a0baa
Apply CSS shorthand expansion to IE8 only
...
Closes #1953 .
2015-08-19 17:17:51 -07:00
Ben Alpert
3de7a281de
Merge pull request #4664 from spicyj/ref-docs
...
Spruce up refs docs
2015-08-19 16:34:44 -07:00
Ben Alpert
1db20999f0
Spruce up refs docs
...
Fixes #4651 .
2015-08-19 16:14:35 -07:00
Ben Alpert
2f96d70087
Merge pull request #4660 from TylerBrock/patch-2
...
Clarify invocation order of componentDidMount
2015-08-19 11:13:24 -07:00
Paul O’Shannessy
17d5440751
Merge pull request #4567 from koba04/fix-set-boolean-properties
...
Fixed consistency of behavior boolean properties
2015-08-19 10:20:49 -07:00
Tyler Brock
1e10bb5923
Clarify invocation order of componentDidMount
...
OP is delivering on promise made here: https://discuss.reactjs.org/t/how-do-you-invoke-the-render-callback-in-jsx/1744
2015-08-19 10:04:34 -07:00
Paul O’Shannessy
50adfeb421
Merge pull request #4657 from zpao/abcorderevents
...
Re-sort some constants
2015-08-19 09:26:02 -07:00
Paul O’Shannessy
ec9b866bc0
Check for compatible node,npm versions on install
...
This is only for building React and doesnn't apply to production installs.
2015-08-18 23:45:12 -07:00
Paul O’Shannessy
eb056fcf5d
Re-sort some constants
2015-08-18 22:33:51 -07:00
Ben Alpert
9c98a5998a
Merge pull request #4656 from spicyj/jest-fast
...
hax to make jest fast
2015-08-18 21:45:42 -07:00
Ben Alpert
a8b6c8292b
hax to make jest fast
...
Turns out jest is _incredibly_ slow at resolving require paths like `require('fbjs/lib/foo')`. Like several milliseconds per require. Really adds up when all our files require `invariant` and `warning`. Here's a temporary hack to make things fast again.
Test Plan:
```
npm test src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js
```
has a self-proclaimed runtime of ~8 seconds now instead of ~35 seconds.
2015-08-18 21:40:58 -07:00
Jim
2a82689e6e
Merge pull request #4655 from levibuzolic/patch-1
...
Update Advanced Performance code examples so they would output values
2015-08-18 20:57:34 -07:00
Levi Buzolic
009f766d6e
Update Advanced Performance code examples so they would output values
...
Noticed the code examples in *Advanced Performance* wouldn't be rendering the example props, this could lead to some minor confusion for new users.
2015-08-19 13:50:43 +10:00
Sebastian Markbåge
4a92860b00
Merge pull request #4089 from sebmarkbage/killowner
...
Don't use owner to determine if the auto-bailout should be used
2015-08-18 18:09:01 -07:00
Ben Alpert
81b4f7295d
Merge pull request #4611 from spicyj/create-element
...
Use createElement instead of HTML generation
2015-08-18 18:04:54 -07:00
Ben Alpert
cfd6f7a1b8
Use createElement instead of HTML generation
...
Behind a feature flag. This is a relatively simple change; adopting this strategy universally would mean that we could clean up a lot of code but this doesn't attempt to restructure more than necessary.
2015-08-18 17:44:20 -07:00
Sebastian Markbage
9315517dec
Don't use owner to determine if the auto-bailout should be used
...
I didn't realize that we actually special cased this. This is an
unfortunate heuristic but it helps minimize the harm that this optimization
does.
2015-08-18 17:33:13 -07:00
Ben Alpert
5375b503e9
Merge pull request #4652 from spicyj/no-isre
...
Remove _isReactElement
2015-08-18 16:41:45 -07:00
Ben Alpert
6663fb3135
Remove _isReactElement
...
As of this commit, we still support objects as maps so if anyone has an object with keys 'type' and 'props' this will change behavior, but otherwise this should be pretty safe.
2015-08-18 12:55:34 -07:00
Paul O’Shannessy
b4ee5b5bf1
Merge pull request #4451 from dmatteo/TestUtils.Simulate-docs
...
improve ReactTestUtils.Simulate documentation
2015-08-17 14:51:05 -07:00
Jim
d984b687ec
Merge pull request #4634 from edvinerikson/event-pooling
...
Added documentation about pooled events
2015-08-17 14:33:33 -07:00
Jim
87530049f8
Merge pull request #4481 from dmatteo/Simulate.change-tests
...
add tests for React.addons.TestUtils.Simulate.change
2015-08-17 11:23:12 -07:00
Paul O’Shannessy
cac9c88978
Merge pull request #4641 from mik01aj/master
...
Updated the Performance tools doc page.
2015-08-17 11:01:10 -07:00
Paul O’Shannessy
b5a9cfc8b0
Merge pull request #4643 from yasaricli/master
...
Examples jquery-mobile thirdparty files move
2015-08-17 09:48:07 -07:00
Yasar icli
0c0119b70d
examples jquery-mobile thirdparty files move
2015-08-17 13:43:33 +03:00
Mikolaj Dadela
75fafe1c0b
Updated the Performance tools doc page.
...
Now it’s possible to read the page from top to the bottom without
asking oneself “Ok, but how do I get these measurements?”
2015-08-17 11:18:04 +02:00
Edvin Erikson
6793a7197e
Updated event pooling note in docs
2015-08-15 21:47:59 +02:00
Edvin Erikson
1e3c3e1b6b
Added documentation about pooled events
2015-08-15 17:03:21 +02:00
Paul O’Shannessy
56527cda64
Merge pull request #4631 from Simek/tiny-code-tweak-reactMultiChild
...
tiny code tweak in ReactMultiChild
2015-08-14 16:44:49 -07:00
Paul O’Shannessy
9257fbbadc
Merge pull request #4632 from Simek/react-codemod-lint-fix
...
react-codemod lint fix
2015-08-14 16:43:44 -07:00
Bartosz Kaszubowski
f53b960741
react-codemod-lint-fix
2015-08-15 01:36:44 +02:00
Bartosz Kaszubowski
1ca77c6ae6
tiny code tweak in ReactMultiChild
2015-08-15 01:25:09 +02:00
Paul O’Shannessy
b4b028dec0
Merge pull request #4622 from jorrit/instanceofreporttype
...
Report the actual type when PropTypes.instanceOf fails
2015-08-14 11:05:57 -07:00
cpojer
989caa870d
Support export default in the class codemod.
2015-08-14 10:27:31 -07:00
Merrick Christensen
5395c815de
fix(es6-import-export): initial commit actually applying
2015-08-14 10:27:31 -07:00
Jorrit Schippers
cf6222dd71
Report the actual type when PropTypes.instanceOf fails
2015-08-14 17:46:24 +02:00
Jim
534e277c10
Merge pull request #4627 from tako-black/translate_top-level-api_to_japanese
...
Translate ref-01-top-level-api.md to Japanese
2015-08-14 05:14:53 -07:00
Kohei TAKATA
ae38ea9275
Translate ref-01-top-level-api.md to Japanese
2015-08-14 19:16:59 +09:00
Paul O’Shannessy
6708059b51
Merge pull request #4607 from hekar/add/html-table-summary-attr
...
Added support for more HTML attributes: `summary`
2015-08-13 21:28:50 -07:00
Hekar Khani
be1fc794f0
Added support for more HTML attributes: summary
...
This attribute is used on <table> to support screen readers.
It is deprecated, so take a look at <caption> instead.
2015-08-13 22:41:37 -05:00
Matthew Johnston
0b07fed32c
ReactEurope roundup blog post
2015-08-13 17:14:17 -07:00
Ben Alpert
4d614cfc87
Merge pull request #4624 from Torwori/null-check-fix
...
Swap places of mounted and pending update checks
2015-08-13 14:48:56 -07:00
Paul O’Shannessy
6c84a57a2d
Merge pull request #4610 from lili21/fix-component-api-doc
...
update component api docs
2015-08-13 13:08:28 -07:00
Paul O’Shannessy
6a9c789076
Merge pull request #4626 from yoshuki/fix-markdown-conversion
...
Fix Markdown conversion with marked
2015-08-13 13:02:32 -07:00
MIKAMI Yoshiyuki
47ce8ecacb
Fix Markdown conversion with marked
2015-08-14 01:07:19 +09:00
Igor Scekic
0e834fabca
swap places of mounted and pending update checks
...
prevents a type error if the component isn't mounted
2015-08-13 16:34:47 +02:00
Jim
d8998354ee
Merge pull request #4623 from tako-black/translate_introduction_to_japanese
...
Translate 01-introduction.md to Japanese
2015-08-13 07:25:36 -07:00
Kohei TAKATA
edca54fb93
Translate 01-introduction.md to Japanese
2015-08-13 21:27:00 +09:00
li.li
f027ca8ca0
update component api docs
2015-08-13 15:34:21 +08:00
Paul O’Shannessy
530a30c1d5
Fix grammar in Relay blog post
...
Brings in #4617 properly
2015-08-12 12:09:24 -07:00
Paul O’Shannessy
1b7d6c381f
Merge pull request #4619 from jaredly/beta-2
...
update devtools post to note beta 2
2015-08-12 11:53:25 -07:00
Jared Forsyth
3ed9581adb
update devtools post to note beta 2
2015-08-12 11:29:41 -07:00
Jim
d7b59de1c3
Merge pull request #4613 from tako-black/translate_advanced-performance_to_japanese
...
Translate 11-advanced-performance.md to Japanese
2015-08-12 07:39:03 -07:00
Kohei TAKATA
239eb0fc23
Translate 11-advanced-performance.md to Japanese
2015-08-12 19:40:30 +09:00
Sebastian Markbåge
d3f338ff27
Fix typecheck
2015-08-12 00:32:52 -07:00
Ben Alpert
cb2f4de4ca
Merge pull request #4609 from spicyj/warn-r2
...
Remove accidental .only
2015-08-11 18:20:05 -07:00
Ben Alpert
a54d321765
Remove accidental .only
2015-08-11 18:19:42 -07:00
Ben Alpert
dc5a5adfaf
Merge pull request #4477 from mridgway/autobind-opt-out
...
Allow classes created with React.createClass to opt out of autobinding
2015-08-11 18:03:41 -07:00
Ben Alpert
655b82fb7b
Merge pull request #3332 from spicyj/warn-r2
...
Warn with two copies of React
2015-08-11 17:17:53 -07:00
Ben Alpert
d002abf0e7
Warn with two copies of React
2015-08-11 17:15:02 -07:00
Jim
079a6b0092
Merge pull request #4470 from jimfb/ref-error-means-multiple-react
...
Added note about multiple Reacts, since this error commonly implies that.
2015-08-11 16:24:01 -07:00
Ben Alpert
6160216b22
Merge pull request #3650 from spicyj/toarray
...
Add React.Children.toArray
2015-08-11 16:13:51 -07:00
Ben Alpert
53d8bbddc7
Add React.Children.toArray
2015-08-11 16:13:40 -07:00
Jim
e984d2b7d2
Added note about multiple Reacts, since this error commonly implies that.
2015-08-11 12:59:55 -07:00
Joseph Savona
aa55a71c62
Relay Technical Preview - blog post
...
(cherry picked from commit cac6bc870d )
2015-08-11 12:46:37 -07:00
Sebastian Markbåge
2457823227
Merge pull request #4182 from sebmarkbage/fixguards
...
Move guards from auto binding to event dispatch
2015-08-11 12:05:08 -07:00
Sebastian Markbage
216026418c
Simplify event dispatching
...
This simplifies event dispatching by removing the `return false` special
case for the SimpleEventPlugin which allow us to inline much more here
and the code becomes easier to follow.
2015-08-11 11:55:07 -07:00
Sebastian Markbage
16cc45156f
Move guards from auto binding to event dispatch
...
This wraps a proper guard around event dispatching so that errors doesn't
interupt other event callbacks.
Instead we rethrow the first error after all callbacks have been invoked.
For DEV mode we use native event dispatching if available. This has the
benefit that caught exceptions show up in the dev tools even without caught
exceptions being turned on. Yet, all callbacks are guaranteed to fire.
2015-08-11 11:55:07 -07:00
Jim
1b67acc168
Merge pull request #4344 from jimfb/update-children-because-context
...
Don't skip reconcilation if context differs
2015-08-11 10:44:14 -07:00
Jim
bcd32768e6
Merge pull request #4602 from tako-black/update_tutorial_ja-JP
...
Change tutorial.ja-JP.md to use marked
2015-08-11 09:26:53 -07:00
Kohei TAKATA
1ceded865b
Change tutorial.ja-JP.md to use marked
2015-08-11 22:54:36 +09:00
Paul O’Shannessy
7deab28347
Merge pull request #4598 from zpao/eslint-1.1
...
Upgrade ESLint, fix code
2015-08-10 21:11:23 -07:00
Ben Alpert
d1a2193127
Merge pull request #4587 from spicyj/stateless-fn
...
Minimal implementation of stateless components
2015-08-10 17:49:31 -07:00
Paul O’Shannessy
ecb34de574
Upgrade ESLint, fix code
2015-08-10 17:04:29 -07:00
Sebastian Markbåge
37ee03f29c
Merge pull request #4596 from jaredly/add-source-self
...
adding __self and __source special props
2015-08-10 16:22:12 -07:00
Ben Alpert
cd15dc60b8
Merge pull request #4597 from spicyj/coco
...
Apply codemod for React -> ReactDOM split
2015-08-10 15:33:49 -07:00
Ben Alpert
9adcff442a
Apply codemod for React -> ReactDOM split
...
Ran the codemod automatically then ran
```
codemod.py -m -d src '(var React\b[^\n]*;)\n\n(var ReactDOM)' '\1\n\2'
```
to clean up spacing of requires.
2015-08-10 15:24:30 -07:00
Ben Alpert
b98b6ea2ac
Clean up files before automated codemod
2015-08-10 15:23:12 -07:00
Jared Forsyth
009b7c8ae1
adding __self and __source special props
2015-08-10 13:52:17 -07:00
Paul O’Shannessy
1e90de692e
Merge pull request #4584 from jessebeach/jessebeach-reactComponentExpect-silent-fail
...
reactComponentExpect fails silently
2015-08-10 13:15:14 -07:00
Toru Kobayashi
eb4e44a3c9
Fixed consistency of behavior boolean properties
2015-08-09 17:00:37 +09:00
Sebastian Markbåge
2f079359e8
Merge pull request #4588 from sebmarkbage/ownersforcontext
...
Add property key names + type of value to fragment warning
2015-08-08 15:11:22 -07:00
Sebastian Markbage
754ee176d0
Add property key names + type of value to fragment warning
...
This provides useful context in the logs to help us filter out things like
{__html:...}.
2015-08-07 20:01:03 -07:00
Ben Alpert
f3440c0d6f
Merge pull request #4581 from Youmoo/patch-1
...
Update 2015-05-01-graphql-introduction.md
2015-08-07 19:32:22 -07:00
Ben Alpert
5a7bd964b4
Minimal implementation of stateless components
...
Stateless pure-function components give us more opportunity to make performance optimizations. For now, we'll do a minimal implementation which has similar performance characteristics to other components in the interests of shipping 0.14 and allowing people to begin writing code using this pattern; in the future we can refactor to allocate less and avoid other unnecessary work.
2015-08-07 19:27:42 -07:00
Ben Alpert
3ec9f86573
Deduplicate logic in ReactElementValidator
...
Shouldn't be much change. Notably, this calls `.getName()` instead of trying to derive it manually, which is more consistent.
2015-08-07 18:53:42 -07:00
Ben Alpert
b927110fb2
Merge pull request #4585 from spicyj/disable-path
...
Disable event.path handling
2015-08-07 13:41:11 -07:00
Ben Alpert
016a1907e1
Disable event.path handling
...
Looks like #4558 isn't ready yet and we'd like an interim fix.
2015-08-07 13:33:42 -07:00
J. Renée Beach
39c3fb2b09
reactComponentExpect fails silently
...
```reactComponentExpect``` fails silently when passed an undefined value. It calls ```ReactTestUtils.isCompositeComponent``` with the undefined value, in which a ```render``` property is accessed, throwing a prop on undefined not found error which isn't surfaced to jest.
```
TypeError: Cannot read property 'render' of undefined
at Object.ReactTestUtils.isCompositeComponent (./react/test/ReactTestUtils.js:127:23)
at new reactComponentExpect (./react/test/reactComponentExpect.js:46:20)
at reactComponentExpect (./react/test/reactComponentExpect.js:40:12)
```
Expecting the passed-in instance to not be undefined surfaces this issue in the test runner.
2015-08-07 11:21:45 -07:00
Sebastian Markbåge
7f119d41c7
Merge pull request #4554 from chernysh/chernysh-added-docs-img-events
...
Added documentation for <img> events
2015-08-07 11:07:24 -07:00
youmoo
0a19e0c0e5
Update 2015-05-01-graphql-introduction.md
...
Or the alternative:
`REST is an acronym for Representational State Transfer, which is an architectural style rather than a formal protocol`.
Sorry , I'am not a native speaker:)
2015-08-07 14:11:03 +08:00
Ben Alpert
6871ec2e29
Merge pull request #4580 from spicyj/gh-4578
...
Fix missing change event target in old IE
2015-08-06 15:24:02 -07:00
Ben Alpert
264bc2e7f2
Fix missing change event target in old IE
...
Events have `.srcElement` in old IE, not `.target`.
Fixes #4578 .
2015-08-06 15:08:59 -07:00
Sebastian Markbåge
375734731d
Merge pull request #4579 from sebmarkbage/ownersforcontext
...
Only set the owner during flattening
2015-08-06 13:04:56 -07:00
Sebastian Markbage
9fc2f8de26
Only set the owner during flattening
...
This used to do the update as well, which could have side-effects that
rely on owner being null.
2015-08-06 12:57:17 -07:00
Jim
13acbd2424
Merge pull request #4577 from marjan-georgiev/add-stopOpacity-to-unitless-props
...
Add stop-opacity to unitless style properties
2015-08-06 10:19:27 -07:00
Marjan
2b4d98fa52
Revert change to docs/js/reactj.js
2015-08-06 19:16:29 +02:00
Marjan
0d8c3f9cba
Add stop-opacity to unitless style properties
2015-08-06 16:46:13 +02:00
Sebastian Markbåge
7ffff573ae
Merge pull request #4569 from sebmarkbage/ownersforcontext
...
Set the owner during traverseAllChildren
2015-08-05 22:46:08 -07:00
Sebastian Markbage
cd1ab32d2f
Set the owner during traverseAllChildren
...
This is basically just adding some context to the warning in ReactFragment
so that we can more easily find the callers.
2015-08-05 21:04:52 -07:00
Ben Alpert
f7b9545c15
Merge pull request #4559 from salier/ie-selection
...
Use onSelect fallback in IE
2015-08-05 20:35:24 -07:00
Ben Alpert
bdfa948121
Fix lint
2015-08-05 20:34:48 -07:00
Paul O’Shannessy
e64fc51984
Merge pull request #4565 from koba04/remove-fasttest
...
Remove fasttest task. fasttest is not fast
2015-08-05 14:40:41 -07:00
Toru Kobayashi
656c2ef173
Remove fasttest task. fasttest is not fast
2015-08-05 19:00:23 +09:00
Isaac Salier-Hellendag
2ff7512975
Use onSelect fallback in IE
...
In response to https://github.com/facebook/react/issues/2722 . Use the Firefox selection change fallback for IE.
2015-08-04 17:36:34 -07:00
Vadim Chernysh
56e9d4aa4d
Added events documentation for <img> elements
2015-08-04 15:27:56 +03:00
Jim
c97ed7b804
Merge pull request #4552 from psibi/patch-1
...
Include Haskell language
2015-08-04 03:35:34 -07:00
Sibi
1c1cfe95ee
Include Haskell language
2015-08-04 14:06:08 +05:30
Ben Alpert
b4f40ba95f
Merge pull request #4473 from facebook/devtools-blog-post
...
[docs] Add blog post about the new devtools beta
2015-08-03 15:13:33 -07:00
Jared Forsyth
1343cc0c9b
Add blog post about the new devtools beta
2015-08-03 14:55:05 -07:00
Paul O’Shannessy
3f6bca7b16
0.14.0-beta3
2015-08-03 14:24:24 -07:00
Paul O’Shannessy
da8fc4e91b
Merge pull request #4545 from salzhrani/patch-2
...
Update addons.js
2015-08-02 21:05:45 -07:00
Jim
ff7996b58a
Merge pull request #4381 from mikrofusion/clarify-main-ideas
...
clarify the two main ideas behind react.
2015-08-02 20:04:37 -07:00
Mike Groseclose
38818189a5
remove two ideas from why react to add clarity
2015-08-02 19:34:20 -07:00
Samy Al Zahrani
5f01a90954
Update addons.js
2015-08-02 16:12:34 +03:00
Jim
134e0700cd
Merge pull request #4541 from marocchino/update-korean
...
Update Korean translation to e88c7bf
2015-08-01 10:43:11 -07:00
Scott Burch
1da2b29897
added suggested comment to get file to pass es-lint
2015-08-01 01:43:24 -07:00
Shim Won
28261783ed
Update Korean translation to e88c7bf
2015-08-01 12:35:09 +09:00
Paul O’Shannessy
e88c7bf495
Merge pull request #4539 from zpao/fix-encrypted-media-event
...
Listen to encrypted event, not onencrypted
2015-07-31 17:49:33 -07:00
Paul O’Shannessy
b321925cfa
Listen to encrypted event, not onencrypted
2015-07-31 17:08:57 -07:00
Scott Burch
0f1ecc3ae3
removed dangling comma that messes up loading in IE8
2015-07-31 16:36:04 -07:00
Christoph Pojer
2d239006c5
Merge pull request #4528 from cpojer/codemod-updates
...
Simplify react-codemod.
2015-07-31 10:33:12 -07:00
cpojer
2ae9921945
Simplify react-codemod.
2015-07-31 10:32:53 -07:00
Jim
50d73f9a13
Merge pull request #4537 from afhole/patch-1
...
Update 02.1-jsx-in-depth.md
2015-07-31 10:13:58 -07:00
Alastair Hole
72a1fd6ce5
Update 02.1-jsx-in-depth.md
...
'setup' is a noun, not a verb
2015-07-31 17:40:48 +01:00
Paul O’Shannessy
681bbb629f
0.14.0-beta2
2015-07-30 21:29:09 -07:00
Paul O’Shannessy
e9c53364e5
Update fbjs dependency
2015-07-30 21:28:11 -07:00
Paul O’Shannessy
617ba9c21a
Merge pull request #4501 from zpao/build-more-addons
...
Build perf and test-utils addon npm packages
2015-07-30 13:29:50 -07:00
Paul O’Shannessy
3d197e2a88
Merge pull request #4010 from zpao/really-deprecate-react-tools
...
Remove react-tools
2015-07-30 10:29:20 -07:00
Paul O’Shannessy
94bc29b400
Remove react-tools completely
2015-07-30 10:15:36 -07:00
Paul O’Shannessy
d982d5e153
Move react-tools from root.
...
ReactTools is deprecated, it doesn't belong at the root of the project. We'll remove it after 0.14 but for now this moves it so that it's contained and not intermixed with the rest of the project. The currect behavior of copying src/ into the package is maintained.
2015-07-30 10:15:36 -07:00
Jim
cc98f83b53
Merge pull request #4370 from blainekasten/video-events
...
Add Video/Audio Media Events
2015-07-29 21:57:25 -07:00
blainekasten
bdf377ff02
Add MediaEvent Handlers for Video/Audio components
2015-07-29 23:25:01 -05:00
Jim
f46c631091
Merge pull request #4513 from jimfb/fix-global-events
...
Fixed global events (like enter/leave events) when event has path.
2015-07-29 16:59:31 -07:00
Paul O’Shannessy
7989b34dd4
Merge pull request #4512 from zpao/codeofconduct
...
Explicitly call out code of conduct in CONTRIBUTING
2015-07-29 13:17:10 -07:00
Jim
b3d5b7f8db
Fixed global events (like enter/leave events) when event has path.
2015-07-29 11:42:04 -07:00
Paul O’Shannessy
48e47fd25b
Merge pull request #4493 from dmatteo/scryRenderedDOMComponents.bug
...
ensure tags are upperCase before comparing. #4388
2015-07-28 18:41:00 -07:00
Paul O’Shannessy
e8d79c3548
Fix a couple lint issues as a followup for #3761
2015-07-28 17:49:53 -07:00
Paul O’Shannessy
edf4d24c49
Merge pull request #3761 from alexpien/CustomClassesForReactCSSTransitionGroup
...
Custom class names in ReactCSSTransitionGroup
2015-07-28 16:59:51 -07:00
Paul O’Shannessy
6eb5a15049
Merge pull request #3742 from mminer/order-css-vendor-prefixes
...
Treat boxOrdinalGroup and flexOrder as unitless
2015-07-28 16:44:14 -07:00
Paul O’Shannessy
b766c62bb9
Merge pull request #2664 from jasonwebster/patch-1
...
Add additional supported methods to event documentation
2015-07-28 16:09:23 -07:00
Paul O’Shannessy
d80b1b89ae
Explicitly call out code of conduct in CONTRIBUTING
2015-07-28 13:49:00 -07:00
Paul O’Shannessy
8a81d0cea2
Note that npm >= 2.0.0 is required for building
2015-07-28 11:59:06 -07:00
Jim
98d4fde55c
Merge pull request #4506 from tako-black/translate_perf_to_japanese
...
Translate 10.9-perf.md to Japanese
2015-07-28 08:51:51 -07:00
Kohei TAKATA
2392217f32
Translate 10.9-perf.md to Japanese
2015-07-28 17:54:10 +09:00
Paul O’Shannessy
a7da0f22c4
Merge pull request #4503 from jimfb/remove-npm-run-jest
...
Removed `npm run jest` script. Users can use `npm test` instead.
2015-07-27 16:05:38 -07:00
Jim
6296d1cad2
Removed npm run jest script. Users can use npm test instead.
2015-07-27 16:03:59 -07:00
Jim
9b30176122
Merge pull request #4422 from jimfb/reconciler-cleanup
...
Cleaned up a few names in the reconciler.
2015-07-27 15:59:44 -07:00
Jim
a4459558c1
Cleaned up a few names in the reconciler.
2015-07-27 15:07:44 -07:00
Paul O’Shannessy
ff71d7a939
Build perf and test-utils addon npm packages
2015-07-27 15:04:38 -07:00
Paul O’Shannessy
9d4a805eb7
Merge pull request #4499 from zpao/update-fbjs
...
Update fbjs dependency
2015-07-27 14:26:07 -07:00
Paul O’Shannessy
be5c09c24d
Update fbjs dependency
...
- remove a file that got moved over there
- update for renamed babel transform
2015-07-27 13:37:48 -07:00
Jim
fab001aa80
Merge pull request #4469 from KevinTCoughlin/kevintcoughlin/#4265
...
Fixes #4265 - Clarify React.render note in documentation
2015-07-27 11:06:58 -07:00
Jim
be39979460
Merge pull request #4495 from tako-black/translate_pure-render-mixin_to_japanese
...
Translate 10.8-pure-render-mixin.md to Japanese
2015-07-26 19:25:09 -07:00
Kohei TAKATA
21d1e0004e
Translate 10.8-pure-render-mixin.md to Japanese
2015-07-27 11:22:45 +09:00
Kevin Coughlin
ee11412933
remove footnote reference asterisk, no longer needed
2015-07-26 21:35:12 -04:00
Domenico Matteo
cc02c22cb4
ensure tags are upperCase before comparing. #4388
2015-07-27 00:32:59 +02:00
Paul O’Shannessy
3056066ede
Merge pull request #4486 from yangmillstheory/docfix
...
Fix grammar
2015-07-25 10:10:18 -07:00
Victor Alvarez
912d71c9ce
Fix grammar
2015-07-25 10:08:23 -07:00
Jim
44997df9eb
Merge pull request #4483 from marocchino/update-korean
...
Update Korean translation to 991c437
2015-07-24 21:15:22 -07:00
Shim Won
b2caf1e4e3
Update Korean translation to 991c437
2015-07-25 11:06:00 +09:00
Paul O’Shannessy
7b37f8ac36
Fix gulp
2015-07-24 14:41:34 -07:00
Domenico Matteo
94d536f2ef
add tests for React.addons.TestUtils.Simulate.change
2015-07-24 22:26:33 +02:00
Paul O’Shannessy
991c437b93
Merge pull request #4167 from zpao/vendor2fbjs
...
Move vendor to fbjs package
2015-07-24 10:51:07 -07:00
Jim
f23fe004bb
Merge pull request #4478 from tako-black/translate_update_to_japanese
...
Translate 10.7-update.md to Japanese
2015-07-24 05:15:23 -06:00
Kohei TAKATA
b13b9975b8
Translate 10.7-update.md to Japanese
2015-07-24 17:52:48 +09:00
Michael Ridgway
b1fc5f949d
Allow classes created with React.createClass to opt out of autobinding
2015-07-23 18:07:00 -07:00
Paul O’Shannessy
6fc53e0438
Enable (and apply) global transforms with browserify
...
This ensures that we can consume code from npm that has our process.env pattern. Unfortunately we'll run the same transform on minified builds but it's pretty quick.
2015-07-23 17:52:58 -07:00
Paul O’Shannessy
83c88578e9
Replace grunt-jest with our own runner
...
This gives us more control
2015-07-23 17:52:58 -07:00
Paul O’Shannessy
1d0c1b1817
Use fbjs package from npm, gulp
...
This reworks a few things in building and distributing React. The biggest change is using fbjs to share dependencies with other libraries. We're also using Gulp for some build steps.
2015-07-23 15:48:02 -07:00
Paul O’Shannessy
ac5e5d789f
Merge pull request #4367 from Simek/traverse-children-cleanup
...
traverseAllChildren code clarity
2015-07-23 14:48:23 -07:00
Paul O’Shannessy
bcfba9178f
Merge pull request #4386 from AnSavvides/4369-walkthrough-clarification
...
[#4369 ] Make getting started a little less confusing
2015-07-23 13:45:33 -07:00
Paul O’Shannessy
ee410d68d6
Merge pull request #4395 from wibud/v0.0.1
...
add animationIterationCount in isUnitlessNumber
2015-07-23 13:44:08 -07:00
Paul O’Shannessy
e0b8597dbb
Merge pull request #4474 from zpao/ts14
...
Lock typescript dep at 1.4
2015-07-23 13:33:14 -07:00
Paul O’Shannessy
458714ab2f
Lock typescript dep at 1.4
2015-07-23 12:49:21 -07:00
Ben Alpert
d16481d0e7
Merge pull request #4453 from spicyj/react-dom
...
Rename ReactDOMClient to ReactDOM
2015-07-23 11:27:25 -07:00
Sebastian Markbåge
d1169b54dd
Merge pull request #4466 from jimfb/path-events-in-detached-nodes
...
Use old event propagation if path is not reasonable (eg. detached DOM). Fixes #4452
2015-07-23 11:05:33 -07:00
Jim
318c288bd3
Merge pull request #4472 from tako-black/translate_create-fragment_to_japanese
...
Translate 10.6-create-fragment.md to Japanese
2015-07-23 01:35:36 -07:00
Kohei TAKATA
2b35ba6f40
Translate 10.6-create-fragment.md to Japanese
2015-07-23 17:06:21 +09:00
Jim
42caf036e2
Merge pull request #4471 from Yeti-or/yeti-or.fix-docs
...
Docs: Fix jsx iife example
2015-07-22 21:04:59 -07:00
Vasiliy Loginevskiy
3ce58df87d
Docs: Fix jsx iife example
2015-07-23 06:08:11 +03:00
Kevin Coughlin
60a081e66b
remove markdown remnant & unnecessary whitespace
2015-07-22 22:26:03 -04:00
Paul O’Shannessy
e055a1a28a
Merge pull request #4456 from zpao/babel58
...
Upgrade babel, babel-eslint; remove babel-core dep
2015-07-22 15:11:50 -07:00
Jim
054fa0e16b
Use old event propagation if path is not reasonable (eg. detached DOM). Fixes #4452
2015-07-22 12:43:59 -07:00
Jim
b71ad1f600
Merge pull request #4460 from tako-black/enclose_variables_in_back_quote
...
Enclose variables in back quote
2015-07-22 09:00:58 -07:00
Jim
3dcc4b8b90
Merge pull request #4459 from tako-black/translate_clone-with-props_to_japanese
...
Translate 10.5-clone-with-props.md to Japanese
2015-07-22 09:00:16 -07:00
Kohei TAKATA
ae0f9189fc
Enclose variables in back quote
2015-07-22 16:19:04 +09:00
Kohei TAKATA
2a81f1229a
Translate 10.5-clone-with-props.md to Japanese
2015-07-22 16:12:08 +09:00
Ben Alpert
6c20271488
Rename ReactDOMClient to ReactDOM
...
This closer matches the npm package name and (I assume) is what we want to call it internally.
2015-07-21 19:30:09 -07:00
Paul O’Shannessy
ecb4433cc9
Upgrade babel, babel-eslint; remove babel-core dep
2015-07-21 17:23:52 -07:00
Jim
e10c873d09
Merge pull request #4455 from marocchino/update-korean
...
Update Korean translation to e928c65
2015-07-21 16:13:28 -07:00
Shim Won
dc56073d68
Update Korean translation to e928c65
2015-07-22 08:11:26 +09:00
Paul O’Shannessy
e928c65340
Merge pull request #4449 from zpao/lock-babel
...
Lock babel @ 5.6.x.
2015-07-21 14:09:47 -07:00
Domenico Matteo
97e219e785
improve ReactTestUtils.Simulate documentation
2015-07-21 22:27:20 +02:00
Paul O’Shannessy
ce8a152c49
Lock babel @ 5.6.x.
...
5.7 and 5.8 are having big issues with linting
2015-07-21 12:20:39 -07:00
Ben Alpert
6faa225fe8
Merge pull request #4447 from spicyj/tag-end
...
Pull out tag end regex
2015-07-21 12:00:45 -07:00
Ben Alpert
6fe034e6f9
Pull out tag end regex
...
For perf -- avoids allocating another object.
2015-07-21 11:53:13 -07:00
Paul O’Shannessy
82a9a5595e
Merge pull request #4404 from jbonta/component_api_docs
...
Make component api docs clearer
2015-07-21 11:11:37 -07:00
Jim
f000fa564e
Merge pull request #4443 from tako-black/translate_test-utils_to_japanese
...
Translate 10.4test-utils.md to Japanese
2015-07-21 05:14:52 -07:00
Jim
dc0d4bae7b
Merge pull request #4444 from tako-black/Add_period
...
Add period
2015-07-21 05:14:28 -07:00
Kohei TAKATA
d8961311c5
Add period
2015-07-21 21:08:42 +09:00
Kohei TAKATA
75d0486202
Translate 10.4test-utils.md to Japanese
2015-07-21 21:04:46 +09:00
Jim
57d14ec33a
Merge pull request #4400 from jimfb/adler32
...
Improved performance for our adler32 implementation.
2015-07-20 18:53:58 -07:00
Jim
57e9e5bf23
Improved performance for our adler32 implementation
2015-07-20 18:50:05 -07:00
Ben Alpert
16483e3cca
Merge pull request #4427 from spicyj/gh-1232
...
Fix switching between dangerouslySetInnerHTML and children
2015-07-20 16:57:01 -07:00
Ben Alpert
caae627cd5
Fix switching between dangerouslySetInnerHTML and children
...
With this, ReactMultiChild handles all of the children-related operations for ReactDOMComponent so that we don't process operations out of order. This is necessary because ReactMultiChild does its own batching so there's no way without its cooperation to get the timing right here.
Ideally we'll factor this logic out a bit better in subsequent updates but this is the simplest way to fix #1232 which has embarrassingly been open for over a year.
2015-07-20 16:37:43 -07:00
Paul O’Shannessy
3ca5c15c1e
Merge pull request #4092 from mking/remove-react-source-gem
...
Stop building react-source gem
2015-07-20 15:18:26 -07:00
Paul O’Shannessy
d66fd21446
Merge pull request #4435 from rtfeldman/fix-error-message
...
Fix typo in removeComponentAsRefFrom error message
2015-07-20 13:04:00 -07:00
Richard Feldman
c13588ef0a
Fix typo in removeComponentAsRefFrom error message.
2015-07-20 11:16:15 -07:00
Ben Alpert
21fff2daa6
Merge pull request #4432 from spicyj/eslint-upg
...
Upgrade eslint
2015-07-20 08:45:29 -07:00
Ben Alpert
06304d59de
Upgrade eslint
...
Fixes #4428 .
2015-07-20 08:37:47 -07:00
Ben Alpert
d13fafa5dd
counterexample -> antipattern
2015-07-20 08:28:53 -07:00
dongmeng.ldm
28329e8655
add animationIterationCount in isUnitlessNumber
2015-07-20 10:45:23 +08:00
Ben Alpert
33a5a64160
Merge pull request #4387 from spicyj/aep
...
Remove AnalyticsEventPlugin
2015-07-18 21:27:36 -07:00
Jason Bonta
bae4e586e5
Make component api docs clearer
...
I'm proposing these changes because I found some repetition / lack of
clarity and some language that suggested that you could mutate
`this.state` directly.
2015-07-18 17:20:36 -07:00
Jim
c73f95292c
Merge pull request #4408 from jimfb/remove-children-map
...
Removed flattened children object. Fixes #4405
2015-07-17 22:19:39 -07:00
Jim
fe99e59c81
Removed flattened children object for initial render. Fixes #4405
2015-07-17 22:01:59 -07:00
Paul O’Shannessy
2ea0bd77b4
Merge pull request #4419 from Simek/invert-if-else-with-negation
...
invert few if-else with negation for better readability
2015-07-17 16:39:15 -07:00
Bartosz Kaszubowski
da11691e26
invert few if-else with negation for readability
2015-07-18 00:19:28 +02:00
Jim
c844899187
Fixed basic-jsx example, which got clobbered during a prior bug investigation
2015-07-17 14:42:55 -07:00
Paul O’Shannessy
cc85f42f0f
Merge pull request #4414 from zpao/lint-src-test
...
Enable linting in src/tests, cleanup
2015-07-17 13:56:32 -07:00
Paul O’Shannessy
a28325e412
Enable linting in src/tests, cleanup
2015-07-17 13:35:17 -07:00
Paul O’Shannessy
d435556920
Merge pull request #4412 from hawsome/patch-2
...
Switch to using comma-dangle: always-multiline
2015-07-17 13:34:33 -07:00
Paul O’Shannessy
c72f2e455a
Merge pull request #4413 from zpao/more-default-value-docs-chagnes
...
Tweaks to new content in forms documentation
2015-07-17 13:32:47 -07:00
Paul O’Shannessy
8f419c956e
Merge pull request #4393 from zpao/rm-browser-tests
...
Remove in-browser unit testing
2015-07-17 00:24:03 -07:00
Paul O’Shannessy
5da408297f
Remove in-browser unit testing
...
Rely on jest for now until we get a better and less hacky solution to running tests in the browser, probably a totally different test suite with different behavior/goals.
2015-07-17 00:13:16 -07:00
Paul O’Shannessy
2b97bc63f0
Tweaks to new content in forms documentation
2015-07-16 23:50:18 -07:00
Chris Ha
c085c85045
Switch to using comma-dangle: always-multiline
2015-07-16 23:40:16 -07:00
Jim
976b51adf8
Merge pull request #4379 from eriklharper/patch-1
...
Add more information about defaultValue
2015-07-16 19:13:31 -07:00
Jim
aa5f503595
Merge pull request #4407 from Simek/patch-4
...
split code block for readability
2015-07-16 19:08:50 -07:00
Jim
b66fa7eb05
Merge pull request #4409 from tako-black/translate_class-name-manipulation_to_japanese
...
Translate 10.3-class-name-manipulation.md to Japanese
2015-07-16 19:06:08 -07:00
Paul O’Shannessy
ddb84f44a8
Merge pull request #3186 from benekastah/patch-1
...
Modify sample CSS so that it works in Safari
2015-07-16 16:52:21 -07:00
Kohei TAKATA
990caa4a9a
Translate 10.3-class-name-manipulation.md to Japanese
2015-07-17 08:51:22 +09:00
Bartosz Kaszubowski
46d0bf825c
split code block for readability
2015-07-16 23:49:40 +02:00
eriklharper
fabdeaa6b8
Review changes
...
Fixing spelling errors and revising based on feedback.
2015-07-16 10:57:16 -07:00
Ben Alpert
44ed6010d3
Merge pull request #4306 from brigand/patch-5
...
Blog: move "refs to custom components..." fixes #4305
2015-07-15 16:36:16 +02:00
Ben Alpert
6858c7120c
Remove AnalyticsEventPlugin
...
We only ever had a couple internal users of this, and now we have none. Removing it from the repo for cleanliness.
2015-07-15 15:36:55 +02:00
Andreas Savvides
4a05be3459
[ #4369 ] Make getting started a little less confusing
2015-07-15 11:25:58 +01:00
Jim
d6c062b213
Merge pull request #4382 from tako-black/enclose_a_name_of_library_in_back_quote
...
Enclose a name of library in back quote
2015-07-14 22:30:26 -07:00
Jim
d76a686c7f
Merge pull request #4383 from tako-black/translate_form-input-binding-sugar_to_japanese
...
Translate 10.2-form-input-binding-sugar.md to Japanese
2015-07-14 22:29:49 -07:00
Paul O’Shannessy
ea6b0dd1b0
Merge pull request #4384 from zpao/jest-on-travis-again
...
Use more specific ignore pattern for jest
2015-07-14 18:35:27 -07:00
Paul O’Shannessy
91a87174bc
Use more specific ignore pattern for jest
...
TravisCI clones into /home/travis/build/facebook/react, which /build/ matches so we never ran any of our tests.
2015-07-14 18:28:30 -07:00
Kohei TAKATA
9a95ce8308
Enclose a name of library in back quote
2015-07-15 09:26:56 +09:00
Kohei TAKATA
024f5fc595
Translate 10.2-form-input-binding-sugar.md to Japanese
2015-07-15 09:20:29 +09:00
eriklharper
95a810ac01
Add more information about defaultValue
...
I came across an issue on a React project where I needed to programatically set the default value of an input as the result of an async call. (I was prepopulating a zip code field from the Google Maps Geocoding API). It didn't work when I passed in an updated defaultValue prop, until I came across this StackOverflow: http://stackoverflow.com/questions/30146105/react-input-defaultvalue-doesnt-update-with-state . I was able to get it to do what I wanted by passing in the value prop instead.
2015-07-14 13:28:55 -07:00
Jim
432d887f4a
Merge pull request #4377 from sugarshin/typo_docs
...
Delete unnecessary control code.
2015-07-14 10:27:19 -07:00
sugarshin
75a0049433
Delete unnecessary control code.
2015-07-15 00:39:52 +09:00
Jim
704ea0bb83
Merge pull request #4371 from tako-black/translate_animation_to_japanese
...
Translate 10.1-animation.md to Japanese
2015-07-14 00:00:10 -07:00
Kohei TAKATA
fe466e5842
Translate 10.1-animation.md to Japanese
2015-07-14 15:54:42 +09:00
Paul O’Shannessy
64dafb17a9
Merge pull request #4237 from jas14/issue-4226
...
Allow wrap attribute in textarea
2015-07-13 16:58:43 -07:00
Joe Stein
1b5bfb516a
Add wrap attribute
2015-07-13 15:00:03 -07:00
Bartosz Kaszubowski
ea2496b6f6
traverseAllChildren code clarity
2015-07-13 23:45:00 +02:00
Jim
9baaeec21d
Don't skip reconcilation if context differs
2015-07-13 14:21:38 -07:00
Paul O’Shannessy
4d178415e8
Merge pull request #4144 from lukehorvat/docs/iife-jsx
...
Add IIFE example to JSX documentation
2015-07-13 14:01:51 -07:00
Paul O’Shannessy
e9b3974d7c
Merge pull request #4291 from rwoodnz/patch-2
...
indicate file name requried for static file
2015-07-13 13:34:51 -07:00
Paul O’Shannessy
e9915f0735
Merge pull request #4357 from yangmillstheory/docfix
...
Warn against JSX transform failure for non-HTTP-served JSX
2015-07-13 13:20:09 -07:00
Victor Alvarez
36ee340fe5
Add warning for protocol sandboxing near pain point in Getting Started
2015-07-13 12:50:42 -07:00
Paul O’Shannessy
820c695612
Merge pull request #4355 from makky3939/use_html5_meta_charset_tag
...
Use html5 meta charset tag
2015-07-13 11:45:53 -07:00
Paul O’Shannessy
fa7aeb65ac
Merge pull request #4363 from tako-black/change_css_to_uppercase
...
Change `css` to uppercase
2015-07-13 10:35:22 -07:00
Kohei TAKATA
4715dec510
Change css to uppecase
2015-07-13 21:07:40 +09:00
Jim
bd390afc22
Merge pull request #4362 from makky3939/translate_04_self_closing_tag
...
Translate 4-self-closing-tag.md to Japanese
2015-07-12 22:15:25 -07:00
Masaki KOBAYASHI
3098a6f66e
Translate 04-self-closing-tag.md to Japanese
2015-07-13 12:38:24 +09:00
Jim
ea964e760c
Merge pull request #4356 from makky3939/fix_03-interactivity-and-dynamic-uis_ja-JP_md
...
Update 03-interactivity-and-dynamic-uis.ja-JP.md
2015-07-11 21:39:25 -07:00
Jim
0572747d74
Merge pull request #4358 from makky3939/remove_controll_character_from_jp_docs
...
Remove controll character from jp.md
2015-07-11 21:38:13 -07:00
Masaki KOBAYASHI
ec98fa9e3d
remove controll character from 07-forms.ja-JP.md, 10-addons.ja-JP.md and 10-addons.ja-JP.md
2015-07-12 11:39:05 +09:00
Masaki KOBAYASHI
ca34c57a5e
fix typo
2015-07-12 11:17:41 +09:00
Masaki KOBAYASHI
dee6726080
change http-equiv with charset
2015-07-12 10:54:54 +09:00
Jim
3ee65cc653
Merge pull request #4349 from makky3939/remove_type_attribute_in_script_tag
...
Remove type attribute in script tag
2015-07-11 11:40:37 -07:00
Jim
2b3d83fe34
Merge pull request #4351 from tako-black/translate_addons_to_japanese
...
Translate 10-addons.md to Japanese
2015-07-11 11:36:57 -07:00
Jim
13c9bb4845
Merge pull request #4348 from himkt/master
...
remove controll character from 02-displaying-data.ja-JP.md
2015-07-11 11:36:33 -07:00
Kohei TAKATA
b35de1db4e
Translate 10-addons.md to Japanese
2015-07-11 15:55:04 +09:00
Masaki KOBAYASHI
81e3b632fd
remove type="text/javascript"
2015-07-11 15:02:54 +09:00
himkt
41858a77a3
remove controll character from 02-displaying-data.ja-JP.md
2015-07-11 15:00:25 +09:00
Jim
7661d6c7da
Merge pull request #4346 from makky3939/fix_typo_09-tooling-integration_ja-JP_md
...
fix typo 09-tooling-integration.ja-JP.md
2015-07-10 21:56:02 -07:00
Masaki KOBAYASHI
445e99b7d9
fix typo
2015-07-11 13:50:42 +09:00
Jim
52ad6bc61a
Merge pull request #4324 from drd/improve-warning-in-react-mount
...
Improve warning in react mount
2015-07-10 11:06:32 -07:00
Paul O’Shannessy
f0caf89dad
Merge pull request #4342 from laiso/unexpected_character
...
Remove the unexpected character in ReactEventListener
2015-07-10 09:18:54 -07:00
laiso
804b109ba6
Remove the unexpected character in ReactEventListener
2015-07-11 01:00:21 +09:00
Paul O’Shannessy
441a6ec378
Merge pull request #4338 from dcousens/patch-1
...
s/currentPathElemenID/currentPathElementID
2015-07-09 23:56:50 -07:00
Paul O’Shannessy
4ec2575cd8
Merge pull request #4337 from tako-black/translate_tooling-integration_to_japanese
...
Translate 09.tooling-integration.md to Japanese
2015-07-09 23:53:01 -07:00
Daniel Cousens
dfe5f19917
s/currentPathElemenID/currentPathElementID
2015-07-10 16:38:39 +10:00
Cheng Lou
37cd9277a9
Merge pull request #4336 from zpao/ID-not-Id
...
ID not Id
2015-07-09 23:11:17 -07:00
Kohei TAKATA
e6832b5136
Translate 09.tooling-integration.md to Japanese
2015-07-10 15:09:26 +09:00
Paul O’Shannessy
7032e88c25
ID not Id
2015-07-09 22:49:26 -07:00
Jim
6c0ab0b60e
Merge pull request #4334 from tako-black/add_meta_tag_in_the_header_of_html
...
Add meta tag in the header of HTML in translated documentation.
2015-07-09 19:59:51 -07:00
Kohei TAKATA
a9e0b4a0a3
Change number of html{} to highlight correct line
2015-07-10 09:16:26 +09:00
Kohei TAKATA
87ecb0ba1f
Add meta tag in the header of HTML
2015-07-10 08:49:43 +09:00
Benjamin Woodruff
4d4e0bd699
Merge pull request #4330 from zpao/eslint-jest
...
Use jest for eslint-rules
2015-07-09 16:04:15 -07:00
Paul O’Shannessy
d967ea4658
Merge pull request #4332 from bgw/eslint-tests-use-jest
...
Run eslint tests with jest
2015-07-09 16:04:01 -07:00
Benjamin Woodruff
fc0b42dc07
Run eslint tests with jest
...
Turns out eslint-tester works with jest (!)
We take advantage of this internally at FB, so we'll do it here too.
Fixes #4328
2015-07-09 15:59:59 -07:00
Eric O'Connell
d2e8449bf0
Only perform expensive checks in __DEV__, clean up after inserted iframe
2015-07-09 15:49:49 -07:00
Paul O’Shannessy
44c98704ff
Use jest for eslint-rules
2015-07-09 15:40:52 -07:00
Paul O’Shannessy
78f1369380
Merge pull request #4329 from zpao/fix-jest
...
Reset module cache between tests
2015-07-09 15:31:32 -07:00
Paul O’Shannessy
d6183570e3
Reset module cache between tests
...
This ensures that module caches for warnings is reset between runs. This makes
it so the deprecations warnings always fire.
2015-07-09 15:24:43 -07:00
Jim
cf164f1aa2
Merge pull request #4327 from jimfb/markup-unit-test
...
Add unit test: should generate simple markup for attribute with `>` symbol
2015-07-09 15:05:08 -07:00
Jim
7b1f03f4f8
Merge pull request #4311 from jimfb/fix-input-events
...
Fix event target for input change events. Fixes #4288
2015-07-09 15:03:37 -07:00
Eric O'Connell
0941cc9884
Use a test case that demonstrates the fix.
2015-07-09 14:56:55 -07:00
Jim
b89f7ebff4
Add unit test: should generate simple markup for attribute with > symbol
2015-07-09 14:26:41 -07:00
Jim
75c4311a04
Merge pull request #4325 from jimfb/self-closing-checksum
...
Fix checksum hash attribute insertion for self-closing root tags. Fixes #4323
2015-07-09 14:23:07 -07:00
Jim
dfeeb3f673
Fix checksum hash attribute insertion for self-closing root tags. Fixes #4323
2015-07-09 14:21:40 -07:00
Eric O'Connell
902b607f1f
Fix some lint
2015-07-09 14:06:42 -07:00
Eric O'Connell
1316160b86
Properly handle rendering into document when comparing markup
2015-07-09 11:48:42 -07:00
Jim
a9e2111b34
Merge pull request #4320 from tako-black/translate_more-about-refs_to_japanese
...
Translate 08.1-more-about-refs.md to Japanese
2015-07-09 08:25:56 -07:00
Jim
34c8b2366c
Merge pull request #4317 from koba04/add-deprecation-warning-for-clonewithprops
...
Add runtime deprecation warning for cloneWithProps
2015-07-09 08:24:20 -07:00
Toru Kobayashi
17a4dc83e0
Add runtime deprecation warning for cloneWithProps
2015-07-09 19:12:26 +09:00
Kohei TAKATA
55c3d92bc8
Translate 08.1-more-about-refs.md to Japanese
2015-07-09 18:41:19 +09:00
Paul O’Shannessy
59eddf8943
Merge pull request #4319 from tako-black/enclose_a_name_of_function_in_back_quote
...
Enclose a name of function in back quote
2015-07-08 23:13:59 -07:00
Kohei TAKATA
ecb483f307
Enclose a name of function in back quote
2015-07-09 15:11:20 +09:00
Eric O'Connell
0249adf3db
Handle escaping when comparing server/client markup
2015-07-08 20:31:10 -07:00
Paul O’Shannessy
84efb8a4f3
Merge pull request #4318 from jlongster/master
...
respect NODE_ENV environment variable if set when building
2015-07-08 15:14:59 -07:00
Jim
418e03e96e
Merge pull request #4309 from mmoss/addons-warning-fix
...
Concatenate warning message, due to parsing issues
2015-07-08 12:17:35 -07:00
James Long
ce61a49bca
respect NODE_ENV environment variable if set when building
2015-07-08 14:45:21 -04:00
Murray M. Moss
334372758c
Add comment to explain string concatenation
2015-07-08 13:26:36 -04:00
Murray M. Moss
fa4063455b
Concatenate warning message, due to parsing issues
...
The addons module warning is currently causing issues with babel/JSPM due to the warning message getting parsed as a require statement. Adding a break using string concatenation appears to prevent any issues.
Example error using JSPM:
```
Error loading "react-addons-{addon}" from...
```
2015-07-08 13:24:01 -04:00
Paul O’Shannessy
6eaf03df1a
Merge pull request #4314 from devonharvey/patch-1
...
Fix typo on line 91 of tutorial.md
2015-07-08 09:30:49 -07:00
Devon Harvey
b3ae6891b7
Fix typo on line 91 of tutorial.md
2015-07-07 22:16:14 -07:00
Jim
c3f0d7c6bd
Merge pull request #4312 from tako-black/translate_working-with-the-browser_to_japanese
...
Translate 08-working-with-the-browser.md to Japanese
2015-07-07 20:09:13 -07:00
Kohei TAKATA
5d7f24c67f
Translate 08-working-with-the-browser.md to Japanese
2015-07-08 09:21:09 +09:00
Jim
4b804e485d
Fix event target for input change events. Fixes #4288
2015-07-07 17:14:52 -07:00
Jim
ed0d41bb88
Merge pull request #4310 from tako-black/enclose_a_value_of_variable_in_back_quote
...
Enclose a value of variable in back quote
2015-07-07 16:27:30 -07:00
Kohei TAKATA
4dbb8b307c
Enclose a value of variable in back quote
2015-07-08 08:24:42 +09:00
Richard Wood
24c41b6849
Add backticks to highlight comment.json file name
2015-07-08 10:16:21 +12:00
Jim
abf965c3c5
Merge pull request #4290 from rwoodnz/patch-1
...
Suggest open index.html in browser regularly.
2015-07-07 15:08:27 -07:00
Frankie Bagnardi
335f7d5e57
Blog: move "refs to custom components..." fixes #4305
...
Just to prevent the TL;DR confusion. Separate paragraph and moved up above the code block. `s/References/Refs` for consistency.
2015-07-06 19:28:23 -07:00
Kevin Coughlin
e685da53ee
Clarify React.render note in documentation
2015-07-06 21:47:37 -04:00
Jim
2284c0f449
Merge pull request #4299 from tako-black/enclose_a_value_in_back_quote
...
Enclose a value of variable in back quote
2015-07-06 08:20:47 -07:00
Jim
25be80c959
Merge pull request #4300 from tako-black/translate_forms_to_japanese
...
Translate 07-forms.md to Japanese
2015-07-06 08:20:03 -07:00
Kohei TAKATA
b66a520d13
Translate 07-forms.md to Japanese
2015-07-06 19:17:52 +09:00
Kohei TAKATA
f0a7b5df64
Enclose a value of variable in back quote
2015-07-06 17:57:44 +09:00
Jim
500d4c3f87
Merge pull request #4209 from aruberto/iterable_node_proptype
...
Allow iterables to pass node prop type check
2015-07-05 17:19:37 -07:00
Jim
a8955e7c3e
Merge pull request #4292 from dariocravero/patch-1
...
Update 2015-07-03-react-v0.14-beta-1.md
2015-07-05 17:01:24 -07:00
Jim
19e1918ccd
Merge pull request #4287 from Simek/semicolon-cleanup
...
semicolon cleanup
2015-07-05 15:55:09 -07:00
Darío Javier Cravero
8f9800193c
Update 2015-07-03-react-v0.14-beta-1.md
...
Highlight all packages names so that they're easier to read /cc @spicyj
2015-07-05 14:39:24 +01:00
Richard Wood
50ea437bf8
indicate file name requried for static file
...
the text doesn't say explicitly to call your file comments.json, nor to put it in the public directory.
2015-07-05 23:38:23 +12:00
Richard Wood
a9d0135f84
Suggest open index.html in browser regularly.
2015-07-05 23:05:53 +12:00
Paul O’Shannessy
a4034b37eb
Merge pull request #4283 from Yeti-or/patch-1
...
Remove unnecessary semicolon;
2015-07-05 16:02:50 +07:00
Paul O’Shannessy
3b54d5cd57
Merge pull request #4284 from Simek/patch-3
...
add IntelliJ IDEA project related ignores
2015-07-05 15:59:57 +07:00
Paul O’Shannessy
5370987cc0
Merge pull request #4289 from joshuago/patch-1
...
Fix typos
2015-07-05 15:56:11 +07:00
Joshua Go
1c831b186c
Fix typos
...
Just s/Javascript/Javascript/g and punctuation changes.
2015-07-05 00:15:08 -07:00
Bartosz Kaszubowski
7a2be27d63
semicolon cleanup
...
One unnecessary semicolon removed and few missing added.
2015-07-05 01:06:04 +02:00
Bartosz Kaszubowski
3ac6dfa5f7
add IntelliJ IDEA project related ignores
2015-07-04 21:27:33 +02:00
Vasiliy
01535bfc18
Remove unnecessary semicolon;
...
For the God of css
2015-07-04 21:43:12 +03:00
Ben Alpert
cb5913a842
Fix react-addons-update package name
2015-07-04 17:26:24 +02:00
Ben Alpert
d0d57ad7a3
Merge pull request #4278 from koba04/fix-addons-update-package
...
Fix a library path for react-addons-updates
2015-07-04 17:22:58 +02:00
Toru Kobayashi
ddf27b6299
Rename react-addons-updates to react-addons-update
2015-07-04 16:53:16 +09:00
Jim
5a7019de7b
Merge pull request #3798 from levibuzolic/attribute-inputmode
...
Add inputMode to allowed HTML DOM properties
2015-07-03 17:23:13 -07:00
Levi Buzolic
3b2df5fd9c
Add inputMode to HTML DOM Property Whitelist
2015-07-04 02:17:22 +02:00
Ben Alpert
10f8e22e20
Add missing semicolon
2015-07-03 10:53:00 +02:00
Ben Alpert
b2db10f43e
beta1 blog post
...
Closes #4275 .
2015-07-03 10:46:36 +02:00
Ben Alpert
b4e74e38e4
Bump version to beta1
2015-07-03 10:46:35 +02:00
Ben Alpert
41aa3496aa
Add setProps/replaceProps warning
2015-07-03 10:46:35 +02:00
Ben Alpert
2b68ea21ee
Removed most uses of setProps in unit tests
...
Picked from 721fe73541 .
2015-07-03 10:46:35 +02:00
Ben Alpert
4eb889b72e
Revert "Removed setProps and replaceProps (both previously deprecated)"
...
This reverts commit 721fe73541 . We'll keep these with a warning for one more release.
2015-07-03 10:46:35 +02:00
Jim
2d86486fd1
Merge pull request #4276 from tako-black/translate_transferring-props_to_japanese
...
Translate 06-transferring-props.md to Japanese
2015-07-02 20:34:59 -07:00
Kohei TAKATA
680d4e7933
Translate 06-transferring-props.md to Japanese
2015-07-03 09:49:17 +09:00
Ben Alpert
ee85efc03c
Merge pull request #4273 from spicyj/addons
...
Finish addons packaging
2015-07-02 23:39:04 +02:00
Ben Alpert
33d5201a94
Finish addons packaging
...
- Add missing object-assign dependency
- Add batchedUpdates to ReactDOMClient, rename the two addons to `unstable_`
- Delete react/addons/* (leaving react/addons with a slightly updated warning)
- Add README.md, LICENSE, PATENTS to each addons package
2015-07-02 23:33:16 +02:00
Ben Alpert
a88c3c9f85
Merge commit 'pr/4185'
...
Closes #4185 .
2015-07-02 23:05:15 +02:00
Ben Alpert
0eaa0a6ff7
Fix jest tests
2015-07-02 22:54:22 +02:00
Ben Alpert
07107ca936
Merge pull request #4184 from zpao/move-from-addons
...
Move renderSubtreeIntoContainer into ReactDOMClient
2015-07-02 22:53:47 +02:00
Jim
ddffc7cebe
Merge pull request #4270 from kamronbatman/patch-1
...
Fixed header comment spacing in ReactComponentWithPureRenderMixin.
2015-07-02 10:31:48 -07:00
Kamron Batman
72b432df03
Fixed header comment spacing.
...
Fixed header comment spacing in the header for ReactComponentWithPureRenderMixin.
2015-07-02 09:36:52 -07:00
Jim
2baf4bf4e8
Merge pull request #4268 from jimfb/remove-setprops
...
Removed setProps and replaceProps (both previously deprecated)
2015-07-02 04:47:18 -07:00
Jim
6a92179d6f
Merge pull request #4221 from jimfb/ryans-context-bug
...
updateComponent should update the context iff it has changed
2015-07-02 04:45:41 -07:00
Jim
851378b0b2
Merge pull request #4150 from jimfb/event-path
...
Make events propagate through shadow DOMs.
2015-07-02 04:35:44 -07:00
Jim
4a465fbd9a
Make events propagate through shadow DOMs.
2015-07-02 04:32:22 -07:00
Jim
721fe73541
Removed setProps and replaceProps (both previously deprecated)
2015-07-02 04:00:58 -07:00
Paul O’Shannessy
d268a9fbe3
Merge pull request #4238 from bhamodi/bhamodi/update-dependency-notation
...
More conservative dependency update.
2015-07-02 10:27:26 +07:00
Jim
8953033454
Merge pull request #4259 from janraasch/patch-1
...
Add IE-only security attr to HTMLDOMPropertyConfig
2015-07-01 18:15:39 -07:00
Jim
feee7a1868
Merge pull request #4231 from DarkScorpion/clickCounter
...
Click counter example
2015-07-01 17:46:43 -07:00
Jim
bde585f4e0
Merge pull request #4262 from coryhouse/patch-1
...
Removed redundant word
2015-07-01 17:37:53 -07:00
Jim
c3e411a0dc
Merge pull request #4266 from tako-black/translate_reusable-components_to_japanese
...
Translate 05-reusable-components.md to Japanese
2015-07-01 17:04:29 -07:00
Kohei TAKATA
f5e0d0c8f2
Translate 05-reusable-components.md to Japanese
2015-07-02 08:44:42 +09:00
Jan Raasch
b089b427ab
Add IE-only security attr to HTMLDOMPropertyConfig
...
See https://msdn.microsoft.com/en-us/library/ms534622(v=vs.85).aspx for an in-depth specification.
This fixes #4169 .
2015-07-01 19:47:48 +02:00
Cory House
e869c58a1d
Removed redundant word
2015-07-01 11:26:31 -05:00
Sebastian Markbåge
8f9643485d
Merge pull request #4162 from sebmarkbage/updator
...
Inject the update queue into classes
2015-07-01 17:46:05 +02:00
Ben Alpert
9f0042cd8d
Merge pull request #4258 from mjomble/patch-1
...
Typo fix
2015-06-30 15:57:37 +02:00
Andres Kalle
af2071af63
Typo fix
2015-06-30 15:05:57 +03:00
Alex Smith
83c8118c7c
update title
2015-06-30 19:43:44 +09:00
Alex Smith
6b669aa37d
used JSX
2015-06-30 17:49:25 +09:00
Alex Smith
099c227c35
lowercase index file
2015-06-30 17:26:50 +09:00
Jim
ae9b2c0649
Merge pull request #4252 from bhamodi/patch-2
...
Update url to save a redirect
2015-06-29 10:28:29 -07:00
Baraa Hamodi
91de455909
Update React Link
...
Saves a redirect from occurring.
2015-06-29 10:21:35 -07:00
Ben Alpert
454d47fa09
Merge pull request #4223 from spicyj/check-no-warn
...
Fail tests on any un-spied warnings
2015-06-29 07:57:56 -07:00
Ben Alpert
c22153e25a
Fail tests on any un-spied warnings
...
Fixes #3890 .
2015-06-29 07:57:35 -07:00
Jim
d9d442808a
Merge pull request #4249 from tako-black/translate_multiple-components_to_japanese
...
Translate 04-multiple-components.md to Japanese
2015-06-29 05:15:33 -07:00
Kohei TAKATA
d32f8b5a38
Translate 04-multiple-components.md to Japanese
2015-06-29 21:11:39 +09:00
Paul O’Shannessy
859a5d5c3c
Merge pull request #4229 from tako-black/translate_jsx-spread_to_japanese
...
Translate 02.2-jsx-spread.md to Japanese
2015-06-28 23:59:34 -07:00
Paul O’Shannessy
dd3244c4f2
Merge pull request #4242 from tako-black/translate_interactivity-and-dynamic-uis_to_japanese
...
Translate 03-interactivity-and-dynamic-uis.md to Japanese
2015-06-28 23:57:20 -07:00
Kohei TAKATA
308db9a866
Translate 03-interactivity-and-dynamic-uis.md to Japanese
2015-06-28 19:31:47 +09:00
Matthew King
fc63cebd29
Stop building react-source gem
...
fixes #4069
2015-06-27 13:44:08 -07:00
Jim
e695ebb5c6
Merge pull request #4240 from tako-black/translate_jsx-gotchas_to_japanese
...
Translate 02.3-jsx-gotchas.md to Japanese
2015-06-27 09:20:09 -07:00
Kohei TAKATA
19e1d11d2f
Translate 02.3-jsx-gotchas.md to Japanese
2015-06-27 19:11:40 +09:00
Ben Alpert
6bbd6976eb
Merge pull request #4239 from tako-black/change_word_to_uppercase
...
Change 'Javascript' to 'JavaScript'
2015-06-27 03:01:49 -07:00
Kohei TAKATA
aefb608fd6
Change 'Javascript' to 'JavaScript'
2015-06-27 18:49:41 +09:00
Alex Smith
67c70b8690
R: handleClick function
2015-06-27 12:13:29 +09:00
Baraa Hamodi
c1ec407bd9
More conservative dependency update.
2015-06-26 18:37:15 -07:00
Jim
5fb8cbc6ca
Merge pull request #4232 from marocchino/update-docs
...
Update translated docs
2015-06-26 10:22:01 -07:00
Shim Won
ca6fa4b7e6
Add site title to first code snippet of getting started ( bd9d4b2)
2015-06-26 19:39:44 +09:00
Shim Won
c1b0550acf
Update script source ( c227a39)
2015-06-26 19:39:25 +09:00
Alex Smith
2b554703af
add new line at and of some files
2015-06-26 13:50:43 +09:00
Alex Smith
e58d31022c
update click message
2015-06-26 13:39:59 +09:00
Alex Smith
456135eb04
rename folder
2015-06-26 13:35:30 +09:00
Alex Smith
d19aa7a363
use react from bild
2015-06-26 13:34:20 +09:00
Alex Smith
e766d5539e
click conter example
2015-06-26 13:08:32 +09:00
Alex Smith
578077081f
update git ignore
2015-06-26 12:55:25 +09:00
Kohei TAKATA
829ce68cd7
Translate 02.2-jsx-spread.md to Japanese
2015-06-26 09:55:04 +09:00
Jim
289962f6f8
Don't bail out of reconsiliation if context changes.
2015-06-25 00:58:05 -07:00
Ben Alpert
ef00e856aa
Merge pull request #4204 from dpercy/patch-1
...
Fix docs typo: "overridden" -> "overwritten"
2015-06-24 23:18:23 -07:00
Jim
9bcc8dab93
Merge pull request #4222 from tako-black/translate_jsx-in-depth_to_japanese
...
Translate 02.1-jsx-in-depth.ja-JP.md to Japanese
2015-06-24 22:48:58 -07:00
Kohei TAKATA
f460a19d8a
Translate 02.1-jsx-in-depth.ja-JP.md to Japanese
2015-06-25 14:46:19 +09:00
li.li
63d0471580
Remove warnings in tests
...
For #3890 .
Squashed merge, closes #3925 .
2015-06-24 22:01:36 -07:00
Ben Alpert
0b0a436a41
Drop react-codemod.tgz from travis build
...
This didn't work anyway. See #4217 .
2015-06-24 18:41:34 -07:00
Ben Alpert
d87f50aab8
Merge pull request #4217 from brigand/patch-5
...
Fix travis after_script
2015-06-24 18:38:38 -07:00
Frankie Bagnardi
0677fe8f3b
Fix travis artifact upload
...
Changes:
- moves after_script to script
- adds `set -e`
- creates a seperate matrix 'build'
Way at the bottom of the travis output:
```
1571: curl: (26) couldn't open file "build/react.tgz"
```
This seems to be broken since 12c9fee94e
2015-06-24 18:09:34 -07:00
Ben Alpert
8f217c8a4b
Merge pull request #4215 from spicyj/prod-props
...
Set this.props on elements in prod mode
2015-06-24 16:38:14 -07:00
Ben Alpert
9ba28f317b
Merge pull request #4200 from spicyj/ten-thousand
...
Allow deeper trees
2015-06-24 16:33:30 -07:00
Ben Alpert
9c8c11dd07
Set this.props on elements in prod mode
...
Oops. Introduced in https://github.com/facebook/react/pull/4172 .
2015-06-24 16:26:40 -07:00
Antonio Ruberto
79fc73e674
check entry type iterables
...
check that the value is a node for map iterables
2015-06-24 15:17:48 -04:00
Jim
4431c90fa4
Merge pull request #4208 from battaile/master
...
Minor cleanup of ReactES6Class-test output by expecting the warning
2015-06-24 08:18:44 -07:00
Jim
484e20c02d
Merge pull request #4206 from yiminghe/fix_change_type
...
Set change event type in SyntheticEvent
2015-06-24 08:05:52 -07:00
Jim
b99fb2c92d
Merge pull request #4202 from tako-black/translate_displaying-data_to_japanese
...
Translate 02-displaying-data.md to Japanese
2015-06-24 07:42:48 -07:00
Antonio Ruberto
8e72956430
Allow iterables to pass node prop type check
2015-06-24 09:43:02 -04:00
Battaile Fauber
41df3ce421
Check for warning when testing to see if error is thrown when render not defined
2015-06-24 08:03:36 -04:00
Ben Alpert
e80cccf87f
Merge pull request #4207 from yangshun/patch-1
...
Add site title to first code snippet of getting started
2015-06-24 02:24:04 -07:00
yiminghe
ee831d7550
optimize spec
2015-06-24 17:13:41 +08:00
Tay Yang Shun
bd9d4b2499
Add site title to first code snippet of getting started
2015-06-24 17:09:34 +08:00
yiminghe
47e9cfb975
fix change event type
2015-06-24 17:06:35 +08:00
David Percy
78018b99d6
Fix docs typo: "overridden" -> "overwritten"
...
I think this was meant to say "overwritten", since "the statement overwrites the data" makes more sense than "the statement overrides the data".
2015-06-24 01:54:54 -04:00
Kohei TAKATA
af34ca7b41
Translate 02-displaying-data.md to Japanese
2015-06-24 09:23:05 +09:00
Jim
3dc43840ef
Merge pull request #4188 from jisaacks/master
...
Generate reasonable markup even if tags have unexpected case.
2015-06-23 15:04:36 -07:00
JD Isaacks
d944d3f941
Prevent creating invalid closing tags
...
fixes #2756
2015-06-23 17:58:52 -04:00
Ben Alpert
fdaefc1103
Allow deeper trees
...
No reason to limit at 100. I can't imagine a reasonable tree with depth over 10,000 but that should still be small enough to "catch infinite loops" quickly.
2015-06-23 14:07:05 -07:00
Ben Alpert
c5fb3ff987
Merge pull request #4139 from spicyj/dom-refs
...
DOM components as refs
2015-06-22 16:58:01 -07:00
Ben Alpert
06b88c38f9
Merge pull request #4084 from spicyj/carc
...
Remove constructAndRenderComponent
2015-06-22 16:57:52 -07:00
Ben Alpert
d810079101
Remove constructAndRenderComponent
...
These were never part of the public API and shouldn't have been part of the React object. Now they're not.
2015-06-22 16:55:19 -07:00
Ben Alpert
eefda9377c
Add legacy methods to DOM components for compatibility
2015-06-22 16:51:21 -07:00
Ben Alpert
ffd527f593
DOM components as refs
...
Still missing: .props/.getDOMNode warnings.
2015-06-22 16:51:21 -07:00
Ben Alpert
643651b8e5
Wrap all top-level components for consistency
2015-06-22 16:51:04 -07:00
Sebastian Markbåge
9d2c9b5864
Merge pull request #4196 from oluckyman/componentDidUnmount-warning
...
Show warning when componentDidUnmount is defined
2015-06-22 16:48:27 -07:00
oluckyman
2568933ca3
Update warn message and move it to the error-catching block
2015-06-22 23:52:37 +02:00
Jim
859b7957b7
Merge pull request #4190 from dantman/fix-%s-module
...
Don't try building a %s module.
2015-06-22 14:45:19 -07:00
Ben Alpert
7e0a544ae3
Merge pull request #4164 from spicyj/jest-wc
...
Fix exceptions when running `grunt test --debug`
2015-06-22 14:22:41 -07:00
oluckyman
db40beafbe
Show warning when componentDidUnmount is defined
...
Fixes #4194
2015-06-22 21:09:33 +02:00
Daniel Friesen
357ed8ebd7
Add a comment about why the string is split up. For future readers of this file.
2015-06-22 12:04:29 -07:00
Daniel Friesen
c8d606196d
Don't try building a %s module.
...
React's build tools are reading the `require("react")` and `react("%s")` inside the warning string and thinking they are actual requires.
2015-06-21 21:14:04 -07:00
Paul O’Shannessy
79561342c3
Build standalone react-addons packages
2015-06-21 20:01:21 +08:00
Paul O’Shannessy
bbadc15ac1
Move renderSubtreeIntoContainer into ReactDOMClient
2015-06-20 18:08:33 -07:00
Ben Alpert
df05c6efb8
Fix typo in blog post
...
(#4183 )
2015-06-20 16:49:33 -07:00
Ben Alpert
64b5f043dd
Merge pull request #4170 from johanneslumpe/patch-1
...
Guard against a null node
2015-06-20 16:42:23 -07:00
Jim
ede27d2e86
Merge pull request #4172 from jimfb/freeze-props
...
Freeze ReactElement.props in dev mode
2015-06-19 14:13:17 -07:00
Johannes Lumpe
b16f9d42b1
Guard against a null node
...
This could fix #2619
2015-06-19 11:21:22 +03:00
Sebastian Markbåge
59dfe87d04
Merge pull request #4171 from sebmarkbage/simplifylifecycle
...
Simplified Life Cycles
2015-06-18 23:16:27 -07:00
Sebastian Markbage
c1330dcfcd
Unit tests for unmounted setState and isMounted
2015-06-18 22:55:52 -07:00
Jim
95373ce769
Freeze ReactElement.props in dev mode
2015-06-18 14:49:06 -07:00
Sebastian Markbage
8659223939
Lint fixes
2015-06-18 14:12:21 -07:00
Sebastian Markbage
dddebd1344
Use hack to support isMounted without stateful module
...
This hack allow us to get rid of the stateful module ReactLifeCycle since
we can infer the value of isMounted even without it. This gets rid of
the try/catch which is deopting all mountComponent calls.
As a next step we could deprecate isMounted completely and avoid stateful
APIs. Since it can be easily simulated if you truly need it.
2015-06-18 14:10:12 -07:00
Sebastian Markbage
140af9b985
Allow callbacks to be enqueued during componentWillMount
...
Since I fixed the server-side rendering it is now possible to trigger these
callbacks on the client alone. They will still be queued up on the server
but they are never executed.
2015-06-18 13:35:39 -07:00
Sebastian Markbage
e737acb472
Let updates be enqueued during render
...
This allows updates to be enqueued during render. setState in
componentWillMount will still be collected as part of the first pass so
if nothing else get added as pending, they won't trigger a second rerender.
This allow us to get rid of one more stateful special case.
2015-06-18 13:35:39 -07:00
Sebastian Markbage
40b7c19a89
Use a custom batching strategy for server rendering
...
This simply ignores any enqueued actions. This means that we don't have to have special logic for componentWillMount. It is just that those updates are never enqueued.
2015-06-18 13:34:30 -07:00
Sebastian Markbage
3af73834d9
Remove currentlyUnmountingComponent
...
This was used for any invariant that was subsequently removed. It turns
out that this is completely unnecessary now. Any setState calls will
enqueue and update and the component added to the update queue. However,
since the pending fields are reset after componentWillUnmount, any update
will still be ignored.
2015-06-18 12:36:50 -07:00
Sebastian Markbage
7443f63ae9
Remove an unnecessary warning
...
It was impossible to get here because if you enqueue something
Also ensure that they're only used in DEV because we will be reading
state that is DEV only here.
2015-06-18 12:36:45 -07:00
Sebastian Markbage
c4cafcecd9
Move current owner to isomorphic
...
This should only be used for tracking string refs. For that purpose, we
need a single central stateful module that is coupled to createElement.
Which is why it needs to live in isomorphic.
Eventually this will go away completely.
2015-06-18 09:05:35 -07:00
Ben Alpert
d76e3e1632
Fix exceptions when running grunt test --debug
2015-06-17 20:57:04 -07:00
Sebastian Markbage
1224a203bb
Inject the update queue into classes
...
This decouples the stateful imperative API from the class creation.
Instead, they get injected into the class from the renderer. Stateful
modules should always be injected.
As a convenience, just like props/context/refs, we set it up after
construction using mutation. That way it is optional to pass it along
the super call constructor chain.
2015-06-17 18:57:26 -07:00
Ben Alpert
016021207c
Merge pull request #4154 from spicyj/gh-3478
...
Improve error message when mounting non-string/function elements
2015-06-17 16:26:02 -07:00
Paul O’Shannessy
a841b4f5fb
Merge pull request #2981 from hzoo/jsdoc-fixes
2015-06-17 16:06:37 -07:00
Paul O’Shannessy
531e6280a3
Merge pull request #4158 from zpao/mv-packages
...
Move npm packages into folder
2015-06-17 12:18:37 -07:00
Ben Alpert
642323e5a8
Improve error message when mounting non-string/function elements
2015-06-17 12:04:05 -07:00
Paul O’Shannessy
12c9fee94e
Move npm packages into folder
2015-06-17 12:01:44 -07:00
Paul O’Shannessy
ec791582f4
Merge pull request #4156 from tako-black/fix_link
...
Fix link of getting-started.ja-JP.md
2015-06-17 11:53:21 -07:00
Paul O’Shannessy
10ada3b5f5
Merge pull request #4157 from zpao/svg-image
...
Support SVG image, other related cleanup
2015-06-17 11:44:29 -07:00
Paul O’Shannessy
ace49f304b
Merge pull request #4100 from zpao/deprecate-react-calls
...
Deprecate non-isomorphic react methods in npm module
2015-06-17 11:15:46 -07:00
Paul O’Shannessy
bdbbe40b1e
Merge pull request #4140 from zpao/mv-errorutils
...
Move ReactErrorUtils out of vendor
2015-06-17 10:51:02 -07:00
Paul O’Shannessy
efdd75685d
Support SVG image
2015-06-17 10:47:53 -07:00
Paul O’Shannessy
572a1d895c
Update getMarkupWrap with list of SVG supported in ReactDOM
2015-06-17 10:40:11 -07:00
Paul O’Shannessy
265fdc3eed
Rewrite SVG initialization in getMarkupWrap
2015-06-17 10:37:13 -07:00
Kohei TAKATA
3c53d25587
Fix link of getting-started.ja-JP.md
2015-06-17 22:17:47 +09:00
Ben Alpert
c265504fe2
Merge pull request #4152 from spicyj/rce
...
Disallow passing a DOM component to reactComponentExpect
2015-06-16 23:33:09 -07:00
Ben Alpert
306c2dd5a9
Merge pull request #4151 from spicyj/fairti
...
Disallow passing a DOM component to findAllInRenderedTree
2015-06-16 23:32:53 -07:00
Ben Alpert
cf6b3ff0e2
Disallow passing a DOM component to reactComponentExpect
...
We won't be able to support this after DOM-components-as-refs but we don't expect many people to be passing DOM components to this function anyway, and it should be fairly straightforward for people to clean up failing unit tests using this function.
(This module also isn't public API and never has been.)
2015-06-16 17:51:06 -07:00
Ben Alpert
4070c4ca20
Disallow passing a DOM component to findAllInRenderedTree
...
We won't be able to support this after DOM-components-as-refs but we don't expect many people to be passing DOM components to this function anyway, and it should be fairly straightforward for people to clean up failing unit tests using this function.
2015-06-16 16:37:37 -07:00
Ben Alpert
c9b0c26966
Invert logic in findAllInRenderedTreeInternal
...
With DOM components we won't be able to go from public instance to internal instance reliably, so do the traversal on internal instances.
2015-06-16 14:38:03 -07:00
Paul O’Shannessy
e571b32061
Wrap calls to deprecated functions with a warning.
2015-06-16 13:23:40 -07:00
Paul O’Shannessy
f306ed65b3
Merge pull request #4121 from cristovaov/tutorial-doc/script-src
...
update script sources to be even with the example file ...
2015-06-16 12:37:20 -07:00
Paul O’Shannessy
6248abb6ee
Merge pull request #4142 from zpao/lint-changed
...
npm script to run lint only on changed files
2015-06-16 11:41:28 -07:00
Paul O’Shannessy
ddac9473ca
npm script to run lint only on changed files
2015-06-16 11:24:02 -07:00
Ben Alpert
efcf2e318e
Merge pull request #4145 from RReverser/patch-1
...
Update 2015-06-12-deprecating-jstransform-and-react-tools.md
2015-06-16 10:57:50 -07:00
Sebastian Markbåge
2d29691019
Merge pull request #4105 from sebmarkbage/moveismounted
...
Move isMounted logic into the ReactUpdateQueue
2015-06-16 10:36:04 -07:00
Ingvar Stepanyan
cab21c7783
Update 2015-06-12-deprecating-jstransform-and-react-tools.md
...
Add paragraph about parsing JSX after deprecation of esprima-fb.
2015-06-16 16:18:18 +03:00
Luke Horvat
9a2e5f2cc5
Add IIFE example to JSX documentation
2015-06-16 19:46:25 +10:00
Paul O’Shannessy
93be1939b5
Move ReactErrorUtils out of vendor
...
Some other small changes now that it's linted.
2015-06-16 01:16:17 -07:00
Ben Alpert
78da37da50
Merge pull request #4137 from spicyj/setpropsinternal
...
Remove _setPropsInternal
2015-06-15 23:33:14 -07:00
Ben Alpert
ee367a8a02
Remove _setPropsInternal
...
Nothing uses this.
2015-06-15 23:28:27 -07:00
Ben Alpert
d67f23fb0e
Merge pull request #4115 from spicyj/dom-hash
...
Reduce hash lookups for DOM properties
2015-06-15 14:15:55 -07:00
alexpien
f1e524b0b1
Add support for appear and appear-active classes
2015-06-15 12:05:18 -07:00
Paul O’Shannessy
a2862f3c2f
Merge pull request #4097 from zpao/react-dom-package
...
Build react-dom package
2015-06-15 12:04:44 -07:00
Paul O’Shannessy
3bae8f5f35
Build react-dom package
2015-06-15 11:01:39 -07:00
Paul O’Shannessy
193773e349
Merge pull request #4103 from marocchino/ko-update
...
Update Korean transltaion to 4c778e2
2015-06-15 10:56:40 -07:00
Paul O’Shannessy
f8ffb0f8b3
Merge pull request #4132 from tako-black/translate_why-react_to_japanese
...
Translate 01-why-react.md to Japanese
2015-06-15 10:51:32 -07:00
Kohei TAKATA
1d3906f91d
Translate 01-why-react.md to Japanese
2015-06-15 21:30:12 +09:00
Cristovao Verstraeten
c227a398ba
update script sources to be even with the example file in reactjs/react-tutorial repo ... apply to japanese and korean translation (+2 squashed commit)
...
Squashed commit:
[4564e55] Ensures we don't need to update this page for every release.
[b0d60f9] update script sources to be even with the example file in reactjs/react-tutorial repo
2015-06-15 13:30:15 +02:00
Paul O’Shannessy
cfe428e510
Merge pull request #4128 from prathamesh-sonpatki/more-typos
...
Fix typos in ReactServerRenderingTransaction.js
2015-06-15 00:32:53 -07:00
Prathamesh Sonpatki
7b0764b1d2
Fix typos in ReactServerRenderingTransaction.js
...
- There were some more occurrences of typos fixed in
https://github.com/facebook/react/pull/4123 .
2015-06-15 12:42:45 +05:30
Paul O’Shannessy
80cc63ffce
Merge pull request #4123 from carterchung/patch-1
...
Corrected spelling in ReactReconcileTransaction.js
2015-06-15 00:03:47 -07:00
Carter Chung
c01352232b
Corrected spelling
...
ReactReconcileTransaction.js
2015-06-13 18:21:17 -07:00
Ben Alpert
da40027dfd
Merge pull request #4119 from iamdustan/patch-1
...
s/parse/parser in jstransform deprecation blog post
2015-06-12 21:52:13 -07:00
Ben Alpert
434a64a08a
Merge pull request #4114 from spicyj/void-warn
...
Add owner to void element children warning
2015-06-12 21:41:24 -07:00
Ben Alpert
99b89ff1b3
Add owner to void element children warning
2015-06-12 21:37:51 -07:00
Dustan Kasten
54e77a251c
s/parse/parser in jstransform deprecation blog post
2015-06-12 23:57:49 -04:00
Ben Alpert
40963e503b
Reduce hash lookups for DOM properties
2015-06-12 17:10:26 -07:00
Paul O’Shannessy
26cc5e1c43
[blog] Deprecate JSTransform & react-tools
2015-06-12 16:45:15 -07:00
Paul O’Shannessy
830bc92d36
Merge pull request #4112 from kevhuang/doc/readme-grammar
...
Remove extra period
2015-06-12 12:10:12 -07:00
Kevin Huang
7e27772625
Remove extra period
2015-06-12 11:29:26 -07:00
Sebastian Markbåge
a1cf88b098
Merge pull request #4091 from sebmarkbage/updatequeuewarning
...
Make setState in render a warning, not an invariant
2015-06-11 18:41:46 -07:00
Sebastian Markbage
ffd5b16d5f
Move isMounted logic into the ReactUpdateQueue
...
This is kind of a confusing place for it but it is intimitely tied to the
update life cycle which is what the update queue is about.
This kills some dependencies from isomorphic to the renderer.
2015-06-11 18:39:13 -07:00
Shim Won
e67c0943b8
Update Korean transltaion to 4c778e2
2015-06-12 10:24:07 +09:00
Benjamin Woodruff
e4abdcb31b
Merge pull request #4102 from tomarak/patch-1
...
Fixed grammar in CLA section of contribution guide
2015-06-11 17:57:32 -07:00
Anuj Tomar
61ef4a24cb
Fixed grammar in CLA section of contribution guide
...
took out quotation marks from CLA header as per MLA standards
2015-06-11 17:49:46 -07:00
Ben Alpert
4c778e2e4b
Merge pull request #4098 from spicyj/grunt
...
Inline requires in Gruntfile
2015-06-11 15:14:09 -07:00
Ben Alpert
67a98468b2
Inline requires in Gruntfile
...
I think this makes it quite a bit easier to understand.
2015-06-11 15:00:30 -07:00
Paul O’Shannessy
128390a691
Merge pull request #4095 from zpao/update-jest
...
Update jest to latest
2015-06-11 11:07:20 -07:00
Paul O’Shannessy
b4b542303d
Update jest to latest
2015-06-11 11:01:00 -07:00
Paul O’Shannessy
e98acaa4a7
Merge pull request #4058 from yiminghe/className_contains
...
fix className check in scryRenderedDOMComponentsWithClass when encounter new line
2015-06-11 09:37:09 -07:00
Paul O’Shannessy
9a93f24709
[lint] Ignore generated docs
2015-06-11 09:27:05 -07:00
yiminghe
a5f3962ef6
update code style
2015-06-11 23:26:09 +08:00
yiminghe
69339a0f67
update code style
2015-06-11 23:21:52 +08:00
Sebastian Markbage
02aafb5162
Make setState in render a warning, not an invariant
...
We keep track of the fact that something is rendering for a bunch of
warnings. (ReactCurrentOwner.current !== null)
Once we get rid of owner for string refs, I'll convert those to something
like "isRendering" instead. The interesting part is that feature `__DEV__`
only. It is only used for warnings. Except for this case.
This means that we can get rid of the special case for the isRendering
stack on in prod.
2015-06-10 18:33:59 -07:00
Sebastian Markbåge
8b24b3d8b0
Merge pull request #4090 from sebmarkbage/fixdomcomponentest
...
Use the public render API in ReactDOMComponent-test
2015-06-10 17:57:33 -07:00
Sebastian Markbage
3cdf718504
Use the public render API in ReactDOMComponent-test
...
Avoids testing a non-public API. First step towards refactoring more of
these internals to not be instances. Also gets rid of an _owner usage.
2015-06-10 17:34:56 -07:00
Paul O’Shannessy
f55b93672f
Merge pull request #4088 from zpao/fix-class-test
...
Fix Class tests
2015-06-10 17:19:40 -07:00
Paul O’Shannessy
d580a71293
Fix Class tests
...
These were introduced in #4045 as a result of jest not running properly in CI.
I also fixed the places where we misspelled "misspelling".
2015-06-10 17:06:04 -07:00
Ben Alpert
6c96f9f273
Merge pull request #4086 from spicyj/ta
...
Remove stray call to ReactDOMTextarea.unmountWrapper
2015-06-10 15:49:04 -07:00
Ben Alpert
f073ce2ba7
Remove stray call to ReactDOMTextarea.unmountWrapper
...
ReactDOMInput has this but ReactDOMTextarea doesn't so we shouldn't try to call it.
2015-06-10 15:31:27 -07:00
Jim
88042b1b00
Merge pull request #4074 from jimfb/docs-context-parameter-confusing
...
Fixed confusing use of the word/name `context` in documentation
2015-06-10 13:32:03 -07:00
Ben Alpert
4f73ce2c95
Merge pull request #4077 from neojski/svg-namespace
...
Add xmlns to svg wrap
2015-06-10 12:19:45 -07:00
Jim
537a84183a
Merge pull request #3752 from jhicken/Custom-Element-Support
...
Ignore whitelisted attributes for native custom elements.
2015-06-10 10:58:54 -07:00
Ben Alpert
46cec1949d
Merge pull request #4071 from spicyj/warn-dom-props
...
Fix IE8
2015-06-10 10:16:57 -07:00
Jeff Hicken
7256f0976c
Ignore whitelisted attributes for native custom elements that use the is attribute.
2015-06-10 10:00:21 -06:00
Tomasz Kołodziejski
c9fab582c4
Add xmlns to svg wrap
...
Closes #4072 .
2015-06-10 15:57:05 +02:00
Jim
5446ef1c14
Fixed confusing use of the word/name in documentation
2015-06-10 02:48:48 -07:00
Ben Alpert
13a8758fc8
Fix IE8
2015-06-09 18:45:29 -07:00
Ben Alpert
0abb350530
Merge pull request #4070 from tako-black/fix_md_file
...
Fix code of getting-started-ja-JP
2015-06-09 17:01:14 -07:00
Kohei TAKATA
005b65c17b
Fix code of getting-started-ja-JP
2015-06-10 08:52:47 +09:00
yiminghe
e704503dc7
optimize className check
2015-06-10 01:11:39 +08:00
Scott Feeney
61d8de3f3f
Merge pull request #4003 from AnSavvides/on-change-vs-on-input
...
[#3964 ] Add note about React's onChange vs. DOM's oninput
2015-06-09 11:13:28 -04:00
Paul O’Shannessy
04a025f3b7
Merge pull request #4046 from basarat/patch-2
...
📝 document changes for classes
2015-06-08 21:46:39 -07:00
Paul O’Shannessy
3faad4f65f
Merge pull request #4063 from zpao/fix-ja-docs
...
fix japanese docs permalinks
2015-06-08 20:16:49 -07:00
Basarat Ali Syed
b7fe1ac0fc
📝 link to docs and not the blog post
2015-06-09 11:33:33 +10:00
Paul O’Shannessy
8488cb4dac
fix japanese docs permalinks
2015-06-08 18:18:57 -07:00
Paul O’Shannessy
2b53acb00a
Merge pull request #4045 from davemeetsworld/add-warning-for-mispelling-of-componentWillReceiveProps
...
Added warning for mispelling of componentWillReceiveProps and updated…
2015-06-08 15:12:40 -07:00
David Baker
2d8c4be000
Added warning for mispelling of componentWillReceiveProps and updated tests
2015-06-08 22:44:30 +01:00
Paul O’Shannessy
5955379753
Merge pull request #4060 from cody/addons
...
Fix addon name in npm Readme
2015-06-08 14:00:20 -07:00
Paul O’Shannessy
a74138bdee
Fix docblock of ReactFragment
2015-06-08 13:49:29 -07:00
Stefan Dombrowski
c9ab11f5ff
Fix addon name in npm Readme
2015-06-08 22:39:12 +02:00
Ben Alpert
6b8ed9b64e
Merge pull request #3884 from glenjamin/patch-3
...
Document boolean attributes in JSX
2015-06-08 13:28:39 -07:00
Paul O’Shannessy
7f7528c454
Merge pull request #4059 from jquense/patch-3
...
fix my embarrassing amount of typos in this 4 line change
2015-06-08 13:01:15 -07:00
Benjamin Woodruff
f27d130323
Merge pull request #4040 from PiPeep/eslint-updates
...
Update eslint-related dependencies
2015-06-08 13:00:13 -07:00
Jason Quense
813649cbc7
fix my embarrassing amount of typos in this 4 line change
2015-06-08 15:59:30 -04:00
Paul O’Shannessy
09993a1379
Merge pull request #4054 from jquense/patch-2
...
Update npm Readme to new method of accessing addons
2015-06-08 12:53:28 -07:00
Ben Alpert
8614dd3cf9
Merge pull request #3984 from neojski/uppercase-node-name
...
Always toLowerCase when comparing nodeName or tagName
2015-06-08 11:44:56 -07:00
Ben Alpert
0e3ae67418
Merge pull request #4043 from spicyj/80
...
Remove line length lint warning
2015-06-08 10:40:42 -07:00
Ben Alpert
39f232b9aa
Merge pull request #4042 from spicyj/warn-dom-props
...
Warn when accessing .props, .setProps on DOM components
2015-06-08 10:40:26 -07:00
Ben Alpert
bfcad9614a
Warn when accessing .props, .setProps on DOM components
2015-06-08 10:36:20 -07:00
Benjamin Woodruff
52eca1eb69
Update eslint-related dependencies
...
- babel-eslint ^3.1.14 fixes babel/babel-eslint#120
- babel updated from ^5.3.3 to ^3.5.5, which changes stuff, I guess
- eslint updated from ^0.21.2 to ^0.22.1, which makes `no-shadow` also
check class declarations
2015-06-08 08:41:13 -07:00
Jason Quense
7fa8c79d40
Update docs to new method of accessing addons
2015-06-07 19:07:36 -04:00
Andreas Savvides
ae83e90ec7
[ #3964 ] Add note about React's onChange vs. DOM's oninput
2015-06-07 10:39:08 +01:00
Tomasz Kołodziejski
2bb69328ae
Always toLowerCase when comparing nodeName or tagName
...
In xml node name casing is exactly the same as the node was originally named.
Make sure to convert node and tag names to lower case before making any node
and tag name checks.
Fixes #3960 .
2015-06-06 10:28:43 +02:00
Basarat Ali Syed
b994d076d1
📝 document changes for classes
...
Taking https://github.com/facebook/react/pull/4013#discussion_r31829922 into account
2015-06-06 10:23:41 +10:00
Ben Alpert
ba81b60ad8
Merge pull request #4037 from spicyj/ref-trans
...
Only enqueue attachRefs if refs are present
2015-06-05 12:42:09 -07:00
Ben Alpert
edee1c7ed7
Merge pull request #4035 from spicyj/dc-os
...
Convert select/option to not use wrappers
2015-06-05 12:41:34 -07:00
Benjamin Woodruff
0dab63b905
Merge pull request #4034 from PiPeep/eslint-rules-as-a-plugin
...
Load custom eslint rules as plugin, w/o --rulesdir
2015-06-05 10:43:02 -07:00
Ben Alpert
c6837507f9
Only enqueue attachRefs if refs are present
...
for #4036
2015-06-04 22:57:46 -07:00
Ben Alpert
06de43d73e
Remove line length lint warning
...
...because the current situation isn't helpful; no one looks at the list. Our style guide hasn't changed.
2015-06-04 18:14:31 -07:00
Ben Alpert
abfd151b90
Convert select/option to not use wrappers
2015-06-04 18:13:54 -07:00
Ben Alpert
806ff23f03
Merge pull request #4033 from spicyj/dc-events
...
Convert form, iframe, img to not use wrappers
2015-06-04 17:23:48 -07:00
Benjamin Woodruff
30cce21ae6
Load custom eslint rules as plugin, w/o --rulesdir
...
This allows us to load the eslint rules without requiring command-line
arguments, which avoids breaking editors with eslint plugins.
https://github.com/eslint/eslint/issues/2180#issuecomment-87722150
2015-06-04 17:04:45 -07:00
Benjamin Woodruff
58302a71c4
Merge pull request #4032 from PiPeep/babel-eslint-no-unused-vars
...
Roll back to babel-eslint 3.1.9
2015-06-04 15:53:04 -07:00
Ben Alpert
a825380840
Convert form, iframe, img to not use wrappers
...
Test Plan:
Tested manually that rendering an `<img />` triggers its onLoad handler.
2015-06-04 15:52:34 -07:00
Benjamin Woodruff
40eb94d13e
Roll back to babel-eslint 3.1.9
...
spicyj noticed newer versions of babel-eslint seemed not to error on
no-unused-vars, and I was able to repro. It seems like something broke
between 3.1.9 and 3.1.10. (Smaller repro case and babel-eslint bug
report to come)
His commit failed on travis, but not on his local machine:
https://travis-ci.org/facebook/react/jobs/65468729
2015-06-04 15:43:41 -07:00
Benjamin Woodruff
1f307ae118
Merge pull request #4029 from PiPeep/warning-invariant-rules-take-two
...
Fix problems with/improve warning and invariant rules (take two)
2015-06-04 15:10:13 -07:00
Benjamin Woodruff
2fa1b2c810
Attempt to simplify/fix warnAndMonitorForKeyUse
...
> The two callers of this function have different warning configs
> internally (static_upstream/core/createWarning.js) so we can't sync it
> like this without changing behavior. We should just split this out
> into two separate warning calls probably – this code is a little
> overabstracted.
https://github.com/facebook/react/pull/4021#discussion_r31690020
@spicyj
I think completely removing warnAndMonitorForKeyUse is a bit difficult, without
duplicating a ton of code. This at least ensures that the format string passed
to `warning` is unique. Plus, because the FB internal code in question only
matches the beginning of the format string, I think there should be zero
internal changes that need to be made to support this refactor.
2015-06-04 15:07:17 -07:00
Paul O’Shannessy
da27129f73
Merge pull request #3913 from edvinerikson/edvinerikson/better-warning-message
...
Added component displayName to warning message in ReactUpdateQueue.js
2015-06-04 15:00:36 -07:00
Ben Alpert
aacd7ac57d
Merge pull request #4030 from spicyj/dc-button
...
Convert ReactDOMButton
2015-06-04 14:47:58 -07:00
Benjamin Woodruff
c91fd8ac14
Check warning/invariant calls have good messages
...
The `warning` implementation checked that the message is long enough to
be useful. See commit f5038829d for more information.
It makes more sense to move this into a lint rule, and also to apply it
for both `warning` and `invariant`. We can safely remove stuff from the
`warning` implementation as we replace the function internally anyways.
https://github.com/facebook/react/pull/4021#issuecomment-108694976
@spicyj
2015-06-04 14:19:22 -07:00
Ben Alpert
9dbc29e276
Convert ReactDOMButton
2015-06-04 13:59:32 -07:00
Sebastian Markbåge
2d9a0846f1
Merge pull request #3940 from troutowicz/context_processing
...
Process childContextTypes via internal constructor
2015-06-04 13:54:14 -07:00
Ben Alpert
d993475e9e
Merge pull request #4027 from spicyj/dc-textarea
...
Convert ReactDOMTextarea to not be a wrapper
2015-06-04 13:53:43 -07:00
Ben Alpert
67a4f0e852
Merge pull request #4028 from spicyj/npm-run-lint
...
Fix `npm run lint`
2015-06-04 13:37:00 -07:00
Ben Alpert
d2e7e56cc4
Convert ReactDOMTextarea to not be a wrapper
2015-06-04 13:36:46 -07:00
Paul O’Shannessy
2b195cb1ca
Merge pull request #3941 from troutowicz/testing_type
...
Assert instance type using internal constructor
2015-06-04 13:31:23 -07:00
Ben Alpert
b1538e36e3
Fix npm run lint
...
Broke in #4021 .
2015-06-04 13:20:42 -07:00
Paul O’Shannessy
d3db430baf
Merge pull request #4022 from zpao/fix-undefined-location
...
Use correct location when running LinkedValueUtils proptype checks
2015-06-04 13:02:54 -07:00
Edvin Erikson
fa9382654a
reversed line 54 (no-op message) in ReactUpdateQueue.js and added it to the line above
2015-06-04 21:47:35 +02:00
Edvin Erikson
58edaab705
Added component displayName to warning message in ReactUpdateQueue.js
2015-06-04 21:47:34 +02:00
Ben Alpert
e04015a4a2
Merge pull request #4011 from spicyj/cfpc
...
Inline createFullPageComponent in ReactDOMComponent
2015-06-04 12:44:02 -07:00
Benjamin Woodruff
aecc48d877
Fix wording of warning-and-invariant-args linter
...
The wording for an incorrect number of arguments based on counting %s
substitutions. The previous wording was backwards and a bit yoda-like
leading to possible ambiguity.
2015-06-04 10:51:15 -07:00
Benjamin Woodruff
9760e13f36
Merge pull request #4007 from PiPeep/eslint-plugin-react
...
Enable more eslint-plugin-react rules
2015-06-04 09:51:47 -07:00
Benjamin Woodruff
c04a9e632c
Enable react/wrap-multilines eslint rule
...
Multiline jsx literals in a return should be paren-wrapped.
2015-06-04 09:44:47 -07:00
Benjamin Woodruff
f41abdf70f
Enable more eslint-plugin-react rules
...
This should contain all the rules we probably want to use, except
react/wrap-multilines, which requires a larger codemod, and would
clutter this commit.
2015-06-04 09:43:16 -07:00
Paul O’Shannessy
6b79977c31
Merge pull request #3416 from koba04/remove-jshint
...
Remove the codes relating to jshint
2015-06-03 19:45:51 -07:00
Benjamin Woodruff
56771b6701
Merge pull request #4021 from PiPeep/warning-invariant-rules
...
Add custom eslint rule for warning and invariant
2015-06-03 19:03:41 -07:00
Toru Kobayashi
ce46068def
Remove the codes relating to jshint
2015-06-04 09:32:37 +09:00
Benjamin Woodruff
17e7046754
Add custom eslint rule for warning and invariant
...
See #2869
Checks that the *second* argument of warning and invariant are a literal
string, or a concatination of literal strings, and that the number of
arguments is correct based on the number of %s substrings.
This commit also fixes a few places where the existing code had broken
error messages!
The rule itself is pretty straightforward, although adding the tests
ended up being a bit painful, as eslint-tester depends on mocha, and
therefore needs to be run in a separate grunt task.
2015-06-03 17:19:32 -07:00
Paul O’Shannessy
ec289c27f9
Use correct location when running LinkedValueUtils proptype checks
2015-06-03 16:45:58 -07:00
Jim
9a02ea246d
Merge pull request #3067 from jimfb/arbitrary-attributes-for-dash-elements
...
Support arbitrary attributes on elements with dashes in the tag name.
2015-06-03 12:52:54 -07:00
Ben Alpert
fc341c5537
Inline createFullPageComponent in ReactDOMComponent
2015-06-02 17:24:06 -07:00
Benjamin Woodruff
4c3e9650ba
Merge pull request #3998 from PiPeep/comma-dangle
...
Switch to using comma-dangle: always-multiline
2015-06-02 17:02:39 -07:00
Benjamin Woodruff
95edacc994
Remove /*eslint-disable comma-dangle*/ comments
...
Commit 9d3f7f30ba3ba55cbfd98b26fdd2cc7289716650 reverses the rule, so
these comments aren't needed anymore.
2015-06-02 16:57:43 -07:00
Benjamin Woodruff
c089eece50
Switch to using comma-dangle: always-multiline
...
This is a machine-generated codemod, but it's pretty safe since it was
generated by hooking into eslint's own report.
A few files had to be touched up by hand because there were existing
formatting issues with nested arrays/objects:
src/shared/utils/__tests__/OrderedMap-test.js
src/shared/utils/__tests__/Transaction-test.js
src/shared/utils/__tests__/traverseAllChildren-test.js
src/isomorphic/children/__tests__/ReactChildren-test.js
2015-06-02 16:57:26 -07:00
Jim
e0e8270c9d
Merge pull request #4009 from jimfb/kill-.type
...
Kill .type (was deprecated in 0.13, to be removed in 0.14)
2015-06-02 14:03:26 -07:00
Jim
c9153e6462
Kill .type (was deprecated in 0.13, to be removed in 0.14)
2015-06-02 13:36:51 -07:00
Jim
b1db817dc5
Support arbitrary attributes on elements with dashes in the tag name.
2015-06-02 11:57:29 -07:00
Paul O’Shannessy
0e37fde307
Merge pull request #4006 from cody/console
...
Remove debug message
2015-06-02 11:31:01 -07:00
Stefan Dombrowski
3e0de40d3a
Remove debug message
2015-06-02 19:31:26 +02:00
Ben Alpert
1af9b54561
Merge pull request #3930 from Wildhoney/add-is-attribute
...
Added 'is' attribute for custom elements
2015-06-02 02:47:33 -07:00
Wildhoney
0d060d135f
Added 'is' attribute
2015-06-02 10:42:31 +01:00
Ben Alpert
8c2a4991eb
Merge pull request #3976 from spicyj/no-wrapper
...
Make DOM wrapper component using lower-level primitives
2015-06-01 20:20:20 -07:00
Ben Alpert
52a229f168
Make DOM wrapper component using lower-level primitives
...
Introducing: a really lame version of composite components, right inside of ReactDOMComponent!
Now ReactDOMInput isn't an actual component. This brings us closer to exposing DOM nodes as refs.
2015-06-01 20:16:01 -07:00
Jim
db82ed09c5
Merge pull request #3999 from jimfb/more-context-cleanup
...
Removed ReactContext (cleanup)
2015-06-01 17:08:23 -07:00
Jim
5ebcd9d89b
Removed ReactContext (cleanup)
2015-06-01 16:46:45 -07:00
Paul O’Shannessy
1a2a54b947
Merge pull request #3988 from jrobison153/troubleshooting_docs
...
Troubleshooting documentation
2015-06-01 16:33:33 -07:00
Benjamin Woodruff
13823ec218
Merge pull request #3985 from PiPeep/eslint-tests
...
Enable linting for __tests__
2015-06-01 16:05:42 -07:00
Benjamin Woodruff
21ca3f732f
Enable linting for __tests__
...
Closes #3971 .
> After #3968 , the next thing we should do is start linting our tests.
> Historically we've ignored them due to lack of parser compatibility.
> But that shouldn't be a problem anymore. We may want to integrate
> https://www.npmjs.com/package/eslint-plugin-react to more aggressively
> lint our JSX in tests.
I understand this diff touches a lot of stuff, so I tried to keep it to
a near-minimal set of changes to make eslint happy.
2015-06-01 16:01:03 -07:00
Paul O’Shannessy
659fda1f1c
Merge pull request #3997 from donabrams/patch-1
...
Trivial misspelling in enqueueForceUpdate docs
2015-06-01 12:36:49 -07:00
Don Abrams
8074136bcb
Trivial mispelling in docs
2015-06-01 13:28:20 -06:00
Ben Alpert
f661d7c407
Merge pull request #3993 from arianf/doctype
...
added missing DOCTYPE
2015-05-31 19:58:15 -07:00
Arian Faurtosh
f8f92f4169
added missing DOCTYPE
2015-05-31 19:41:01 -07:00
Ben Alpert
2fbe15e370
Merge pull request #3992 from thorn0/patch-1
...
Remove envify from the basic-commonjs example
2015-05-31 15:31:34 -07:00
thorn0
58492362c5
Remove envify from the basic-commonjs example
...
`envify` is installed as a dependency of the `react` package. There is no need in installing it one more time
2015-06-01 01:09:46 +03:00
jrobison
361f73a43e
Addition of troubleshooting section
2015-05-30 05:20:29 -04:00
Paul O’Shannessy
38acadf6f4
Merge pull request #3975 from marocchino/update-korean
...
Update Korean transltaion to 58fb322
2015-05-29 14:25:35 -07:00
Paul O’Shannessy
fa56c52563
Merge pull request #3980 from cody/http
...
Revert links to non-https fiddles back to http in old blog posts
2015-05-29 14:23:19 -07:00
Stefan Dombrowski
cd54876518
Revert links to non-https fiddles back to http in old blog posts
2015-05-29 09:45:48 +02:00
Ben Alpert
54e3f12877
Merge pull request #3977 from spicyj/jest-lines
...
Retain lines in babel under jest
2015-05-28 16:10:28 -07:00
Ben Alpert
049fd9a902
Retain lines in babel under jest
...
Now stack trace lines are actually useful.
2015-05-28 16:09:25 -07:00
Shim Won
6a4617a4cd
Update Korean transltaion to 58fb322
2015-05-29 07:53:21 +09:00
Benjamin Woodruff
58fb322e21
Use babel-eslint and update eslint
...
- Removes esprima-fb dependency
- Tightens up eslintrc with some minor rules we were pretty-much
following anyways.
- Adds pretty colors to the `grunt lint` output
- Breaks block-scoped-var :(
2015-05-28 09:42:55 -07:00
Paul O’Shannessy
1df466b23a
Merge pull request #3967 from jamischarles/master
...
Added challenge, keyParams and keyType on <keygen>
2015-05-28 09:32:10 -07:00
Jim
74915803a8
Merge pull request #3970 from jimfb/remove-_context
...
Removed ReactElement._context (cleanup)
2015-05-27 17:09:53 -07:00
Ben Alpert
8471cc5f47
0.14.0-alpha3
2015-05-27 16:47:35 -07:00
Jim
4e129220a6
Removed ReactElement._context (cleanup)
2015-05-27 16:37:11 -07:00
Ben Alpert
34f8a0d6da
Merge pull request #3969 from spicyj/pt
...
Fix PropTypes.{oneOf, oneOfType} validation
2015-05-27 16:07:48 -07:00
Ben Alpert
ac349cfbe5
Fix PropTypes.{oneOf, oneOfType} validation
...
Follow-up to #3963 . (Returning an Error wasn't useful; it just caused a later error when actually using it because type checkers need to be functions.)
2015-05-27 15:58:16 -07:00
Jamis Charles
dc01c0e66d
Added challenge, keyParams and keyType on <keygen>
...
Chrome allowed some of these to be 'null' (allow `node.challenge` etc),
but FF didn't work. This will tell React to use node.setAttribute() to
set these values.
Tested in FF, Chrome, Safari. <keygen> isn't supported on IE.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/keygen
2015-05-27 11:56:23 -07:00
Ben Alpert
f44bf7e67a
Merge pull request #3966 from spicyj/no-worker-test
...
Remove web worker test
2015-05-27 10:53:53 -07:00
Ben Alpert
12ea09a03c
Remove web worker test
2015-05-27 10:52:32 -07:00
Paul O’Shannessy
1503994821
Merge pull request #3963 from alansouzati/REACT_PROP_ARRAY_VALIDATION
...
Adding validation for array in ReactPropTypes.
2015-05-26 16:42:49 -07:00
Alan Souza
5d55bbc1b7
Adding validation for array in ReactPropTypes.
2015-05-26 15:54:31 -07:00
Paul O’Shannessy
3e1349bb65
Merge pull request #3950 from cody/capture
...
Add capture to supported attributes
2015-05-26 11:34:35 -07:00
Stefan Dombrowski
3092454940
Add capture to supported attributes
2015-05-24 21:20:40 +02:00
Jim
e1dd3cd8a1
Merge pull request #3923 from jimfb/fix-grunt-test-debug
...
Fixed failing unit tests in browsers that don't support WebComponents
2015-05-22 13:48:03 -07:00
Jim
7108c8a624
Fixed failing unit tests in browsers that don't support WebComponents
2015-05-22 13:27:52 -07:00
Tim Routowicz
f1e32a06e0
Assert instance type using internal constructor
2015-05-22 16:13:06 -04:00
Tim Routowicz
d7843fe4d2
Process childContextTypes via internal constructor
2015-05-22 16:07:51 -04:00
Christopher Chedeau
b249799bc7
Merge pull request #3938 from vjeux/blog_rn_release_process
...
[Blog post] React Native Release Process
2015-05-22 12:37:55 -07:00
Christopher Chedeau
516b623121
[Blog post] React Native Release Process
2015-05-22 12:34:43 -07:00
Ben Alpert
e1a9e429d3
Merge pull request #3934 from spicyj/gh-3921
...
Dedupe warnings in validateDOMNesting
2015-05-22 10:33:36 -07:00
Paul O’Shannessy
a78be9856a
Merge pull request #3935 from julen/docs/transition-group
...
Docs: value for `transitionAppear` must be boolean
2015-05-22 10:21:58 -07:00
Julen Ruiz Aizpuru
c041356178
Docs: value for transitionAppear must be boolean
2015-05-22 15:22:22 +02:00
Ben Alpert
08b55e1c4f
Dedupe warnings in validateDOMNesting
...
Fixes #3921 .
2015-05-22 01:14:40 -07:00
Ben Alpert
e772c465e4
Merge pull request #3909 from spicyj/tir-redirect
...
Redirect Thinking in React blog post to docs
2015-05-21 22:09:48 -07:00
Ben Alpert
1d5e8c2387
Redirect Thinking in React blog post to docs
...
Much easier to keep this updated if it only exists in one place. Added the byline because otherwise the voice of the post doesn't sound quite right.
2015-05-21 22:09:21 -07:00
Paul O’Shannessy
a30c87525f
Merge pull request #3788 from zpao/better-invariantwarning-replacement
...
Better invariant / warning replacement
2015-05-21 19:42:22 -07:00
Paul O’Shannessy
02f1626725
Better invariant / warning replacement
2015-05-21 19:20:56 -07:00
Ben Alpert
4aa7bffff5
Merge pull request #3931 from marocchino/update-korean
...
Update Korean transltaion to 5bee4a5
2015-05-21 18:33:09 -07:00
Shim Won
401caf2f96
Update Korean transltaion to 5bee4a5
2015-05-22 09:03:54 +09:00
Paul O’Shannessy
5bee4a5e29
Merge pull request #3803 from zpao/docs-fancy-authors
...
[docs] Give authors links.
2015-05-21 11:34:31 -07:00
Paul O’Shannessy
81950edeb1
[docs] Give authors links.
2015-05-21 11:32:38 -07:00
Paul O’Shannessy
924328b436
Update website with 0.13.3 builds
...
(cherry picked from commit 107ce2b80d )
2015-05-21 10:53:33 -07:00
Paul O’Shannessy
7425685c27
v0.13.3 blog post
...
(cherry picked from commit 179b6380cf )
2015-05-21 10:51:51 -07:00
Paul O’Shannessy
44a6cdf2bf
Changelog for 0.13.3
...
(cherry picked from commit 95e864fd07 )
2015-05-21 10:51:45 -07:00
Paul O’Shannessy
314ee6d635
Readme for 0.13.3
...
(cherry picked from commit 1d950ddbd4 )
2015-05-21 10:51:39 -07:00
Paul O’Shannessy
631f3a4f59
Fix docs for #3690
...
(cherry picked from commit 2668de126c )
2015-05-21 10:51:21 -07:00
Paul O’Shannessy
f1cfd29e7e
Merge pull request #3912 from laskos/shallow-context-pass
...
Add shallow context pass test
2015-05-20 15:11:31 -07:00
Sławomir Laskowski
2c83627ca8
Add shallow context pass test
2015-05-21 00:08:31 +02:00
Ben Alpert
e5f935636d
Merge pull request #3917 from spicyj/option-context
...
Pass context to DOM wrappers, use it in <option>
2015-05-20 15:02:53 -07:00
Paul O’Shannessy
b687a22953
0.14.0-alpha2
2015-05-20 13:37:42 -07:00
Ben Alpert
2fafe3eb76
Pass context to DOM wrappers, use it in <option>
2015-05-20 12:30:51 -07:00
Paul O’Shannessy
a6485e11e7
Merge pull request #3896 from zpao/babel-ignore-web-components
...
Ignore third_party JS in internal transform step
2015-05-20 11:08:43 -07:00
Paul O’Shannessy
021574e07d
[docs] Fix 404 due to relative url
...
Closes #3914
2015-05-20 10:15:35 -07:00
Ben Alpert
1d7da35153
Merge pull request #3910 from spicyj/gh-3904
...
Clarify tutorial instructions
2015-05-19 20:36:12 -07:00
Ben Alpert
c157ce3599
Clarify tutorial instructions
...
Fixes #3904 .
2015-05-19 19:27:01 -07:00
Ben Alpert
34e2427f72
Merge pull request #3908 from spicyj/lint
...
Remove unused variable
2015-05-19 18:39:05 -07:00
Ben Alpert
a43b6fec45
Remove unused variable
2015-05-19 16:23:10 -07:00
Paul O’Shannessy
4cf39ef195
Merge pull request #3905 from troeggla/replace-getdomnode
...
Replaced call to deprected .getDOMNode() with React.findDOMNode().
2015-05-19 10:59:26 -07:00
Thomas Röggla
210dc90c95
Replaced call to deprected .getDOMNode() with React.findDOMNode().
...
The code sample in tip 18 in the docs contained a call to the
.getDOMNode() method which has been deprecated. The method call was
replaced with a call to React.findDOMNode(), which is the preferred way
of getting DOM nodes from a ref.
2015-05-19 18:32:07 +02:00
Ben Alpert
e47fa115bb
Merge pull request #3883 from spicyj/revert-nested
...
Revert "Add key warning to nested collections"
2015-05-18 23:11:29 -07:00
Ben Alpert
69e6ab5083
Add test for DOM node as this.props.children
2015-05-18 23:11:07 -07:00
Ben Alpert
39402fe75d
Revert "Add key warning to nested collections"
...
This heuristic isn't great because it relies on inspecting deep children which aren't guaranteed to be React elements. In particular, this was causing stack overflows in a component we had that used a *DOM node* as children, like `<DOMContainer>{node}</DOMContainer>`.
This reverts commits:
0a3aa8493a
64c9d9d762
0c58f4f6b1
8cf226e442
086636747f
2015-05-18 23:11:07 -07:00
Paul O’Shannessy
6502da8f8d
Merge pull request #3894 from bhamodi/patch-2
...
Update Styling Guide in Contributing Docs
2015-05-18 10:53:09 -07:00
Paul O’Shannessy
9308a8abe6
Merge pull request #3892 from spicyj/docs-wwb
...
[docs] Clarify wording in Working with the Browser
2015-05-18 10:47:37 -07:00
Paul O’Shannessy
5b5e48a0d2
Ignore third_party JS in internal transform step
2015-05-18 09:50:13 -07:00
Baraa Hamodi
00342dfc26
Update Styling Guide in Contributing Docs
2015-05-17 23:38:40 -07:00
Ben Alpert
c7381ea48d
[docs] Clarify wording in Working with the Browser
...
I think the change in #3889 misinterpreted this slightly; this makes it clearer.
2015-05-17 11:58:17 -07:00
Paul O’Shannessy
490d8835fc
Merge pull request #3737 from Morhaus/nested-proptypes-warnings
...
Better warnings for nested propTypes
2015-05-16 12:09:29 -07:00
Paul O’Shannessy
095d4691ca
Merge pull request #3888 from marocchino/korean-update
...
Update Korean Translation to 5275244
2015-05-16 12:03:42 -07:00
Paul O’Shannessy
97d338fd5b
Merge pull request #3889 from garethnic/WorkBrowser
...
change wording in 'Working with the Browser'
2015-05-16 11:09:49 -07:00
Gareth Nicholson
07bfadf054
change wording
2015-05-16 15:55:29 +02:00
Shim Won
6f434b35ad
Update Korean Translation to 5275244
2015-05-16 21:49:04 +09:00
Glen Mailer
0950f50753
Document boolean attributes in JSX
2015-05-16 12:00:14 +01:00
Sebastian Markbåge
5275244676
Merge pull request #3866 from sebmarkbage/coreapi
...
Reorganize Src Directory for Isomorphic React Package
2015-05-15 18:39:36 -07:00
Sebastian Markbage
0b063f8a09
Reorganize Src Files for Isomorphic React Package
...
The new folder structure is organized around major packages that are expected to ship separately in some form.
`/isomorphic`
I moved classic/modern and children utils into a directory called "isomorphic" with the main export being ReactIsomorphic. This will eventually become the "react" package.
This includes all the dependencies that you might need to create a component without dependencies on the renderer/reconciler.
The rest moves into decoupled renderers.
`/renderers/dom/client` - This is the main renderer for DOM.
`/renderers/dom/server` - This is the server-side renderer for HTML strings.
`/addons` and `/test` - Same as before for now.
You're not supposed to take on a dependency inside another package.
Shared code is organized into a "shared" directory which is intended to support all the packages in that subdirectory. Meaning that once we swap to CommonJS modules, the only time you should use `..` is to target `../shared/` or `../../shared`.
E.g. `/shared/` is common utils that are used by everything.
`/renderers/shared/` is code that is shared by all renderers, such as the main reconciliation algorithm.
Shared code will likely be copied into each package rather than referenced. This allow us to have separate state and allow inlining and deadcode elimination.
2015-05-15 18:35:22 -07:00
Paul O’Shannessy
bea5a57750
Merge pull request #3746 from chrisgrovers/patch-1
...
Fixed Formatting.
2015-05-15 18:09:44 -07:00
Paul O’Shannessy
c464e873fd
Merge pull request #3874 from bhamodi/patch-1
...
Update CONTRIBUTING.md
2015-05-15 18:08:00 -07:00
Paul O’Shannessy
3ef24f73bb
Merge pull request #3881 from ef718/docs-grammar
...
Fix punctuation and grammar
2015-05-15 17:57:36 -07:00
Paul O’Shannessy
cfa354415b
Followup to #3852 , use https
2015-05-15 17:51:57 -07:00
Ben Alpert
35e67a793e
Merge pull request #3882 from wali-s/get-html5-minlength-working
...
Get HTML5 minlength working.
2015-05-15 15:51:14 -07:00
wali-s
aeb45360ed
Get HTML5 minlength working.
...
Adding minLength=X to an input element would not work, whereas maxLength=X would work.
This change gets minLength=X working.
2015-05-15 15:47:15 -07:00
Ben Alpert
7112a35037
Merge pull request #3847 from bloodyowl/option-flatten-children
...
<option> added children flatten, & warn if invalid
2015-05-14 10:36:27 -07:00
Ben Alpert
69fc206f96
Merge pull request #3719 from spicyj/vdn2
...
Add more context to DOM nesting warning
2015-05-14 10:33:21 -07:00
Ben Alpert
5c7b4a043f
Merge pull request #3651 from spicyj/tac-noi
...
Don't thread index through traverseAllChildren
2015-05-14 10:32:49 -07:00
Elaine Fang
d24cfa6405
Add punctuation
2015-05-14 13:15:06 -04:00
Matthias Le Brun
4a012b0741
<option> added children flatten, & warn if invalid
2015-05-14 12:44:04 +02:00
Morhaus
12a43d4eee
Better warnings for nested propTypes
...
`arrayOf`, `shape` and `objectOf` warnings now display the full path of
the invalid key.
2015-05-14 11:33:07 +02:00
Baraa Hamodi
b276af5c0a
Update CONTRIBUTING.md
...
Make the contributing sentence make a little bit more sense.
2015-05-13 23:17:31 -07:00
Ben Alpert
05b98ac70c
Merge pull request #3872 from spicyj/nested-num
...
Split message for deep numeric key warning too
2015-05-13 15:32:13 -07:00
Paul O’Shannessy
db25a63c12
Merge pull request #3869 from zpao/jsx-cleanup
...
JSX -> Babel cleanup
2015-05-13 15:31:48 -07:00
Paul O’Shannessy
76d016c6f1
Use Babel to transform JS in docs, update other calls
2015-05-13 15:26:23 -07:00
Ben Alpert
0a3aa8493a
Split message for deep numeric key warning too
2015-05-13 15:23:29 -07:00
Ben Alpert
922d531445
Merge pull request #3871 from spicyj/group
...
Deprecate reactjs Google Group
2015-05-13 15:16:51 -07:00
Ben Alpert
ffabf4b5ff
Deprecate reactjs Google Group
2015-05-13 15:16:33 -07:00
Ben Alpert
51843ec710
Merge pull request #3870 from spicyj/gh-3865
...
Clarify ReactElement prop validation message
2015-05-13 15:14:00 -07:00
Ben Alpert
bed4de3eca
Clarify ReactElement prop validation message
...
Fixes #3865 .
2015-05-13 12:37:54 -07:00
Ben Alpert
67aea08b4f
Merge pull request #3861 from spicyj/nested-v
...
Split out warning message for nested key warning
2015-05-13 11:51:11 -07:00
Paul O’Shannessy
555d5dc35c
Merge pull request #3864 from cvrebert/patch-1
...
bower.json: remove moot `version` field
2015-05-13 11:12:10 -07:00
Paul O’Shannessy
9769f96974
[docs] Move pre-compiled JS files
2015-05-13 10:57:47 -07:00
Paul O’Shannessy
b258d34c73
Don't run non-existant fbtransform tests
2015-05-13 10:52:51 -07:00
Chris Rebert
73c84c8319
bower.json: remove moot version field
...
Per a325da3d79
2015-05-12 22:31:18 -07:00
Ben Alpert
64c9d9d762
Split out warning message for nested key warning
...
Also make sure to mark child array as validated in cloneElement as well.
2015-05-12 16:33:04 -07:00
Ben Alpert
f0bdadf85b
Merge pull request #3857 from spicyj/dev-rckv
...
Set _reactChildKeysValidated in dev mode only
2015-05-11 17:06:18 -07:00
Ben Alpert
0c58f4f6b1
Set _reactChildKeysValidated in dev mode only
2015-05-11 17:02:49 -07:00
Jim
6b19cf9ce3
Merge pull request #3856 from chaseadamsio/chaseadamsio-patch-1
...
Change object typo to objects
2015-05-11 13:56:58 -07:00
Chase Adams
a21b82d151
Change object typo to objects
2015-05-11 13:29:14 -07:00
Paul O’Shannessy
1549bae2ab
Merge pull request #3834 from chicoxyzzy/remove_jslint
...
remove jslint comments
2015-05-10 22:52:57 -07:00
Paul O’Shannessy
1748dc8131
Merge pull request #3837 from davidneat/transition-group-appear-high-level-docs
...
Added transitionAppear docs
2015-05-10 22:51:46 -07:00
Paul O’Shannessy
7839e07231
0.14.0-alpha1
2015-05-10 22:36:50 -07:00
Paul O’Shannessy
64014c4641
Fix esprima-fb dependency
2015-05-10 22:25:08 -07:00
Ben Alpert
0de20e35bc
Merge pull request #3852 from thewarpaint/patch-1
...
Add Wikipedia link to Cross-site scripting article on "XSS attack" string
2015-05-10 13:28:10 -07:00
Eduardo Garcia
ee7d7487ea
Add Wikipedia link to Cross-site scripting on "XSS attack" string
2015-05-10 15:22:12 -05:00
Ben Alpert
4ba67670f9
Merge pull request #3841 from spicyj/yolo
...
Preserve prototype with replaceState
2015-05-08 13:16:43 -07:00
Ben Alpert
d7de12fbd8
Preserve prototype with replaceState
...
Fixes #3418 .
2015-05-08 13:11:18 -07:00
David Neubauer
f17a15a07d
added animate initial mounting section to animation docs
2015-05-08 20:31:11 +02:00
Paul O’Shannessy
e135a4dbc3
Follow-up to follow-up to #3718
...
Cleaned up a few more ununsed things.
2015-05-07 17:29:31 -07:00
Paul O’Shannessy
4bb7abf8fe
Merge pull request #3835 from zpao/fix-keys-keys-keys-test
...
Followup to #3758 so we actually test things
2015-05-07 17:15:11 -07:00
Paul O’Shannessy
5da94d6eb0
Followup to #3758 so we actually test things
2015-05-07 17:10:51 -07:00
chico
553dd90528
remove jslint comments
2015-05-08 03:05:51 +03:00
Paul O’Shannessy
29d548fe65
Merge pull request #3831 from MadLittleMods/tab-size-unit-less
...
Add support for unitless tabSize/tab-size
2015-05-07 13:09:17 -07:00
Eric Eastwood
60e1f5a103
Add support for unitless tabSize/tab-size
2015-05-07 13:51:15 -05:00
Paul O’Shannessy
d71965b988
Merge pull request #3828 from chicoxyzzy/patch-1
...
add a badge with latest npm package published
2015-05-07 11:29:16 -07:00
Paul O’Shannessy
72ad0c11c3
Merge pull request #3829 from murashki/ReactMultiChildText-test.js-__html-typo
...
ReactMultiChildText-test.js fix __html typo
2015-05-07 10:34:08 -07:00
Paul O’Shannessy
1c4965060b
Merge pull request #3830 from gberg1/patch-1
...
Formatting of line 19 ReactNativeComponent.js
2015-05-07 10:17:29 -07:00
David Goldberg
759a393ce5
Formatting of line 19 ReactNativeComponent.js
...
Corrected formatting error on line 19 of ReactNativeComponent.js by adding a period in order to be consistent with the other comments in the file.
2015-05-07 10:09:00 -07:00
Yakov Dalinchuk
9b798400fd
ReactMultiChildText-test.js fix __html typo
2015-05-07 16:06:11 +03:00
Sergey R
b157088e71
add a badge with latest npm package published
2015-05-07 02:21:37 +03:00
Ben Alpert
1db70dbef1
Merge pull request #3718 from framp/master
...
Added support for namespace attributes
2015-05-05 16:48:21 -07:00
Ben Alpert
5f32953ac7
Follow-ups for #3718
...
- Rename NamespaceProperties to DOMAttributeNamespaces
- Make tests pass in jest
- Remove unnecessary xmlns attributes
2015-05-05 16:46:49 -07:00
Federico Rampazzo
a88b655ccd
Added support for namespace attributes
2015-05-05 16:15:25 -07:00
Paul O’Shannessy
2b9a74c0e6
Merge pull request #3777 from zpao/deprecate-react-tools
...
Deprecate react-tools
2015-05-05 11:06:15 -07:00
Paul O’Shannessy
d2fe87892d
Remove transforms from repo, react-tools
...
Time to just use jstransform.
2015-05-05 10:51:51 -07:00
Jim
e0890664a7
Merge pull request #3815 from neojski/isMounted-should-return-boolean
...
IsMounted should always return a boolean.
2015-05-05 02:51:49 -07:00
Tomasz Kołodziejski
5ef0b416df
IsMounted should always return a boolean.
...
Fixes #3814 . isMounted used to return undefined if internalInstance
was undefined after component was unmounted.
2015-05-05 11:43:09 +02:00
Ben Alpert
5509cd74a4
Merge pull request #3813 from spicyj/babel
...
Replace vendor/constants recast transform with babel
2015-05-04 17:43:14 -07:00
Ben Alpert
ceb92cd78c
Replace vendor/constants recast transform with babel
...
Built files look the same up to parenthesization and quoting. This only saves 1.5 seconds out of ~20 on a clean build but it's a little simpler.
2015-05-04 17:05:42 -07:00
Paul O’Shannessy
aee3614d80
Merge pull request #3778 from masterfung/docs-update
...
updated some typos, grammers, and made sentences sound better
2015-05-04 16:27:38 -07:00
Tsung Hung
f34c2eab40
updated some typos, grammers, and made sentences sound better
2015-05-04 16:26:14 -07:00
Ben Alpert
a110c76558
Merge pull request #3801 from spicyj/babel
...
Use Babel to build React
2015-05-04 16:14:00 -07:00
Ben Alpert
8897b00989
Remove es3ify
2015-05-04 16:13:36 -07:00
Ben Alpert
93a782b40b
Use Babel to build React
...
Size comparison:
```
raw gz Compared to master @ 6ed98ec0c8
= = build/JSXTransformer.js
-15736 -3247 build/react-with-addons.js
+287 +7 build/react-with-addons.min.js
-14412 -2887 build/react.js
+274 +15 build/react.min.js
```
Differences mostly look to be various bits of whitespace that Babel ends up removing during its transforms (https://gist.github.com/spicyj/21ef31f4d95fb7a58daf ). In minified files, mostly additions of `"use strict";`.
2015-05-04 14:14:09 -07:00
Henry Zhu
0937e918aa
jsdoc fixes
2015-05-04 16:04:49 -04:00
Ben Alpert
dc08ae4043
Merge pull request #3805 from hejld/master
...
Removed redundant grave accent character from Component API docs
2015-05-02 23:00:07 -07:00
Daniel Hejl
f81d52b854
Removed redundant grave accent character from Component API docs
2015-05-02 22:22:20 -07:00
Ben Alpert
70e64ef099
Merge pull request #3797 from marocchino/update-korean
...
Update Korean Translation to 9484d0f
2015-05-02 12:35:06 -07:00
Ben Alpert
a6d03f36a4
Merge pull request #3802 from spicyj/cleaner-depr
...
Better warning messages for deprecated methods
2015-05-02 10:05:30 -07:00
Paul O’Shannessy
c8d40e0f65
Update 2015-05-01-graphql-introduction.md
...
Typo
2015-05-01 17:01:17 -07:00
Ben Alpert
e06d3e0ab9
Better warning messages for deprecated methods
2015-05-01 13:32:31 -07:00
Paul O’Shannessy
b264372e2b
Fix a couple grammar issues in GraphQL blog post
2015-05-01 12:36:30 -07:00
Paul O’Shannessy
693da719a3
GraphQL Introduction Blog Post
2015-05-01 11:18:44 -07:00
Jim
6ed98ec0c8
Merge pull request #3794 from jsfb/fix-thinking-in-react-blog-post
...
Fixed jsfiddles broken on https. Fixes 3735.
2015-05-01 10:47:12 -07:00
Shim Won
ee38a36f50
Update Korean Translation to 9484d0f
2015-05-01 09:09:09 +09:00
Ben Alpert
9484d0fc39
Merge pull request #3795 from spicyj/batch-unmount
...
Batch updates within top-level unmount
2015-04-30 15:05:55 -07:00
Ben Alpert
36f3a2aaff
Batch updates within top-level unmount
...
Analogous change to #2935 .
2015-04-30 15:05:44 -07:00
Jim
34b99cc69e
Fixed jsfiddles broken from https conversion. Fixes 3735
2015-04-30 13:05:53 -07:00
Ben Alpert
a092b47be5
Merge pull request #3785 from iamdustan/addons
...
npm build: create addons directory that loads from lib. Closes #3780
2015-04-29 15:31:20 -07:00
Dustan Kasten
5cfb712088
npm build: create addons directory that loads from lib. Closes #3780
2015-04-29 18:25:36 -04:00
Ben Alpert
571c327438
Merge pull request #3786 from HurricaneJames/master
...
check that React renders the menuitem closing tag
2015-04-29 14:43:16 -07:00
James Burnett
d42bf671d2
check that React renders the menuitem closing tag
2015-04-29 17:32:56 -04:00
Ben Alpert
64b1f05e75
Add more context to DOM nesting warning
...
Better version of #3578 .
2015-04-29 14:20:23 -07:00
Ben Alpert
a56d0d6dc5
Merge pull request #3781 from spicyj/elval
...
Fix infinite recursion in browsers with iterators
2015-04-29 13:54:08 -07:00
Paul O’Shannessy
1427522151
Merge pull request #3784 from ef718/docs-punctuation
...
Add punctuation
2015-04-29 12:40:41 -07:00
Elaine Fang
50e974b5b6
Add punctuation
2015-04-29 11:07:48 -04:00
Ben Alpert
8cf226e442
Fix infinite recursion in browsers with iterators
...
My old code here didn't work properly -- for a string child, getIteratorFn would return an iterator that gave each character as its own string, and we'd attempt to loop over that too.
Tests now work in Chrome again.
2015-04-29 00:21:00 -07:00
Paul O’Shannessy
92e82c91a5
Merge pull request #3779 from katzoo/dry-quadratic-example
...
DRY quadratic formula example
2015-04-28 18:03:15 -07:00
katzoo
065f13a968
DRY quadratic formula example
2015-04-29 02:50:53 +02:00
Ben Alpert
1d8025258a
Merge pull request #3722 from spicyj/travis-rel-grunt
...
Use local `grunt` executable on Travis
2015-04-28 14:55:34 -07:00
Ben Alpert
e534e0730e
Use local grunt executable on Travis
...
Builds have been flaky lately. Maybe this will help?
2015-04-28 14:45:55 -07:00
Jim
49de80e692
Merge pull request #3767 from kubosho/patch-1
...
Use jQuery 2.1.3 (latest) to be up-to-date and consistent with other docs)
2015-04-28 06:42:52 -07:00
Shota Kubota
d376e12a9c
Fix differences a jQuery CDN URLs, fixes #3750 .
...
unify to `https://code.jquery.com/jquery-2.1.3.min.js `.
2015-04-28 22:27:46 +09:00
alexpien
6e5b0248db
Update 10.1-animation.md
...
Custom classes
2015-04-27 19:16:24 -07:00
alexpien
039110f8bf
Allow ReactCSSTransitionGroup to also take in object containing classNames instead of relying on manipulation of the transitionName property
2015-04-27 18:56:00 -07:00
Jim
40119404b9
Merge pull request #3740 from jsfb/element-is-parent-of-render-result-test
...
Added unit test to verify that context treats the component doing a render() as the parent.
2015-04-27 16:11:39 -07:00
Ben Alpert
3b10a7b038
Add forgotten clipPath wrapper in getMarkupWrap
2015-04-27 15:39:39 -07:00
codesuki
e3cf48cd7f
Added support for SVG clipPath element and clip-path attribute
2015-04-27 15:37:23 -07:00
Jim
9a950e9a19
Added unit test to verify that context treats the component doing a render() as the parent.
2015-04-27 14:56:25 -07:00
Ben Alpert
d359319073
Merge pull request #3758 from spicyj/keys-keys-keys
...
Add key warning to nested collections
2015-04-27 14:51:30 -07:00
Ben Alpert
086636747f
Add key warning to nested collections
...
Also when reusing elements in multiple contexts -- before we were mutating each element to indicate its validity; now we mutate the array containing it (which we create, in the case of rest-arg children).
Fixes #2496 . Fixes #3348 .
2015-04-27 14:41:25 -07:00
Ben Alpert
adcb420414
Merge pull request #3757 from spicyj/es6
...
Add missing super() calls
2015-04-27 14:31:03 -07:00
Ben Alpert
2d1a24e8df
Add missing super() calls
...
Babel complains without these because it's invalid ES6.
2015-04-27 13:41:10 -07:00
Ben Alpert
8e9deff3cc
Merge pull request #3749 from VictorKoenders/master
...
unmountChildren was missing an Object.hasOwnProperty check (src/core/ReactChildReconciler.js)
2015-04-26 15:09:48 -07:00
Victor Koenders
ed4daba87d
src/core/ReactChildReconciler.js::unmountChildren was missing an Object.hasOwnProperty check
2015-04-26 13:54:16 +02:00
Cheng Lou
86dee966a4
Merge pull request #3747 from jayeszee/patch-1
...
Missing punctuations in comments.
2015-04-26 00:23:43 -04:00
Jack Zhang
f7a9a6c480
Missing punctuations in comments.
...
Added periods to two comment lines to ensure uniform format.
2015-04-25 20:50:30 -07:00
Chris Grovers
91029ffac1
Fixed Formatting.
2015-04-25 15:06:59 -07:00
Matthew Miner
aa9274991d
Treat boxOrdinalGroup and flexOrder as unitless.
2015-04-24 17:05:07 -07:00
Cheng Lou
f6ae856797
Merge pull request #3739 from chenglou/style-mut-comments
...
Tweak style mutation warning, remove test comment
2015-04-24 15:08:24 -04:00
Cheng Lou
1df2b6f638
Tweak style mutation warning, remove test comment
2015-04-24 15:04:05 -04:00
Cheng Lou
288c7ed139
Merge pull request #2027 from chenglou/warn-style-mutation
...
Set up `style` mutation monitoring
2015-04-24 14:51:33 -04:00
Paul O’Shannessy
4dbccea975
Merge pull request #3734 from marocchino/update-korean
...
Update Translation to 0183f70
2015-04-23 23:03:47 -07:00
Shim Won
8d0937e60d
Update Translation to 0183f70
2015-04-24 09:15:46 +09:00
Ben Alpert
0183f70797
Merge pull request #3727 from spicyj/dsih
...
Relax dangerouslySetInnerHTML validation
2015-04-22 17:37:40 -07:00
mheiber
39442aaa84
Update cloneWithProps documentation
...
Updated documentation to reflect that using React.cloneElement is the new way to copy an element and preserve `key` and `ref`.
Fixes #3432 , closes #3447 .
2015-04-22 17:05:59 -07:00
Ben Alpert
7f02455220
Relax dangerouslySetInnerHTML validation
...
Fixes #3460 .
2015-04-22 16:59:50 -07:00
Ben Alpert
a171474348
Merge pull request #3429 from AoDev/patch-1
...
Add a note about react classe name convention
2015-04-22 16:11:56 -07:00
Jim
41348ba911
Merge pull request #3640 from jsfb/render-subtree-pass-context
...
Provide top level method for rendering subtree (passes context)
2015-04-22 14:29:06 -07:00
Jim
c93b4245cb
Provide top level method for rendering subtree (passes context)
2015-04-22 14:25:29 -07:00
Jim
1a5fe9fd13
Merge pull request #3723 from jsfb/fix-bad-homepage-link
...
Fix bad links in docs. Fixes #3654 .
2015-04-22 13:35:02 -07:00
Jim
d900541021
Fix bad links in docs. Fixes #3654 .
2015-04-22 13:17:39 -07:00
Ben Alpert
3c66b8f0f7
Merge pull request #3665 from mridgway/replaceHasOwnProperty
...
[performance] Replace hasOwnProperty in child processing with typeof undefined check
2015-04-22 11:21:38 -07:00
Scott Feeney
d235940037
Merge pull request #3716 from graue/optional-shallow-render-context
...
Shallow render components that define contextTypes
2015-04-22 10:54:40 -07:00
Paul O’Shannessy
5b42e895c1
Merge pull request #3691 from jonscottclark/patch-1
...
Add 'cache: false' to $.ajax when fetching comments (docs/tutorial)
2015-04-22 09:57:58 -07:00
Paul O’Shannessy
4f285b7ba0
Merge pull request #3676 from zpao/rm-withContext
...
Remove withContext from top-level API
2015-04-22 09:45:26 -07:00
Jon Scott Clark
f4a6644f4e
Fix line highlighting in code blocks due to addition of extra example code
2015-04-22 10:45:15 -04:00
Scott Feeney
df937af91c
Shallow render components that define contextTypes
...
You now no longer have to pass an undocumented extra argument to the
shallow renderer for rendering components with contextTypes to work.
Fixes #3696
2015-04-21 16:17:06 -07:00
Paul O’Shannessy
f0c7fa3098
Merge pull request #3712 from zpao/changelog-jsxtransformer
...
Update Changelog for 0.13 to mention JSXTransfomer change
2015-04-21 15:04:43 -07:00
Paul O’Shannessy
73cad28e22
Update Changelog for 0.13 to mention JSXTransfomer change
2015-04-21 15:04:13 -07:00
Ben Alpert
cc412367dd
Merge pull request #3706 from spicyj/no-raf
...
Remove ReactRAFBatchingStrategy
2015-04-20 13:41:46 -07:00
Ben Alpert
302f0a1f5a
Remove ReactRAFBatchingStrategy
...
We don't use or support this, so let's just delete it. (#3570 )
2015-04-20 12:09:15 -07:00
Paul O’Shannessy
088d71c7c1
Merge pull request #3693 from reedloden/swap-http-to-https
...
SSL/TLSize all the things! (convert http:// to https:// where appropriate)
2015-04-20 11:02:29 -07:00
Paul O’Shannessy
7b89989c47
Merge pull request #3705 from zpao/doc/update-supported-attrs
...
[docs] Update supported HTML attributes
2015-04-20 10:45:36 -07:00
Jim
e5747b8ffb
Merge pull request #3697 from basecode/improve-pooler-tests
...
Improve `PooledClass` tests
2015-04-20 10:41:18 -07:00
Paul O’Shannessy
1dff5a2009
[docs] Update supported HTML attributes
2015-04-20 09:56:55 -07:00
Paul O’Shannessy
cfc734bb33
Merge pull request #3703 from JimBobSquarePants/patch-1
...
Example is JSX not JS.
2015-04-20 09:40:23 -07:00
James South
8972ad921f
Example is JSX not JS.
2015-04-20 14:26:39 +01:00
Tobias Reiss
e2fa43031e
should call new and old constructor with arguments
2015-04-20 00:43:55 +02:00
Paul O’Shannessy
ec31267e1c
Merge pull request #3694 from adamzap/fix-tutorial-line-highlighting
...
Fix missing line highlight in tutorial
2015-04-19 15:21:59 -07:00
Reed Loden
3e8951e8c7
SSL/TLSize all the things! (convert http:// to https:// where appropriate)
...
Update links to use https:// where it is supported. There's probably a lot
more that could be fixed, but these are the core ones I found (especially
the download links in order to prevent MITM attacks). Note that there are
some fb.me links that will redirect to http:// even while accessed over
https://, but this seemed like the best way to fix those for now.
NOTE: Only non-third-party files were modified. There are references to
http:// URLs in vendored/third-party files, but seems appropriate to fix
upstream for those rather than editing the files.
Also, copy one image locally to the blog, as it was hotlinking to a site
that did not support https://.
Last, use youtube-nocookie.com instead of youtube.com for video embeds,
as the former doesn't try to set a cookie on load (privacy enhancement).
2015-04-18 16:49:32 -07:00
Adam Zapletal
05562a0b09
Fix missing line highlight in tutorial
2015-04-18 18:36:18 -05:00
Paul O’Shannessy
feef6e885b
Tweak wording in 0.13.2 blog post
2015-04-18 16:08:01 -07:00
Paul O’Shannessy
5a19481160
v0.13.2 blog post
...
(cherry picked from commit 6ed202288b )
2015-04-18 15:58:13 -07:00
Paul O’Shannessy
1185fdaf1f
Update website with 0.13.2 builds
...
(cherry picked from commit 179f904525 )
2015-04-18 15:58:11 -07:00
Paul O’Shannessy
8a691f59fe
Readme for 0.13.2
...
(cherry picked from commit e1437078fc )
2015-04-18 15:57:05 -07:00
Paul O’Shannessy
3f5f78e374
Changelog for 0.13.2
...
(cherry picked from commit 4f1c61f915 )
2015-04-18 15:57:05 -07:00
Jon Scott Clark
90f086efbf
Add 'cache: false' to $.ajax when fetching comments
2015-04-18 11:11:18 -04:00
Jim
d9a9f5a0d4
Merge pull request #3625 from dmin/patch-1
...
Docs: Fix example JSX output
2015-04-17 14:22:25 -07:00
Paul O’Shannessy
550cce441f
Merge pull request #3678 from marocchino/update-korean
...
Update Translation to 6a7a4fd
2015-04-17 11:12:45 -07:00
Christopher Chedeau
d8ef641bcc
Merge pull request #3684 from vjeux/react-native-0-4
...
React Native 0.4 Blog Post
2015-04-17 09:13:31 -07:00
Christopher Chedeau
6fdac757c5
Update 2015-04-17-react-native-v0.4.md
2015-04-17 09:11:51 -07:00
Christopher Chedeau
4a1557b947
React Native 0.4 Blog Post
2015-04-17 09:03:55 -07:00
Shim Won
2d847a145c
Update Translation to 6a7a4fd
2015-04-17 17:19:04 +09:00
Leonardo YongUk Kim
7e64c16ff6
Create 19-dangerously-set-inner-html.ko-KR.md
...
Based on 2e1ccae275
2015-04-17 17:15:51 +09:00
Paul O’Shannessy
5297ff66cf
Remove withContext from top-level API
2015-04-16 15:58:27 -07:00
Ben Alpert
6a7a4fd635
Merge pull request #3675 from spicyj/gh-3655
...
Add warning for getDefaultProps on ES6 classes
2015-04-15 17:40:47 -07:00
Ben Alpert
b8b10001f3
Add warning for getDefaultProps on ES6 classes
...
Fixes #3655 .
2015-04-15 17:33:20 -07:00
Paul O’Shannessy
e21f7c7da3
Merge pull request #3673 from ultrafez/patch-1
...
"Advanced performance" typo fix
2015-04-15 16:42:25 -07:00
Alex
729ec1bb74
"Advanced performance" typo fix
...
Example code used the key "propsTypes" - correct to "propTypes"
2015-04-15 15:32:37 +01:00
Paul O’Shannessy
41a6186d7a
Merge pull request #3485 from jnu/ie10-flex-unitless
...
Treat flexPositive, flexNegative as unitless styles
2015-04-14 16:31:13 -07:00
Michael Ridgway
ed70d35e18
Update code style
2015-04-14 14:37:50 -07:00
Ben Alpert
45045049b0
Merge pull request #3668 from elquatro/master
...
Get rid of magic numbers in transitions example
2015-04-14 13:36:42 -07:00
Ilya Shuklin
0447f1e792
Update index.html
...
getting rid of magic numbers
2015-04-14 16:55:12 +03:00
Ben Alpert
be03fa7f46
Merge pull request #3663 from spicyj/san-md
...
[docs] Use marked instead of Showdown and escape HTML
2015-04-13 16:44:19 -07:00
Ben Alpert
36aefcb8cc
[docs] Use marked instead of Showdown and escape HTML
...
Fixes #3501 .
2015-04-13 15:50:40 -07:00
Ben Alpert
d8117d0df6
Merge pull request #1366 from spicyj/enterleave-testutils
...
Make Simulate.mouseEnter/Leave use direct dispatch
2015-04-13 15:39:54 -07:00
Michael Ridgway
5a431a12ac
Replace hasOwnProperty in child processing with typeof undefined check
2015-04-13 14:17:16 -07:00
Paul O’Shannessy
6d868a2705
Merge pull request #3662 from zpao/update-uglify
...
Update uglify dependency
2015-04-13 13:18:30 -07:00
Paul O’Shannessy
d467b52758
Update uglify dependency
...
Apparently we needed to get to v2.4.17 to get the fix for #2247 . We
shrinkwrapped on the same day but the timing didn't work out so we missed it.
2015-04-13 12:49:45 -07:00
Paul O’Shannessy
3c174cacc9
Merge pull request #3658 from sbezludny/patch-1
...
Fixed typo
2015-04-13 09:48:08 -07:00
Serg
1bf7648108
Fixed typo
2015-04-13 12:12:49 +03:00
Ben Alpert
ce215483ae
Don't thread index through traverseAllChildren
...
I'm not super attached to this, but this feels cleaner to me. Might even be faster since flattenChildren doesn't use the index. Probably no change though.
2015-04-11 01:04:20 -07:00
Ben Alpert
88fb106c39
Merge pull request #3646 from facebook/revert-3580-2402-warn-multiple-copies-of-react-on-same-page
...
Revert "Warn when multiple instances of React are loaded on the same page"
2015-04-10 13:54:57 -07:00
Ben Alpert
8fa15080b2
Revert "Warn when multiple instances of React are loaded on the same page"
2015-04-10 12:34:04 -07:00
Paul O’Shannessy
b8ba8c83f3
Update Patent Grant
...
https://code.facebook.com/posts/1639473982937255/updating-our-open-source-patent-grant/
2015-04-10 12:15:29 -07:00
Paul O’Shannessy
c164c477fb
Merge pull request #3645 from facebook/revert-3644-patch-1
...
Revert "Add webkitdirectory and nwdirectory attributes for input file"
2015-04-10 10:24:46 -07:00
Paul O’Shannessy
71fdf09630
Revert "Add webkitdirectory and nwdirectory attributes for input file"
2015-04-10 10:22:52 -07:00
Jim
5e9623d1a2
Merge pull request #3644 from gregorym/patch-1
...
Add webkitdirectory and nwdirectory attributes for input file
2015-04-10 10:16:40 -07:00
Gregory
5a7c6964cc
Add webkitdirectory and nwdirectory attributes for input file
...
Add attributes for <input type="file" />
* webkitdirectory
* nwdirectory
2015-04-10 09:51:54 -07:00
Paul O’Shannessy
86c72a5271
Merge pull request #3642 from marocchino/ko-update
...
Update Korean translation to 0185c68
2015-04-09 16:37:24 -07:00
Isaac Salier-Hellendag
4ff99a2873
Merge pull request #3639 from salier/select-event-plugin
...
Skip SelectEventPlugin extraction if no listeners
2015-04-09 18:29:37 -05:00
Isaac Salier-Hellendag
47b147f392
Skip SelectEventPlugin extraction if no listeners
...
If there are no listeners for `onSelect` yet, do not extract events. This way we can avoid issues where listeners have been set up for some event dependencies for `SelectEventPlugin`, but not all.
For instance, if `topMouseDown` has been registered but not `topMouseUp`, event extraction will set the `mouseDown` flag to true but never unset it. This leads to bugs when `onSelect` is registered and should be firing during normal key behavior. Since no `topMouseUp` has yet occurred to unset the flag, `onSelect` fails to fire.
2015-04-09 17:55:42 -05:00
Shim Won
57f14017fb
Update Korean translation to 0185c68
2015-04-10 06:54:28 +09:00
Leonardo YongUk Kim
78f59da8df
Translate tips 11 to Korean
...
1. Create 11-dom-event-listeners.ko-KR.md
2. Update 03-interactivity-and-dynamic-uis.ko-KR.md to add an anchor.
Based on 52494f9d72
2015-04-10 06:52:32 +09:00
Leonardo YongUk Kim
792c161cc5
Create 12-initial-ajax.ko-KR.md
...
Based on 52494f9d72
2015-04-10 06:52:32 +09:00
Leonardo YongUk Kim
16832c701b
Create 13-false-in-jsx.ko-KR.md
...
Based on 52494f9d72
2015-04-10 06:52:31 +09:00
Paul O’Shannessy
9d6b119c3f
Merge pull request #3641 from ljharb/patch-1
...
Updating `es5-shim` URL
2015-04-09 14:24:26 -07:00
Jordan Harband
5ddd307c5e
Updating es5-shim URL
2015-04-09 13:51:34 -07:00
Jim
0185c68c91
Merge pull request #3615 from jsfb/enable-new-context
...
Switch to parent-based context. Fixes #2112 .
2015-04-09 13:21:26 -07:00
Jim
0f0f5aa701
Merge pull request #3638 from devicehubnet/master
...
check if type.prototype is object in instantiateReactComponent
2015-04-09 12:35:57 -07:00
Paul O’Shannessy
857736dc13
Merge pull request #3636 from cody/jsx-target
...
Add target option to npm readme
2015-04-09 10:27:06 -07:00
Teodor Szente
cdd359b710
check if is undefined
2015-04-09 20:12:22 +03:00
Jim
f4a07c4b53
Merge pull request #3635 from garethnic/reuseCompDoc
...
Clarify sentence in Reusable Components doc
2015-04-09 10:01:10 -07:00
Teodor Szente
8f6bae21fb
check if type.prototype is object
2015-04-09 19:29:25 +03:00
Stefan Dombrowski
148543ce2b
Add target option to npm readme
2015-04-09 13:04:04 +02:00
Gareth Nicholson
5c35d93436
clarify sentence
2015-04-09 12:16:21 +02:00
Jim
f1cd867323
Merge pull request #3580 from robertknight/2402-warn-multiple-copies-of-react-on-same-page
...
Warn when multiple instances of React are loaded on the same page
2015-04-08 19:18:44 -07:00
Ben Alpert
50e08d4269
Merge pull request #3627 from spicyj/mut-warn-clone
...
Refer to cloneElement in mutation warning
2015-04-08 15:33:56 -07:00
Paul O’Shannessy
b6756c56ff
Merge pull request #3584 from ThornWinters/patch-1
...
More Uniform Formating
2015-04-08 15:33:16 -07:00
Ben Alpert
177dfea503
Merge pull request #3628 from spicyj/do-not-bind
...
Kill ReactDoNotBindDeprecated
2015-04-08 15:28:07 -07:00
Ben Alpert
e60a26a682
Kill ReactDoNotBindDeprecated
...
No one uses this.
2015-04-08 15:15:02 -07:00
Ben Alpert
05f6e7de71
Refer to cloneElement in mutation warning
2015-04-08 14:51:17 -07:00
Ben Alpert
44f0e801df
Merge pull request #3587 from spicyj/kill-plq
...
Kill ReactPutListenerQueue
2015-04-08 14:49:53 -07:00
David Mininger
86bac33408
Docs: Fix example JSX output
2015-04-08 14:23:49 -05:00
Paul O’Shannessy
ee811b1614
[docs] Fix typo
...
Introduced in #3589
2015-04-08 10:39:26 -07:00
Paul O’Shannessy
a34cf222ba
Merge pull request #3604 from Charca/firefox-tests-fixes
...
Fixes for several failing tests in Firefox and Safari
2015-04-08 10:34:57 -07:00
Paul O’Shannessy
cf76365cd9
Merge pull request #3618 from TimeBomb/master
...
Document new es6module flag in react-tools README
2015-04-08 10:31:24 -07:00
Christoph Pojer
214c1f9919
Merge pull request #3622 from cpojer/copyright-headers
...
Add copyright headers to npm-react-codemod.
2015-04-08 10:29:06 -07:00
cpojer
245f0d0afa
Add copyright headers to npm-react-codemod.
2015-04-08 10:28:20 -07:00
Jim
5b7f865ffe
Merge pull request #3621 from bhamodi/master
...
Update Copyright notices to include 2015
2015-04-08 10:10:12 -07:00
Baraa Hamodi
8e806ba382
Merge pull request #2 from bhamodi/bhamodi-patch-1
...
Update ReactDOMIframe-test.js
2015-04-08 13:06:50 -04:00
Baraa Hamodi
d9d77bc9a5
Update ReactDOMIframe-test.js
2015-04-08 13:06:37 -04:00
Baraa Hamodi
9ecdd3600b
Merge pull request #1 from bhamodi/2015-update
...
Update ReactCompositeComponentNestedState-test.js
2015-04-08 13:05:38 -04:00
Baraa Hamodi
c9e3a32bc5
Update ReactCompositeComponentNestedState-test.js
2015-04-08 13:02:43 -04:00
Jason
eb377195be
Document new es6module flag in react-tools README
2015-04-08 01:01:54 -07:00
Ben Alpert
e27ad4add3
Merge pull request #3589 from theseyi/master
...
Documentation: Fixed typo / grammar in 'clone with props'
2015-04-07 17:33:52 -07:00
Ben Alpert
057f41ec0f
Merge pull request #3595 from spicyj/select-ssr
...
Fix server-side rendering of <select>
2015-04-07 16:49:10 -07:00
Ben Alpert
ea089fdfe6
Fix server-side rendering of <select>
...
Fixes #1398 .
2015-04-07 16:48:58 -07:00
Jim
7d44917531
Switch to parent-based context. Fixes #2112 .
2015-04-07 14:49:29 -07:00
Paul O’Shannessy
3eb2a01ec1
Merge pull request #3612 from gaearon/patch-1
...
Mention Flux in “communicate between components”
2015-04-07 13:14:44 -07:00
Paul O’Shannessy
af819d122e
Merge pull request #3614 from kassens/set_style_null
...
Fix for style not always reset when set to null
2015-04-07 13:13:31 -07:00
Jan Kassens
eda9ec53b5
Fix for style not always reset when set to null
...
When the style property existed, but was set to null, `this._previousStyleCopy`
was not set back to `null` causing an old value to persist. This broke setting
the style to `null` the next time.
Fixes #3606 .
2015-04-07 12:17:06 -07:00
Dan Abramov
21d91e6f5f
Mention Flux in “communicate between components”
2015-04-07 19:44:20 +03:00
Maxi Ferreira
49745e7bff
Fixes for several failing tests in Firefox and Safari
2015-04-07 01:37:27 -03:00
Seyi Adebajo
5eaca79baa
Documentation: Suggested edit adds clarity regarding when 'shouldComponentUpdate' is triggered and what the 're-rendering' process entails.
2015-04-05 18:46:38 -04:00
Seyi Adebajo
a366ec16e6
Fixed typo / grammar docs
2015-04-05 18:46:38 -04:00
Ben Alpert
ddbbaa9500
Merge pull request #3590 from koba04/patch-1
...
component.render method returns a ReactElement.
2015-04-04 23:47:05 -07:00
Toru Kobayashi
c7a2d46ead
component.render method returns a ReactElement.
2015-04-05 15:33:19 +09:00
Ben Alpert
aee05c27ea
Merge pull request #3588 from marocchino/ko-update
...
Update Korean translation to d402bd3
2015-04-04 22:26:50 -07:00
Shim Won
b9f02d37ed
Update Korean translation to d402bd3
2015-04-05 09:44:54 +09:00
Ben Alpert
7529e6de47
Kill ReactPutListenerQueue
...
As far as I can tell, this is almost equivalent and is simpler. When a component's componentDidMount is called, all the listeners for that subtree will have been attached which I think is all that matters.
2015-04-04 17:34:35 -07:00
Michael Warner
0126e9efcd
More Uniform Formating
...
Corrected so the formatting in this document matches the same as others.
2015-04-03 20:37:42 -07:00
Ben Alpert
d402bd3831
[docs] Fix type on renderIntoDocument
...
Fixes #3581 .
2015-04-03 09:12:10 -07:00
Robert Knight
8ad58ae45a
Warn when multiple instances of React are loaded on the same page
...
This causes a variety of hard-to-debug issues.
See #2402 for examples.
Fixes #2402
2015-04-03 11:46:58 +01:00
Paul O’Shannessy
5a3bda983b
Merge pull request #3567 from chenglou/rm-getdomnode
...
Remove some `getDOMNode` from docs and DOMComponent test
2015-04-02 15:01:15 -07:00
Paul O’Shannessy
1576c1a2b9
Merge pull request #3576 from chenglou/last-getdomnode
...
Remove last call to `getDOMNode` in tests
2015-04-02 15:00:39 -07:00
Cheng Lou
f3e6436bee
Remove last call to getDOMNode in tests
2015-04-02 17:26:19 -04:00
Cheng Lou
5561d0e925
Remove some getDOMNode from docs and examples
2015-04-02 17:23:27 -04:00
Ben Alpert
dea7efbe16
Merge pull request #3555 from spicyj/native-overrides
...
Import ResponderEventPlugin from react-native
2015-04-02 14:13:35 -07:00
Paul O’Shannessy
29dc96c202
Merge pull request #3574 from rogozhnikoff/patch-1
...
Increase speed of shallowEqual
2015-04-02 13:55:11 -07:00
Ben Alpert
5a01f5f6a9
Fix ResponderEventPlugin to work in core React again
...
Test Plan: jest, grunt fasttest
2015-04-02 13:33:47 -07:00
Murad
6963ea4bfc
Update shallowEqual.js
2015-04-03 03:44:37 +08:00
Ben Alpert
54615fc6c0
Merge pull request #3572 from iamdoron/patch-1
...
use 'forEach' instead of 'map' when clearing intervals
2015-04-02 11:29:49 -07:00
Murad
d912329c97
Update shallowEqual.js
...
optimize for lint rules
2015-04-03 00:12:07 +08:00
Murad
d2bb4728f0
Increase speed of shallowEqual
...
All testes successfully completed.
- for-in in browsers is slow, i replaced him by Object.keys + for(array)
- simple check of lengths let us not iterate if not same
- now we dont need to test for B's keys missing from A, because if length's is same and prev check success - objB hasn't more keys
- micro optimize: calling objB.hasOwnProperty
- micro optimize: replaced !objA || !obj for more speedy check === null
#inspiredby https://github.com/jurassix/react-immutable-render-mixin/pull/4
2015-04-02 23:43:29 +08:00
iamdoron
f1e6a0dad2
use 'forEach' instead of 'map' when clearing intervals
2015-04-02 14:06:08 +03:00
Cheng Lou
6e992fbbdd
Set up style mutation monitoring
...
This works by storing the style and its copy onto the component, and do
the appropriate comparison during `_updateDOMProperties`.
2015-04-01 22:05:09 -04:00
Jim
3fad007bdb
Merge pull request #3560 from mariodu/mariodu
...
fix render order error in safari. Fixes #3560 .
2015-04-01 17:40:09 -07:00
Ben Alpert
db38059669
Merge pull request #3564 from spicyj/travis
...
Fix inverted feature test in .travis.yml
2015-04-01 15:17:32 -07:00
Ben Alpert
9c12e48f68
Fix inverted feature test in .travis.yml
...
I messed this up in #3540 .
2015-04-01 15:12:17 -07:00
Ben Alpert
08e4420019
Use setState transaction for TransitionGroup instead of extra property
2015-04-01 14:34:01 -07:00
Ben Alpert
205273d2ee
Merge pull request #2549 from ashtuchkin/fix-transitiongroup-multiremove
...
Fix ReactTransitionGroup behavior when removing several children at once
2015-04-01 14:33:42 -07:00
Paul O’Shannessy
dcc194bbb8
Merge pull request #3563 from quizlet/fix-addons-hasownproperty
...
Fix immutability helper to check hasOwnProperty safely
2015-04-01 12:38:04 -07:00
Jeff Chan
af7e43269f
Fix immutability helper to check hasOwnProperty safely
...
This makes `update({}, {'hasOwnProperty': {$set: 'yolo'}})` work.
2015-04-01 12:25:12 -07:00
Paul O’Shannessy
7f30a1fed3
Merge pull request #3562 from dalinaum/rename
...
Rename 19--dangerouslySetInnerHTML.md -> 19-dangerously-set-inner-html.md
2015-04-01 12:13:55 -07:00
Leonardo YongUk Kim
2e1ccae275
Rename 19--dangerouslySetInnerHTML.md -> 19-dangerously-set-inner-html.md
...
1. It had double dash.
2. Its name was inconsistent. Other tips are named by their IDs.
2015-04-02 04:11:22 +09:00
凌恒
6094ebbc39
update comment
2015-04-01 23:59:43 +08:00
凌恒
54a74d95bb
deal IE8 out of size error
2015-04-01 23:56:05 +08:00
凌恒
d4adaee4eb
use ie8 feature detect instead of try catch
2015-04-01 21:46:40 +08:00
凌恒
e1a8d69840
fix render order error in safari
2015-04-01 18:13:03 +08:00
Ben Alpert
036d342189
Fix unused variable lint from #3552
2015-03-31 17:06:42 -07:00
Ben Alpert
5241ebb0bc
Merge pull request #3556 from wali-s/patch-1
...
Fix small typo in 11-advanced-performance.md.
2015-03-31 17:03:15 -07:00
Ahmad Wali Sidiqi
4fe1b59849
Fix small typo in 11-advanced-performance.md.
...
"React didn't even had"->"React didn't even have"
http://english.stackexchange.com/questions/204603/proper-usage-of-didnt-had-or-didnt-have
2015-03-31 16:18:45 -07:00
Ben Alpert
6ec3b65169
Import ResponderEventPlugin from react-native
...
This is a direct import of the files from react-native, with the license headers updated.
2015-03-31 15:21:47 -07:00
Paul O’Shannessy
8c3d6b05d6
Merge pull request #3534 from tonyspiro/master
...
Update index.html in transitions example
2015-03-31 13:49:50 -07:00
Paul O’Shannessy
94a3b0f8a3
Merge pull request #3552 from James-Dunn/fix-for-loops
...
Remove caching from for loops
2015-03-31 10:30:44 -07:00
James
90dcc1ffb7
Remove caching from for loops
...
Removed caching from for loops as it does not seem to increase
performance and makes the code harder to read.
2015-03-31 10:22:52 +04:00
Paul O’Shannessy
18d608820e
Merge pull request #3519 from jonchester/patch-1
...
Add IE-specific 'unselectable' attribute
2015-03-30 15:27:13 -07:00
Paul O’Shannessy
0c2238bb72
Merge pull request #3537 from marocchino/korean-update
...
Update Korean translations
2015-03-30 14:20:37 -07:00
Ben Alpert
a7a6c425d4
Merge pull request #3549 from spicyj/trans-sync
...
Sync transforms from internal
2015-03-30 14:15:09 -07:00
Ben Alpert
c9ef8f62ba
Merge pull request #3445 from mihaip/master
...
Use full chain of member expressions when generating display names.
2015-03-30 11:46:54 -07:00
Ben Alpert
4d84784ca6
Sync transforms from internal
2015-03-30 11:43:26 -07:00
Ben Alpert
835fc3d0fb
Squelch git warning on Travis
2015-03-30 11:25:55 -07:00
Ben Alpert
76805fdfda
Set name and email a different way
2015-03-30 11:20:23 -07:00
Ben Alpert
be566e0aa6
Set git name and email for Travis
2015-03-30 11:16:36 -07:00
Ben Alpert
b7c4da59ca
[docs] English tweaks (and testing Travis)
2015-03-30 11:10:44 -07:00
Ben Alpert
a39af74c6f
Merge pull request #3540 from spicyj/auto-gh-pages
...
Autobuild website on Travis from stable branch
2015-03-30 10:57:06 -07:00
Ben Alpert
accb4f6047
Autobuild website on Travis from stable branch
...
$REACT_WEBSITE_BRANCH in https://travis-ci.org/facebook/react/settings/env_vars now needs to point to the stable branch (currently 0.13-stable). I haven't tested the commit-and-push part of this but everything else works so I'm hopeful.
2015-03-30 10:56:41 -07:00
Ben Alpert
b20778a7f6
Merge pull request #3543 from spicyj/keep-docs-js-react
...
Keep docs/js/{react,JSXTransformer}.js in repo
2015-03-30 10:55:29 -07:00
jonchester
a0265fe8b7
Add IE-specific 'unselectable' attribute
...
I ended up needing to add this attribute to work around a common IE bug, that clicking on a scrollbar gives focus to the scroll container. I needed to set it as MUST_USE_ATTRIBUTE or the attribute would not be passed through by React successfully.
remove trailing spaces
2015-03-30 07:44:08 -07:00
Christopher Chedeau
bfe1c5b60d
Merge pull request #3545 from vjeux/roundup_26
...
Roundup 26
2015-03-30 07:23:20 -07:00
Christopher Chedeau
6bb2185bf0
Roundup 26
2015-03-29 20:02:40 -07:00
Paul O’Shannessy
ec2f35e0c9
Merge pull request #3544 from prathamesh-sonpatki/fix-link-to-display-name
...
Fixed link to displayName component spec from JSX in depth article
2015-03-29 10:30:24 -07:00
Prathamesh Sonpatki
139020d982
Fixed link to displayName component spec from JSX in depth article
2015-03-29 16:50:33 +05:30
Paul O’Shannessy
15e6968ad5
Merge pull request #3539 from russellpwirtz/patch-1
...
Update tutorial.md
2015-03-28 21:26:29 -07:00
Ben Alpert
0b6c7c29fe
Keep docs/js/{react,JSXTransformer}.js in repo
...
This way we don't need to rebuild them each time for the website.
2015-03-28 14:56:54 -07:00
Russ
fdcf1f2b0e
Update tutorial.md
...
Grammar fix
2015-03-28 11:37:55 -07:00
Ben Alpert
f3d3ccb8b3
Update README.md
2015-03-28 10:55:15 -07:00
James Pearce
78dd5e2c1e
Update README.md
2015-03-28 10:33:56 -07:00
James Pearce
494be2179c
'New' note
2015-03-28 10:33:15 -07:00
Shim Won
6911fa5c5b
Update Korean translation to b3c75d8
2015-03-28 18:02:25 +09:00
jiyeonseo
0b3fe6f47e
Translate tips 05..10
...
- Up to 3fd6ac5
2015-03-28 08:51:52 +09:00
Jinwoo Oh
45a3332a38
Translate tip-18 to Korean
...
- Up to 6f44f60
2015-03-28 08:47:18 +09:00
Jinwoo Oh
4df79154de
Translate tip-17 to Korean
...
- Up to 6f44f60
2015-03-28 08:47:12 +09:00
Jinwoo Oh
452f2f282f
Translate tip-16 to Korean
...
- Up to 1cb3f25
2015-03-28 08:47:05 +09:00
Jinwoo Oh
23a5a89077
Translate tip-15 to Korean
...
- Up to 52494f9
2015-03-28 08:46:57 +09:00
Jinwoo Oh
03666e884d
Translate tip-14 to Korean
...
- Up to 92c37ff
2015-03-28 08:46:37 +09:00
Ted Kim
aa6bfb6b51
Translate tips 01..04 (based on 157d7770c99be26a9e0557d00978f15f6d9db794)
2015-03-28 08:46:26 +09:00
Shim Won
712710cabc
Update to ed257cb
2015-03-28 08:46:14 +09:00
Tony Spiro
03e0ebf532
Update index.html
...
'current' makes more sense than 'start' as the value increments passed it's start value.
2015-03-27 15:17:07 -05:00
Paul O’Shannessy
e30dd83896
Merge pull request #3240 from reactkr/translate-ko-release
...
Korean translation for docs
2015-03-27 11:39:54 -07:00
Jim
b3c75d82b2
Merge pull request #3521 from grant/master
...
Display error when trying to create an element of type `boolean`. Fixes #3478
2015-03-26 14:39:32 -07:00
Jim
335221910d
Merge pull request #3527 from mertkahyaoglu/master
...
remove unrelated doc line
2015-03-26 14:27:42 -07:00
Ben Alpert
56067147fe
Merge pull request #3529 from uzarubin/patch-1
...
Swapping defaultChecked and defaultValue
2015-03-26 13:51:25 -07:00
Ustin Zarubin
c45fa8b581
Swapping defaultChecked and defaultValue
...
The current documentation states that the `<select>` tag supports `defaultChecked`, but it actually doesn't. I believe this documentation was meant to be written in the proposed order.
Non-working fiddle using `defaultChecked`: http://jsfiddle.net/jqs1hsLr/1/
Working fiddle using `defaultValue`: http://jsfiddle.net/nv7z0yzL/1/
2015-03-26 16:42:36 -04:00
Ben Alpert
c3b0d8d9c6
Merge pull request #3525 from spicyj/home-3
...
[docs] Tweak words on homepage
2015-03-26 12:29:59 -07:00
Ben Alpert
eef22ece37
[docs] Split up second sentence more
2015-03-26 12:29:14 -07:00
Mert Kahyaoğlu
6248406d6a
remove unrelated doc line
2015-03-26 21:08:32 +02:00
Ben Alpert
cf956ac8be
[docs] Tweak words on homepage
2015-03-26 10:42:01 -07:00
Ben Alpert
951adcdd4c
Add React Native blog post
2015-03-26 10:10:43 -07:00
Grant Timmerman
59a914aac0
Disable numeric element types
2015-03-26 10:07:56 -07:00
Ben Alpert
ca66399402
[docs] Update site nav
2015-03-26 10:06:09 -07:00
Grant Timmerman
3c9ea72795
Display error when trying to create an element of type boolean. Fixes #3478
2015-03-26 01:21:54 -07:00
Ben Alpert
b32fbef7c5
Add missing semicolon
2015-03-25 18:10:49 -07:00
Ben Alpert
a4630c3928
Merge pull request #3520 from spicyj/validate-message
...
Tweak validation message, add html support
2015-03-25 17:43:55 -07:00
Ben Alpert
7c6694987d
Tweak validation message, add html support
...
The old message made no sense if you had a > div > a or similar. I'm clearly feeling sloppy today.
2015-03-25 17:24:13 -07:00
Ben Alpert
da598c6a27
Merge pull request #3518 from alopatin/patch-1
...
Docs: Clarify that React.PropTypes.node accepts fragments
2015-03-25 17:23:52 -07:00
Paul O’Shannessy
6cb0b985a7
Merge pull request #3504 from clariroid/docsJP
...
Translate 2 docs into Japanese
2015-03-25 17:20:59 -07:00
Alex Lopatin
6daa22be5a
Docs: Clarify that React.PropTypes.node accepts fragments
...
As of #3293 `ReactFragment` counts as a node, but this isn't made clear in the docs.
2015-03-25 17:17:42 -07:00
Ben Alpert
07b7e8424d
Remove stray console.log comment
2015-03-25 17:06:42 -07:00
Ben Alpert
7bef374f3f
Merge pull request #3517 from spicyj/jest-config
...
Only run src/ and vendor/fbtransform/ tests in jest
2015-03-25 17:06:26 -07:00
Ben Alpert
98fff82336
Merge pull request #3516 from spicyj/valid-4
...
Validate only against problematic tag nesting
2015-03-25 17:01:09 -07:00
Paul O’Shannessy
029a526916
Merge pull request #3498 from AnSavvides/patch-1
...
Include latest version of jQuery in tutorial
2015-03-25 16:53:13 -07:00
Ben Alpert
d12c968dec
Only run src/ and vendor/fbtransform/ tests in jest
...
Test Plan: jest
2015-03-25 16:49:01 -07:00
Ben Alpert
76bb96ef21
Validate only against problematic tag nesting
...
Turns out lots of people write invalid HTML all the time and no one, including your browser or React, cares. Most invalid HTML combinations don't cause magic reparented nodes; only some do. The HTML5 parsing spec (https://html.spec.whatwg.org/multipage/syntax.html ) specifies which tag combinations cause strange parsing behavior. I did my best to encode the logic here. It's more lenient than before in some cases, but more strict in others (before we didn't look at the whole stack of tags; now we warn with deeply nested `p` or `form` or `a` tags).
2015-03-25 16:43:41 -07:00
Christoph Pojer
949349d5ca
Merge pull request #3515 from cpojer/fix-class-transform
...
npm-react-codemod: Class transform doesn’t need aliases
2015-03-25 16:35:18 -07:00
cpojer
bc8b057bf0
npm-react-codemod: Class transform doesn’t need an alias for module.exports = React.createClass any longer.
...
Before: `module.exports = class __exports extends React.Component {}`
After: `module.exports = class extends React.Component {}`
See 638ef2b9d2
2015-03-25 16:31:23 -07:00
Christoph Pojer
86836c885d
Merge pull request #3506 from cpojer/react-codemod
...
Add npm-react-codemod
2015-03-25 16:20:14 -07:00
cpojer
1865c042d7
Update README for npm-react-codemod
2015-03-25 16:15:07 -07:00
cpojer
d9c13c73b6
Add ES6 class transform
2015-03-25 16:11:52 -07:00
cpojer
d4cb2537af
Add pure-render-mixin transform
2015-03-25 16:11:52 -07:00
cpojer
20004e94d3
Add findDOMNode transform
2015-03-25 16:11:52 -07:00
cpojer
328274bbba
Add ReactUtils and array polyfills.
2015-03-25 16:11:52 -07:00
cpojer
e361fcb3e6
Add skeleton for react-codemod
2015-03-25 16:11:48 -07:00
Andreas Savvides
580f2d829b
Include latest version of jQuery in tutorial
...
Include latest version of jQuery 2.x in tutorial
2015-03-25 22:36:27 +00:00
clariroid
a869a0f7b0
Fix the locale id
2015-03-26 06:15:52 +09:00
clariroid
574b906f9b
Translate 2 docs into Japanese
2015-03-26 06:15:50 +09:00
Paul O’Shannessy
27a191e704
Merge pull request #3513 from agelter/master
...
Added support for the 'low', 'high', and 'optimum' attributes that are missing from the <meter> tag.
2015-03-25 12:17:07 -07:00
Paul O’Shannessy
56b180b464
Fix failing test
...
PR #3494 was based on master before we shifted to using console.error. This
just fixes the new test case.
2015-03-25 12:15:41 -07:00
Jim
13dbda3644
Merge pull request #3494 from letiemble/B_Context_Rerender
...
Fix the context handling when updating a rendered component.
2015-03-25 11:55:35 -07:00
Paul O’Shannessy
8bd9541e08
Merge pull request #3503 from aredridel/patch-1
...
npm without -g should never need sudo
2015-03-25 10:55:41 -07:00
Paul O’Shannessy
a164222367
Merge pull request #3507 from dpellier/master
...
Add scoped property to the list of DOM standard properties
2015-03-25 10:54:29 -07:00
Paul O’Shannessy
f86a7f86cc
Merge pull request #3511 from AnSavvides/glossary-space
...
Minor space change to be in line with coding style everywhere else
2015-03-25 10:51:15 -07:00
Aaron Gelter
c9e82ce0f6
Added support for the 'low', 'high', and 'optimum' attributes that the <meter> tag requires.
2015-03-25 11:33:02 -06:00
Andreas
b6534bec7d
Minor space change to be in line with coding style everywhere else
2015-03-25 17:09:58 +00:00
Damien Pellier
3d45c0ad9d
add scoped property to the list of DOM standard properties
2015-03-25 09:41:05 +01:00
Aria Stewart
151384dd22
npm without -g should never need sudo
2015-03-24 19:47:31 -07:00
Paul O’Shannessy
45fdb4ba79
Merge pull request #3487 from zpao/doc/video
...
[docs] Videos: use https, right width videos
2015-03-24 14:18:36 -07:00
Paul O’Shannessy
21bb7582c0
Merge pull request #3491 from bobbyrenwick/transition-group-appear-docs
...
adding docs for componentWillAppear and componentDidAppear
2015-03-24 14:05:11 -07:00
Paul O’Shannessy
09ecf8bca9
Merge pull request #3499 from sverrejoh/patch-1
...
Don't add 'px' to strokeDashoffset CSS Properties
2015-03-24 13:57:02 -07:00
Sverre Johansen
77abea5ddc
Reordered properties to maintain ABC order
2015-03-24 20:43:55 +00:00
Ben Alpert
6ad4afd404
Merge pull request #3502 from spicyj/tests
...
Fix tests after merge of #3440
2015-03-24 13:41:34 -07:00
Paul O’Shannessy
2795fb162a
Merge pull request #3490 from chenglou/remove-class-addon
...
Remove classSet/cx
2015-03-24 13:39:47 -07:00
Ben Alpert
4dde417214
Fix tests after merge
...
Test Plan: jest
2015-03-24 13:37:39 -07:00
Ben Alpert
9260b540ad
Merge pull request #3467 from spicyj/valid-3
...
Validate node nesting, take 3
2015-03-24 13:30:16 -07:00
Ben Alpert
1aa4e3c234
Merge pull request #3440 from spicyj/console-error
...
Use console.error to show stack trace in console
2015-03-24 13:30:01 -07:00
Sverre Johansen
c28059e39b
Don't add 'px' to strokeDashoffset CSS Properties
...
This is a SVG CSS Property. The standard expects values or percentages, and adding "px" to the value will break it.
http://www.w3.org/TR/SVG/painting.html#StrokeDashoffsetProperty
2015-03-24 17:52:02 +00:00
Laurent Etiemble
357345a56d
Fix the context handling when updating a rendered component.
2015-03-24 08:29:09 +01:00
Bob Renwick
3b33ead6ac
adding docs for componentWillAppear and componentDidAppear
2015-03-24 01:41:04 +00:00
Cheng Lou
9df173113b
Remove mention from docs
2015-03-23 20:13:24 -04:00
Cheng Lou
18ab88aa78
Remove classSet/cx
2015-03-23 17:59:27 -04:00
Paul O’Shannessy
cb05e2f85b
Merge pull request #3271 from delftswa2014/fix/todo-example
...
Added the key attribute into the todo example
2015-03-23 14:54:08 -07:00
Paul O’Shannessy
90f8a89ac4
Merge pull request #3488 from delftswa2014/grunt-coverage-fix
...
Removed build:test from test:coverage.
2015-03-23 14:49:56 -07:00
PNikray
e931aaab4a
Removed build:test from test:coverage.
...
This was a duplicate task for build:withCodeCoverageLogging.
It should now properly output the lines which are not covered.
2015-03-23 21:32:49 +01:00
Paul O’Shannessy
21221e0376
[docs] Videos: use https, right width videos
...
I also added some <hr>s in there, which helps a little bit with spacing.
2015-03-23 11:38:10 -07:00
Paul O’Shannessy
11983d8d6b
Merge pull request #3483 from julen/docs/document-body-footgun
...
Docs: do not render components to `document.body`
2015-03-23 11:09:48 -07:00
Paul O’Shannessy
dd2e2ecaee
Merge pull request #3481 from mertkahyaoglu/master
...
minor fixes in package.json
2015-03-23 09:45:13 -07:00
Joseph Nudell
51b6092264
Update unprefixed css props doc
2015-03-23 11:30:56 -05:00
Joseph Nudell
30b2cfc1fd
Treat flexPositive/Negative/boxFlex as unitless styles
2015-03-23 11:29:55 -05:00
Julen Ruiz Aizpuru
d83596620f
Docs: do not render components to document.body
...
Rendering to `document.body` in the examples is conveniently short, but it can
be misleading at the same time, especially for newcomers.
While it's possible to render React components to `document.body`, any 3rd
party scripts can also mess up with it, and it can have unintended consequences
and be source of difficult-to-trace bugs.
2015-03-23 13:59:24 +01:00
Mert Kahyaoğlu
31bab53cc8
minor fixes in package.json
2015-03-22 22:09:24 +02:00
Ben Alpert
5dee15273f
Merge pull request #3475 from MaximAbramchuck/patch-1
...
Add missing semicolon
2015-03-21 13:43:22 -07:00
Maxim Abramchuk
9b70e82246
Add missing semicolon
2015-03-21 23:11:45 +03:00
Ben Alpert
f9abf493b4
Validate node nesting, take 3
...
Nicer version of #644 and #735 . Fixes #101 . Context is neat.
2015-03-20 16:10:02 -07:00
Ben Alpert
ed3e6ecb9b
Merge pull request #3472 from mertkahyaoglu/master
...
move getReactRootElementInContainer to ReactMount.js
2015-03-20 12:29:53 -07:00
Mert Kahyaoğlu
63aa7259b9
move getReactRootElementInContainer to ReactMount.js
...
getReactRootElementInContainer.js file contains one function used only
in ReactMount.js.
2015-03-20 20:50:11 +02:00
Paul O’Shannessy
786055415b
Merge pull request #3129
...
Put comma after any non-whitespace non-comment characters in JSXExpression
2015-03-20 10:32:11 -07:00
Jason Miller
ef796790ec
Put comma after any non-comments, non-whitespace in JSXEspression
...
Fixes #1673
Closes #3129
2015-03-20 10:27:21 -07:00
Ben Alpert
70f16cc936
Merge pull request #3471 from mertkahyaoglu/master
...
fix doc comments and typos
2015-03-20 10:02:49 -07:00
Mert Kahyaoğlu
0c1eca7dfc
fix doc comments and typos
2015-03-20 18:21:29 +02:00
Mihai Parparita
fea7bc5968
Use full chain of member expressions when generating display names.
...
Assumed to be namespaced names (with the exception of "exports", which is
special-cased).
2015-03-19 16:46:55 -07:00
Ben Alpert
7fe5a3aadd
Merge pull request #3442 from spicyj/kill-initializeTouchEvents
...
Kill React.initializeTouchEvents for good
2015-03-19 14:15:26 -07:00
Ben Alpert
41e5518135
Merge pull request #3464 from martomi/html-tags
...
Examples - Fix a closing html paragraph tag.
2015-03-19 13:09:09 -07:00
Martin Mihaylov
d7bf64396a
Fix the closing html paragraph tag.
2015-03-19 20:56:49 +01:00
Joseph Savona
f707f74c8a
Merge pull request #3463 from josephsavona/relay-components
...
Building The Facebook News Feed With Relay
2015-03-19 12:56:21 -07:00
Joseph Savona
85e7598ef1
Building with Relay blog post
2015-03-19 12:53:49 -07:00
Ben Alpert
1a102a2ed8
Merge pull request #3456 from cody/html-jsx
...
Fix HTML to JSX converter to work with https
2015-03-19 12:45:41 -07:00
Stefan Dombrowski
89b17330ac
Fix HTML to JSX converter to work with https
2015-03-19 00:33:14 +01:00
Christoph Pojer
d86790f4b6
Merge pull request #3441 from cpojer/rm-perf
...
Remove perf folder
2015-03-18 12:28:55 -07:00
Ben Alpert
a321247ee5
More lint fixes
2015-03-17 14:17:03 -07:00
Ben Alpert
26664315a6
Merge pull request #3438 from spicyj/lint
...
Lint fixes
2015-03-17 14:14:57 -07:00
Christoph Pojer
0098168b60
Merge pull request #3439 from cpojer/dom-node-warn
...
Add warning for getDOMNode calls.
2015-03-17 14:14:16 -07:00
Ben Alpert
9c4c2f58ea
Kill React.initializeTouchEvents for good
...
Now that #1169 is fixed, the only thing this is used for is to determine whether `onTouchTap` causes touch listeners to be added. The only internal uses of TapEventPlugin are where touch events are already initialized (so this doesn't make a difference) and we don't support `onTouchTap` as part of the public API so this should be safe.
2015-03-17 14:12:26 -07:00
cpojer
fb23276178
Add warning for getDOMNode calls.
2015-03-17 14:08:04 -07:00
cpojer
7291942550
Remove perf folder
2015-03-17 13:40:11 -07:00
Ben Alpert
e791fccf58
Use console.error to show stack trace in console
...
Better version of #3277 .
Test Plan: jest, grunt test
2015-03-17 13:39:04 -07:00
Ben Alpert
c34fa7f3d2
Lint fixes
2015-03-17 13:30:15 -07:00
Ben Alpert
9a6fa5eb7d
Merge pull request #3430 from fourcolors/patch-1
...
fix grammar in comments
2015-03-17 11:08:40 -07:00
Ben Alpert
5d9b228e03
Merge pull request #3433 from mihaip/master
...
Include the owner name when warning about createElement(null/undefined).
2015-03-16 22:21:33 -07:00
Mihai Parparita
60a101eced
Include the owner name when warning about createElement(null/undefined).
...
Makes it easier to find the callsite that needs to be fixed.
2015-03-16 22:05:29 -07:00
Sebastian Markbåge
dc9dcdba86
Merge pull request #3431 from sebmarkbage/ignoreowner
...
Don't use owner to determine statefulness
2015-03-16 18:08:21 -07:00
Sebastian Markbage
50cbdbc9ab
Don't use owner to determine statefulness
...
This reverts an early commit that made it so that elements from two
different owner in the same slot wouldn't share state.
That behavior was helpful, and we did hit a case which was solved by this.
However, this pattern is extremely uncommon. I've yet to even find the
original case, let alone any existing cases in our codebase.
Therefore, we're dropping this to simplify elements and enable new
optimizations.
2015-03-16 18:05:15 -07:00
Paul O’Shannessy
c48ccc5742
0.13 blog post, starter kit
2015-03-16 16:59:22 -07:00
Paul O’Shannessy
77f011f82f
Update Readme for 0.13.1
2015-03-16 16:59:21 -07:00
Paul O’Shannessy
efc88bad76
Changelog for 0.13.1
2015-03-16 16:59:21 -07:00
Jim
87e14c5ef8
Merge pull request #3176 from jsfb/webcomponent-to-vendor-thirdparty
...
Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container
2015-03-16 16:40:22 -07:00
Jim
12059299f3
Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container.
2015-03-16 16:37:05 -07:00
Jim
73f4dc59d8
Merge pull request #3169 from jsfb/mount-into-shadowdom
...
Allow rendering into document fragments. Fixes #840
2015-03-16 16:15:03 -07:00
Paul O’Shannessy
10112672b1
Merge pull request #3395 from Simek/reactComponentExpect-cleanup
...
toBeDOMComponentWithChildCount readability
2015-03-16 16:14:48 -07:00
Sterling Cobb
b59e7e60b5
fix grammer in comments
2015-03-16 17:10:14 -06:00
AoDev
83a2465af9
Add a note about react classe name convention
...
I lost quite some time trying to figure out what was happening. No error in console and nothing showing up.
2015-03-16 23:59:02 +01:00
Paul O’Shannessy
dacd4db1fa
Merge pull request #3427 from zpao/full-page-dom-components
...
Ensure FullPageComponents are treated as DOM components
2015-03-16 15:39:40 -07:00
Paul O’Shannessy
99cbaed836
Ensure FullPageComponents are treated as DOM components
...
We currently override a couple DOM components. We need to ensure everything we
override is still treated as a DOM component, even if it has a composite
component wrapper.
2015-03-16 15:18:39 -07:00
Paul O’Shannessy
93e67a0a5b
Merge pull request #3425 from zpao/fix-pure-test
...
Fix PureRender test to use providesModule
2015-03-16 15:14:26 -07:00
Ben Alpert
0a312bba89
Merge pull request #3414 from spicyj/gh-3407
...
Fix up Perf a bit better for 0.13
2015-03-16 14:04:28 -07:00
Paul O’Shannessy
bb0fc28fac
Fix PureRender test to use providesModule
2015-03-16 13:56:43 -07:00
Paul O’Shannessy
b0a59a643a
Merge pull request #3381 from zpao/jsx-nonstrictmodule
...
Fix module option parsing of jsx command
2015-03-16 13:24:35 -07:00
Paul O’Shannessy
4c9a07aad4
Merge pull request #3419 from xmo-odoo/patch-1
...
Link to inserting raw HTML document
2015-03-16 13:22:33 -07:00
Jim
f3f1294589
Merge pull request #2842 from Acubed/master
...
Generate XML-compatible void tags and boolean attributes
2015-03-16 12:49:59 -07:00
Jim
fb2999076c
Merge pull request #3422 from jviereck/doc-typo-fix
...
Fix small typo ("of" instead of "or")
2015-03-16 11:03:06 -07:00
Julian Viereck
c6108afdc7
Fix small typo
2015-03-16 18:27:04 +01:00
Paul O’Shannessy
a9e787665d
Merge pull request #3413 from zpao/travis
...
Fix TravisCI fast bail check
2015-03-16 09:28:45 -07:00
xmo-odoo
f0c7b0c8ed
Link to inserting raw HTML document
2015-03-16 10:51:20 +01:00
Austin Wright
29416f422e
Appease eslint
2015-03-14 14:08:18 -07:00
Austin Wright
b52bb22342
Move list of newline-eating tags to variable
2015-03-14 13:57:15 -07:00
Austin Wright
030a7b34c7
Add back \n-to-be-eaten for the plain-text elements
...
The comment hack to enable polyglot HTML isn't cross-browser, or simply doesn't work.
2015-03-14 13:53:12 -07:00
Austin Wright
8e714f9898
Update tests to use Polyglot profile of HTML
2015-03-14 13:53:12 -07:00
Austin Wright
e913e85e1a
Use a Polyglot HTML-safe method of escaping leading newline in rawtext elements
2015-03-14 13:53:12 -07:00
Austin Wright
8bc828aa7c
Generate XML-compatible tags and boolean attributes
2015-03-14 13:53:12 -07:00
Ben Alpert
98671fda1a
Fix up Perf a bit better for 0.13
...
_mountImageIntoNode moved into ReactMount and wasn't being counted where it was supposed to be. In addition, all DOM elements are now wrapped in a composite wrapper but for the perf tools we want to skip over those or else we'll double-count (at least with the current accounting -- and that's effectively what we did before so this brings us back up to parity).
Fixes #3407 .
Test Plan:
Used the jsbin from #3407 and saw similar output from this branch and 0.12:

2015-03-13 18:51:53 -07:00
Paul O’Shannessy
08b1515f7f
Update TravisCI to use exiting env var
...
$TRAVIS_COMMIT_RANGE was broken but it seems what we're doing is worse and
resulting in false negatives.
The result of the bad range was that we weren't running lint or tests for
things we should have been. It actually looks like $TRAVIS_COMMIT has been
wrong and it's not clear why this has been working at all.
2015-03-13 18:39:47 -07:00
Paul O’Shannessy
68a2f89cc6
Merge pull request #3402 from vkramskikh/fix-empty-selects-with-value
...
Fix for empty <select> elements with value
2015-03-13 18:04:57 -07:00
Ben Alpert
ed257cb691
Merge pull request #3412 from spicyj/gh-3329
...
Squash getDOMNode warning from isDOMComponent
2015-03-13 17:55:02 -07:00
Ben Alpert
70985ba68d
Squash getDOMNode warning from isDOMComponent
...
Fixes #3329 .
2015-03-13 17:11:02 -07:00
Ben Alpert
bcd70ad500
Merge pull request #3410 from robertknight/3409-style-null-to-nonnull
...
Fix incorrect update of style when props.style transitions from null to non-null
2015-03-13 17:07:01 -07:00
Robert Knight
ee86942d77
Fix incorrect update of style when props.style transitions from null to non-null
...
ReactDOMComponent maintains a copy of the previous style
object to support in-place mutations of props.style.
This cached object was not cleared when the style
property was removed in a props update.
Fixes #3409
2015-03-13 22:16:19 +00:00
Vitaly Kramskikh
2f52d81865
Fix for empty <select> elements with value
...
There is an exception when value or defaultValue is set but there are no
children as ReactDOMSelect tries to mark the first children as selected
even if there are no children.
2015-03-13 21:48:02 +07:00
Paul O’Shannessy
228c00b813
Merge pull request #3397 from koba04/eslint-ignore-built-files
...
ESLint ignores built files
2015-03-12 18:25:42 -07:00
Toru Kobayashi
ed0e242e07
ESLint ignores built files
2015-03-13 09:58:20 +09:00
Sebastian Markbåge
ca8d7cba1b
Merge pull request #3355 from cpojer/shallowCompare
...
Add shallowCompare module and use it in PureRenderMixin + tests
2015-03-12 17:45:22 -07:00
Bartosz Kaszubowski
4b1d7bcec2
toBeDOMComponentWithChildCount readability
2015-03-13 00:15:32 +01:00
Paul O’Shannessy
d19636295b
Merge pull request #3394 from cody/getDOMNode
...
Fix in docs: getDOMNode --> findDOMNode
2015-03-12 14:12:23 -07:00
Stefan Dombrowski
84e6a392a3
Fix in docs: getDOMNode --> findDOMNode
2015-03-12 22:07:03 +01:00
Ben Alpert
1f72387a47
Merge pull request #3385 from RichardLitt/patch-2
...
Nominalized 'shallow copy'
2015-03-11 16:27:26 -07:00
Richard Littauer
00e89454ec
Nominalized 'shallow copy'
...
I mis-parsed 'shallow copies' as adjective noun, instead of as a compound verb. I've adjusted the text to make it easier to parse on the first read, which should also help ESL learners to be able to parse it easier.
2015-03-11 16:22:24 -07:00
Paul O’Shannessy
78001d3abc
jsx_orphaned_brackets_transformer v1.0.1
2015-03-11 15:52:54 -07:00
Paul O’Shannessy
b459f2ff99
Merge pull request #3384 from syranide/npmjobt
...
Fix jsx_orphaned_brackets_transformer using jstransformer with an older esprima version
2015-03-11 15:51:38 -07:00
syranide
4485f6a439
Fix jsx_orphaned_brackets_transformer using jstransformer with an older esprima version
2015-03-11 23:48:05 +01:00
Ben Alpert
f8672c7270
Fix grammar in warning message
2015-03-11 15:47:04 -07:00
Ben Alpert
d9e06462a3
Merge pull request #3383 from ariabuckles/proptype-warnings
...
[PropTypes] Add warnings if PropTypes return functions
2015-03-11 15:46:17 -07:00
Aria Buckles
206e69c403
[PropTypes] Make invalid proptype warning clearer
...
Addresses comments on #3383 , making the invalid proptype specification
warning clearer and making the tests for it a bit clearer.
2015-03-11 15:36:51 -07:00
Ben Alpert
098f316aff
It\ns -> Its
2015-03-11 15:28:24 -07:00
Paul O’Shannessy
adf4aee1b4
[docs] it's --> its
2015-03-11 15:25:57 -07:00
Aria Buckles
d973e32336
[PropTypes] Add warnings if PropTypes return functions
...
Summary:
Right now, if a component specifies a propType as, for example,
`myProp: React.PropTypes.shape`, without an actual shape
parameter, any prop type will be accepted, because
`React.PropTypes.shape` returns a function (the actual validator),
not an Error, currently indicating that propType checking passed.
This can create an unfortunate situation where a component looks
like it has fully specified `propTypes`, but in fact does not.
This commit addresses this by warning if a propType checker returns
anything non-falsy that is not an Error (currently all the library
PropTypes return null or an Error).
Test Plan:
Added a unit test; ran `jest` in the root repo directory.
Also ran `grunt lint` and `grunt test`
2015-03-11 15:09:18 -07:00
Paul O’Shannessy
c4a2e4d414
Fix module option parsing of jsx command
2015-03-11 14:26:51 -07:00
Jay Jaeho Lee
58f6958128
Revise Korean translation - final
2015-03-12 01:57:44 +09:00
Jim
3d8b47bbcc
Merge pull request #3356 from cpojer/findDOMNode
...
foo.getDOMNode => React.findDOMNode(foo)
2015-03-11 08:47:56 -07:00
Jinwoo Oh
dd3734094c
Update Translation to 91b4564
2015-03-12 00:37:35 +09:00
Ted Kim
7dfbf73004
ref-08-reconciliation (based on 941cba6)
2015-03-12 00:37:35 +09:00
Jinwoo Oh
7dc818a95a
Translate 06 to Korean
...
- Up to 8326a9f
2015-03-12 00:37:34 +09:00
Shim Won
f2fbb31ace
Apply review
...
- Up to 60e96ed
2015-03-12 00:37:02 +09:00
Jinwoo Oh
2bc8a36ab9
Translate 11 to Korean
...
- Up to 83e4409
2015-03-12 00:37:02 +09:00
Shim Won
ec91b4184f
Translate 10.1 to Korean
...
- Up to 678ec31
2015-03-12 00:37:02 +09:00
Seoh Char
4aeb306064
translation of 05-reusable-components-ko-KR.md
2015-03-12 00:37:02 +09:00
Shim Won
87fb9caca7
Update Translation to b95ad29
2015-03-12 00:37:01 +09:00
Shim Won
bf6d9811e7
Translate 10.2 to Korean
...
- Up to b7a548c
2015-03-12 00:36:50 +09:00
Jinwoo Oh
5579a86ac3
Translate 08.1 to Korean
...
- Up to b7a548c
2015-03-12 00:36:50 +09:00
Shim Won
c0ac76d723
Translate 10.7 to Korean
...
- Up to 0bf88f2
2015-03-12 00:36:50 +09:00
Shim Won
c24e5926b9
Translate 10.3 to Korean
...
- Up to 5ab7fde
2015-03-12 00:36:50 +09:00
Jinwoo Oh
48d2f31a6d
Translate conferences to Korean
...
- Up to 1b86246
2015-03-12 00:36:50 +09:00
Shim Won
8838a6d9f9
Translate 10.5 to Korean
...
- Up to 60e96ed
2015-03-12 00:36:25 +09:00
Shim Won
74adeb3611
Translate 10.8 to Korean
...
- Up to ab512af
2015-03-12 00:36:25 +09:00
Shim Won
d3ad46a461
Translate 10.4 to Korean
...
- Up to 2e232f8
2015-03-12 00:36:25 +09:00
Jinwoo Oh
89b23c0c20
Translate 08 to Korean
...
- Up to b7a548c
2015-03-12 00:36:25 +09:00
Jim
5afa657d77
Merge pull request #3370 from varunrau/master
...
Fixed shallowEqual for arguments that are not objects
2015-03-11 08:34:49 -07:00
Shim Won
710668e7f1
Update Translation to 673874d
2015-03-12 00:33:40 +09:00
Shim Won
4ce0e00767
Unify words
2015-03-12 00:33:40 +09:00
Jay Jaeho Lee
3abeb52e6f
Revise Korean translations
2015-03-12 00:33:40 +09:00
Shim Won
35293b5229
Translate 09 to Korean
...
- Up to 2de44cf
2015-03-12 00:33:40 +09:00
Shim Won
a04597eaa1
Translate 02.2 to Korean
...
- Up to fc91d2f
2015-03-12 00:33:40 +09:00
Shim Won
7e73efefd8
Fix links
2015-03-12 00:33:40 +09:00
Shim Won
fe1a2e48f9
Update think-in-react.ko-KR
...
- Up to 5ab7fde
2015-03-12 00:33:39 +09:00
Shim Won
f1d74bef9c
Translate 10 to Korean
...
- Up to a911513
2015-03-12 00:33:39 +09:00
Shim Won
fe8cd0c442
Translate 02.3 to Korean
...
- Up to 6f44f60
2015-03-12 00:33:39 +09:00
Shim Won
84ebb42596
Update content
...
- Up to 5ab7fde
2015-03-12 00:33:39 +09:00
Shim Won
aae74da792
Translate 02.1 to Korean
...
- Up to 513433b
2015-03-12 00:33:39 +09:00
Shim Won
fb2f6c6747
Update docs to v0.13.0-beta.2
...
- Up to 5126cee
2015-03-12 00:33:39 +09:00
Jinwoo Oh
ac466b71d8
Translate tutorial to Korean
...
- Up to a19966f
2015-03-12 00:33:39 +09:00
Shim Won
547baf82b5
Translate ref 07 to Korean
...
- Up to 6f44f60
2015-03-12 00:33:39 +09:00
Shim Won
f7f48bda28
Translate ref 06 to Korean
...
- Up to 4c7cd13
2015-03-12 00:33:38 +09:00
Shim Won
65b8bcce6f
Translate ref 05 to Korean
...
- Up to c0e33e8
2015-03-12 00:33:38 +09:00
Shim Won
ade720d4d9
Translate ref 04 to Korean
...
- Up to a4c96d6
2015-03-12 00:33:38 +09:00
Lee Jaeyoung
9e601b8c05
translate 10.6-update.ko-KR.md
...
apply comments
apply comments
apply comments
2015-03-12 00:33:38 +09:00
Shim Won
ae4fbff308
Translate 07 to Korean
...
- Up to bb52715
2015-03-12 00:33:38 +09:00
Shim Won
c344ef1b79
Translate flux-docs to Korean
...
- Up to 6c19040
2015-03-12 00:33:38 +09:00
Shim Won
7eabccc214
Translate 04 to Korean
...
- Up to e4352ef
2015-03-12 00:33:38 +09:00
Jinwoo Oh
8387f3bbc4
Translate getting-started to Korean
...
- Up to b3cd299
2015-03-12 00:33:38 +09:00
Taeho Kim
a4f9c67dbb
Create ref-09-glossary.ko-KR.md
2015-03-12 00:33:38 +09:00
Taeho Kim
87d6c59ebf
Create ref-03-component-specs.ko-KR.md
...
Based on 08c5e42649
2015-03-12 00:33:38 +09:00
Taeho Kim
8b109e54f1
Create ref-02-component-api.ko-KR.md
2015-03-12 00:33:37 +09:00
Taeho Kim
72f631b994
Create ref-01-top-level-api.ko-KR.md
...
Based on 4f50071de0
2015-03-12 00:33:37 +09:00
Lee Jaeyoung
cb50a48788
translate thinking-in-react.ko
2015-03-12 00:33:37 +09:00
Lee Jaeyoung
4466b0336d
translate complementary-tools
2015-03-12 00:33:37 +09:00
Jay Jaeho Lee
e8fa815391
translated docs/docs/02-displaying-data.md into Korean
...
Up to b25e2e70d8
2015-03-12 00:33:37 +09:00
Shim Won
6686029267
Fix some words, Translate title
...
- Up to 9f18ccd
2015-03-12 00:33:37 +09:00
Shim Won
f0afc7809a
Translate 03 to Korean
...
- Up to 9f18ccd
2015-03-12 00:33:37 +09:00
Lee Jaeyoung
ed1d7fc513
translate videos.md
2015-03-12 00:33:37 +09:00
Lee Jaeyoung
8cef7910a7
translate examples.md
2015-03-12 00:33:36 +09:00
Jay Jaeho Lee
4d4f322c60
Add docs/docs 01
2015-03-12 00:33:36 +09:00
Varun Rau
6cd004f20a
Fixed shallowEqual implementation to handle the case when inputs are not objects.
...
If either argument is not an object and unequal, then shallowEqual should return false.
If only one argument is an object, then shallowEqual should return false.
Fixes #3369
2015-03-10 18:03:51 -07:00
cpojer
413e96d0cd
Add some important getDOMNode tests back.
2015-03-10 17:27:19 -07:00
cpojer
ae7da3aadd
foo.getDOMNode => React.findDOMNode(foo)
2015-03-10 17:17:21 -07:00
Jim
91b45641b8
Merge pull request #3317 from ianobermiller/fix-shallow-equal
...
shallowEqual: bail if either argument is falsey
2015-03-10 15:45:03 -07:00
Ben Alpert
53f92bf858
Fix comma splice and line length
2015-03-10 15:36:27 -07:00
Jim
645a6caaf5
Merge pull request #3323 from jonhester/ie8-compat-mode
...
warn if IE8 is in compatibility mode
2015-03-10 15:35:09 -07:00
Ben Alpert
462e8f1be8
Merge pull request #3327 from Simek/initialize-variables-fix
...
initialize dev variables in dev mode only in shouldUpdateReactComponent.js
2015-03-10 15:33:29 -07:00
Ben Alpert
cff3f35bf7
Merge pull request #3321 from Smert/master
...
Bringing the code to one style.
2015-03-10 15:32:43 -07:00
Ben Alpert
4d9561d938
Merge pull request #3310 from darcyadams/console-exists-before-warn
...
Check that console exists before warning
2015-03-10 15:32:32 -07:00
Ben Alpert
b95fe57743
Merge pull request #3253 from jsfb/fix-comment-to-reflect-class-type-usage
...
Fix comment to reflect the new (non-deprecated) way of accessing a class type.
2015-03-10 15:31:50 -07:00
Ben Alpert
e8af59cf82
Merge pull request #3246 from spicyj/onclick
...
Revert "Revert #1536 "
2015-03-10 15:31:38 -07:00
Ben Alpert
68ca057bc3
Merge pull request #3230 from nmn/master
...
Add numeric CSS property - stroke width
2015-03-10 15:31:30 -07:00
Ben Anderson
75a8bc96b1
Warn when rendering directly into document.body
...
This is in response to #3207 to address concerns regarding third-party
scripts and browser plugins potentially altering DOM nodes within
document.body, causing problems with reconciliation.
Closes #3211 .
2015-03-10 15:31:02 -07:00
Ben Alpert
f77de57e41
Merge pull request #2946 from benmoss/nested-render-warning
...
Add displayName to nested render warnings [#1726 ]
2015-03-10 15:24:59 -07:00
Ben Alpert
4feed4fcc5
Merge pull request #2868 from chicoxyzzy/dev_and_prod_environments_consistancy
...
make dev and production environment consistent
2015-03-10 15:24:33 -07:00
Ben Alpert
9cb25b3ddb
Merge pull request #2266 from syranide/voidelem
...
ReactDOMComponent should not accept children for void elements
2015-03-10 15:24:00 -07:00
Paul O’Shannessy
715aadd1c7
v0.13 starter kit
2015-03-10 15:08:26 -07:00
Paul O’Shannessy
e313616be7
Bump version so we can get back to work
2015-03-10 15:06:35 -07:00
Paul O’Shannessy
e17b6c0514
Bump version in readme
2015-03-10 15:05:43 -07:00
Ben Alpert
df18770a0c
with the exception for -> with the exception of
2015-03-10 14:44:44 -07:00
Ben Alpert
ab7084f71d
Merge pull request #3366 from sebmarkbage/docs2
...
ES6 Class Docs
2015-03-10 14:44:23 -07:00
Sebastian Markbage
efebdb2925
ES6 Class Docs
...
Some minor burried docs.
2015-03-10 14:41:42 -07:00
Ben Alpert
085bf8635c
Add deprecation note to blog post and changelog
2015-03-10 14:22:03 -07:00
Paul O’Shannessy
5f791be022
[docs] Update acknowledgements
...
Missed updating this in #3283 before merging.
2015-03-10 13:57:44 -07:00
Paul O’Shannessy
139012cd6a
Merge pull request #3283 from zpao/0.13-authors
...
Update AUTHORS for 0.13
2015-03-10 13:56:52 -07:00
Paul O’Shannessy
a95d6ff0df
Update AUTHORS for 0.13
2015-03-10 13:55:55 -07:00
Paul O’Shannessy
5e79bd5c4f
Changelog for 0.13
2015-03-10 13:47:15 -07:00
Paul O’Shannessy
deeb55b6e7
Merge pull request #3363 from zpao/0.13-docs-cloneelement
...
[docs] React.cloneElement
2015-03-10 13:46:12 -07:00
Paul O’Shannessy
a5bdc92990
A couple small changes to the changelog for 0.13
2015-03-10 13:43:15 -07:00
Jim
565e2ecbac
Merge pull request #3364 from jsfb/refs-docs
...
Added docs about the ref-as-callback.
2015-03-10 13:02:18 -07:00
Jim
f3811e68fa
Added docs about the ref-as-callback.
2015-03-10 13:01:07 -07:00
Ben Alpert
4fb9644823
0.13 blog post
2015-03-10 12:57:50 -07:00
Paul O’Shannessy
62d5d646db
Merge pull request #3362 from jsfb/docs-for-setstate
...
Added docs about the first-parameter-is-function version of setState.
2015-03-10 12:29:25 -07:00
Paul O’Shannessy
969d92a411
Merge pull request #3354 from zpao/0.13-examples
...
Update the examples for 0.13
2015-03-10 11:57:35 -07:00
Paul O’Shannessy
ce66a796ee
Update the examples for 0.13
...
The only substantial difference here is that I made the harmony example use ES6
classes. The server rendering example was pretty wacky and hard to run but
I did confirm that it works.
2015-03-10 11:56:25 -07:00
Jim
7569e810e7
Added docs about the first-parameter-is-function version of setState.
2015-03-10 11:47:00 -07:00
Paul O’Shannessy
45cc5006d7
[docs] React.cloneElement
2015-03-10 11:19:11 -07:00
Paul O’Shannessy
ee019d6cc5
Merge pull request #3360 from zpao/0.13-docs-api-deprecations
...
Add deprecation note for deprecated component APIs
2015-03-10 11:07:47 -07:00
Paul O’Shannessy
b4962eff43
Merge pull request #3361 from zpao/deprecate-replaceprops
...
Deprecate replaceProps
2015-03-10 11:07:34 -07:00
Paul O’Shannessy
9d58e9a27b
Deprecate replaceProps
...
This isn't supported on plain JS classes anyway, so this is just adding
a warning in DEV before the code throws.
2015-03-10 10:44:47 -07:00
Paul O’Shannessy
b038943653
Add deprecation note for deprecated component APIs
2015-03-10 10:44:24 -07:00
Ben Alpert
79a34e80b1
Merge pull request #3358 from coliff/patch-1
...
Update relevant URLS to HTTPS
2015-03-10 10:03:59 -07:00
Paul O’Shannessy
f41904cf99
Merge pull request #2963 from graue/document-shallow-testing
...
Add documentation for shallow testing
2015-03-10 09:39:47 -07:00
Ben Alpert
ca08f7546e
Merge pull request #3353 from spicyj/frag
...
Add docs for createFragment
2015-03-10 09:17:51 -07:00
Ben Alpert
b7732ba7c0
Add docs for createFragment
2015-03-10 09:17:34 -07:00
Christian
dbba47d5d2
Update relevant URLS to HTTPS
...
Update relevant URLS to HTTPS
2015-03-10 18:11:29 +09:00
Paul O’Shannessy
dd6b8ab8b9
Merge pull request #3347 from koba04/fix-perf-displayname
...
Fix addons.Perf displayName with ES6 classes
2015-03-09 21:32:24 -07:00
cpojer
a1631bea71
Add shallowCompare module and use it in PureRenderMixin + tests
2015-03-09 18:49:37 -07:00
Toru Kobayashi
29506cec54
Fix Perf displayName with ES6 classes
2015-03-10 09:45:40 +09:00
Paul O’Shannessy
62ee384d7b
Merge pull request #3330 from spicyj/no-render
...
Add warning when using non-component element types
2015-03-09 13:47:39 -07:00
Paul O’Shannessy
eaed4d7804
Merge pull request #3345 from zertosh/update-derequire
...
Update derequire (and greatly improve build speed)
2015-03-09 13:46:49 -07:00
Paul O’Shannessy
769e1cea03
Merge pull request #3337 from facebook/cpojer-patch-2
...
"Better" duck typing in reactComponentExpect
2015-03-09 13:45:50 -07:00
Paul O’Shannessy
8a3dd040a0
Merge pull request #3331 from zpao/null-frag-proptypes
...
Allow null and undefined values in non-frag object passed to PropTypes.node
2015-03-09 13:43:26 -07:00
Paul O’Shannessy
57bed796ef
Merge pull request #3339 from gabelevi/patch-1
...
Update jstransform and esprima-fb dependencies
2015-03-09 13:19:41 -07:00
Jim
ccb5ccd5a0
Merge pull request #3341 from rickbeerendonk/3338-documentation-issue
...
Add documentation about JSX and displayName.
2015-03-09 10:35:28 -07:00
Andres Suarez
9941095dc3
Update to derequire@^2.0.0
2015-03-08 23:43:47 -04:00
Ben Alpert
208b258519
Merge pull request #3343 from BinaryMuse/docs/bkt-add-contextmenu-event
...
Add onContextMenu to events doc
2015-03-07 20:27:57 -08:00
BinaryMuse
1aa9580484
Add onContextMenu to events doc
2015-03-07 20:22:10 -08:00
Rick Beerendonk
2184162e38
Add documentation about JSX and displayName.
...
The section that described how JSX transform handles displayName was lost in commit 9b1ee4de46
Fixes #3338
2015-03-07 19:01:58 +01:00
Gabe Levi
ac5af1ec45
Update jstransform and esprima-fb dependencies
2015-03-06 18:31:29 -05:00
Ben Alpert
b95ad296da
Merge pull request #3336 from facebook/cpojer-patch-1
...
Fix documentation typo in ReactComponent
2015-03-06 10:07:45 -08:00
Christoph Pojer
8ce9e2b194
Update reactComponentExpect.js
2015-03-06 02:46:33 -08:00
Christoph Pojer
419038f846
Fix documentation typo in ReactComponent
2015-03-06 01:33:56 -08:00
Paul O’Shannessy
0e797dffe4
Allow null and undefined values in non-frag object passed to PropTypes.node
2015-03-05 17:56:50 -08:00
Jim
c7c2e05c33
Merge pull request #2802 from jsfb/findDOMNode-in-docs
...
Updated docs examples/recommendations to use findDOMNode instead of getDOMNode
2015-03-05 16:51:13 -08:00
Jim
030fc752ba
Updated docs examples/recommendations to use findDOMNode instead of getDOMNode
2015-03-05 16:42:43 -08:00
Ben Alpert
6dbef56da3
Merge pull request #3333 from ariabuckles/docs
...
[Docs] Add 'ing' to make "opening" and "closing" line up
2015-03-05 16:28:04 -08:00
Aria Buckles
7eb6f68e7c
[Docs] Add 'ing' to make "opening" and "closing" line up
...
Test Plan:
None
2015-03-05 16:25:41 -08:00
Ben Alpert
6b7e4dc8e8
Add warning when using non-component element types
...
This should make debugging easier for people who missed callsites when fixing up their JSX/non-JSX usage.
2015-03-05 15:24:31 -08:00
Bartosz Kaszubowski
a42dcf4f7b
initialize dev variables in dev mode only
2015-03-05 21:20:48 +01:00
Jon Hester
65c4aeaa3a
use warning module instead of console.debug
2015-03-05 18:53:12 +00:00
Darcy
6b593083ed
check that console exists before warning
...
Console is undefined in earlier versions of IE when it is not open. This causes an uncaught exception, and breaks applications in these versions of IE when attempting to warn when the console is closed.
Admittedly, console will usually be open when testing in development, but still React should not break the application when it is not.
2015-03-05 09:20:16 -05:00
Jon Hester
a999ac1ac3
warn if IE8 is in compatibility mode
2015-03-05 13:48:28 +00:00
dmitry
adb9b20f6d
Bringing the code to one style.
2015-03-05 14:04:47 +02:00
Ian Obermiller
34f4a0e42d
shallowEqual: bail if either argument is falsey
...
Also add some unit tests.
2015-03-04 22:16:51 -08:00
Paul O’Shannessy
fa8961118a
Merge pull request #3294 from zpao/jsxcompiler-linenumbers
...
[docs] show line numbers in online jsx compiler
2015-03-04 18:45:18 -08:00
Paul O’Shannessy
bda845cf4c
[docs] Fox Ryan's name: #3311
2015-03-04 12:32:41 -08:00
Christopher Chedeau
4485903d40
Update round-up 25
...
(cherry picked from commit 40336d8144 )
2015-03-04 12:32:37 -08:00
Christopher Chedeau
af400ab17b
Merge pull request #3304 from facebook/matthewjohnston4-croundup-1
...
Community Roundup #25 blog post
2015-03-04 09:06:38 -08:00
Jim
71675bb400
Merge pull request #3305 from brafdlog/patch-1
...
There was a redundant word in the sentence
2015-03-03 14:04:05 -08:00
Paul O’Shannessy
811057aae2
Facebook, not FaceBook
2015-03-03 12:49:02 -08:00
Paul O’Shannessy
a3642d3995
v0.13 rc blog post
2015-03-03 12:42:57 -08:00
brafdlog
457c8e397d
There was a redundant word in the sentence
2015-03-03 22:03:53 +02:00
Paul O’Shannessy
2d46d589a1
v0.13.0-rc2 starter kit
2015-03-03 11:46:01 -08:00
Paul O’Shannessy
21b41480a5
v0.13.0-rc2
2015-03-03 11:46:01 -08:00
Paul O’Shannessy
71e583844b
Update bower release task
...
This makes it so we only delete some files during the buld process. We were
losing the LICENSE and PATENTS files.
2015-03-03 11:46:01 -08:00
Paul O’Shannessy
e8ffb80586
[lint] fix errors from new test
2015-03-03 11:23:45 -08:00
Paul O’Shannessy
e114988a2c
Sync out another jsx transform test.
...
We added this test internally and it never got added here. We haven't broken it
with any transforms *yet* but it's still good to actually run all of our tests
here too.
2015-03-03 10:40:07 -08:00
Matthew Johnston
a850603e1c
Update 2015-03-03-community-roundup-25.md
2015-03-03 18:34:07 +00:00
Paul O’Shannessy
2e2d79758d
Merge pull request #3264 from zpao/transform-jsx
...
XJS -> JSX
2015-03-03 10:33:08 -08:00
Matthew Johnston
2417b7f4de
Update 2015-03-03-community-roundup-25.md
2015-03-03 18:31:45 +00:00
Matthew Johnston
49d5722467
Update 2015-03-03-community-roundup-25.md
2015-03-03 17:56:53 +00:00
Matthew Johnston
e99ef894b8
Community Roundup #25 blog post
2015-03-03 14:20:41 +00:00
Paul O’Shannessy
272ae10b48
Merge pull request #3299 from sebmarkbage/fixwarningformats
...
Always use a static message formats
2015-03-02 13:19:01 -08:00
Sebastian Markbage
a27c6d1690
Always use a static message formats
...
These are the only places that seems to be including environment specific
variables in the message format.
By ensuring that they're static, we make it easier to group logs by
format. I also ensure that I keep each addendum separate so that they can
be filtered/grouped separately.
2015-03-02 13:18:38 -08:00
Paul O’Shannessy
4bad1aacb6
Merge pull request #3275 from spicyj/gh-3222
...
Don't use undefined as parent name in key warning
2015-03-02 12:47:52 -08:00
Paul O’Shannessy
8fdf4bbffc
Merge pull request #3276 from spicyj/gh-2978
...
Add regression test for scry order
2015-03-02 12:46:55 -08:00
Sebastian Markbåge
ecc4ad569a
Merge pull request #3266 from sebmarkbage/cloneelement
...
Add cloneElement Implementation
2015-03-02 12:15:20 -08:00
Sebastian Markbåge
edddd57d28
Merge pull request #3293 from spicyj/gh-3286
...
ReactFragment counts as a node without warning
2015-03-02 12:10:50 -08:00
Jim
f2c7d9ac81
Merge pull request #3284 from delftswa2014/bugfix/blog/https-urls
...
Fixed the http url in the blog pages
2015-03-02 11:20:10 -08:00
PNikray
3516f33ffd
Modified the todo example.
...
Instead of only using the index to supress the warning it now uses the
text + index to also ensure object iteration order.
2015-03-02 19:49:42 +01:00
Paul O’Shannessy
57bd8fe3bb
Merge pull request #3295 from koba04/patch-1
...
Add a code format in 2015-02-24-react-v0.13-rc1.md
2015-03-01 20:48:25 -08:00
Toru Kobayashi
1744977201
Add a code format in 2015-02-24-react-v0.13-rc1.md
2015-03-02 09:33:36 +09:00
Paul O’Shannessy
b2161bd51d
[docs] show line numbers in online jsx compiler
2015-03-01 11:53:06 -08:00
Ben Alpert
7ebf7c46f5
ReactFragment counts as a node without warning
...
Fixes #3286 .
2015-03-01 11:50:07 -08:00
Paul O’Shannessy
dc92fa480a
Upgrade package dependencies for new esprima/jstransform
2015-03-01 11:25:16 -08:00
Ben Alpert
7346ce5c0b
Merge pull request #3288 from apaatsio/remove-unnecessary-variable-in-test
...
Remove unnecessary variable from test
2015-02-28 13:31:50 -08:00
Antti Ahti
323789540a
Remove unnecessary variable from test
2015-02-28 15:23:34 +02:00
Paul O’Shannessy
48e54da484
XJS -> JSX
...
Part 1: change all of our methods and AST node types.
Part 2: Rename files so there is no trace of XJS
2015-02-27 18:23:18 -08:00
Ben Alpert
673874dc87
Merge pull request #3263 from wmertens/patch-1
...
beta1 blog entry: Fix CoffeeScript example
2015-02-27 15:28:22 -08:00
PNikray
0e355fc8c4
Fixed the url in community-roundup-9
...
using http resulted in an error, changing it to https fixes it
2015-02-27 23:43:50 +01:00
PNikray
77ec7da124
Fixed the url in community-roundup-5
...
using http resulted in an error, changing it to https fixes it
2015-02-27 23:42:14 +01:00
PNikray
94fa077a76
Changed the url of the video in community-round-up-4
...
The url was using http instead of https, which results in an error.
2015-02-27 23:39:17 +01:00
Ben Alpert
de1f8682d5
Add note about enter/leave bubbling
...
Fixes #2826 .
2015-02-26 16:29:18 -08:00
Ben Alpert
feae9ad0a8
Add regression test for scry order
...
Fixes #2978 .
2015-02-26 15:54:50 -08:00
Ben Alpert
d5fa14de1a
Don't use undefined as parent name in key warning
...
Fixes #3222 .
2015-02-26 15:20:37 -08:00
Sebastian Markbåge
1c697ab141
Merge pull request #3265 from sebmarkbage/shouldupdaterefs
...
Avoid passing `this` of a static object
2015-02-26 13:33:35 -08:00
PNikray
9c7f9b8de5
Added the key attribute into the todo example
...
This is to solve the warning (that the key should be set) that was being raised when adding a new item.
2015-02-26 19:37:05 +01:00
Sebastian Markbage
4adcee69a0
Add cloneElement Implementation
...
This is a new version of cloneWithProps but this one is moving out of
add-ons. Unlike cloneWithProps, this one doesn't have special logic for
style, className and children.
This one also preserves the original ref. This is critical when upgrading
from a mutative pattern where a child might have a ref on it.
It also preserves context, which is similar to how context would work when
it is parent based. It also ensures that we're compatible with the old
mutative pattern which makes updates easier.
2015-02-26 01:17:05 -08:00
Andreas Svensson
20dd247292
ReactDOMComponent should warn when provided children for void elements
2015-02-26 10:14:47 +01:00
Sebastian Markbage
061c6fc13c
Avoid passing this of a static object
...
Refactoring artifact.
2015-02-25 18:37:02 -08:00
Ben Alpert
618bbdc531
Merge pull request #3239 from rralian/update/docs-clarify-forceUpdate
...
Docs: clarifies forceUpdate method
2015-02-25 17:35:07 -08:00
Wout Mertens
ce7190537f
beta1 blog entry: Fix CoffeeScript example
...
Fix the constructor call and make code more idiomatic.
2015-02-26 00:26:16 +01:00
Paul O’Shannessy
84ddd9deaf
Merge pull request #3257 from danmane/update-tutorial-md
...
Add mention of go and php server implementations in React tutorial
2015-02-25 12:46:17 -08:00
Daniel Mané
a7ae40e90d
Add mention of go and php server implementations in React tutorial
2015-02-24 15:10:11 -08:00
Paul O’Shannessy
63146e1f16
v0.13 RC blog post
...
Note: we need to manually specify date in these files so that the sort order is
correct (2 posts on the same day). Otherwise it will just be ABC order, which
is wrong.
Closes : #3256
2015-02-24 14:05:57 -08:00
Paul O’Shannessy
7269422825
Fix typo
...
(cherry picked from commit 4d90b9bdf3 )
2015-02-24 12:49:19 -08:00
Paul O’Shannessy
888daccf9f
Merge pull request #3255 from chenglou/fix-blog-post
...
[Blog] Fix post code snippet display
2015-02-24 12:39:28 -08:00
Cheng Lou
99d23a54bc
[Blog] Fix post code snippet display
...
I think nokogiri (is that what we use?) accidentally escaped this
snippet. Simply putting spaces between braces fixes it.
2015-02-24 15:22:25 -05:00
Paul O’Shannessy
2f20091520
Merge pull request #3250 from sebmarkbage/blogpost
...
Add Blog Post about ReactElement Changes in 0.13
2015-02-24 11:26:55 -08:00
Jim
29f6c7e774
Fix comment to reflect the new (non-deprecated) way of accessing a class type.
2015-02-24 11:18:17 -08:00
Sebastian Markbage
cd47798c59
Add Blog Post about ReactElement Changes in 0.13
...
Explains some of the rationale for the new warnings added in 0.13.
2015-02-24 10:54:03 -08:00
Paul O’Shannessy
44d91295cb
Merge pull request #3251 from Simek/empty-docs-prevnext-fix
...
do not show empty "docs-prevnext" div on single page
2015-02-24 09:24:23 -08:00
Bartosz Kaszubowski
f785dd09ea
do not show empty "docs-prevnext" div on single page
...
to remove additional necessary spacing between content and footer
2015-02-24 16:28:47 +01:00
Ben Alpert
1943a9a0db
Only call put/deleteListener with truthy listeners
...
Without this, transitioning from `<div onClick={null} />` to `<div />` triggered `willDeleteListener` to delete the `click` handler which caused problems; now, we only call `putListener` and `deleteListener` when we have an actual listener.
I now also clean up the `onClickListeners` map upon deletion and don't double-listen when updating the event listener.
2015-02-23 14:52:30 -08:00
Ben Alpert
090e4bbc9a
Revert "Revert #1536 "
...
Formerly "Attach empty onclick listener to each node". This reverts commit 431155d2e2 .
2015-02-23 14:28:22 -08:00
Bob Ralian
8d29520dc7
clarifies forceUpdate method
2015-02-23 10:34:41 -06:00
Paul O’Shannessy
95206fe5dc
Make cloneWithProps typechecks static-only
2015-02-22 14:40:39 -08:00
Paul O’Shannessy
a30e25467d
v0.13.0-rc1 starter kit
2015-02-22 13:32:25 -08:00
Paul O’Shannessy
06126ad3f4
v0.13.0-rc1
2015-02-22 13:26:13 -08:00
Paul O’Shannessy
4f26cc1414
Update dependencies
2015-02-22 13:26:13 -08:00
Paul O’Shannessy
d83fa6a6bf
Merge pull request #3224 from Simek/patch-2
...
wider Twitter timeline on support page
2015-02-22 13:10:43 -08:00
Paul O’Shannessy
fe16c8292c
Merge pull request #3232 from artnez/master
...
Add vendor/inline-source-map.js to package.json
2015-02-22 13:01:05 -08:00
Paul O’Shannessy
029e64bb56
Merge pull request #3233 from artnez/es6-call-spread
...
Add support for jstransform es6-call-spread
2015-02-22 12:57:25 -08:00
Artem Nezvigin
0bc4aafb74
Add support for jstransform es6-call-spread
2015-02-22 11:57:06 -08:00
Artem Nezvigin
d7791a7cbb
Add vendor/inline-source-map.js to package.json
2015-02-22 11:11:48 -08:00
Naman Goel
34d5e05199
Merge branch 'master' of https://github.com/facebook/react
...
* 'master' of https://github.com/facebook/react: (30 commits)
Expose --target flag on jsx executable
Contributing: cleanup quote style
Add Relay blog post
Fix long lines in vendor/fbtransform/visitors
lint vendor/*.js
fix .eslintignore
remove ballmer example
Fix a doc. cloneWithProps clones a ReactElement.
lint from root
Fixed mistake in jsdocs types for cloneWithProps
Put deprecation warning for classSet
Lint vendor/fbtransform as well
More warnings to ReactFragment.create
Warn when using constructor function directly
Move option parsing into react-tools proper.
Remove lodash devDependency
Added the immutability talk to the React.js Conf update.
Use same pathways for browser transforms as we use in react-tools
lint: remove spaces from array brackets
lint: remove spaces from object braces
...
2015-02-22 15:57:34 +01:00
Naman Goel
20d3f0db29
CSS property
2015-02-22 15:57:30 +01:00
chico
9185323959
make dev and production environment consistent
2015-02-22 14:58:42 +03:00
Bartosz Kaszubowski
087cd7b27a
wider Twitter timeline on support page
2015-02-21 23:20:09 +01:00
Paul O’Shannessy
5ab7fdecfe
Merge pull request #2994 from chenglou/docs-classset
...
[Docs] Add note on classSet deprecation
2015-02-20 17:00:36 -08:00
Paul O’Shannessy
4046b92487
Merge pull request #2847 from zpao/jsx-es5
...
Expose --target=esversion flag on jsx executable
2015-02-20 15:19:37 -08:00
Paul O’Shannessy
d40be68d2c
Expose --target flag on jsx executable
...
Valid values are 'es3' and 'es5'.
es3: perform reserved words quoting, don't use defineProperty
es5: default, don't do the above, class methods non-enumerable
2015-02-20 13:37:42 -08:00
Paul O’Shannessy
821383165f
Merge pull request #3212 from denis-sokolov/patch-1
...
Contributing: cleanup quote style
2015-02-20 08:20:18 -08:00
Denis Sokolov
ae3e85d9e4
Contributing: cleanup quote style
...
The line above it recommends `'` over `"`, and yet the line in question uses `"`.
2015-02-20 12:06:33 +02:00
Greg Hurrell
531add88c4
Add Relay blog post
...
closes #3174
2015-02-19 21:27:45 -08:00
Paul O’Shannessy
85baea4404
Merge pull request #3209 from chicoxyzzy/eslint-everywhere
...
lint from root
2015-02-19 20:59:44 -08:00
Paul O’Shannessy
362e9595c4
Fix long lines in vendor/fbtransform/visitors
...
I meant to do this with #3206 but forgot to add them.
2015-02-19 18:43:06 -08:00
Paul O’Shannessy
a3ee6a9548
Merge pull request #2993 from chenglou/classset-ded
...
Put deprecation warning for classSet
2015-02-19 18:36:36 -08:00
Jim
8326a9f11e
Merge pull request #2921 from hanski07/updateTransferringPropsDocs
...
Update transferring props docs
2015-02-19 17:52:02 -08:00
chico
90ce7f67d7
lint vendor/*.js
2015-02-20 04:37:45 +03:00
chico
ed6d02e1a8
fix .eslintignore
2015-02-20 04:31:21 +03:00
Jim
8913a07ada
Merge pull request #3161 from koba04/fix-clone-with-props-document
...
Fix a doc. cloneWithProps clones a ReactElement.
2015-02-19 17:14:53 -08:00
chico
1876bc2432
remove ballmer example
2015-02-20 04:13:07 +03:00
Toru Kobayashi
60e96edce2
Fix a doc. cloneWithProps clones a ReactElement.
2015-02-20 10:08:46 +09:00
chico
466f4faf4e
lint from root
2015-02-20 04:06:15 +03:00
Jim
d69329a17c
Merge pull request #3208 from jsfb/clonewithprops-jsdocs
...
Fixed mistake in jsdocs types for cloneWithProps
2015-02-19 17:02:28 -08:00
Jim
bad85fafa1
Fixed mistake in jsdocs types for cloneWithProps
2015-02-19 16:38:25 -08:00
Cheng Lou
835316bc13
Put deprecation warning for classSet
...
Also removes the one test that used the module.
2015-02-19 19:31:54 -05:00
Paul O’Shannessy
c889f409bf
Merge pull request #3191 from zpao/jsxtransformer-use-shared-code
...
Use same pathways for browser transforms as we use in react-tools
2015-02-19 16:09:41 -08:00
Paul O’Shannessy
cb3e797236
Merge pull request #3206 from zpao/lint-fbtransform
...
Lint vendor/fbtransform as well
2015-02-19 16:06:38 -08:00
Paul O’Shannessy
e60db7316f
Merge pull request #3198 from zpao/jsx-option-parsing
...
Move option parsing into react-tools proper.
2015-02-19 15:54:11 -08:00
Paul O’Shannessy
0f85884fa4
Merge pull request #3201 from zpao/non-factory-invariant
...
Warn when using constructor function directly
2015-02-19 15:53:50 -08:00
Sebastian Markbåge
977204991b
Merge pull request #3205 from sebmarkbage/warningfixes
...
More warnings to ReactFragment.create
2015-02-19 15:43:18 -08:00
Paul O’Shannessy
e830cea050
Lint vendor/fbtransform as well
2015-02-19 15:26:27 -08:00
Sebastian Markbage
5a2c80382c
More warnings to ReactFragment.create
...
Apparently I could've used these too because if you accept an arbitrary
node, then these could end up being objects, but those objects might
also be arrays or elements.
2015-02-19 15:11:49 -08:00
Paul O’Shannessy
02d225f26e
Merge pull request #3193 from fisherwebdev/remove_lodash
...
Remove lodash devDependency
2015-02-19 14:22:34 -08:00
Paul O’Shannessy
ad31cfa4dc
Warn when using constructor function directly
...
We no longer support the legacy factory style of calling component constructors
directly. We only support createElement or the wrapping of classes with
createFactory. Instead of letting this fail in a gross way as we try to run,
add a nice warning that shows up before the gross TypeError.
2015-02-19 13:57:48 -08:00
Jim
a2f77208e6
Merge pull request #3180 from cody/https
...
Using https URLs for embedded fiddles
2015-02-19 13:18:34 -08:00
Paul O’Shannessy
21a9e8b6e8
Merge pull request #3189 from hzoo/more-lint
...
More lint - remove spaces in object braces / array brackets
2015-02-19 11:42:02 -08:00
Paul O’Shannessy
629d400774
Merge pull request #3165 from oiva/jquery-mobile-example
...
Change how components are rendered in jQuery Mobile example. Fixes #2880
2015-02-19 10:48:26 -08:00
Paul O’Shannessy
112f7aa249
Move option parsing into react-tools proper.
...
We were doing some preprocessing for module options in the command line. Since
we also expose the same API via react-tools (and JSXTransformer), we need to do
the same processing from the API. So just move it all to the same place.
2015-02-19 09:46:25 -08:00
fisherwebdev
10d336d4eb
Remove lodash devDependency
2015-02-18 22:41:58 -08:00
Steven Luscher
f1288d1055
Added the immutability talk to the React.js Conf update.
...
(cherry picked from commit de8b3eb9d4 )
2015-02-18 21:42:11 -08:00
Paul O’Shannessy
0e0a8f65c5
Use same pathways for browser transforms as we use in react-tools
...
This makes sure we can use the same options everywhere, even from react-rails,
without having to specify each one separately in JSXTransformer as well.
2015-02-18 21:40:16 -08:00
Henry Zhu
eba5d1365c
lint: remove spaces from array brackets
2015-02-19 00:13:36 -05:00
Henry Zhu
07cfd66028
lint: remove spaces from object braces
2015-02-19 00:10:31 -05:00
Timothy Yung
b0789c9582
Merge pull request #3187 from yungsters/shallow
...
Support unmounting in ReactShallowRenderer
2015-02-18 17:47:12 -08:00
yungsters
e9e33b984f
Support unmounting in ReactShallowRenderer
...
Reviewers: @sebmarkbage, @zpao
Test Plan:
```
$ npm test ReactTestUtils
```
2015-02-18 17:45:42 -08:00
Paul Harper
a18c7549df
Modify sample CSS so that it works in Safari
...
When animating the max-height property in Safari, entering the leave state would trigger an animation to `max-height: 0`. Then when the active state kicked in, it would jump and didn't really look right. Moving the `transition` css property to the active version fixed the issue for me and worked on Safari, Chrome and Firefox. Unfortunately I'm not in a position to test in IE at the moment, but I'll do that at my first convenience tomorrow.
2015-02-18 17:26:54 -08:00
Paul O’Shannessy
6c29eba035
Merge pull request #2821 from zpao/unitless-css-boxflex
...
Add boxFlex and boxFlexGroup to CSS Unitless Properties
2015-02-18 17:22:56 -08:00
Stefan Dombrowski
8ba3ba49d2
Using https for embedded fiddles
...
Official announcement from jsfiddle:
https://twitter.com/jsfiddle/status/565041134435852289
2015-02-18 23:07:48 +01:00
Paul O’Shannessy
6f7b9a97bf
Merge pull request #3108 from zpao/quadratic-example
...
Replace Ballmer Peak example with Quadratic Formula
2015-02-18 14:02:17 -08:00
Paul O’Shannessy
1caeda30ea
Replace Ballmer Peak example with Quadratic Formula
2015-02-18 13:59:26 -08:00
Steven Luscher
85a6462062
Added special edition round-up for React.js Conf 2015
...
(cherry picked from commit 233980826c )
2015-02-18 13:30:26 -08:00
Sebastian Markbåge
5499321d63
Merge pull request #3183 from yungsters/master
...
Support rendering to null in ShallowComponentRenderer
2015-02-18 11:43:07 -08:00
yungsters
e952869ff8
Support rendering to null in ShallowComponentRenderer
...
Reviewers: @sema, @zpao
Test Plan:
```
$ npm jest
```
2015-02-18 11:31:02 -08:00
Sebastian Markbåge
00a3b9233f
Merge pull request #3177 from sebmarkbage/fixbindwarningstring
...
Forgotten string
2015-02-17 18:26:32 -08:00
Sebastian Markbage
377319b863
Forgotten string
...
We forgot this `%s` as this was converted.
2015-02-17 18:26:12 -08:00
Sebastian Markbåge
c61207588d
Merge pull request #3175 from sebmarkbage/fixhasownorder
...
Avoid reading the property if hasOwnProperty is false
2015-02-17 16:02:18 -08:00
Sebastian Markbage
67cf95c16d
Avoid reading the property if hasOwnProperty is false
...
Easy with an Object.assign polyfill
2015-02-17 15:59:01 -08:00
Sebastian Markbåge
de3ecabd6c
Merge pull request #3148 from hmarr/fix-nan-mutation-warning
...
Prevent NaN props from triggering warnings
2015-02-17 15:41:18 -08:00
Sebastian Markbåge
cf4bef8bd7
Merge pull request #3171 from sebmarkbage/moarwarnings
...
Moar Warnings
2015-02-17 15:09:33 -08:00
Oiva Eskola
4c32fb487e
Wrap jQuery Mobile example's components with React.createFactory to fix on v0.13.0. Fixes #2880
2015-02-18 00:13:13 +02:00
Jim
f6920ba377
Merge pull request #3170 from adelevie/patch-1
...
Make tutorial CDN URLs use https
2015-02-17 11:50:54 -08:00
Sebastian Markbage
2490289c4a
Warn if getDOMNode or isMounted is accessed in render
...
This is an anti-pattern that can be easily avoided by putting the logic
in componentDidMount and componentDidUpdate instead.
It creates a dependency on stale data inside render without enforcing
a two-pass render.
2015-02-17 11:49:20 -08:00
Alan deLevie
4980bcb0f3
Make tutorial CDN URLs use https
2015-02-17 14:34:01 -05:00
Jim
93f6fc9eeb
Allow rendering into document fragments. Fixes #840
2015-02-17 11:24:03 -08:00
Sebastian Markbage
91194126d8
Warn if using Maps as children
...
We're not sure if this is the way we want to support this API. It creates
two ways of doing things.
It is convenient to avoid needing to explicitly redefine the key of Maps.
However, this use case isn't as common as having an iterable where the
key is on the value, not the key.
2015-02-17 11:23:12 -08:00
Paul O’Shannessy
a8d9bff3ca
Merge pull request #3168 from briankung/docs-jsx-namespacing
...
[Docs] Clarify section on namespaced components
2015-02-17 11:10:33 -08:00
Paul O’Shannessy
9e2da7a0ae
Merge pull request #3164 from oiva/master
...
Fix sourcemap filenames when using transformWithDetails. Fixes #3140
2015-02-17 11:07:19 -08:00
Sebastian Markbage
3587460675
Warn if accessing .type on a factory
...
This was an important convenience as an upgrade path but shouldn't be
necessary if you're using best-practice of calling createFactory in the
consuming component.
2015-02-17 11:06:54 -08:00
Paul O’Shannessy
68a8e4491f
Merge pull request #3147 from hzoo/lint-fixes
...
lint whitespace , trailing comma
2015-02-17 10:58:42 -08:00
Paul O’Shannessy
6cd7ab5254
Merge pull request #3154 from iamdustan/patch-1
...
s/upate/update
2015-02-17 10:55:42 -08:00
Brian Kung
26e0b1a298
[Docs] Clarify section on namespaced components
...
While going through the docs, I wasn't sure if the first example was
something I should do or not. This makes the wording a bit more clear.
2015-02-17 06:40:48 -06:00
Ben Alpert
6d97c708a9
Merge pull request #3167 from MichelleTodd/docs-grammar
...
[Docs] Reword section on React without JSX
2015-02-16 17:26:23 -08:00
Michelle Todd
17f2c26139
[Docs] Reword section on React without JSX
...
Summary:
This section was confusing. I reworded it from:
"JSX is completely optional. You don't have to use JSX with React.
You can create these trees through `React.createElement`. The first
argument is the tag, pass a properties object as the second
argument and children to the third argument."
to:
"JSX is completely optional; you don't have to use JSX with React.
You can create React elements in plain JavaScript using
`React.createElement`, which takes a tag name or component, a
properties object, and variable number of optional child
arguments."
and additionally added another child element to the example code.
Test Plan:
Read the new paragraph!
2015-02-16 17:12:19 -08:00
Ben Alpert
6b03975395
Make Simulate.mouseEnter/Leave use direct dispatch
...
Fixes #1297 .
onMouseEnter and onMouseLeave shouldn't *actually* use direct dispatch, but doing so is more useful than doing nothing (and I don't think it precludes adding proper enter/leave dispatching later, either).
Test Plan:
grunt test
2015-02-16 16:12:19 -08:00
Ben Alpert
6729acf370
Merge pull request #3162 from vsiao/mount-element
...
Fix ReactMount._renderNewRootComponent signature
2015-02-16 16:05:08 -08:00
Oiva Eskola
35e24759f1
fix sourcemap filenames when using transformWithDetails. Fixes #3140
2015-02-16 22:21:51 +02:00
Vincent Siao
96e4e3cbbc
Fix ReactMount._renderNewRootComponent signature (ReactComponent -> ReactElement)
2015-02-15 19:25:18 -08:00
Dustan Kasten
dc21dca50e
s/upate/update
2015-02-14 22:09:31 -05:00
Henry Zhu
cb49492f88
lint whitespace
...
- use spaces
- remove space before paren in function
- remove space before colon in object
2015-02-14 11:12:18 -05:00
Harry Marr
198aabaafb
Prevent NaN props from triggering warnings
...
Previously, `checkAndWarnForMutatedProps` would flag `NaN` props as
having been mutated, because `NaN !== NaN`. This prevents that warning
from being emitted by explicitly checking for `NaN`s.
2015-02-14 10:06:55 +00:00
Henry Zhu
74726f0af5
remove space before round brace in function expressions
2015-02-13 23:41:53 -05:00
Henry Zhu
e2a57920da
lint whitespace , trailing comma
2015-02-13 23:13:47 -05:00
Paul O’Shannessy
5126cee0f5
v0.13.0-beta.2
2015-02-13 18:28:03 -08:00
Paul O’Shannessy
432e378687
Remove references to vendor_deprecated
2015-02-13 18:27:22 -08:00
Paul O’Shannessy
ad01f21469
Merge pull request #3145 from jsfb/dedup-is-owner-important
...
Dedupe owner-is-important warning.
2015-02-13 18:26:49 -08:00
Jim
207b03c56d
Dedupe owner-is-important warning.
2015-02-13 18:05:18 -08:00
Paul O’Shannessy
0b5331c155
Update license for jsx_orphaned_brackets_transformer
2015-02-13 15:45:01 -08:00
Paul O’Shannessy
3751f85260
Merge pull request #3139 from brianpchsu/master
...
Fixed Copyright year for three files and react.js licence to BSD-license
2015-02-13 15:44:03 -08:00
Jeff Morrison
8e803cba23
Merge pull request #3143 from jeffmo/flow_0_3_0
...
Update jsx binary to latest jstransform + latest flow syntax features
2015-02-13 15:37:41 -08:00
jeffmo
332a782d28
Add --es6module and --non-strict-es6module flags to jsx bin
2015-02-13 17:51:35 -05:00
jeffmo
34bb8e85a2
Bump jstransform version to 9.1.0 to include new flow updates
2015-02-13 17:40:52 -05:00
Jim
5512d0d4d0
Merge pull request #3132 from jsfb/warn-less-for-owner-necessary
...
Only monitor components that are likely stateful (inputs and composites)
2015-02-13 13:55:06 -08:00
Brian Hsu
7e609c6903
Fixed Copyright year for three files and react.js licence to BSD-license.
2015-02-13 12:15:49 -08:00
Paul O’Shannessy
2a3f43184a
Merge pull request #3123 from chicoxyzzy/remove-jshint
...
ESLint coverage
2015-02-13 11:39:11 -08:00
Paul O’Shannessy
5714510ea4
Merge pull request #3134 from briankung/update-safe_yaml
...
Fix for the jekyll docs build process
2015-02-13 11:22:47 -08:00
Jim
f18dfdc00d
Only monitor components that are likely stateful (inputs and composites)
2015-02-12 17:22:42 -08:00
chico
862f7d6a41
fix linting
2015-02-13 02:45:50 +03:00
chico
96677d5da5
update eslint rules
2015-02-13 02:44:32 +03:00
chico
e02a303e3e
.eslint in src is not necessary anymore
2015-02-13 02:44:32 +03:00
chico
1511fff598
eslint
2015-02-13 02:43:42 +03:00
Brian Kung
892200ae38
Bumps safe_yaml to 1.0.4 (was 1.0.3) to fix bug
...
safe_yaml 1.0.3 has some issues with Ruby 2.2.0:
https://github.com/dtao/safe_yaml/issues/67
2015-02-12 17:40:57 -06:00
Paul O’Shannessy
fffe135931
Merge pull request #3133 from zpao/more-lint
...
More lint rules, fixes
2015-02-12 15:37:22 -08:00
Paul O’Shannessy
7e5eb4b2b2
Add indent lint rule, fix code
2015-02-12 14:31:55 -08:00
Paul O’Shannessy
52b32d83d0
Remove newline at beginning of file
2015-02-12 14:28:54 -08:00
Paul O’Shannessy
12808e81c1
Fix license header to use BSD
2015-02-12 14:28:32 -08:00
Paul O’Shannessy
af8ad59a5b
Add space-before-blocks rules, fix code
2015-02-12 14:28:01 -08:00
Sebastian Markbåge
a411f3e0dc
Merge pull request #3130 from sebmarkbage/identifiablewarnings
...
Moar warnings with solid prefixes!
2015-02-12 13:47:53 -08:00
Sebastian Markbage
f5038829d8
Moar warnings with solid prefixes!
...
This ensures that we have a prefix that can be easily identified in logs
so that we can filter out warnings based on their prefix.
This also turns the remaining two monitorCodeUse callers into warnings.
We'll probably still use monitorCodeUse until we know if we want to
deprecate but most releases should only have warnings.
2015-02-12 13:37:19 -08:00
Paul O’Shannessy
d2fcdfc7df
Merge pull request #3126 from Sourdoughh/patch-1
...
Update to CLA, CONTRIBUTING.md
2015-02-11 16:46:53 -08:00
Jason Ly
462f3ca245
Update to CLA, CONTRIBUTING.md
2015-02-11 13:56:25 -08:00
Christopher Chedeau
6c549d2899
update image perf
2015-02-11 12:45:58 -08:00
Sebastian Markbåge
032fb6ce11
Merge pull request #3107 from sebmarkbage/fragments
...
Warn if a non-object value is used in ReactFragment.create
2015-02-11 11:58:46 -08:00
Paul O’Shannessy
c07657fde1
Merge pull request #3114 from chicoxyzzy/master
...
rename `Id` suffix to `ID` to apply naming conventions
2015-02-11 11:35:17 -08:00
Paul O’Shannessy
ea29768a2b
Merge pull request #3118 from rkho/patch-1
...
Updated CONTRIBUTING.md: Mention of "facebook.com" was not a link
2015-02-11 11:34:48 -08:00
Christopher Chedeau
83e4409a72
Tweaks on Advanced Performance
2015-02-11 11:14:59 -08:00
Christopher Chedeau
ab512af57f
Advanced Performance Doc
2015-02-11 10:53:57 -08:00
chico
fbe88c7e46
fix Microdata properties' commentaries
2015-02-11 15:50:59 +03:00
Jim
130a164c8d
Merge pull request #3117 from jsfb/use-warning-module
...
Flip console.warn to use warning module.
2015-02-10 17:08:12 -08:00
Jim
4e5543965d
Flip console.warn to use warning module so users can intercept all warnings by shimming the warning module.
...
The two remaining console.warns are:
/Users/jsproch/react/src/test/mock-modules.js:
19 return mocks.generateFromMetadata(mocks.getMetadata(exports));
20 } catch (err) {
21: console.warn(err);
22 return exports;
23 }
/Users/jsproch/react/src/vendor/core/warning.js:
39 var argIndex = 0;
40 var message = 'Warning: ' + format.replace(/%s/g, () => args[argIndex++]);
41: console.warn(message);
42 try {
43 // --- Welcome to debugging React ---
2015-02-10 15:23:24 -08:00
Richard Kho
9c19135c34
Updated CONTRIBUTING.md: Mention of "facebook.com" was not a link
...
Updated the mention of "facebook.com" on line 3 of the CONTRIBUTING.md file to link to Facebook. Previously, this mention was just in plain text.
Changed from `facebook.com` to `[facebook.com](https://facebook.com )`
No other content has been changed. Content has not been removed from this file in any way.
2015-02-10 14:44:23 -08:00
chico
58d705110e
rename Id suffix to ID to apply naming conventions
2015-02-10 21:40:30 +03:00
Paul O’Shannessy
f6f0bab237
Merge pull request #3103 from zpao/lifecyle-warn-not-throw
...
Warn when calling setState & other methods at wrong time
2015-02-10 09:58:34 -08:00
Sebastian Markbage
093ab00085
Warn if a non-object value is used in ReactFragment.create
...
I made this mistake while upgrading a few callers.
I'm leaving this as warning so that it is always safe to wrap any existing
child in React.addons.createFragment without breaking prod.
This makes upgrading easier.
2015-02-10 09:44:14 -08:00
Paul O’Shannessy
01ef83feef
Merge pull request #3105 from matiassingers/jasmine-call-count-consistency
...
Jasmine spies call count property consistency
2015-02-09 18:17:16 -08:00
Matias Singers
b9310a8fa5
Consistently use calls.length instead of callCount for Jasmine spies
2015-02-10 10:11:22 +08:00
Paul O’Shannessy
5967915ec4
Warn when calling setState & other methods at wrong time
...
Currently we use an invariant to prevent this code pattern. That is really
aggressive for something that doesn't actually put React in a bad state. This
diff replaces invariants with warnings and makes those code paths no-ops.
2015-02-09 17:04:13 -08:00
Sebastian Markbåge
7b0ce2c11f
Merge pull request #3100 from sebmarkbage/fragments
...
Dead code
2015-02-09 14:58:21 -08:00
Sebastian Markbage
18c9a6e54a
Dead code
...
Missed this because lint was off
2015-02-09 14:57:07 -08:00
Sebastian Markbåge
0fdd2a74e2
Merge pull request #3030 from sebmarkbage/fragments
...
Make keyed object fragments an opaque type
2015-02-09 14:50:46 -08:00
Paul O’Shannessy
d59a039ebd
Merge pull request #3097 from zpao/upgrade-eslint
...
Upgrade to newer eslint, use esprima-fb
2015-02-09 14:32:28 -08:00
Paul O’Shannessy
1455001caa
Merge pull request #2998 from rickbeerendonk/docs-conferences
...
Add Conferences section to the Community Resources on the website
2015-02-09 14:32:04 -08:00
Paul O’Shannessy
dae1dc6292
Upgrade to newer eslint, use esprima-fb
...
Eslint now allows us to use a different parser, which allows us to use
esprima-fb explicitly. This means we don't have to wait for espree to add
things like rest-param parsing. Though we do need eslint to upgrade its rules
to handle that AST.
I had hoped to enable parsing of our tests but we can't do that until we
change esprima-fb's XJS nodes to JSX.
While I was here, I also enabled the no-unused-vars rule since eslint
understands template strings. I also made the single quote enforcement
actually fail instead of just warn.
2015-02-09 14:27:28 -08:00
Sebastian Markbage
56f51156ba
Make keyed object fragments an opaque type
...
This triggers a warning if you try to pass a keyed object as a child.
You now have to wrap it in React.addons.createFragment(object) which
creates a proxy (in dev) which warns if it is accessed. The purpose of
this is to make these into opaque objects so that nobody relies on its
data structure.
After that we can turn it into a different data structure such as a
ReactFragment node or an iterable of flattened ReactElements.
2015-02-09 14:24:56 -08:00
Rick Beerendonk
1b86246d64
Remove zerowidth space at the beginning of file
2015-02-09 22:17:33 +01:00
Paul O’Shannessy
44634c062a
Merge pull request #3082 from hzoo/patch-1
...
Add React.js Conf Keynote talk (with playlist)
2015-02-09 10:17:37 -08:00
Paul O’Shannessy
358e70cedd
Merge pull request #3089 from iamdanfox/fix-markdown-parsing-error-3075
...
Fix markdown parsing error
2015-02-09 10:12:17 -08:00
Paul O’Shannessy
cb833710af
Merge pull request #2968 from ClimbsRocks/patch-5
...
Reordered 'Using Props' before 'Component Properties'
2015-02-09 10:08:44 -08:00
Paul O’Shannessy
a6a64d1ed4
Merge pull request #2854 from cedrics/add-iframe-component
...
Adds a composite component for an iframe to handle load events
2015-02-09 09:59:01 -08:00
Dan Fox
462ab93d83
Fix markdown parsing error
...
closes #3075
2015-02-08 11:31:48 +00:00
Paul O’Shannessy
60c2f56e6e
Merge pull request #3074 from noyobo/master
...
fix Chinese docs typos
2015-02-06 17:17:46 -08:00
Paul O’Shannessy
7853260788
Merge pull request #3080 from zpao/upgrade-internal-modules
...
Upgrade internal modules
2015-02-06 17:17:00 -08:00
Henry Zhu
bcdf8f2375
Add React.js Conf Keynote talk (with playlist)
2015-02-06 18:31:00 -05:00
Jim
3740c51616
Merge pull request #3078 from vincentriemer/patch-1
...
Fixed pure-render-mixin documentation
2015-02-06 13:33:06 -08:00
Cheng Lou
b6980ab980
[Docs] Add note on classSet deprecation
2015-02-06 16:25:48 -05:00
Jim
c69a9206a4
Merge pull request #3073 from gsklee/patch-3
...
Fix typos in animation.md
2015-02-06 13:14:30 -08:00
Paul O’Shannessy
705353fbaf
Move keyMirror to vendor to match internal move
2015-02-06 12:09:36 -08:00
Vincent Riemer
0bf88f26a4
Corrected pure-render-mixin documentation
...
Fixed the PureRenderMixin documentation which was incorrectly importing the base React library instead of ReactWithAddons.
2015-02-06 14:34:09 -05:00
Paul O’Shannessy
3525d01b9b
Remove more upstream modules that aren't used
...
Immutable* hasn't been used... ever?
copyProperties, merge were deprecated as part of 0.12. We've replaced
them with Object.assign.
2015-02-06 09:54:52 -08:00
noyobo
7f6c575d9d
Chinese docs Typesetting beautification & relate links
2015-02-06 19:44:14 +08:00
noyobo
9296f15682
Chinese docs typo
2015-02-06 17:31:33 +08:00
YouBao Nong
8197bface7
sync up Chinese docs links
2015-02-06 16:26:43 +08:00
YouBao Nong
7cb1b9bdb2
fix next page link typo
...
下一页链接错误
2015-02-06 15:53:45 +08:00
Preston Parry
0903120ad1
Update tutorial.md
2015-02-05 22:57:36 -08:00
G. Kay Lee
678ec31e41
Fix typos
2015-02-06 14:47:56 +08:00
Paul O’Shannessy
8ab0ecba13
Sync internal modules
...
We've actually diverged more with some modules, but we don't want
a cascade of dependencies out here. Mostly, the changes internally that
we don't want are tied to FB infrastructure but otherwise are
functionally equivalent (usually around error reporting, code monitoring).
2015-02-05 16:31:54 -08:00
Sebastian Markbåge
007207bac4
Merge pull request #3068 from sebmarkbage/dedupwarning
...
Warn only once for each class when accessing .type
2015-02-05 15:36:37 -08:00
Nick Williams
5bf8cda58f
document checkbox using click handlers for change events
...
I hit an issue related to this earlier today. Feels like a short paragraph warning of potential issues would be of benefit. Discussed with @zpao on IRC, agreed to make PR.
For more info:
* https://github.com/facebook/react/issues/3005#issuecomment-72513965
* c7e4f55eb0/src/browser/eventPlugins/ChangeEventPlugin.js (L287)
2015-02-05 22:32:23 +00:00
Sebastian Markbage
140d9b4192
Warn only once for each class when accessing .type
...
Currently it is a bit too spammy.
2015-02-05 12:32:15 -08:00
Andreas Svensson
c7e4f55eb0
Merge pull request #3047 from syranide/escbrow2
...
Drop processAttributeNameAndPrefix and invalid attribute name escaping
2015-02-05 20:53:47 +01:00
Paul O’Shannessy
123d218eaf
Merge pull request #3046 from cobbweb/patch-1
...
Add autoFocus to supported HTML attributes
2015-02-05 10:50:38 -08:00
syranide
6af987c524
Drop processAttributeNameAndPrefix and invalid attribute name escaping
2015-02-05 09:43:26 +01:00
Andreas Svensson
04e6d02e40
Merge pull request #1599 from syranide/escbrow
...
Split escapeTextForBrowser into escapeTextContentForBrowser and quoteAttributeValueForBrowser
2015-02-05 09:41:36 +01:00
Andrew Cobby
a4c96d6e9c
Add autoFocus to supported HTML attributes
...
It appears to be supported http://jsfiddle.net/9f48wbsa/1/
2015-02-05 16:45:27 +10:00
Paul O’Shannessy
787200631b
Merge pull request #3045 from milanlandaverde/removes-validation-msg
...
remove extraneous argument to createChainableTypeChecker in ReactPropTypes
2015-02-04 19:36:11 -08:00
Marlon Landaverde
876fdd0190
removes loose validation message
2015-02-04 21:13:59 -06:00
Paul O’Shannessy
7e6c820cd2
Merge pull request #3022 from btholt/master
...
Added itemRef and itemId for complete microdata support.
2015-02-04 16:57:03 -08:00
Paul O’Shannessy
f2cd1a0591
Merge pull request #2969 from gsklee/patch-1
...
Update thinking-in-react.md
2015-02-04 15:22:37 -08:00
Paul O’Shannessy
ac4b64059e
Merge pull request #3013 from akheron/patch-2
...
Document React.addons.TestUtils.isElement()
2015-02-04 15:19:08 -08:00
Sebastian Markbåge
3abfe00ae7
Merge pull request #3039 from sebmarkbage/fixismounted
...
Fix isMounted inside of render
2015-02-04 11:53:07 -08:00
Sebastian Markbage
263800e09b
Fix isMounted inside of render
...
This is apparently used to determine if you can access refs.
Bad pattern, but a pattern nonetheless.
2015-02-04 11:50:04 -08:00
Paul O’Shannessy
99a2ef30ae
Merge pull request #3032 from germ13/patch-1
...
Corrected documentation
2015-02-04 11:46:27 -08:00
Paul O’Shannessy
f77e86834b
Merge pull request #3036 from jergason/master
...
Fix list formatting in glossary
2015-02-04 11:45:05 -08:00
Andreas Svensson
6672a7ec62
Merge pull request #2135 from syranide/ie8enctype
...
IE8 does not have a setter for property "enctype"
2015-02-04 13:47:54 +01:00
Andreas Svensson
8ca058ac4e
Split escapeTextForBrowser into escapeTextContentForBrowser and quoteAttributeValueForBrowser
2015-02-04 13:44:38 +01:00
Jamison Dance
d74d0e3215
Fix list formatting in glossary
2015-02-03 23:34:43 -07:00
juan serrano
3a0534e1b8
Corrected documentation
2015-02-03 18:41:47 -08:00
Lee Byron
9174501771
Merge pull request #2991 from leebyron/state-queue
...
Set state takes a function
2015-02-03 19:52:26 -05:00
Lee Byron
279b956c9b
Set state takes a function
...
This diff enables setState to accept a function in addition to a state partial. If you provide a function, it will be called with the up-to-date `state, props, context` as arguments.
This enables some nicer syntax for complex setState patterns:
If setState is doing an increment and wants to guarantee atomicy, you need a function:
```
this.setState(state => ({ number: state.number + 1 }));
```
This atomicy is particularly important if setState is called multiple times in a single frame of execution as the result of complex user actions. It's a tricky bug to chase down and difficult to determine how to fix when you find it. The current pattern of reaching into _pendingState relies on an implementation detail.
In this example: props.doAction() may result in your ancestor re-rendering and providing you with new props. If setState is called directly with an object literal referencing `this.props`, it will use the *old* version of props, not the new value. Using a function solves for this case:
```
this.props.doAction();
this.setState((state, props) => ({ number: state.number * props.multiplier }));
```
2015-02-03 19:49:17 -05:00
Paul O’Shannessy
3f60a99cd9
Merge pull request #3016 from hnordt/patch-1
...
Removing unnecessary returns
2015-02-03 10:46:21 -08:00
Jeff Morrison
acca4b3993
Merge pull request #3020 from syranide/jsxbracketcodemod
...
Added jsx_orphaned_brackets_transformer for breaking JSX parser change
2015-02-03 09:56:28 -08:00
Héliton Nordt
62213e08df
Fix highlighting
2015-02-03 08:38:16 -02:00
Sebastian Markbåge
c8833daf53
Merge pull request #3026 from sebmarkbage/fixdependency
...
Hot fix cyclic dependency
2015-02-02 23:57:46 -08:00
Sebastian Markbage
e3f95ea293
Hot fix cyclic dependency
...
We accidentally created an unfortunate cyclic dependency because of the
auto-wrapper hack that uses ReactClass.
Making it injected instead.
2015-02-02 23:55:34 -08:00
Sebastian Markbåge
50c38bbc75
Merge pull request #3023 from sebmarkbage/devtoolsfix
...
Expose ReactReconciler
2015-02-02 22:07:28 -08:00
Sebastian Markbåge
1172f636cb
Merge pull request #3025 from sebmarkbage/fixrendercallback
...
Always trigger an update when a callback is enqueued.
2015-02-02 22:07:13 -08:00
Brian Holt
7b92d71744
Changed itemId to itemID and added clarity to the comments of where it is specified.
2015-02-02 21:58:00 -08:00
Sebastian Markbage
2702281a13
Always trigger an update when a callback is enqueued.
...
enqueueCallbackInternal forgot to schedule an update.
We could rely on the implicit contract of enqueueElement to do it. However,
if we're currently outside a transaction, it'll flush synchronously. Before
we enqueue the callback. We could also enqueueCallback before we
enqueueElement, but that causes a fragile relationship between them. E.g.
enqueueElement should not need to schedule an update if it is the same
element.
2015-02-02 20:42:15 -08:00
Sebastian Markbage
e67ff7ee78
Expose ReactReconciler
...
This can be used by devtools to monkey patch the reconciler and therefore
get notified whenever any internal instance is updated.
2015-02-02 18:15:31 -08:00
Brian Holt
ea67a1d436
Added itemRef and itemId for complete microdata support.
2015-02-02 17:17:04 -08:00
Ben Moss
ba55716a2d
Fix warning messages wording and access of displayName
2015-02-02 18:05:31 -05:00
syranide
f3271ad53b
Added jsx_orphaned_brackets_transformer for breaking JSX parser change
2015-02-02 23:24:15 +01:00
Andreas Svensson
63c3461af7
Merge pull request #1864 from syranide/ie8text2
...
Newlines handled incorrectly by innerText in IE8
2015-02-02 21:33:48 +01:00
Andreas Svensson
c371709d23
Newlines handled incorrectly in innerText in IE8
2015-02-02 21:27:27 +01:00
Andreas Svensson
8d6c8a7793
Merge pull request #3017 from syranide/trydefine
...
Try/catch property deprecation warnings to support IE8
2015-02-02 21:26:18 +01:00
Jim
381a01a19b
Merge pull request #3018 from jsfb/assert-not-throw
...
Expecting transform not to throw. Removed meaningless comment.
2015-02-02 12:21:05 -08:00
Jim
b207b8698c
Expecting transform not to throw. Removed meaningless comment.
2015-02-02 12:19:47 -08:00
Andreas Svensson
387adae3de
Merge pull request #3000 from syranide/openbool
...
Set HTML DOM property "open" to HAS_BOOLEAN_VALUE
2015-02-02 21:11:10 +01:00
syranide
0a1cd56ead
Try/catch property deprecation warnings to support IE8
2015-02-02 21:00:04 +01:00
Paul O’Shannessy
6c36b528e2
Merge pull request #2997 from rickbeerendonk/2943-jsx-build-tool-documentation
...
Documents that JSX tool is transforming files with .js extension (and no...
2015-02-02 11:25:32 -08:00
Paul O’Shannessy
f922664e86
Merge pull request #3007 from JoelOtter/patch-2
...
Add note linking to up-to-date doc on Flux website
2015-02-02 11:22:45 -08:00
Sebastian Markbåge
534d23d903
Merge pull request #3012 from sebmarkbage/typescript
...
Use TypeScript Compiler API Directly
2015-02-02 11:21:40 -08:00
Héliton Nordt
8fc4f23cdb
Removing unnecessary returns
2015-02-02 17:20:38 -02:00
Paul O’Shannessy
bab94bf2af
Merge pull request #3011 from koba04/fix-coponent-api-doc
...
Fix consistency of component api document
2015-02-02 11:18:10 -08:00
Paul O’Shannessy
8b1cd7509d
Merge pull request #3001 from rgarcia/patch-1
...
remove extraneous comma in tutorial
2015-02-02 11:16:28 -08:00
Paul O’Shannessy
2aeb8a2a6b
Merge pull request #2995 from rickbeerendonk/copyright-2015
...
Update copyright headers for 2015
2015-02-02 11:15:30 -08:00
Paul O’Shannessy
e04bdd8c9b
Merge pull request #2999 from sedovsek/master
...
Changed unit to pixels due to inconsistent font-size rendering of code elements.
2015-02-02 11:05:35 -08:00
Petri Lehtinen
2e232f83bc
Document React.addons.TestUtils.isElement()
2015-02-02 10:22:52 +02:00
Sebastian Markbage
f6fd4a8506
Use TypeScript Compiler API Directly
...
In 1.4.0 we can use the TypeScript API directly to preprocess our files.
This lets us get rid of a dependency.
https://github.com/Microsoft/TypeScript/wiki/Using-the-Compiler-API
We can also use this to provide our default libraries so that we don't
need to keep the references in the test file.
2015-02-01 22:41:00 -08:00
Toru Kobayashi
b7860b7da4
Fix consistency of component api document
2015-02-02 09:52:08 +09:00
Joel Auterson
344d07d7de
Add note linking to up-to-date doc on Flux website
2015-02-01 15:26:29 +00:00
Rafael
246fdebf82
remove extraneous comma in tutorial
2015-01-31 12:31:14 -10:00
syranide
aa9edc2a9c
Set HTML DOM property "open" to HAS_BOOLEAN_VALUE
2015-01-31 23:11:08 +01:00
Robert Sedovsek
ea94ec8c0e
Changed unit to pixels due to inconsitent font-size rendering of code elements.
2015-01-31 22:53:21 +01:00
Rick Beerendonk
f1bd869350
Add Conferences section to the Community Resources on the website
2015-01-31 22:46:03 +01:00
Rick Beerendonk
2de44cf668
Documents that JSX tool is transforming files with .js extension (and not .jsx) by default
2015-01-31 20:59:18 +01:00
Rick Beerendonk
3e0750a4ad
Update copyright headers for 2015
2015-01-31 20:18:25 +01:00
Andreas Svensson
905bfcec60
Merge pull request #1912 from syranide/safereuse
...
Warn if mounting into node with dirty rendered markup
2015-01-31 19:56:34 +01:00
Andreas Svensson
c460ad660b
Warn if mounting into node with dirty rendered markup
2015-01-31 19:36:12 +01:00
Andreas Svensson
a170629128
Merge pull request #1568 from syranide/dompurge
...
Only purgeID on ReactDOMComponent and ReactDOMTextComponent unmount
2015-01-31 18:21:22 +01:00
Lee Byron
508b625313
Merge pull request #2990 from jeffkole/patch-1
...
Documents that `classSet` concatenates its arguments
2015-01-30 21:45:54 -05:00
Jeff Kolesky
b7530e19eb
Documents that classSet concatenates its arguments
...
Just wanted it to be noted that `classSet` operates in two ways, both of which are valuable.
2015-01-30 16:47:44 -08:00
syranide
a7f0fb7c4f
Only purgeID on ReactDOMComponent and ReactDOMTextComponent unmount
2015-01-30 21:32:58 +01:00
Paul O’Shannessy
9f9d833065
Merge pull request #2987 from jsfb/fix-markdown-output-wrap
...
Fixed linewrap issue on markdown output css. Fixes #2986
2015-01-30 12:22:44 -08:00
Jim
2ea00ea772
Fixed linewrap issue on markdown output css. Fixes #2986
2015-01-30 12:19:18 -08:00
Jim
ddb1c7470e
Merge pull request #2960 from jsfb/add-detectable-prefix-to-reactelement-warning
...
Add detectable prefix to ReactElement proptype warning.
2015-01-30 12:14:33 -08:00
Paul O’Shannessy
bab59cd090
Pull in 0.13 beta blog post from 0.12-stable branch
2015-01-30 11:49:40 -08:00
Jim
b2f77e6de3
Add detectable prefix to ReactElement proptype warning.
2015-01-30 11:43:57 -08:00
G. Kay Lee
140627b1b2
Update thinking-in-react.md
...
Make style consistent with `tutorial.md`
2015-01-28 16:59:03 +08:00
Paul O’Shannessy
5bd078508a
v0.13.0-beta.1
2015-01-27 21:13:35 -08:00
Paul O’Shannessy
bd56b731de
Merge pull request #2967 from zpao/jest-match-internal
...
[jest] Use persistModuleRegistryBetweenSpecs
2015-01-27 20:54:19 -08:00
Paul O’Shannessy
657e30771a
Merge pull request #2966 from zpao/grunt-jest
...
Run jest with grunt, add to travis
2015-01-27 20:51:39 -08:00
Paul O’Shannessy
e2d3370aa9
Merge pull request #2964 from zertosh/no-derequire-when-minifying
...
Remove "derequire" from minified bundles
2015-01-27 20:51:08 -08:00
Preston Parry
5776dc7918
Update tutorial.md
2015-01-27 20:27:16 -08:00
Paul O’Shannessy
14d88d4e38
[jest] Use persistModuleRegistryBetweenSpecs
...
This more closely matches how we have jest configured at FB, so when we
pull in and run internally we will have fewer things to waste time on.
2015-01-27 19:17:31 -08:00
Paul O’Shannessy
49eb84efdd
Run jest with grunt, add to travis
...
This is to make sure we don't end up with differences in our different
testing methods. We may switch out the failure allowances later (maybe
just jest will be good enough and we can let phantom fail for a little
bit).
2015-01-27 18:04:58 -08:00
Scott Feeney
76f5453cc7
Mention shallow rendering's limitations
...
Also, move it to the bottom of the test utils documentation and mention that it's experimental.
2015-01-27 17:09:16 -08:00
Paul O’Shannessy
dbdeb078ce
[testing] dump the cache when depending on warning messages
...
It's possible to configure Jest to not dump the module cache between
specs. This makes it tricky when we silence warnings one a 2nd call.
In this case, the same message was getting logged so when we expected
the count of warning calls to increment, it didn't.
2015-01-27 16:02:00 -08:00
Jim
2ea1f51fe8
Merge pull request #2965 from ClimbsRocks/patch-4
...
Docs wording tweak: subject verb agreement
2015-01-27 14:45:15 -08:00
Preston Parry
e4352efc21
Update 04-multiple-components.md
2015-01-27 14:34:35 -08:00
Andres Suarez
5c5fc5e316
Remove "derequire" from minified bundles
2015-01-27 16:53:18 -05:00
Scott Feeney
f6804d2504
Add documentation for shallow testing
...
See #2393 for the original issue, and #2497 for the implementation.
2015-01-27 13:44:20 -08:00
Paul O’Shannessy
9801f2d8ab
Merge pull request #2940 from kevinold/2749-consistent-use-of-spys-or-mocks
...
update to use spyOn for console.warn #2749
2015-01-27 13:38:56 -08:00
Ben Alpert
513433b370
Merge pull request #2962 from ClimbsRocks/patch-3
...
Docs wording tweak for clarity
2015-01-27 11:59:00 -08:00
Ben Alpert
8174262135
Merge pull request #2961 from ClimbsRocks/patch-1
...
Rewording for clarity
2015-01-27 11:58:36 -08:00
Preston Parry
33ecec07cb
Update 02.1-jsx-in-depth.md
2015-01-27 11:22:21 -08:00
Preston Parry
cadbe1d27e
Rewording for clarity
2015-01-27 11:04:21 -08:00
Sebastian Markbåge
8bbaa95a49
Merge pull request #2948 from jergason/master
...
do not validate propTypes in production
2015-01-27 10:55:14 -08:00
Sebastian Markbåge
61c4497d58
Merge pull request #2959 from sebmarkbage/createmixin
...
We don't currently have a way to trace the origin of a mixin
2015-01-27 10:39:25 -08:00
Sebastian Markbåge
b3f96d97f9
Merge pull request #2957 from sebmarkbage/renamecomponent
...
Rename ReactComponentBase -> ReactComponent
2015-01-27 10:39:07 -08:00
Sebastian Markbage
295ef0063b
We don't currently have a way to trace the origin of a mixin
...
This makes it more difficult to find bugs in mixins both dynamically
and using a static type system.
We also don't have a way to find these to be upgraded to a new mixin
syntax if we needed to.
This hook is currently an optional noop but could be made required to
create a mixin class.
2015-01-27 09:36:14 -08:00
Sebastian Markbage
c3c98084b9
Rename ReactComponentBase -> ReactComponent
...
We freed up this internal name by removing the internal base class.
We're now free to use this name as it was intended.
ReactDOMComponent and ReactCompositeComponent are still confusing as
they're internal but we'll rename them later.
2015-01-27 09:22:07 -08:00
Jamison Dance
f61ca8d307
don't validate propTypes in production
...
Switch to warnings so code execution doesn't differ between prod and
dev.
2015-01-27 09:45:20 -07:00
Sebastian Markbåge
16a56afada
Merge pull request #2936 from sebmarkbage/refactorlifecycles
...
Use Singleton LifeCycle State
2015-01-27 01:26:30 -08:00
Sebastian Markbage
bebc568ceb
Use Singleton LifeCycle State
...
All entry points are for reconciliation are within batching strategies.
Since we don't have any batching strategies with synchronous updates,
there can't be more than one life-cycle method on the stack at any given
time.
Therefore, it's safe to move the composite life cycle flag to a singleton.
This saves us some memory management.
I think that we can get rid of these life cycle states completely in the
future.
2015-01-27 01:19:31 -08:00
Sebastian Markbåge
7e6251887f
Merge pull request #2935 from sebmarkbage/batchupdates
...
Batch updates in initial render
2015-01-27 01:06:56 -08:00
Sebastian Markbage
9811b10aaa
Batch updates in initial render
...
Currently, the first setState that happens during initial render will
start a new batch. Any subsequent updates will be batched. That means that
the first setState is synchronous but any subsequent setStates are
asynchronous.
This commit makes it so that the batching starts at the root. That way all
the setStates that happen within life-cycle methods are asynchronous.
2015-01-27 01:00:59 -08:00
Sebastian Markbåge
b3df7cabb7
Merge pull request #2930 from sebmarkbage/updatequeue
...
Extract setState, setProps etc into ReactUpdateQueue
2015-01-27 00:57:44 -08:00
Sebastian Markbage
ed7332c749
Extract setState, setProps etc into ReactUpdateQueue
...
I originally did this work so that we could allow setState to be called
before the internal ReactCompositeComponent was constructed. It's unlikely
that we'll go down that route now but this still seems like a better
abstraction. It communicates that this is not immediately updating an
object oriented class. It's just a queue which a minor optimization.
It also avoids bloating the ReactCompositeComponent file.
Since they both depend on the life cycle I break that out into a common
shared dependency. In a follow up I'll refactor the life-cycle management.
2015-01-27 00:55:25 -08:00
Sebastian Markbage
103bf101ae
Fix broken jest test
...
jest accidentally picked up this .d.ts file as a test.
I'll just move it out to fix it.
2015-01-26 23:37:30 -08:00
Sebastian Markbåge
9b23807cfd
Merge pull request #2953 from sebmarkbage/callbacktests
...
Add Tests to Callbacks of the Life Cycles
2015-01-26 23:30:14 -08:00
Sebastian Markbage
fd077d7492
Add Tests to Callbacks of the Life Cycles
...
This adds some much needed tests of the callbacks to setState, setProps
and render.
2015-01-26 23:26:24 -08:00
Jim
61ee74b562
Merge pull request #2941 from kevinold/2870-update-warning-calls
...
Update warning calls to use %s #2870
2015-01-26 22:06:42 -08:00
Kevin Old
f0ea2b5979
update to use spyOn for console.warn #2749
2015-01-26 21:51:42 -06:00
Kevin Old
e8ef06783a
Update warning calls to use %s #2870
2015-01-26 21:39:43 -06:00
Paul O’Shannessy
c6d1904f24
Merge pull request #2951 from mzabriskie/semicolon
...
Provide warning when using styles containing a semicolon
2015-01-26 18:32:57 -08:00
Jim
c3522b80a5
Merge pull request #2920 from jsfb/move-proptype-validation
...
Move propType validation to element instead of class.
2015-01-26 17:21:01 -08:00
Sebastian Markbåge
46ae2f4e55
Merge pull request #2952 from sebmarkbage/typescript
...
Add Basic TypeScript Class Test
2015-01-26 17:19:18 -08:00
Jim
6ee5299b4a
Move propType validation to element instead of class.
...
Conflicts:
src/classic/element/ReactElementValidator.js
2015-01-26 17:16:49 -08:00
Sebastian Markbage
f837cc289e
Move component class instantiation into ReactCompositeComponent
...
We need to move instantiation into the mount phase for context purposes.
To do this I moved the shallow rendering stuff into ReactTestUtils and
reused more of the existing code for it by instantiating a noop child.
Everywhere we refer to the "type" we should pass it to ReactNativeComponent
to resolve any string value into the underlying composite.
2015-01-26 17:16:21 -08:00
mzabriskie
ae5a124745
Using %s in warning message
2015-01-26 18:09:21 -07:00
mzabriskie
fca0fdc115
Better tests
2015-01-26 18:08:51 -07:00
Sebastian Markbage
6c145c31f5
Add Basic TypeScript Class Test
...
As part of the new class effort it is now possible to define React
Components using any type of generic JavaScript class syntax.
This includes TypeScript classes. This test ensures that we don't regress
that support, and also serves as an example for using React in TypeScript.
TypeScript provides a good demo of where we think property initializers
are going.
We don't have any official *type* support for TypeScript yet.
This test trails the ReactES6Class-test file. Some manual tweaking is
required when converting tests.
2015-01-26 16:59:11 -08:00
mzabriskie
b6edbae3fc
Renaming assertValidStyle to warnValidStyle
2015-01-26 17:50:35 -07:00
mzabriskie
94fb463c06
Moar tests
2015-01-26 17:45:51 -07:00
mzabriskie
05e2bc6b5c
Fixing lint failures
2015-01-26 17:41:54 -07:00
mzabriskie
4054bb13cd
Provide warning when using styles containing a semicolon
2015-01-26 17:33:44 -07:00
Paul O’Shannessy
96058a10ee
Merge pull request #2939 from patlaughlin/patch-1
...
Update 06-transferring-props.md
2015-01-26 16:32:09 -08:00
Sebastian Markbåge
d750cf7401
Merge pull request #2942 from sebmarkbage/metamatchers
...
Add Meta Matchers for Testing Tests
2015-01-26 16:05:40 -08:00
Sebastian Markbage
3bbf6ce1a5
Add Meta Matchers for Testing Tests
...
This adds a matcher called toEqualSpecsIn which executes two test suites,
without reporting the result. It then compares the specs and the number
of expects executed by each spec.
This will be used to ensure that tests written in other languages test the
same thing as the base line, ES6 classes.
Sets up CoffeeScript equivalence test.
2015-01-26 15:50:57 -08:00
Ben Moss
28f50c8a78
Add displayName to nested render warnings [ #1726 ]
2015-01-26 14:14:36 -05:00
Sebastian Markbåge
e6672a3a03
Merge pull request #2944 from sebmarkbage/coffeescript
...
Add CoffeeScript Class Test
2015-01-26 11:10:18 -08:00
Sebastian Markbage
5f150822e6
Add CoffeeScript Class Test
...
As part of the new class effort it is now possible to define React
Components using any type of generic JavaScript class syntax.
This includes CoffeeScript. This test ensures that we don't regress that
support, and also serves as an example for using React in CoffeeScript.
This test fail trails the ReactES6Class-test file. Some manual tweaking is
required when converting tests.
2015-01-26 02:19:35 -08:00
Patrick Laughlin
51e0610a62
Update 06-transferring-props.md
2015-01-25 22:03:57 -05:00
Sebastian Markbåge
4486a17c24
Merge pull request #2933 from sebmarkbage/pendingcontext
...
Remove _pendingContext
2015-01-24 21:54:36 -08:00
Sebastian Markbage
adabfe2f49
Remove _pendingContext
...
There is no way to queue an update to a context so there is no need for
this field. The only way to get a new context is from above.
Soon _pendingElement will get the same treatment. Once _setPropsInternal
can be removed.
2015-01-24 20:09:14 -08:00
Sebastian Markbåge
1c90efbf7c
Merge pull request #2923 from sebmarkbage/dropcomponentmixin
...
Replace ReactComponentMixin with ReactReconciler
2015-01-23 18:06:50 -08:00
Sebastian Markbage
690409a912
Replace ReactComponentMixin with ReactReconciler
...
Instead of putting the shared code in a base class method, we use a wrapper
call around all invokations. That way they're free to add code before AND
after the non-shared code.
That way we ensure that component extensions don't need to implement
ReactComponentMixin and do super() calls into it. This helps to create a
tighter API for custom component extensions.
This provides the first step towards moving these methods to static
methods which allows to use a different dispatch mechanism instead of
virtual method calls. E.g. pattern matching.
2015-01-23 17:27:42 -08:00
Ben Alpert
ac7677bb11
Update .mailmap for me
2015-01-23 11:10:22 -08:00
Sebastian Markbåge
0e108b180a
Merge pull request #2918 from sebmarkbage/fixcontexts
...
Move Component Class Instantiation into ReactCompositeComponent
2015-01-23 10:41:47 -08:00
Sebastian Markbage
9abd1133c9
Pass context to the constructor
...
This should reenable reading this.context from getInitialState.
Added a bunch of tests for this too.
2015-01-23 10:09:45 -08:00
Sebastian Markbage
766a79c695
Move component class instantiation into ReactCompositeComponent
...
We need to move instantiation into the mount phase for context purposes.
To do this I moved the shallow rendering stuff into ReactTestUtils and
reused more of the existing code for it by instantiating a noop child.
Everywhere we refer to the "type" we should pass it to ReactNativeComponent
to resolve any string value into the underlying composite.
2015-01-23 10:09:45 -08:00
Kirk Steven Hansen
3d37c95533
Typo in first commit.
2015-01-22 23:34:14 -06:00
Kirk Steven Hansen
b4007e85b8
Updated tutorial to be more clear about the dependence on the --harmony flag.
2015-01-22 23:30:02 -06:00
Sebastian Markbåge
8616a6f60e
Merge pull request #2919 from sebmarkbage/removecreateref
...
Remove React.createRef API
2015-01-22 19:13:55 -08:00
Sebastian Markbage
a3a464c8fc
Remove React.createRef API
...
This API was removed so this won't work.
2015-01-22 19:11:11 -08:00
Ben Alpert
f9821de909
Merge pull request #2917 from spicyj/ref-composite
...
Switch first-class refs to use functions
2015-01-22 18:19:05 -08:00
Ben Alpert
322bde6eb0
Switch first-class refs to use functions
...
Closes #1373 .
Test Plan: jest
2015-01-22 18:10:25 -08:00
Jim
734aedb977
Merge pull request #2892 from jsfb/fbme-url-for-dangerouslySetInnerHtml
...
Added fb.me url to error message.
2015-01-22 17:07:28 -08:00
Ben Alpert
a534264c1e
Merge pull request #2916 from spicyj/ref-composite
...
Move ref code to ReactCompositeComponent
2015-01-22 16:01:51 -08:00
Ben Alpert
9c3d6b8881
Move ref code to ReactCompositeComponent
...
You can only get a ref to a ReactCompositeComponent, so move the ref code here which gives us more flexibility to put it at the correct time in the lifecycle.
There should be no behavior change in this commit.
Test Plan: jest
2015-01-22 15:36:59 -08:00
Paul O’Shannessy
3d109aa11b
Merge pull request #2915 from zpao/lint-fixup
...
Fix a couple small lint issues
2015-01-22 14:56:25 -08:00
Paul O’Shannessy
c33d443c0b
Fix a couple small lint issues
...
These aren't caught by eslint yet :(
2015-01-22 14:39:08 -08:00
Sebastian Markbåge
8a5c5ba69d
Merge pull request #2913 from sebmarkbage/typewarning
...
Add warning when accessing .type on a component class
2015-01-22 13:39:07 -08:00
Sebastian Markbage
1ed1d7a158
Add warning when accessing .type on a component class
...
Since we removed the wrapper factory around classes, the class is just
the class now so there is no need for this indirection property.
2015-01-22 13:26:34 -08:00
Paul O’Shannessy
6588a84a0f
Merge pull request #2765 from zpao/jsxtransformerlinenumber
...
Check for lineNumber support before using it
2015-01-22 12:58:51 -08:00
Jim
b94adc9724
Added fb.me url to error message.
2015-01-22 12:56:52 -08:00
Paul O’Shannessy
f8a214137a
Merge pull request #2903 from tendant/merge-conflicts-in-translation
...
Update documents for Chinese translation
2015-01-22 12:55:53 -08:00
Paul O’Shannessy
92e361709c
[docs] Use current date in copyright footer
...
This will be based on the site generation time, making doc generation
slightly less deterministic but that's ok. Now we won't depend on
helpful community members updating it for us (#2874 ) when we forget,
it'll just happen naturally the next time the site is generated.
2015-01-22 12:50:52 -08:00
Jim
54b565de93
Merge pull request #2518 from jsfb/documentation-for-dangerouslySetInnerHtml
...
Document justification for dangerouslySetInnerHTML, fixes #2256
2015-01-22 10:52:47 -08:00
Ben Alpert
76e1d5a542
Merge pull request #2902 from swestwood/patch-2
...
Correctly highlight changed line in tutorial.
2015-01-22 08:27:29 -08:00
Lei
943c2aa77a
Add Chinese translation of reusable-components
2015-01-21 19:43:24 -08:00
Lei
833fcb6593
Add Chinese translation of multiple-components
2015-01-21 19:34:40 -08:00
Paul O’Shannessy
6247f30103
Merge pull request #2890 from amykyta/patch-1
...
Update 02.1-jsx-in-depth.md
2015-01-21 19:07:01 -08:00
Timothy Yung
b403af192d
Merge pull request #2900 from wincent/test-desc-fix
...
Fix inaccurate spec description
2015-01-21 18:56:33 -08:00
Paul O’Shannessy
4b2e89dd99
Add npm run build
...
It's a "shortcut" to `grunt build`
2015-01-21 17:23:36 -08:00
Sophia Westwood
a19966f2ea
Correctly highlight changed line in tutorial.
...
This excerpt adds the onSubmit handler to the form element, but the line was not highlighted as having been modified.
2015-01-21 17:15:31 -08:00
Greg Hurrell
76fe572a97
Fix inaccurate spec description
...
The string here was initially accurate, but got out of sync with reality
when the commit was revised (as 892e357fd5 ).
2015-01-21 17:07:29 -08:00
Timothy Yung
892e357fd5
Merge pull request #2894 from yungsters/local-event-trap-mixin
...
Fix LocalEventTrapMixin for Bad Tree State
2015-01-21 15:34:32 -08:00
yungsters
a7aca51f1e
Throw for Misue of LocalEventTrapMixin
...
Summary:
If `getDOMNode()` returns null in `LocalEventTrapMixin`, `listener` will also be null and `accumulateInto` will throw. This changes `LocalEventTrapMixin` to throw a more helpful error message.
Test Plan:
Ran unit test successfully:
```
npm test LocalEventTrapMixin-test.js
```
2015-01-21 15:30:04 -08:00
Jim
6f44f6049e
Document justification for dangerouslySetInnerHTML, fixes #2256
...
Conflicts:
docs/_data/nav_tips.yml
docs/tips/17-children-undefined.md
2015-01-21 12:47:36 -08:00
Isaac Salier-Hellendag
972befe0b6
Merge pull request #2889 from salier/react-default-perf
...
Repair ReactDefaultPerf
2015-01-21 13:28:53 -06:00
amykyta
b8f3c7f7fb
Update 02.1-jsx-in-depth.md
2015-01-21 12:22:29 -05:00
Isaac Salier-Hellendag
de54d84051
Repair ReactDefaultPerf
...
Update ReactDefaultPerf to properly record component names.
2015-01-21 10:52:43 -06:00
Cedric Sohrauer
5f837074f9
adds a composite component for an iframe to handle load events
...
This is basically a copy of ReactDOMImg
2015-01-21 10:33:34 +01:00
Paul O’Shannessy
ce5346f2ce
Merge pull request #2884 from chenglou/fix-ex-source-map
...
Temporarily comment out bundle-collapser for JSXTransformer
2015-01-20 18:55:39 -08:00
Paul O’Shannessy
f9c393f4fb
Fix strict mode violoation in test
2015-01-20 18:26:51 -08:00
Cheng Lou
51d74ca36c
Temporarily comment out bundle-collapser for JSXTransformer
...
This will at least make the examples run while we fix the issue.
2015-01-20 20:27:59 -05:00
Paul O’Shannessy
06de3f31f0
Merge pull request #2875 from kchia/patch-2
...
Update 03-interactivity-and-dynamic-uis.md: correct typo
2015-01-20 16:42:27 -08:00
Paul O’Shannessy
0a62a04909
Merge pull request #2881 from camsong/master
...
Add Chinese translation to several pages.
2015-01-20 16:41:58 -08:00
Sebastian Markbage
a5657d213c
Fix lint
2015-01-20 14:40:19 -08:00
Paul O’Shannessy
c778e61da0
Fix ES6Class test so it runs in browsers
...
document.createElement throws an error if you don't pass it any
arguments. Neither PhantomJS nor jest (via jsdom at version jest is
using) behave as browsers do now so this went unnoticed.
2015-01-20 14:30:33 -08:00
Sebastian Markbåge
2d75b11097
Merge pull request #2808 from sebmarkbage/modernclasses
...
New class instantiation and initialization process
2015-01-20 14:28:40 -08:00
Sebastian Markbage
291a92c4a6
New class instantiation and initialization process
...
This allows state to be set up in the constructor instead of through
getInitialState. getInitialState is now considered part of "classic".
Therefore, they move into ReactClass's constructor.
As a consequence of this, we no longer have a mapping between the internal
representation and the public instance during the mounting process.
Because the constructor hasn't returned yet.
We used to have a special case for calling setState in getInitialState
which was just ignored. This makes that throw and the component is
considered unmounted during the construction phase.
2015-01-20 14:27:28 -08:00
Jim
f92967c886
Merge pull request #2853 from jsfb/warn-only-on-read
...
Eliminate context warnings when component isn't reading the conflicting context variable
2015-01-20 11:57:30 -08:00
Cam Song
1694aff89e
Add Chinese translation to 7 more pages.
...
Translate 'Note' to '注意' instead of '提示' to make it more sensible.
2015-01-20 00:15:16 +08:00
Hou Chia
9f18ccdce9
Update 03-interactivity-and-dynamic-uis.md: correct typo
...
My file change corrects a typo in the document.
Best,
Hou
2015-01-18 00:35:27 -08:00
Paul O’Shannessy
c6686768eb
Merge pull request #2874 from Carlsson87/patch-1
...
Update footer with correct year
2015-01-17 12:21:21 -08:00
Daniel Carlsson
4ffdbefaa2
Friends don't let friends look foolish on the internet
...
Updated your footer =)
2015-01-17 20:16:24 +01:00
Paul O’Shannessy
f656f1966e
Merge pull request #2297 from pedronauck/docs-namespace-in-jsx
...
Add a section at 'jsx-in-depth' talking about namespaced components
2015-01-16 16:21:22 -08:00
Paul O’Shannessy
4f50071de0
Merge pull request #2675 from af/topLevelAPIDocs
...
Top level api docs for createFactory
2015-01-16 13:18:28 -08:00
Paul O’Shannessy
d6aa588dfc
Merge pull request #2360 from beausmith/patch-1
...
Highlighted changed lines in examples
2015-01-16 13:10:00 -08:00
Paul O’Shannessy
31002e0cc1
Merge pull request #2707 from camsong/master
...
More Chinese Doc Translation
2015-01-16 13:06:40 -08:00
Paul O’Shannessy
1b85e611ad
Merge pull request #2734 from Minwe/master
...
add Forms and Event System docs Chinese translation
2015-01-16 13:06:12 -08:00
Paul O’Shannessy
d471fb4c0b
Merge pull request #2795 from chenglou/tips-lib
...
[Docs] Tip on integration with other libraries
2015-01-16 13:05:43 -08:00
Paul O’Shannessy
69d40d1be3
Merge pull request #2824 from zpao/docs-tutorial-server
...
[docs] Talk about running a server in tutorial
2015-01-16 13:05:19 -08:00
Ben Alpert
1428ea7823
Merge pull request #2502 from fabiomcosta/patch-4
...
Removing unecessary resize listener
2015-01-16 12:08:34 -08:00
Paul O’Shannessy
deae575dae
v0.13.0-alpha.2
2015-01-16 10:33:42 -08:00
Paul O’Shannessy
588032da51
Update package deps
2015-01-16 10:33:42 -08:00
Paul O’Shannessy
2de1545eae
Merge pull request #2867 from zpao/no-warn-mock-methods
...
Don't warn about plain classes when in mocked components
2015-01-15 16:45:05 -08:00
Paul O’Shannessy
069aec1d42
Don't warn about plain classes when in mocked components
...
Mocking both doesn't copy properties that start with an underscore, nor
does it copy values, only nested objects.
2015-01-15 16:39:57 -08:00
Sebastian Markbåge
c01507fd11
Merge pull request #2866 from sebmarkbage/fixbindwarning
...
Don't bind callbacks to setState, setProps etc.
2015-01-15 15:36:50 -08:00
Paul O’Shannessy
45c0747a17
Merge pull request #2851 from jsfb/unique-key-in-dev-only
...
The unique key warning should only happen in dev.
2015-01-15 15:08:43 -08:00
Sebastian Markbage
d7d3ea5560
Don't bind callbacks to setState, setProps etc.
...
We added a bind to the public instance, but instead we can just pass the
public instance as the context when we execute.
This avoids a warning that fires when we call bind on auto-bound methods.
2015-01-15 14:00:45 -08:00
Paul O’Shannessy
8e6e98b387
Merge pull request #2865 from zpao/revert-jasmine-helper
...
Revert "Merge pull request #2814 from jsfb/testutils-consolemock"
2015-01-15 13:47:34 -08:00
Paul O’Shannessy
967435b249
Revert "Merge pull request #2814 from jsfb/testutils-consolemock"
...
This reverts commit 9514861d93 , reversing
changes made to cdec83732d .
2015-01-15 13:35:57 -08:00
Cheng Lou
251d31a515
Merge pull request #2859 from javawizard/patch-1
...
ref-08-reconciliation.md: grammar/punctuation fixes
2015-01-15 14:36:27 -05:00
Alex Boyd
941cba679e
ref-08-reconciliation.md: grammar/punctuation fixes
2015-01-14 22:40:29 -07:00
Ben Alpert
8d5838af72
Merge pull request #2540 from spicyj/no-mutate-props
...
Warn when mutating props on a ReactElement
2015-01-14 11:37:43 -08:00
Paul O’Shannessy
892f0a59fe
Fix lint on travis
...
PR #2852 was not quite correct
2015-01-13 16:55:10 -08:00
Paul O’Shannessy
29ca22c2ff
Merge pull request #2852 from zpao/lint-fail-travis
...
Add eslint grunt task, fail travis for it
2015-01-13 16:12:15 -08:00
Paul O’Shannessy
84c83dca2d
Add eslint grunt task, fail travis for it
...
This is it...
2015-01-13 16:11:42 -08:00
Jim
8aa6171fd6
Eliminate context warnings when component isn't reading the conflicting context variable.
2015-01-13 15:34:46 -08:00
Paul O’Shannessy
54c82da15f
Merge pull request #2751 from zpao/eslint-fixup
...
Eslint fixup
2015-01-13 15:27:54 -08:00
Paul O’Shannessy
47ee780caf
[lint] fix consistent-returns
2015-01-13 15:26:33 -08:00
Paul O’Shannessy
2126600c37
[lint] disable a couple rules since rest args aren't processed right
2015-01-13 15:26:33 -08:00
Paul O’Shannessy
847357e42e
[lint] Fix reasonable lines to 80
...
I don't agree with 80 on principal but it's what we have for now.
This fixes the reasonable cases. Most of the long lines are in docblocks
with long type information or containing links.
2015-01-13 15:26:33 -08:00
Paul O’Shannessy
e27da99731
[lint] Fix majority of issues eslint found
2015-01-13 15:26:33 -08:00
Paul O’Shannessy
df2ddc5dfa
[lint] convert to single quotes
2015-01-13 15:26:33 -08:00
Paul O’Shannessy
df64a67b7f
codemod "use strict" to 'use strict' for better linting
2015-01-13 15:26:32 -08:00
Jim
fa40eefa00
Merge pull request #2818 from jsfb/unmasked-context-in-performContextUpdate
...
Context warning should fire on update, not just initial mount.
Renamed a couple instances of context
2015-01-13 15:05:45 -08:00
Paul O’Shannessy
aeffbef21f
Merge pull request #2662 from zpao/eslint
...
Use eslint
2015-01-13 14:03:16 -08:00
Jim
6b5b1b3f17
The unique key warning should only happen in dev.
2015-01-13 14:03:00 -08:00
Paul O’Shannessy
3f8d4eaa63
Use eslint
...
These rules are very close to what we have internally. We may still miss
a couple things (jsdoc params being a big one) but it's good enough.
This is also more restrictive than what we enforce internally, but it's
for the best.
2015-01-13 14:01:34 -08:00
Sebastian Markbåge
7a3083af36
Merge pull request #2806 from sebmarkbage/baseclass
...
Warn when defined methods are used in plain JS classes
2015-01-13 11:40:52 -08:00
Sebastian Markbage
2330962d25
Warn when defined methods are used in plain JS classes
...
In ReactClass we use early validation to warn you if a accidentally defined
propTypes in the wrong place or if you mispelled componentShouldUpdate.
For plain JS classes there is no early validation process. Therefore, we
wait to do this validation until the component is mounted before we issue
the warning.
This should bring us to warning-parity with ReactClass.
2015-01-13 11:29:28 -08:00
Sebastian Markbåge
d138f9a35b
Merge pull request #2805 from sebmarkbage/baseclass1
...
Introducing ReactComponentBase base class
2015-01-13 11:00:56 -08:00
Sebastian Markbage
ff032dc857
Introducing ReactComponentBase base class
...
This is the base class that will be used by ES6 classes.
I'm only moving setState and forceUpdate to this base class and the other
functions are disabled for modern classes as we're intending to deprecate
them. The base classes only have getters that warn if accessed. It's as if
they didn't exist.
ReactClass now extends ReactComponentBase but also adds the deprecated
methods. They are not yet fully deprecated on the ReactClass API.
I added some extra tests to composite component which we weren't testing
to avoid regressions.
I also added some test for ES6 classes. These are not testing the new
state initialization process. That's coming in a follow up.
2015-01-13 10:54:19 -08:00
Jim
e4842b4ae2
Context warning should fire on update, not just initial mount.
...
Renamed a couple instances of context to make it clear if it was masked/unmasked
2015-01-12 16:40:08 -08:00
Ben Alpert
90053da7bd
Merge pull request #2844 from kchia/patch-1
...
Update README.md insert comma
2015-01-12 09:45:52 -10:00
Hou Chia
08c7c556de
Update README.md insert comma
...
The file change inserts a missing comma.
Best,
Hou
2015-01-12 11:29:17 -08:00
Jim
d94acc0363
Merge pull request #2830 from jsfb/remove-tag-warning
...
Removed unknown tag warning/whitelist.
2015-01-12 10:42:44 -08:00
Ben Alpert
a5aacb947f
Warn when mutating props on a ReactElement
...
Test Plan: jest. Also used ballmer-peak in IE8 to verify that it still works.
2015-01-11 10:45:37 -10:00
Christopher Chedeau
f50da7ec63
Merge pull request #2832 from kikyous/patch-1
...
Update 07-forms.md
2015-01-10 13:54:05 -08:00
Jim
61f7a5613b
Removed unknown tag warning/whitelist.
2015-01-09 11:46:47 -08:00
chen
bb52715f1c
Update 07-forms.md
2015-01-09 10:19:42 +08:00
Paul O’Shannessy
8babd0ada3
[docs] Talk about running a server in tutorial
...
We've talked about this a few times and even half done it. This is for
real.
2015-01-07 17:26:54 -08:00
Paul O’Shannessy
5394acdb4b
Merge pull request #2799 from stkb/master
...
Wrap setInnerHTML in Windows 8 apps (Fixes #441 )
2015-01-07 16:47:32 -08:00
Paul O’Shannessy
4772967e29
Remove period from findDOMNode test filename
2015-01-07 15:16:31 -08:00
Paul O’Shannessy
6204aeec7d
Merge pull request #2822 from zpao/rm-immutable
...
Remove LegacyImmutableObject
2015-01-07 13:27:21 -08:00
Jim
9514861d93
Merge pull request #2814 from jsfb/testutils-consolemock
...
Added jasmine matcher that expects calls to console.warn.
2015-01-07 13:10:53 -08:00
Paul O’Shannessy
7863175cd9
Remove LegacyImmutableObject
...
We don't use it and it's not part of the build so nobody else is using
it. You should probably use immutable instead anyway.
2015-01-07 11:37:52 -08:00
Paul O’Shannessy
52e8ba4a40
Add boxFlex and boxFlexGroup to CSS Unitless Properties
...
Fixes #2812
2015-01-07 11:27:43 -08:00
Jason Bonta
cdec83732d
suggesting the use of immutable js for comparisons
2015-01-07 10:46:50 -08:00
Jim
bd4aff062d
Added jasmine matcher that expects calls to console.warn.
2015-01-06 14:05:37 -08:00
Paul O’Shannessy
a45472e050
Merge pull request #2793 from huang47/improve/use-bundle-collapser-to-reduce-file-size
...
use bundle-collapser to reduce browserified file size
2015-01-05 15:43:04 -08:00
Paul O’Shannessy
680bfd54a6
Merge pull request #2807 from JoshSGman/patch-1
...
Fix Outdated Copyright Year
2015-01-05 15:42:12 -08:00
Jim
e5b3f9aefa
Merge pull request #2520 from jsfb/warn-for-dangerouslySetInnerHtml
...
Added checks for incorrect usage of innerHTML. Fixes #1370
2015-01-05 13:39:16 -08:00
Jim
158e0dd35a
Merge pull request #2614 from jsfb/monitor-should-update-owner-is-useful
...
Find cases where shouldUpdateReactComponent is det
2015-01-05 13:32:43 -08:00
Jim
2a28189bea
Merge pull request #2800 from jsfb/getDOMNode-becomes-findDOMNode
...
Minor updates to findDOMNode, as per additional post-commit CR feedback.
2015-01-05 13:29:14 -08:00
Jim
f507ba3c2b
Minor updates to findDOMNode, as per additional post-commit CR feedback.
2015-01-05 13:26:35 -08:00
ShihChi Huang
9bc1961936
apply browserify bundle collapser to all build type
2015-01-05 13:15:16 -08:00
Joshua Goldberg
e926d4ff54
Fix Outdated Copyright Year
...
Fix outdated copyright year (update to 2015)
The copyright year was out of date. Copyright notices must reflect the current year. This commit updates the listed year to 2015.
2015-01-05 13:52:20 -05:00
Paul O’Shannessy
a7028c467f
Merge pull request #2801 from jsfb/componentDidUpdate-docs
...
Update docs to indicate that componentDDidUpdate is fired after changes are flushed to the DOM. Fix
2015-01-05 09:34:38 -08:00
Steve Baker
9c55b961d3
code formatting fixes
2015-01-05 18:21:53 +01:00
Paul O’Shannessy
26636e501d
Merge pull request #2791 from rickbeerendonk/patch-1
...
Update ref-09-glossary.md
2015-01-05 09:05:46 -08:00
Paul O’Shannessy
7295f36b0f
Merge pull request #2788 from mihaip/master
...
SyntheticEvent.timeStamp is a number, not a Date
2015-01-05 09:05:19 -08:00
Jim
08c5e42649
Update docs to indicate that componentDDidUpdate is fired after changes are flushed to the DOM. Fixes #2796
2015-01-02 14:02:44 -08:00
Steve Baker
3287ea52fe
Wrap setInnerHTML in Windows 8 apps
2015-01-02 20:28:58 +01:00
Cheng Lou
d0f2e7db5f
[Docs] Tip on integration with other libraries
...
Chose this title because it's more eye-catchy than "third-party integration".
2015-01-01 16:09:45 -05:00
ShihChi Huang
f214776a97
use bundle-collapser to reduce browserified file size
2014-12-30 23:16:04 -08:00
Rick Beerendonk
717b6d6249
Update ref-09-glossary.md
...
Minor grammatical fix.
2014-12-30 23:42:38 -05:00
Mihai Parparita
c0e33e8e76
SyntheticEvent.timeStamp is a number, not a Date
...
Also makes the a few other attribute types use lowercase (primitive) naming, to be consistent.
2014-12-30 12:06:49 -08:00
Paul O’Shannessy
ebf4cb4fab
Merge pull request #2785 from c-das/patch-1
...
Update 02-displaying-data.md
2014-12-30 06:45:18 -08:00
Chitharanjan Das
b25e2e70d8
Update 02-displaying-data.md
...
Just a couple of minor grammatical fixes.
2014-12-30 10:49:44 +00:00
Sebastian Markbåge
82a30268a3
Merge pull request #2767 from sebmarkbage/moderntypevalidation
...
Add late class validation warnings for statics
2014-12-29 12:45:49 -05:00
Sebastian Markbage
82d15c8fd5
Add late class validation warnings for statics
...
ES6 classes won't have an early validation step. Therefore I added some
extra validation later on in the process. These would've normally have
been caught by createClass in classic React.
2014-12-29 12:43:40 -05:00
Sebastian Markbåge
9cd290a8c8
Merge pull request #2783 from dylanharrington/master
...
Fix typo in warning for invalid reused markup
2014-12-29 12:14:22 -05:00
Sebastian Markbåge
bd5a91a55c
Merge pull request #2768 from sebmarkbage/duplicatetests
...
Removed some duplicate tests
2014-12-29 09:10:26 -08:00
Dylan Harrington
159ba54b8c
Fix typo in warning message for invalid reused markup
2014-12-29 01:55:16 -08:00
Sebastian Markbåge
11f83c1fa0
Merge pull request #2769 from sebmarkbage/breakonwarning
...
Throw a caught error in the default warning module
2014-12-25 14:47:34 -08:00
Paul O’Shannessy
b98facd76e
Merge pull request #2773 from vanesyan/patch-1
...
Update ref-01-top-level-api.md
2014-12-25 10:42:47 -08:00
Roman Vanesyan
172dec8351
Update ref-01-top-level-api.md
...
React isn't framework, it's library for UI!?
2014-12-24 14:39:37 +05:00
Paul O’Shannessy
6ca8bf82f5
Merge pull request #2772 from zpao/fixjsdoc
...
Fixup jsdoc for findDOMNode
2014-12-23 15:58:59 -08:00
Paul O’Shannessy
20c43d4ec8
Fixup jsdoc for findDOMNode
2014-12-23 15:56:05 -08:00
Paul O’Shannessy
41b919bb81
Merge pull request #2771 from zpao/temp-fix-empty-component
...
Temporarily fix EmptyComponents
2014-12-23 15:43:00 -08:00
Paul O’Shannessy
b2bf83ec85
Temporarily fix EmptyComponents
...
This a workaround for the problem described in #2770 . It should be
temporary because this is really just working around the real problem.
2014-12-23 15:33:53 -08:00
Sebastian Markbage
f1bab136d0
Throw a caught error in the default warning module
...
This throws an error that is immediately caught. This allows you to use the
debugger's "break on caught exception" feature to break on warnings.
This should help with tracking down these warnings using the stack.
However, it could also add more noise to other debugging pattern.
2014-12-23 14:21:04 -08:00
Sebastian Markbage
8864692237
Removed some duplicate tests
...
These tests are duplicates of the same test in the same file. Copy/paste
fail.
2014-12-23 13:59:11 -08:00
Paul O’Shannessy
3fec78638d
v0.13.0-alpha.1
...
Bumping version numbers so we can push to npm.
2014-12-23 12:04:23 -08:00
Paul O’Shannessy
343cda72d9
Merge pull request #2760 from alextsg/patch-3
...
Update 14-communicate-between-components.md for grammatical changes
2014-12-22 13:56:44 -08:00
Paul O’Shannessy
fe1edb60eb
Merge pull request #2759 from alextsg/patch-2
...
Update 05-maximum-number-of-jsx-root-nodes.md for capitalization
2014-12-22 13:56:10 -08:00
Paul O’Shannessy
f0f431e428
Check for lineNumber support before using it
2014-12-22 13:43:59 -08:00
Jim
e0725341cf
Merge pull request #2646 from jsfb/getDOMNode-becomes-findDOMNode
...
Added findDOMNode, as we move toward deprecating getDOMNode
2014-12-22 13:05:49 -08:00
Alexander Tseung
92c37ffb3d
Update 14-communicate-between-components.md
2014-12-21 00:14:34 -08:00
Alexander Tseung
3fd6ac56c1
Update 05-maximum-number-of-jsx-root-nodes.md
2014-12-20 23:59:34 -08:00
Paul O’Shannessy
f7166d0c97
Merge pull request #2754 from songawee/fix_version_typo
...
Fix version typo in grunt task
2014-12-20 15:00:37 -08:00
Dennis Johnson
5216460246
Fix version typo in grunt task
2014-12-20 12:29:06 -07:00
Paul O’Shannessy
7ed36c30b1
Merge pull request #2752 from peterblazejewicz/fix/blog-typo
...
Fix conference year typo in blog post content
2014-12-19 14:30:06 -08:00
Peter Blazejewicz
ef4e75b031
Fix conference year typo in blog post content
2014-12-19 23:06:24 +01:00
Paul O’Shannessy
b7734a7000
Diversity Scholarship blog post
2014-12-19 13:22:23 -08:00
Sebastian Markbåge
6c6ffdb064
Merge pull request #2748 from sebmarkbage/modern
...
Separate createElement and JSX tests
2014-12-18 18:16:06 -08:00
Sebastian Markbage
cea2c38733
Separate createElement and JSX tests
...
This essentially copies all classic element creation tests to the modern
JSX tests. The classic tests doesn't use JSX and modern tests do.
The idea is that the JSX tests can start dropping dynamic checks once
we have Flow support for those features. JSX won't be necessary for
dropping dynamic checks. Plain object will also work. Flow will also not
be necessary for JSX. However, the tests should test for the suggested
combination (JSX + Flow).
This also moves some misplaced tests to ReactDOM and Validator.
Note that the modern tests uses ES6 classes. I will add separate tests for
those. However, these are not guaranteed to have .displayName so all our
error messages should check .name if available instead. This should be
better abstracted but I just adhoc fix this for now.
2014-12-18 16:13:29 -08:00
Sebastian Markbåge
60b2241ad4
Merge pull request #2745 from sebmarkbage/types
...
Add placeholders for static prop type tests
2014-12-18 15:13:36 -08:00
Jim
a463191bb2
Find cases where shouldUpdateReactComponent is determined by the owner.
2014-12-18 14:24:09 -08:00
Paul O’Shannessy
c63de4b79b
Merge pull request #2586 from RileyTomasek/master
...
Fix typo in comment of jquery-bootstrap example
2014-12-18 14:15:30 -08:00
Jim
b46a6ce4bb
Added findDOMNode, as we move toward deprecating getDOMNode
2014-12-18 13:55:44 -08:00
Sebastian Markbage
e31f23fc2a
Add placeholders for static prop type tests
...
This is where tests of static prop types should go when we have the
infrastructure set up to handle it.
2014-12-18 13:52:56 -08:00
Sebastian Markbåge
435aac26af
Merge pull request #2744 from sebmarkbage/types
...
Renamed classic/propTypes to classic/types
2014-12-18 13:42:45 -08:00
Sebastian Markbage
019028bec4
Renamed classic/propTypes to classic/types
...
I want to create a parallel folder for static type checking in the
"modern" folder so lets use the generic "types" name.
2014-12-18 13:40:32 -08:00
Paul O’Shannessy
d488f534ae
0.12.2 starter kit
...
(cherry picked from commit 6c5cb72cdc )
2014-12-18 12:47:33 -08:00
Paul O’Shannessy
378112f380
v0.12.2 blog post
...
(cherry picked from commit 2f6a95d5a2 )
2014-12-18 12:47:32 -08:00
Paul O’Shannessy
2eb6cf6dd0
Readme + Changelog for 0.12.2
...
(cherry picked from commit 7468f092ae )
2014-12-18 12:47:32 -08:00
Paul O’Shannessy
3c2fc6440e
update docs for 0.12.2 changes
...
(cherry picked from commit e6e60c4fa8 )
2014-12-18 12:47:32 -08:00
Sebastian Markbåge
702eef0bf0
Merge pull request #2740 from facebook/revert-2613-monitor-cloneWithProps
...
Revert "Monitoring code use of cloneWithProps"
2014-12-18 12:13:34 -08:00
Sebastian Markbåge
7354a699ff
Revert "Monitoring code use of cloneWithProps"
2014-12-18 12:13:09 -08:00
Riley Tomasek
84a93fbacf
Improve comment in example code
...
This should make it more clear that even though `$` is used in 4 methods, only 2 of them are crucial for integrating the modal into the components lifecycle methods and the other 2 are just helpers.
2014-12-18 10:05:25 -05:00
minwe
309507955b
add Event System doc Chinese translation
2014-12-18 13:10:02 +08:00
minwe
60ffe1e22e
add Forms doc Chinese translation
2014-12-18 12:27:28 +08:00
Paul O’Shannessy
11785db573
Merge pull request #2727 from zpao/update-npm-deps
...
Update NPM dependencies
2014-12-17 16:56:14 -08:00
Paul O’Shannessy
c17ea85483
Merge pull request #2732 from zpao/travis-container
...
Use containers on TravisCI
2014-12-17 16:54:12 -08:00
Paul O’Shannessy
2620161d93
Merge pull request #2733 from morenoh149/patch-1
...
Added note for proper example display
2014-12-17 16:17:50 -08:00
Harry Moreno
9adb4447cd
Added note for proper example display
...
jsfiddles weren't showing up for me. Upon further investigation I found that changing to http fixes the embedding.
2014-12-17 12:52:49 -08:00
Paul O’Shannessy
626023fc52
Merge pull request #2726 from zpao/createElement-undefined-null
...
Protect better against createElement(null/undefined)
2014-12-17 10:46:49 -08:00
Paul O’Shannessy
1bd8990fb2
Use containers on TravisCI
...
This *should* enabled the caching of node_modules for faster builds. We
may need to tweak this later to make sure node_modules gets updated
See http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/
2014-12-17 10:44:07 -08:00
Paul O’Shannessy
50a0d69961
Protect better against createElement(null/undefined)
...
This adds a warning to React.createElement in __DEV__ about using null
or undefined. This is technically valid since element creation can be
considered safe and usable in multiple rendering environments. But
rendering in a DOM environment with an element with null/undefined type
is not safe.
2014-12-17 10:38:02 -08:00
Paul O’Shannessy
401d4dd108
Update NPM dependencies
...
This was mostly to update Jest, but the others were the safe ones from
`npm outdated --depth=0`
2014-12-16 14:17:10 -08:00
Paul O’Shannessy
5f4d759a2b
Merge pull request #2718 from alextsg/patch-1
...
Update tutorial.md for grammatical changes
2014-12-16 09:48:23 -08:00
Paul O’Shannessy
558afae61a
Changelog, Readme updates for v0.12.1
...
(cherry picked from commit a067fc0fee )
2014-12-16 09:44:00 -08:00
jeffmo
849e79fef4
Include 0.12.1 starter kit
...
(cherry picked from commit e9dde65341 )
2014-12-16 09:44:00 -08:00
Alexander Tseung
a53270267f
Update tutorial.md for grammatical changes
...
Update tutorial.md to improve grammatical parallelism in features list. Also added periods to follow first item's syntax.
BEFORE: "Live updates: as other users comment we'll pop them into the comment view in real time"
AFTER: "Live updates: other users' comments are popped into the comment view in real time."
BEFORE: "Markdown formatting: users can use Markdown to format their text"
AFTER: "Markdown formatting: users can use Markdown to format their text."
2014-12-15 23:43:26 -08:00
Paul O’Shannessy
f13b4641bb
Merge pull request #2716 from RichardLitt/patch-2
...
Delete extraneous period
2014-12-15 13:16:38 -08:00
Richard Littauer
4f7b37f73a
Delete extraneous period
2014-12-15 13:14:00 -08:00
Paul O’Shannessy
6abb1c9e84
Merge pull request #2710 from zpao/lint-fix-again
...
Fix lint
2014-12-14 22:12:43 -08:00
Aaron Franks
a5ae126630
Docs: ReactComponent -> ReactClass in a few places
2014-12-14 17:03:02 -08:00
Paul O’Shannessy
63d8e0c144
Fix lint
2014-12-14 15:22:24 -08:00
Paul O’Shannessy
0b0fa760cc
Merge pull request #2647 from zpao/text-component-expect
...
Add toBeTextComponentWithValue to reactComponentExpect
2014-12-14 14:33:37 -08:00
Paul O’Shannessy
42ae61d065
Merge pull request #2655 from zpao/rm-deprecated
...
Remove deprecated methods since 0.12 shipped
2014-12-14 14:33:16 -08:00
Paul O’Shannessy
c46dadea55
Remove deprecated methods since 0.12 shipped
2014-12-14 14:19:44 -08:00
Paul O’Shannessy
c9fb5b258e
Add toBeTextComponentWithValue to reactComponentExpect
...
This was previously possible by looking at renderedChildren and props
but this feels better.
2014-12-14 14:12:29 -08:00
Paul O’Shannessy
ca5d93ca0a
Merge pull request #2708 from zpao/strip-types
...
Enable strip-types transform for internal code
2014-12-14 13:08:34 -08:00
Paul O’Shannessy
a818097a60
Merge pull request #2705 from Swader/patch-1
...
Update 02-displaying-data.md
2014-12-14 13:00:51 -08:00
Paul O’Shannessy
9016665c0e
Enable strip-types transform for internal code
...
Flow is coming so we need to be ready.
2014-12-14 12:51:39 -08:00
Cam Song
09e0dee307
Sync up previous Chinese documents and several minor updates on formats.
2014-12-14 15:30:10 +08:00
Cam Song
db569f0c0a
Add Chinese translation of interactivity-and-dynamic-uis
2014-12-14 15:30:00 +08:00
Bruno Škvorc
e507dc08d5
Update 02-displaying-data.md
...
Typo fix
2014-12-14 08:03:35 +01:00
Cam Song
f84ede6d34
Add Chinese translation of jsx-gotchas
2014-12-14 04:28:57 +08:00
Sebastian Markbåge
6bb77b5d4d
Merge pull request #2700 from sebmarkbage/classic
...
Move ReactClass, ReactElement and ReactPropTypes into "classic"
2014-12-12 19:53:28 -08:00
Sebastian Markbage
801e953334
Move ReactClass, ReactElement and ReactPropTypes into "traditional"
...
This moves ReactClass, ReactElement and ReactPropTypes into a legacy folder
but since it's not quite legacy yet, I call it "classic".
These are "classic" because they are decoupled and can be replaced by
ES6 classes, JSX and Flow respectively.
This also extracts unit tests from ReactCompositeComponent, which was
terribly overloaded, into the new corresponding test suites.
There is one weird case for ReactContextValidator. This actually happens in
core, and technically belongs to ReactCompositeComponent. I'm not sure
we will be able to statically validate contexts so this might be a case
for dynamic checks even in the future. Leaving the unit tests in classic
until we can figure out what to do with them.
2014-12-12 17:54:35 -08:00
Paul O’Shannessy
d1ab4cda4b
Merge pull request #2694 from camsong/master
...
Add Chinese translation of js-spread
2014-12-12 09:47:07 -08:00
Cam Song
9c7dc5f3b8
Add Chinese translation of js-spread
2014-12-12 09:33:01 +08:00
Paul O’Shannessy
80ed4d870a
Merge pull request #2690 from salier/before-input
...
Combine BeforeInput and Composition event plugins
2014-12-11 17:08:26 -08:00
Jim
df81c9916b
Merge pull request #2695 from jsfb/fix-scry2
...
Fixed ReactTestUtils scry for TextComponents. Fix
2014-12-11 16:54:55 -08:00
Jim
74f5b21758
Fixed ReactTestUtils scry for TextComponents. Fixes issue #2654 .
2014-12-11 13:12:35 -08:00
Paul O’Shannessy
91eb2e2f99
Merge pull request #2689 from camsong/master
...
Add Chinese translation of jsx-in-depth
2014-12-10 15:12:55 -08:00
Isaac Salier-Hellendag
9ad0e1d846
Update BeforeInputEventPlugin.js
2014-12-10 11:36:39 -05:00
Isaac Salier-Hellendag
ddaf215b03
Combine BeforeInput and Composition event plugins
...
In order to improve support for Chinese and Japanese IME input in
Internet Explorer, use a fallback composition state to determine
inserted text. IE composition events are mostly okay, except for
certain punctuation characters that are ignored. Using the fallback, we
can detect these characters.
The fallback is also useful for emitting `beforeInput` events, so it
makes sense to simply combine these plugins.
This change also incorporates a recent change to the Google Input Tools
browser extension that exposes a `data` field via the `detail` object
on the custom composition events it emits.
2014-12-10 11:32:53 -05:00
Cam Song
8621b4d338
Add Chinese translation of jsx-in-depth
2014-12-11 00:19:15 +08:00
Paul O’Shannessy
ed1803dc16
Merge pull request #2679 from tschaub/patch-1
...
Add missing verb in docs
2014-12-09 14:04:57 -08:00
Tim Schaub
877d00d9ba
Add missing verb
...
This adds a missing verb in JSX-in-depth doc.
2014-12-08 15:08:57 -08:00
Paul O’Shannessy
ba95ce7b6f
Merge pull request #2677 from zpao/lint-internal
...
Fix new lint errors
2014-12-08 12:22:06 -08:00
Paul O’Shannessy
739baa9092
Fix new lint errors
...
We'll get to lint parity soon and then not need to do this.
2014-12-08 12:18:41 -08:00
Aaron Franks
93ce334368
Add top-level API docs for React.createFactory.
2014-12-08 07:54:13 -08:00
Aaron Franks
09cfe453b8
Add type signature info to top-level API docs.
2014-12-07 23:17:27 -08:00
Ben Alpert
b97bb21ea2
Merge pull request #2672 from cookfront/master
...
The same problem in issue #2648
2014-12-06 23:50:43 -08:00
cookfront
7fad8fddf1
The same problem in issue #2648
2014-12-07 15:42:51 +08:00
Cheng Lou
cfe97641ce
Merge pull request #2671 from benkeen/patch-1
...
Update 10.6-update.md
2014-12-06 20:12:21 -05:00
Benjamin Keen
2ee870e253
Update 10.6-update.md
...
Spelling fix.
2014-12-06 15:49:22 -08:00
Jason Webster
6846cce840
Add additional supported methods to event documentation
...
`isPropagationStopped` and `isDefaultPrevented` methods do in fact exist on `SyntheticEvent`
2014-12-05 01:19:08 -08:00
Paul O’Shannessy
5c1589b81e
Merge pull request #2658 from ianobermiller/margin-attrs
...
Support marginHeight and marginWidth attributes
2014-12-04 19:02:34 -08:00
Paul O’Shannessy
dd844bffc0
Merge pull request #2489 from cody/form
...
Add Attributes formAction, formEncType, formMethod and formTarget
2014-12-04 19:01:32 -08:00
Ian Obermiller
9d7467e225
Don't need MUST_USE_ATTRIBUTE for margin(Width|Height)
2014-12-04 11:02:35 -08:00
Ian Obermiller
96bd155cbd
Support marginHeight and marginWidth attributes
...
marginHeight and marginWidth are used on iframes to set the default body margin inside the iframe.
2014-12-04 07:35:17 -08:00
Isaac Salier-Hellendag
0e1185cdbf
Merge pull request #2653 from salier/ie-selection
...
Use getSelection in IE where available
2014-12-03 14:19:49 -08:00
Isaac Salier-Hellendag
6b46e80bb9
Use getSelection in IE where available
...
IE9+ has support for window.getSelection, but we’re still using
document.selection for IE9/10. Only use the old IE selection API if the
modern one is unavailable.
2014-12-03 14:03:26 -08:00
Paul O’Shannessy
3144485cb9
Merge pull request #2635 from zpao/docs/props-state-clarification
...
[docs] Clarify when state may duplicate props
2014-12-03 11:24:21 -08:00
Paul O’Shannessy
b3cd299ed7
Merge pull request #2639 from zpao/own-jsfiddle
...
Own our fiddles so we can update them more easily
2014-12-03 11:24:08 -08:00
Paul O’Shannessy
b1971a7e27
Merge pull request #2649 from cookfront/master
...
In `Transferring Props` guide, `Manual Transfer` section will lead an er...
2014-12-03 11:13:40 -08:00
Paul O’Shannessy
a66430aec3
Merge pull request #2651 from arnihermann/use-charat-not-string-index-markup-diff
...
Use String.charAt to lookup string characters by index
2014-12-03 10:57:30 -08:00
Árni Hermann Reynisson
fdffec73c3
Use String.charAt for character by index lookup
...
Using object property accessor for string character lookup breaks in
non-modern browsers.
2014-12-03 14:49:55 +00:00
张敏
218a9ae74d
In Transferring Props guide, Manual Transfer section will lead an error
...
```c
var FancyCheckbox = React.createClass({
render: function() {
var fancyClass = this.props.checked ? 'FancyChecked' : 'FancyUnchecked';
return (
<div className={fancyClass} onClick={this.props.onClick}>
{this.props.children}
</div>
);
}
});
React.render(
<FancyCheckbox checked={true} onClick={console.log}>
Hello world!
</FancyCheckbox>,
document.body
);
```
When click `Hello world!` will lead a `Uncaught TypeError: Illegal invocation` error
2014-12-03 17:28:55 +08:00
Paul O’Shannessy
bd6b10887a
Remove unused require from ReactDOM-test
...
This happened internally in a codemod
2014-12-02 14:39:19 -08:00
Paul O’Shannessy
1bcf6ad77b
Merge pull request #2615 from af/createElement-docs
...
Add top-level API docs section for React.createElement.
2014-12-02 11:19:26 -08:00
Paul O’Shannessy
9021423be9
Merge pull request #2636 from zpao/docs/spread-assign-update
...
[docs] Remove generic spread, Object.assign mentions
2014-12-02 11:10:33 -08:00
Paul O’Shannessy
45bddda0f9
Merge pull request #2622 from rafd/patch-1
...
add note re: handling events in capture phase
2014-12-02 11:10:20 -08:00
Paul O’Shannessy
a76ffd56b7
Merge pull request #2623 from jbhatab/patch-1
...
Screencast interfacing react + backbone
2014-12-02 10:54:05 -08:00
Blaine Hatab
e1be9c0ad8
Screencast interfacing react + backbone
2014-12-02 10:49:16 -06:00
Paul O’Shannessy
2c2cac00f9
Own our fiddles so we can update them more easily
2014-12-01 19:33:43 -08:00
Paul O’Shannessy
e347e2975f
Merge pull request #2616 from christianalfoni/patch-3
...
Adding link to wiki
2014-12-01 16:03:16 -08:00
Paul O’Shannessy
fc91d2fd72
[docs] Remove generic spread, Object.assign mentions
2014-12-01 13:54:26 -08:00
Paul O’Shannessy
0a3a85bf52
[docs] Clarify when state may duplicate props
2014-12-01 13:46:59 -08:00
Rafal Dittwald
b3438c5f4b
Update ref-05-events.md
...
use backticks and change example into its own sentence
2014-12-01 15:36:01 -05:00
Paul O’Shannessy
4cc2993a01
Merge pull request #2633 from koba04/fix-addons-document
...
Fix addons documentation of development only part
2014-12-01 12:13:30 -08:00
Jim
aef7c4d1a1
Added checks for incorrect usage of innerHTML. Fixes #1370
2014-12-01 11:10:52 -08:00
Toru Kobayashi
a9115134b5
Fix addons documentation of development only part
2014-12-01 23:17:53 +09:00
Christopher Chedeau
f5a9ea8e03
Merge pull request #2629 from arnihermann/diff-msg-on-checksum-fail
...
Give context aware message if markup reuse fails
2014-12-01 10:16:40 +00:00
Árni Hermann Reynisson
a352b94f57
Give context aware message if markup reuse fails
...
The context is an extra message with comparison of where server and
client markup started to differ.
2014-12-01 10:15:07 +00:00
Paul O’Shannessy
5daffbb2c3
Merge pull request #2630 from shamrin/patch-1
...
fix typo in addons.update() $splice command help
2014-11-30 10:48:24 -08:00
Alexey Shamrin
92862ed601
fix typo in addons.update() $splice command help
2014-11-30 20:20:34 +03:00
Rafal Dittwald
4bc7c46c62
add note re: handling events in capture phase
2014-11-28 15:38:15 -05:00
Christian Alfoni
f09a39d963
Adding link to wiki
...
Based on conversation in https://github.com/facebook/react/pull/2501 . A good place to guide people further in finding the complete set of tools needed to build an application.
2014-11-27 08:48:16 +01:00
Aaron Franks
5e7e07b6d8
Add top-level API docs section for React.createElement.
2014-11-26 23:18:10 -08:00
Jim
5bd0b249b7
Merge pull request #2613 from jsfb/monitor-cloneWithProps
...
Monitoring code use of cloneWithProps
2014-11-26 16:37:00 -08:00
Jim
d42b285b0c
Monitoring code use of cloneWithProps
2014-11-26 16:29:09 -08:00
Paul O’Shannessy
bb97482729
Merge pull request #2610 from zpao/update-commonjs-example
...
Update commonjs example for 0.12
2014-11-26 13:08:24 -08:00
Paul O’Shannessy
e2dcc4a863
Update commonjs example for 0.12
2014-11-26 13:08:08 -08:00
Paul O’Shannessy
45a19a290c
Merge pull request #2553 from mhuggins/headers-attribute
...
Permit th `headers` attribute
2014-11-26 11:15:21 -08:00
Paul O’Shannessy
c48b877253
Merge pull request #2596 from sebmarkbage/rce
...
reactComponentExpect expects itself
2014-11-26 11:10:00 -08:00
Paul O’Shannessy
84e35615d2
Merge pull request #2600 from zpao/npm-test
...
Use jest for `npm test`
2014-11-26 11:09:39 -08:00
Jim
aee73cc463
Merge pull request #2602 from jsfb/context-tripple-equals
...
Warn if context values differ, related to issue #2
2014-11-25 16:52:09 -08:00
Jim
90d75ab099
Warn if context values differ, related to issue #2112
2014-11-25 16:44:09 -08:00
Paul O’Shannessy
b2ace55d9d
Merge pull request #2603 from facebook/revert-2601-rm-fbtransform-syntax
...
Revert "Remove fbtransform/syntax.js"
2014-11-25 16:43:46 -08:00
Paul O’Shannessy
f7f3df3acc
Revert "Remove fbtransform/syntax.js"
2014-11-25 16:42:20 -08:00
Paul O’Shannessy
ce699e4a32
Merge pull request #2601 from zpao/rm-fbtransform-syntax
...
Remove fbtransform/syntax.js
2014-11-25 15:42:13 -08:00
Jim
3a8fb5fc1e
Merge pull request #2597 from jsfb/render-into-document
...
Replaced document.createElement with ReactTestUtil
2014-11-25 15:35:26 -08:00
Paul O’Shannessy
2a540b3fb7
Remove fbtransform/syntax.js
...
This was a file we probably never should have synced out in the first
place. We don't use it and it provides the same basic functionality that
bin/jsx provides.
2014-11-25 15:34:28 -08:00
Paul O’Shannessy
fd3f8e70e2
Merge pull request #2566 from zpao/style-fixup
...
Fix lint warnings, style fixups
2014-11-25 15:11:27 -08:00
Paul O’Shannessy
3ce88d7c17
Use jest for npm test
...
I've given in and this is easier than `npm run jest`. `grunt test` still
exists and is used by Travis so this has no CI implications.
2014-11-25 15:07:46 -08:00
Paul O’Shannessy
b7b74b7efe
Fix lint warnings, style fixups
...
Followup work for recent PRs
2014-11-25 15:06:30 -08:00
Jim
89fafad255
Replaced document.createElement with ReactTestUtils.renderIntoDocument where container was not subsequently utilized.
...
Fixes #1250
2014-11-25 12:06:22 -08:00
Steven Luscher
e18d87b53b
Merge pull request #2594 from steveluscher/community-round-up-24
...
Wrote Community Roundup #24
2014-11-25 10:24:47 -08:00
Sebastian Markbage
a530f1c379
reactComponentExpect expects itself
...
This was a bug when reactComponentExpectInternal was separated from
the normal reactComponentExpect flow.
2014-11-24 18:48:41 -08:00
Steven Luscher
0f488bfe71
Community #24 : New Carousel link, spelled react-prism correctly, and removed the whale-speak.
2014-11-24 18:24:52 -08:00
Steven Luscher
c94a48be4f
Wrote Community Roundup #24
2014-11-24 18:12:59 -08:00
Sebastian Markbåge
47e18c3ce6
Merge pull request #2593 from sebmarkbage/mountImage
...
Add additional field for ART reconciler
2014-11-24 17:08:13 -08:00
Sebastian Markbage
61349eb5a6
Add additional field for ART reconciler
...
ART, just like MultiChild adds an expando property to manage it's diffing
state. This is ugly and bad. We should be moving this state outside the
component for use by the diffing algorithm. This state is not needed by
components nested in composites, and varies by diffing algorithm.
It sucks that I have to add it to every component just to support ART,
but that's the quickest solution, other than disabling preventExtensions.
At least now we know that it sucks.
2014-11-24 17:02:11 -08:00
Jim
e7f4badf4a
Merge pull request #2579 from jsfb/context-to-warning-module
...
Use warning module for context warning instead of invoking console.warn ...
2014-11-24 14:42:23 -08:00
Jim
9f7901fe1d
Use warning module for context warning instead of invoking console.warn and monitorCodeUse directly. Depends on https://phabricator.fb.com/D1695279
2014-11-24 13:24:56 -08:00
Christopher Chedeau
f8aee772ce
Mention that talks will be recorded
2014-11-24 11:28:42 +00:00
Christopher Chedeau
c32cf03d0b
better wording thanks to @jwalke
2014-11-24 10:33:23 +00:00
Christopher Chedeau
fb2be69e9c
react.js conf updates
2014-11-24 09:26:00 +00:00
Ben Alpert
582bc932e5
Merge pull request #2583 from spicyj/style-example
...
Add example for how to use `style` properly
2014-11-21 14:27:32 -08:00
Ben Alpert
1c5443175c
Add example for how to use style properly
...
Test Plan: jest
2014-11-21 12:10:59 -08:00
Ben Alpert
c6ed9df7f3
Merge pull request #2582 from spicyj/rendercomponent
...
Finish renaming renderComponent -> render
2014-11-21 11:54:36 -08:00
Ben Alpert
23effb7034
Merge pull request #2581 from spicyj/rm-elt-docs
...
Update variable name and doc type to be accurate
2014-11-21 11:54:26 -08:00
Riley Tomasek
08b6b28902
Fix typo in comment of jquery-bootstrap example
2014-11-21 12:05:39 -05:00
Ben Alpert
d4e32a7b2c
Finish renaming renderComponent -> render
...
Test Plan: jest
2014-11-20 23:07:58 -08:00
Ben Alpert
c4b9b938cf
Update variable name and doc type to be accurate
...
Test Plan: Crossed fingers.
2014-11-20 23:03:03 -08:00
Sebastian Markbåge
68ba3b6d18
Merge pull request #2567 from sebmarkbage/childrenreconciler
...
Separate Child Reconciliation Step from Diffing
2014-11-20 11:48:54 -08:00
Sebastian Markbage
26ea341870
Separate Child Reconciliation Step from Diffing
...
This separates the reconciliation step of children into a separate module.
This is the first step towards prerendering.
The stateful instances are reconciled and put into a "rendered children"
set. Updates creates a new of these sets. These two sets are then diffed
to create insert/move/remove operations on the set.
The next step is to move the ReactChildReconciler step to before the
native DOM component. That way it's possible to rely on child
reconciliation without relying on diffing.
2014-11-20 11:45:02 -08:00
Jim
6ec952977e
Merge pull request #2565 from jsfb/fixwhitespace
...
Removed context paremeter to renderToString/renderToStaticMarkup.
2014-11-19 15:49:33 -08:00
Jim
7768d91363
Removed context paremeter to renderToString/renderToStaticMarkup.
2014-11-19 15:16:23 -08:00
Timothy Yung
006bc28633
Merge pull request #2571 from yungsters/cleanup
...
Replace `mountDepth` with `isTopLevel`
2014-11-19 13:43:50 -08:00
yungsters
fc7cf2ff63
Replace mountDepth with isTopLevel
...
Summary:
After #2570 , `mountDepth` is only used to enforce that `setProps` and `replaceProps` is only invoked on the top-level component. This replaces `mountDepth` with a simpler `isTopLevel` boolean set by `ReactMount` which reduces the surface area of the internal API and removes the need to thread `mountDepth` throughout React core.
Reviewers: @sebmarkbage @zpao
Test Plan:
Ran unit tests successfully:
```
npm run jest
```
2014-11-19 13:13:08 -08:00
Timothy Yung
70b1426ef0
Merge pull request #2570 from yungsters/updates
...
Update Dirty Components in Mount Ordering
2014-11-19 13:12:43 -08:00
yungsters
c7fd626b1f
Summary:
...
Currently, `ReactUpdates` updates dirty components in increasing order of mount depth. However, mount depth is only relative to the component passed into `React.render`. This breaks down for components that invoke `React.render` as an implementation detail because the child components will be updated before the parent component.
This fixes the problem by using the order in which components are mounted (instead of their depth). The mount order transcends component trees (rooted at `React.render` calls).
Reviewers: @sebmarkbage @zpao
Test Plan:
Ran unit tests successfully:
```
npm run jest
```
2014-11-19 12:51:55 -08:00
Paul O’Shannessy
3a0f30480d
Merge pull request #2544 from mjul/patch-1
...
Update 10.4-test-utils.md
2014-11-19 07:16:07 -08:00
Paul O’Shannessy
a07ab60ec0
Merge pull request #2554 from samccone/patch-1
...
Update tutorial language to be more explicit.
2014-11-19 06:15:35 -08:00
Cheng Lou
93bbb3ea5b
Merge pull request #2555 from mfunkie/patch-1
...
Animation documentation for ReactTransitionGroup
2014-11-18 22:33:48 -05:00
Sebastian Markbåge
b0f6f5449c
Merge pull request #2552 from sebmarkbage/cleanupinternals
...
Remove some unnecessary code in ReactComponents
2014-11-18 13:51:39 -08:00
Sebastian Markbage
13ed0317fa
Remove some invariants and deadcode
...
These are not necessary if we enable type checks. Static or dynamic.
They're distracting my greppability.
Also, some dead code in shallow rendering.
2014-11-18 13:04:56 -08:00
Timothy Yung
df87ea1fa6
Merge pull request #2465 from yungsters/perf
...
Preserve Implicit Method Names
2014-11-18 12:51:08 -08:00
yungsters
bda199de04
Preserve Implicit Method Names
...
Summary:
Changes the way we instrument methods for `ReactPerf` so that developer tools can assign implicit method names to measured functions.
Reviewers: @zpao @sebmarkbage
2014-11-18 12:48:58 -08:00
Mark Funk
5b2ffde48d
Animation documentation for ReactTransitionGroup
...
Update to the animation documentation for ReactTransitionGroup to clear the air on where one can use it.
If someone tries to use it off of React.addons.ReactTransitionGroup, which is undefined, instead of its real location, React.addons.TransitionGroup, they get a vague error about being unable to set defaultProps of undefined in the React createElement body.
2014-11-18 13:49:23 -05:00
Timothy Yung
ef35585468
Merge pull request #2464 from yungsters/immutable
...
Stop Mutating Merged Lifecycle Results
2014-11-18 10:02:07 -08:00
yungsters
8e15046283
Stop Mutating Merged Lifecycle Results
...
Summary:
Currently, `ReactClass` mutates values returned by `getDefaultProps`, `getInitialState`, and `getChildContext`. This is bad because the objects may, for example, be cached and re-used across instances of a React component.
This changes `ReactClass` to instead create a new object. In return for allocating a new object, I've replaced `mapObject` with a `for ... in` so that we are no longer allocating an unused object.
Fair trade, IMO.
Test Plan:
Ran unit tests successfully:
```
npm run jest
```
Conflicts:
src/core/ReactCompositeComponent.js
Conflicts:
src/class/ReactClass.js
2014-11-18 10:00:22 -08:00
Sam Saccone
8e47082fb6
Update tutorial language to be more explicit.
...
The word "Friends" does establish a relationship however it does not fit in the vernacular of react.
This change makes the phrase more explicit and more familiar.
2014-11-18 12:36:20 -05:00
Matt Huggins
9a472ca8f1
Permit th attribute
2014-11-18 07:52:25 -07:00
Sebastian Markbåge
e3e0bf5de2
Merge pull request #2550 from sebmarkbage/cleanupinternals
...
Move ComponentEnvironment out of ReactComponent
2014-11-17 17:41:32 -08:00
Jim
ef3b348bef
Merge pull request #2508 from jsfb/monitor-with-context
...
Start monitoring uses of withContext, related to issue #2112
2014-11-17 17:23:39 -08:00
Sebastian Markbage
5951a131db
Move ComponentEnvironment out of ReactComponent
...
We currently have three DOM specific hooks that get injected. I move those
out to ReactComponentEnvironment. The idea is to eventually remove this
injection as the reconciler gets refactored.
There is also a BackendIDOperation which is specific to the DOM component
itself so I move this injection to be more specific to the DOMComponent.
E.g. it makes sense for it to be injectable for cross-worker DOM operations
but it doesn't make sense for ART components.
2014-11-17 17:21:41 -08:00
Jim
46bff98a3f
Fixed 'imports' to resolve merge conflict
2014-11-17 17:14:00 -08:00
Jim
89aaf73ae8
Merge pull request #2509 from jsfb/use-parent-context
...
Initial implementation of issue #2112
2014-11-17 17:08:18 -08:00
Jim
081feeb2dd
Added warning if owner-based and parent-based contexts differ.
2014-11-17 17:02:20 -08:00
Alexander Shtuchkin
c779ad4da3
Fix ReactTransitionGroup behavior when removing several children at once
...
If several children complete leaving before rendering TransitionGroup,
only the last one was removed. This could easily happen if
callback in componentWillLeave is called synchronously and several items
are removed from array. The other case is when ReactCSSTransitionGroup
has transitionLeave={false} and array is also cleaned up.
The bug was happening because this.state.children was used as a base for
children removal and it wasn't updated until the render, so only the last
removal was actually happening.
Fix involves keeping the updated children state between invocations of
_handleDoneLeaving. After updating this.state and rendering,
updatedState is cleaned up and ready for subsequent array modifications.
Test case included.
2014-11-17 15:15:54 -08:00
Sebastian Markbåge
fba8be3b98
Merge pull request #2546 from sebmarkbage/cleanupinternals
...
Move more stuff out of ReactComponent
2014-11-17 14:47:34 -08:00
Sebastian Markbage
6dddd60e33
Unused variables
2014-11-17 13:31:19 -08:00
Sebastian Markbage
fb17e8ca56
Ensure that all internal instances have consistent properties
...
Use preventExtensions so that we can't add expando properties to internal
instances. This ensures that the hidden class is kept more consistent.
2014-11-17 12:54:21 -08:00
Sebastian Markbage
bc4dd411b0
Move _pendingX into ReactCompositeComponent
...
Since setProps can no longer be called on anything but composites, we can
move this complexity into ReactCompositeComponent.
2014-11-17 12:54:21 -08:00
Sebastian Markbage
974a4c84ce
Move mountComponentIntoNode and setProps out of ReactComponent
...
This is part of moving more logic out of the base classes.
setProps, replaceProps etc. are not accessible from anything other than
ReactClass so we can safely move it to ReactCompositeComponent.
mountComponentIntoNode is tightly coupled to ReactMount. It's part of the
outer abstraction, the mount point, not the individual component.
2014-11-17 12:54:21 -08:00
Scott Feeney
d75512f211
Merge pull request #2497 from graue/2393-v1
...
Basic shallow rendering support (#2393 )
2014-11-17 11:07:05 -08:00
Scott Feeney
bfadafe5d0
Shallow rendering support ( #2393 )
...
Now handles updating. Haven't looked at refs yet.
2014-11-17 10:47:18 -08:00
Martin Jul
50db9feb28
Update 10.4-test-utils.md
...
This adds minimal valid event data to the Simulate.change example for a text input field.
2014-11-17 13:14:11 +01:00
Sebastian Markbåge
e4218cb7dc
Merge pull request #2539 from sebmarkbage/cleanupinternals
...
Clean up a bunch of internal methods and fields that are now unnecessary
2014-11-16 21:13:07 -08:00
Sebastian Markbage
63644d5e71
Add test for warning in ReactElementValidator
...
I previously had a mistake here, so I'm adding a unit test to ensure that I
don't make the same mistake again.
2014-11-16 21:07:31 -08:00
Sebastian Markbage
dac59d1032
Drop the _owner and _lifeCycle field on internal instances
...
The _owner field is unnecessary since it's reachable from _currentElement.
The _lifeCycle field is unnecessary because an internal component should
not even need to exist at all if it's unmounted. It should be dereferenced
internally, and never exposed externally.
The only case where it's important is for batching updates where we
currently avoid calling performUpdateIfNecessary if it's mounted. However,
this function is already only executed "if necessary" so we just make sure
that it's not necessary after unmount by resetting all the pending fields.
2014-11-16 21:05:12 -08:00
Sebastian Markbage
03ae0a906b
Drop ReactOwner.Mixin
...
This is not used anywhere else. To avoid overabstraction we should just
inline this.
2014-11-16 21:04:07 -08:00
Sebastian Markbage
519ee322ca
Drop this.props
2014-11-16 21:04:04 -08:00
Sebastian Markbage
8181272fe8
Drop inaccessible methods
...
These are no longer accessible and the isOwnedBy check is only used in
a method that is not accessible.
2014-11-16 21:02:40 -08:00
Ben Alpert
a194e51af0
Move logic for null to instantiateReactComponent
...
This cleans up the code a bit and also brings us closer to allowing any ReactNode to be rendered at the top level.
Test Plan: jest
2014-11-16 17:41:54 -08:00
Ben Alpert
c96ea9abf2
Remove transferPropsTo
...
I'd like to outlaw prop mutation altogether, and now seems like a fine time to remove transferPropsTo.
Test Plan: jest
2014-11-16 17:41:07 -08:00
Ben Alpert
f391b7b3ca
Don't mutate .props.style in ReactDOMComponent
...
We currently make a copy of .style because we support mutating the style object in place. Instead of storing it back on props, store it separately on the component instance so that we don't mutate props anywhere. This is gross but should all be cleaned up after #2008 is resolved.
Test Plan: jest
2014-11-16 17:39:00 -08:00
Ben Alpert
505bc7595b
Fix up variable names and types to be correct
...
Test Plan: jest
2014-11-16 17:37:40 -08:00
Sebastian Markbåge
3aa56039c6
Merge pull request #2537 from sebmarkbage/hidedomcomponentinternals
...
Wrap every DOM node in a Composite Component
2014-11-16 15:35:04 -08:00
Ben Alpert
e619d25d03
Inject browser mixin before full-page components
...
createFullPageComponent doesn't reference ReactBrowserComponentMixin directly so the mixin should get injected before the components are created. Previously, this test failed because getDOMNode wasn't present on the component instance.
Test Plan: jest
2014-11-16 12:59:44 -08:00
Sebastian Markbage
9c3e2d833d
Wrap every DOM node in a Composite Component
...
...unless they already have a wrapper. Also, add tagName to every wrapper.
This ensures that refs are consistent. They always look like composite
components. This effectively hides the internal implementation details of
real DOM components since you can no longer get a ref to one.
In the future we might want to drop this wrapper and have refs refer
directly to the DOM node.
I currently use a hacky way of auto-wrapping inside of ReactNativeComponent
so that any given string can be wrapped. Better suggestions are welcome.
2014-11-16 10:32:46 -08:00
Christopher Chedeau
e8e79472aa
Merge pull request #2527 from gabelevi/master
...
Update stripTypes transform to use fixed up jstransform transform
2014-11-15 16:57:25 -08:00
Ben Alpert
795290d1b0
Fix problems with empty component ID registration
...
Fixes #2493 , also closes #2353 as it incorporates a variant of that fix.
- Instead of having getEmptyComponent return `<noscript />` directly, wrap it in a class that we can easily identify later as being an empty component
- Cache the empty component element instead of recreating one each time
- Avoid touching the nullComponentIdsRegistry dictionary at all when not dealing with empty components
- Move empty-component tests to a separate file
Test Plan: jest
2014-11-15 12:35:11 -08:00
Ben Alpert
230115da92
Make ReactTextComponent properly injectable
...
ReactTextComponent's implementation is DOM-specific; instead of flattenChildren creating the ReactTextComponent instances, ReactNativeComponent now takes care of having ReactTextComponent injected and creating the component instance. I also renamed ReactTextComponent to ReactDOMTextComponent and moved it to browser/ui/ where it belongs. ReactDOMTextComponent no longer inherits directly from ReactComponent and instead implements construct and {mount,receive,unmount}Component directly.
This diff removes `ReactTestUtils.isTextComponent` which should have previously never returned true when using public APIs.
Test Plan: jest, use ballmer-peak example.
2014-11-15 12:30:42 -08:00
Sebastian Markbåge
9b1c3226d0
Merge pull request #2385 from shripadk/bool-fix
...
Fix: Always return boolean from isNullComponentID
2014-11-15 11:43:27 -08:00
Gabe Levi
0d308add09
Update stripTypes transform to use fixed up jstransform transform
2014-11-14 18:25:11 -08:00
Ben Alpert
903db8bd14
Stop treating key={null} as an unspecified key
...
This reverts commit dd92786fb0 , which was intended to be temporary for the 0.12 release.
Fixes #2394 .
2014-11-14 16:52:43 -08:00
Ben Alpert
22da7b6fa5
Warn when casing CSS vendor prefixes incorrectly
...
Fixes #2487 .
Test Plan: jest
2014-11-14 16:51:55 -08:00
Cheng Lou
0db323e42a
Merge pull request #2514 from jvalente/patch-1
...
Update ref-09-glossary.md
2014-11-13 13:45:35 -05:00
Lee Byron
81d4d7bf24
Merge pull request #2512 from leebyron/transition-appear
...
Adding "appear" phase to ReactTransitionGroup and ReactCSSTransitionGroup
2014-11-13 13:44:56 -05:00
João Valente
485d84fb9b
Update ref-09-glossary.md
2014-11-13 12:06:51 +00:00
Lee Byron
8760a70e73
Adding "appear" phase to ReactTransitionGroup and ReactCSSTransitionGroup.
...
"appear" differs from "enter" in that all children of a transition group at mount time will "appear" but will not "enter". All children later added to an existing transition group will "enter" but not "appear".
This extra transition phase allows for animation-on-mount effects.
A mirroring "appear" prop has been added to ReactCSSTransitionGroup, however for reverse-compatibility (and because "appear" is less common) it defaults to false.
Thanks to @afa for his work investigating the possible ways to implement this.
2014-11-12 21:30:56 -05:00
Fabio M. Costa
f6dd6ef772
Removing unecessary resize listener
...
monitorScrollValue is only called with `ViewportMetrics.refreshScrollValues` (https://github.com/facebook/react/blob/master/src/browser/ReactBrowserEventEmitter.js#L333-L334 ) and the window scroll properties (scrollTop and scrollLeft) don't change on resize (from my testings), so there is no need to listen for window resizes.
I also tried to see why the resize listener was added from the history but it was introduced on the initial commits.
I created a simple page that shows that http://jsbin.com/nuhice , open the console.
2014-11-12 00:08:30 -08:00
Paul O’Shannessy
06bf89db8e
Merge pull request #2498 from ikr/patch-1
...
There's no isComponentOfType() anymore
2014-11-11 13:25:33 -08:00
Ivan Krechetov
13311639cc
There's no isComponentOfType() anymore
2014-11-11 09:25:33 +01:00
Stefan Dombrowski
1bb29cab7c
Add Attributes formAction, formEncType, formMethod and formTarget
...
This resolves #2425 .
2014-11-11 06:37:26 +01:00
Ben Alpert
7a162ce731
Merge pull request #2482 from BinaryMuse/bkt/fix-stroke-opacity
...
Add strokeOpacity to unitless CSS properties
2014-11-07 22:26:03 -08:00
Brandon Tilley
96126e9ff4
Add strokeOpacity to unitless CSS properties
2014-11-07 21:20:01 -08:00
Paul O’Shannessy
78ec2501cf
Merge pull request #2481 from mjul/fix-typos
...
Fix some minor typos in doc comments / code comments.
2014-11-07 16:58:49 -08:00
Paul O’Shannessy
b243f1eec6
Merge pull request #2480 from spicyj/text-stability
...
Test that text spans aren't remounted needlessly
2014-11-07 16:56:58 -08:00
Paul O’Shannessy
14d0a22ae8
Merge pull request #2479 from spicyj/nitfix
...
Fix odd formatting in ReactDOMComponent-test
2014-11-07 16:55:06 -08:00
Martin Jul
042c6c794c
Fix some minor typos in doc comments / code comments.
2014-11-07 18:07:07 +01:00
Ben Alpert
ba418c6014
Test that text spans aren't remounted needlessly
...
While working on #2382 , I accidentally broke this behavior (causing text components to get unmounted and remounted for any update) but we didn't have any unit test for it. Now we do.
Test Plan: jest TextComponent
2014-11-06 23:19:48 -08:00
Ben Alpert
a1dcdf1a64
Fix odd formatting in ReactDOMComponent-test
...
Test Plan: Crossed fingers.
2014-11-06 23:10:17 -08:00
Sebastian Markbåge
c10a39e82b
Merge pull request #2445 from sebmarkbage/classes
...
Separate React Composite and Class
2014-11-06 19:53:10 -08:00
Sebastian Markbage
27c482a2b8
Separate React Composite and Class
...
ReactClass is now composed by ReactCompositeComponent rather than
inherit from it.
The state transition functions currently use ReactInstanceMap to map an
instance back to an internal representation.
I updated some tests to use public APIs. Other unit tests still reach into
internals but now we can find them using ReactInstanceMap.
I will do more cleanup in follow ups. The purpose of this diff is to
preserve semantics and most of the existing code.
This effectively enables support for ES6 classes. All you would need to
expose is ReactClassMixin.
2014-11-06 19:49:33 -08:00
Ben Alpert
bd02e17fec
Merge pull request #2476 from jsfb/patch-1
...
Using semicolon instead of "and" conjunction
2014-11-06 15:15:39 -08:00
Jim
dbe16a357b
Using semicolon instead of "and" conjunction
...
The use of the conjunction "and" leads to an improper assertion about what should/shouldn't be done. Using a semicolon resolves this by indicating the contrasting alternative.
2014-11-06 14:50:35 -08:00
Paul O’Shannessy
cbada1e55a
Merge pull request #2473 from zertosh/docs-ssr-at-sc
...
Add React at SoundCloud talk
2014-11-06 14:05:10 -08:00
Paul O’Shannessy
df24852ca1
Merge pull request #2475 from jsfb/master
...
Use adjective "too" instead of "to"
2014-11-06 14:04:33 -08:00
jsfb
7f37074c33
Use adjective "too" instead of "to"
...
The author clearly intended to use the adjective "too" to mean "excessively" instead of the preposition "to".
2014-11-06 13:42:19 -08:00
Paul O’Shannessy
d12ae9d5bb
Merge pull request #2241 from syranide/selectvalue
...
ReactDOMSelect makeover, fix edge-case inconsistencies and remove state
2014-11-06 12:40:15 -08:00
Andres Suarez
d5810e46f9
Add SSR at SoundCloud talk
2014-11-06 10:54:05 -05:00
Ben Alpert
9edc6260a7
Initial implementation of new-style refs
...
cf. #1373
This implementation can be used in any situation that refs can currently be used (and can also be used without an owner, which is a plus).
2014-11-05 19:28:12 -08:00
Pedro Nauck
1adbc22fde
bugfix: remove conflict comment
2014-11-06 01:23:51 -02:00
Paul O’Shannessy
dca7ffbe21
Merge pull request #2446 from enaqx/master
...
Add 'use strict' to statisfy linter rules
2014-11-05 16:25:38 -08:00
Paul O’Shannessy
3e60195bd4
Merge pull request #2408 from Peeja/patch-1
...
TodoMVC live demos have moved.
2014-11-05 13:49:23 -08:00
Paul O’Shannessy
462f8ea9f6
Merge pull request #2452 from Shahor/master
...
Trailing commas break old IE versions
2014-11-05 11:00:12 -08:00
Paul O’Shannessy
a3509e5b42
Fixing some newline-preserving issues
...
Done internally as part of
f9836a3912
2014-11-05 10:36:22 -08:00
Pedro Nauck
a7f157ebb1
update namespaced component to adapt with the v0.12
2014-11-05 12:32:16 -02:00
Pedro Nauck
b5bcaba77f
Merge branch 'master' into docs-namespace-in-jsx
...
* master: (113 commits)
Remove esprima-fb and use Syntax from jstransform
Update React.renderToString argument type in docs
[traverseAllChildren] fix out-of-scope var use.
Use double quote for transformed `displayName` and `data-*`
Remove unrelated comment
Fix typo in If/Else JSX doc.
Cleanup a couple unused variables
Use dump cache and remove factory from ReactElement-test
Update deprecated propTypes
Bring in jsfiddle integration script, add harmony
Extending period in which click events are ignored
React.renderComponent --> React.render
Followup fix for React.PropTypes.node
Add comma for readability in tutorial
Drop internal uses of .type on the class
Drop Legacy Factories Around Classes
Drop ReactDOM from internal DOM extensions
Added comma to increase readability.
Add 0.12 starter kit
Change the date and the link url to match the proper roundup
...
Conflicts:
docs/docs/02.1-jsx-in-depth.md
2014-11-05 12:30:37 -02:00
Paul O’Shannessy
1fd187b994
Merge pull request #2224 from zertosh/remove-esprima-fb-dep
...
Remove esprima-fb and use Syntax from jstransform
2014-11-04 14:38:09 -08:00
Paul O’Shannessy
4ba53e1839
Merge pull request #1708 from chenglou/displayName
...
Use double quote for transformed `displayName`
2014-11-04 14:36:19 -08:00
Andres Suarez
bf0a857a92
Remove esprima-fb and use Syntax from jstransform
2014-11-04 17:10:12 -05:00
Paul O’Shannessy
984055c2f5
Merge pull request #2463 from fson/render-to-string-docs
...
Update React.renderToString argument type in docs
2014-11-04 09:37:12 -08:00
Ville Immonen
9c3357eef5
Update React.renderToString argument type in docs
...
renderToString and renderToStaticMarkup now take a ReactElement.
Update the documentation to reflect this recent change.
2014-11-04 17:02:00 +02:00
Lee Byron
d4ac1229a6
Merge pull request #2458 from leebyron/fix-iterable
...
[traverseAllChildren] fix out-of-scope var use.
2014-11-03 21:25:01 -05:00
Lee Byron
a3608d27ab
[traverseAllChildren] fix out-of-scope var use.
...
Dear ES6 gods, bring us `let` soon.
This fixes an issue where non-keyed iterables are used as children and the value of `i` would be undefined because its used out of scope. This adds a separately scoped iteration index value and appropriately increments it as iteration continues. Doi.
While I'm in there, make the usage of falsey `nameSoFar` more obvious and more consistent with the existing usage on L115
Test plan: first wrote a test covering this previously untested path. Saw an identical issue as was experienced in development environment. Then ensured test passed after this diff.
2014-11-03 21:19:28 -05:00
Andreas Svensson
2601b6a0b0
ReactDOMSelect makeover, fix edge-case inconsistencies and remove state
2014-11-03 23:19:01 +01:00
Alexandre Gaudencio
6379342b71
Trailing commas break old IE versions
2014-11-03 02:54:23 +01:00
Nick Raienko
bea9fbbf62
Add 'use strict' to statisfy linter rules
2014-11-01 07:05:46 +02:00
Cheng Lou
eddbb0cfef
Use double quote for transformed displayName and data-*
...
JSX currently transforms everything to double quote except these two. This way, it's at least consistent and will satisfy half of the people who do put a strict quotation linting on their project.
Test: `jest`, check the double quoted transformed `data-bla="something"`.
2014-10-31 15:49:24 -04:00
Sebastian Markbåge
cb50a8698b
Remove unrelated comment
...
This is no longer unwrapping a legacy factory (which are gone).
2014-10-31 12:39:38 -07:00
Paul O’Shannessy
1666661a06
Merge pull request #2433 from zpao/fiddle-integration
...
Bring in jsfiddle integration script, add harmony
2014-10-31 11:22:57 -07:00
Paul O’Shannessy
1abe716358
Merge pull request #2443 from kruppel/kurt/minor-tip-typo
...
Fix typo in If/Else JSX doc.
2014-10-31 10:11:32 -07:00
Kurt Ruppel
4b3b32e418
Fix typo in If/Else JSX doc.
2014-10-31 09:52:44 -07:00
Sebastian Markbåge
881c9b5be8
Merge pull request #2435 from sebmarkbage/fixretest
...
Use dump cache and remove factory from ReactElement-test
2014-10-30 12:06:21 -07:00
Paul O’Shannessy
d8ed3e5cf9
Merge pull request #2437 from zpao/lint-cleanup
...
Cleanup a couple unused variables
2014-10-30 12:05:38 -07:00
Paul O’Shannessy
295c1e3652
Cleanup a couple unused variables
2014-10-30 11:38:53 -07:00
Paul O’Shannessy
bf99ab1c89
Merge pull request #2434 from Shraymonks/propTypes-docs
...
Update deprecated propTypes
2014-10-30 09:43:02 -07:00
Sebastian Markbage
7f7b7f386a
Use dump cache and remove factory from ReactElement-test
...
We need to use dump cache because we don't enable it by default internally.
While I'm at it, I might as well kill the ComponentFactory variable which
is now just an alias.
2014-10-30 02:50:28 -07:00
Raymond Ha
92d171a4fc
Update deprecated propTypes
2014-10-29 21:00:32 -07:00
Paul O’Shannessy
0f5368341f
Bring in jsfiddle integration script, add harmony
2014-10-29 19:35:27 -07:00
Paul O’Shannessy
7071d1c316
Merge pull request #2419 from johnheroy/patch-1
...
Add comma for readability in tutorial.md
2014-10-29 18:03:48 -07:00
Paul O’Shannessy
eb7f806566
Merge pull request #2431 from wassil/master
...
Extending period in which click events are ignored
2014-10-29 18:02:44 -07:00
Juraj Dudak
c563e19739
Extending period in which click events are ignored
2014-10-29 14:06:37 -07:00
Paul O’Shannessy
b2b8e5c08a
Merge pull request #2428 from cody/fixes
...
React.renderComponent --> React.render
2014-10-29 11:44:35 -07:00
Stefan Dombrowski
93ac4d09a1
React.renderComponent --> React.render
...
Also fixed a spelling mistake.
2014-10-29 19:05:16 +01:00
Paul O’Shannessy
ce1b394529
Followup fix for React.PropTypes.node
...
This should have gone in as a part of #2343
2014-10-28 22:49:25 -07:00
Sebastian Markbåge
a54ed49eb0
Merge pull request #2375 from sebmarkbage/droplegacyfactories
...
Drop Legacy Factories
2014-10-28 18:00:32 -07:00
John Heroy
129d66a62e
Add comma for readability in tutorial
2014-10-28 15:22:40 -07:00
Sebastian Markbage
9b36b04d75
Drop internal uses of .type on the class
2014-10-28 15:08:52 -07:00
Sebastian Markbage
199a7d6903
Drop Legacy Factories Around Classes
...
Classes are now pure classes without a legacy factory around them.
Since classes will become just any function that returns a valid instance,
let's drop isValidClass.
There's some hacks in here for auto-mocking frameworks (jest) that mock the
prototype of these classes. These hacks allow these classes to be mounted.
2014-10-28 15:08:52 -07:00
Sebastian Markbage
531c2bc4c9
Drop ReactDOM from internal DOM extensions
...
These used to be exposed as strings on the legacy factories but are now
gone.
2014-10-28 15:08:52 -07:00
Paul O’Shannessy
581085ea1b
Merge pull request #2416 from zachasme/update-jstransform
...
Update jstransform version to 7.0
2014-10-28 15:01:57 -07:00
Paul O’Shannessy
22ffb57a93
Merge pull request #2415 from zpao/sync-internal
...
Sync internal
2014-10-28 14:30:06 -07:00
Cheng Lou
86336997cd
Merge pull request #2418 from spencer48/patch-1
...
(docs) Added commas to increase readability.
2014-10-28 17:26:18 -04:00
Spencer Handley
a55a3f77a1
Added comma to increase readability.
...
When thumbing through the docs, I noticed a few missing commas. I inserted two commas and did not alter any source code.
2014-10-28 13:56:14 -07:00
Paul O’Shannessy
17b190bee2
Add 0.12 starter kit
2014-10-28 11:48:53 -07:00
Christopher Chedeau
26c8a70c1d
Change the date and the link url to match the proper roundup
2014-10-28 11:36:12 -07:00
Paul O’Shannessy
9e895bc360
Correct changes from 0.12-stable merge
2014-10-28 11:20:33 -07:00
Paul O’Shannessy
8b041eaa5a
Merge branch '0.12-stable'
2014-10-28 11:18:02 -07:00
Paul O’Shannessy
f2947a0ca1
Merge pull request #2399 from zpao/0.12-docs
...
Docs updates for 0.12
2014-10-28 11:17:25 -07:00
Paul O’Shannessy
fa2597a3b3
0.12 blog post
2014-10-28 11:16:29 -07:00
Paul O’Shannessy
8ef1f96850
0.12 CHANGELOG
2014-10-28 11:16:28 -07:00
Paul O’Shannessy
3eb8222c22
Update cdnjs link, include jsdelivr in readme
2014-10-28 11:06:32 -07:00
Paul O’Shannessy
fcd4be3933
Update version references in the readme
2014-10-28 11:06:32 -07:00
Paul O’Shannessy
0b8454724e
Update Authors & Acknowledgements for 0.12
2014-10-28 11:06:32 -07:00
Christopher Chedeau
081115609c
React.js Conf blog post
...
Closes #2412
2014-10-28 11:06:31 -07:00
Cheng Lou
539db8e9c8
Merge pull request #2414 from benleiken/patch-1
...
Moved key requirement note into 'getting started'
2014-10-28 11:06:31 -07:00
Paul O’Shannessy
4d47ff36b2
Merge pull request #2413 from LeonFedotov/patch-1
...
Changing api documentation for jsx transformer
2014-10-28 11:06:31 -07:00
Sebastian Markbage
98bf80254f
Update Docs Navigation
2014-10-28 11:06:31 -07:00
Sebastian Markbage
1cb3f25e78
More Descriptor -> Element renames
2014-10-28 11:06:31 -07:00
Sebastian Markbage
b7a548c4bf
Replace transferPropsTo with transferring props patterns
2014-10-28 11:06:30 -07:00
Sebastian Markbage
9b1ee4de46
Updated Docs for new JSX Changes
...
Moved non-JSX explanation to Displaying Data.
Overhauled JSX in Depth.
Added JSX Spread Section.
2014-10-28 11:06:30 -07:00
Paul O’Shannessy
0dd942b121
Update Animation docs for createElement
2014-10-28 11:06:30 -07:00
Paul O’Shannessy
eb2827ec6a
Update React.DOM -> React.createElement through docs
2014-10-28 11:06:30 -07:00
Paul O’Shannessy
0344aaf18d
Use --harmomy in docs examples for cleaner code
2014-10-28 11:06:30 -07:00
Zacharias
c260c45db3
Update jstransform version to ^7.0.0
2014-10-28 13:48:48 +01:00
Tienchai Wirojsaksaree
ff12423d63
Fixing touch/mouse issues with TapEventPlugin
...
On ios device, browser simulates mouse events, but does that with
a delay, because of double tap gesture. The problem is that
TapEventPlugins listens to both types of events, so it fires twice
Everytime there is a touch event, we should ignore mouse events that
follow it. This way, we still respond to both mouse and touch events,
just ignore the device generated ones.
2014-10-27 17:02:03 -07:00
Paul O’Shannessy
1c241b3ebc
Ensure PropTypes test works when warning module is replaced
...
For example, warning might be replaced with a module that throws errors,
as is the case internally when running tests. Previously we were
whitelisting this test to provide time to update callsites. Now we
aren't and it fails.
2014-10-27 16:58:54 -07:00
Paul O’Shannessy
85930e63db
Merge pull request #2413 from LeonFedotov/patch-1
...
Changing api documentation for jsx transformer
2014-10-27 16:32:07 -07:00
Cheng Lou
18066a301e
Merge pull request #2414 from benleiken/patch-1
...
Moved key requirement note into 'getting started'
2014-10-27 18:47:24 -04:00
Benjamin Leiken
bb0c7b4ca9
Moved key requirement note into 'getting started'
...
It's an important note and it was buried too far down the page. Now it's more prominent and harder for people to miss (like I did).
2014-10-27 10:22:57 -07:00
Leon Fedotov
a29d496443
Changing api documentation for jsx transformer
...
Hi in chrome debugger, the files that use sourcemaps from the transformer get "null" as the filename during debug, https://github.com/facebook/react/blob/master/main.js#L15 "sourceFilename" is used instead of "filename" to specify the filename in the sourcemap.
2014-10-27 19:18:22 +02:00
Christopher Chedeau
64a5355444
React.js Conf blog post
...
Closes #2412
2014-10-27 10:12:09 -07:00
Paul O’Shannessy
d63aa0f113
Move Object.assign file to align with internal
2014-10-26 17:14:00 -07:00
Paul O’Shannessy
076a8285f7
Merge pull request #2409 from enaqx/master
...
Remove obsolete jshint options
2014-10-26 11:12:20 -07:00
Nick Raienko
eb3337b018
Remove obsolete jshint options
2014-10-26 12:18:24 +02:00
Peter Jaros
411a6a1f0c
TodoMVC live demos have moved.
2014-10-24 09:57:27 -04:00
Paul O’Shannessy
d36d26a574
[docs] Glossary
...
Pulled in https://gist.github.com/sebmarkbage/fcb1b6ab493b0c77d589
mostly verbatim
2014-10-23 20:51:11 -07:00
Paul O’Shannessy
4e5f5df4f6
Remove @jsx from examples
2014-10-23 20:51:11 -07:00
Paul O’Shannessy
4cfd8c6204
Update server servering example
...
It's referencing packages that aren't published yet but it *probably*
works...
2014-10-23 20:51:11 -07:00
Paul O’Shannessy
f53854bd93
React.renderComponent -> React.render
...
This covers most everything. The perf suite still needs work for the
Element updates. And the server rendering example needs to be done
wholesale.
2014-10-23 20:51:11 -07:00
Paul O’Shannessy
a90b4c9b3e
Update properties/elements
2014-10-23 20:51:11 -07:00
Sebastian Markbåge
ae8771fe2e
Merge pull request #2084 from kimagure/unmount-comp-error
...
Error when unmountComponentAtNode receives non-node
2014-10-23 12:53:40 -07:00
Sebastian Markbåge
29bcda463e
Merge pull request #2387 from fabiomcosta/avoid_double_scrollread
...
avoid reading the scroll position twice
2014-10-23 12:51:23 -07:00
Sebastian Markbåge
b7cd3e7d1d
Merge pull request #2396 from sebmarkbage/classmodule
...
Move Class Creation Concerns into a ReactClass Module
2014-10-23 12:50:17 -07:00
Sebastian Markbage
7ce8c844bd
Hide ReactElement constructor
...
This prevents feature tests like:
var ReactElement = React.createElement(...).constructor;
if (element.constructor === ReactElement)
This is intentional so that we have the option to make these plain objects.
E.g. for direct inlining or replacing them with value types.
2014-10-23 12:08:14 -07:00
Sebastian Markbåge
4aee2a9c28
Merge pull request #2405 from sebmarkbage/hideelementconstructor
...
Hide ReactElement constructor
2014-10-23 12:06:16 -07:00
Paul O’Shannessy
8de03c47dd
Merge pull request #2397 from mjul/fix-gruntfile
...
Added missing semicolon after statement.
2014-10-23 12:01:55 -07:00
Sebastian Markbage
20af6b0a14
Hide ReactElement constructor
...
This prevents feature tests like:
var ReactElement = React.createElement(...).constructor;
if (element.constructor === ReactElement)
This is intentional so that we have the option to make these plain objects.
E.g. for direct inlining or replacing them with value types.
2014-10-23 10:53:57 -07:00
Martin Jul
994fc7d8a7
Merge remote-tracking branch 'upstream/master' into fix-gruntfile
2014-10-23 09:55:43 +02:00
Martin Jul
c9fb57feb3
Added missing semicolons identified by using grunt jshint:project.
2014-10-23 09:54:13 +02:00
Ben Alpert
32630cd8cf
Fix typo in 0.12 RC blog post
2014-10-23 00:45:33 -07:00
Sebastian Markbage
d9fe40e147
Move Class Creation Concerns to ReactClass
...
This moves logic responsible for class creation and mixins into
the ReactClass module. This currently creates a class that extends
the ReactCompositeBase but in the future, this will be decoupled as
ReactCompositeComponent will compose these classes.
This is just a cut/paste.
2014-10-22 21:25:20 -07:00
Sebastian Markbage
c7bb936566
Introduce React Class as an alias for Composite Component
...
This is in preparation for the separation of Composite Component internals
from the Class abstraction.
2014-10-22 18:35:10 -07:00
Lee Byron
d545238fd9
Merge pull request #2376 from leebyron/iterable
...
Allow iterables in traverseAllChildren
2014-10-22 18:18:08 -07:00
Ben Alpert
de1dacdb28
Refactor composite component update flow
...
Fixes #1392 .
Previously, ReactComponent.updateComponent set the new props and owner and updated the component's refs. Because it did the actual props assignment, it had to be called by ReactCompositeComponent between componentWillMount and componentDidMount, meaning that it was skipped if shouldComponentUpdate returned false. Now, updateComponent takes the old and new descriptors and only updates refs, allowing a subclass to call updateComponent at a convenient time (specifically, it can be before `this._descriptor` is updated if the subclass also overrides performUpdateIfNecessary).
The new update cycle for composites is:
- receiveComponent is called which stores `this._pendingDescriptor` and calls performUpdateIfNecessary directly or a state update is enqueued, in which case ReactUpdates will call performUpdateIfNecessary
- performUpdateIfNecessary ensures that an update is still pending (which might no longer be the case if an update is queued for a subcomponent that was updated through a parent's reconciliation) and calls updateComponent with the old and new descriptors
- updateComponent calls super to update refs, then calls componentWillReceiveProps (if applicable) and shouldComponentUpdate -- if shouldComponentUpdate returns false, `this._descriptor`, `this.props`, and `this.state` are updated and the update is skipped; else, _performComponentUpdate is called
- _performComponentUpdate calls componentWillUpdate and _updateRenderedComponent, and enqueues the componentDidUpdate call (in that order)
- _updateRenderedComponent calls render and updates the rendered component appropriately
For DOM components (essentially unchanged):
- receiveComponent is called which does a short-circuit check for descriptor equality and delegates to super (which stores `this._pendingDescriptor` and calls performUpdateIfNecessary)
- performUpdateIfNecessary (not overridden) sets new values for `this.props`, etc. and calls updateComponent
- updateComponent does the DOM property and children updates (some synchronously, some queued for the transaction close)
For text and ART components (unchanged):
- receiveComponent updates the DOM or ART directly based on the new props
- updateComponent is never called
Notable changes:
- When shouldComponentUpdate returns false, refs are still updated
- ReactDefaultPerf now includes lifecycle methods in component timings
- updateComponent's signature changed (technically this is part of the public API, though we've never documented it)
Test Plan: jest
2014-10-22 17:59:58 -07:00
Ben Alpert
9c2125599c
Add \n after <textarea> to fix missing linebreaks
...
Same for <pre> and <listing>. Browsers are crazy.
Test Plan: jest, verify in Chrome that starting textareas with a value starting with two newlines renders both newlines instead of one newline, as it did before.
2014-10-22 17:24:24 -07:00
Martin Jul
70fdd5a287
Added missing semicolon after statement.
2014-10-22 23:46:54 +02:00
Paul O’Shannessy
b78fe39b60
Bump version to 0.13.0-alpha
2014-10-22 14:19:54 -07:00
Paul O’Shannessy
5ffcec7552
Update travis-ci badge for 0.12-stable branch
2014-10-22 14:17:11 -07:00
Ben Alpert
5e2d926d65
Merge pull request #2372 from spicyj/docs012-1
...
Update docs to align with 0.12 better
2014-10-22 14:02:35 -07:00
Ben Alpert
52494f9d72
Update docs to align with 0.12 better
...
- Rename React.renderComponent -> React.render
- Remove most references to transferPropsTo
2014-10-22 14:01:54 -07:00
Paul O’Shannessy
85a98d4c8e
Merge pull request #2322 from zpao/update-licenses-docs-examples
...
Update docs/examples with licenses
2014-10-22 13:13:56 -07:00
Paul O’Shannessy
7dc0e3d746
Update licenses for docs and examples
...
Docs are now CC licensed
Examples are under a separate license
2014-10-22 12:35:08 -07:00
Lee Byron
c07ea0ba34
Allow iterables in traverseAllChildren
...
This lets you use any kind of iterable as a container of react child elements. It also preserves keys when possible if the iterable is keyed.
* Use an ES6 Map or Set to hold children.
* Use an Immutable-js collection to hold children.
* Use a function* which yields children.
Concretely, this removes the necessary conversion to JS objects if you're mapping over Immutable-js collections to get children, i.e.:
```
<div>
{myImmutable.map(val => <span>{val}</span>).toJS()
</div>
```
Now we can remove the `toJS()` and the intermediate allocation along with it.
This also cleans up the traverseAllChildrenImpl method.
2014-10-21 15:18:53 -07:00
Ben Alpert
631b6a097c
Merge pull request #2388 from spicyj/null-key
...
Support but warn on key={null}
2014-10-21 14:20:16 -07:00
Paul O’Shannessy
ac3e9b55e0
Merge pull request #2370 from chenglou/rm-school
...
[Docs] Remove most of @jsx
2014-10-21 14:11:22 -07:00
Ben Alpert
dd92786fb0
Support but warn on key={null}
...
Fixes #2386 .
Test Plan: jest
2014-10-20 17:19:48 -07:00
Sebastian Markbåge
2bdad81955
Merge pull request #2384 from sebmarkbage/deprecateisvalidclass
...
Deprecate isValidClass
2014-10-20 17:17:56 -07:00
Fabio M. Costa
dafaf1a42e
avoid reading the scroll position twice
2014-10-20 13:30:02 -07:00
Shripad K
edab4814da
Fix: Always return boolean from isNullComponentID
2014-10-21 00:43:04 +05:30
Cheng Lou
1b3b432d64
[Docs] Remove most of @jsx
...
I kept some places intact (search for @jsx) because they require other bigger changes:
- ref-01-top-level-api.md
- grunt/tasks/npm.js
- old blog posts (don't change those)
- examples/ folder, as they have their own package.json that rely on old dependencies (node-jsx, reactify) that haven't upgraded to 0.12
2014-10-20 14:44:07 -04:00
Paul O’Shannessy
be468c2c22
Merge pull request #2373 from genbit/docs-animation-props
...
Update 09.1-animation.md
2014-10-20 11:01:36 -07:00
Paul O’Shannessy
a94bfd7888
Merge pull request #2381 from shripadk/jsdoc-fix
...
Fix JSDoc tag in ReactElement.js
2014-10-20 10:56:46 -07:00
Sebastian Markbage
ef971014bc
Deprecate isValidClass
...
Fixes #2374
2014-10-19 23:55:57 -07:00
Shripad K
621bb09cd7
Fix JSDoc tag in ReactElement.js
2014-10-19 21:01:45 +05:30
Sergey Generalov
3031c6591e
Update 09.1-animation.md
...
Add note about ReactTransitionGroup, that any additional, user-defined, properties will be become properties of the rendered component.
And example how to render a `<ul>` with css class.
2014-10-17 20:18:45 -07:00
Ben Alpert
daf4182707
Merge pull request #2368 from spicyj/use-the-string
...
Fix warning message for using React.DOM.* as type
2014-10-17 12:01:17 -07:00
Christopher Chedeau
dec41bbbca
Merge pull request #2356 from vjeux/roundup_23
...
Community round-up #23
2014-10-17 07:58:40 -07:00
Christopher Chedeau
6470920125
Community round-up #23
2014-10-17 07:56:28 -07:00
Ben Alpert
810582d114
Fix warning message for using React.DOM.* as type
...
Previously, this said 'Use the string "function() { [native code] }" instead.'.
2014-10-16 18:22:37 -07:00
Paul O’Shannessy
56e84d8cf3
Merge pull request #2364 from zpao/0.12rc-blog-post
...
0.12 rc1 release materials
2014-10-16 15:34:11 -07:00
Paul O’Shannessy
aca264e399
0.12 rc1 release materials
...
* blog post
* starter kit
2014-10-16 15:31:52 -07:00
Paul O’Shannessy
2b4e35870b
v0.12.0-rc1
2014-10-16 14:56:50 -07:00
Sebastian Markbåge
22903a57e8
Merge pull request #2363 from sebmarkbage/assign
...
Use hasOwnProperty checks in Object.assign
2014-10-16 11:52:43 -07:00
Sebastian Markbage
25d63b43ef
Use hasOwnProperty checks in Object.assign
...
Because IE8 polyfills add enumerable properties, this doesn't play nicely.
So for IE8 compatibility we add this check. Slower though. :(
2014-10-16 11:49:50 -07:00
Sebastian Markbåge
828efb798a
Merge pull request #2350 from sebmarkbage/assign
...
Hide Object.assign polyfill behind a module
2014-10-16 09:29:01 -07:00
Sebastian Markbage
8210beeef4
Hide Object.assign polyfill behind a module
...
Because the JS community's polyfilling infrastructure sucks and we'll
have to fix it for them before we require this.
JSX spread uses React.__spread
(which might get special behavior for key/ref, not sure yet)
This never uses the native implementation and throws for prototype chains.
Once the native implementations are faster, we'll start using them.
2014-10-16 09:21:10 -07:00
Beau Smith
df36c258b3
Highlighted changed lines in examples
2014-10-15 23:01:05 -07:00
Paul O’Shannessy
5263f61c87
Merge pull request #2357 from jimjea/patch-1
...
Minor grammar change to Thinking in React
2014-10-15 17:01:57 -07:00
Jimmy Jea
43dbd29bb1
minor change to post
...
Hello,
I was just reading through your post and noticed a minor change. The sentence originally read, "It's scaled very well for us...". I thought it was a little unclear since it's can mean "it has" or "it is", which can make this sentence take on a whole different meaning.
2014-10-15 16:36:30 -07:00
Paul O’Shannessy
4d06df3153
Merge pull request #2359 from zpao/fix-blog-post
...
[docs] Move React Elements post to right place, fix typo
2014-10-15 16:22:36 -07:00
Paul O’Shannessy
dcbc64ac76
[docs] Move React Elements post to right place, fix typo
...
The URL already made its way around so we can't just break it. We might
want to just live with it instead of even doing this redirect.
2b225446c0 (commitcomment-8176218)
2014-10-15 16:10:03 -07:00
Paul O’Shannessy
e7f509d3a3
0.11.2 release materials
...
TODO: starter kit for cherry-pick to master
(cherry picked from commit 732ffad313 )
2014-10-15 15:55:12 -07:00
Paul O’Shannessy
bc672c8bc5
Merge pull request #2344 from ThomasCrvsr/master
...
Use React.createFactory in examples/basic/
2014-10-15 10:48:33 -07:00
Ben Alpert
b8229cc761
Fix typo in blog post
2014-10-15 10:09:23 -07:00
ThomasCrvsr
e3734e2b43
#2315 : Use of React.createFactory in example basic/
2014-10-15 09:20:25 +02:00
Paul O’Shannessy
efc7829e91
Merge pull request #2330 from alexeyraspopov/patch-1
...
use function composition instead of mutable state
2014-10-14 23:48:55 -07:00
Paul O’Shannessy
7853affd4f
Merge pull request #2343 from zpao/proptypes-deprecation
...
Update PropTypes for ReactElement & ReactNode
2014-10-14 23:23:57 -07:00
Paul O’Shannessy
58165dfbcd
Merge pull request #2349 from zpao/update-deps
...
Update npm dependencies, fix browserify task
2014-10-14 23:21:01 -07:00
Paul O’Shannessy
d03d49101b
browserify update
2014-10-14 22:40:28 -07:00
Paul O’Shannessy
770b579aa2
Update PropTypes for ReactElement & ReactNode
2014-10-14 21:35:48 -07:00
Paul O’Shannessy
67307ce850
Update dependencies, removed unused ones
...
Also picked up a bit of JSON reformatting, presumably from npm >= 2
Test plan: build, run tests
2014-10-14 16:18:20 -07:00
Paul O’Shannessy
2b225446c0
React Elements blog post
2014-10-14 10:59:15 -07:00
Paul O’Shannessy
27cbd71394
Merge pull request #2317 from zpao/npm-ship-merge
...
Ship merge, mergeInto, copyProperties to npm
2014-10-14 10:21:51 -07:00
ThomasCrvsr
4f1f8c0605
Use react.createElement in example in basic/
2014-10-14 10:18:00 +02:00
Paul O’Shannessy
b227837b0c
Ship merge to npm
...
People may have a bad time if they're depending on these but we can
delay that a little bit. Unless they're using directly and not
polyfilling Object.assign.
2014-10-13 14:07:39 -07:00
Paul O’Shannessy
4dcc1161fa
Update @emails in react-displayName-test
2014-10-13 12:56:02 -07:00
Sebastian Markbåge
3991d4de6b
Merge pull request #2337 from sebmarkbage/devtoolshook
...
Inject the runtime to a global instead of exposing internals
2014-10-13 12:30:15 -07:00
Sebastian Markbage
ce19af9d30
Inject the runtime to a global instead of exposing internals
...
See 673de20a4a
2014-10-13 11:59:23 -07:00
Alexey Raspopov
1db3ed0d6d
fix: var name
2014-10-12 16:06:53 +03:00
Alexey Raspopov
cc0e7d2a79
ballmer-peak: use composition instead of mutable state
2014-10-12 16:05:58 +03:00
Paul O’Shannessy
5d3b12bb3b
Merge pull request #2312 from zpao/license-update
...
Update Licenses
2014-10-10 16:58:45 -07:00
Paul O’Shannessy
dcf415c2b9
BSD + PATENTS
2014-10-10 13:34:07 -07:00
Paul O’Shannessy
3bbed150ab
Merge pull request #2139 from syranide/acceptcharset
...
Add form "acceptCharset" to HTMLDOMPropertyConfig
2014-10-10 12:40:13 -07:00
Sebastian Markbåge
eef9995093
Merge pull request #2313 from sebmarkbage/sanitizetags
...
Sanitize the string tag passed to DOM components
2014-10-10 12:33:45 -07:00
Paul O’Shannessy
31faa58c27
Merge pull request #2320 from zpao/jsxtransformer-no-docblock
...
JSXTransformer: don't look for docblock
2014-10-10 11:46:26 -07:00
Paul O’Shannessy
cf5fea4616
JSXTransformer: don't look for docblock
2014-10-10 11:45:52 -07:00
Paul O’Shannessy
0dccf64c67
Sync upstream modules
2014-10-10 10:40:18 -07:00
Paul O’Shannessy
5d127eaa49
Merge pull request #2316 from zpao/devtoolsmarker
...
Look for devtools global hook
2014-10-09 17:00:06 -07:00
Paul O’Shannessy
540731b7a8
Merge pull request #2002 from zpao/rename-renderComponent
...
React.renderComponent -> React.render
2014-10-09 16:41:37 -07:00
Paul O’Shannessy
1c86f5836a
Codemod deprecated API usage away
2014-10-09 16:41:03 -07:00
Paul O’Shannessy
9b1fa914fa
React.renderComponent -> React.render
...
Also rename all the associated render methods and adds deprecation
notices.
2014-10-09 16:41:03 -07:00
Sebastian Markbage
a4e923b7fc
Sanitize the string tag passed to DOM components
...
Because we're using innerHTML to generate DOM Elements, we need to make
sure that the tag is sane and doesn't try to do injection.
This wouldn't be an issue if we used document.createElement instead.
2014-10-09 13:55:29 -07:00
Paul O’Shannessy
436c6c2db7
Merge pull request #2310 from tmcw/list-require-attribute
...
Require list property to be accessed as an attribute
2014-10-09 11:29:59 -07:00
Paul O’Shannessy
6ddf8de5ae
Look for devtools global hook
...
It doesn't exist yet, but it could.
This also ensures we actually do our polyfill checks in *all* browsers,
not just Chrome.
2014-10-09 11:24:48 -07:00
Sebastian Markbåge
36b091bc44
Merge pull request #2308 from sebmarkbage/dropdocblock
...
Drop the @jsx docblock from unit tests
2014-10-08 15:24:18 -07:00
Tom MacWright
688f64c5c8
Require list property to be accessed as an attribute
2014-10-08 17:49:05 -04:00
Andreas Svensson
70a7506bb9
Add form "acceptCharset" to HTMLDOMPropertyConfig
2014-10-08 22:45:33 +02:00
Paul O’Shannessy
18209a1112
Merge pull request #2304 from zpao/rm-server-rendering-deprecation-notice
...
Update ReactServerRendering for the modern world
2014-10-08 13:09:01 -07:00
Paul O’Shannessy
8faca765e1
Update ReactServerRendering for the modern world
...
* ReactComponents aren't really the thing we need, ReactElements are
* Remove the deprecation notice that we've had in there for a long time
Test Plan: build, jest
2014-10-08 12:52:59 -07:00
Paul O’Shannessy
fe32477d97
Merge pull request #2306 from zpao/cleanup-textcomponent-dep
...
Remove ReactBrowserComponentMixin dependency from ReactTextComponent
2014-10-08 12:48:23 -07:00
Sebastian Markbage
348af57842
Drop the @jsx docblock from unit tests
...
This is no longer necessary in our transforms.
2014-10-08 12:46:45 -07:00
Sebastian Markbåge
85597bf3aa
Merge pull request #2303 from sebmarkbage/dropmerge
...
Use Object.assign instead of merge, mergeInto, mixInto and copyPropertie...
2014-10-08 12:10:08 -07:00
Sebastian Markbage
096360db03
Use Object.assign instead of merge, mergeInto, mixInto and copyProperties
...
This makes it easier to contribute without having to learn a bunch of
slightly different helpers and remember their slightly different
signatures and semantics.
We'll probably start using ES7 spread properties instead of merge in the
future when at least one more transpiler supports it.
2014-10-08 11:32:40 -07:00
Paul O’Shannessy
f2f4006ff6
Remove ReactBrowserComponent dependency from ReactTextComponent
...
It's no longer used as of #1598 , which just missed the require.
Test Plan: build, jest
2014-10-08 11:29:45 -07:00
Paul O’Shannessy
c0c90c0050
Merge pull request #2305 from sebmarkbage/missingrename
...
Rename ReactDescriptor followup
2014-10-08 10:54:57 -07:00
Sebastian Markbage
5541842284
Renamed ReactDescriptor-test
...
I forgot to rename the test.
2014-10-07 23:44:02 -07:00
Pedro Nauck
8a4b2763dc
change note comment about namespaced components
2014-10-08 01:41:48 -03:00
Justin Woo
9c8ddb3316
Error when unmountComponentAtNode receives non-node
2014-10-07 21:12:56 -04:00
Paul O’Shannessy
9ef2b4e5d9
Merge pull request #2252 from syranide/htmlmanifest
...
Add manifest to HTMLDOMPropertyConfig
2014-10-07 15:29:57 -07:00
Paul O’Shannessy
33d2b5e8ff
Merge pull request #2238 from syranide/noclassid
...
Remove superfluous classID from DOMAttributeNames
2014-10-07 15:26:19 -07:00
Paul O’Shannessy
8883d0f818
Merge pull request #2276 from spicyj/asap
...
Rename ReactUpdates.setImmediate to 'asap'
2014-10-07 14:27:00 -07:00
Sebastian Markbåge
f48954d8a3
Merge pull request #2300 from sebmarkbage/descriptorstoelements
...
Renamed Descriptor -> Element
2014-10-07 13:44:44 -07:00
Sebastian Markbage
8f1657bba6
Renamed Descriptor -> Element
...
We've decided on a new naming convention for ReactDescriptor. It's now
called ReactElement, which is a subset of the ReactNode union type.
2014-10-07 13:41:51 -07:00
Sebastian Markbage
7f9b1d18d1
Start warning when React.DOM.x is passed into JSX
...
React.DOM is becoming helper factories to generate ReactElements. They're not
classes. It will be ok to call them directly as functions, but not to use them
where a class is expected.
2014-10-07 10:49:18 -07:00
Sebastian Markbage
15a0c8920e
Don't use React.DOM
...
I grepped for uses of React.DOM. This is going to be a set of helper functions
to generate ReactElements without JSX.
They're not classes so they cannot be used where a React class is expected.
Since we always use JSX, we should have no internal use for these helpers.
We can use strings instead.
2014-10-07 10:49:18 -07:00
Sebastian Markbage
b2dbccf9a2
Rename lower case variables in JSX to upper case
...
We're trying to move to a convention where lower-case variables on JSX are always HTML/SVG tags rather than variables in scope. See:
http://fb.me/react-jsx-lower-case
Therefore, this diff renames existing uses to upper case variables.
This throws an error on all these files, so I manually go rename all the variables. I then run lint to ensure that the rename doesn't leave any undeclared variables.
2014-10-07 10:48:57 -07:00
Sebastian Markbage
c4658c1728
Update React JSX Transforms
...
* Extract JSXDOM into separate transform
* Rename lower case variables in JSX to upper case
* Drop React.DOM docblock, use string tags instead
2014-10-07 10:48:57 -07:00
Pedro Nauck
fd9ddab532
change the global variable to a new sample component
2014-10-07 13:06:16 -03:00
Pedro Nauck
748a4ef1b2
add a section at 'jsx-in-depth' talking about namespaced components
2014-10-07 03:09:24 -03:00
Sebastian Markbåge
1a1104f56f
Merge pull request #2287 from sebmarkbage/stringelements2
...
Use strings as the type for DOM elements
2014-10-03 10:49:31 -07:00
Sebastian Markbage
3aaccd2dc9
Use strings as the type for DOM elements
...
This makes ReactDOM a simple helper for creating ReactElements with the string tag as the type. The actual class is internal and created by instantiateReactComponent. Configurable using injection.
There's not a separate class for each tag. There's just a generic ReactDOMComponent which could take any tag name.
Invididual tags can be wrapped. When wrapping happens you can return the same tag again. If the wrapper returns the same string, then we fall back to the generic component. This avoids recursion in a single level wrapper.
2014-10-02 23:05:11 -07:00
Ben Alpert
a8fff93971
Rename ReactUpdates.setImmediate to 'asap'
...
Per https://github.com/facebook/react/pull/1554#issuecomment-57243842 .
Test Plan: jest
2014-09-29 17:37:13 -07:00
Paul O’Shannessy
35764c5ffb
[docs] Use subitem in new nav generation
...
(cherry picked from commit 995d0e588b )
2014-09-29 13:48:25 -07:00
Paul O’Shannessy
57de1b07d0
Merge pull request #2254 from jgable/spellingFix
...
Spelling fix for "Testing Flux Applications"
2014-09-26 23:11:42 -07:00
Paul O’Shannessy
3888b97433
Merge pull request #2219 from pablolmiranda/master
...
Creates a getMeasurementsSummaryMap in ReactDefaultPerf
2014-09-26 17:56:07 -07:00
Paul O’Shannessy
a37dcbb8e0
Merge pull request #2208 from wincent/typo-fix-03
...
Fix a comment typo
2014-09-26 17:55:10 -07:00
Paul O’Shannessy
0383534094
Merge pull request #2202 from syranide/noscroll
...
Remove non-attribute scrollLeft and scrollTop from HTMLDOMPropertyConfig
2014-09-26 17:54:49 -07:00
Paul O’Shannessy
778ca2f862
Merge pull request #1598 from syranide/nogettext
...
Un-mixin ReactBrowserComponentMixin from ReactTextComponent
2014-09-26 17:54:32 -07:00
Paul O’Shannessy
c14b3a1b13
Merge pull request #1520 from syranide/ediblechildren
...
Warn against contentEditable with children props
2014-09-26 17:54:24 -07:00
Jacob Gable
0b3c0ebced
Spelling fix
...
- Puting -> Putting
2014-09-26 12:42:58 -05:00
Andreas Svensson
3de80ec4ba
Add manifest to HTMLDOMPropertyConfig
2014-09-26 16:45:33 +02:00
fisherwebdev
65c1834059
Merge branch 'zpao-rm-flux-docs'
2014-09-26 07:05:02 -07:00
fisherwebdev
f45d753486
Merge pull request #2236 from zpao/rm-flux-docs
2014-09-26 07:03:37 -07:00
Paul O’Shannessy
6c19040d24
Point to Flux site for Flux docs
...
This doesn't actually remove the pages, just the main content. Sidebar
items now link offsite. The pages doesn't automatically redirect, but we
could do that if we really wanted.
Fixes #2229
2014-09-25 12:34:22 -07:00
Bill Fisher
ef327fcb23
Merge pull request #2240 from christianalfoni/patch-1
...
Update flux-todo-list.md
2014-09-25 08:33:02 -07:00
Bill Fisher
2f30b2648c
Merge pull request #2237 from markhovskiy/patch-1
...
fix typos in "Testing Flux Applications"
2014-09-25 08:29:13 -07:00
Christian Alfoni
1b6a3d5215
Update flux-todo-list.md
...
You have to instantiate a Dispatcher to use it, not just grab the prototype or it will fail when trying to grab instance properties like: this.$Dispatcher._callbacks.
2014-09-25 11:54:52 +02:00
Andreas Svensson
cac45631c3
Remove superfluous classID from DOMAttributeNames
2014-09-25 10:46:29 +02:00
Oleksii Markhovskyi
5493b63b44
fix typos
2014-09-25 09:54:35 +02:00
Paul O’Shannessy
4f27dc30ad
Merge pull request #2228 from XuefengWu/patch-1
...
add tip for the important jsx convention
2014-09-24 15:35:36 -07:00
Bill Fisher
6f54ed71da
Merge pull request #2234 from fisherwebdev/master
...
[blog] testing flux applications
2014-09-24 13:08:45 -07:00
fisherwebdev
9952a54026
[blog] testing flux applications
2014-09-24 12:35:39 -07:00
Pablo Lacerda de Miranda
792b84c94b
fixes ReactDefaultPerf.getMeasurementsSummaryMap format style
2014-09-23 18:50:18 -07:00
XuefengWu
b9f32a8295
Update getting-started.md
...
fix grammar
2014-09-24 08:26:10 +08:00
Paul O’Shannessy
67eeed601b
Merge pull request #2212 from Oleg24/patch-1
...
Improved readability by removing semicolon
2014-09-23 17:06:53 -07:00
Oleg
86287bffd4
Add space after ellipses
2014-09-23 17:01:23 -07:00
Paul O’Shannessy
7339f8b7b8
Merge pull request #2149 from imcotton/jsx-reduce-warning
...
Reduce unnecessary warning while including JSX transformer in browser
2014-09-23 13:34:10 -07:00
XuefengWu
f04d648888
Update getting-started.md
...
merge the warn and explain for the @jsx
2014-09-23 15:22:11 +08:00
Isaac Salier-Hellendag
e7299f6039
Prefer window.getSelection for IE
...
IE9+ supports `window.getSelection()` but `SelectEventPlugin` gives precedence to `document.selection` instead. `document.selection` is still available in later versions of IE, but the modern Selection object is preferable. Swap the two.
2014-09-22 16:56:22 -07:00
Paul O’Shannessy
176d47319a
Merge pull request #2225 from jesseskinner/patch-1
...
Fix inconsistency in mockComponent argument name
2014-09-22 14:42:38 -07:00
Paul O’Shannessy
9919734df3
Merge pull request #2180 from zpao/fix-2179
...
Reword Component API intro
2014-09-22 14:41:18 -07:00
Paul O’Shannessy
eafe786aef
Reword Component API intro
...
Fixes #2179
2014-09-22 14:40:22 -07:00
Paul O’Shannessy
bf0fe94561
Merge pull request #2209 from glenjamin/patch-2
...
[docs] Clarify wording on sub-tree reconciliation
2014-09-22 14:32:18 -07:00
Paul O’Shannessy
8cd460ce24
Move examples from the website to the wiki.
2014-09-22 14:29:39 -07:00
Andreas Svensson
14ba6ee788
Un-mixin ReactBrowserComponentMixin from ReactTextComponent
2014-09-22 23:28:26 +02:00
Paul O’Shannessy
7cf350a5a1
Merge pull request #2223 from cody/stripTypes
...
Add stripTypes option to npm docs
2014-09-22 13:38:37 -07:00
Paul O’Shannessy
97a41db82c
Merge pull request #2218 from fisherwebdev/master
...
Acknowledge ProjectMoon for allowing us to use the flux name on npm
2014-09-22 13:09:06 -07:00
XuefengWu
0ae09f4c70
add tip for the important jsx convention
...
I missed the convention and wast hours to figure out what's wrong.
Add this tip in the document for who would miss the importance comment.
2014-09-22 20:10:34 +08:00
fisherwebdev
0e4e7ea7e1
Acknowledge ProjectMoon for allowing us to use the flux name on npm
2014-09-21 21:10:39 -07:00
Jesse Skinner
3109082144
Fix inconsistency in mockComponent argument name
...
The second argument of mockComponent was listed as tagName, but referred to in the description as mockTagName. I changed the first one to mockTagName to be consistent.
2014-09-21 23:00:25 -04:00
Stefan Dombrowski
7597cfc5fb
Add stripTypes option to npm docs
2014-09-21 19:22:22 +02:00
Pablo Lacerda de Miranda
486c69b6de
extracts getMeasurementsSummaryMap from ReactDefaultPerf.printWasted
2014-09-19 16:03:41 -07:00
Oleg
d06018cbac
Improved readability by removing semicolon
...
The first sentence had an unnecessary semicolon which made the whole thing difficult to read. The new syntax is not only easier to read but also more exciting.
2014-09-18 21:34:47 -07:00
Paul O’Shannessy
9d7e3a7471
Merge pull request #2211 from jacobgreenleaf/master
...
Fix typo in documentation in Flux Todo List
2014-09-18 18:33:04 -07:00
Jacob Greenleaf
8882f19187
Fix typo in documentation in Flux Todo List
2014-09-18 18:30:57 -07:00
Glen Mailer
cf512bf60d
[docs] Clarify wording on sub-tree reconciliation
...
The previous wording could be interpreted to mean sub-trees moving from
within one sibling to within another, rather than the shuffling of siblings on
a single level as intended
2014-09-18 22:48:35 +01:00
Greg Hurrell
94eac0b8fa
Fix a comment typo
2014-09-18 09:47:23 -07:00
Andreas Svensson
802ad0bc00
Remove non-attribute scrollLeft and scrollTop from HTMLDOMPropertyConfig
2014-09-17 14:40:37 +02:00
Paul O’Shannessy
21f601964f
Merge pull request #1301 from markijbema/patch-1
...
Only stop if the transition on this element ended
2014-09-12 17:00:05 -07:00
Christopher Chedeau
aa25eb8e40
Update 2014-09-12-community-round-up-22.md
2014-09-12 11:34:29 -07:00
Christopher Chedeau
05cec04367
Merge pull request #2186 from vjeux/roundup_22
...
Community roundup #22
2014-09-12 11:06:25 -07:00
Christopher Chedeau
d53a365e77
Community roundup #22
2014-09-12 10:35:30 -07:00
Paul O’Shannessy
af485d928f
Merge pull request #2181 from zpao/move-onscroll-detection
...
Move onscroll detection
2014-09-11 15:59:11 -07:00
Paul O’Shannessy
584e6bd648
Ignore .module-cache from jest [skip ci]
...
I hit a case where running jest was including files from the module
cache. I don't think that should have happened, but this works.
2014-09-11 15:28:20 -07:00
Paul O’Shannessy
def41dfd8f
Move onscroll warning test
...
This moves it to the appropriate place to accomodate the move of the check.
2014-09-11 15:15:19 -07:00
Paul O’Shannessy
a10436d4ab
Merge pull request #2097 from fitzgen/explain-where-to-provide-key
...
Explain where to provide the key for dynamic children.
2014-09-11 14:14:55 -07:00
Paul O’Shannessy
6daf6d31f3
Merge pull request #2178 from benfoxall/patch-1
...
Docs grammar tweak
2014-09-11 10:36:32 -07:00
Ben Foxall
fe08888fbb
Less -> Fewer
...
bugs and bytes are countable, so should be fewer
2014-09-11 14:33:16 +01:00
Nick Fitzgerald
18874a6054
Explain where to provide the key for dynamic children.
2014-09-10 14:53:41 -07:00
Andrew Rasmussen
7ae8909504
Move IE8 onscroll check
...
Rather than checking if document.onscroll exists in EventPluginHub
(which is agnostic of the DOM) do it in ReactDOMComponent
2014-09-10 13:33:23 -07:00
Paul O’Shannessy
76d64812e1
Merge pull request #2170 from undernewmanagement/patch-1
...
Added extra explanation for require() statements
2014-09-10 13:21:47 -07:00
Sheraz
9e6c442df0
Updated small change with zuggestions from @zpao
2014-09-10 12:29:54 +02:00
Paul O’Shannessy
53be3905f8
Merge pull request #2167 from mhintz/patch-1
...
Update ref-03-component-specs.md
2014-09-09 16:00:39 -07:00
Paul O’Shannessy
99191046f9
Merge pull request #2113 from BinaryMuse/fix_numeric_properties
...
Fix DOMProperty bitmask checking
2014-09-09 15:26:38 -07:00
Paul O’Shannessy
0d66ea301e
Merge pull request #2165 from DJCordhose/patch-1
...
Update 09.5-clone-with-props.md
2014-09-09 09:41:51 -07:00
Mark Anderson
e8e50986c5
Added extra explanation for require() statements
2014-09-09 14:39:07 +02:00
Mark Hintz
95def7f829
Update ref-03-component-specs.md
...
Edit the description of componentDidMount() to make clear that the function is called only once during the lifecycle of the component, after only the initial render() call. The description is now similar to that for componentWillMount(). The existing wording does not make it clear that the function is called only after the initial render. (Granted, it is possible to infer this from descriptions of the component lifecycle found elsewhere in the documentation, but I think explicit is better than implicit in this case).
2014-09-09 11:50:13 +02:00
Oliver Zeigermann
8601a3c27d
Update 09.5-clone-with-props.md
2014-09-09 10:52:26 +02:00
Paul O’Shannessy
5d88ebbecb
Merge pull request #2144 from zertosh/master
...
Comment typo
2014-09-08 19:37:00 -07:00
Paul O’Shannessy
79ca0c7fd2
Merge pull request #1848 from fgnass/master
...
add picture element and related attributes
2014-09-08 16:23:39 -07:00
Paul O’Shannessy
f3c64704ad
Merge pull request #1988 from syranide/tacfix
...
Don't wrap values with ReactTextComponent in traverseAllChildren (cloneWithProps)
2014-09-08 15:36:26 -07:00
Paul O’Shannessy
61c42ccdee
Update Bootstrap example to 3.2.0
2014-09-08 14:32:19 -07:00
Isaac Salier-Hellendag
8c9a24983e
Remove calls to Range.detach
...
This method is a no-op, as demonstrated by console warnings in Chrome and https://developer.mozilla.org/en-US/docs/Web/API/range.detach .
Remove callsites.
Fixes #2142
2014-09-08 14:30:53 -07:00
Andreas Svensson
45f8837e35
Don't wrap values with ReactTextComponent in traverseAllChildren
2014-09-08 22:35:25 +02:00
Paul O’Shannessy
adb62c76e5
Merge pull request #2158 from Daniel15/htmltojsx-move
...
Move htmltojsx.js to React-Magic project.
2014-09-07 18:52:37 -07:00
Daniel Lo Nigro
6ceb47e8bf
console.warn when html-jsx-lib.js is loaded
2014-09-07 15:20:42 -07:00
Paul O’Shannessy
4398879c2e
Merge pull request #2155 from rickbeerendonk/patch-1
...
Update video.md with Forward JS 2014 talk
2014-09-07 14:31:03 -07:00
Cheng Lou
90d1aeb1c3
Merge pull request #2156 from simonwelsh/patch-1
...
Correct highlighted block
2014-09-07 14:51:27 -04:00
Daniel Lo Nigro
1d1b6ed07a
Move htmltojsx.js to React-Magic project.
...
The HTMLtoJSX file is really a part of the React-Magic project, and should belong there rather than here:
- It doesn't really follow the release cycle of React at all
- It is totally standalone with no dependency on React
- The only usage of this script is in React-Magic and on the HTML to JSX page on the React website (http://facebook.github.io/react/html-jsx.html )
I've hotlinked it from the Github site for that project since this was the easiest way to pull it in.
Due to the fact that Github Pages lacks redirects (among other basic web hosting functionality), I've replaced the `html-jsx-lib.js` file with a comment explaining where the file has moved to, just in case anyone was hotlinking it from the React site.
2014-09-06 22:51:52 -07:00
Simon Welsh
611abfbcb7
Correct highlighted block
2014-09-06 20:46:19 +10:00
Rick Beerendonk
34b4ed7316
Update video.md with Forward JS 2014 talk
...
Added "React and Flux: Building Applications with a Unidirectional Data Flow" by Bill Fisher and Jing Chen.
2014-09-06 11:33:36 +02:00
Paul O’Shannessy
ea76f9bf63
Merge pull request #2116 from spicyj/nl-jsx-spread
...
Add newline before JSX spread when appropriate
2014-09-05 14:34:54 -07:00
Paul O’Shannessy
6c8c70eea4
Merge pull request #2152 from RReverser/fix-pr-check
...
Fix check for commit ranges in racing PRs.
2014-09-05 14:13:33 -07:00
Paul O’Shannessy
0ad43aff5e
Merge pull request #2153 from jeffmo/jsx_strip_types
...
Add --strip-types flag to bin/jsx
2014-09-05 14:10:37 -07:00
jeffmo
808730df59
Add support for a --strip-types flag to bin/jsx
2014-09-05 16:28:46 -04:00
jeffmo
bcc291b591
Bump esprima + jstransform versions
2014-09-05 15:42:07 -04:00
Paul O’Shannessy
ce014a00a5
Merge pull request #2148 from nordstrom-innovation/docfix
...
corrected highlighted/updated line in tutorial example
2014-09-05 10:59:24 -07:00
Ingvar Stepanyan
3b2cd51fa5
Fix check for commit ranges in racing PRs.
...
See #1768 / #2000 for original issue.
See https://github.com/travis-ci/travis-ci/issues/1719#issuecomment-51705110 for problem description and origin of this fix.
This is still a temporary fix until travis-ci/travis-core#383 is merged.
2014-09-05 15:45:21 +03:00
Paul O’Shannessy
b36c9f6638
Merge pull request #2147 from naman34/patch-2
...
added the missing **
2014-09-04 16:26:35 -07:00
Cotton Hou
6294d7aacc
Reduce unnecessary warning while including JSX transformer in browser
2014-09-05 07:15:39 +08:00
jon madison
3e59977046
corrected highlighted/updated line in tutorial example
2014-09-04 16:07:34 -07:00
Nick Merwin
610b75a5b6
Update Like button example verbiage
...
Changes text "You unlike this" to "You liked this". Makes a bit more grammatical sense.
Closes #2146 .
2014-09-04 15:21:27 -07:00
Naman Goel
815f267700
added the missing **
...
Missed it the last time. Apologies.
2014-09-05 03:21:30 +05:30
Andres Suarez
4c2f124aa8
Comment typo
2014-09-04 12:00:43 -04:00
Andreas Svensson
05fa75d395
IE8 does not have a setter for property "enctype"
2014-09-04 12:11:01 +02:00
Paul O’Shannessy
00fe66ddec
Merge pull request #2106 from subtleGradient/subtleGradient/improve-ReactPerf-debugging
...
Improve debugging for methods using ReactPerf
2014-09-03 17:46:49 -07:00
Paul O’Shannessy
c707c2568e
JSX spec blog post
2014-09-03 15:37:08 -07:00
Paul O’Shannessy
1854e8a912
Merge pull request #2033 from pekim/master
...
Add support for <dialog> tag.
2014-09-03 14:47:41 -07:00
Paul O’Shannessy
9a89edbb22
Fix broken link in animation docs
...
Missed in #2068
2014-09-03 11:59:14 -07:00
Paul O’Shannessy
073e1186d7
Merge pull request #2120 from zpao/svg-logo
...
[docs] SVG logo
2014-09-02 14:05:05 -07:00
Paul O’Shannessy
c406534c26
Merge pull request #2124 from Daniel15/htmltojsx-fixes
...
Small tweaks to HTML to JSX page
2014-09-02 14:03:21 -07:00
Paul O’Shannessy
f678591ad6
Merge pull request #2101 from jeffchan/patch-1
...
Fix typo in ReactDefaultPerfAnalysis comment
2014-09-02 11:57:45 -07:00
Brandon Tilley
0e28f5e6d7
Fix DOMProperty bitmask checking
2014-09-02 06:53:58 -07:00
Daniel Lo Nigro
e11b4078bc
Small tweaks to HTML to JSX page:
...
- Remove "Compiled JS" tab since it doesn't make sense
- Relabelled editor to "Live HTML Editor" rather than "Live JSX Editor"
2014-08-31 21:48:10 -07:00
Mike D Pilsbury
ffa0447177
Add support for <dialog> tag's open attribute.
2014-08-31 12:43:32 +01:00
Paul O’Shannessy
820210fd9e
Merge pull request #2091 from julen/docs/LinkedState
...
Docs: renamed input's state to `inputValue`
2014-08-30 17:25:49 -07:00
Paul O’Shannessy
9f802e7703
Merge pull request #2075 from IvanVergiliev/patch-1
...
Add 2048-react to open-source demos
2014-08-30 17:24:11 -07:00
Paul O’Shannessy
11a96fd8ce
Merge pull request #2119 from naman34/patch-1
...
added production example
2014-08-30 16:08:58 -07:00
Paul O’Shannessy
9a1236790b
SVG logo
...
I traced the current logo in Illustrator to get a good version. And with
SVG we don't need any 2x magic because it's already vector. I should
probably care about IE8, but I don't.
2014-08-30 16:03:49 -07:00
Naman Goel
3c74626a70
added production example
...
Addition note: Scribbler.co uses an infinite.js/UITableView like rendering pattern with animations which is only possible because of React.
2014-08-31 03:26:08 +05:30
Paul O’Shannessy
59324ab6d5
Merge pull request #2117 from spicyj/jest-vendor
...
Include vendor/ when running jest tests
2014-08-30 12:55:20 -07:00
Paul O’Shannessy
87cbde0a40
Merge pull request #2118 from spicyj/es7-spread
...
Enable ES7 spread transform when using --harmony
2014-08-30 12:54:58 -07:00
Ben Alpert
9f4ae415e2
Enable ES7 spread transform when using --harmony
...
Test Plan: `echo "var o = {...x};" | bin/jsx --harmony` outputs `var o = Object.assign({},x);`.
2014-08-30 01:10:21 -07:00
Ben Alpert
1ba022b1ea
Include vendor/ when running jest tests
...
Now the two transform tests get run alongside the React core tests.
Test Plan: jest
2014-08-30 01:08:57 -07:00
Ben Alpert
cc9735f889
Add newline before JSX spread when appropriate
...
Previously, we were losing the newline before a JSX spread attribute which would cause the lines to not match up; this fixes the problem.
2014-08-30 01:04:19 -07:00
Sebastian Markbage
4af98990db
Bumping version to help filtering.
2014-08-29 14:35:22 -07:00
Sebastian Markbage
63046277e4
Bumping version to help filtering.
2014-08-29 14:35:12 -07:00
Sebastian Markbage
bad1b7c41a
Start warning for JSX on plain functions
...
Let's also bump the version number for the log so that we can start filtering
out the other logs.
2014-08-29 14:35:07 -07:00
Sebastian Markbage
3c6c437d07
Don't transfer props to mocked empty component
...
We currently automatically render empty components in place of mocks. However,
we were accidentally transferring the props from the mocked descriptor to the
empty component placeholder. Even children.
This change just cleans that up and should only affect unit tests.
2014-08-29 14:35:01 -07:00
Sebastian Markbage
f5a0d667a5
Add version to legacy factory monitoring
2014-08-29 14:34:58 -07:00
Miorel Palii
335e91df71
Fix console warning in LegacyImmutableObject
...
It does check `hasOwnProperty`, but *after* accessing the field and therefore triggering enumerable getters in modified prototypes.
2014-08-29 14:32:50 -07:00
Ben Alpert
944f49c264
Merge pull request #2080 from fisherwebdev/master
...
[docs] Update Flux TodoMVC Tutorial
2014-08-28 12:11:28 -07:00
Thomas Aylott
755cc9671f
Combine displayName using underscore
2014-08-28 14:58:59 -04:00
Thomas Aylott
a6116b31e5
Improve debugging for methods using ReactPerf
2014-08-28 13:49:51 -04:00
Jeff Chan
ef9c9c81d0
Fix typo
2014-08-27 21:17:10 -07:00
Cheng Lou
74ff6fb6b8
Merge pull request #2039 from crm416/return-false
...
Deprecate 'return false' in event handlers
2014-08-27 13:33:40 -07:00
Cheng Lou
95de877dce
Merge pull request #2036 from crm416/static-functions
...
Throw an error when functions on `statics` clash due to duplicate keys
2014-08-27 11:36:53 -07:00
Julen Ruiz Aizpuru
ca66baee83
Docs: renamed input's state to message
...
Readers might feel confused with the actual input's `value` attribute.
2014-08-27 13:02:00 +02:00
Ben Alpert
f7c7676a98
Merge pull request #2083 from chenglou/docs-retina-icon
...
[Docs] Make retina react logo work
2014-08-24 23:19:41 -07:00
Cheng Lou
2920473ea1
[Docs] Make retina react logo work
...
Bourbon now takes *_2x instead of *@2x.
2014-08-23 18:09:20 -07:00
Charles Marsh
eb36b57079
Use warning module
2014-08-23 09:46:32 +08:00
Cheng Lou
174e67564c
Merge pull request #2078 from michaelrp/patch-1
...
Including missing validation check
2014-08-22 11:36:47 -07:00
fisherwebdev
9fe36e591b
[docs] remove redundant paragraph
2014-08-22 09:50:05 -07:00
fisherwebdev
149cadd664
[docs] fix nits
2014-08-22 09:46:34 -07:00
Michael Randers-Pehrson
c999785fa0
Adding e.preventDefault() to handleSubmit,
...
Also added plain `return`, updated text.
2014-08-22 08:27:23 -04:00
fisherwebdev
bc4d935cb0
[docs] Update Flux TodoMVC Tutorial
2014-08-22 02:21:04 -07:00
Charles Marsh
979a93a70a
Removed monitorCodeUse call
2014-08-22 13:09:38 +08:00
Michael Randers-Pehrson
6c926094c3
Including missing validation check
...
The validation check was removed from the update to the CommentForm handleSubmit function.
2014-08-21 23:00:05 -04:00
Felix Gnass
942d358ace
use attribute for media, srcSet and sizes
2014-08-22 00:37:32 +02:00
Charles Marsh
f01246d6bb
Indentation for eventHandlerName
2014-08-21 09:13:35 +08:00
Cheng Lou
72e690ecfb
Merge pull request #2037 from crm416/duplicate-key
...
More informative error message for mergeObjectsWithNoDuplicateKeys
2014-08-20 17:27:07 -07:00
Cheng Lou
b8ab95aaa7
Merge pull request #2054 from chenglou/accum
...
[RFC] Use `accumulateInto` to save even more allocation
2014-08-20 13:36:45 -07:00
Cheng Lou
48e901f8ae
[RFC] Use accumulateInto to save even more allocation
...
Trying to make the event a bit more performant for events.
Feel free to reject this because the API inevitably isn't great. It's good for perf though, and since we're only using `accumulate` in very restrained places, I think we're fine.
`accumulateInto` is `accumulate` that mutates more and allocates less. I kept `accumulate` in case we want that in the future.
2014-08-20 13:10:50 -07:00
Paul O’Shannessy
ef47bb753c
Merge pull request #2076 from whatasunnyday/master
...
Add example to if else in JSX.
2014-08-20 12:45:04 -07:00
Sunny Juneja
b9cf0d2bdd
Add example to if else in JSX.
2014-08-20 12:29:21 -07:00
Paul O’Shannessy
4d9a2c4a29
Make npm run-script jest available
...
This is slightly shorter than typing `./node_modules/.bin/jest`.
2014-08-20 11:48:01 -07:00
Paul O’Shannessy
417678310c
Update Object.assign polyfill
...
The spec changed to allow null & undefined sources without throwing.
Now our code depends on this new behavior. The only browser that
implements Object.assign has also updated its native implementation to
this behavior (Firefox Nightly).
2014-08-20 11:44:24 -07:00
IvanVergiliev
f627ddfb74
Add 2048-react to open-source demos
...
Nothing too complicated, but I think it could be a fun beginner demo.
2014-08-20 15:17:27 +03:00
Paul O’Shannessy
2058ad99be
Sync out latest JSX transforms
...
The biggest change: instead of calling functions directly, we now use
React.createElement to wrap.
The other big change: this removes the need for the @jsx pragma.
Instead we'll parse everything, assume React is in scope,
and only look for the actual XJS parts in the AST (as opposed to only
runing the transform when @jsx was specified in the docblock).
Note: this is actually a series of commits internally and should have
been syned out in pieces over the past several weeks.
2014-08-20 00:27:38 -07:00
Sebastian Markbage
aae31ae24c
ReactMount calls a legacy factory use createDescriptor instead
...
This fixes some log spew since this pattern is deprecated. This doesn't use
the validator in the descriptor creation so there's no prop type checks here.
I guess that's fine because we still have the second prop type checks.
We need to use ReactLegacyDescriptor because the constructor here will be a
legacy factory that we need to unwrap.
constructAndRenderComponent should be deprecated.
2014-08-20 00:15:43 -07:00
Sebastian Markbage
5c51f2fe46
Check if a function has a prototype first
...
Because somehow someone used a prototype less function with JSX.
2014-08-20 00:15:32 -07:00
Sebastian Markbage
68b7b82145
Start warning when calling a legacy factory
...
Let's start warning when a legacy factory is called as a plain function call.
2014-08-20 00:15:11 -07:00
Sebastian Markbage
989e6b618e
Drop usage of plain functions to create descriptors
...
Replace plain function calls to legacy factories with createFactory or
createElement. For ReactDOMComponents the type should be replaced with
strings.
Because we don't have easy access to ReactLegacyDescriptor from within
React, we need to use the .type property to extract the real class.
This will go away later and is covered by unit tests.
2014-08-20 00:14:59 -07:00
Sebastian Markbage
c901b1005e
Make createDescriptor return a descriptor for components
...
This moves all logic around legacy descriptors to ReactLegacyDescriptor. This
is responsible for the layer that knows that createClass exports a legacy
factory. When passed one of these classes, it unwraps it to be a real class.
If it is passed a non legacy factory, it is assumed to be a non-react component
that needs to be invoked as a plain function.
The semantic change is that a descriptor is now always returned if passed a
legacy factory. Even if that factory is a mock. A mock would previously return
undefined.
For mocks, I treat the factory as the authoritative function. I call it to extract
the instance or fill it with an empty component placeholder.
Additionally, I make the classes take props as the first argument to the
constructor. This is what the new class system will do.
We currently need to set up some internals by calling the internal construct
method. Instead of doing that automatically in the constructor, I now move that
to a second pass so that mocks can get the plain props.
This means that we can assert that a mock has been called once it's mounted
with it's final props. Instead of the descriptor factory being called.
2014-08-20 00:14:32 -07:00
Paul O’Shannessy
182379305a
Update vendored modules
2014-08-20 00:14:28 -07:00
Cheng Lou
25c9d6d578
Merge pull request #2068 from ChrisSki/patch-1
...
Update 09.1-animation.md
2014-08-19 18:10:31 -07:00
Chris Sciolla
99ed64387d
Update 09.1-animation.md
2014-08-19 20:59:13 -04:00
Charles Marsh
0ecc7e5a7f
Look on __reactBoundContext for displayName
2014-08-20 08:44:33 +08:00
Chris Sciolla
65e1938708
Update 09.1-animation.md
...
The reason I chose to submit this is because it was initially unclear from the docs that the transition group needed to already be mounted in order for it to work properly.
2014-08-19 15:11:07 -04:00
Charles Marsh
cf45a40bb8
More info in monitorCodeUse call
2014-08-18 22:57:02 -04:00
Josh Duck
5b4e2be867
Iterate over expectedFeatures correctly
...
This fails if Array.prototype is extended.
2014-08-18 18:18:05 -07:00
Paul O’Shannessy
326be2faa6
Merge pull request #2053 from zpao/jsx-transformer-optional-sourcemaps
...
Don't force sourcemaps on for JSXTransformer APIs
2014-08-18 18:10:57 -07:00
Paul O’Shannessy
ea17506f6a
Merge pull request #2062 from dmitriiabramov/patch-1
...
remove doubled whitespace chars in jsDoc
2014-08-18 16:54:06 -07:00
Paul O’Shannessy
32d3f79dc5
Upgrade Commoner
...
It no longer parses @providesModule directives by default.
Fixes #1145
2014-08-18 15:12:39 -07:00
Dmitrii Abramov
d50278997c
remove doubled whitespace chars in jsDoc
2014-08-18 14:26:26 -07:00
Cheng Lou
a43d8c588b
Fix bad merge from 04c9820694
...
Didn't sync out correctly.
2014-08-18 10:37:18 -07:00
Cheng Lou
196030aeb5
Merge pull request #2058 from chantastic/patch-2
...
docs(flux-todo-list): fix TodoStore syntax
2014-08-17 19:52:54 -07:00
Michael Chan
aaeb107e00
docs(flux-todo-list): fix TodoStore syntax
...
Add missing semicolon behind `TodoStore#addChangeListener'
2014-08-17 19:37:10 -07:00
Lee Byron
04c9820694
Merge pull request #1601 from gaearon/apply-component-and-mixin-spec-deterministically
...
Apply component and mixins specs deterministically
2014-08-15 18:08:03 -07:00
Paul O’Shannessy
d9a053d287
Don't force sourcemaps on for JSXTransformer APIs
...
In case somebody doesn't want sourcemaps (eg, react-rails) or r.js
2014-08-15 17:51:41 -07:00
Charles Marsh
429650a750
Test for both true and false
2014-08-15 19:47:36 -04:00
Charles Marsh
c5be746fda
Fixed style and comment nits
2014-08-15 11:52:22 -04:00
Paul O’Shannessy
d970dc45d9
Merge pull request #1826 from syranide/jsxasync
...
JSXTransformer respects async attribute
2014-08-14 15:13:04 -07:00
Paul O’Shannessy
f479cffdbb
Merge pull request #2042 from zpao/update-recast
...
Update recast to 0.6, update constants.js
2014-08-14 13:59:45 -07:00
Paul O’Shannessy
d7f21d760b
Update recast to 0.6, update constants.js
...
I dropped the part of constants.js that we weren't using (namely the
part where we insert constants) but left it open to do that. It should
be trivial, we just aren't using it.
Fixes #1824
2014-08-14 11:14:20 -07:00
Charles Marsh
a195d3ea1f
Re-add with warning and monitorCodeUse
2014-08-14 10:43:00 -04:00
Andreas Svensson
079400c2a6
JSXTransformer respects async attribute
...
Conflicts:
vendor/browser-transforms.js
2014-08-14 10:00:27 +02:00
Charles Marsh
45f8b52135
Deprecate 'return false' in event handlers
2014-08-13 22:37:41 -04:00
Ben Alpert
5ca9e193ee
Merge pull request #2038 from zpao/update-testutil-docs
...
TestUtils docs: isComponentOfType -> isDescriptorOfType
2014-08-13 19:29:16 -07:00
Paul O’Shannessy
aa959dcb97
TestUtils docs: isComponentOfType -> isDescriptorOfType
...
Fixes #1946
2014-08-13 19:23:47 -07:00
Charles Marsh
a70db003db
Throw if a reserved property is defined in 'statics'
2014-08-13 21:34:49 -04:00
Paul O’Shannessy
5df9b90c3d
Merge pull request #1832 from rayqian/master
...
Add chinese translation for 02-displaying-data.md
2014-08-13 17:38:44 -07:00
Paul O’Shannessy
d6f5ff0288
Merge pull request #1867 from WickyNilliams/patch-1
...
Add note about key prop being excluded by cloneWithProps
2014-08-13 17:36:48 -07:00
Paul O’Shannessy
f30e5b5a72
Merge pull request #2007 from janhancic/better-docs-for-select-multiple
...
Add a 'note' about passing arrays into the `value` attribute
2014-08-13 17:27:26 -07:00
Paul O’Shannessy
91cdd5af24
Merge pull request #2010 from nw/patch-1
...
Update ref-01-top-level-api.md
2014-08-13 17:26:51 -07:00
Ben Alpert
f982387c6e
[docs] Move "| React" to end of OG title
...
For consistency!
2014-08-13 16:30:43 -07:00
Paul O’Shannessy
6d740448e2
[docs] Move "| React" to end of page title
...
Looks better in search results
2014-08-13 16:28:50 -07:00
Paul O’Shannessy
eb3ea3f2df
Move batchedUpdated to React.addons
...
This is a followup to #1060 , where I did not read closely enough before
merging.
2014-08-13 15:40:40 -07:00
Paul O’Shannessy
938bcbecd5
Merge pull request #1060 from spicyj/gh-906
...
Add React.batchedUpdates to public API
2014-08-13 15:37:43 -07:00
Paul O’Shannessy
ec6653aa56
Merge pull request #1952 from slorber/master
...
Update 09.2-form-input-binding-sugar.md -> document checkedLink
2014-08-13 15:32:27 -07:00
Charles Marsh
87607045e4
Abbreviated error message
2014-08-13 18:25:53 -04:00
Paul O’Shannessy
16dfaca66a
Merge pull request #2035 from zpao/jekyll-update
...
[Docs] Update Jekyll + more
2014-08-13 15:23:37 -07:00
Charles Marsh
dcdc35fab6
More informative error message for mergeObjectsWithNoDuplicateKeys
2014-08-13 16:59:40 -04:00
Charles Marsh
71e49adf35
Throw an error when functions on statics clash due to duplicate keys
2014-08-13 16:33:57 -04:00
Karpich Dmitry
a185f09943
Add classid property for <object/> tag
...
This properties needed to work with ActiveX objects in IE, created by
<object/> tag.
Closes #1526
2014-08-13 13:28:19 -07:00
Paul O’Shannessy
fdf97f42f7
Update README to use bundle exec *
...
Also, referenced rake release task
2014-08-13 12:38:09 -07:00
Paul O’Shannessy
2cbf609856
Autogenerate acknowledgements
2014-08-13 12:38:09 -07:00
Paul O’Shannessy
51df0efe34
Use jekyll-redirect-from instead of our other redirect method
2014-08-13 12:38:09 -07:00
Paul O’Shannessy
4c7cd13ab3
Set default layout for docs
2014-08-13 11:40:14 -07:00
Paul O’Shannessy
03df215bd2
Default to layout: post for posts
...
Just a little less boilerplate. This also removes a bit of trailing
whitespace because it shouldn't have been there.
2014-08-13 11:37:19 -07:00
Paul O’Shannessy
b58b9d0b79
Update Bourbon files (4.0.2)
2014-08-13 11:20:00 -07:00
Paul O’Shannessy
8dbdd53e46
Reorder _config for sanity
2014-08-13 11:14:24 -07:00
Paul O’Shannessy
77fa3f35b5
Minimal updates for Jekyll 2.0
2014-08-13 11:10:40 -07:00
Paul O’Shannessy
ed27c89748
Merge pull request #2026 from spicyj/likely-a-bug-in-the-framework
...
Improve Danger error message to not blame React
2014-08-12 13:23:29 -07:00
Mike D Pilsbury
f035949e73
Add support for <dialog> tag.
...
fixes #2017
2014-08-12 19:58:10 +01:00
Ben Alpert
26aff787e7
Merge pull request #2028 from andrezsanchez/patch-1
...
Fix typo
2014-08-11 20:09:28 -07:00
Andre Z Sanchez
6f49827c12
Fix typo
2014-08-11 22:57:33 -04:00
Ben Alpert
e2ac2f326c
Improve Danger error message to not blame React
2014-08-11 15:18:07 -07:00
Nathan White
c141a8581f
changed type info. added descriptor to descriptions
2014-08-11 15:44:21 -06:00
Ben Alpert
13e60298e1
Merge pull request #2025 from zpao/rm-flux-todomvc
...
Remove TodoMVC flux example
2014-08-11 13:37:23 -07:00
Paul O’Shannessy
1033c4805f
Remove TodoMVC flux example
...
It lives at https://github.com/facebook/flux/tree/master/examples/flux-todomvc now.
2014-08-11 13:02:12 -07:00
Ben Alpert
f7af58fa0c
<noscript /> -> null in todomvc-flux Footer
2014-08-11 12:26:10 -07:00
Paul O’Shannessy
986f5a1a07
Merge pull request #1662 from gaearon/warn-when-using-hyphenated-style-names
...
Warn when using hyphenated style property names
Closes #1662
Conflicts:
src/browser/ui/dom/CSSPropertyOperations.js
2014-08-11 10:18:08 -07:00
Paul O’Shannessy
0e5316f12f
Merge pull request #2021 from adammark/patch-1
...
Close <section> tag in sample markup
2014-08-11 10:07:36 -07:00
Adam Mark
8642262aad
Copy edit (fix grammar)
2014-08-11 12:19:08 -04:00
Adam Mark
77d7b4928e
Close <section> tag in sample markup
2014-08-11 12:13:04 -04:00
Cheng Lou
82da739d9e
Merge pull request #2018 from samselikoff/patch-2
...
Clarify section introducing callbacks
2014-08-10 13:59:20 -07:00
Sam Selikoff
90888debd0
Clarify section introducing callbacks
2014-08-10 16:47:06 -04:00
Cheng Lou
68930ad4a6
Merge pull request #2016 from samselikoff/patch-1
...
Clarify section introducing `props`
2014-08-09 17:54:15 -07:00
Sam Selikoff
255f238cee
Clarify section introducing props
2014-08-09 19:24:40 -04:00
Paul O’Shannessy
c506b44173
Merge pull request #2000 from RReverser/stop-travis-on-docs
...
Cancelling Travis build on commits with docs updates only.
2014-08-08 13:25:23 -07:00
Nathan White
c53fb8f405
Update ref-01-top-level-api.md
...
Added docs for `React.isValidClass` and `React.isValidComponent`.
Still missing top level api:
* `constructAndRenderComponent`
* `constructAndRenderComponentById`
* `withContext`
2014-08-07 12:09:45 -06:00
Jan Hancic
1db8756b8f
Remove quotes around the value attribute
2014-08-07 09:22:46 +01:00
Jan Hancic
b25e4368bb
Add ={true} so it's aligned with recommended practises
2014-08-07 08:10:55 +01:00
Josh Duck
f71455fb31
Fire onBeforeUpdate for space on Android
...
We deliberately skip the event, but Android Chrome
doesn't fire the keypress, so this is wrong.
2014-08-06 16:41:56 -07:00
Sebastian Markbage
036d751397
Add createElement alias for createDescriptor
2014-08-06 16:41:47 -07:00
Jan Hancic
b016400bb1
Add a 'note' about passing arrays into the value attribute
...
This is for #1700
2014-08-06 23:45:37 +01:00
Cheng Lou
aaa8a5ff50
Merge pull request #1990 from syranide/rmctest
...
Simplified and improved test-cases for ReactMultiChildText-test
2014-08-06 11:20:59 -07:00
Cheng Lou
12ab5e8345
Merge pull request #1974 from jstoja/jquery-tutorial
...
jQuery note in tutorial
2014-08-05 22:10:58 -07:00
Andreas Svensson
41d5cee44e
Simplified and improved test-cases for ReactMultiChildText-test
2014-08-05 23:40:11 +02:00
Ingvar Stepanyan
233af7e2df
Cancelling Travis build on commits with docs updates only.
...
Currently recognized patterns:
* any Markdown files (*.md)
* any files in docs or examples directories.
Closes facebook/react#1768 .
2014-08-06 00:39:55 +03:00
Ben Alpert
e39a28c175
[docs] Add parens to defeat ASI in example
...
Fixes #1996 .
2014-08-04 21:48:24 -07:00
Cheng Lou
2d250d44a5
Merge pull request #1993 from spicyj/devtools-warning-2
...
Slightly more considerate devtools warning
2014-08-04 14:25:16 -07:00
Ben Alpert
3045291417
Slightly more considerate devtools warning
...
See #953 .
2014-08-04 11:16:51 -07:00
Ben Alpert
e2dad02ef2
Wording tweaks to reconciliation docs
2014-08-04 08:36:49 -07:00
Ben Alpert
716742dcd7
Merge pull request #1972 from cutbko/patch-1
...
Update ref-08-reconciliation.md
2014-08-04 08:35:22 -07:00
Julien Bordellier
46c0bbfb11
Using the markdown's quote syntax and explaining why use include jQuery
2014-08-04 10:42:55 +02:00
Christopher Chedeau
226f45b24d
typo "refere" -> "reference"
2014-08-03 18:53:18 +02:00
Christopher Chedeau
5805ab17ed
Merge pull request #1976 from vjeux/community_21
...
Community Roundup #21
2014-08-03 18:22:57 +02:00
Christopher Chedeau
ffef61e407
english + casing + 02 -> 03
2014-08-03 18:20:54 +02:00
Ben Alpert
320d72c735
Merge pull request #1985 from jimobrien/master
...
Fix typo in test utils documentation
2014-08-03 00:41:49 -07:00
Jim OBrien
0e7526e401
typo
2014-08-02 22:04:37 -07:00
Christopher Chedeau
cd25fe1ef3
Community Roundup #21
2014-08-02 14:44:57 +02:00
Julien Bordellier
5eca8d604f
Adding a note just below the jQuery inclusion in the tutorial to inform that jQuery is not mandatory.
...
It's linked with #603
2014-08-02 11:32:31 +02:00
cutbko
d0494ac85c
Update ref-08-reconciliation.md
2014-08-02 02:59:16 +03:00
Paul O’Shannessy
5d288deba5
Merge pull request #1956 from syranide/ffenter
...
Improve normalization of charCode, fix FF not reporting Enter
2014-07-31 15:11:09 -07:00
Andreas Svensson
b83076468d
Improve normalization of charCode, fix FF not reporting Enter
2014-07-31 22:00:23 +02:00
Paul O’Shannessy
ab2406ffec
Merge pull request #1885 from syranide/testinnerhtml
...
Use faster cached regexps for tests in setInnerHTML
2014-07-31 11:44:21 -07:00
Ben Alpert
3acb5f84b3
Merge pull request #1960 from julen/docs/setState
...
Docs: added note about setState() side-effects
2014-07-31 00:33:53 -07:00
Julen Ruiz Aizpuru
1219663e9a
Docs: added note about setState() side-effects
2014-07-31 09:31:01 +02:00
Paul O’Shannessy
db6e07e87d
Merge pull request #1827 from syranide/jsxstrict
...
JSXTransformer, stricter parsing of script type
2014-07-30 21:39:37 -07:00
Paul O’Shannessy
62a336f9ab
Update CONTRIBUTING.md
2014-07-30 13:09:23 -07:00
Vjeux
aed0931f9a
update background color for image
2014-07-30 21:09:17 +02:00
Vjeux
76c3d7c647
fix spurious )
2014-07-30 21:09:17 +02:00
Vjeux
9f5403b18c
Include image
2014-07-30 19:31:16 +02:00
Vjeux
10bcfdf1f7
Flux blog post about dispatcher
2014-07-30 19:12:21 +02:00
Paul O’Shannessy
61c8b2a6e8
Merge pull request #1961 from knuton/patch-1
...
Fix typo
2014-07-30 10:04:24 -07:00
Johannes Emerich
52143700e8
Fix typo
2014-07-30 15:38:19 +02:00
Sébastien Lorber
d0d15a3a3c
Update 09.2-form-input-binding-sugar.md -> better checkedLink documentation
2014-07-30 11:17:38 +02:00
Paul O’Shannessy
590e5057bc
Merge pull request #1759 from spicyj/gh-1698
...
Use setImmediate to defer value restoration
2014-07-29 20:15:59 -07:00
Paul O’Shannessy
0a1c5dad67
Merge pull request #1758 from spicyj/setimmediate
...
Add ReactUpdates.setImmediate for async callbacks
2014-07-29 20:15:31 -07:00
Paul O’Shannessy
45c719942e
Merge pull request #1854 from syranide/floatfix
...
cssFloat is only accessible as styleFloat on IE8
2014-07-29 13:00:20 -07:00
Sébastien Lorber
b9a0c27914
Update 09.2-form-input-binding-sugar.md
...
Add better explanation for 2-way data binding to checkboxes using `checkedLink`. As mentionned here: https://github.com/facebook/react/issues/1930
2014-07-29 16:14:27 +02:00
Andreas Svensson
ffafae5cfe
cssFloat is only accessible as styleFloat on IE8
2014-07-29 10:15:01 +02:00
Paul O’Shannessy
90df0ea8bd
Merge pull request #1951 from JedWatson/patch-1
...
Adding "Tutorial" label to Flux Todo List nav item
2014-07-28 21:57:16 -07:00
Jed Watson
bfd0a53d3e
Updating "Tutorial" label as per suggestion
2014-07-29 12:20:15 +10:00
Jed Watson
2e6ff6449b
Adding "Tutorial" label to Flux Todo List nav item
2014-07-29 10:54:22 +10:00
Christopher Chedeau
2822d63df2
Rename "Ice Lab studio" to "Icelab"
2014-07-28 11:48:25 +02:00
Christopher Chedeau
ba76ba8d4b
Merge pull request #1944 from shaneosullivan/patch-3
...
Fix small language nits
2014-07-28 11:46:55 +02:00
Ben Alpert
8cb2812cff
Merge pull request #1941 from divad12/animating-one-or-zero-items-docs
...
Clarify animating one or zero items in animation docs
2014-07-27 16:05:24 -07:00
Shane O'Sullivan
460ca72abb
Update 2014-07-28-community-roundup-20.md
2014-07-27 14:16:59 -07:00
Shane O'Sullivan
b606dac461
Fix small language nits
2014-07-27 13:44:47 -07:00
Ben Alpert
673e228af9
Merge pull request #1943 from shaneosullivan/patch-1
...
Fix typo for 'fundations'
2014-07-27 13:30:12 -07:00
Shane O'Sullivan
0c4b2728c8
Fix typo for 'fundations'
2014-07-27 13:29:12 -07:00
Ben Alpert
e30b60cc58
Wording tweaks to community roundup
2014-07-27 13:06:20 -07:00
Christopher Chedeau
88d0c81680
Merge pull request #1942 from LoukaN/roundup_20
...
Community Round-up #20
2014-07-27 14:19:55 +02:00
Vjeux
75ee7d05bb
Community Round-up #20
2014-07-27 13:55:20 +02:00
David Hu
721f397303
Clarify animating one or zero items in docs
...
When I first read these docs, it was not immediately clear to me that I could
use `React.addons.CSSTransitionGroup` to animate a single item coming into view,
or an item replacing an item already there. This was partly due to the example
which rendered a list of items.
This PR adds a blurb about being able to use
`React.addons.CSSTransitionGroup` with one or zero items, provides a code
example, and adds a note blockquote that a `key` attribute must always be
provided on each child of `React.addons.CSSTransitionGroup`. The latter point
was not immediately obvious from the original `TodoList` code example, since it
renders a list which would normally require `key` attributes anyway.
Test Plan:
- Refreshed `http://localhost:4000/react/docs/animation.html `, saw that the
docs additions rendered correctly.
- Example code not tested (it was extracted from working code).
2014-07-27 00:26:17 -07:00
Sebastian Markbage
c6b2687bbd
Partially revert React.createDescriptor
...
We still have some issues to work out when the type argument is a mock.
2014-07-25 16:48:10 -07:00
Paul O’Shannessy
d526456951
Delete ImmutableObject-test.js
...
Our syncing doesn't update these tests so just remove them.
2014-07-25 16:47:48 -07:00
Cheng Lou
aed2d86e7b
Merge pull request #1929 from zertosh/master
...
ReactTransitionChildMapping comment typo
2014-07-25 16:38:55 -07:00
Paul O’Shannessy
631705f31d
v0.11.1 release materials, update to 0.11.0 release materials
...
* 0.11.1 blog post, changelog
* Update to 0.11.0 post, changelog
* Update version in site, add starter kit
2014-07-25 12:59:56 -07:00
andres suarez
1961fecf2d
ReactTransitionChildMapping comment typo
2014-07-25 09:03:51 -04:00
Cheng Lou
af21aeb59f
Merge pull request #1924 from spicyj/autobind-bind
...
Use .bind when autobinding
2014-07-25 01:34:15 -07:00
Paul O’Shannessy
eb8f766005
[docs] increase base font-weight
...
Closes #1926
2014-07-24 21:01:20 -07:00
Cheng Lou
7f584f3a49
Merge pull request #1511 from syranide/strsidefx
...
HAS_SIDE_EFFECTS should compare by type-casting
2014-07-24 13:38:01 -07:00
Paul O’Shannessy
f76d4dd48f
Merge pull request #1770 from eins78/master
...
Also list <form> in error message as possible culprit
2014-07-24 12:53:19 -07:00
Ben Alpert
f1508c4937
Use .bind when autobinding
...
This eliminates all of the `boundMethod` frames from call stacks when debugging and as far as I know should behave the same otherwise.
Test Plan: jest
2014-07-24 12:11:19 -07:00
Andreas Svensson
3b94abcb3b
HAS_SIDE_EFFECTS properties must compare as property type
2014-07-24 11:53:02 +02:00
Paul O’Shannessy
efdc5da097
Merge pull request #1903 from syranide/ie8nmlb
...
Remove empty TextNode left behind by IE8 setInnerHTML workaround
2014-07-23 18:40:35 -07:00
Cheng Lou
b0945b16cc
Merge pull request #1560 from spicyj/simplify-lifecycle
...
Simplify composite lifecycle state
2014-07-23 18:02:39 -07:00
Andreas Svensson
8a135c0e75
Remove empty TextNode left behind by IE8 setInnerHTML workaround
2014-07-23 21:52:56 +02:00
Paul O’Shannessy
13e2c38a01
Merge pull request #1865 from syranide/modistatefalse
...
getModifierState should always return a boolean
2014-07-23 10:12:49 -07:00
Andreas Svensson
030071dd8b
getModifierState should always return a boolean
2014-07-23 10:01:22 -07:00
Cheng Lou
79076fad9c
Merge pull request #1774 from syranide/ie8focusthrow
...
Fix IE8 potentially throwing during restoreSelection
2014-07-22 16:29:07 -07:00
Paul O’Shannessy
6d02e04672
Merge pull request #1879 from syranide/modistatewrong
...
getModifierState incorrectly exposed as SyntheticMouseEvent.getEventModifierState
2014-07-22 15:50:15 -07:00
Paul O’Shannessy
2ba254af70
Merge pull request #1909 from zpao/move-react-source
...
Move react-source gem out of project root
2014-07-22 15:34:50 -07:00
Paul O’Shannessy
520c4f96d4
Move react-source gem out of project root
...
Now it requires a build step. At least the confusing lib directory is
gone though.
2014-07-21 22:56:32 -07:00
Ben Alpert
354fb44299
Use setImmediate to defer value restoration
...
Depends on #1758 .
Fixes #1698 .
Previously, controlled components would update too soon when using something like ReactLayeredComponentMixin (i.e., before the layer's updates could propagate from the parent), causing the cursor to jump even when always updating the new model value to match the DOM state. With this change, we defer the update until after all nested updates have had a chance to finish, which prevents the cursor from misbehaving.
Also cleaned up the logic around updating a bit -- the .value and .checked updates in ReactDOMInput weren't being relied on at all so I removed them and opted for a simple forceUpdate instead. I also got rid of _isChanging which hasn't been necessary since the introduction of update batching.
Test Plan: Tested the example in http://jsfiddle.net/Bobris/ZZtXn/2/ and verified that the cursor didn't jump. Changed the code to filter out numbers and verified that the field prevents typing numbers (attempting to do so still causes the cursor to jump to the end). Also verified that controlled and uncontrolled radio buttons, textareas, and select boxes work.
2014-07-21 22:42:18 -07:00
Ben Alpert
12b532c253
Add ReactUpdates.setImmediate for async callbacks
...
Callbacks passed to this setImmediate function are called at the end of the current update cycle, which is guaranteed to be asynchronous but in the same event loop (with the default batching strategy).
This is useful for new-style refs (#1373 , #1554 ) and for fixing #1698 .
Test Plan: jest
2014-07-21 22:41:00 -07:00
Paul O’Shannessy
520d73d73c
Merge pull request #1908 from spicyj/simpler-server-willmount
...
Simpler way to prevent flushing updates on server
2014-07-21 21:42:07 -07:00
Ben Alpert
6259d88f03
Simpler way to prevent flushing updates on server
...
Test Plan: Only failing tests in jest are immutable tests that were already failing.
2014-07-21 17:25:52 -07:00
Paul O’Shannessy
04e341936c
Include Object.assign polyfill
...
This isn't a good final solution but it makes React actually usable on
its own.
This also makes tests runnable, though only via jest
(./node_modules/.bin/jest)
2014-07-21 16:18:12 -07:00
Paul O’Shannessy
4bb7b70b28
Merge pull request #1892 from thauburger/patch-1
...
Remove _addPromise from Dispatcher code example
2014-07-21 15:55:41 -07:00
Cheng Lou
af72d9f37f
Merge pull request #1891 from robarnold/patch-1
...
Fix small issue in ReactContext comment
2014-07-21 14:47:07 -07:00
WickyNilliams
ee325eb5d5
follow docs convention for notes
2014-07-21 17:11:40 +01:00
Cheng Lou
d210269985
Merge pull request #1882 from glenjamin/patch-1
...
Note how to access Perf in docs
2014-07-20 11:45:24 -07:00
Ben Alpert
76d2ebdf74
Merge pull request #1893 from chenglou/docs-bar
...
[Docs] Add recent addons to addons.html; tweak wording
2014-07-20 01:16:52 -07:00
Cheng Lou
d95a4ef983
[Docs] Add recent addons to addons.html; tweak wording
...
Add PureRenderMixin and Perf to this page. Also, I think it's better if the link titles reflect the name used by these addons.
2014-07-20 00:59:19 -07:00
Tom Hauburger
c94bb20cb8
Remove _addPromise from Dispatcher code example
...
`_addPromise` is not used in the provided Dispatcher example, nor does it exist in Dispatcher.js found here: https://github.com/facebook/react/blob/master/examples/todomvc-flux/js/dispatcher/Dispatcher.js
2014-07-19 19:52:33 -07:00
robarnold
83e5e9bedf
Fix small issue in ReactContext comment
...
Noticed this the other day and meant to fix it.
2014-07-19 19:09:35 -07:00
Andreas Svensson
0efe8ca362
JSXTransformer, stricter parsing of script type
2014-07-20 01:20:30 +02:00
Ben Alpert
93712246c8
Reword sentence in reconciliation docs
2014-07-19 14:44:16 -07:00
Andreas Svensson
6950a8418c
Use faster cached regexps for tests in setInnerHTML
2014-07-19 21:00:35 +02:00
Glen Mailer
83fd5583bf
Note how to access Perf in docs
2014-07-19 16:14:27 +01:00
Andreas Svensson
6f0db65777
getModifierState incorrectly exposed as SyntheticMouseEvent.getEventModifierState
2014-07-19 10:44:11 +02:00
Sebastian Markbage
c419cce5c9
Move defaultProps resolution to the descriptor factory
...
Moves the defaultProps resolution to the descriptor factory.
2014-07-18 22:01:36 -07:00
Sebastian Markbage
3a7dbe6b73
Deprecate transferPropsTo
2014-07-18 22:01:36 -07:00
Paul O'Shannessy
de711efcc9
When proxying statics functions, copy properties
...
Port of 076047012a which went in
externally before ReactLegacyDescriptor happened, so it needed to be
ported.
2014-07-18 22:01:36 -07:00
Ben Newman
23c5332208
Fix ReactTestUtils.mockComponent so that mockTagName is not ignored.
...
The `mockTagName` parameter was always optional, and so probably was not
used very often. If you tried to use it, it would be shadowed by the
`var mockTagName` declaration in the `render` method, so only
`module.mockTagName` or `"div"` were ever possible values.
2014-07-18 22:01:36 -07:00
Ben Newman
2347abf75c
Don't call window.getSelection when it isn't defined.
...
Sadly, jsdom does not support `window.getSelection` yet, but
`ExecutionEnvironment.canUseDOM` is `true` in a jsdom environment.
2014-07-18 22:01:36 -07:00
Sebastian Markbage
3818656f70
Use Object.assign in merge/mergeInto
...
Relax the argument type checks. Currently we throw for non-objects and terminals
but Object.assign does a coercion to Object instead. It also allows merging
Arrays as if they are objects.
This also relaxes the check for dependents such as ImmutableObject. This sucks
but it will allow us to use a fast code path to native Object.assign.
We always have the option of adding warnings to Object.assign or static type
checks.
I'm keeping the null check. Object.assign throws for null checks.
We'll also start returning the result of coercions just like Object.assign.
2014-07-18 22:01:36 -07:00
Sebastian Markbage
225d76f772
Drop transferPropsTo usage in React core
...
These were completely unnecessary uses of transferPropsTo.
2014-07-18 22:01:36 -07:00
Ben Newman
66cdba3dfb
Avoid leading spaces when first argument to joinClasses is falsy.
...
This detail is going to become more important once the idiom
`className={joinClasses(this.props.className, newClass)}` becomes more
common, as it will when we move away from `this.transferPropsTo`.
2014-07-18 22:01:36 -07:00
Sebastian Markbage
5aab0bddaa
Move key/ref off props and prepare for new descriptor factories
...
Breaking changes
- key/ref are no longer accessible on props but they are accessible on the
descriptors. This means that parents/owners can access it but not the
component itself.
- Descriptor factories are now plain functions and you can't rely on the
prototype or constructors of descriptors to identify the component type.
Existing descriptor factories are now wrapped in a legacy factory. Currently it
does nothing but it will give us a hook to track callers to factories that are
not using JSX but just invoking the function directly. It also proxies static
methods/properties to the underlying class. The newer factories don't have this
feature.
ReactTextComponent has it's own little factory because it's props is not an
object. This is a detail and will go away once ReactTextComponent no longer
needs descriptors.
2014-07-18 22:01:36 -07:00
Paul O’Shannessy
06e6313a72
Merge pull request #1876 from petehunt/fix-jsxt2
...
Fix JSXTransformer
2014-07-18 20:07:49 -07:00
petehunt
e8efa2a1e9
Fix browser-tranforms
2014-07-18 19:02:31 -07:00
Paul O’Shannessy
9929f6de1e
Merge pull request #1870 from spicyj/gh-1866
...
Don't initialize reconcile transaction on server
2014-07-18 16:40:03 -07:00
Paul O’Shannessy
8439deadd0
Merge pull request #1869 from syranide/modistatecase
...
getModifierState is case sensitive
2014-07-18 16:13:34 -07:00
Ben Alpert
54d91c293d
Don't initialize reconcile transaction on server
...
...when calling setState from within a componentWillMount. Fixes #1866 .
Test Plan: jest
2014-07-18 11:03:34 -07:00
Paul O’Shannessy
f367785a78
Merge pull request #1837 from garrensmith/update-todo-example
...
Update Todo MVC example
2014-07-18 10:56:21 -07:00
Andreas Svensson
495d866a66
getModifierState is case sensitive
2014-07-18 18:24:11 +02:00
Nick Williams
48006b0e63
Add note about key prop being excluded by cloneWithProps
...
Whilst this is intentional behaviour (see #1274 ), it is not documented anywhere, so it is worth mentioning.
It would also be nice if React issued a warning to console if a cloned component loses its key (as this will silently break reconciliation?)
2014-07-18 16:14:55 +01:00
Garren Smith
0c4be5a8f9
Update Todo MVC example
...
A small patch for the Todo MVC example to use React 0.11.0.
This then allows the `MainSection` to return `null` instead of
previous `<noscript/>`.
2014-07-18 10:51:43 +02:00
James Seppi
6d1ede34df
fix typo
...
Closes #1859 .
2014-07-17 15:58:33 -07:00
Ben Alpert
9698b54dfe
Merge pull request #1860 from KyleAMathews/patch-3
...
Not a candidate anymore
2014-07-17 15:22:04 -07:00
Ben Alpert
384e8fe195
Fix appearance of video thumbnail
2014-07-17 15:19:58 -07:00
Kyle Mathews
bd5e8aa076
Update 2014-07-17-react-v0.11.md
2014-07-17 15:18:41 -07:00
Ben Alpert
d39b8078a3
Merge pull request #1835 from amm385/patch-1
...
Update videos.md
2014-07-17 15:15:11 -07:00
Paul O’Shannessy
5bfee601ce
Bump version for 0.12.0-alpha
...
[skip ci]
2014-07-17 14:22:50 -07:00
Paul O’Shannessy
8814ee2065
Release materials for 0.11
2014-07-17 14:18:28 -07:00
Ben Alpert
11e0e5ae44
Performance boost in some cases
2014-07-17 13:43:43 -07:00
Paul O’Shannessy
5f77e6dc51
Upgrade commoner dependency
...
0.9.5 depended on Node 0.11+, so make sure we don't ever get that.
See https://github.com/reactjs/commoner/pull/65
2014-07-17 12:59:53 -07:00
Ben Alpert
6ee9aa773d
Remove stale deprecation note from unmounting docs
2014-07-16 23:22:54 -07:00
Ben Alpert
ba5c7ff507
Add React.Children.count docs
2014-07-16 23:19:45 -07:00
Paul O’Shannessy
0fdd98f0d4
Update authors/acknowledgements [skip ci]
2014-07-16 15:14:49 -07:00
Paul O’Shannessy
c21678f9bc
Merge pull request #1818 from chenglou/docs-apply
...
[Docs] Update addons.update
2014-07-16 14:17:47 -07:00
Paul O’Shannessy
bb6087848d
Merge pull request #1821 from chenglou/docs-addons-perf
...
[Docs] Perf tools
2014-07-16 14:17:30 -07:00
Paul O’Shannessy
62a4ac0f4d
Merge pull request #1840 from spicyj/statics-proptypes
...
When proxying statics functions, copy properties
2014-07-16 13:07:56 -07:00
Ben Alpert
121529bdfd
Add "Edit on GitHub" link on docs pages
...
Ember's docs do this and I rather like the idea of encouraging people to make improvements.
2014-07-16 11:17:00 -07:00
Felix Gnass
5f56f4ac36
add picture to xjs.knownTags
2014-07-16 19:57:19 +02:00
Felix Gnass
33bd509737
add picture element and related attributes
2014-07-16 13:19:55 +02:00
Ben Alpert
dd3167edc9
Reorder reference pages
...
This order should make more sense; it moves important functions like React.renderComponent up and deprecated/discouraged ones like transferPropsTo and setProps down. No content changes.
2014-07-15 23:03:37 -07:00
Ben Alpert
abb95eed5c
Fix comma splice
2014-07-15 22:34:33 -07:00
Paul O’Shannessy
5ea3ff64b6
Merge pull request #1842 from spicyj/jstransform-visitors
...
Add new jstransform visitors to JSX transform
2014-07-15 16:36:14 -07:00
Ben Alpert
f02264cf83
Add destructuring visitor to JSX harmony transform
2014-07-15 16:34:00 -07:00
Ben Alpert
076047012a
When proxying statics functions, copy properties
...
Test Plan: jest
2014-07-15 15:09:16 -07:00
Cheng Lou
12750ad749
[Docs] Perf tools
...
Fixes #1814 .
@petehunt @joshduck
The images look blurry (taken on retina then shrank down to 50%...)
2014-07-15 11:17:21 -07:00
Paul O’Shannessy
e85e5e9952
Merge pull request #1817 from chenglou/docs-PureRenderMixin
...
[Docs] Document PureRenderMixin addon
2014-07-15 11:09:16 -07:00
Ben Alpert
76496b3cca
Add note about higher/lower-level transition APIs
2014-07-14 21:41:07 -07:00
Cheng Lou
8ebadf1591
[Docs] Update addons.update
...
Fixes #1815 .
Add the new `$apply` command, plus a few examples.
@petehunt
2014-07-14 17:59:22 -07:00
Areeb Malik
28ed79c2ce
Update videos.md
...
reordering to spot #4
2014-07-14 17:31:56 -07:00
Areeb Malik
afe30ad8ee
Update videos.md
...
Adding video for my recent talk in London about using React in large scale applications
2014-07-14 17:16:44 -07:00
Ben Alpert
7b872cd781
Merge pull request #1813 from baddox/patch-2
...
Verb agreement grammar fix
2014-07-14 17:08:43 -07:00
Ben Alpert
c26c2d42ac
Merge pull request #1812 from baddox/patch-1
...
Add possessive to fix grammar
2014-07-14 17:07:10 -07:00
Mouad Debbar
97dbada03d
Up-to-date React.Children
...
Make sure we actually include `.count`
2014-07-14 15:01:44 -07:00
Andreas Svensson
f8ccc2186f
Fix IE8 potentially throwing during restoreSelection
2014-07-14 21:07:56 +02:00
Ray
bea24ca944
fix some translation bug
2014-07-14 20:25:07 +08:00
Ray
8758addb41
add translation for 02-displaying-data.md and change next link in 01-why-react.zh-CN.md
2014-07-14 20:13:33 +08:00
Ben Alpert
65b2232f34
Fix typo-ed "of"
2014-07-13 13:09:50 -07:00
Ben Alpert
4a66260b2c
Make code in headers not giant
2014-07-13 13:03:12 -07:00
Paul O’Shannessy
b8cc3f510a
0.11-rc blog post
2014-07-13 12:54:41 -07:00
Paul O’Shannessy
ab690586d3
Consolas > Courier New for monospace docs font [skip ci]
2014-07-13 12:26:28 -07:00
Paul O’Shannessy
0f9cec2e78
0.11.0-rc1
2014-07-12 19:50:45 -07:00
Paul O’Shannessy
ec7de52a8f
Merge pull request #1825 from zpao/jsx-sourcemap
...
Add support for inline sourcemaps in jsx executable
2014-07-12 19:50:01 -07:00
Paul O’Shannessy
fc3a3801de
Add support for inline sourcemaps in jsx executable
...
--source-map-inline
2014-07-12 19:49:11 -07:00
Paul O’Shannessy
87c8e69fca
Bump dependencies that are known safe
...
Most of these would have been installed anyway, just making sure what
got shrinkwrapped is what others would experience.
2014-07-12 19:09:00 -07:00
Cheng Lou
8f909233c9
[Docs] Document PureRenderMixin addon
...
Fixes #1816
2014-07-12 14:56:43 -07:00
Ben Alpert
92d2dcc25f
Revert "Add helpful message about pooled classes"
...
This reverts commit e65f17b86c . This might have a perf impact so we're not going to go with it for now.
2014-07-11 16:00:58 -07:00
Paul O’Shannessy
4526f627f2
Simplify shouldComponentUpdate example [skip ci]
2014-07-11 15:32:48 -07:00
Ben Alpert
a47a6ab1d1
Rewrap tags/attributes lists
2014-07-11 15:23:51 -07:00
Cheng Lou
b38518ff4d
[Docs] Better README for react-tools
2014-07-11 15:09:22 -07:00
Paul O’Shannessy
165cb5f70f
Merge pull request #1783 from avanderhoorn/patch-1
...
Update React-tools to support transform as object
2014-07-11 15:00:04 -07:00
Ben Alpert
b14ae9b615
Update AUTHORS and acknowledgements again
2014-07-11 14:51:56 -07:00
Ben Alpert
7e44894219
Tweak wording a bit on renderComponent note
2014-07-11 14:50:46 -07:00
Ben Alpert
694a952d26
Merge pull request #1799 from julen/patch-1
...
Added note about `renderComponent()` requirement
2014-07-11 14:48:37 -07:00
Ben Alpert
47d3339e1b
Don't copy todomvc-flux into starter kit
...
Test Plan: Ran `grunt release:starter` and looked in build/starter/ to see all the examples but not todomvc-flux.
2014-07-11 14:35:10 -07:00
Ben Alpert
c64df89ecf
Fix up getDefaultProps docs
2014-07-11 14:26:42 -07:00
Ben Alpert
a4374c4f74
Update acknowledgements page from AUTHORS
2014-07-11 14:15:53 -07:00
Ben Alpert
d101e2ef30
Update AUTHORS
2014-07-11 14:10:46 -07:00
Paul O’Shannessy
2b0e51bdba
Add String.prototype.trim to polyfill check
...
Also shortens the URL so it fits on 1 line
2014-07-11 10:36:38 -07:00
Paul O’Shannessy
28d94d2dcf
Fix react-dislayName-test
...
[skip ci]
2014-07-11 10:36:07 -07:00
Anthony van der Hoorn
8c1ce8f9c3
Update sourceMap to return .toJSON() output
...
This means we get a data object back rather than a SourceMapGenerator
2014-07-11 08:44:02 -04:00
Anthony van der Hoorn
b8582b8d1c
Refactor transformAsObject to transformWithDetails
...
This matches current best thinking.
2014-07-11 08:38:28 -04:00
Thomas Shaddox
0d7184f0db
Verb agreement grammar fix
2014-07-11 02:57:21 -07:00
Thomas Shaddox
4477e69d52
Add possessive to fix grammar
2014-07-11 02:52:17 -07:00
Julen Ruiz Aizpuru
e0c0e20b49
Docs: added note about renderComponent() requirement
2014-07-11 08:37:44 +02:00
Ben Alpert
774f5a022e
tutorial: Fetch data in componentDidMount instead
...
In a world where this component was server-rendered, we wouldn't want to call the data-fetching code there so it makes more sense to have it in componentDidMount.
2014-07-10 22:33:09 -07:00
Paul O’Shannessy
cd1adc5303
Merge pull request #1796 from enguerran/footer
...
fix the disappearing footer on the todomvc-flux sample
2014-07-10 20:41:25 -07:00
Paul O’Shannessy
55b7c387da
Update supported elements and properties [skip ci]
2014-07-10 20:04:37 -07:00
Paul O’Shannessy
d8aa1c3612
Update polyfills list in docs [skip ci]
...
Fixes #1744
2014-07-10 17:14:25 -07:00
Paul O’Shannessy
0d8aa8ff65
Update AUTHORS for 0.11 [ci skip]
2014-07-10 14:49:00 -07:00
Paul O’Shannessy
9e582661e3
Merge pull request #1802 from zpao/jsxtransformer-cleanup
...
Jsxtransformer cleanup
2014-07-09 13:28:49 -07:00
Paul O’Shannessy
31a025a667
Add docblocks and consistent styling to JSXTransformer
2014-07-09 12:51:46 -07:00
Paul O’Shannessy
61d495422d
Merge pull request #1801 from zpao/jsxtransformer-sourcemaps
...
Fix sourcemaps in JSXTransformer for Firefox
2014-07-09 12:49:31 -07:00
Paul O’Shannessy
336890291e
Fix sourcemaps in JSXTransformer for Firefox
...
Fixes #1725
2014-07-09 12:48:02 -07:00
Enguerran
0d481c69a5
another way to fix the footer that is not shown
2014-07-09 10:39:14 +02:00
Paul O’Shannessy
9d5ab297d2
Merge pull request #1784 from wvl/package-built-source-with-npm
...
Add the built source to npm package. See #1699
2014-07-08 19:22:53 -07:00
Paul O’Shannessy
897b423e0e
Merge pull request #1797 from spicyj/transition-group-names
...
Add displayName to ReactTransitionGroup + friends
2014-07-08 14:40:34 -07:00
Paul O’Shannessy
49c476e1e6
Merge pull request #1786 from zpao/react-tools-readme
...
Custom readme for react-tools
2014-07-08 14:20:36 -07:00
Ben Alpert
734a345257
Add displayName to ReactTransitionGroup + friends
...
Fixes facebook/react-devtools#42 .
Test Plan: Crossed fingers.
2014-07-08 12:18:46 -07:00
Max F. Albrecht
bcea3bee45
Also list <form> in error message as possible culprit
2014-07-08 14:08:17 +02:00
Enguerran
745082c0ac
fix the disappearing footer on the todomvc-flux sample
2014-07-08 11:59:07 +02:00
Paul O’Shannessy
785d2cabef
Merge pull request #1793 from monsanto/browserify-note
...
Add a note about production mode for npm installs.
2014-07-07 21:56:51 -07:00
Christopher Monsanto
39ac88595d
Remove mention of envify since it is listed in package.json
2014-07-07 15:00:47 -04:00
Anthony van der Hoorn
5c4e451054
Abstracted out common code into innerTransform
...
As per feedback brought common logic from both `transform` and `transformAsObject` into its own `innerTransform` function.
2014-07-06 16:23:50 -04:00
Christopher Monsanto
9ddb4d4a78
Add a note about production mode for npm installs.
2014-07-05 20:52:42 -04:00
Paul O’Shannessy
5c85f33184
Custom readme for react-tools
...
Of course this means I can no longer just npm publish from the project
root, but I haven't been anyway.
2014-07-03 17:39:33 -07:00
Wayne Larsen
c1c8ad8e53
Add the built source to npm package. See #1699
2014-07-03 18:21:22 -04:00
Cheng Lou
e10d10e31e
Merge pull request #1531 from spicyj/two-face
...
Give useful error when using two copies of React
2014-07-03 14:45:23 -07:00
Ben Alpert
70bf3e1306
Give useful error when using two copies of React
...
If we don't error here, we end up with a confusing error later on in this.getDOMNode() where ReactMount doesn't have the proper container registered in its object.
2014-07-03 14:20:31 -07:00
Andrew Zich
559eb89965
make invariant show formatted actual errors in all unminified environments
...
Because we can have !__DEV__ but unminified, we still want to see the
message in those cases.
2014-07-03 13:53:41 -07:00
Cheng Lou
e8e08127c5
Merge pull request #1461 from spicyj/no-esc-slash
...
Don't escape slash; it's unnecessary
2014-07-03 11:05:16 -07:00
Paul O’Shannessy
676aac13d0
Update npm dependencies [skip ci]
2014-07-03 09:57:12 -07:00
Anthony van der Hoorn
4ecde425f9
Update React-tools to support transform as object
...
This change adds an additional function to the exported object to support getting access to the transformed result as an object rather than just a string result - the separate function designed to maintain backwards compatibility.
This facilitates tools that want the code separate from the sourcemap or anything else as time goes by.
2014-07-03 08:20:55 -04:00
Paul O’Shannessy
12479d3d20
Merge pull request #1780 from jbrantly/issue-1292
...
Fixing grunt jsx task in Windows
2014-07-02 17:41:18 -07:00
Cheng Lou
7a27d43020
Merge pull request #1779 from spicyj/spell-gram
...
Fix spelling/grammar in test comment
2014-07-02 15:13:36 -07:00
jbrantly
9e60afdc31
Fixing grunt jsx task in Windows
...
Spawning node directly instead of relying on shebang in the jsx-internal script
Fixes #1292
2014-07-02 17:26:40 -04:00
Ben Alpert
c8d9957f68
Fix spelling/grammar in test comment
2014-07-02 14:09:38 -07:00
Ben Alpert
a02b6b3d7f
Clarify when getDefaultProps is called
...
Fixes #1778 .
2014-07-02 14:06:48 -07:00
Yuval Dekel
40b522c498
Give context for owners of compenent instantiations with propType errors
...
See modification to the test-file: Basically we add a small hint at the end
of the error warning for propType errors to help identify which instantiation
of the component at hand is faulty.
2014-07-02 12:47:26 -07:00
Paul O’Shannessy
17aef05d75
Stop running so many things in travis
...
We're not actively looking at most of these and they take up valuable
job time.
2014-07-01 18:11:34 -07:00
Paul O'Shannessy
a4e5327b76
Remove jest usage in ReactDescriptorTest
...
Until we're only using jest on github, we should stick with Jasmine spies. Soon, hopefully.
2014-06-30 20:55:19 -07:00
Paul O'Shannessy
022e44c95b
Cleanup ReactChildren
2014-06-30 20:55:09 -07:00
Guangqiang Dong
1aa9cc6a8b
add count() method to ReactChildren
...
added ReactChildren.count() to count the number of children, and a test case.
2014-06-30 20:54:57 -07:00
Paul O'Shannessy
5b17e75707
Support more properties for image maps
...
Supporting the `<area>` tag is pretty useless if we don't support the necessary properties.
2014-06-30 20:54:44 -07:00
Paul O’Shannessy
5eb57fa51b
Add support to JSX transform for <hyphenated-tags>
...
This only adds support for whitelisted tags, not arbitrary ones.
Closes #1539
2014-06-30 20:54:41 -07:00
Cheng Lou
3e5c606f3f
Merge pull request #1750 from protron/patch-1
...
Fix to sample code for href in ReactPropTypes
2014-06-30 17:14:58 -07:00
Paul O’Shannessy
dc8ec2fab1
Cache node_modules on Travis
...
This isn't actually enabled yet for public projects, but this will help
us speed up builds when it does get enabled.
http://docs.travis-ci.com/user/caching/
2014-06-30 14:19:24 -07:00
Ben Alpert
94fd726f86
Merge pull request #1767 from jgebhardt/fixlink
...
fix link in community roundup #18
2014-06-30 10:48:29 -07:00
Jonas Gebhardt
a8e273f844
fix link in community roundup #18
2014-06-30 10:41:42 -07:00
Ben Alpert
5a0eee3bb6
Merge pull request #1765 from chenglou/docs-tut-again
...
[Docs] Fix tutorial line highlights, revert ajax in cb
2014-06-30 01:02:29 -07:00
Cheng Lou
66d6e3f391
[Docs] Fix tutorial line highlights, revert ajax in cb
2014-06-30 01:01:48 -07:00
Cheng Lou
108efb4add
Merge pull request #1763 from chenglou/docs-tut
...
[Docs] Put tutorial up-to-date with the code
2014-06-29 21:50:42 -07:00
Cheng Lou
58a463f01c
[Docs] Put tutorial up-to-date with the code
2014-06-29 21:46:16 -07:00
Cheng Lou
546bf0ed74
Merge pull request #1760 from spicyj/docs-harmony
...
Add --harmony option to live JSX compiler page
2014-06-28 17:32:57 -07:00
Ben Alpert
ba67bf1b0d
Add --harmony option to live JSX compiler page
2014-06-28 17:29:30 -07:00
Ben Alpert
cb20dec85f
Simplify composite lifecycle state
...
We now forbid calling setState or forceUpdate if any component's render function is higher in the stack, not just the component you're trying to update. (We do this already now for React.renderComponent and React.unmountComponentAtNode.)
This also has the advantage that we can now remove CompositeLifeCycle.RECEIVING_STATE, making _compositeLifeCycleState easier to reason about (not to mention that RECEIVING_STATE was a confusing name) and making it possible to remove a try/finally from the render path which might help with perf.
2014-06-28 01:04:04 -07:00
Mariano Desanze
bb1a31930b
Wrapped line to 80 chars in ReactPropTypes sample
2014-06-28 04:33:45 -03:00
Ben Alpert
bc11793c04
Fix code style in TodoMVC Flux example
2014-06-27 22:16:42 -07:00
Paul O’Shannessy
8dcad5e09c
Merge pull request #1622 from gebrits/patch-1
...
Update todo example. fixes 'Create' that shouldn't happen
2014-06-27 17:57:01 -07:00
Cheng Lou
5ba3911929
[Blog] Update round-up #19 to include more credit
2014-06-27 10:00:41 -07:00
Mariano Desanze
9854be2e46
Fix to sample code for href in ReactPropTypes
...
Error should be thrown in the previous condition is "not" meet. And the href propType is described as optional in the comment, but the null check was missing.
2014-06-27 11:50:03 -03:00
Sebastian Markbage
ef67406272
Add simple React.createDescriptor hook
...
This is the minimal runtime change we need to switch the JSX syntax to resolve
to React.createDescriptor(...)
2014-06-26 15:42:18 -07:00
Sebastian Markbage
d0719a5ea4
Preparing to move defaultProps resolution and type validation to the descriptor
...
This copies the propType and contextType validation to a wrapper around the
descriptor factory. By doing the validation early, we make it easier to track
down bugs. It also prepares for static type checking which should be done at the
usage site.
This validation is not yet active and is just logged using monitorCodeUse. This
will allow us to clean up callsites which would fail this new type of
validation.
I chose to copy the validation of abstracting it out since this is just an
intermediate step to avoid spamming consoles. This makes more a much cleaner
diff review/history. The original validation in the instance will be deleted as
soon as we can turn on the warnings.
Additionally, getDefaultProps are moved to become a static function which is
only executed once. It should be moved to statics but we don't have a
convenient way to merge mixins in statics right now. Deferring to ES6 classes.
This is still a breaking change since you can return an object or array from
getDefaultProps, which later gets mutated and now the shared instance is
mutated. Mutating an object that is passed into you from props is highly
discouraged and likely to lead to subtle bugs anyway. So I'm not too worried.
The defaultProps will later be resolved in the descriptor factory. This will
enable a perf optimizations where we don't create an unnecessary object
allocation when you use default props. It also means that ReactChildren.map
has access to resolved properties which gives them consistent behavior whether
or not the default prop is specified.
2014-06-26 15:40:12 -07:00
Sebastian Markbage
e6134c307e
[react jsx transform] Spread attribute -> Object.assign
...
Add support for spread attributes. Transforms into an Object.assign just
like jstransform does for spread properties in object literals.
Depends on https://github.com/facebook/esprima/pull/22
2014-06-26 15:40:02 -07:00
Paul O’Shannessy
0cf686fe1e
Merge pull request #1738 from cassus/master
...
Add missing markerStart, markerMid, markerEnd SVG attributes
2014-06-26 15:24:30 -07:00
Ben Alpert
991c1c1169
Fix typo in blog post
2014-06-26 15:19:24 -07:00
Paul O’Shannessy
7ec2428611
Merge pull request #1748 from pieterv/community-roundup-19-fix
...
Change community roundup 19's React Bootstrap author to @stevoland
2014-06-26 15:14:03 -07:00
Pieter Vanderwerff
deb47d5ecc
Change community roundup 19's React Bootstrap author to @stevoland
2014-06-27 10:00:10 +12:00
Cheng Lou
dbf41a55a4
{Blog] Community Round-up #19
2014-06-26 13:53:14 -07:00
Paul O’Shannessy
3581a92fc3
Merge pull request #1642 from ryanseddon/trimCSSValues
...
Correctly trim strings for css properties
2014-06-25 22:02:54 -07:00
Paul O’Shannessy
295da0a795
Merge pull request #1741 from spicyj/mount-unused
...
Remove unused properties from ReactMount
2014-06-25 21:24:42 -07:00
Ben Alpert
b8ad5a23c6
Remove unused properties from ReactMount
...
(useTouchEvents lives in EventPluginUtils.)
Test Plan: jest
2014-06-24 22:03:43 -07:00
Cheng Lou
d52bebd07b
Merge pull request #1716 from somethingkindawierd/master
...
Removes value attribute from rendered html of textarea
2014-06-24 19:14:19 -07:00
Paul O’Shannessy
56263c44e8
2 docs fixes.
...
Fix 404 and extra slash in url
2014-06-24 15:12:19 -07:00
Paul O’Shannessy
2496757364
Simple custom 404 page.
...
Github doesn't let us handle 404s within a project repository, so we
handle them at the organization level. In order to handle graceully for
specific projects, we're setting up redirects to projects' own 404.html.
2014-06-24 14:11:37 -07:00
Cheng Lou
a0486514a3
Merge pull request #1737 from spicyj/notime
...
Remove timing metrics from Transaction
2014-06-24 11:02:22 -07:00
Paul O’Shannessy
b018870091
Merge pull request #1664 from spicyj/warn-pooling
...
Add helpful message about pooled classes
2014-06-24 11:01:21 -07:00
Jon Beebe
e077dd40eb
Adds empty onChange handler to textarea test
2014-06-24 07:26:07 -05:00
Cassus Adam Banko
30705f794c
Add missing markerStart, markerMid, markerEnd SVG attributes
2014-06-24 11:17:34 +02:00
Dan Abramov
e625b8b234
Warn when using hyphenated style property names
2014-06-24 13:05:52 +04:00
Ben Alpert
1c44b874fc
Remove timing metrics from Transaction
...
No one uses these and they weren't meant to be left in.
Test Plan: jest
2014-06-23 20:32:12 -07:00
Ben Alpert
e65f17b86c
Add helpful message about pooled classes
...
Hopefully this will make fewer people confused at all of the null properties. The string won't wrap nicely so I tried to keep it pithy:
https://s3.amazonaws.com/uploads.hipchat.com/6574/26709/v8vzKAC784QMkX2/upload.png
2014-06-23 14:30:40 -07:00
Cheng Lou
9d5ad77774
[Docs] Render null returns noscript now
...
Following #1495 .
2014-06-23 13:52:09 -07:00
Cheng Lou
f81e213f41
Merge pull request #1495 from syranide/ie8noscript
...
Fix ReactEmptyComponent disappearing and throwing in IE8
2014-06-23 13:38:36 -07:00
Ryan Seddon
2bff5c5c7e
Correctly trim strings for css properties
...
* If a unitless value is passed with a space it'll return `1 px`
2014-06-23 09:43:50 +10:00
Ben Alpert
14be8f4547
Merge pull request #1731 from cody/master
...
Fix example for animation
2014-06-22 12:11:11 -07:00
Stefan Dombrowski
c91f95a092
Fix example for animation
...
* Highlight the correct lines
* Add missing text to button
* Remove unnecessary div
2014-06-22 18:11:51 +02:00
petehunt
c33cceb466
Expose React.addons.Perf
2014-06-20 17:55:48 -04:00
Paul O’Shannessy
f0fc42af77
Merge pull request #1464 from spicyj/style-esc
...
Don't double-escape style names
2014-06-20 12:12:18 -07:00
Jonas Enlund
0377ec579e
Added missing SVG attributes: fill-opacity, font-family, font-size, opacity, stroke-opacity.
...
Closes #1557
2014-06-20 12:45:31 -04:00
Josh Bassett
11486f1b31
Add 'patternContentUnits' to SVG attributes.
...
Closes #1702
2014-06-20 12:45:23 -04:00
Nate Hunzaker
3f29d5d6cb
Add support for patternUnits attribute.
...
The patternUnits attribute defines how a pattern's coordinate system is
defined (x, y, width, height). This is particularly important when using
repeatable patterns in SVG. This commit adds this attribute to the lists
of known properties.
Closes #1548
2014-06-20 11:32:31 -04:00
Brandon Bloom
aebb3261ee
Add support for SVG ellipse elements.
...
Closes #1675
2014-06-20 11:29:19 -04:00
Paul O’Shannessy
77150630e2
Merge pull request #1542 from remixz/gh-1420
...
Add harmony transform support in browser
Fixes #1420 . Moved some code around in the merge to account for more
changes in the transform code.
Conflicts:
vendor/browser-transforms.js
2014-06-20 10:55:06 -04:00
Andreas Svensson
b36e05b0af
Fix ReactEmptyComponent disappearing and throwing in IE8
2014-06-20 10:08:49 +02:00
Ben Newman
3c64461383
Merge pull request #1710 from benjamn/fix-tests-broken-by-undefined-window-references
...
Fix tests broken by undefined `window` references in ReactEventListener.
2014-06-19 15:33:16 -04:00
Ben Newman
4cef56d73b
Fix tests broken by undefined window references in ReactEventListener.
...
This test breakage blames to e1c2d02fdd .
2014-06-19 15:32:45 -04:00
Paul O’Shannessy
cc920a502f
Merge pull request #1724 from spicyj/main-nor
...
Don't export (undefined) React in main.js
2014-06-19 12:21:13 -07:00
Paul O’Shannessy
af1af19d39
Sync out transform tests
2014-06-19 15:14:54 -04:00
Paul O’Shannessy
2c85658c69
[jsx] Make sure we throw when we get XML namespaces
...
aad8a2b798
replaced XJSIdentifer with XJSNamespacedName for namespaced items, so we
need to adjust here accordingly.
2014-06-19 15:07:08 -04:00
Ben Alpert
8a6e2cde7f
Don't export (undefined) React in main.js
...
Previously, this was throwing an error. It was unintentionally (I assume) introduced in fc5bb9c .
Test Plan: jest
2014-06-19 11:34:50 -07:00
Paul O’Shannessy
324d41b5f0
Merge pull request #1244 from rayqian/master
...
add chinese translation support
2014-06-19 11:18:11 -07:00
Jon Beebe
b9c132e58a
Removes value from rendered attributes of textarea
2014-06-19 07:14:49 -05:00
Ben Alpert
b0dce1543a
Merge pull request #1721 from whatthejeff/patch-1
...
Fugbix typo.
2014-06-18 20:47:19 -07:00
Jeff Welch
27db8acaf9
Fugbix typo.
2014-06-18 23:36:37 -04:00
Paul O’Shannessy
92e3384cd2
Merge pull request #1513 from danielschonfeld/shouldcomponentupdate-boolean
...
Warn if shouldComponentUpdate returns anything other than true/false
2014-06-18 11:29:31 -07:00
Paul O’Shannessy
29083d0cec
Merge pull request #1713 from bmihelac/patch-1
...
Missing semicolon in TodoStore.js
2014-06-18 11:17:04 -07:00
Bojan Mihelac
84135bc605
Missing semicolon in TodoStore.js
2014-06-18 10:34:53 +02:00
Ben Alpert
121b290899
Clarify refs and setState callback documentation
2014-06-17 23:20:04 -07:00
Cheng Lou
3d696312ef
Merge pull request #1712 from mathieumg/master
...
Added example of objectOf usage in documentation.
2014-06-17 20:55:13 -07:00
Mathieu M-Gosselin
7fefab5946
Added example of objectOf usage in documentation.
2014-06-17 23:43:25 -04:00
Paul O’Shannessy
7f757347bc
Update many npm dependencies
...
Sauce/connect related things need some more work and I didn't want to
figure those out right now.
Fixes #1701
2014-06-17 14:21:24 -07:00
Paul O’Shannessy
8bbbe900a5
Sync out camelize module
...
For use in #1662
2014-06-17 09:27:59 -07:00
Ben Alpert
00037b3ec2
Fix tagtree.tv link
...
Fixes #1697 .
2014-06-16 13:56:36 -07:00
Paul O’Shannessy
08a207f401
Merge pull request #910 from andrewdavey/react-transform-source-map
...
Add sourceMap option to react-tools transform
2014-06-16 13:41:41 -07:00
Cheng Lou
20a50410a2
Merge pull request #1609 from spicyj/tlt-indirect
...
Remove unnecessary topLevelTypes indirection
2014-06-16 13:07:44 -07:00
Ben Alpert
52127dd7cf
Remove unnecessary topLevelTypes indirection
...
topLevelTypes is a key mirror, so dependency and topLevelType are always the same here.
2014-06-16 12:18:19 -07:00
Pete Hunt
c93583c84f
Remove bad perf metric
...
Remove a bad perf metric. Will investigate later.
2014-06-14 20:40:09 -07:00
Pete Hunt
e1c2d02fdd
Create ReactEventListener
...
Per our discussion friday, this creates ReactEventListener and renames variables to use the "handle"
nomenclature.
2014-06-14 20:38:45 -07:00
Marshall Roch
a6cd945d9f
Fix 'this' in static methods
...
binds static methods on the descriptor to the component's actual constructor, so that `foo.constructor.bar()` and `Foo.bar()` run with the same `this`.
2014-06-14 20:37:51 -07:00
Tim Yung
431155d2e2
Revert #1536
...
It's causing issues in product code. Reverting until it can be
investigated further.
2014-06-14 20:36:07 -07:00
Kunal Mehta
0f7423f31d
Merge pull request #1661 from spicyj/test-ie10-select-multiple
...
Fix select switching to multiple in IE
2014-06-13 14:24:50 -07:00
Cheng Lou
3eb36415bd
Merge pull request #1206 from brandonbloom/apply
...
$apply directive for update
2014-06-12 20:34:29 -07:00
Cheng Lou
4329d5ac38
Merge pull request #1611 from mathieumg/master
...
Added 'objectOf' PropType validator to iterate on objects and validate properties.
2014-06-12 20:19:33 -07:00
Brandon Bloom
86161c9c48
$apply command for update
2014-06-12 23:10:14 -04:00
Ben Alpert
7ab5769e18
Merge pull request #1687 from KyleAMathews/patch-2
...
typo fix
2014-06-12 16:29:19 -07:00
Kyle Mathews
cfdc884582
typo
2014-06-12 16:27:40 -07:00
Ben Alpert
5758f8da35
Merge pull request #1685 from randallsquared/patch-1
...
Fix correlation direction of wording in Ballmer Peak example.
2014-06-12 12:34:53 -07:00
Randall Randall
6d0e2feb52
Fix wording.
...
The Ballmer Peak XKCD suggests that it's a graph of ability, rather than bug frequency, which should be inversely correlated with ability. A simple change of the wording fixes this terrible mishandling of Ballmer Peak data.
2014-06-12 10:15:13 -04:00
Mathieu M-Gosselin
4852c30d62
Added 'objectOf' PropType validator to iterate on object literals and
...
validate properties.
2014-06-11 21:12:05 -04:00
Cheng Lou
303a719f92
Merge pull request #1658 from spicyj/test-ie10-submit-label
...
Fix submit-button value test in IE10
2014-06-11 13:44:27 -07:00
Cheng Lou
9eff32c80c
Merge pull request #1659 from spicyj/test-ie10-iframe
...
Fix EnterLeaveEventPlugin-test in IE10
2014-06-11 13:44:16 -07:00
Cheng Lou
92c174fec8
Merge pull request #1671 from gasi/fix-unset-style
...
Prevent null reference access when unsetting styles
2014-06-11 11:27:37 -07:00
Cheng Lou
36f2999d47
Merge pull request #1660 from spicyj/test-ie10-proptypesname
...
Fix PropTypes test in IE10
2014-06-11 10:34:28 -07:00
Ben Alpert
8e2dcceee3
Merge pull request #1597 from spicyj/defaultprops-autobind
...
Auto-bind before getDefaultProps
2014-06-11 10:14:31 -07:00
Ben Alpert
927eb570b9
Merge pull request #1631 from dblandin/master
...
Update link to @petehunt's react-server-rendering GitHub repo
2014-06-10 13:53:37 -07:00
Ben Alpert
e1e2fbdcf7
Merge pull request #1636 from harshadsabne/master
...
Update 2014-03-21-react-v0.10.md
2014-06-10 13:45:46 -07:00
Daniel Gasienica
7c2dec5bd3
Prevent null reference access when unsetting styles
2014-06-10 13:33:32 -07:00
Ben Alpert
2f61996ec3
[docs] Point to renderComponent over setProps
2014-06-08 13:04:40 -07:00
Ben Alpert
eaa68b8e6b
Fix select switching to multiple in IE
...
This one was an actual behavioral bug rather than a bug with the tests; our intention was that the first element from the `defaultValue` array would remain selected but IE seemed to be choosing the last one instead. Now we set the value for uncontrolled components in componentDidUpdate when switching from multiple to non-multiple to ensure that a consistent option gets selected.
Test Plan: Ran the ReactDOMSelect tests in jest, phantomjs, IE10, Chrome, and Firefox. Also tested an uncontrolled select manually to make sure that nothing crazy happened when switching between options.
2014-06-07 19:16:34 -07:00
Ben Alpert
7cd5e9b399
Fix PropTypes test in IE10
...
Test Plan: Ran the test in jest, phantomjs, IE10, Chrome, and Firefox.
2014-06-07 18:56:28 -07:00
Ben Alpert
5790a75622
Fix submit-button value test in IE10
...
Test Plan: Ran test in jest, phantomjs, IE10, Chrome, and Firefox.
2014-06-07 18:50:29 -07:00
Ben Alpert
e938116549
Fix EnterLeaveEventPlugin-test in IE10
...
Previously this was failing because iframeDocument.body wasn't properly initialized. Creating the document this way seems to work in all environments
Test Plan: Ran the test in jest, phantomjs, IE10, Chrome, and Firefox.
2014-06-07 18:45:32 -07:00
cpojer
eebcf9f888
Fix ExecutionEnvironment.canUseDOM for IE8.
2014-06-05 12:44:24 -07:00
Christoph Pojer
41ed67d222
Merge pull request #1638 from spicyj/getmodifierstate-2
...
Fix getEventModifierState, no allocations
2014-06-03 14:36:16 -07:00
Ben Alpert
e501238c10
Fix getEventModifierState, no allocations
...
Alternative to #1637 that doesn't allocate on every event.
Test Plan: Crossed fingers.
2014-06-03 14:35:29 -07:00
Harshad Sabne
7172b1d5da
Update 2014-03-21-react-v0.10.md
...
Fix link to React v0.10 RC
2014-06-03 21:35:49 +05:30
Pete Hunt
87bcbff218
Merge pull request #1632 from spicyj/img-load-error
...
Fix onLoad and onError on images
2014-05-30 17:04:41 -07:00
Ben Alpert
3e34739cb9
Fix onLoad and onError on images
...
Fixes bug introduced in c62c2c5 .
Test Plan: Tested that the onLoad event was properly triggered on an image. Didn't test onError but I can only assume that it works equally well.
2014-05-30 16:53:46 -07:00
Devon Blandin
d8a2f12498
Update link to @petehunt's react-server-rendering GitHub repo
2014-05-30 14:14:18 -05:00
Cheng Lou
6ce193614c
Merge pull request #1627 from Enome/master
...
Typo: ClosureScript -> ClojureScript in latest blog post
2014-05-29 16:20:42 -04:00
enome
b72d9f3aab
Typo: ClosureScript -> ClojureScript
2014-05-29 22:10:15 +02:00
Ben Alpert
5a856c769d
Merge pull request #1614 from chenglou/1-year
...
[Blog] One-year anniversary post
2014-05-29 11:41:51 -07:00
Cheng Lou
c5f690a7c7
[Blog] One-year anniversary post
2014-05-29 14:39:59 -04:00
Geert-Jan Brits
0c312222e9
Update todo example. fixes 'Create' that shouldn't happen
...
Currently, an `onBlur` creates a new todo on `TodoTextInput`. This makes sense for existing items but not for new items. I.e consider the following:
1. cursor on new item ("What needs to be done?")
2. click 'x' on the first item.
This results in two actions being fired:
1. TODO_CREATE, with an empty string as 'text'
2. TODO_DESTROY
The proposed fix doesn't send a TODO_CREATE if `text.trim() === "")`
2014-05-29 14:45:42 +02:00
Ben Alpert
8d8dd4d336
Merge pull request #1620 from kmeht/jestDoc
...
Reference Jest in TestUtils documentation.
2014-05-28 23:53:37 -07:00
Kunal Mehta
055275b833
Reference Jest in TestUtils documentation.
2014-05-28 23:51:22 -07:00
Ben Alpert
3297909545
[docs] Fix grammar
2014-05-28 23:31:02 -07:00
Fred Zhao
50516585a4
Update findComponentRoot and processUpdates warnings for SVG
...
I ran into a really difficult-to-debug issue with a React app with SVG
elements. Christopher sat down with me for a while and we finally figured out
that the browser was moving non-SVG elements out of a parent `<svg>` node which
triggered the `processUpdates()` invariant. This updates the error message
thrown from there to include this scenario in the possible issues list.
2014-05-28 18:19:49 -07:00
Paul O’Shannessy
6c7abd36dd
Sync upstream modules
...
crateObjectFrom is no longer used (was used in ReactPropTypes). Others are small changes.
2014-05-28 15:13:02 -07:00
Ben Alpert
2e3cf459ba
Fix tutorial to have exact translation of example
...
Fixes #903 .
2014-05-28 10:29:34 -07:00
Paul O’Shannessy
0ad8cfad1a
Merge pull request #1590 from spicyj/svg-classname
...
Handle className properly on SVG nodes
2014-05-28 10:14:59 -07:00
Paul O’Shannessy
f230e0a031
Merge pull request #1583 from nhunzaker/jsxtransform-parallel
...
Load external scripts in parallel in JSXTransformer
2014-05-27 14:31:25 -07:00
Timothy Yung
bca1f0e352
Merge pull request #1536 from spicyj/gh-1169
...
Attach empty onclick listener to each node
2014-05-27 16:44:08 -04:00
Ben Alpert
e096000bb5
Attach empty onclick listener to each node
...
Fixes #1169 .
This is a more robust way of fixing what MobileSafariClickPlugin previously tried to. Now even if you don't want anything to do with touch events, click events still work properly.
Test Plan: Added a click handler to an `<img />` element and triggered it in the iOS simulator -- it didn't execute before.
2014-05-27 13:40:17 -07:00
Paul O’Shannessy
fa6fe54432
Merge pull request #1596 from mindeavor/patch-1
...
Fix typo in Flux TodoMVC Tutorial
2014-05-27 11:07:09 -07:00
Tom Haggie
cd3ba59cf1
Updated the ajax to tip to also mention that you need to check
...
that the component is still mounted before updating it's state.
Closes #1600 .
2014-05-26 20:29:48 -07:00
Ben Alpert
03df8d7de0
Ignore built todomvc-flux bundles
2014-05-26 20:27:48 -07:00
Ben Alpert
f761f770e1
Don't load todomvc-common/base.js
...
Fixes #1603 .
It's unnecessary and makes a request to learn.json which doesn't exist.
2014-05-26 20:19:16 -07:00
Ben Alpert
db4a90a9ef
Capitalize README for consistency
2014-05-26 20:14:54 -07:00
Dan Abramov
367c88e399
Apply component and mixins specs deterministically
...
Fixes #1589 .
2014-05-26 02:56:28 +04:00
Ben Alpert
8a460ba2e8
Auto-bind before getDefaultProps
...
Fixes #1595 .
2014-05-25 00:40:39 -07:00
Gilbert
330fa30141
Fix typo in Flux TodoMVC Tutorial
...
A sentence says "only handles one actionType" when the example code instead handles two.
2014-05-25 00:21:31 -05:00
Ben Alpert
e1457a14fd
Run all tests, fix indentation
2014-05-23 23:03:13 -07:00
Ben Alpert
1e268c3591
Merge pull request #1556 from joshma/flux-dispatcher-docs
...
Update Flux Dispatcher.dispatch and waitFor examples
2014-05-23 23:01:25 -07:00
Ben Alpert
3e30940bf3
Bump to React 0.10 in TodoMVC Flux
2014-05-23 16:09:47 -07:00
Paul O'Shannessy
7a9b81ef55
remove spurios module ref
...
long long ago in a galaxy far away this was probably a dependency
2014-05-23 15:35:22 -07:00
Joshua Ma
7954a861d1
Add more complicated fourth listener to AppDispatcher-test
2014-05-23 12:42:09 -07:00
Joshua Ma
a616742fce
Configure todomvc-flux npm test to use jest
2014-05-23 12:36:38 -07:00
Joshua Ma
f8d0291874
Fix doc typo and remove underscore from local var
2014-05-23 12:34:40 -07:00
Paul O'Shannessy
c62c2c59bb
Remove event listeners from native dom wrapper components
...
Not removing them resulted in leaks as we would hold on to removed nodes forever.
This really showed up with images and the load event where we would unmount and create a new img with the same react id as the old one. We properly cleared and primed the caches but we would handle the load event for both nodes. We would eventually hit an invariant in that path as we tried to handle the event for the removed node, which no longer matched the node we had in the cache.
By forcefully removing the listener, we'll avoid this problem entirely and we should leak fewer DOM nodes.
2014-05-23 11:30:19 -07:00
Ben Alpert
37f61c479e
Handle className properly on SVG nodes
...
This strategy avoids a runtime check for every set (as opposed to using a mutation method).
Test Plan: Verify that changing className works on a div and a rect in latest Chrome, latest Firefox, IE9. Verify that the div works in IE8.
2014-05-22 20:31:04 -07:00
Ben Alpert
e60a893d2f
Bump esprima-fb and jstransform versions
...
Fixes #1584 , fixes #1475 .
2014-05-22 20:16:37 -07:00
Jeff Morrison
9ef6156d5c
Merge pull request #760 from syranide/jsxns
...
Support for JSX tag namespaces <React:DOM:div />
2014-05-22 15:51:49 -07:00
Paul O’Shannessy
f9ad17db65
Merge pull request #1363 from spicyj/batch-all
...
Batch subupdates caused by any state update
2014-05-22 15:28:48 -07:00
Ben Alpert
49652c8e20
Merge pull request #1575 from spicyj/dispatch-index
...
Make promise selection logic clearer
2014-05-21 15:39:53 -07:00
Paul O’Shannessy
cccdc54b68
Merge pull request #1576 from spicyj/ex-shim
...
Add shims to examples
2014-05-21 15:16:51 -07:00
Ian Obermiller
bf5dfc87dc
Error in extractEvents
...
If the event is on the window object, topScroll, for instance, the topLevelTarget will not have getAttribute defined. Restore the previous `|| !topLevelTarget.attributes` check to avoid an error on every scroll.
2014-05-21 15:12:26 -07:00
Ben Alpert
696e556eae
Merge pull request #1579 from gscottolson/master
...
Improve readability of multi-line nav items.
2014-05-21 12:30:28 -07:00
G Scott Olson
c9bac95034
Fix nested UL spacing.
2014-05-21 15:26:01 -04:00
Nate Hunzaker
59a9251c90
Set executed after run
2014-05-21 15:09:52 -04:00
Nate Hunzaker
b1247690d5
Load in parallel, evaluate linearly as they come in
2014-05-21 15:07:10 -04:00
Pete Hunt
6c34151588
Merge pull request #1577 from piranha/master
...
better talk in russian
2014-05-21 11:26:29 -07:00
G Scott Olson
7094737782
Improve readability of multi-line nav items.
2014-05-21 10:55:42 -04:00
Alexander Solovyov
4595dbdc7a
better talk in russian
2014-05-21 11:52:24 +03:00
Ben Alpert
4cb4bd0220
Add shims to examples
...
I find myself often using (modified) examples to test in IE and it's a pain to have to add the shims in every time. Might as well just add them in always.
2014-05-21 00:07:18 -07:00
Ben Alpert
e58899cdff
Make promise selection logic clearer
2014-05-20 17:09:05 -07:00
Paul O’Shannessy
c6309567c9
Merge pull request #1559 from spicyj/gh-1376
...
Allow unmounting title tag
2014-05-20 11:23:36 -07:00
Paul O’Shannessy
e63eab111c
Merge pull request #1553 from givingstage/invalid_checksum_warning_spacing
...
Fixed spacing of invalid checksum warning
2014-05-20 11:23:19 -07:00
Paul O’Shannessy
6c595d55dc
Merge pull request #1571 from spicyj/style-test
...
Switch style test to pass in jsdom
2014-05-20 11:22:30 -07:00
remixz
765ee8e5d0
Merge upstream changes
2014-05-19 20:12:57 -07:00
Ben Alpert
2d26451821
Add configuration for running tests with Jest
...
Can be run with `node_modules/.bin/jest` for now; didn't want to disturb the grunt setup.
Right now one test fails with:
```
FAIL browser/ui/__tests__/ReactDOMComponent-test.js (1.423s)
● ReactDOMComponent › updateDOM › it should update styles when mutating style object
- Expected: '0' toEqual: '0.5'
at Spec.<anonymous> (src/browser/ui/__tests__/ReactDOMComponent-test.js:99:33)
```
which I can only assume is a jsdom problem -- no other asserts fail.
2014-05-19 16:58:33 -07:00
Ben Alpert
4e5ed8317b
Switch style test to pass in jsdom
...
This should be testing approximately the same thing and passes in Jest.
Test Plan: Cherry-pick Jest config from #1528 and verify that running `jest`.
2014-05-19 16:56:30 -07:00
Ben Alpert
e17086e5df
Add componentWillReceiveProps setState test
2014-05-19 15:58:40 -07:00
Paul O’Shannessy
5933d97cb6
Merge pull request #1563 from spicyj/travis-no-sauce
...
Don't fail Travis on sauce failures
2014-05-19 13:28:09 -07:00
Ben Alpert
8db8e60a38
Don't fail Travis on sauce failures
...
Fixes #1496 .
2014-05-19 13:23:07 -07:00
Paul O’Shannessy
ab58ecefa7
Merge pull request #1564 from spicyj/hop-ie8
...
Use Object.prototype.hasOwnProperty for doc in IE8
2014-05-19 13:15:25 -07:00
Ben Alpert
550795445e
Use Object.prototype.hasOwnProperty for doc in IE8
...
Test Plan: Loaded ballmer-peak example in IE8 without errors and interacted with the text field.
2014-05-19 13:09:47 -07:00
Paul O’Shannessy
0c6bee049e
Merge pull request #1189 from spicyj/hasown
...
Add hasOwnProperty checks where appropriate
2014-05-19 09:38:56 -07:00
Ben Alpert
4935d04d50
Allow unmounting title tag
...
cf. #1376 .
This is useful for SVG. Dynamically adding and removing `<title>` elements in SVG still won't work properly because of getMarkupWrap but this at least lets you include it in initial render and then unmount the entire `<svg>` without problems.
2014-05-18 23:19:51 -07:00
Nate Hunzaker
0614cfa43e
Load scripts in parallel
2014-05-18 16:34:40 -04:00
Ben Alpert
66291d2761
Merge pull request #1558 from nhunzaker/fix-1530
...
Fix 1530 - Asynchronously load scripts with JSX transformer
2014-05-18 13:04:11 -07:00
Nate Hunzaker
bc79f623a1
Asynchronously load scripts with JSX transformer.
2014-05-18 15:41:41 -04:00
Andrew Davey
2b38795769
Rebased on master
2014-05-18 17:51:14 +01:00
Andrew Davey
fc5bb9c9b2
Add sourceMap option to react-tools transform
...
Allow tools like grunt-react to include inline source maps in the
generated JavaScript. Browserify can then combine these source maps when
bundling everything together.
Usage:
```
var transform = require('react-tools').transform;
var output = transform(jsxContent, {
sourceMap: true,
sourceFilename: 'source.jsx'
});
```
The `output` will have an inline source map comment appended.
2014-05-18 17:42:35 +01:00
Mark IJbema
59616672d7
Make sure it works when we have no css transitions
2014-05-18 11:31:24 +02:00
Mark IJbema
cd7b8aa0b1
Added event parameter
2014-05-18 11:29:29 +02:00
Ben Alpert
1baca43391
Mention PropTypes in top-level API
...
cf. #449
2014-05-18 00:15:35 -07:00
Ben Alpert
f1a5a4c58e
Be more specific with createClass, renderComponent
...
Closes #371 .
2014-05-18 00:15:35 -07:00
Ben Alpert
566af16e64
Tweak getting started wording
2014-05-18 00:15:35 -07:00
Joshua Ma
de1f783188
Update todomvc dispatcher to match docs, add AppDispatcher test
2014-05-17 22:01:18 -07:00
Joshua Ma
f12a376f34
Update Flux Dispatcher.dispatch and waitFor examples
...
The previous examples didn't properly work when 1) a Store callback does
waitFor on Stores that haven't been reached yet and 2) a Store callback
waits on another Store that is already waiting.
The updated example uses constructs Promises up front and then
asynchronously resolves them.
2014-05-17 21:17:08 -07:00
Thomas Shafer
0a7128c70f
Fixed spacing of invalid checksum warning
2014-05-17 20:04:52 -07:00
Ben Alpert
e9653aad6a
Merge pull request #1552 from t3chnoboy/master
...
Update Jasmine link
2014-05-17 18:33:51 -07:00
Dmitry Mazuro
8192b8c27f
Update Jasmine link
2014-05-18 04:30:02 +03:00
Ben Alpert
78958fe0f5
Remove references to autoflow
...
Most references were removed in 6e59561; this should be the last.
2014-05-17 15:15:26 -07:00
Ben Alpert
6c331fba07
Add hasOwnProperty checks where appropriate
...
For boolean-like objects, I've added hasOwnProperty checks in addition to the existing truthiness check even though for most of these dicts, we leave out false keys instead of setting them explicitly to false.
In DOMPropertyOperations, we don't need to check hasOwnProperty if the property is in isStandardName because (with the exception of getPossibleStandardName) the dicts on DOMProperty will now be consistently populated with every valid attribute.
2014-05-16 10:59:51 -07:00
Paul O’Shannessy
4558e2c4bc
Merge pull request #1491 from naturalatlas/itemscope
...
Added support for itemscope, itemtype, itemprop attributes.
2014-05-15 14:48:51 -07:00
Jan Kassens
46de927a28
Merge pull request #1537 from chenglou/rm-filter-attrs
...
Remove filterAttributes.js
2014-05-15 12:16:35 -07:00
Cheng Lou
80a5463a2c
Remove filterAttributes.js
...
This is no longer needed because of 089a494a1f
mutateHTMLNodeWithMarkup.js was the only one using it.
2014-05-15 14:14:38 -04:00
Andreas Svensson
3bec9f070f
Guard against contentEditable with children props
2014-05-15 11:08:25 +02:00
Ben Alpert
c913c95908
Update Simulate docs to reflect reality
...
cf. #1532 , #1445 .
2014-05-14 21:39:00 -07:00
remixz
3f31ec463f
Change harmony option to "harmony=true"
2014-05-14 15:50:35 -07:00
remixz
65c258a7b7
Add harmony transform support in browser (Fixes GH-1420)
...
I implemented this by checking for `type="text/jsx;harmony"`, since this
has a bit of a cleaner implementation rather than parsing a JSON object
out of a data attribute. If in the future there are other options to
pass, it would make sense to move to a system like that.
Along with adding support, there is also a new example added that's
the basic-jsx example with Harmony syntax.
2014-05-13 22:07:02 -07:00
Daniel Schonfeld
7d91277a50
warn when shouldComponentUpdate() returns undefined
2014-05-13 22:44:00 -04:00
Pete Hunt
b66202eb98
Merge pull request #1487 from somethingkindawierd/master
...
Adds svg mask and pattern dom components
2014-05-13 11:28:59 -07:00
Ben Alpert
808a54f410
Batch subupdates caused by any state update
...
With this, multiple setState calls triggered by a componentDidUpdate handler (or similar) will be batched together, regardless of if the original setState call was in a batching context.
I also cleaned up some inconsistencies with the order of component updates and callbacks in situations where one component's update directly causes another to update.
Fixes #1147 . Helps with #1353 and #1245 as well, though doesn't completely fix them yet.
Test Plan:
grunt test
2014-05-13 10:50:26 -07:00
Paul O’Shannessy
a00199ddd2
Merge pull request #1358 from spicyj/one-transaction
...
Share reconcile transaction in batched updates
2014-05-13 10:47:03 -07:00
Josh Duck
29f3f74c52
Make perf show all exclusive time, not just render time.
...
Currently require('ReactDefaultPerf').printExclusive() shows render
time and aggregate componentMount time.
This makes it show exclusive mount time by tracking a stack.
2014-05-12 16:39:09 -07:00
Pete Hunt
7268f44c94
Merge pull request #1504 from spicyj/flux-621
...
Start Flux video at 10m21s
2014-05-12 13:44:21 -07:00
Pete Hunt
e4f80f301d
Merge pull request #1516 from syranide/es5err
...
Preemptively error when required ES5 shim/shams are not available
2014-05-12 13:40:00 -07:00
Ben Alpert
d46e1588f9
Update Flux README to point at website post/docs
2014-05-12 01:33:53 -07:00
Ben Alpert
76abdddae8
todomvc-flux: Depend on uglify-js, not uglifyjs
...
Fixes #1505 .
Confusingly, the uglify-js package provides the `uglifyjs` binary and `npm run-script build` didn't work if uglify-js wasn't installed globally; now it does.
2014-05-12 01:14:01 -07:00
Andreas Svensson
659b7981e1
Preemptively error when required ES5 shim/shams are not available
2014-05-11 21:20:07 +02:00
Ben Alpert
6b1c546602
Add missing emitChange() to Flux docs
2014-05-10 17:50:26 -03:00
Ben Alpert
6b758ef283
Merge pull request #1503 from dybskiy/patch-2
...
Update flux-todo-list.md
2014-05-09 15:38:18 -03:00
Ben Alpert
39a0dbaebe
Start Flux video at 10m21s
2014-05-09 15:34:12 -03:00
Yuriy Dybskiy
d5a5840d31
Update flux-todo-list.md
...
Fix broken link to todomvc-flux repo
@spicyj cla signed
2014-05-09 11:11:42 -07:00
Daniel Lo Nigro
bf957c6c50
Fix minor typo
2014-05-09 10:01:40 -07:00
Brian Reavis
f399b68201
Stylistic changes.
2014-05-08 23:25:10 -07:00
fisherwebdev
39ec28f6f4
update Flux tutorial link
2014-05-08 19:57:19 -07:00
Christopher Chedeau
7f9a8385b6
Merge pull request #1499 from vjeux/flux
...
Flux blog post and tutorial
2014-05-08 16:26:43 -07:00
Vjeux
46995dd2fe
Flux blog post and tutorial
2014-05-09 01:22:47 +02:00
Paul O’Shannessy
c4ed2c1c90
Move tagtree image to docs/
...
Missed this in #1470
2014-05-08 11:52:32 -07:00
Paul O’Shannessy
8af991f10b
Codemod mockReturnValue externally
...
320024555c didn't update the mocks module
here, just the callsites.
2014-05-08 10:47:44 -07:00
Christopher Chedeau
320024555c
Codemod mockDefaultReturnValue
...
The naming is super confusing.
mockReturnValue -> mockReturnValueOnce
mockDefaultReturnValue -> mockReturnValue
2014-05-08 10:11:38 -07:00
Paul O’Shannessy
562b1b201e
Merge pull request #1492 from spicyj/rtg-from-false
...
ReactTransitionGroup: Fix moving from falsey child
2014-05-08 09:46:49 -07:00
Jon Beebe
c50dbb0ec1
Adds svg pattern and mask components
2014-05-08 07:16:28 -05:00
Paul O’Shannessy
32b84a4c5e
Merge pull request #1460 from spicyj/tg2
...
Actually fix transitioning to null
2014-05-07 17:12:05 -07:00
Andreas Svensson
aa044c6b61
Add support for JSX member expressions <React.DOM.div />
2014-05-08 00:10:10 +02:00
Paul O’Shannessy
aa46ab1862
Merge pull request #1486 from nbostrom/patch-1
...
Embed video from F8
2014-05-07 11:09:19 -07:00
Paul O’Shannessy
67c68612c0
Title case on videos page
2014-05-07 11:07:49 -07:00
Paul O’Shannessy
9926a2d7f9
Merge pull request #1490 from Vijar/master
...
Fixed incorrect usage of github api in example
2014-05-07 11:01:05 -07:00
Paul O’Shannessy
4a24283559
Merge pull request #1276 from marcins/bugfix/1275-transitiongroup-android
...
Fix transition end detection for Android
2014-05-07 10:54:37 -07:00
Paul O’Shannessy
c7c3027081
Small style fixup
2014-05-07 10:44:30 -07:00
Brian Reavis
bfcd4cac48
Use camelCase and declare MUST_USE_ATTRIBUTE.
2014-05-07 10:02:57 -07:00
Ben Alpert
5c9224145e
ReactTransitionGroup: Fix moving from falsey child
...
See http://stackoverflow.com/q/23510413/49485 .
Test Plan: grunt fasttest
2014-05-07 09:54:23 -03:00
Brian Reavis
2b196b7cd2
Updated documentation.
2014-05-07 00:41:50 -07:00
Brian Reavis
0fe2fcc27e
Added support for itemscope, itemtype, itemprop.
2014-05-07 00:37:06 -07:00
Rajiv Tirumalareddy
b360ed80dd
Fixed incorrect usage of github api in example
...
more: https://developer.github.com/v3/gists/#detailed-gist-representation
2014-05-06 16:42:07 -07:00
Christopher Chedeau
52e1b42d26
Merge pull request #1480 from volkanunsal/patch-1
...
Update Dispatcher.js
2014-05-06 16:40:14 -07:00
Jon Beebe
c50ad81b06
Adds svg mask and pattern dom components
2014-05-06 11:21:47 -05:00
Paul O’Shannessy
88c94683d6
Revert "Move defaultProps resolution and type validation to the descriptor"
...
This reverts commit ff52e3df00 .
Too many things broke with transferPropsTo
2014-05-06 09:09:51 -07:00
Niklas Boström
dea228e4ae
Embed video from F8
...
Edited in githubs inline editor. Not tested!
2014-05-06 15:18:02 +02:00
Sebastian Markbage
ff52e3df00
Move defaultProps resolution and type validation to the descriptor
...
This copies the propType and contextType validation to a wrapper around the
descriptor factory. By doing the validation early, we make it easier to track
down bugs. It also prepares for static type checking which should be done at the
usage site.
This validation is not yet active and is just logged using monitorCodeUse. This
will allow us to clean up callsites which would fail this new type of
validation.
I chose to copy the validation instead of abstracting it out to a common abstraction. This is just an
intermediate step to avoid spamming consoles. The original validation in the instance will be deleted as soon as we can turn on the warnings at the callsite. Copy+Delete makes this a more a much cleaner diff review/history.
Additionally, getDefaultProps are moved to become a static function which is
only executed once. It should be moved to statics but we don't have a
convenient way to merge mixins in statics right now. Deferring to ES6 classes.
This is still a breaking change since you can return an object or array from
getDefaultProps, which later gets mutated and now the shared instance is
mutated. Mutating an object that is passed into you from props is highly
discouraged and likely to lead to subtle bugs anyway. So I'm not too worried.
The defaultProps are now resolved in the descriptor factory. This will enable
a perf optimizations where we don't create an unnecessary object allocation
when you use default props. It also means that ReactChildren.map has access to
resolved properties which gives them consistent behavior whether or not the
default prop is specified.
This is a breaking change since it can affect how mapping over children and
transferPropsTo works together with defaultProps.
2014-05-05 17:03:54 -07:00
Paul O’Shannessy
b48a534f6f
Merge pull request #1032 from fforw/master
...
Additional SVG tag and attribute names
2014-05-05 16:54:57 -07:00
Ben Alpert
486b3c0bc5
Move envify from peerDependencies to dependencies
...
Fixes #1482 , closes #1483 .
This shouldn't make a practical difference to us and will apparently fix browserify-cdn.
2014-05-05 20:26:23 -03:00
Isaac Salier-Hellendag
d6731e7a0b
Merge pull request #776 from syranide/superkey
...
Even better normalization of KeyboardEvent + MouseEvent
2014-05-05 16:19:02 -05:00
Paul O’Shannessy
c253c786a9
Merge pull request #1468 from dschafer/tutorial
...
Update jsfiddles in thinking-in-react to remove handleSubmit from forms
2014-05-05 13:10:28 -07:00
volkanunsal
035a648a2d
Update Dispatcher.js
2014-05-05 12:20:25 -04:00
volkanunsal
c81c07c816
Update Dispatcher.js
2014-05-04 19:15:44 -04:00
volkanunsal
a7823a3624
Update Dispatcher.js
2014-05-04 19:08:46 -04:00
volkanunsal
31477dbf94
Update Dispatcher.js
...
I think Array.filter expects a boolean return value, am I correct?
2014-05-04 19:04:51 -04:00
Ben Alpert
f1096c6bb3
Fix ASCII-art arrow alignment
2014-05-03 23:45:12 -03:00
Paul O’Shannessy
064abe3d49
Merge pull request #1470 from hendrikswan/master
...
Link to tagtree 'Thinking in React' video - on master
2014-05-02 15:22:27 -07:00
Pete Hunt
b02a5dc0f8
Merge pull request #1479 from fisherwebdev/master
...
Clean up Flux documentation and add more info about dependencies btwn stores
2014-05-02 23:56:06 +02:00
fisherwebdev
b0f82bfe4c
Clean up Flux documentation and add more info about managing dependencies between stores
2014-05-02 13:22:15 -07:00
hendrik swanepoel
cdac160439
Fixed a couple of issues with link to tagtree.tv video
2014-05-02 21:28:31 +02:00
Paul O’Shannessy
0dd8f551c0
Merge pull request #1477 from KyleAMathews/patch-1
...
Typo in Flux example readme
2014-05-02 12:05:20 -07:00
Kyle Mathews
72b830ec4c
Typo
2014-05-02 11:10:13 -07:00
petehunt
fa154e6e21
Add some backticks to flux docs
2014-05-02 16:44:43 +02:00
Pete Hunt
d567f37bc3
Merge pull request #1476 from fisherwebdev/master
...
Additional Flux documentation
2014-05-02 16:42:20 +02:00
fisherwebdev
b97cf7a180
Additional Flux documentation
2014-05-02 07:17:49 -07:00
Andreas Svensson
bf7826c68d
Normalize and polyfill KeyboardEvent further, also MouseEvent+TouchEvent
...
KeyboardEvent now normalizes "charCode", "keyCode", "which" across all browsers
KeyboardEvent has partial "key"-support for KeyDown/KeyUp and full "key"-support for KeyPress.
KeyboardEvent, MouseEvent and TouchEvent now has "getModifierState", polyfill when not implemented.
2014-05-01 16:56:43 +02:00
hendrik swanepoel
6323db7c18
link to tagtree 'Thinking in React' video
2014-05-01 11:30:21 +02:00
dschafer
fbbace6b69
Update jsfiddles in thinking-in-react to remove onSubmit from forms
2014-04-29 19:53:13 -07:00
Ben Alpert
da34209148
Don't double-escape style names
...
Previously we were escaping both in createMarkupForStyles and then in createMarkupForProperty; now we escape only in the latter (otherwise the hypothetical style name `b&ckground` would become `b&amp;ckground`).
Test Plan: grunt fasttest
2014-04-29 15:50:12 -03:00
Christopher Chedeau
32d80aa5eb
Merge pull request #1462 from spicyj/lint
...
Fix some linty things
2014-04-29 11:34:30 -07:00
Christopher Chedeau
92a3e94528
Merge pull request #1459 from spicyj/ti
...
Move tooling info to Complementary Tools wiki
2014-04-29 11:33:50 -07:00
Christopher Chedeau
3eee27ebc8
Merge pull request #1463 from andreypopp/example-commonjs
...
Add basic CommonJS example with browserify
2014-04-29 10:58:14 -07:00
Andrey Popp
93fed1a459
Add basic CommonJS example with browserify
2014-04-29 21:57:08 +04:00
Ben Alpert
d5a4d29532
Fix some linty things
2014-04-28 23:30:05 -03:00
Ben Alpert
0d3622714c
Don't escape slash; it's unnecessary
...
Fixes #1444 .
Test Plan: grunt fasttest
2014-04-28 23:22:03 -03:00
Ben Alpert
4b51708ed2
Actually fix transitioning to null
...
Test Plan: grunt fasttest
2014-04-28 22:16:59 -03:00
Ben Alpert
05cc7b635c
Move tooling info to Complementary Tools wiki
...
I moved the info that was here to the wiki page: https://github.com/facebook/react/wiki/Complementary-Tools ; it doesn't need to live in the website any more.
2014-04-28 21:03:19 -03:00
Pete Hunt
b9e215d169
Merge pull request #1458 from spicyj/gh-1457
...
ReactTransitionGroup: Fix changing to null child
2014-04-28 17:00:22 -07:00
Ben Alpert
9dbbaf12bf
ReactTransitionGroup: Fix changing to null child
...
Fixes #1457 .
Test Plan: grunt fasttest
2014-04-28 20:52:42 -03:00
Paul O’Shannessy
d657479a9d
Merge branch 'spicyj-nested-render' from #1402
2014-04-27 13:15:58 -07:00
Cheng Lou
8b23a7e699
Warn instead of throw for nested render calls
2014-04-27 13:15:42 -07:00
Cheng Lou
3a796ab47c
Merge pull request #1455 from jeffmo/master
...
Bump jstransform dependency to point at 4.0.1 or higher
2014-04-26 15:38:32 -07:00
jeffmo
a7c3dc8b08
Bump jstransform dependency to point at 4.0.1 or higher
2014-04-26 15:34:40 -07:00
Pete Hunt
50eb9b3e50
Merge pull request #1452 from chenglou/perf-fix
...
Fix perf suite broken by descriptor change
2014-04-25 11:10:27 -07:00
Cheng Lou
5158a022df
Fix perf suite broken by descriptor change
2014-04-25 10:38:17 -07:00
Marcin Szczepanski
cc56629620
Fix transition end detection for Android
...
Some Android versions have the "transition" and "animation" properties
set on element style objects despite not supporting un-prefxied animations
and transitions. This change adds an additional sanity check to make sure
the correct event handlers are added for transition groups.
2014-04-25 13:19:25 +10:00
Paul O’Shannessy
28820e0adb
Merge pull request #887 from syranide/textdocument
...
Test innerText/textContent on document.documentElement instead
2014-04-24 16:10:13 -07:00
Paul O’Shannessy
83687b927d
Merge pull request #1450 from sahat/patch-1
...
Update build status svg badge
2014-04-24 15:45:19 -07:00
Sahat Yalkabov
f98995fe08
Update build status svg badge
2014-04-24 18:41:34 -04:00
Paul O’Shannessy
a0dc45e652
Merge pull request #879 from syranide/inlinechild
...
Remove unnecessary tests from insertChildAt and inline it instead
2014-04-24 15:02:14 -07:00
Andreas Svensson
a9a398b15a
Test innerText/textContent on document.documentElement instead
2014-04-24 23:51:05 +02:00
Andreas Svensson
9ee1d92b52
Remove unnecessary tests from insertChildAt and inline it instead
2014-04-24 23:44:41 +02:00
Isaac Salier-Hellendag
cc292c1e22
Fix IE11 collapsed ranges in ReactDOMSelection
...
In IE10/11, it is apparently possible to have a Selection or Range object that has the following properties:
- `anchorNode` === `focusNode` (Selection) or `startContainer` === `endContainer` (Range)
- `anchorOffset` === `focusOffset` (Selection) or `startOffset` === `endOffset` (Range)
- `isCollapsed` === `false` (Selection) or `collapsed` === `false` (Range)
As defined in http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html , this doesn't really make sense. Since the nodes and offsets are the same, the "collapsed" value should be `true`.
Moreover, when calling `selection.toString()` in this case, it appears that the entire text contents of `body` -- including `<script>` tag contents -- are considered within the selection. I thought maybe the selected nodes were missing from the DOM or something, but no, they're there.
Sidestep all of this in `ReactDOMSelection` by calculating the `collapsed` property manually and setting the selection length directly to zero if it is actually collapsed.
Side note: I think that for selection restoration on contenteditables, we shouldn't try to do this offset calculation. We should just use the structure provided natively (nodes and offsets) since we can restore using that structure as well.
2014-04-24 12:53:08 -07:00
Sven Helmberger
8e0d17c756
Add tspan to JSX transform
2014-04-24 19:13:01 +02:00
Sven Helmberger
0f0328f093
Current set of must-have SVG attributes / tag
...
The current set of SVG attributes / tag I felt like I needed
them absolutely for my React/SVG editor app.
2014-04-24 19:12:58 +02:00
Jeff Morrison
1b022e9b3a
Merge pull request #1441 from zpao/update-jstransform
...
Upgrade jstransform to 4.0
2014-04-23 16:49:11 -07:00
Cheng Lou
7fa656dae9
Don't let new keys on style from transferPropsTo override old ones
...
Previous behavior: `transferPropsTo(<div style={{color: 'red'}} />)` would get `color` overriden if we transfer in a `style={{color: 'blue'}}`. This is inconsistent with how other props are transfered.
This simply reverses the order of arguments.
closes #1435
2014-04-23 16:44:32 -07:00
Paul O’Shannessy
4ed9e22a44
Upgrade jstransform to 4.0
...
Also enables the object-concise-method transform for --harmony
closes #1438
2014-04-23 16:36:45 -07:00
Paul O'Shannessy
3d605da15f
Split DefaultDOMPropertyConfig
...
This makes it a little easier to add SVG properties. It also makes use of that injection that we claim is easy to use and will likely start playing a bigger part soon.
Closes #1009
2014-04-23 16:22:10 -07:00
Paul O’Shannessy
ff60e81fa9
Remove whitespace_transformer package
...
This was a one-time use thing, let's get rid of it. If we ever need to
push an update, we'll do it from the 0.9-stable branch.
2014-04-23 16:00:44 -07:00
Pete Hunt
df72bd76be
Update videos.md
2014-04-23 15:45:48 -07:00
Jan Kassens
514f5fb98b
fix warnings in cloneWithProps test
...
Don't test refs in this case, already testing warning above
2014-04-23 14:14:45 -07:00
Jan Kassens
9e9d8dbe76
fix warnings in ReactComponentLifeCycle test
...
Don't use inputs to avoid warnings in tests
2014-04-23 14:14:42 -07:00
Jonas Gebhardt
01d41f6e18
better error message for React EventPlugin order check
...
Ran into this while inadvertently requiring multiple React versions in a separate project (`require('react');` vs `require('React');`
2014-04-21 15:42:25 -07:00
Jan Kassens
4c199daa26
fix log spew from ReactDOMTextarea test
...
Similar to previous but for textarea. If `value` is set, we have to also set
`onChange` to avoid warnings.
2014-04-21 15:42:00 -07:00
Jan Kassens
089146b2f8
fix log spew from ReactDOMInput test
...
The prop validation threw a warning that either `onChange` or `readOnly` is required. Set the `onChange` where needed.
2014-04-21 15:41:50 -07:00
Paul O'Shannessy
c8933b947b
unbreak server-side/web worker
...
We're now trying to access document directly at require time. Wrapping in a function prevented that before. But we can simply check what environment we're in first.
2014-04-20 11:44:01 -07:00
Juraj Dudak
385eb1cef1
Fixed a bug in expectRenderedChildAt
...
React components have _mountIndex, that looks like it is their order in DOM.
If you swap 2 elements in DOM, their order in children array isn't changed, but their _mountIndex is
2014-04-18 12:57:24 -07:00
Christoph Pojer
9a13393ce3
Remove function wrappers in DOMSelection
...
There is no point in doing the feature detection on every call, unless there is an IE bug where it is not sure about which support for selection it has (totally plausible).
2014-04-18 12:57:05 -07:00
Jonas Gebhardt
3a49ee7d82
Add typed ReactLink to ReactProps
...
Adds a PropType that checks for proper use of the ReactLink API and optionally validates the type of value passed in via the link. Basically, it's a wrapper around PropTypes.shape that hides the implementation of ReactLink.
2014-04-18 12:56:46 -07:00
Cheng Lou
0a5c22264b
Make custom PropTypes return error rather than whatever
...
The new rule for PropTypes is that it should return an error object if validation fails, not throw, not warn.
2014-04-18 12:56:25 -07:00
Cheng Lou
4487831281
Allow false as an acceptable renderable type value
...
`false` is renderable.
2014-04-18 12:56:06 -07:00
Cheng Lou
3ee081b125
Merge pull request #1188 from spicyj/comp-spec-inv
...
Add clearer invariants to composite spec mixing
2014-04-17 12:50:29 -07:00
Cheng Lou
13f799ee8e
Merge pull request #1419 from spicyj/inv-process
...
Add clearer invariant in processUpdates
2014-04-17 01:30:58 -07:00
Ben Alpert
7fb7e95108
Add React.batchedUpdates to public API
...
Fixes #906 .
2014-04-16 15:59:54 -07:00
Ben Alpert
945d041160
Add clearer invariant in processUpdates
...
The `updatedChildren[j].parentNode.removeChild(updatedChildren[j]);` line below can fail if (1) we're moving/moving the same node twice or (2) the node we're looking for is gone completely. This makes it easier to distinguish between the two cases.
Perf shouldn't be a concern here because this is DOM code and invariants are fast in comparison.
Test Plan: grunt test
2014-04-16 15:09:31 -07:00
Cheng Lou
e9c00b1bae
Remove grunt-complexity
...
The report itself is more or less useful because it detects stuff like
big objects (e.g. CSSProperty) as being too complicated. Furthermore, afaik
nobody refactors the code based on what the report says =).
2014-04-16 11:52:25 -07:00
Paul O’Shannessy
b3f5e863e0
Merge pull request #1340 from matthewwithanm/download-attribute
...
Support download attribute properly
2014-04-15 16:30:30 -07:00
Cheng Lou
7832b94114
Merge pull request #1412 from gasi/patch-3
...
Match `setTimeout` delay with documentation
2014-04-15 13:47:20 -07:00
Daniel Gasienica
663dd6f5b3
Match setTimeout delay with documentation
2014-04-15 13:45:09 -07:00
Paul O’Shannessy
0dcbfe831a
Merge pull request #1410 from spicyj/sih
...
Don't try to detach a detached node
2014-04-15 12:59:57 -07:00
Ben Alpert
cc0233dd76
Don't try to detach a detached node
...
Test Plan: grunt test
2014-04-15 11:27:46 -07:00
Ben Alpert
c9767c2822
Guard top-level methods, not in every render call
...
Test Plan: grunt test
2014-04-15 00:03:02 -07:00
Matthew Dapena-Tretter
32a7a1cedb
Rename "booleanish" to "overloaded boolean"
2014-04-14 23:00:25 -04:00
Cheng Lou
c6df1c2dd2
Fix PropType for travis
...
closes #1404
2014-04-14 17:20:50 -07:00
Paul O’Shannessy
717eacdb64
Merge pull request #1183 from lrowe/patch-6
...
meta http-equiv attribute name
2014-04-14 17:03:16 -07:00
Ben Alpert
f27175d166
Fix preposition capitalization
2014-04-14 16:28:46 -07:00
Ben Alpert
14580fb012
Update refs example code to use onChange
...
Fixes #1408 .
Test Plan: Copy each code snippet into jsbin; type in the text box successfully; click the button and see the input clear (and in the second example, get focused).
2014-04-14 16:23:37 -07:00
Pete Hunt
d5533cfb6d
Add docs for fasttest
2014-04-14 14:27:23 -07:00
Pete Hunt
d44b6c41d2
Merge pull request #1406 from petehunt/testperf
...
Improve `grunt test` performance
2014-04-14 13:45:08 -07:00
petehunt
2220f0478c
Drastically improve test performance
2014-04-14 11:32:36 -07:00
Cheng Lou
b9c50ee8fd
Merge pull request #1403 from spicyj/keyword-spacing
...
Make code spacing more consistent
2014-04-14 11:06:11 -07:00
Paul O’Shannessy
4c7422f4d3
Merge pull request #1384 from chenglou/render-docs
...
[Docs] Rendering null/false and getDOMNode
2014-04-14 10:15:14 -07:00
Paul O’Shannessy
34c9e142dc
Merge pull request #1386 from georgesisco/master
...
In the tutorial, carry ajax error checking from step 13 forward to other ajax steps
2014-04-14 10:14:35 -07:00
Laurence Rowe
b5017c26b4
meta http-equiv attribute name
2014-04-13 17:56:03 -04:00
Cheng Lou
ea361e884e
Merge pull request #1284 from plievone/directives-2-commands
...
[addons] Renamed update() directives to commands
2014-04-13 14:25:38 -07:00
Ben Alpert
f923933ef3
Make code spacing more consistent
...
I'm a little surprised we don't have lint rules for this.
2014-04-13 14:25:11 -07:00
Cheng Lou
716dcead3a
Merge pull request #1405 from spicyj/css-tests
...
Restore CSSTransitionGroup tests
2014-04-13 14:23:53 -07:00
Cheng Lou
3c27f8564d
Merge pull request #1324 from jordwalke/executeDispatchesInOrder
...
Make EventPluginUtils clear dispatchIDs and dispatchListeners
2014-04-13 00:23:26 -07:00
Ben Alpert
b918f7fc07
Restore CSSTransitionGroup tests
...
Not sure what happened here.
Test Plan: grunt test
2014-04-12 17:05:29 -07:00
Ben Alpert
382be4e9e9
Improve error for nested render calls
...
In the future we could consider wrapping the entire public API (renderComponent, setProps, setState, etc) in this check but this should do for now.
Test Plan: grunt test
2014-04-12 15:37:48 -07:00
Cheng Lou
775d2a3952
Merge pull request #1184 from spicyj/setInnerHTML
...
Consolidate innerHTML setting logic
2014-04-12 00:58:37 -07:00
Ben Alpert
534e7c06e9
Consolidate innerHTML setting logic
...
See https://github.com/facebook/react/commit/7eb33ef#commitcomment-5447724 .
2014-04-12 00:41:54 -07:00
Cheng Lou
ed1b4dbfb5
Merge pull request #1394 from spicyj/gh-1164
...
Add test for isValidDescriptor
2014-04-11 20:48:29 -07:00
Cheng Lou
f4f6b055df
Merge pull request #1190 from spicyj/custom-set-null
...
Remove custom attrs properly when setting to null
2014-04-11 18:02:02 -07:00
Ben Alpert
b067556a93
Merge pull request #1390 from chenglou/doc-new-proptypes
...
[Docs] new PropType behavior
2014-04-11 17:42:27 -07:00
Cheng Lou
acc9bde1f3
[Docs] new PropType behavior
...
(Killed the TODOs since they're no longer valid).
2014-04-11 17:40:04 -07:00
Paul O’Shannessy
3e2182fd16
Merge pull request #1231 from spicyj/gh-1227
...
Batch updates caused by handlers in multiple roots
2014-04-11 17:16:04 -07:00
Paul O'Shannessy
3bf12bba0d
add displayName to component spec functions
...
closes #992
2014-04-11 16:39:45 -07:00
Cheng Lou
d673e51044
Make PropType.object pass for Date and RegExp instances
...
8855d6153e gave more accurate error messages for date and regexp by returning 'date' and 'regexp' respectively from `getPropType`.
However, for the object primitive check, which compares the instance passed with `getPropType's` return string, `object` !== 'date'.
This adds special hanlding for those.
2014-04-11 16:39:02 -07:00
Paul O’Shannessy
ef81148b09
Merge pull request #925 from chenglou/rm-comm
...
[Docs] Remove comment section
2014-04-11 11:43:23 -07:00
Paul O’Shannessy
cb2e394b9c
Merge pull request #1285 from justinj/weak-shape-checker
...
Add tests for oneOfType with shape
2014-04-11 11:38:05 -07:00
georgesisco
287db7017e
Update tutorial.md
2014-04-10 14:51:10 -04:00
Matthew Dapena-Tretter
1c63a3a7f4
Test more falsey values
2014-04-10 09:21:56 -04:00
Matthew Dapena-Tretter
4b71cf2efe
Combine valid value checks
2014-04-10 09:21:56 -04:00
Matthew Dapena-Tretter
77ae237be9
Rename CAN_BE_MINIMIZED to HAS_BOOLEANISH_VALUE
2014-04-10 09:18:39 -04:00
Matthew Dapena-Tretter
422a8d9c2c
Support minimizable, non-boolean attributes
...
Fixes GH-1337
2014-04-10 09:17:39 -04:00
Matthew Dapena-Tretter
13351dd937
Test for correct handling of "download" attribute
...
These tests currently fail as there is no special treatment for this kind of
attribute.
Related: GH-1337
2014-04-10 09:12:35 -04:00
Cheng Lou
f728846712
docs remove comment section
2014-04-09 22:53:54 -07:00
Ben Alpert
697bf73c5f
Add test for isValidDescriptor
...
Fixes #1164 .
Test Plan: grunt test
2014-04-09 22:53:22 -07:00
Justin Jaffray
f88936977f
Add tests for oneOfType with shape
2014-04-09 22:23:43 -07:00
Cheng Lou
e17222671e
[Docs] Rendering null/false and getDOMNode.
2014-04-09 19:26:42 -07:00
Cheng Lou
8855d6153e
Revamp and fix PropTypes
...
This uses the return value (an Error or nothing) to indicate whether a prop passes validation or not. It used to be done through calling `console.warn` as a side-effect, except this didn't work well with and `oneOfType`, which calls each validator.
The solution was to insert a `.weak` prop to each validator to suppress the warning message. This is overkill and also doesn't work well in because it increases the potential API surface. Plus, letting the validators warn it can't be easily used for logging, especially for custom validators.
So `.weak` is no longer needed: fixes https://github.com/facebook/react/issues/863 .
Backward compatibility for custom validators: since they didn't return anything and directly call `console.warn` or something, this doesn't break them.
Improvements:
- `arrayOf`, `oneOfType` and `oneOf` got better message now, since they can get hold of their validator's message and output that instead of a generic `warning: bla`.
- More complete tests, including testing custom types and `isRequired` on everything.
Bug fixes:
- oneOfType(...).isRequired didn't work. The workaround was to use `oneOfType(a.isRequired, b.isRequired, ...)`. This means `oneOfType(a.isRequired, b)` doesn't make sense. The new version simply makes `oneOfType(...).isRequired` possible.
- `oneOf([true])` worked for 'true' boolean because it converted everything to string before comparing. It no longer does.
- `oneOf([true]).isRequired` didn't work.
(see #1294 )
2014-04-09 18:50:53 -07:00
Cheng Lou
5a9d0c6a12
Update invalid render error message
...
forgot to update the message following the previous diff on rendering null.
2014-04-09 18:50:11 -07:00
Tim Yung
356e85cd6a
Separate performanceNow into own project
2014-04-09 18:50:11 -07:00
Josh Yudaken
5c9d616735
Add start property that is used by the <ol> tag
...
Property was missing
2014-04-09 17:50:34 -07:00
George A Sisco III
af7ea7c999
Carry ajax error checking from step #13 forward to other ajax steps
...
The following steps also have an ajax function, but the 'error:' param
is gone after #13 :
#14
#17
#19
#20
This may be superfluous, but it helped me find an error with something I
was doing - Namely, in my .json file, I had single line javascript
comments ("//") that I copied from the tutorial. I couldn't find the
issue on later steps, but was able to see my issue when the error
handler complained about an unexpected "/" in my file in step #13 .
2014-04-09 13:42:13 -04:00
Ben Alpert
4f1ca0ee96
Merge pull request #1381 from marcinkwiatkowski/master
...
fix typo in 09.4-test-utils.md
2014-04-09 10:05:40 -07:00
Ben Alpert
ddf53f97f0
Share reconcile transaction in batched updates
...
Should make #1350 better and will also take away any performance hit from #1157 .
Test Plan:
grunt test
2014-04-09 01:42:27 -07:00
Paul O’Shannessy
bff6d50796
Merge pull request #1364 from spicyj/key-collisions-2
...
Ignore children with clashing keys
2014-04-08 18:11:36 -07:00
Marcin Kwiatkowski
5167b7a5b2
fix typo in 09.4-test-utils.md
2014-04-09 01:31:02 +01:00
Paul O’Shannessy
debd3318c7
Merge pull request #1379 from fkling/patch-1
...
Update 05-reusable-components.md
2014-04-08 15:45:19 -07:00
Felix Kling
af79caf1aa
Update 05-reusable-components.md
...
`any` also seems to accept primitive values, not only objects. And since we already have `React.PropType.object`, the description was confusing.
2014-04-08 15:43:24 -07:00
Christopher Chedeau
009be62906
Document multiple ways to insert comments in JSX
2014-04-08 15:24:09 -07:00
Paul O’Shannessy
ccafb030cb
Merge pull request #813 from spicyj/e-view-detail
...
Normalize view and detail properties
2014-04-08 14:23:46 -07:00
Ben Alpert
348399a594
Let early returns do their thing
2014-04-08 14:08:16 -07:00
Ben Alpert
4d62e1ef59
Don't fail if target.ownerDocument is null
...
See f71dbab .
2014-04-08 14:08:16 -07:00
Ben Alpert
5fa001b12c
Normalize view and detail properties
2014-04-08 14:08:16 -07:00
Cheng Lou
f0f59877aa
Make rendering to null work and make it injectable
...
This allows render to return `null`. Under the hood, this renders a `script` tag.
closes #1127
2014-04-08 10:12:18 -07:00
Paul O'Shannessy
af3c04b43b
Warn better for key issues
...
We weren't warning for key issues at the top level (renderComponent)
level at all. This makes us do that, even if it's not quite perfect.
closes #1351
2014-04-07 18:18:50 -07:00
Karl Mikkelsen
f0a8a397ac
Link to Events from Forms
...
closes #1372
2014-04-07 17:47:41 -07:00
Paul O’Shannessy
127e964808
Merge pull request #1362 from spicyj/cb-queue
...
Make MountReady more reusable, reduce allocations
2014-04-07 15:46:34 -07:00
Paul O’Shannessy
7f9ab471ac
Merge pull request #1365 from akre54/unminified-docs-js
...
Serve unminified react.js on docs site
2014-04-07 15:42:50 -07:00
Ben Alpert
216fcdeb42
Ignore children with clashing keys
...
Fixes #566 .
2014-04-07 13:50:42 -07:00
Paul O’Shannessy
40cbc074ee
Move complementary tools to wiki for easier management.
2014-04-07 12:56:38 -07:00
Pete Hunt
b75d11c603
Merge pull request #1356 from petehunt/server-rendering-example2
...
React server rendering example
2014-04-08 07:27:58 +12:00
Ben Alpert
6cafc638fa
Don't forcibly wrap lines in git commit messages
2014-04-06 23:17:51 -07:00
Adam Krebs
a6211a0fd8
Serve unminified react on docs site. Fixes #1359
2014-04-07 02:13:59 -04:00
Ben Alpert
59d2420b05
Add clearer invariants to composite spec mixing
2014-04-06 21:16:38 -07:00
Ben Alpert
ec6da04f6a
Make MountReady more reusable, reduce allocations
...
Test Plan:
grunt test
2014-04-06 17:06:12 -07:00
petehunt
9a78db3457
Initial add
...
Add readme
remove gitignore
fix graphic
2014-04-04 18:47:33 -07:00
Daniel Lo Nigro
21de5c816f
ReactJS.NET blog post
...
Closes #1354 .
2014-04-04 13:23:24 -07:00
Ben Alpert
ed0ef164c0
Fix appearance of code blocks in lists
2014-04-04 12:55:43 -07:00
Jeff Morrison
9c2b9b1eb6
Merge pull request #970 from syranide/jsxws
...
Normalize whitespace for transformed JSX code
2014-04-04 10:20:43 -07:00
Paul O’Shannessy
0617696ae4
Merge pull request #1251 from davidxi/patch-1
...
Update jasmine-support.js
2014-04-03 18:41:59 -07:00
Ben Alpert
933dde9c6d
Batch updates caused by handlers in multiple roots
...
Fixes #1227 .
It seems rare that event handlers in two roots nested in the DOM will update the same component in the same tick, but if that happens, the updates should be batched together.
2014-04-03 17:41:04 -07:00
Paul O’Shannessy
ed6f8aea77
Merge pull request #1258 from fisherwebdev/master
...
TodoMVC Flux Example
2014-04-03 15:10:42 -07:00
Paul O’Shannessy
4f6800c2a4
Merge pull request #1306 from twobit/master
...
Add dx and dy attributes for SVG text
2014-04-03 15:05:44 -07:00
Paul O’Shannessy
00aa33446b
Merge pull request #1325 from venmo/add-scrolling-attribute
...
Add scrolling attribute for <iframe>
2014-04-03 09:56:07 -07:00
Paul O’Shannessy
079749bac6
Merge pull request #1338 from chenglou/tip-children
...
[Docs][Tips] Entry on this.props.children and tweak component ref entry
2014-04-03 09:30:53 -07:00
Paul O’Shannessy
0aba933911
Merge pull request #1313 from spicyj/ms-prefix
...
Support `ms` vendor prefix when generating markup
2014-04-03 09:25:41 -07:00
Ben Alpert
67ff4e5050
Add acknowledgement to Christopher Aue
2014-04-03 07:33:32 -07:00
Ben Alpert
2d66fc4518
Add callback to setProps docs
2014-04-02 15:01:50 -07:00
Sebastian Markbage
b44761135e
Remove toJSON
...
This was temporarily needed since clone on mount introduced a cyclic reference
in __DEV__. This reverts that change since we now have descriptors.
To avoid a problem where toJSON may collide.
2014-04-01 17:07:57 -07:00
Paul O’Shannessy
8ccb363a8e
Merge pull request #1308 from chenglou/pure
...
add `ReactComponentWithPureRenderMixin` to addons
2014-04-01 14:32:18 -07:00
Ben Alpert
e86f7671a0
Merge pull request #1345 from kmeht/referenceDoc
...
[docs] Amend "References to components" tip to mention descriptors.
2014-04-01 13:40:22 -07:00
Kunal Mehta
93a033a94f
Remove erroneous line about static methods.
2014-04-01 13:36:56 -07:00
Kunal Mehta
d236a0538d
Simplify comment.
2014-04-01 13:04:09 -07:00
Kunal Mehta
da27fb049a
[docs] Amend "References to components" tip to mention descriptors.
2014-04-01 11:42:15 -07:00
Paul O’Shannessy
c8fc3e38ab
Merge pull request #1329 from irae/transition-group-leftovers
...
Remove leftovers from ReactTransitionGroup rewrite
2014-04-01 10:16:53 -07:00
Paul O’Shannessy
a2ed61ee66
Update mailmap post 0.10 (see #1283 )
2014-04-01 09:30:08 -07:00
Cheng Lou
dc7242c786
[Docs][Tips] Entry on this.props.children and tweak component ref entry
...
Component ref entry wasn't registered in nav_tips.
2014-03-31 19:13:16 -07:00
Ben Alpert
f63d0fe2b4
Merge pull request #1336 from Daniel15/making-zpao-happy
...
[Docs] Consistent use of self-closing tags in layout
2014-03-30 22:43:15 -07:00
Daniel Lo Nigro
306209be9e
[Docs] Consistent use of self-closing tags in layout
2014-03-30 22:42:02 -07:00
Ben Newman
60d16be90b
Merge pull request #1330 from spicyj/clone-imm
...
Clone objects in immutable tests.
2014-03-30 19:25:56 -04:00
Ben Alpert
42e20a1488
Fix jshint warnings in grunt/
...
Fixes #1052 .
Test Plan:
jshint grunt
2014-03-30 16:09:08 -07:00
Cheng Lou
7cbbff01e7
Merge pull request #1334 from spicyj/non-numeric-top-level
...
Don't break on top-level non-numeric object keys
2014-03-30 14:03:18 -07:00
Ben Alpert
a89ed9b8dc
Don't break on top-level non-numeric object keys
...
Previously, this threw (in `__DEV__` only) in `ReactCurrentOwner.current.constructor.displayName` because `ReactCurrentOwner.current` is null:
```
React.renderComponent(<div>{{1: <div />, 2: <div />}}</div>, document.body);
```
2014-03-30 13:55:45 -07:00
Christopher Chedeau
f99123b882
Merge pull request #1332 from chenglou/linter
...
[Jshint] Allow Jasmine globals in *-test.js
2014-03-30 13:13:49 -07:00
Stephen Murphy
468007612f
Merge branch 'master' of github.com:facebook/react
2014-03-30 12:53:26 -07:00
Cheng Lou
09ca4a9c80
[Jshint] Allow Jasmine globals in *-test.js
...
Editors that inline lint use`.jshintrc and directly lint the open
*-test.js files. This makes those linters actually useful.
2014-03-30 12:52:49 -07:00
Ben Alpert
99e943dd13
Clone objects in immutable tests
...
Fixes #1314 , fixes #1328 .
Test Plan:
`grunt test`, `grunt test --debug` in Chrome and Firefox.
2014-03-29 17:01:23 -10:00
Irae
27ea2c7e51
Remove leftovers from ReactTransitionGroup rewrite
...
Looks like while rewriting @petehunt forgot to remove this block.
See: 9ac27cb551
This block used to contain the only `runNextTick` ocurrences in the whole project.
No tests broken after removal, no documentation affected.
2014-03-29 14:46:02 -07:00
Thomas Boyt
8a69b5bc98
Add scrolling attribute for <iframe>
2014-03-29 13:41:34 -04:00
Jordan W
08baa114cc
Make EventPluginUtils clear dispatchIDs and dispatchListeners
...
The other dispatch utils clear these out and I found a bug where they weren't being cleared out.
I'm thinking this should probably be done in the `SyntheticEvent` constructor but at least this way it's consistent. Also, I know no one else uses `executeDispatchesInOrderStopAtTrue` except the `ResponderEventPlugin`.
2014-03-29 01:17:20 -07:00
Christopher Chedeau
70a8c55023
Merge pull request #1288 from vjeux/server_docs
...
Add client/server mention in componentDid/WillMount documentation
2014-03-28 23:24:20 -07:00
Christopher Chedeau
98ef7abb1a
Merge pull request #1322 from spicyj/transformer-harmony
...
Add optional harmony support to browser transform
2014-03-28 23:22:17 -07:00
Ben Alpert
e6c93f9246
Add optional harmony support to browser transform
...
This mirrors the react-tools API; it doesn't include support (yet) for transforming `<script type="text/jsx">` blocks with the ES6 transforms, mostly because I don't have a good API in mind there.
Test Plan:
Ran
JSXTransformer.transform("var two = () => 2;", {harmony: true}).code
in Chrome's dev console and got back some ES5 code.
2014-03-28 18:26:20 -10:00
Cheng Lou
999b4cf1a8
Merge pull request #1318 from spicyj/existence
...
Fix spelling of 'existence'
2014-03-28 20:27:38 -07:00
Ben Alpert
4cb83566e0
Merge pull request #1320 from gasi/patch-2
...
Fix minor typo in `update` `$push` directive
2014-03-28 13:35:04 -10:00
Daniel Gasienica
5fc2ecbe92
Fix minor typo in update $push directive
2014-03-28 16:33:03 -07:00
Josh Duck
e5c8831f90
Formatting
...
An extra "`" snuck in there.
2014-03-28 14:26:05 -07:00
Ben Alpert
c0de6b51ff
Fix spelling of 'existence'
2014-03-28 10:44:03 -10:00
Paul O’Shannessy
a778bf2c51
[blog] The Road to 1.0
2014-03-28 13:38:28 -07:00
Paul O’Shannessy
7982ba0571
Merge pull request #1310 from plievone/patch-1
...
Fix hasOwnProperty check typo in mixStaticSpecIntoComponent
2014-03-28 13:09:14 -07:00
Isaac Salier-Hellendag
807e3dc423
BeforeInputEventPlugin: Support Opera <= 12
...
Add support for Opera <= 12 (Presto) in `BeforeInputEventPlugin`.
It turns out that Opera 12 has a `TextEvent` in `window`, but doesn't actually fire any input events. Even `input` apparently doesn't fire. Fall back to keypress handling in this case.
2014-03-28 12:33:10 -07:00
Sebastian Markbage
c40e06f728
First phase to true descriptors
...
This moves all convenience constructors to use frozen ReactDescriptors.
2014-03-28 12:32:53 -07:00
Tom Occhino
a91c9f38f8
Update CONTRIBUTING.md
...
Updating doc to point to the brand new CLA form at https://code.facebook.com/cla
2014-03-27 23:57:32 -07:00
Ben Alpert
6406183f78
Support ms vendor prefix when generating markup
2014-03-27 19:46:02 -10:00
Paul O'Shannessy
fe9cecd507
Clean up assertions on descriptors
...
By making this fail, we catch a lot of tests that are expecting rendered
instances but are actually operating on descriptors.
2014-03-27 13:41:18 -07:00
Pete Hunt
976826aec0
Remove extraneous assert
2014-03-27 13:41:10 -07:00
plievone
65d16883a5
Fix hasOwnProperty check typo in mixStaticSpecIntoComponent
2014-03-27 21:21:12 +02:00
Cheng Lou
858fd2e4e2
Merge pull request #1309 from spicyj/dom-arg-order
...
Fix docstring arg order in createDOMComponentClass
2014-03-27 11:42:52 -07:00
Cheng Lou
0a483e3799
add ReactComponentWithPureRenderMixin to addons
2014-03-27 11:27:45 -07:00
Ben Alpert
3cdef1a86a
Fix docstring arg order in createDOMComponentClass
2014-03-27 08:27:19 -10:00
Stephen Murphy
94c2f961fd
added dx and dy for laying out text with relative offsets
2014-03-26 16:57:50 -07:00
fisherwebdev
85339bfdae
TodoMVC Flux Example
2014-03-26 12:13:17 -07:00
Isaac Salier-Hellendag
5476f9168b
Repair spacebar textInput
...
Browsers that natively support the `textInput` event appear to have a bug: when preventing default behavior for a `textInput` event occurring for a spacebar keypress, the character is prevented from being inserted **but the browser scrolls down**.
Minimal repro example: http://jsfiddle.net/salier/bX4fw/
This is ridiculous, since scrolling makes no sense when the user is focused in a textinput or contenteditable. Preventing default at the `textInput` stage should mean to prevent the character from being inserted, and should have no impact at all on scrolling behavior. I have filed this as a Chromium bug (https://code.google.com/p/chromium/issues/detail?id=355103 ) but I'm not going to hold out much hope that they'll fix it.
To resolve this, I'm special-casing the spacebar character at the plugin level, in `BeforeInputEventPlugin`. I looked for ways to do this at the component level, but it seems to me that this is simply a browser bug and it's cleaner to handle it there.
In browsers that can use the native `textInput` event, I'm checking the code of the pressed key. If it's the spacebar, we dispatch the synthetic event as if there were no native `textInput` event -- as if we were running Firefox. Then, if the synthetic event is not canceled and we make it through to the native `textInput` event, bail if the character data is a space character.
2014-03-25 13:05:44 -07:00
Cheng Lou
09333a3819
Remove last uses of {' '} in docs and tests
...
Whitespace fix is in, so no need for {' '} anymore.
2014-03-25 13:05:44 -07:00
Cheng Lou
edc0fa4c3f
assertValidProps for updating DOM components through renderComponent
...
`renderComponent(<div style={invalidType}/>, container)` throws correctly,
but not when it's called a second time (i.e. updating rather than mounting).
It goes through `ReactDOMComponent.updateComponent` but there wasn't a
props assertion there.
(Removed the assertion in `receiveComponent`)
2014-03-25 13:05:44 -07:00
Isaac Salier-Hellendag
116ee058eb
TextInputEventPlugin, SyntheticTextInputEvent
...
This diff introduces `TextInputEventPlugin` and `SyntheticTextInputEvent`, which are based on Webkit's native `textInput` event.
In Chrome, Safari, and Opera, the `textInput` event fires prior to the insertion of character data into the document. For normal typing, for example, thevent sequence is: `keydown`, `keypress`, `textInput`, `input`, `keyup`. The `textInput` event contains a `data` field corresponding to the character data that will actually be inserted.
There is also a `beforeinput` event described by http://www.w3.org/TR/DOM-Level-3-Events/#event-type-beforeinput , and this is essentially that event, so it may make sense to rename the plugin.
This event is especially useful because it solves a number of issues we can't currently handle with only keypress and composition events:
- **Windows Chrome: Trailing characters discarded in Korean IME.** For instance, `안녕하세요` becomes `안녕하세` with the final character discarded by the final `compositionend` event. The `textInput` event fires correctly with the final character.
- **Windows Chrome: Special characters discarded in IME.** Certain ideographs are discarded in IME mode. In Japanese, typing the ideographic space character is not represented by keypress but //is// represented by the subsequent `textInput`. This issue also applies to punctuation characters in Chinese.
- **OSX Chrome: Characters from palette discarded.** Inserting characters from the OSX character palette fails, since no keypress is fired.
The plugin is useful for Firefox and IE. For these, we record inserted characters via keypress and compositionend events and dispatch the synthetic event with these characters as the `data` field to match the native `textInput` event.
- Firefox has no corresponding `textInput` event and has not yet implemented `beforeinput`.
- IE has a native `textinput` event, but it fires after the DOM mutation has already occurred, so it isn't very useful as an analog to the Webkit version. I'm just not going to bother with it.
2014-03-25 13:05:44 -07:00
Christoph Pojer
f10f32aaaf
Remove objMapKeyVal
2014-03-25 13:05:44 -07:00
Christoph Pojer
6cbeee1e59
Rename objMap to mapObject
...
mapObject fits better with other module names ("flattenChildren", "traverseAllChildren" etc.) and highlights that it only works with objects - which is going to be more important once we'll have an ES6 Map polyfill.
2014-03-25 13:05:43 -07:00
Mark IJbema
89a2157914
Only stop if the transition on this element ended
...
This way it doesn't end when some random element elsewhere on the page has an ending transition.
It must be noted that this is not a complete fix. If you have multiple transitions on the element, it still ends when the first ends.
I ran into this not working (the transition ends almost immediately, because some unrelated transition ends). This fixes it for me, but I was wondering whether this cornercase was considered, and whether the other cornercase (multiple transitions) was considered.
I think it's very hard to get this correct, and think it might be better to make the timeout explicit, or at least allow to set it explicit, and fall back to this behaviour. But I'm really interested in feedback on this one.
2014-03-25 15:02:12 +01:00
Christopher Chedeau
e55b9aa059
Add client/server mention in componentDid/WillMount documentation
2014-03-22 12:18:12 -07:00
plievone
c5bf2ada4b
[addons] Renamed update() directives to commands
2014-03-22 01:40:05 +02:00
Paul O’Shannessy
f0eae5086b
version bump for 0.11 development
2014-03-21 14:58:52 -07:00
Paul O’Shannessy
aea3949062
0.10 release materials
2014-03-21 14:57:03 -07:00
Paul O’Shannessy
3b2d176f59
Update AUTHORS for 0.10
2014-03-21 13:21:20 -07:00
Pete Hunt
68da0eccbe
Merge pull request #1282 from jeffbski/addCodewinds004Videos
...
add CodeWinds episode 4 w/Pete Hunt to videos
2014-03-21 12:54:48 +00:00
Jeff Barczewski
593889b87a
add CodeWinds episode 4 w/Pete Hunt to videos
...
Added to videos.md
2014-03-21 07:41:06 -05:00
Paul O’Shannessy
732f4717a6
Merge pull request #1186 from chenglou/doc-toString-opt
...
[Docs] document optional param for renderComponentToString
2014-03-20 17:28:51 -07:00
Ben Newman
7807413256
Upgrade Commoner to v0.9.2 to silence deprecation warnings.
...
Closes #1278 .
2014-03-20 14:43:47 -04:00
Ben Alpert
ec893833ee
Merge pull request #1273 from wincent/typo-fix-02
...
Fix a minor typo in the `update()` docs
2014-03-19 15:37:30 -07:00
Greg Hurrell
5aaf4dbae9
Fix a minor typo in the update() docs
2014-03-19 15:33:43 -07:00
Paul O’Shannessy
ecea2918cf
0.10rc blog post
2014-03-18 22:15:16 -07:00
Paul O’Shannessy
7f24943e5a
update version for 0.10rc
2014-03-18 22:09:32 -07:00
Paul O’Shannessy
0491d30e7c
re-enable moved root warning
2014-03-18 22:03:25 -07:00
Paul O’Shannessy
55b0222596
Upgrade browserify
2014-03-18 21:33:39 -07:00
Paul O’Shannessy
b95fbbe4a2
Silence tests unsupported in PhantomJS.
...
These tests can still be run in the browser using `grunt test --debug`.
This is a repeat of 42f8d155f8 . For posterity, we
do this because Phantom has a problem with Object.freeze and the test runner
can't do __DEV__ right (because we get rid of that in the build step).
2014-03-18 17:48:16 -07:00
Kunal Mehta
e505e47e01
Separate immutable project
...
This moves Immutable and Immutable object into the new `immutable` project.
2014-03-18 15:03:26 -07:00
Sebastian Markbage
e0c487649d
Logging use of objects as maps for children
...
Let's start logging objects as maps for children. We may want to deprecate this
and replace it with ImmutableMap and Map data structures instead.
This should ideally be logged in the recursive function but since that loses the
scope of where these children are passed it's easier to start tracking them
here to get an idea of how frequently and where it's used.
2014-03-18 15:01:51 -07:00
Andrew Zich
22057ef61c
don't try to use Object.prototype methods as transfer strategies in ReactPropTransferer.mergeProps
...
While looking up a detail of how `transferPropsTo()` works I noticed that we never check `TransferStrategies.hasOwnProperty(thisKey)` when merging props, just `newProps.hasOwnProperty(thisKey)` and a truthy test for `TransferStrategies[thisKey]`. This means that if our `newProps` has keys like `toString`, `valueOf`, or `constructor` etc. set, we will pull these functions off `TransferStrategies` and invoke them when merging props. In most cases this will just result in a failure to merge and some code without side effects being run but in the case of `valueOf` it will actually generate an exception.
2014-03-18 15:01:46 -07:00
Josh Duck
0278f01d95
Replace function expression with for loop
...
isCustomAttribute used an anonymous function in place of a for loop.
Swap it out so we're not allocating unnecessarily.
2014-03-18 14:57:08 -07:00
Kunal Mehta
0cec4af8d7
Sync latest Immutable changes
2014-03-18 14:57:04 -07:00
Paul O’Shannessy
8d495f3b6e
Revert "Merge pull request #1234 from RReverser/pure-cjs"
...
This reverts commit 7987e6a51d , reversing
changes made to d88d479685 .
2014-03-18 11:25:21 -07:00
Ben Newman
7987e6a51d
Merge pull request #1234 from RReverser/pure-cjs
...
Switched from browserify to pure-cjs bundler.
2014-03-18 12:04:58 -04:00
Paul O’Shannessy
d88d479685
Merge pull request #1193 from spicyj/jsx-polygon
...
Add polygon tag to transform
2014-03-17 10:07:23 -07:00
Ingvar Stepanyan
3f3187c14f
Renamed commojs task to bundle, added failing build if bundler failed.
2014-03-17 16:53:02 +02:00
Ben Alpert
c1443e92e6
Merge pull request #1226 from LilyJ/master
...
included link to React devtools in tooling-integration. fixes #791
2014-03-16 22:42:14 -07:00
Paul O’Shannessy
52e8f3fdb0
Merge pull request #1248 from asolove/svg-text-anchor
...
Add svg text-anchor attribute
2014-03-16 22:33:00 -07:00
Paul O’Shannessy
cdf4f07a15
Merge pull request #1229 from spicyj/no-jsx
...
Avoid JSX in ReactCSSTransitionGroup code
2014-03-16 22:31:24 -07:00
Paul O’Shannessy
6ff116e34b
Merge pull request #1262 from vjeux/harmony-react-to
...
Add support for {harmony: true} to react-tools
2014-03-16 22:30:30 -07:00
Pete Hunt
d889a01caf
Fix ref behavior for remounting
...
I'm thinking that setting up `this.refs` in `mountComponent` is better than `construct`. Followed the same pattern as `ReactComponent.Mixin` and nulling out
the value in `construct` and setting it to its initial value in `mountComponent`.
2014-03-16 22:01:54 -07:00
Pete Hunt
04f9887f0e
More actionable error message for <tbody> and nested <p>
...
This bites people all of the time. Until we have a better solution, let's just make the error message more actionable (most people don't know how the DOM
gets unexpectedly mutated).
2014-03-16 22:01:34 -07:00
Sebastian Markbage
9b427a322f
Fix some invalid uses of instances
...
Breaking this out of the other code mod.
2014-03-16 22:01:30 -07:00
Sebastian Markbage
7bbdcdba96
Reassign variable of rendered component
...
The component that gets passed into renderComponent isn't guaranteed to be the
instance that gets mounted. We want to clone the instance.
Unit tests need to reason about the mounted instance. The first code mod changes:
ReactTestUtils.renderIntoDocument(<identifier>)
into
<identifier> = ReactTestUtils.renderIntoDocument(<identifier>)
Using this scripts:
scripts/bin/codemod -m -d ~/www --extensions js \
'^(\s*)ReactTestUtils\.renderIntoDocument\(\s*([$a-zA-Z0-9_]+)\s*\)' \
'\1\2 = ReactTestUtils.renderIntoDocument(\2)'
In the second case I do the same for React.renderComponent. However, there are
alot more unnecessary matches so I only codemod if the same identifier occurs
later in the file.
scripts/bin/codemod -m -d ~/www --extensions js \
'^(\s*)React.renderComponent\(\s*([$a-zA-Z0-9_]+)\s*?,(.*?\n?.*?\s\2\b)' \
'\1\2 = React.renderComponent(\2,\3'
And one more for ReactMount.renderComponent used by internals.
scripts/bin/codemod -m -d ~/www --extensions js \
'^(\s*)ReactMount.renderComponent\(\s*([$a-zA-Z0-9_]+)\s*?,(.*?\n?.*?\s\2\b)' \
'\1\2 = ReactMount.renderComponent(\2,\3'
This still matches many unnecessary cases where the second occurance of the
identifier is a redeclaration or comment. But this code mod doesn't hurt in
those cases.
Finally I have to do the same for:
this.<identifier> = React.renderComponent(this.<identifier>,
This is a common pattern for production code but not tests. Some of these call
sites will likely break when we move to true descriptors.
scripts/bin/codemod -m -d ~/www --extensions js \
'^(\s*)React.renderComponent\((\s*)this\.([$a-zA-Z0-9\_\.]+)\s*?,' \
'\1this.\3 = React.renderComponent(\2this.\3,'
2014-03-16 22:01:09 -07:00
Christopher Chedeau
5106b793f7
Add support for {harmony: true} to react-tools
...
```
require('react-tools').transform(code, {harmony: true});
```
now enables all the harmony es6 transforms that are supported.
This is modeled after https://github.com/facebook/react/blob/master/bin/jsx#L17-L23
2014-03-16 15:38:40 -07:00
Jonas Gebhardt
83e4ef16e6
Community Round-up #18
2014-03-14 16:56:12 -07:00
ray
f6a2888910
change some translation words
2014-03-13 23:28:50 +08:00
ray
b7471bcd93
add translation for getting-started.md
2014-03-13 23:19:29 +08:00
ray
93b6804912
make translation better
2014-03-13 21:12:25 +08:00
ray
3c9b797d21
fix (
2014-03-13 21:00:25 +08:00
Paul O’Shannessy
308c9a0752
Merge pull request #1181 from lrowe/patch-5
...
omitClose for all void elements
2014-03-12 16:37:52 -07:00
davidxi
29abe53924
Update jasmine-support.js
...
fix typo in multiple error messages.
2014-03-12 14:39:14 -04:00
Adam Solove
6a01752f3d
Add svg text-anchor attribute.
2014-03-12 10:07:05 -04:00
Andreas Svensson
60d7a02d44
Normalize whitespace for transformed JSX code
2014-03-12 10:03:16 +01:00
Ben Alpert
6fd53815cd
Merge pull request #1246 from ericflo/patch-1
...
Remove Shirtstarter as an example application.
2014-03-11 15:48:20 -07:00
Eric Florenzano
3efa02da91
Remove Shirtstarter as an example application.
...
We have unexpectedly had to shut Shirtstarter down, so it won't serve as a good React.js example any more unfortunately -- sorry for the documentation churn.
2014-03-11 15:45:14 -07:00
Jeff Morrison
d9af091244
Merge pull request #1242 from syranide/jsxcomfix
...
Unbreak JSX comment comma fix
2014-03-11 10:13:24 -07:00
Ingvar Stepanyan
25773ed1b3
CommonJS builder config to Grunt style for easier handling and readability.
2014-03-11 13:40:38 +00:00
Ingvar Stepanyan
9e224e615f
Renamed browserify tasks/configs to cjs, updated pure-cjs to 1.9.0 for better build speed.
2014-03-11 13:26:36 +02:00
ray
b0f9f73e91
Merge branch 'master' of github.com:rayqian/react
...
Conflicts:
docs/docs/01-why-react.zh-CN.md
2014-03-11 17:52:20 +08:00
ray
c6a59c0ae6
fix some translation error
2014-03-11 17:51:09 +08:00
ray
69767d4b79
fix some translation error
2014-03-11 17:42:03 +08:00
ray
c3948483d9
add chinese translation for 01-why-react.md
2014-03-11 17:36:57 +08:00
Cheng Lou
3ce2cd04e2
Merge pull request #1243 from jeffcarp/master
...
Remove unused variable in ballmer-peak
2014-03-10 21:29:35 -07:00
Jeff Carpenter
652f5aea28
Remove unused variable
2014-03-10 19:48:13 -07:00
Andreas Svensson
280ff2e5a7
Unbreak JSX comment comma fix
2014-03-11 00:31:59 +01:00
Pete Hunt
5ede7fb619
ReactDOMComponent optimization
...
Slight optimization to not do unneeded reconciles of DOM components
2014-03-10 15:32:20 -07:00
Sebastian Markbage
3ea3274ca4
Clone on mount
...
This is the first step towards descriptors. This will start cloning the
component when it's mounted instead of mounting the first instance.
This avoids an issue where a reference to the first instance can hang around
in props. Since a mounted component gets mutated, the descriptor changes.
We don't need to clone the props object itself. Mutating the shallow props
object of a child that's passed into you is already flawed. Those cases need to
use cloneWithProps. A props object is considered shallow frozen after it leaves
the render it was created in.
2014-03-10 15:28:54 -07:00
Paul O’Shannessy
2ca810fbf3
Merge pull request #1225 from spicyj/cprop
...
Fix removing DOM property with mapped name
2014-03-10 11:29:10 -07:00
Pete Hunt
d9dd9d5cb3
Merge pull request #1235 from fxbois/master
...
Update 08-tooling-integration.md
2014-03-08 20:15:45 -08:00
fxbois
9ffd70c688
Update 08-tooling-integration.md
...
emacs compatibility
2014-03-08 18:12:05 +01:00
Ingvar Stepanyan
3171436d97
Switched from browserify to pure-cjs bundler.
...
Optimizations and fix for JSXTransformer build.
Dropped dependency on emulation of Node.js native modules.
Added deamdify step for JSXTransformer build.
2014-03-08 16:33:58 +02:00
Jeff Morrison
9ce7ecc3d9
Merge pull request #1219 from syranide/jsxempty
...
Fix empty JSX expressions sometimes emitting erroneous commas
2014-03-07 21:23:55 -08:00
Paul O’Shannessy
9f9c8bcebf
Merge pull request #1228 from spicyj/grunt-debug
...
Bring back `grunt test --debug`
2014-03-07 11:18:29 -08:00
Ben Alpert
ec54dcbd8f
Avoid JSX in ReactCSSTransitionGroup code
...
Supposedly we want these to be plain JS.
2014-03-06 22:16:25 -08:00
Ben Alpert
9766ed5797
Bring back grunt test --debug
2014-03-06 22:11:55 -08:00
Ben Alpert
1d209248ef
Remove obsolete __VERSION__ references
2014-03-06 20:33:06 -08:00
Ben Alpert
21e06196cd
Fix removing DOM property with mapped name
2014-03-06 17:50:01 -08:00
Lily
4b56947560
included link to React devtools in tooling-integration. fixes #791
2014-03-06 13:00:48 -08:00
Paul O’Shannessy
554b677e60
Merge pull request #1180 from evanc/master
...
Test that Node is a function before using instanceof on it
2014-03-06 11:02:28 -08:00
Andreas Svensson
aa70419f9d
Fix empty JSX expressions sometimes emitting erroneous commas
2014-03-06 13:01:03 +01:00
Cheng Lou
af1b63456e
Merge pull request #1222 from spicyj/npm-dl
...
[docs] Add more words to downloads page
2014-03-05 20:23:10 -08:00
Ben Alpert
ac3051530a
[docs] Add more words to downloads page
2014-03-05 20:16:50 -08:00
Paul O’Shannessy
c5f56f318a
Merge pull request #1208 from passy/patch-3
...
Fix docstring typo for pure render mixin
2014-03-05 19:13:22 -08:00
Paul O’Shannessy
be2c185888
Merge pull request #1211 from spicyj/freeze
...
Add Object.freeze to polyfill list
2014-03-05 12:18:20 -08:00
Paul O’Shannessy
7d0e6c6c0b
Merge pull request #1192 from spicyj/srcset
...
Add srcSet attribute
2014-03-04 21:39:46 -08:00
Jing Chen
13aa8d37e6
Allow falsy values in statics
...
We found that the component would break if we set any statics with the
value 0. It turns out @chenglou already ran into this with
d71736b3ed but the statics code was copied
earlier, and still has this falsy check. Made the same change, updated
the unittest.
2014-03-04 18:15:49 -08:00
Kunal Mehta
06f762da77
Add Immutable
...
As titled. First of 3 diffs to add Immutable, ImmutableMap, and ImmutableObject. No logic changes.
2014-03-04 18:14:47 -08:00
Kunal Mehta
4ad320dd13
LegacyImmutableObject module
...
This copies the old implementation of ImmutableObject into LegacyImmutableObject.
2014-03-04 18:14:12 -08:00
Ben Newman
521201f121
Merge pull request #1215 from benjamn/fix-cloneWithProps-test
...
Fix stale usage of emptyObject in cloneWithProps-test.
2014-03-04 13:27:59 -05:00
Ben Newman
41d30bb7de
Re-require cloneWithProps as well, for consistency.
...
And don't mock `emptyObject`, since that might actually replace it with a
mutable/non-frozen object.
2014-03-04 13:12:59 -05:00
Ben Newman
9c87aef67f
Fix stale usage of emptyObject in cloneWithProps-test.
...
After we run `require('mock-modules').dumpCache()`, the object exported by
the `emptyObject` module will no longer be identical to previously
exported objects, so tests like `expect(component.refs).toBe(emptyObject)`
will fail.
Note that this behavior only manifests itself in tests, because of course
we do not call `dumpCache` in production code.
We could consider storing the `emptyObject` globally to thwart the effects
of `dumpCache`, but it's more idiomatic simply to re-`require` the latest
version of `emptyObject`.
2014-03-04 12:59:55 -05:00
Ben Alpert
c3cfcf073d
Remove custom attrs properly when setting to null
...
I don't think this particular codepath was exercised at all (because all the callers call deleteValueForProperty) but this fixes a bug here nonetheless.
2014-03-03 17:43:03 -08:00
Ben Alpert
ec8b0d7fbf
Add srcSet attribute
...
Chrome beta supports this now: http://blog.chromium.org/2014/02/chrome-34-responsive-images-and_9316.html .
2014-03-03 17:12:00 -08:00
Ben Alpert
e954a1c0d9
Add Object.freeze to polyfill list
2014-03-03 15:55:19 -08:00
Paul O’Shannessy
1d27770b40
Fix verion-check to look in right place for React.js
2014-03-03 15:35:10 -08:00
Paul O’Shannessy
4c4446d283
Sync more vendored modules
2014-03-03 15:34:14 -08:00
Pete Hunt
a8fc3b940d
Move UI-thread-only browser modules to browser/ui/
...
This also deletes an unused module.
2014-03-03 15:07:11 -08:00
Pete Hunt
6666538316
Unbreak refs
...
If no refs are rendered, `this.refs` is undefined. This is bad since it deopts & is hard to look for. Instead we should make `this.refs` an immutable empty object.
2014-03-03 15:06:57 -08:00
Sebastian Markbage
620c1bc2ff
Add more owner context to monitoring
...
Always include context and specifically include the component that was missing a key.
2014-03-03 15:06:39 -08:00
Cheng Lou
99dab49f92
Refactor rendering to string without checksum & React ID
...
Finalize API for rendering to static markup.
Instead of passing a boolean option to `renderComponentToString`, just use another method.
2014-03-03 15:06:27 -08:00
Pete Hunt
9b0534eb77
ReactRAFBatchingStrategy
...
This will go in React addons only for now until we figure out `pendingState`.
2014-03-03 15:06:14 -08:00
Sebastian Markbage
eee04b19e1
Add monitor module for logging instrumentation
...
This adds an instrumentation hook for logging so that we can monitor invalid API
usage before we're ready to issue a warning.
I took the opportunity to update some console.warns to use the warning module
instead. The remaining console.warns
will be replaced by the warning module after we've cleaned up the callsites.
2014-03-03 15:05:53 -08:00
Cheng Lou
f734083a17
Better name for server-side rendering without React ID & checksum
...
"staticMarkup" sounds way better than "noChecksumNoID".
Also avoids some double negations.
2014-03-03 15:05:35 -08:00
Christoph Pojer
3fe9f9f336
Fix ReactPropTypesTest
...
children should never be defined as propType, so changing the test to use an actual prop.
2014-03-03 15:05:26 -08:00
Jan Kassens
e39c19423a
temporarily disable warning
2014-03-03 15:05:10 -08:00
Cheng Lou
6203e53d16
Fix IE8 disabled input throwing on focus
...
When IE8 focuses a disabled item, it throws
This makes sure the we're not focusing the item during selection restoration/autofocus when the element's disabled.
2014-03-03 15:04:34 -08:00
Ben Alpert
88a4a566ae
Merge pull request #1209 from petehunt/thinking-in-react
...
Add thinking in react to the official docs + cleanup
2014-03-03 10:40:28 -08:00
petehunt
2f6656e3e9
fix
2014-03-03 10:39:41 -08:00
petehunt
a0ecf47242
Add thinking in react to the official docs
2014-03-03 10:37:33 -08:00
Cheng Lou
4b670a08fa
Merge pull request #1207 from passy/patch-2
...
Add missing backtick in complementary-tools.md
2014-03-02 16:21:35 -08:00
Pascal Hartig
6b78cfb0f4
Fix docstring typo for pure render mixin
2014-03-02 22:18:10 +00:00
Pascal Hartig
8df5e55efd
Add missing backtick in complementary-tools.md
2014-03-02 22:10:24 +00:00
Pete Hunt
237adacc3a
Merge pull request #1204 from jmingov/patch-1
...
Updated React Version to 0.9.0
2014-03-01 17:01:12 -08:00
Pete Hunt
90e996324a
Merge pull request #1203 from fson/jsx-integrations
...
Merge the lists of JSX integrations in the docs.
2014-03-01 14:24:58 -08:00
3boll
b2649dd73b
Updated React Version 0.9.0
...
**Updated Url's:**
CDN:
http://fb.me/react-0.9.0.js
http://fb.me/JSXTransformer-0.9.0.js
Starter Kit
http://facebook.github.io/react/downloads/react-0.9.0.zip
2014-03-01 21:12:17 +01:00
Ville Immonen
0217461d16
Merge the lists of JSX integrations in the docs.
...
There were these two lists of JSX tools at Complimentary Tools
and Tooling Integration, that were a bit out of sync with each other.
Bring them together and add a link to the former from the latter.
2014-03-01 16:50:40 +02:00
Pete Hunt
3c4f45fe45
Merge pull request #1200 from ericflo/patch-1
...
Add Shirtstarter to examples of production apps.
2014-02-28 13:42:28 -08:00
Eric Florenzano
6485e21956
Add Shirtstarter to examples of production apps.
...
Shirtstarter is 100% built on React.
2014-02-28 13:40:14 -08:00
Paul O’Shannessy
ae72e6ef91
Merge pull request #1082 from spicyj/class-false
...
Ensure className={false} turns into string 'false'
2014-02-27 16:41:41 -08:00
Ben Alpert
42444f6bb9
Add polygon tag to transform
...
Fixes #1144 .
2014-02-27 12:32:24 -08:00
Cheng Lou
071d2a947c
[Docs] document optional param for renderComponentToString
2014-02-26 15:11:53 -08:00
Ben Alpert
298a05517e
Tweak propTypes examples for clarity in oneOfType
2014-02-26 15:03:47 -08:00
Laurence Rowe
cbfbb54c1d
omitClose for all void elements
...
According to http://www.w3.org/TR/html5/syntax.html#void-elements the following elements should not specify end tags:
area, base, br, col, embed, hr, img, input, keygen, link, meta, param, source, track, wbr
2014-02-25 20:03:16 -08:00
evanc
26179d2b79
Test that Node is a function before using instanceof on it
2014-02-25 17:55:31 -08:00
Pete Hunt
ba78edbed8
Update complementary-tools.md
2014-02-25 17:01:00 -08:00
Paul O’Shannessy
34b6707132
Merge pull request #1166 from chenglou/docs-examples-consolidate
...
[Docs] Consolidate the two examples sections
2014-02-25 16:45:01 -08:00
Paul O’Shannessy
7b773a6b3d
make <hasOwnProperty/> transform correctly
2014-02-24 18:03:02 -08:00
Paul O’Shannessy
1dfc5c79f9
Merge pull request #1148 from spicyj/jsx-constructor
...
Make JSX transform not break on 'constructor' attr
2014-02-24 17:20:25 -08:00
Ben Alpert
04111d5228
Add acknowledgements page
2014-02-24 17:18:57 -08:00
Jonas Gebhardt
a6c1b91c7d
fix typo in community round-up #17
2014-02-24 15:27:02 -08:00
Pete Hunt
f34f0d2912
Update README.md
2014-02-24 14:25:09 -08:00
Pete Hunt
46cae63d2c
Merge pull request #1156 from chenglou/1154
...
Remove TodoMVCs from examples/
2014-02-24 14:24:12 -08:00
Jonas Gebhardt
5049fc6b05
Community Round-up # 17
2014-02-24 14:20:17 -08:00
Pete Hunt
8b1279e6b2
Merge pull request #1174 from spicyj/addons-update
...
Add update() to React.addons
2014-02-24 14:10:07 -08:00
Ben Alpert
854d1f7c1b
Add update() to React.addons
2014-02-24 14:05:29 -08:00
Pete Hunt
ab2d59f8b0
[addons] update() immutability helper
...
Dealing with immutable data is hard. This provides a simple helper (ported from the IG codebase) that makes dealing with immutable JSON data easier. Designed to be familiar for people who use MongoDB.
2014-02-24 13:58:51 -08:00
Cheng Lou
25cafec4a9
[Docs] Consolidate the two examples sections
...
Also made the formatting more consistent between complementary-tools and
examples.
2014-02-23 18:58:28 -08:00
Ben Alpert
61c287c5ea
[docs] Fix version in lifecycle argument note
...
Fixes #1163 .
2014-02-23 16:49:27 -08:00
Pete Hunt
7bba8c3257
Merge pull request #1155 from petehunt/update-helper
...
Add update() docs
2014-02-21 15:58:39 -08:00
Cheng Lou
2f0507f730
Remove TodoMVCs from examples/
...
Fixes #1154 .
Added a README to point to TodoMVC's site instead.
2014-02-21 14:31:54 -08:00
petehunt
989f6f987d
Add update() docs
2014-02-21 13:07:51 -08:00
Ben Alpert
e2b006f9ae
.dataTransfer not .dragTransfer
2014-02-21 12:13:21 -08:00
Ben Alpert
141ff66986
Merge pull request #1150 from andreypopp/update-react-router-component-link
...
docs: update react-router-component link
2014-02-21 11:30:26 -08:00
Andrey Popp
da0b34e945
docs: update link for react-async
2014-02-21 18:30:19 +04:00
Andrey Popp
cbce621570
docs: update react-router-component link
2014-02-21 15:51:27 +04:00
Ben Alpert
472be09ff6
Make JSX transform not break on 'constructor' attr
2014-02-20 21:44:58 -08:00
Ben Alpert
7144a9f241
Merge pull request #1146 from dlau/patch-1
...
incorrect include in css transition group example?
2014-02-20 19:13:14 -08:00
Daryl Lau
8aaf5fdbf4
incorrect include in css transition group example?
...
TransitionGroup maps to ReactTransitionGroup, shouldn't it be a ReactCSSTransitionGroup?
2014-02-20 18:26:56 -08:00
Ben Alpert
445611f3e6
Add html5shiv to polyfill docs
...
cf. #1030
2014-02-20 17:21:41 -08:00
Pete Hunt
b79a3cbd21
Break more browser deps in core
...
This is part of what Sebastian suggested. We require it into every component that explicitly needs it and inject it as a default mixin for composite components in
the browser environment. This change frees us up to inject everything in ReactComponent.
2014-02-20 16:55:17 -08:00
Jason Bonta
0790040aac
update docblock
...
...for typechecking.
2014-02-20 16:55:01 -08:00
Cheng Lou
2900997b5f
Fix transaction test comments
...
Probably got copy/pasted in.
2014-02-20 16:54:52 -08:00
Cheng Lou
7eb33ef176
simplify mountImageIntoNode's way of putting markup in innerHTML
...
Instead of removing the node from the document before changing its innerHTML, just do it directly.
The comment seems to be outdated for years. http://jsperf.com/detach-while-setting-innerhtml
2014-02-20 16:54:43 -08:00
Cheng Lou
5545887a48
Allow rendering markup string without checksum and React ID
...
This fixes https://github.com/facebook/react/pull/994 .
Also fixes https://github.com/facebook/react/issues/1079 .
Server-rendering without ID/checksum now works. Also won't call didMount.
2014-02-20 16:54:20 -08:00
Paul O’Shannessy
e29584b49b
Update authors
2014-02-20 15:20:27 -08:00
Jeff Morrison
c43b3f406c
Merge pull request #1143 from jeffmo/npm_test
...
Add support for `npm test`
2014-02-20 13:15:09 -08:00
jeffmo
a4d6796705
Add support for npm test
2014-02-20 13:10:05 -08:00
Ben Alpert
89d4d352e1
Tweak tutorial wording to be more accurate
2014-02-20 11:40:14 -08:00
Paul O’Shannessy
f3c1383af9
Add context deprecation to changelog, reformat
2014-02-20 10:32:21 -08:00
Shaun Trennery
c32e398a5c
Addition of 'this.context' component breaking change
...
this.context on components is now reserved for internal use by React
closes #1141
2014-02-20 10:32:12 -08:00
Paul O’Shannessy
95edc396df
version bump to 0.10.0-alpha
2014-02-19 22:53:29 -08:00
Paul O’Shannessy
26cd595a98
update changelog
2014-02-19 22:17:28 -08:00
Paul O’Shannessy
8840ee32f1
Updated Authors
2014-02-19 22:11:50 -08:00
Paul O’Shannessy
bb729a5784
Merge pull request #1131 from spicyj/rel-notes-0.9-2
...
React v0.9 blog post
2014-02-19 21:47:29 -08:00
Paul O’Shannessy
b99705f690
Merge branch 'joshduck-patch-1'
...
Closes #989
2014-02-19 18:10:20 -08:00
Paul O’Shannessy
7e7aa21e24
tweak object property warning.
2014-02-19 18:07:24 -08:00
Ben Alpert
1de77f1fbe
Ensure className={false} turns into string 'false'
...
Fixes inconsistency shown by http://jsfiddle.net/zpao/qeXLm/ .
2014-02-19 13:47:35 -08:00
Ben Alpert
01b68c0e76
React v0.9 blog post
2014-02-19 12:05:47 -08:00
Paul O’Shannessy
e59daa8ed8
Add descriptions to package.jsons
...
Otherwise, npm just reads the first non-header of our readmes, which doesn't
match up accurately or cleanly (no markdown parsing).
2014-02-19 11:35:11 -08:00
Paul O’Shannessy
9b405fba24
Merge pull request #1135 from spicyj/testutils-docs
...
Update Simulate docs and reorg a little bit
2014-02-19 11:19:27 -08:00
Ben Alpert
99b80938af
Update Simulate docs and reorg a little bit
2014-02-19 11:16:55 -08:00
Cheng Lou
e13977c0c2
Merge pull request #939 from spicyj/simulate-synthetic
...
Simulate synthetic events using ReactTestUtils
2014-02-19 10:58:54 -08:00
Ben Alpert
42473b2df1
Merge pull request #1133 from martinandert/repo-owner-change
...
complementary-tools repo owner changed
2014-02-19 00:48:15 -08:00
martinandert
970ae44c1f
complementary-tools repo owner changed
2014-02-19 09:34:33 +01:00
Ben Alpert
a447d30a2e
Rebuild simulators after injecting plugins
2014-02-19 00:28:34 -08:00
Ben Alpert
36e97bac21
Simulate synthetic events using ReactTestUtils
...
Most of the time this is what you want to do, so I've renamed what was Simulate to be SimulateNative.
Now Simulate.change does what you expect, so this fixes #517 and fixes #519 .
2014-02-19 00:04:16 -08:00
Ben Alpert
9f9ee697f3
Simpler ReactTestUtils.simulateEventOnDOMComponent
2014-02-18 23:37:11 -08:00
Pete Hunt
58ffd39abf
Merge pull request #1132 from petehunt/docs-clonewithprops
...
clone docs
2014-02-18 23:27:25 -08:00
petehunt
30faba394d
clone docs
2014-02-18 23:26:51 -08:00
Pete Hunt
93e7778d5f
Merge pull request #1112 from petehunt/testutils-addons
...
Add ReactTestUtils to addons
2014-02-18 22:58:30 -08:00
Pete Hunt
b7836c4da6
Merge pull request #1059 from petehunt/rtg-docs
...
Document ReactCSSTransitionGroup
2014-02-18 22:58:15 -08:00
petehunt
c2904b978e
fix docs
2014-02-18 22:57:41 -08:00
petehunt
8122cadeb4
Add ReactTestUtils to addons
2014-02-18 22:54:24 -08:00
petehunt
ea803c47ba
docs fixes
2014-02-18 22:51:51 -08:00
petehunt
42c837e4dd
remove child factories
2014-02-18 22:48:52 -08:00
petehunt
cadd6cbb6c
add ReactCSSTransitionGroup to addons and document it
2014-02-18 22:47:53 -08:00
Paul O’Shannessy
c0660ea6e0
Merge pull request #1100 from plievone/mapchildren-docs
...
Fix docs for React.Children.map, .forEach, .only.
2014-02-18 21:43:30 -08:00
Paul O’Shannessy
cb1f8247e5
Merge pull request #1130 from spicyj/if-attr-value
...
Don't break if no attribute value
2014-02-18 18:20:42 -08:00
Ben Alpert
e0dbca1168
Don't break if no attribute value
...
Fixes the transformation of things like `<button disabled>`.
2014-02-18 18:10:46 -08:00
Paul O’Shannessy
f81d16960c
Merge pull request #1128 from spicyj/media-attrs
...
Add media element attributes
2014-02-18 18:04:43 -08:00
Paul O’Shannessy
8a47813baa
Update copyrights for 2014.
...
grep -rl 'Copyright 2013 Facebook' static_upstream | xargs perl -pi -w -e s/Copyright 2013 Facebook/Copyright 2013-2014 Facebook/g;'
Not going to check in a script to do this since it will just change every year.
Closes #1006
2014-02-18 17:06:43 -08:00
Paul O’Shannessy
792d8aca86
Merge pull request #1116 from spicyj/gh-1115
...
Add download and hrefLang attributes
2014-02-18 13:42:24 -08:00
Ben Alpert
112a20ce73
Add media element attributes
...
Fixes #1124 .
I didn't add `volume` because it requires more complicated logic to control properly and I didn't add `paused` because to set it we need to call play() or pause() -- perhaps a mutation method is appropriate.
2014-02-18 12:30:14 -08:00
Paul O’Shannessy
c79974db3a
Merge pull request #1122 from spicyj/gh-1120
...
Strip calls to warning() in __DEV__
2014-02-17 19:44:53 -08:00
Ben Alpert
5795376961
Strip calls to warning() in __DEV__
...
Fixes #1120 .
2014-02-17 19:01:45 -08:00
Pete Hunt
8ac5975ad8
Merge pull request #1106 from spicyj/gh-1105
...
Prevent error thrown when removing event target
2014-02-17 17:53:51 -08:00
Ben Alpert
d8fd1af4a0
Pool ancestors list so event system is reentrant
2014-02-17 16:37:15 -08:00
Ben Newman
f457df275d
Merge pull request #1117 from andreypopp/envify-bump
...
Update envify to 1.2.0
2014-02-17 19:10:13 -05:00
Andrey Popp
39c9b539e9
Update envify to 1.2.0
2014-02-18 03:38:58 +04:00
Ben Alpert
ae7e44ec84
Add download and hrefLang attributes
...
Fixes #1115 .
2014-02-17 15:13:14 -08:00
Pete Hunt
f73b894c37
Update complementary-tools.md
2014-02-17 10:42:09 -08:00
Pete Hunt
4642a70277
Update complementary-tools.md
2014-02-17 10:41:48 -08:00
Ben Alpert
2f0bb69708
Prevent error thrown when removing event target
...
Fixes #1105 .
2014-02-17 10:33:34 -08:00
Pete Hunt
916776753f
Merge pull request #1110 from dustingetz/master
...
Add wingspan-forms to complimentary tools docs
2014-02-17 09:51:43 -08:00
Dustin Getz
1b5af6b405
Add wingspan-forms to complimentary tools docs
2014-02-17 11:48:42 -06:00
Ben Alpert
9e160df868
Blog post for 0.9 release candidate
2014-02-16 18:47:04 -08:00
Paul O’Shannessy
9125f68194
0.9.0-rc1
2014-02-16 17:38:52 -08:00
Ben Alpert
9ebb40f013
Rename dir to npm-jsx_whitespace_transformer
2014-02-16 14:40:03 -08:00
Ben Alpert
7b5da078c6
Make transitions example use CSSTransitionGroup
2014-02-16 14:11:42 -08:00
Ben Alpert
1167aeb453
Expose cloneWithProps on addons
...
closes #1066
2014-02-16 14:08:05 -08:00
Paul O’Shannessy
6780b47526
Add CSSTransitionGroup to addons
...
Stealing part of #1059 .
2014-02-16 14:04:29 -08:00
Paul O’Shannessy
3e77f64141
Merge pull request #1097 from spicyj/es3ify
...
Run es3ify over unminified builds
2014-02-16 12:49:16 -08:00
plievone
827c44fcd3
Fix docs for React.Children.map, .forEach, .only.
2014-02-16 22:41:30 +02:00
Pete Hunt
b7ba0f173e
Update complementary-tools.md
2014-02-16 12:11:54 -08:00
Ben Newman
634e41788a
Merge pull request #1099 from benjamn/make-ReactWebWorker-test-less-flaky
...
Make ReactWebWorker-test.js less flaky.
2014-02-16 13:58:00 -05:00
Ben Newman
47ae865428
Make ReactWebWorker-test.js less flaky.
...
Two improvements: make sure we set `done = true` when an error message is
received, so that the test output contains the error message instead of
eventually timing out and displaying nothing useful; and increase the
timeout for this particular test from 5000ms (the default) to 20000ms.
2014-02-16 12:57:14 -05:00
Ben Alpert
0d4213001b
Fix typo in latest round-up
2014-02-15 22:53:42 -08:00
Ben Newman
1e7bdc79e1
Upgrade Commoner dependency to v0.9.1 to fix mkdirP bug.
2014-02-15 20:49:17 -05:00
Ben Alpert
e87c8a2aa4
Run es3ify over unminified builds
...
Makes no difference to react.js and react-with-addons.js; quotes .static in four
places for JSXTransformer.js:
https://gist.github.com/spicyj/aada5352e813752a4667
2014-02-15 16:32:36 -08:00
Paul O’Shannessy
d3c12487fd
Update copyright header in browserify config
...
Part of #1006 , but sooner.
2014-02-15 16:24:13 -08:00
Paul O’Shannessy
32e1d76612
Update AUTHORS for 0.9
2014-02-15 16:21:51 -08:00
Jonas Gebhardt
78ac842b4a
Add community round-up #16
2014-02-15 15:50:30 -08:00
Paul O’Shannessy
9ebde97c14
Merge pull request #1096 from spicyj/comma-splice
...
Fix comma splice
2014-02-15 14:07:33 -08:00
Ben Alpert
2013db23d3
Fix comma splice
2014-02-15 13:58:57 -08:00
Paul O’Shannessy
e872cd0a7c
Update vendored modules, delete unused
...
Closes #1090
2014-02-15 13:50:56 -08:00
Paul O’Shannessy
a34eed508a
Merge pull request #1095 from jeffmo/sync_transforms
...
Sync out transforms from fb internal
2014-02-15 12:53:42 -08:00
JeffMo
adcbf0806c
Sync out transforms from fb internal
2014-02-15 12:35:32 -08:00
Jeff Morrison
64afa545dd
Merge pull request #1094 from jeffmo/jsx_whitespace_codemod_fixup
...
Pull in syranides jsx whitespace codemod transform fixes
2014-02-15 11:51:54 -08:00
JeffMo
f66f8f0310
Pull in syranides jsx whitespace codemod transform fixes
2014-02-15 11:20:32 -08:00
Jason Bonta
9ba014fbf1
Merge pull request #1081 from spicyj/textcontent
...
Avoid innerText for better newline behavior
2014-02-15 02:22:54 -06:00
Cheng Lou
d71736b3ed
include mixin keys whose values are falsy
...
the previous behavior is to skip mixin keys whose values are `undefined`, `null`, `''` and (this is a bug) 0. Now, every key is included.
2014-02-14 16:53:34 -08:00
Pete Hunt
529c971db3
Merge pull request #1088 from petehunt/fixtests
...
Fix CSSTransitionGroup tests
2014-02-14 13:10:38 -08:00
petehunt
b65f5a4d30
fix tests
2014-02-14 12:55:03 -08:00
Cheng Lou
123ed1f442
Fix IE8 bug during unitless CSS props creation
...
IE8 goes into an infinite loop if we add props to the obj we're iterating through.
2014-02-14 12:41:44 -08:00
Ben Alpert
31bc18d39e
Add simple docs on statics to reference section
...
Fixes #1056 .
2014-02-14 11:54:58 -08:00
Cheng Lou
f4798ebee1
[Docs] Add Object.keys to list of shims
2014-02-14 09:52:04 -08:00
Ben Alpert
67c5d76321
Add missing commas in propTypes docs
2014-02-13 23:19:41 -08:00
Pete Hunt
a8af11b46d
Merge pull request #1086 from spicyj/new-proptypes
...
Add docs for new prop types
2014-02-13 23:03:42 -08:00
Ben Alpert
30646c9c1e
Add docs for new prop types
2014-02-13 22:59:48 -08:00
Ben Alpert
8c3ac3203d
Merge pull request #940 from chenglou/tips-val
...
[docs] Document newly added unitless css props in tips
2014-02-13 22:40:51 -08:00
Cheng Lou
559933655a
[Docs] Document newly added unitless css props in tips
2014-02-13 22:39:30 -08:00
Ben Alpert
0a9eaab61f
[docs] Add properties that were in 0.8 too
...
This time I actually generated it from the DefaultDOMPropertyConfig file.
2014-02-13 22:02:06 -08:00
Paul O’Shannessy
cebc49e5e6
Merge pull request #1022 from spicyj/multichild-throw
...
Refactor ReactMultiChild to not throw errors too
2014-02-13 21:51:52 -08:00
Ben Alpert
f8349f9614
Add formNoValidate and noValidate too
2014-02-13 21:50:17 -08:00
Ben Alpert
80cbdea144
[docs] Update supported attributes list
...
Fixes #1008 .
2014-02-13 21:47:49 -08:00
Ben Alpert
1991e46f1a
[docs] Capitalize all nav titles for consistency
2014-02-13 21:41:09 -08:00
Ben Alpert
b98f1adf1a
Avoid innerText for better newline behavior
...
Fixes #1080 .
2014-02-13 21:31:32 -08:00
Paul O’Shannessy
05ee61d763
Merge pull request #1084 from spicyj/jsx-wh
...
Various fixes to whitespace transformer
2014-02-13 21:10:49 -08:00
Ben Alpert
cc010e3287
Support transforming multiple files at once
2014-02-13 19:15:59 -08:00
Ben Alpert
49ddf905b1
Use graceful-fs to avoid EMFILE errors
2014-02-13 19:15:59 -08:00
Ben Alpert
ecfd0c1473
Run over *.jsx as well
2014-02-13 19:15:59 -08:00
Ben Alpert
4a76b52751
Resolve paths relative to pwd, not npm install dir
2014-02-13 19:15:59 -08:00
Ben Alpert
940c86964d
Rename run to run.js to avoid not-found errors
2014-02-13 19:15:39 -08:00
Ben Alpert
ac1c90e864
Tweak whitespace README to show other change
2014-02-13 19:01:04 -08:00
Jason Bonta
47645854f9
un-revert textContent, support multi-line strings in modern browsers
...
reverts 23ab30ff87 because the issue it fixed doesn't seem to be a problem
anymore. textContent should be better for more things anyway, as the
original 309a88bcf6 indicates. It should be faster because innerText
requires layout.
This also allows us to use strings with newlines in our rendered output
and have confidence that they will render the same on subsequent
re-renders. This is especially useful for es6-style backtick multi-line
strings. This will be more consistent as textContent is supported almost
everwhere so we won't have differing behavior between webkit and
firefox.
see https://github.com/facebook/react/issues/1080
2014-02-13 18:21:35 -08:00
Josh Duck
acbba1ae67
Updates to perf
...
ReactDefaultPerf:
* Show times as float instead of string. This means they're sortable.
* Add count columns to all types and average to exclusive time.
* Include mountComponent where updateComponent time is measured.
* Increment count on _renderValidatedComponent instead of update.
ReactDefaultPerfAnalysis:
* Return counts with all summaries.
2014-02-13 18:21:17 -08:00
Cheng Lou
5c953a7bdd
Remove aural CSS numerial styles from CSSProperties
...
Those styles are not implemented in known browsers.
2014-02-13 18:21:03 -08:00
Paul O’Shannessy
d1a337b9db
Move jsx_whitespace_transform
...
Also add readme and more details to package.json so it can be published.
2014-02-13 15:58:19 -08:00
Paul O’Shannessy
1012b2ff4b
Merge pull request #979 from jeffmo/jsx_whitespace_codemod_tool
...
jsx whitespace codemod utility
2014-02-13 15:03:11 -08:00
Pete Hunt
6573a726ba
Merge pull request #1075 from spicyj/defperf
...
Measure root component render in ReactDefaultPerf
2014-02-13 10:49:19 -08:00
Pete Hunt
a5c518f69a
Merge pull request #855 from syranide/onerror
...
Add onError to ReactDOMImg to complement onLoad
2014-02-13 10:48:57 -08:00
Pete Hunt
f02c3c07d3
Merge pull request #1067 from spicyj/sandbox-seamless
...
Add seamless and sandbox properties for iframe
2014-02-13 10:48:37 -08:00
Pete Hunt
b04df6335a
Merge pull request #1069 from spicyj/gh-1028
...
Assert that event listeners are real functions
2014-02-13 10:48:20 -08:00
Pete Hunt
fff48c5921
Merge pull request #1076 from spicyj/button-warn
...
Don't warn about onChange for button inputs
2014-02-13 10:48:07 -08:00
Andreas Svensson
cda1d8c779
Add onError to ReactDOMImg to complement onLoad
2014-02-13 10:43:03 +01:00
Ben Alpert
6f305505a7
Remove old whitespace doc warning
...
This was fixed by #480 .
2014-02-13 01:37:06 -08:00
Ben Alpert
cd87848b7d
Don't warn about onChange for button inputs
2014-02-13 01:16:37 -08:00
Ben Alpert
55be7a71c5
Measure root component render in ReactDefaultPerf
...
Fixes #1074 .
2014-02-13 00:59:02 -08:00
Ben Alpert
f37474b75b
Merge pull request #1034 from nadeeshacabral/patch-1
...
Fixed sample code fence highlight
2014-02-12 23:23:49 -08:00
Ben Alpert
b0757c5182
Assert that event listeners are real functions
...
Fixes #1028 .
2014-02-12 23:21:46 -08:00
Ben Alpert
d0502cf3c1
Add seamless and sandbox properties for iframe
...
Fixes #1057 .
2014-02-12 21:06:43 -08:00
Pete Hunt
3895353326
[perf] Refactor ReactDefaultPerf and add DOM operation tracing
...
Split the summary functions into a separate module, and add the ability to view a lot of all DOM operations. Removed DOM timing since it was incorrect. Will potentially replace with a
dropped frame counter in the future.
2014-02-12 16:35:24 -08:00
Jason Bonta
5abcce5343
add lineClamp, vendor prefixes to CSSProperty.isUnitlessNumber
2014-02-12 16:35:09 -08:00
Pete Hunt
75b58d2ad2
[perf] Wasted time metrics
...
This logs DOM ops for a given reconcile. Based on which components rendered and which ones *actually* caused DOM updates we can find
opportunities to add shouldComponentUpdate() methods.
2014-02-12 16:34:37 -08:00
Pete Hunt
94ef6c51fb
[perf] Better inclusive measurements
...
Inclusive time is still not that helpful w/o looking at what actually resulted in DOM ops. However, this is better than what we have today and will serve as a building block.
I blacklisted everything but composite components -- hopefully that's OK.
2014-02-12 16:34:24 -08:00
Pete Hunt
439bca78ed
[perf] New ReactDefaultPerf
...
Simplified version of https://github.com/facebook/react/pull/962 . More goodies coming soon since the inclusive time isn't very helpful right now.
2014-02-12 12:30:02 -08:00
Pete Hunt
9ac27cb551
Rewrite ReactTransitionGroup
...
The key idea here is that you're always rendering `this.state.children`, not
`this.props.children`. When combined with `cloneWithProps()` this means we can
keep them in the DOM as long as we want. We add new children and reactively
update existing ones using `setState()` inside of `componentWillReceiveProps()`
so `this.state.children` always has the latest versions of components. Since we
may be keeping old components around that are no longer in
`this.props.children` we need a way to figure out where they should be inside
of the combined `this.state.children` list. `ReactTransitionChildMapping` does
this for us.
Based on that infrastructure we can build the interface we always wanted: enter
and leave lifecycle hooks.
When a component is added to the DOM, `componentWillEnter(callback)` gets
called. Call the callback when you're done animating and `componentDidEnter()`
will be called.
When a component is about to be removed from the DOM,
`componentWillLeave(callback)` gets called. Call the callback when you're done
animating and `componentDidLeave()` will be called and the component will
*actually* be removed from the DOM. It won't be removed until you call the
callback.
These also handle "concurrent" changes. If you "stack" enter/leaves of a single
component before the animation has completed, it will block out all of those
animations until the current animation completes, and then finally it will
animate 0 or 1 times to get itself into the desired current state. This is what
differentiates `componentWillEnter()` from `componentDidMount()`.
The next step would be to build `componentDidReorder()`.
I've built `ReactCSSTransitionGroup` which is identical to the old
`ReactTransitionGroup` and codemodded the callsites.
2014-02-12 12:29:58 -08:00
Pete Hunt
a6749a686f
[perf] Change how ReactDefaultPerf is injected
...
ReactDefaultPerf should inject itself when require()'d. This continues to support the ?react_perf use case for logging on initial page load.
2014-02-12 12:29:00 -08:00
Pete Hunt
12ebf33f89
[perf] Measure flush time
...
This is so we can look at a given flush to determine total time spent in React vs DOM, and which components ended up generating DOM ops.
2014-02-12 12:28:20 -08:00
Pete Hunt
d547374847
[perf] Log DOM time
...
Log the time it takes to perform all DOM operations
2014-02-12 12:27:53 -08:00
Pete Hunt
756bd975b1
[perf] Measure exclusive render time
...
Piece of https://github.com/facebook/react/pull/962
2014-02-12 12:27:18 -08:00
Paul O’Shannessy
da587b15d5
Merge pull request #1046 from spicyj/errutils
...
Disable guarding in ReactErrorUtils
2014-02-12 09:48:10 -08:00
Pete Hunt
db6ff14e7d
Update videos.md
...
There is a better video clip for the Meteor devshop
2014-02-11 22:57:56 -08:00
Ben Alpert
8f298fbd69
Disable guarding in ReactErrorUtils
...
With #1021 and #1022 , I believe this makes it so React never wraps user code in a try/catch. I left in the calls to ReactErrorUtils.guard because it sounds like FB code finds them useful.
2014-02-11 17:10:57 -08:00
Paul O’Shannessy
49747347fb
Merge pull request #1048 from spicyj/form-onreset
...
Add onReset event for forms
2014-02-11 14:42:15 -08:00
Ben Alpert
35d9286781
Refactor ReactMultiChild to not throw errors too
...
Missed these when I fixed up Transaction; with the exception of ReactErrorUtils, this should be everything.
2014-02-11 10:14:20 -08:00
Paul O’Shannessy
8cf5882447
Merge pull request #1021 from spicyj/close-finally
...
Set isInTransaction to false even if close throws
2014-02-11 09:27:09 -08:00
Paul O’Shannessy
3f243bc4f9
Merge pull request #1055 from spicyj/jsx-transformer-ie8
...
Disable source maps when defineProperty is missing
2014-02-11 09:20:29 -08:00
Sebastian Markbage
fc2805fe03
Add warnings when accessing properties/methods on unmounted components
...
This creates a membrane around the React component prototype. It warns if you
try to access properties on the component before it's unmounted. Before it's
mounted, it should be considered a descriptor and not an actual instance.
The workaround, for unknown types, is to access the constructor using
component.type which has static methods on it.
2014-02-11 09:13:03 -08:00
Ben Alpert
89bcecc76f
Disable source maps when defineProperty is missing
...
Fixes #1053 .
2014-02-11 00:10:06 -08:00
Cheng Lou
0f4cc6ee84
[Docs] Hide compiled js tab in jsx-compiler.html
...
Fixes #1049
2014-02-10 23:22:59 -08:00
Pete Hunt
25e56a4540
Update complementary-tools.md
2014-02-10 21:16:13 -08:00
Paul O’Shannessy
66b290c32f
Merge pull request #1042 from adelevie/master
...
Small grammar fix in ReactComponent.js
2014-02-10 16:18:55 -08:00
Paul O’Shannessy
6e5956195d
Remove references to autoflow, error wrapper
...
Fixes #1023
2014-02-10 14:39:57 -08:00
Pete Hunt
c544b01cad
Delete useless shit in ReactMount
...
lol
2014-02-10 14:31:15 -08:00
Pete Hunt
5f1d4d7c14
ReactInjection
...
Consolidate everything we can inject in core into one place. Does not expose publicly -- this is an internal moving of shit around.
2014-02-10 14:30:59 -08:00
Paul O’Shannessy
c1c2dd9a89
Add noValidate and corresponding formNoValidate
...
Fixes #988
2014-02-10 12:01:28 -08:00
Paul O’Shannessy
acfef143ae
Merge pull request #1045 from spicyj/srcdoc
...
Add HTML5 srcdoc property for iframes
2014-02-10 12:00:43 -08:00
Ben Alpert
30fd3a30b0
Add onReset event for forms
...
Test Plan:
Tested in Chrome and IE8.
2014-02-10 11:12:26 -08:00
Pete Hunt
2e17144ac0
Update complementary-tools.md
2014-02-10 10:37:59 -08:00
Ben Alpert
40547125f8
Add HTML5 srcdoc property for iframes
2014-02-09 21:03:37 -08:00
Pete Hunt
eb3d516f40
Update complementary-tools.md
2014-02-09 19:18:11 -08:00
Alan deLevie
1194a040f9
remove comma in comment
2014-02-08 19:26:36 -05:00
Alan deLevie
42e65ddb3e
Small comment grammar fix in ReactComponent.js
2014-02-08 19:25:49 -05:00
Paul O’Shannessy
141f3a8ac8
Merge pull request #1040 from zpao/react-tools-revamp
...
react-tools revamp
2014-02-07 13:59:56 -08:00
Paul O’Shannessy
d00b11ef03
Remove React from react-tools package
...
All of this is provided by the react package now, so there's no point in having
it available in multiple places. We *may* go back on that in the future for
shipping test utils, but for the time being, this is better for all.
2014-02-07 13:59:19 -08:00
Paul O’Shannessy
463f940c7f
Build react-tools package on build, upload to builds site
2014-02-07 13:59:18 -08:00
Paul O'Shannessy
26fb009e0c
fix comment
2014-02-07 13:51:39 -08:00
Cheng Lou
9ae002503c
Ensure a pooled class releases back into the pool an instance of that class
...
Also added tests for PooledClass.
Noticed that some places use `ReactReconcileTransaction.release(transaction)`, when `transaction` might be of another class, say `ReactServerRenderingTransaction` (still a Github PR). This catches that.
2014-02-07 13:51:14 -08:00
Paul O’Shannessy
b199de29a0
Cleanup jsx tasks
...
debug and release are now identical, so there's no need to have both.
2014-02-07 10:21:19 -08:00
Ben Alpert
bc27325d31
Merge pull request #1003 from rdworth/patch-1
...
Update tutorial.md to still have jQuery script tag in later code sample
2014-02-07 00:08:22 -08:00
Paul O’Shannessy
d8700f04da
Actually upload react.tgz to builds server
2014-02-06 23:59:58 -08:00
Ben Alpert
721ac85bf8
Merge pull request #1039 from imagentleman/patch-2
...
Update broken link in "Why React" post
2014-02-06 21:18:56 -08:00
imagentleman
3141bc5084
Update broken link in "Why React" post
...
The AngularJS docs have been updated since the post was originally published.
It should point to the docs from that date (June 5th).
2014-02-06 23:41:48 -05:00
Ben Alpert
bc1e950a41
Merge pull request #1038 from imagentleman/patch-1
...
Docs: Fixed reference to unreachable url.
2014-02-06 20:40:47 -08:00
imagentleman
e9e44773ee
Docs: Fixed reference to unreachable url.
2014-02-06 21:32:30 -05:00
Paul O’Shannessy
94d11ecf05
build npm-react module, upload to builds page
2014-02-06 15:06:10 -08:00
cpojer
71c10b9f45
Add PropTypes.ArrayOf and clean up ReactPropTypes.js
2014-02-06 11:28:51 -08:00
Nadeesha Cabral
5f941628e0
Fixed missing lighted line
...
The line number added had been changed from the previous representation of the code fence, but was not highlighted. Therefore, fixed.
2014-02-06 19:11:19 +05:30
Ben Alpert
497dab2ad9
Merge pull request #1033 from bripkens/tostring-docs
...
docs(ServerRendering): Reflect renderComponentToString changes
2014-02-05 22:59:13 -08:00
Ben Ripkens
4c1a737343
docs(ServerRendering): Reflect renderComponentToString changes
2014-02-06 07:56:37 +01:00
Pete Hunt
73b4f954f2
DOMIDOperations -> BackendIDOperations
2014-02-05 19:47:54 -08:00
Paul O’Shannessy
4ebdb2c0ac
Merge branch 'spicyj-uncontrolled-select'
...
Closed #907
2014-02-05 16:42:32 -08:00
Paul O’Shannessy
e0262d50f9
Skip assignment, just call updateOptions directly
2014-02-05 16:41:57 -08:00
Paul O’Shannessy
647e65525c
Center twitter embeds differently. again.
...
This time, just target the iframe. display: table was weird in webkit.
2014-02-05 16:25:13 -08:00
Paul O’Shannessy
8360da2937
Don't use <center> for twitter embeds
2014-02-05 15:51:06 -08:00
Jonas Gebhardt
2f812b6f9b
Community Round-Up #15 ; center embedded tweets
2014-02-05 15:19:53 -08:00
Ben Alpert
c7dd8d4217
Refactor updateOptions to take value
2014-02-05 11:46:34 -08:00
Ben Alpert
9c5c1ed902
Make uncontrolled select not set value on update
2014-02-05 11:39:44 -08:00
Paul O’Shannessy
7ad28183b4
Merge pull request #1019 from petehunt/docs99
...
Update docs for React.Children
2014-02-05 11:37:38 -08:00
Paul O’Shannessy
2031946946
Re-add strict warning to Danger test
...
Lost in the great reorg
2014-02-05 11:01:29 -08:00
Paul O’Shannessy
b9cd2f0d3d
Merge branch 'reorg'
2014-02-04 19:51:55 -08:00
Paul O’Shannessy
2435b66840
Fix version check test
2014-02-04 19:49:58 -08:00
Paul O’Shannessy
a528beeda9
Put ReactWithAddons in browser/
2014-02-04 19:49:58 -08:00
Pete Hunt
1a39c3143c
The great reorg of February 2014
2014-02-04 19:49:58 -08:00
cpojer
a21979404c
Add canUseEventListeners to ExecutionEnvironment.
2014-02-04 15:09:41 -08:00
Pete Hunt
9730759322
Fix cloneWithProps() to allow overriding props
...
This is a clear bug.
2014-02-04 14:37:53 -08:00
Pete Hunt
945f788a41
React.Children helpers
...
Adds React.Children and map(), forEach() and only().
2014-02-04 14:37:44 -08:00
Paul O’Shannessy
8d1d29286a
Merge pull request #1013 from bripkens/lint
...
Fix use strict warnings
2014-02-04 12:39:41 -08:00
Ben Alpert
17f602f924
Set isInTransaction to false even if close throws
...
If a transaction wrapper's closer throws (such as flushBatchedUpdates in ReactDefaultBatchingStrategy) then we still want to properly deinitialize the transaction by setting isInTransaction to false. Without this, we can't reuse the transaction object (in this case, all future batched updates would fail because nested transactions aren't allowed).
2014-02-04 12:03:29 -08:00
Pete Hunt
7aaa3a4ed1
Merge pull request #922 from spicyj/submit-submit
...
Fix double-binding to submit event
2014-02-04 10:25:34 -08:00
Pete Hunt
3642b6ea62
Merge pull request #982 from bripkens/async-tostring
...
fix(ServerRendering): execution should be async
2014-02-04 10:24:22 -08:00
Paul O’Shannessy
bced44533f
Merge pull request #967 from syranide/noie8catch
...
Remove unnecessary catch-clauses for try-finally
2014-02-04 10:11:06 -08:00
Andreas Svensson
f9bb6e46f1
Remove unnecessary catch-clauses for try-finally
2014-02-04 18:07:34 +01:00
Ben Ripkens
e14555caed
Use lowercase "string" so that the documentation complies with typecheckers
2014-02-04 09:05:52 +01:00
petehunt
aebfd641aa
more references
2014-02-03 23:33:20 -08:00
petehunt
9e1c6950b1
update docs for React.Children
2014-02-03 23:28:49 -08:00
Ben Ripkens
220687abda
Add new lines above use strict and keep directives at the top
2014-02-04 07:47:35 +01:00
Pete Hunt
0dc0b45f3c
Merge pull request #1018 from stoyan/patch-2
...
joe -> la web speed
2014-02-03 22:31:23 -08:00
Stoyan
c8a2018228
Update videos.md
2014-02-03 22:09:00 -08:00
Paul O’Shannessy
19ff353fdd
Merge pull request #975 from spicyj/transaction-no-catch
...
Refactor Transaction to not rethrow errors
2014-02-03 21:43:27 -08:00
Paul O’Shannessy
4992423547
Merge pull request #1005 from jjt/boolattr
...
Fix boolean attributes as per HTML5 spec
2014-02-03 18:17:46 -08:00
Ben Newman
6d4b470cfc
Merge pull request #1016 from benjamn/revert-pure-cjs-until-0.9
...
Revert commits switching from browserify to pure-cjs (on hold until after v0.9 ships).
2014-02-03 16:09:37 -08:00
Ben Newman
9f1ed709d0
Revert "Switched from browserify to pure-cjs bundler."
...
This reverts commit bff9731b66 .
2014-02-03 19:05:22 -05:00
Ben Newman
77c53dd5d4
Revert "More optimizations and fix for JSXTransformer build"
...
This reverts commit f1b7db9aef .
2014-02-03 19:05:15 -05:00
Ben Newman
e994e06c54
Revert "Removed redundant uglification"
...
This reverts commit 86373d924c .
2014-02-03 19:05:09 -05:00
Ben Newman
806e879566
Merge pull request #1002 from RReverser/pure-cjs
...
Switch from browserify to pure-cjs bundler.
2014-02-03 16:01:13 -08:00
Pete Hunt
fa046ca04e
Merge pull request #963 from bobeagan/patch-1
...
Replace "comments.json" with this.props.url in the docs tutorial code snippet
2014-02-03 15:08:17 -08:00
azure provisioned user
86373d924c
Removed redundant uglification
...
Removed uglification for separate files since it significantly slowed down build (browserify:min became 26 sec instead of 110, same for :addonsMin) while gave economy in ~70 bytes for min+gz version.
2014-02-03 22:06:38 +00:00
Cheng Lou
5dabba999b
add missing 'use strict' to getTestDocument
2014-02-03 12:52:46 -08:00
Cheng Lou
57bf7d21f3
fix transaction comment from componentDidRender to componentDidUpdate
2014-02-03 12:52:36 -08:00
Ben Newman
ce95c3d042
[React] Don't attach to document in ReactTestUtils.renderIntoDocument.
2014-02-03 12:51:34 -08:00
Ben Ripkens
92fdc1562d
Use strict in tests
2014-02-03 20:29:33 +01:00
Ben Ripkens
4e9352f8f8
Fix use strict warnings
2014-02-03 13:11:51 +01:00
Ben Ripkens
cd2aecc377
fix(ServerRendering): execution should be sync
...
The documentation states that React.renderComponentToString
'uses a callback API to keep the API async', but the
implementation is actually synchronous. In order to maintain
this contract the callback should always be called
asynchronously or be change to a synchronous API.
As per the discussion of pull request 982, the API should
be changed to a synchronous one.
2014-02-03 11:39:09 +01:00
Pete Hunt
85270ae154
Merge pull request #1012 from jaredly/patch-1
...
adding a link to react-router
2014-02-02 13:34:58 -08:00
Jared Forsyth
92a20220e7
adding a link to react-router
2014-02-02 01:23:12 -07:00
Pete Hunt
e4d1618f63
Update example-apps.md
2014-02-01 18:43:12 -08:00
Christopher Chedeau
78f3addd01
Merge pull request #1011 from petehunt/complementary-tools
...
Add a complementary tools page
2014-02-01 18:36:45 -08:00
Christopher Chedeau
036303ee90
Merge pull request #1010 from petehunt/meteorvid
...
Add link to meteor talk
2014-02-01 18:35:43 -08:00
petehunt
26c6ea961b
add example apps page
2014-02-01 18:11:00 -08:00
petehunt
aaada5e212
Add a complementary tools page
2014-02-01 17:43:56 -08:00
Pete Hunt
f18bda51d6
Update videos.md
2014-02-01 17:01:52 -08:00
petehunt
3119d66e26
Add link to meteor talk
2014-02-01 17:01:19 -08:00
Ben Alpert
98432365d9
[docs] Fix comma splice
2014-01-31 22:30:38 -08:00
Ben Alpert
a2e805b26e
Disable CodeMirror smart indentation
...
Fixes #966 .
2014-01-31 22:10:37 -08:00
jjt
f7949c1c23
Fix boolean attributes as per HTML5 spec
2014-01-31 17:24:48 -08:00
Paul O’Shannessy
fce6d114fe
Merge pull request #973 from syranide/hidethekill
...
Fix references to the old ReactID syntax
2014-01-31 15:33:57 -08:00
Ingvar Stepanyan
f1b7db9aef
More optimizations and fix for JSXTransformer build
...
* Dropped dependency on emulation of Node.js native modules.
* Added deamdify step for JSXTransformer build.
2014-01-31 21:53:08 +02:00
Christopher Chedeau
f1b54bc310
s/Mock DOM/Virtual DOM/
...
Let's be consistent with the naming
2014-01-31 10:57:06 -08:00
Richard D. Worth
e58064a8db
Update tutorial.md to still have jQuery script tag in later code sample
2014-01-31 12:13:52 -06:00
Ingvar Stepanyan
bff9731b66
Switched from browserify to pure-cjs bundler.
2014-01-31 18:25:09 +02:00
Sebastian Markbåge
1666935878
Merge pull request #1001 from kmeht/renderComponentDocs
...
Add documentation about React.renderComponent
2014-01-30 17:29:59 -08:00
Kunal Mehta
43a242b67f
Add documentation about React.renderComponent
...
Recently learned that components passed into `React.renderComponent` may not be the ones actually mounted. Also learned that it returns the mounted component. Added some documentation describing this.
2014-01-30 17:14:59 -08:00
Josh Duck
5d7563f706
Fix warning for numeric properties
...
Number('.1') === 0.1, and react uses dot-prefixed keys
for children. Whoops. Nuke the non-numeric requirement, and just
check a regex. This seems performant enough in micro-benchmarks:
http://jsperf.com/numericlike
2014-01-30 16:54:01 -08:00
Pete Hunt
4cbc4b58f6
Support children and ref for cloneWithProps()
...
We're not handling these correctly.
2014-01-30 16:53:47 -08:00
Pete Hunt
b225b34f91
Merge pull request #985 from petehunt/remove-react-page
...
Remove references to react-page
2014-01-30 10:40:48 -08:00
Pete Hunt
32f69713fc
Merge pull request #995 from Contra/patch-1
...
fix grammar mistake (reconciliation docs)
2014-01-30 10:40:28 -08:00
Eric Schoffstall
cf1089fa0e
fix grammar mistake
2014-01-29 20:19:51 -07:00
Josh Duck
00f2a053f0
Warn for numeric object properties
...
Numeric keys will be ordered sequentially in Chrome/Firefox.
Warn the user if such keys are set on a child.
2014-01-29 14:08:23 -08:00
Ben Newman
65490a09e6
Use querySelectorAll instead of getElementsByName in ReactDOMInput.
...
We've been able to use `querySelectorAll` in all the browsers that we
support for some time now, but we haven't been able to test code that uses
it in the older version of `jsdom` that we were using, until recently.
Besides the general goal of modernizing our code, the impetus for this
specific change is that I'm trying to support testing without having to
render nodes into an actual document. The `.getElementsByName` method is
only defined on `document` and only works if the nodes you care about are
contained by the document.
On the other hand, `querySelectorAll` works on any DOM node, and allows a
more precise selection of just the `<input type="radio">` elements that
have the appropriate name.
IE8's implementation of `querySelectorAll` supports attribute-based
selectors, which is all we need here.
2014-01-29 14:08:21 -08:00
Paul O’Shannessy
d8e9eb978b
Fix animation example code
...
key should never be index into an array or there are bugs. Especially in
transitions.
Fixes #853
2014-01-29 13:06:22 -08:00
Pete Hunt
46c6ac5bb0
Update 09.2-form-input-binding-sugar.md
2014-01-29 12:45:46 -08:00
Pete Hunt
132e8b3c43
Merge pull request #880 from jbaiter/reactlink_checkbox
...
Support two-way binding for checkboxes in LinkedValueMixin via 'checkedLink' property
2014-01-29 12:44:30 -08:00
Ben Alpert
4894055114
Fix docs typo
2014-01-29 11:19:45 -08:00
Josh Duck
b5dbbd5b2d
Add warning about object property order.
...
It's easy to misuse the properties-as-keys feature and end up with children rendered out of order. Add a note and example of how to avoid this.
2014-01-29 10:53:21 -08:00
petehunt
470a7d11ee
remove references to react-page
2014-01-28 16:02:16 -08:00
Ben Newman
34e6a51e19
Merge pull request #981 from benjamn/upgrade-commoner-to-remove-output-directory-locking
...
Upgrade Commoner to v0.9.0 to get rid of output directory locking.
2014-01-27 19:21:32 -08:00
Ben Newman
933681b42c
Upgrade Commoner to v0.9.0 to get rid of output directory locking.
...
Closes #957 .
2014-01-27 19:07:00 -08:00
Ben Newman
0bca41fc93
Merge pull request #980 from benjamn/issue-856-delete-build-modules
...
Remove build/modules/ at beginning of `grunt` and `grunt test`.
2014-01-27 18:01:18 -08:00
Ben Newman
864366d082
Remove build/modules/ at beginning of grunt and grunt test.
...
Little-known fact: instead of writing copies of compiled module files to
build/modules/, the bin/jsx-internal script actually just makes hard links
to the master versions of files in the .module-cache/, so re-populating
build/modules/ is very inexpensive.
Closes #856 .
2014-01-27 16:46:01 -08:00
JeffMo
f368f18b61
jsx whitespace codemod utility
2014-01-27 13:08:36 -08:00
Ben Newman
36fd1def84
Move grunt/config/jsx/jsx.js to grunt/config/jsx.js.
...
There used to be more files in that subdirectory.
2014-01-27 12:09:55 -08:00
Paul O’Shannessy
0e5dfd3fec
Merge pull request #964 from bobeagan/patch-2
...
fix incorrect link
2014-01-27 11:26:33 -08:00
Ben Alpert
d300df51e1
Refactor Transaction to not rethrow errors
...
Rethrowing errors makes debugging harder. This makes it so that an exception in a render method can be caught using the purple stop sign (or the blue one, of course) in Chrome.
2014-01-26 15:51:37 -08:00
Andreas Svensson
989eb2e7d9
Fix references to the old ReactID syntax
2014-01-26 21:26:58 +01:00
Pete Hunt
526be1570e
Fix memory leak with renderComponentToString()
...
This is leaking memory. Move event registration to mount time.
2014-01-24 18:23:51 -08:00
Bob Eagan
e3342f31b2
add hash link for lifecycle section of working with the browser page
2014-01-24 16:46:09 -07:00
Bob Eagan
4aececb645
fix incorrect link
2014-01-24 11:10:16 -07:00
Bob Eagan
7614af3c9a
replace "comments.json" with this.props.url
2014-01-24 08:52:00 -07:00
Pete Hunt
4975113f20
Merge pull request #958 from aymanosman/master
...
Fix typo
2014-01-24 03:38:14 -08:00
Jeff Morrison
ce92efefc0
Codemod for whitespace change
...
This codemods to shim any old-style JSX whitespace so that it renders the same as before.
Basically it sticks explicit `{' '}` spaces in where spaces are no longer implicit.
2014-01-23 13:52:38 -08:00
Paul Shen
4a5a6ad733
Transfer the key prop in cloneWithProps
...
`cloneWithProps` uses `ReactPropTransferer`, which ignores the `key`
prop. See https://github.com/facebook/react/pull/713
However, this is not the case with `cloneWithProps` because when someone
is cloning a component and provides a key, they mean for the clone to
take it.
2014-01-23 13:48:39 -08:00
Pete Hunt
62b52e008e
Don't reconcile children unneccessarily
...
We've talked about this perf optimization for a while now. This prevents us from re-reconciling components that are above the component being
reconciled in the owner hierarchy.
2014-01-23 13:48:36 -08:00
Ben Newman
b1e6c4d0dd
Merge pull request #959 from benjamn/commoner-multiple-file-support
...
Upgrade Commoner to v0.8.14 for multiple file support.
2014-01-23 13:10:17 -08:00
Jeff Morrison
db04043eaa
Merge pull request #480 from syranide/whitespace
...
JSX whitespace coalescing rules
2014-01-23 12:32:57 -08:00
Ben Newman
1e702f7258
Upgrade Commoner to v0.8.14 for multiple file support.
...
See [Commoner's README.md](
https://github.com/benjamn/commoner#generating-multiple-files-from-one-source-module )
for further explanation of the new functionality.
Among other potential benefits, this upgrade allows us to generate source
maps as standalone files rather than appending them inline to every
compiled module file under `build/modules/` (see #833 ).
2014-01-23 15:25:20 -05:00
Ayman Osman
97518fd664
Fix typo
2014-01-23 19:21:20 +00:00
Paul O’Shannessy
38491c7c93
Merge pull request #952 from jeanlauliac/patch-1
...
Update broken link in 'why react' article
2014-01-23 09:40:28 -08:00
Johannes Baiter
ad9c5e9242
Use Simulate.click instead of Simulate.input for simulating input on
...
checkbox.
2014-01-23 10:53:36 +01:00
Johannes Baiter
91ef878ca8
Fix comparison in _handleLinkedCheckChange
2014-01-23 10:53:36 +01:00
Johannes Baiter
2521b47707
Fix typo in ReactDOMInput-test
2014-01-23 10:52:55 +01:00
Johannes Baiter
79995a05c7
Add invariant if both checkedLink and valueLink are provided
2014-01-23 10:52:54 +01:00
Johannes Baiter
7b047111a0
Support two-way binding for checkboxes in LinkedValueMixin via 'checkedLink' property
2014-01-23 10:49:02 +01:00
Jean Lauliac
b872100be6
Normalize internal links in 'why react' article
2014-01-22 22:01:20 +01:00
Jean Lauliac
14cb99c9aa
Update broken link in 'why react' article
2014-01-22 21:53:36 +01:00
Andreas Svensson
c16b5659a0
Implement stricter whitespace rules
2014-01-22 21:00:10 +01:00
Pete Hunt
0af9c3ebe7
Merge pull request #748 from spicyj/private-getvalue
...
Change LinkedValueMixin to a util class
2014-01-22 10:54:13 -08:00
Ben Alpert
95a80591dd
Change LinkedValueMixin to a util class
...
This makes it clear that .getValue() is not a public API.
2014-01-22 09:57:59 -08:00
Paul O’Shannessy
f0b01d0faa
Merge pull request #885 from syranide/natext
...
Remove unnecessary 'NA'-fallback for getTextContentAccessor()
2014-01-21 17:22:48 -08:00
Paul O’Shannessy
1d1a790df0
Merge pull request #901 from syranide/80chars
...
Fix lines longer than 80 chars
2014-01-21 17:09:24 -08:00
cpojer
ca02a068b8
Update propTypes documentation.
2014-01-21 16:45:34 -08:00
cpojer
8b12670ef9
Perf Test for the propTypes change.
2014-01-21 14:05:38 -08:00
cpojer
2cac321b27
Change ReactPropTypes invariant's to console.warn.
2014-01-21 14:05:33 -08:00
Paul O’Shannessy
9c91546451
Merge pull request #918 from spicyj/npm-react-rec
...
Fix copying files to build/npm-react recursively
2014-01-21 13:03:57 -08:00
Paul O’Shannessy
494f6e9c34
Merge pull request #921 from spicyj/grunt-jsx-no-dev
...
Remove unused grunt jsx config options
2014-01-21 11:40:43 -08:00
Pete Hunt
e3248efe92
Merge pull request #934 from syranide/minid
...
Shortened generated "data-reactid"
2014-01-20 13:26:42 -08:00
Andreas Svensson
559cd46181
Shortened generated "data-reactid"
2014-01-20 22:03:25 +01:00
Ben Alpert
e931dba107
Merge pull request #731 from fabiomcosta/jsxtransform-filename
...
Adds filename to JSXTransform error messages
2014-01-20 12:18:37 -08:00
Fabio M. Costa
de7a92afa7
Updating error message to also show part of the code, making it easier to find the error
2014-01-20 11:57:35 -08:00
Fabio M. Costa
d829d1ab9b
Adding current page's url for inline code and code improvement
2014-01-20 11:57:34 -08:00
Fabio M. Costa
b1a949ed45
Adds the filename to JSXTransform error message, making it easier to debug JSX syntax errors.
2014-01-20 11:55:17 -08:00
Cheng Lou
4b392f19a8
Merge pull request #861 from andrewdavey/unitless-css-props
...
Unitless css props
2014-01-17 21:49:24 -08:00
Ben Alpert
ffc31ed77b
Merge pull request #914 from chenglou/jsx
...
tweak frontpage first example code
2014-01-17 18:27:51 -08:00
Paul O’Shannessy
df8d092609
Merge pull request #924 from zpao/update-deps
...
Update build dependencies
2014-01-17 18:01:43 -08:00
Paul O’Shannessy
ca930efa7c
Upgrade (explicitly) grunt
...
They deprecated the use of some packaged modules and suggest using those modules
directly. http://gruntjs.com/blog/2013-11-21-grunt-0.4.2-released
Lodash was the only use we had.
2014-01-17 18:00:40 -08:00
Paul O’Shannessy
9558285f09
Update other dependencies
2014-01-17 18:00:40 -08:00
Paul O’Shannessy
c5f0e14985
Update browserify
...
Also update bundle.transform call site, which now takes options
2014-01-17 18:00:40 -08:00
Cheng Lou
d8d4120614
[docs] Tweak frontpage first example and jsx-compiler example
2014-01-17 17:53:44 -08:00
Ben Alpert
ea711f1d62
Simplify live editor execution logic
2014-01-17 17:42:53 -08:00
Ben Alpert
4440486a24
Properly clear live editor on JSX compile failure
2014-01-17 17:42:40 -08:00
Nick Thompson
0d2510ad9c
Add span property to React DefaultDOMPropertyConfig
...
So that the `span` attribute on <colgroup> tags isn't swallowed by
React.
2014-01-17 17:17:31 -08:00
Tim Yung
79beb71d69
Fix ChangeEventPlugin Dependencies
...
When React moved to attaching top-level event listeners on-demand, not all of the dependencies for `ChangeEventPlugin` were set. This led to `onChange` events not firing under certain circumstances. For example, listening to `onChange` on a checkbox will not work because it relies on `onClick` (unless something else on the page was listening to `onClick`).
2014-01-17 17:17:31 -08:00
Cheng Lou
d489637a4f
Merge pull request #931 from spicyj/master
...
Update homepage for new JSX/JS editor
2014-01-17 16:56:40 -08:00
Ben Alpert
2ac36178c6
Update homepage for new JSX/JS editor
2014-01-17 16:46:50 -08:00
Paul O’Shannessy
487f633643
Normalize line endings
2014-01-17 16:28:32 -08:00
Paul O’Shannessy
8abca77381
.gitattributes to ensure LF line endings when we should
2014-01-17 16:25:53 -08:00
Cheng Lou
71b585325c
docs add jsx->js tab to live editors
2014-01-17 15:49:59 -08:00
Sebastian Markbåge
a05cef4a40
Merge pull request #852 from spicyj/no-store-mount-image
...
Don't store mount image on component instance
2014-01-17 15:44:57 -08:00
Cheng Lou
4f53f58754
docs fix back link in Examples
2014-01-17 15:21:49 -08:00
Paul O’Shannessy
ef4bda326e
Merge pull request #822 from chenglou/setstate
...
better error for bad setState arguments and mergeHelpers
2014-01-17 13:05:06 -08:00
Pete Hunt
804280275b
Merge pull request #928 from nick-thompson/componentWillMount-descrip
...
Clarify componentWillMount behavior
2014-01-17 12:46:47 -08:00
Nick Thompson
c2d57dff4b
Clarify componentWillMount behavior
2014-01-17 12:44:21 -08:00
Ben Alpert
c72e906841
Fix double-binding to submit event
...
Fixes #916 .
2014-01-17 03:00:08 -08:00
Ben Alpert
703a29c0b2
Remove unused grunt jsx config options
...
Since 5466d0a063 , the `__DEV__` isn't used any more. I can't find anything that uses the `debug` flag either.
2014-01-17 02:02:47 -08:00
Ben Alpert
76a7e2de75
Fix copying files to build/npm-react recursively
...
The intention of the `npm-react/**/*` rule was to copy recursively but it would have flattened any nested directory structure. I changed the `build/modules` rule to copy recursively as well, which is necessary for `ReactTestUtils` to be able to require `test/mock-modules.js` successfully. (`ReactTestUtils` isn't included in a clean `npm-react` build currently but it will be in the future.)
This also makes running ART tests more practical.
2014-01-17 01:15:15 -08:00
Christopher Chedeau
2562813c63
Document isMounted
...
Text from @petehunt
2014-01-16 10:08:53 -08:00
Jeff Morrison
89819de4f2
Kill last remaining use of $ in React
...
It's only used here, so let's just inline this and get rid of the additional module.
Also it will make people like this guy happy: https://github.com/facebook/react/issues/900
(of course he might be even more happy if he wasn't using MS TFS....but that's a much bigger diff, and not one I can write...)
2014-01-15 16:46:11 -08:00
Alex Zelenskiy
b5f905523b
Adding 'scope' to list of standard html attributes in react
...
scope is used for screen readers, so it would be nice to have. Documentation here: http://www.w3.org/TR/WCAG20-TECHS/H63
2014-01-15 16:44:28 -08:00
Isaac Salier-Hellendag
4bdea53d6e
Add topContextMenu to the event dependencies for SelectEventPlugin
2014-01-15 16:43:41 -08:00
Christopher Chedeau
9ade3c26d3
Introduce PropTypes.shape
...
This diff introduces PropType.shape which lets you type an object. PropType.object was already defined and since it isn't a function I couldn't really overload the meaning to also accept a type list. Instead of doing hackery, I decided to name it `shape`.
An example where this could be used is style:
```
propTypes: {
style: PropTypes.shape({
color: PropStyle.string,
fontSize: PropTypes.number
})
}
```
2014-01-15 16:42:04 -08:00
Cheng Lou
0906d282ec
throw when using component/component class as mixin
...
throw invariant error to help people new to mixins, so that they don't get misled into trying to mixin components into another component
2014-01-15 16:41:45 -08:00
Paul O’Shannessy
8ca62bd022
[docs] Remove commented out ghbtns
2014-01-15 11:40:36 -08:00
Paul O’Shannessy
a69f98b834
[docs] Add timezone to _config
...
This way we hopefully won't churn the feed when genereated in
a different time zone (eg France).
2014-01-15 11:14:15 -08:00
Paul O’Shannessy
e1f4357ff7
Remove stray "117", combine lines in polyfill docs
2014-01-15 11:08:10 -08:00
Pete Hunt
615dedc3e2
Merge pull request #881 from spicyj/checkbox-not-checked
...
"checkbox" not "checked"
2014-01-15 11:04:36 -08:00
Pete Hunt
94727f8223
Merge pull request #897 from spicyj/gh-208
...
Wrap _performComponentUpdate call in try/finally
2014-01-15 10:38:26 -08:00
Christopher Chedeau
a821f03cf4
Merge pull request #892 from rtfeldman/update-shim-docs
...
Mention need for `es5-sham.js` in docs
2014-01-15 09:15:59 -08:00
Andreas Svensson
fd02f2c1cd
Fix lines longer than 80 chars
2014-01-15 15:19:14 +01:00
Richard Feldman
c3a2ea2256
Rewrite Older Browsers polyfill section for clarity.
2014-01-14 21:59:53 -08:00
Timothy Yung
977b60c1ed
Fix "Uncontrolled Components" documentation
2014-01-14 21:13:27 -08:00
Ben Alpert
091534c376
Wrap _performComponentUpdate call in try/finally
...
Fixes #208 . If you attempt a state update with a bad state then the render will fail (and the DOM won't change) but if you switch back to a valid state later then it'll rerender properly.
2014-01-14 20:30:07 -08:00
Pete Hunt
17de85689e
Merge pull request #895 from spicyj/zomgperf
...
Make findComponentRoot faster with more nodeCache
2014-01-14 18:58:54 -08:00
Paul O’Shannessy
b131da3869
Merge pull request #884 from spicyj/tut-datatype
...
Add dataType to all $.ajax calls for consistency
2014-01-14 18:48:05 -08:00
Ben Alpert
d96c6914c7
Make findComponentRoot faster with more nodeCache
...
This is an alternative, less-invasive, fix for #891 .
Test Plan:
On http://jsbin.com/OqOJidIQ/2/edit , got timings like
[75, 56, 30, 36, 27, 27, 28, 32, 27, 27, 28, 31]
instead of the old
[75, 729, 46, 32, 28, 34, 26, 27, 27, 30, 26, 26].
I also added a counter to getID and saw it was called 3014 times instead of the old 636264. (3014 is the number of nodes (3000) plus 3 calls that happen for the initial render and 1 for each of the 11 renders after that.)
2014-01-14 18:32:40 -08:00
Richard Feldman
f62ec225e0
Fix typo in docs.
2014-01-14 17:09:39 -08:00
Richard Feldman
9420e86480
Update docs to mention that you need both es5-shim.js and es5-sham.js to use React with IE8.
2014-01-14 16:57:27 -08:00
cpojer
c885abbf21
Allow null return values for functions to-be-merged.
2014-01-14 13:05:31 -08:00
Andreas Svensson
6c7697a1a9
Remove unnecessary 'NA'-fallback for getTextContentAccessor()
2014-01-14 11:41:23 +01:00
Ben Alpert
eb2ac7f2f2
Add dataType to all $.ajax calls for consistency
...
Fixes https://groups.google.com/forum/#!topic/reactjs/WWA3ZqU6y4w .
2014-01-13 19:54:09 -08:00
Pete Hunt
d9b959884b
Merge pull request #878 from spicyj/mount-unmounted
...
Improve "Can only mount when umounted" message
2014-01-13 14:38:07 -08:00
Ben Alpert
5857eb884c
"checkbox" not "checked"
...
I can only assume this was a typo.
2014-01-13 14:28:56 -08:00
Ben Alpert
2f027fce2d
Improve "Can only mount when umounted" message
2014-01-13 13:26:24 -08:00
Isaac Salier-Hellendag
ad70848e80
Use fallback data for composition events if necessary
2014-01-13 13:15:17 -08:00
Pete Hunt
c6f91ee6e8
Merge pull request #864 from spicyj/transition-key-set-faster
...
Rewrite mergeKeySets to be O(n) instead of O(n^3)
2014-01-13 12:50:42 -08:00
Christoph Pojer
ca1ecc626b
Merge pull request #876 from spicyj/cb-ctx
...
Always call callback in component context
2014-01-13 09:04:33 -08:00
Ben Alpert
1825f30353
Always call callback in component context
...
This brings these other call sites in line with line 67 of ReactUpdates.js:
callbacks[j].call(component);
2014-01-13 08:59:48 -08:00
Christoph Pojer
124096a9fe
Fix #845 , Trivial year change
...
This was accidentally pulled into gh-pages.
2014-01-13 08:56:20 -08:00
Christoph Pojer
ad6a982cd0
Fix #874 : Edit thinking-in-react
...
Accidentally pulled #874 into gh-pages.
2014-01-13 08:51:29 -08:00
Cheng Lou
3d47177596
fix propTypes.any.weak test
...
accidentally copied over `.string.weak` and didn't change it
2014-01-12 20:47:16 -08:00
Pete Hunt
ddcab8be99
Merge pull request #871 from fernandoacorreia/jquery-mobile-example
...
jQuery Mobile React Example
2014-01-12 13:03:36 -08:00
Fernando Correia
425fd2ca08
jQuery Mobile React Example
2014-01-12 17:04:42 -02:00
Paul O’Shannessy
59cba3e9f7
Add missing semicolon I missed in #865
2014-01-11 23:29:35 -08:00
Paul O’Shannessy
6ebb1cb3ee
Merge pull request #865 from jergason/link-to-docs-on-keys-warning
...
link to docs in unique key prop warning
2014-01-11 23:21:46 -08:00
Jamison Dance
972acb4581
link to docs in unique key prop warning
2014-01-11 22:17:06 -07:00
Paul O'Shannessy
2c335b0e57
Quieter devtools upsell
...
Check that we're not in a iframe before upselling.
2014-01-10 21:11:33 -08:00
Cheng Lou
d14ce00dc3
add React.PropTypes.any
...
add the ability for React propTypes to accept an `any` type: `someProp: React.PropTypes.any`.
This is more useful when combined with `.isRequired`, to enforce that _something_ is passed:
`someProp: React.PropTypes.any.isRequired`
2014-01-10 21:11:11 -08:00
Pete Hunt
d8a8f6a881
Upsell dev tools
...
People probably don't know these exist. Add some information about React
dev mode as well as a link to the developer tools when using Chrome.
2014-01-10 21:10:54 -08:00
Tim Yung
bcacd17f8b
Better LinkedValueMixin Warning
...
Input elements of type `checkbox`, `hidden`, or `radio` can have a `value` without `onChange`. Also, if the input is `disabled`, who cares that it doesn't have an `onChange`?
2014-01-10 21:10:01 -08:00
Tim Yung
f71dbab31a
Fix Undefined ownerDocument Fatal in IE8
...
This fixes a JS fatal in IE8 when `topLevelTarget.ownerDocument` is sometimes undefined.
2014-01-10 21:07:23 -08:00
Tim Yung
73d9d286ee
Fix EnterLeaveEventPlugin Test in jsdom
...
This is a follow-up to #803 .
In jsdom (used for internal testing), `<iframe>` does not properly create a default document. This makes the `EnterLeaveEventPlugin` tests work for jsdom, too.
Open source does not need this because it uses PhantomJS.
2014-01-10 21:04:39 -08:00
Paul O’Shannessy
49d6d2169d
Remove trailing whitespace
2014-01-10 21:04:39 -08:00
Ben Alpert
1efb14bcf6
Rewrite mergeKeySets to be O(n) instead of O(n^3)
2014-01-10 15:31:15 -08:00
Andrew Davey
d6afb5285e
CSS column-count property is unitless
2014-01-10 19:12:58 +00:00
Pete Hunt
979ee27e2b
Merge pull request #862 from cpojer/docs-proptypes
...
Document PropTypes.renderable and PropTypes.component
2014-01-10 09:55:19 -08:00
cpojer
d73f80ecb2
Document PropTypes.renderable and PropTypes.component
2014-01-10 09:36:22 -08:00
Andrew Davey
423380f9c3
Unitless CSS flex properties
2014-01-10 11:16:06 +00:00
Andrew Davey
b70c3ef4bb
Refactor unit test
2014-01-10 11:16:06 +00:00
Andrew Davey
ac0373ccae
More unitless CSS properties
...
volume, stress, pitch-range, richness
2014-01-10 11:16:06 +00:00
Andrew Davey
095eea3241
CSS widows property is unitless
...
Ref #836
2014-01-10 11:16:05 +00:00
Timothy Yung
338ce603f9
Merge pull request #797 from spicyj/should-update
...
Fix cases where owner warning is shown
2014-01-09 18:50:21 -08:00
cpojer
95cb79a93e
Remove CallbackRegistry
2014-01-09 16:58:48 -08:00
cpojer
b713c2c696
Add PropTypes.component to demand a single React component.
2014-01-09 16:58:47 -08:00
Ben Alpert
f5a48f1ff4
Fix cases where owner warning is shown
...
In b0431a5 I added the check in the wrong place which could cause the warning to be shown because of key changes rather than owner changes like the warning suggests.
2014-01-09 16:48:58 -08:00
Timothy Yung
f47238be41
Merge pull request #803 from spicyj/gh-788
...
Use proper window object for iframe in enter/leave
2014-01-09 16:35:07 -08:00
Timothy Yung
851f08bdc2
Merge pull request #780 from syranide/newhasevent
...
Further cleanup of isEventSupported
2014-01-09 16:34:57 -08:00
Timothy Yung
68bac7fbf0
Merge pull request #778 from syranide/flipwheel
...
Fix WheelEvent incorrectly flipping sign of deltaY
2014-01-09 16:34:47 -08:00
Timothy Yung
dea6063dc9
Merge pull request #771 from spicyj/gh-694
...
Don't get selection if no active element
2014-01-09 16:34:27 -08:00
cpojer
8dbc530d1c
Add --harmony option to jsx.
2014-01-09 15:21:48 -08:00
Paul O’Shannessy
1f5c8d21d8
Merge pull request #786 from spicyj/gh-781
...
Fix potential memory leak when unmounting
2014-01-09 13:08:07 -08:00
Timothy Yung
2c93cd0267
Merge pull request #640 from spicyj/immutable-props-2
...
Don't mutate passed-in props, take 2
2014-01-09 12:52:58 -08:00
Christopher Chedeau
e3e3b477d3
Merge pull request #850 from spicyj/docs-ref-unmount
...
Document return value of unmountComponentAtNode
2014-01-09 09:21:39 -08:00
Ben Alpert
4d3a9c87d1
Don't store mount image on component instance
2014-01-08 22:53:59 -08:00
Ben Alpert
87a95155be
Document return value of unmountComponentAtNode
2014-01-08 21:56:59 -08:00
Cheng Lou
3c40fb2e01
better error message for mergeHelpers and setState
2014-01-08 21:56:48 -08:00
Ben Alpert
2716f38861
Spy on purgeID instead of unmountIDFromEnvironment
2014-01-08 21:48:48 -08:00
Ben Alpert
e2f094614f
Fix potential memory leak when unmounting
...
Fixes #781 .
2014-01-08 21:43:52 -08:00
Paul O’Shannessy
09011493c5
Merge pull request #718 from syranide/npmenvify
...
Fix npm react having wrong version dependency for envify
2014-01-08 15:33:59 -08:00
Paul O’Shannessy
0c3628cd8d
Merge pull request #757 from spicyj/ng
...
Don't tack on EventPluginHub globally
2014-01-08 15:23:47 -08:00
Ben Alpert
1db788b62c
Don't tack on EventPluginHub globally
2014-01-08 15:20:05 -08:00
Christopher Chedeau
2052caf0cc
Merge pull request #846 from spicyj/docs-nomin
...
Remove two more react.min.js references
2014-01-08 11:45:25 -08:00
Ben Alpert
76a0a9cba7
Remove two more react.min.js references
2014-01-08 11:40:53 -08:00
Paul O’Shannessy
46f7163f62
Don't use the min build in getting started guide
2014-01-08 11:38:34 -08:00
Paul O’Shannessy
8d0885e0d8
Merge pull request #844 from xixixao/patch-1
...
Fix URL in displayName description
2014-01-08 11:24:55 -08:00
Michal Srb
b4f4f10478
Fix URL in displayName description
2014-01-08 14:55:27 +01:00
Paul O'Shannessy
23ab30ff87
Revert textContent
...
Reverts 309a88bcf6 because this is causing
issues internally. I'll try to get a repro soon.
2014-01-07 21:10:03 -08:00
Pete Hunt
b1597ab2d7
Warn for common forms misuse
2014-01-07 21:08:13 -08:00
Paul O’Shannessy
be42d94f12
Don't set max_line_length for *.md
2014-01-07 20:46:46 -08:00
Jeff Morrison
33fe8eebda
Merge pull request #799 from spicyj/display-name
...
Add display name in more cases
2014-01-07 12:58:23 -08:00
Ben Alpert
f0fdabae7b
Add display name in more cases
2014-01-07 09:36:47 -08:00
Ben Alpert
a2ecee5353
Use proper window object for iframe in enter/leave
...
Fixes #788 .
2014-01-07 08:36:42 -08:00
Ben Alpert
657602135c
Don't mutate passed-in props, take 2
2014-01-06 21:42:04 -08:00
Ben Newman
4f57515f91
Fix some odd spacing inconsistencies in ReactRenderDocument-test.
2014-01-06 21:13:25 -08:00
Sebastian Markbåge
59bd45d594
Merge pull request #772 from spicyj/gh-444
...
Set event type on enter/leave events
2014-01-06 20:10:26 -08:00
Sebastian Markbåge
c28e1f24df
Merge pull request #768 from spicyj/findcomponentroot-err
...
Remove sometimes-confusing console error
2014-01-06 18:57:18 -08:00
Tom Occhino
ba6c82a326
Merge pull request #829 from spicyj/transitiongroup-null-child
...
Make ReactTransitionGroup work with a null child
2014-01-06 18:40:35 -08:00
Timothy Yung
e23c06a60c
Merge pull request #773 from spicyj/select-event-ff
...
Check for selection on keyup instead of deferring
2014-01-06 18:40:20 -08:00
Pete Hunt
70a0746e9f
Fix react tests
2014-01-06 18:35:54 -08:00
Pete Hunt
1e980a146f
Fix bug in cloneWithProps()
2014-01-06 18:35:54 -08:00
Pete Hunt
57f208e402
Merge pull request #821 from subtleGradient/subtlegradient/perf-task
...
benchmark runner & comparison tool with grunt commands and travis integration
2014-01-06 18:32:51 -08:00
Paul O’Shannessy
f9551d709e
Merge pull request #808 from spicyj/prefer-textContent
...
Prefer textContent to innerText
2014-01-06 18:08:38 -08:00
Ben Alpert
c75899f277
Make ReactTransitionGroup work with a null child
2014-01-06 17:40:50 -08:00
Ben Alpert
09c8ec51bf
Check for selection on keyup instead of deferring
...
This is essentially what we do for the change event in IE8 and IE9 already.
2014-01-06 16:37:27 -08:00
Paul O’Shannessy
6fdf36af13
Merge pull request #827 from spicyj/jstransform-202
...
Bump jstransform version to 2.0.2
2014-01-06 16:26:42 -08:00
Ben Alpert
5968571952
Bump jstransform version to 2.0.2
...
Necessary for JSXTransformer.js to work after 7675611 .
2014-01-06 16:25:05 -08:00
Christopher Chedeau
e9484adf65
Merge pull request #774 from spicyj/img-onload
...
Add support for onLoad event to <img />
2014-01-06 16:24:25 -08:00
Ben Alpert
fb858a8fc2
Set event type on enter/leave events
...
Fixes #444 .
2014-01-06 16:21:46 -08:00
Sebastian Markbåge
4f09a54a1d
Merge pull request #741 from spicyj/flatten-nonull
...
Don't return null children from flattenChildren
2014-01-06 16:21:34 -08:00
Timothy Yung
8f2509e169
Merge pull request #789 from spicyj/gh-785
...
Set target properties explicitly for enter/leave
2014-01-06 16:16:35 -08:00
Ben Alpert
79c9025f17
Add support for onLoad event to <img />
2014-01-06 16:16:21 -08:00
Christopher Chedeau
9454282bfc
Merge pull request #819 from mtharrison/add-more-svg-tags
...
Added support for 4 extra SVG tags
2014-01-06 15:44:15 -08:00
Paul O’Shannessy
147506a911
Merge pull request #826 from spicyj/invariant-license
...
Add back license header to invariant
2014-01-06 15:36:37 -08:00
Ben Newman
b7b4bcfd2e
Merge pull request #764 from spicyj/browser-source-maps
...
Add source map support to browser transformer.
2014-01-06 14:38:00 -08:00
Ben Alpert
808f60f8a0
Add back license header to invariant
2014-01-06 14:19:23 -08:00
Matt Harrison
bd575eb7c8
Updated getMarkupWrap.js to include the new SVG elements
2014-01-06 21:48:40 +00:00
Paul O’Shannessy
c2be8ba42d
Sync vendored modules from upstream
2014-01-06 11:55:37 -08:00
Timothy Yung
627d7eb669
Merge pull request #754 from spicyj/over-and-out
...
Add onMouseOver and onMouseOut events
2014-01-06 10:28:54 -08:00
Tim Yung
182a237fa7
Separate Module for Key Normalization
...
This moves key normalization into its own module so that it can be re-used elsewhere.
2014-01-06 10:07:49 -08:00
Christoph Pojer
22ba8b67f1
Silence console.error in ReactDOMInput-test
...
This test is expected to throw but because of ReactErrorUtils.guard
which uses console.error in __DEV__ it also logged the invariant error
to the console. This change fixes it by temporarily stubbing out
console.error.
Fixes #531
2014-01-06 10:07:49 -08:00
Tim Yung
e65726cd04
Cleanup ReactEventEmitter Variable Naming
...
Minor follow-up to 80d7d2d0f8 .
2014-01-06 10:07:49 -08:00
Isaac Salier-Hellendag
1584aaf746
Change global to window in SyntheticClipboardEvent
...
Replace `global` reference with `window` in `SyntheticClipboardEvent`.
2014-01-06 10:07:49 -08:00
Pete Hunt
089a494a1f
Forbid full-page rendering without server rendering
...
Final part of server rendering cleanup. We should only support full-page rendering when server rendering is involved since
otherwise it's slow and can crash browsers when you start adding and removing document roots. This diff removes the magic
innerHTML code (since that will be handled by the server rendering piece) and adds the right assertions and errors.
Because there's no longer a dangerous of accidentally nuking the whole page, I removed allowFullPageRender which is yet another
internal we no longer need to expose.
2014-01-06 10:07:48 -08:00
Pete Hunt
9b3342ed34
Throw when unmounting <html>, <head>, <title> or <body>
...
These are dangerous from a cross-browser perspective. I think supporting efficient reactive updates will be prohibitively
expensive and we'll never prioritize it. Instead of killing this capability entirely, let's just throw on the dangerous cases.
There will be a few follow-up diffs
2014-01-06 10:07:48 -08:00
Christopher Chedeau
7630e56971
Merge pull request #804 from spicyj/examples-no-browserify
...
Remove mentions of browserify in examples
2014-01-06 10:03:10 -08:00
Christopher Chedeau
9cce0c2752
Merge pull request #823 from spicyj/key-docs
...
Add charCode/keyCode/which to key event docs
2014-01-06 09:40:18 -08:00
Thomas Aylott
91821007ed
benchmark runner
2014-01-06 12:26:40 -05:00
Christopher Chedeau
6dd62b0e4f
Merge pull request #688 from vjeux/community_14
...
Community Round-up #14
2014-01-06 09:11:09 -08:00
Matt Harrison
42262f5361
Aphabetized and wrapped tags/attributes docs
2014-01-06 08:15:46 +00:00
Timothy Yung
2c1a25411f
Merge pull request #747 from spicyj/currentTarget
...
Set currentTarget on synthetic events
2014-01-05 20:41:48 -08:00
Timothy Yung
13230a3044
Merge pull request #643 from spicyj/scroll-pos
...
Fix scrollLeft/scrollTop warning in latest Chrome
2014-01-05 20:41:35 -08:00
Ben Alpert
b366e36367
Add charCode/keyCode/which to key event docs
2014-01-05 21:24:17 -07:00
Christopher Chedeau
ed3d5add76
Merge pull request #809 from passy/patch-1
...
Add gulp-react to Helpful OSS Projects
2014-01-05 18:16:20 -08:00
Christopher Chedeau
0e5b62a4c3
Merge pull request #818 from Daniel15/link-htmltojsx
...
Add link to HTML to JSX converter to “JSX In Depth” page
2014-01-05 18:16:06 -08:00
Cheng Lou
5b43a2e6d7
throw error when setState's arguments are bad
2014-01-05 18:01:07 -08:00
Matt Harrison
c01f0a0487
Updated docs with new SVG elements
2014-01-05 12:18:30 +00:00
Matt Harrison
c4d918aca0
Added support for 4 extra SVG tags: stop, defs, linearGradient, radialGradient
2014-01-05 11:17:04 +00:00
Daniel Lo Nigro
ae9188db50
Change “not allowed” back to “discouraged” since you technically *can* use props called class or for…
2014-01-04 23:33:02 -08:00
Daniel Lo Nigro
202a3f184d
Add link to HTML to JSX converter to “JSX In Depth” page
2014-01-04 23:25:28 -08:00
Christopher Chedeau
605b42e622
Merge pull request #811 from xixixao/issue793
...
Document displayName
2014-01-04 10:41:56 -08:00
xixixao
ee0a4acfac
Document displayName
2014-01-04 17:34:16 +01:00
Pascal Hartig
e92d769a50
Add gulp-react to Helpful OSS Projects
...
Add @sindresorhus' JSX task for Gulp to the "Helpful Open-Source Projects" section of the tooling integration docs.
2014-01-04 11:20:45 +01:00
Ben Alpert
33dcf8a0b5
Set currentTarget on synthetic events
...
Fixes #658 , fixes #659 .
2014-01-04 00:27:11 -07:00
SanderSpies
80d7d2d0f8
Listen to events on demand
...
Fixes #381
This is a squashed version of https://github.com/facebook/react/pull/462
2014-01-03 23:09:59 -08:00
Ben Alpert
309a88bcf6
Prefer textContent to innerText
...
Fixes #807 .
2014-01-04 00:01:03 -07:00
Pete Hunt
a575e93ecd
Merge pull request #806 from spicyj/patch-4
...
Fix typo
2014-01-03 22:19:35 -08:00
Ben Alpert
ea40a6aedd
Fix typo
2014-01-03 23:19:04 -07:00
Pete Hunt
047e962a55
Merge pull request #805 from spicyj/docs-mention-react-art
...
Mention react-art where we talk about SVG
2014-01-03 22:17:51 -08:00
Ben Alpert
fdfd7c1853
Mention react-art where we talk about SVG
2014-01-03 23:15:50 -07:00
Ben Alpert
be75e3be66
Remove mentions of browserify in examples
2014-01-03 22:58:51 -07:00
Timothy Yung
c11d6d79f5
Merge pull request #721 from spicyj/change-bubble-ie
...
Make controlled components and bubbling work in IE
2014-01-03 18:10:16 -08:00
Nick Thompson
d270e2b1c7
Don't add displayName in transform if already defined
...
This ensures we don't add displayName in the transform if it's already been
defined. This is especially important when in strict mode, where duplicate
properties in an object is an exception.
2014-01-03 16:07:10 -08:00
Christopher Chedeau
e3e24500ae
Merge pull request #795 from philix/master
...
Add jsx-requirejs-plugin to the tooling-integration page
2014-01-03 11:09:59 -08:00
Felipe Oliveira Carvalho
86f2dbe55d
Remove the require-jsx plugin from the tooling-integration page
...
In favor of the r.js friendly jsx-requirejs-plugin
2014-01-03 16:03:42 -03:00
Felipe Oliveira Carvalho
344b5998a8
Add jsx-requirejs-plugin to the tooling-integration page
2014-01-03 15:45:03 -03:00
Andreas Svensson
4de2d39f63
Fix WheelEvent incorrectly inverting sign of deltaY
2014-01-03 19:09:09 +01:00
Andreas Svensson
7264cbcdfb
Further cleanup of isEventSupported
2014-01-03 19:02:20 +01:00
Jeff Morrison
1b67ac90f2
Make sure the mock is cleared in the EventEmitter test
2014-01-02 20:09:50 -08:00
Isaac Salier-Hellendag
29190a2c79
Support clipboardData in IE
...
Use the `clipboardData` object available on `window`, if it's not available on the event object. This allows us to support including the `clipboardData` in cut/copy/paste events in IE.
2014-01-02 20:05:07 -08:00
Christoph Pojer
bcfb476366
More tests for 77697f26e3
2014-01-02 20:05:03 -08:00
Ben Newman
1ee7f8131c
Let components specify tag for ReactTestUtils.mockComponent to use.
...
If you're writing a test that involves a mocked component that normally
returns a `<li>` tag from its `render` method as the root element, mocking
it with a dummy `<div>` probably won't work, so you'll want to set
MyListItemComponent.mockTagName = 'li';
The change to the `.mockImplementation` line makes sense because
`ConvenienceConstructor` is more or less synonymous (for these purposes)
with the wrapper that was previously used:
function() {
// This `this` used to be `null`, technically, but
// ConvenienceConstructor doesn't pay attention to `this` anyway.
return ConvenienceConstructor.apply(this, arguments);
}
2014-01-02 20:03:55 -08:00
Ben Newman
a00e4c840c
Support ReactTestUtils.mockComponent.
2014-01-02 20:03:40 -08:00
Sebastian Markbage
cbefc5a968
Add display names to controlled components
...
These show up as Unknown in the DevTools. They also wrap a native component,
so they show up double.
2014-01-02 20:03:26 -08:00
Fabio Costa
f3e774559f
adding warning about the lack of support for onScroll on IE8
...
Adding `console.warn` about the lack of support for `onScroll` event on IE8
Related to this issue on github https://github.com/facebook/react/issues/631
2014-01-02 20:01:33 -08:00
Pete Hunt
1733d42ded
Rework ReactRootIndex generation
...
This had a higher probability of collision than originally thought (bad math). This makes the strategy injectable and provies a
no-collision version on the client and an unlikely-to-collide version on the server.
2014-01-02 20:00:30 -08:00
Pete Hunt
cc005668b5
cloneWithProps()
...
what if you want to change the props of a child? This is my first attempt which lets you clone a child and transfer some custom props to it.
There is a fundamental issue with refs here. Since the component is cloned the ref will be broken. And since we can clone multiple times, it might not make sense to support repairing refs.
2014-01-02 19:46:50 -08:00
Pete Hunt
5661d5168e
Add svg polygon
2014-01-02 19:45:55 -08:00
Ben Alpert
fb8277c819
Set target properties explicitly for enter/leave
...
Fixes #785 .
2014-01-02 17:03:11 -07:00
Ben Newman
5aae5a7b1d
Merge pull request #783 from benjamn/upgrade-commoner
...
Upgrade commoner build tool to v0.8.12.
2014-01-02 12:09:26 -08:00
Christopher Chedeau
acf0c5c646
Merge pull request #784 from vjeux/react_dev_tools
...
React Chrome Developer Tools
2014-01-02 12:04:53 -08:00
Vjeux
e915294b68
React Chrome Developer Tools
2014-01-02 21:04:09 +01:00
Ben Newman
1755d43add
Upgrade commoner build tool to v0.8.12.
...
Fixes #394 .
Fixes #615 .
2014-01-02 14:54:13 -05:00
Ben Newman
04ad3bfcc3
Merge pull request #725 from cpojer/getInitialState-invariant
...
Add invariant to check getInitialState return value. Fixes #397 .
2014-01-02 06:59:50 -08:00
Christopher Chedeau
a78f6f7f94
Merge pull request #779 from chenglou/live-err
...
docs better error display for live editor and JSX compiler
2014-01-01 19:58:26 -08:00
Cheng Lou
f0b5219df9
docs better error display for live editor and JSX compiler
2014-01-01 19:41:08 -05:00
Christopher Chedeau
3396654a6f
Merge pull request #775 from chenglou/doc-fix
...
docs tips fix small typo and code
2014-01-01 14:05:21 -08:00
Cheng Lou
e244df510d
docs tips fix small typo and code
2014-01-01 15:28:44 -05:00
Ben Alpert
7a9e5443b7
Don't get selection if no active element
...
Fixes #694 .
Previously, it could be that there was an active element that was removed in between mousedown and mouseup.
2013-12-31 17:27:05 -07:00
Ben Alpert
261926303d
Remove sometimes-confusing console error
...
Fixes #767 . This essentially reverts 738de8c .
We could store some sort of flag to silence the console error here but since we've made significant improvements in markup wrapping, this error is fairly rare now. We'll also have validation of node structure soon in #735 .
2013-12-31 13:37:15 -07:00
Christopher Chedeau
e91a8a1bc3
Merge pull request #765 from spicyj/editorconfig-80
...
.editorconfig: Set line length to 80
2013-12-31 12:22:14 -08:00
Ben Alpert
3defe88192
.editorconfig: Set line length to 80
...
And alphabetize properties.
2013-12-31 12:59:06 -07:00
Ben Alpert
7675611e5f
Add source map support to browser transformer
2013-12-31 12:03:34 -07:00
Pete Hunt
9a4f011f6c
Merge pull request #763 from spicyj/gh-762
...
Add info about dev vs. prod builds
2013-12-31 09:57:10 -08:00
Ben Alpert
c877451887
Add info about dev vs. prod builds
...
Also moved the dev builds first because that's what most people will want.
2013-12-31 10:35:49 -07:00
Christopher Chedeau
96782fc836
Merge pull request #755 from spicyj/cm-scroll
...
Upgrade codemirror and enable line wrapping
2013-12-30 20:56:59 -08:00
Christopher Chedeau
1155aa9ac0
Merge pull request #758 from chenglou/docs-kill-wiki
...
docs remove link to wiki page
2013-12-30 20:40:05 -08:00
Cheng Lou
41526091a0
docs remove link to wiki page
...
Also some minor writing changes.
2013-12-30 23:38:01 -05:00
Ben Alpert
b2e51c6e01
Upgrade codemirror and enable line wrapping
...
Fixes #678 .
2013-12-30 18:06:00 -07:00
Ben Alpert
a2e352ea76
Add onMouseOver and onMouseOut events
...
Fixes #340 .
Test Plan:
Ported @danielstocks's jsfiddle (linked in the issue) to React and the hover effect worked properly.
2013-12-30 17:38:15 -07:00
Christopher Chedeau
55b7a57e07
Merge pull request #753 from vjeux/virtual_dom_docs
...
Making 'native DOM' nodes more explicit in documentation
2013-12-30 16:37:51 -08:00
Vjeux
1d4d1a0be6
Making 'native DOM' nodes more explicit in documentation
2013-12-31 01:34:42 +01:00
Christopher Chedeau
7dca85a9b1
Merge pull request #752 from spicyj/docs-ie8-css
...
IE8 style fixes
2013-12-30 16:24:26 -08:00
Ben Alpert
1c90172cd0
IE8 style fixes
...
- Add html5shiv so that HTML5 elements like header, footer, etc can be styled
- Remove a couple uses of :first-child/:last-child which IE8 doesn't support
2013-12-30 17:17:17 -07:00
Christopher Chedeau
f871147b4d
Merge pull request #750 from chenglou/docs-clean
...
docs tips small refactorings
2013-12-30 15:12:43 -08:00
Cheng Lou
1671efb53a
docs tips small refactorings
2013-12-30 17:54:41 -05:00
Christopher Chedeau
8915f1b85d
Merge pull request #749 from spicyj/docs-ie8
...
Make React website work in IE8
2013-12-30 14:28:19 -08:00
Ben Alpert
92b440b1d7
Make React website work in IE8
...
Fixes #406 .
Empty conditional comment is for http://www.phpied.com/conditional-comments-block-downloads/ .
2013-12-30 15:25:26 -07:00
Christopher Chedeau
3b0f705658
Merge pull request #623 from chenglou/tips-communication
...
docs tips parent-child communication 2
2013-12-30 14:09:01 -08:00
Cheng Lou
23eac0bbbb
docs tips expose component function
2013-12-30 17:07:24 -05:00
Christopher Chedeau
50d190f111
Merge pull request #746 from petehunt/tip-update
...
Update parent/child communication tip
2013-12-30 10:23:19 -08:00
petehunt
47fe931549
Update parent/child communication tip
2013-12-30 13:22:10 -05:00
Paul O’Shannessy
b3e1697aad
Merge pull request #739 from jhiswin/master
...
live_editor.js using deprecated function
Fixes #738 #666
2013-12-30 10:04:51 -08:00
Christopher Chedeau
4190d0a7bb
Merge pull request #687 from vjeux/community_13
...
Community Round-up #13
2013-12-30 09:28:13 -08:00
Vjeux
40e2d8a064
Community Round-up #13
2013-12-30 18:27:31 +01:00
Ben Alpert
e1ec9a6c65
Don't return null children from flattenChildren
...
This simplifies ReactMultiChild a little bit and will make it more practical to coalesce adjacent text strings.
2013-12-29 12:19:10 -07:00
jhiswin
e2ebbeac07
live_editor.js using deprecated function
...
unmountAndReleaseReactRootNode -> unmountComponentAtNode
breaks html-jsx.html
2013-12-29 09:42:35 -05:00
Pete Hunt
eab2ededdf
Merge pull request #736 from spicyj/minify-before-browserify
...
Minify both before and after browserify
2013-12-28 23:17:52 -08:00
Pete Hunt
7e29f4607b
Merge pull request #737 from spicyj/docs-ajax-state
...
Move initial $.ajax out of getInitialState
2013-12-28 23:17:34 -08:00
Ben Alpert
cce91611aa
Move initial $.ajax out of getInitialState
...
We want to encourage people to make pure getInitialState functions.
2013-12-29 00:14:05 -07:00
Ben Alpert
76c9d8465e
Switch to using uglifyify
2013-12-29 00:03:26 -07:00
Ben Alpert
abee8b0476
Minify both before and after browserify
2013-12-28 23:41:54 -07:00
Pete Hunt
82c4e897dc
Merge pull request #733 from ivan/master
...
Use explicit $.ajax dataType and add error callback
2013-12-28 22:15:08 -08:00
Ivan Kozik
17f14d523b
console.log -> console.error
2013-12-29 06:12:45 +00:00
Pete Hunt
f5f464b16a
Merge pull request #734 from ivan/tut-jsx-header
...
Tell user to keep the @jsx declaration at the top of the script
2013-12-28 22:08:19 -08:00
Ivan Kozik
0647c2ee98
Add a warning about the @jsx declaration
2013-12-29 05:51:07 +00:00
Ivan Kozik
f03d6e212a
Use explicit $.ajax dataType and add error callback
2013-12-29 05:32:46 +00:00
Pete Hunt
918c5134e1
Merge pull request #732 from chenglou/doc-pragma
...
docs add warning to add jsx pragma
2013-12-28 20:05:33 -08:00
Cheng Lou
8f5ef0fdf2
docs add warning to add jsx pragma
2013-12-28 23:04:34 -05:00
Christopher Chedeau
84cacaf5b6
Merge pull request #717 from syranide/testkeytransfer
...
Add unit test for transferPropsTo, "key" should never transfer
2013-12-27 18:54:56 -08:00
Christopher Chedeau
72fd24662e
Merge pull request #716 from bitshadow/hotfix
...
Issue #383 : Error message for using refs outside of render() is difficult to underst...
2013-12-27 18:53:36 -08:00
Christopher Chedeau
fdf64919f3
Merge pull request #730 from syranide/lint80
...
Added max line length = 80 for jshint
2013-12-27 17:59:45 -08:00
Christopher Chedeau
ff9ca2ecb2
Merge pull request #700 from syranide/100%autofocus
...
Patch missing autoFocus-support in older browsers
2013-12-27 17:47:24 -08:00
Christopher Chedeau
f627bc52b0
Merge pull request #714 from syranide/escapekey
...
Escape component keys used in reactid
2013-12-27 17:14:16 -08:00
Christopher Chedeau
9f10bb4aca
Merge pull request #729 from syranide/dragevent
...
Add SyntheticDragEvent with "dataTransfer" property
2013-12-27 17:12:00 -08:00
Andreas Svensson
a6b888b214
Escape component keys used in reactid
2013-12-28 01:58:59 +01:00
Andreas Svensson
cbd6d8a46c
Added max line length = 80 for jshint
2013-12-28 01:49:04 +01:00
Andreas Svensson
01b4b23118
Polyfill/normalize autoFocus across all browsers
2013-12-27 22:44:43 +01:00
Andreas Svensson
9e6456ba41
Add SyntheticDragEvent with "dataTransfer" property
2013-12-27 21:01:30 +01:00
Pete Hunt
a4bb44f1e2
Merge pull request #728 from spicyj/gh-724
...
Allow changing transitionLeave from false to true
2013-12-27 10:59:22 -08:00
Pete Hunt
fac676073a
Merge pull request #722 from wincent/typo-fix-01
...
Fix a typo in the working-with-the-browser docs
2013-12-27 10:09:02 -08:00
Ben Alpert
5e6e332d67
Allow changing transitionLeave from false to true
...
Fixes #724 .
2013-12-27 10:22:48 -07:00
cpojer
77697f26e3
Add invariant to check getInitialState return value. Fixes #397
2013-12-27 16:36:08 +01:00
Wincent Colaiuta
79b00591f1
Fix a typo in the working-with-the-browser docs
2013-12-26 22:22:00 -08:00
Ben Alpert
556065937b
Make controlled components and bubbling work in IE
...
Fixes #708 .
Test Plan:
In IE9, tested a controlled text input with the event handler on a containing element, as in the fiddle linked in the original issue. Also tested a controlled radio button as the logic there differs within ReactDOMInput. In both cases, I was able to interact with the controls.
2013-12-26 23:06:40 -07:00
Andreas Svensson
411f0bd7c3
Fix npm react having wrong version dependency for envify
2013-12-26 18:12:23 +01:00
Paul O’Shannessy
f877c6224f
Merge pull request #695 from luigy/patch-1
...
Fix "Dynamic Children" example
2013-12-26 09:04:21 -08:00
Andreas Svensson
f9947dec2a
Add unit test for transferPropsTo, "key" should never transfer
2013-12-26 16:42:39 +01:00
Jignesh Kakadiya
e35f4c29bb
fix params
2013-12-26 12:29:01 +05:30
Jignesh Kakadiya
ecf9f8ef6d
Adjust params
2013-12-26 12:17:36 +05:30
Jignesh Kakadiya
2b0dc71e3d
Error message for using refs outside of render() is difficult to understand
2013-12-26 12:00:19 +05:30
Pete Hunt
cc229eb749
Merge pull request #591 from spicyj/mount-key
...
Respect 'key' prop for object identity
2013-12-25 22:15:13 -08:00
Ben Alpert
633125fd0d
Use innerHTML not innerText in test
2013-12-25 22:47:10 -07:00
Ben Alpert
30f566392b
Extract out wrapUserProvidedKey for clarity
2013-12-25 22:32:43 -07:00
Ben Alpert
6fae670d19
Make shouldUpdateReactComponent key logic clearer
...
...and inline getComponentKey into traverseAllChildren.js.
2013-12-25 22:25:20 -07:00
Ben Alpert
b0431a51ca
Respect 'key' prop for object identity
...
Now when a `key` prop appears, its value is always honored. This means that in the root component or as an only child, changing key will cause remounting; in a `children` object, the `key` prop will be joined with the object key to form a two-part key.
Fixes #590 .
2013-12-25 22:24:10 -07:00
Christopher Chedeau
02e47ebd00
Merge pull request #713 from syranide/nokeytransfer
...
transferPropsTo should never transfer the "key" property
2013-12-25 20:46:30 -08:00
Andreas Svensson
374c9ba658
transferPropsTo should never transfer the key property
2013-12-26 00:12:22 +01:00
Pete Hunt
adff7c0238
Update README.md
2013-12-24 02:21:06 -05:00
Christopher Chedeau
7e0c6bc952
Merge pull request #705 from chenglou/rm-vid
...
docs remove video at the bottom
2013-12-23 22:44:00 -08:00
Cheng Lou
0519734ea5
docs remove video at the bottom
2013-12-24 01:42:45 -05:00
Pete Hunt
b385b580a6
Merge pull request #704 from vjeux/talks_doc
...
Add a talks section to the docs
2013-12-23 22:21:56 -08:00
Vjeux
91780d1c58
Add a talks section to the docs
2013-12-24 07:20:42 +01:00
Christopher Chedeau
a6d8c00b1a
Merge pull request #702 from syranide/lessmice
...
Removed unnecessary cleanup in isEventSupported
2013-12-23 19:30:16 -08:00
Pete Hunt
1070d12732
Merge pull request #701 from fabiomcosta/react-video-version-note
...
Note about react's version on the video talk
2013-12-23 16:54:33 -08:00
Pete Hunt
a8216e78b1
Merge pull request #703 from fabiomcosta/onscroll-doc-ie8-note
...
Adding note about onScroll on IE8
2013-12-23 16:46:52 -08:00
Fabio M. Costa
c211767d47
language update as suggested by @petehunt
2013-12-23 16:45:44 -08:00
Fabio M. Costa
34660eccf9
updating text as suggested by @petehunt
2013-12-23 16:41:41 -08:00
Fabio M. Costa
874122bad4
Adding note about onScroll on IE8
2013-12-23 16:40:41 -08:00
Andreas Svensson
63ca84e5af
Removed unnecessary cleanup in isEventSupported
2013-12-24 01:02:24 +01:00
Fabio M. Costa
d22874d039
Note about react's version on the talk, since somethings have already changed since then
2013-12-23 15:37:06 -08:00
Pete Hunt
128a35dff9
Merge pull request #642 from Cartas/master
...
ReactTransitionGroup can handle components being re-added before 'leave' transition has completed.
2013-12-23 15:36:28 -08:00
Timothy Yung
9e0987cd9b
Merge pull request #607 from syranide/html5key
...
Polyfill and normalize HTML5 "key", deprecates which and keyCode
2013-12-23 11:11:12 -08:00
Ben Newman
82a26ada65
Merge pull request #684 from syranide/ie8dangerousinnerhtml
...
Use feature detection and more robust recovering of whitespace for innerHTML in IE8.
2013-12-23 11:07:51 -08:00
Christopher Chedeau
9fa759173e
Merge pull request #699 from vjeux/fix_typo
...
typo
2013-12-23 09:53:53 -08:00
Vjeux
a31a8c35c2
typo
2013-12-23 18:45:53 +01:00
Christopher Chedeau
47f24f26aa
Merge pull request #698 from vjeux/fix_compiler
...
Fix html-jsx compiler
2013-12-23 09:31:19 -08:00
Vjeux
6bd9f35bf3
Fix html-jsx compiler
...
It changed React Playground to add a required props but unfortunately didn't update the call sites of the front-page. I don't think it should be required so I'm just making it optional and providing the correct default value.
Test Plan:
- Open the front page and make sure examples are working
- Open /react/jsx-compiler.html and make sure it is working
- Open /react/html-jsx.html and make sure it is working
2013-12-23 18:24:22 +01:00
Christopher Chedeau
590a5498ab
Merge pull request #686 from vjeux/community_12
...
Community Round-up #12
2013-12-23 09:04:03 -08:00
Vjeux
d1e955c37b
Community Round-up #12
2013-12-23 18:03:42 +01:00
Paul O’Shannessy
1783e54eb0
Merge pull request #692 from loganfynne/master
...
Added property attribute to non-standard attributes
2013-12-22 21:30:03 -08:00
Christopher Chedeau
0bbf535b7b
Merge pull request #411 from vjeux/diff_algorithm
...
Document the Diff algorithm
2013-12-22 11:36:26 -08:00
Andreas Svensson
1f2d57d6a4
Use feature detection and more robust recovering of whitespace for innerHTML in IE8
2013-12-22 20:30:59 +01:00
Vjeux
59f72bd991
Document the Diff algorithm
...
We often refer to it but never did actually explain it.
2013-12-22 20:09:02 +01:00
Ben Newman
9f3c4da588
Merge pull request #662 from benjamn/replace-envify
...
Upgrade envify to a version that uses recast.
2013-12-22 09:39:02 -08:00
Ben Newman
9da3f92853
Upgrade envify dependency to v1.0.1.
...
This version uses Recast for source transformation:
https://github.com/hughsk/envify/pull/4
2013-12-22 11:58:56 -05:00
Luigy Leon
814faed08f
Fix "Dynamic Children" example
2013-12-22 10:37:09 -05:00
Pete Hunt
c7fbaa4966
Merge pull request #691 from Daniel15/hackathon40-htmltojsx-master
...
Simple HTML to JSX converter
2013-12-22 00:07:15 -08:00
Logan Allen
ab88dd19d3
Added property to non-standard attributes
...
Fixes issue #655
2013-12-21 22:24:31 -05:00
Daniel Lo Nigro
eab1f4d366
Simple HTML to JSX converter, built during Hackathon 40 at Facebook.
...
See /react/html-jsx.html. Not directly linked from the site yet as there may still be some minor issues with it.
2013-12-21 17:44:38 -08:00
Vjeux
c7c72d1a7a
Community Round-up #14
2013-12-21 20:48:28 +01:00
Mouad Debbar
d914522ae4
A new prop type for React Components
...
Since we can use props to pass React Components, we should have a better way of validating these props than just `object`. Having a prop type `component` will allow us to safely assume that the passed prop IS a component.
2013-12-20 18:13:21 -08:00
Tim Yung
3431e3f847
Add createMarkupForID
...
This is a follow-up the to previous commit and does two things:
- Moves `ReactMount.ATTR_NAME` to `DOMProperty.ID_ATTRIBUTE_NAME`.
- Adds `DOMPropertyOperations.createMarkupForID` and uses it.
2013-12-20 18:12:48 -08:00
Tim Yung
9d119577ea
Consolidate ID Attribute Markup Generation
...
We have this really nice method for safely creating markup for an HTML
attribute, `DOMPropertyOperations.createMarkupForProperty(...)`. Let's
use it to create the ID attribute markup, too.
2013-12-20 18:12:37 -08:00
Paul O’Shannessy
65e0970c41
Merge pull request #673 from quark-zju/fix-select-multiple
...
Some options cannot be selected alone in <select multiple />
2013-12-20 16:24:37 -08:00
Keito Uchiyama
03ab108a77
Change my canonical e-mail address in .mailmap
2013-12-20 13:59:53 -08:00
Jun, WU
3c5710193c
Fix a perf issue of <select multiple />
...
`indexOf` was used inside a loop. Use an object and
`hasOwnProperty` instead.
2013-12-21 01:04:31 +08:00
WU Jun
9a4a8aa71a
Do not automatically select other options
...
For <select multiple />, `value` is an array and should not be
converted to a string.
2013-12-21 01:04:31 +08:00
Cheng Lou
30672654c5
docs make all link start with /react/docs
2013-12-19 17:15:01 -05:00
Paul O’Shannessy
039124bd07
0.8 starter kit
2013-12-19 13:21:27 -08:00
Paul O’Shannessy
5c9f96d12f
v0.8 blog post
2013-12-19 13:21:27 -08:00
Paul O’Shannessy
2595cbc676
Update materials for 0.8.0
2013-12-19 13:21:27 -08:00
Paul O’Shannessy
6a8542a6e9
Fix npm-react build task, add to release
2013-12-19 13:21:27 -08:00
Paul O’Shannessy
a1699bdb88
Update AUTHORS for 0.8
2013-12-19 13:21:27 -08:00
Paul O’Shannessy
a4595f0b32
Add newest starter-kit downloads to docs
2013-12-18 16:51:23 -08:00
Paul O’Shannessy
c0c5cb8e2c
Changelog, blog post for 0.5.2, 0.4.2
2013-12-18 16:45:17 -08:00
Paul O’Shannessy
aabfe79442
Update readme for 0.5.2
2013-12-18 16:45:17 -08:00
Paul O’Shannessy
01c4a706a3
Add starter-kit zip files to repo
...
These should be included so that anybody can build and update the docs
with as little confusion as possible.
I've left the directory in .gitignore so additions need to be
intentional as part of a release.
2013-12-17 22:02:31 -08:00
Pete Hunt
9a049d9774
Merge pull request #675 from chenglou/special-attrs
...
docs section for non-dom attributes and more in dom differences
2013-12-17 21:51:21 -08:00
Cheng Lou
47f2cacc6b
docs add input attrs for Dom Differences
2013-12-18 00:46:59 -05:00
Cheng Lou
be17771270
docs section for non-dom attributes
...
Also added documentation for `dangerouslySetInnerHTML`.
2013-12-18 00:31:17 -05:00
Pete Hunt
294bac537d
Merge pull request #668 from nicholasbs/fix-docs-typo
...
Fix typos
2013-12-17 18:39:14 -08:00
Pete Hunt
b7feb6f6eb
Merge pull request #650 from jaredly/patch-1
...
rename this tip to be less confusing
2013-12-17 18:22:34 -08:00
Pete Hunt
20d736db4c
Merge pull request #674 from squidsoup/tutorial-jquery-src
...
Documentation (minor): template missing jquery reference
2013-12-17 18:21:53 -08:00
Kit Randel
08babd2541
Tutorial template markup needs a reference to jquery for the ajax calls
...
from step 13 onwards.
2013-12-18 15:13:45 +13:00
Tim Yung
41230ef5dd
A new helper for tests: createHierarchyRenderer
...
We aren't using this in any of the React tests, but we've found it
useful testing product code.
2013-12-17 18:07:53 -08:00
Jared Forsyth
e539c8c6c4
one liner
2013-12-17 17:12:21 -07:00
Jared Forsyth
bf6951687d
changes as requested
2013-12-17 17:10:02 -07:00
Jared Forsyth
b5cfc72870
adding note about initializing state w/ props
2013-12-17 16:16:50 -07:00
Ben Newman
0bf9910ae9
Merge pull request #672 from benjamn/upgrade-populist
...
Upgrade populist dependency to v0.1.6.
2013-12-17 13:49:51 -08:00
Ben Newman
b805eff032
Upgrade populist dependency to v0.1.6.
...
This reduces the time taken by `grunt populist:test` from 7s to 550ms,
which should make @spicyj especially happy.
Relevant commits from the `populist` and `ast-types` repositories:
9863ad16c0
dabef2a4ac
2013-12-17 16:26:51 -05:00
Ben Newman
df3bd393eb
Merge pull request #661 from benjamn/upgrade-recast
...
Upgrade recast dev dependency to v0.5.6.
2013-12-17 11:54:27 -08:00
Ben Newman
f3a6775098
Upgrade recast dev dependency to v0.5.6.
...
Paving the way for source maps.
2013-12-17 14:50:36 -05:00
Paul O’Shannessy
c215bc3cd4
Update npm-react readme to point to autoflow
2013-12-17 11:21:08 -08:00
Paul O’Shannessy
adfb5f1eae
Update npm-react error to point to autoflow
2013-12-17 11:18:27 -08:00
Pete Hunt
d663d42d23
Merge pull request #670 from subtleGradient/subtlegradient/escape-the-things
...
the things, escape them
2013-12-17 09:03:01 -08:00
Thomas Aylott
7f3d4f0340
fixes ReactTextComponent rootID unescapedness
2013-12-17 05:07:49 -05:00
Thomas Aylott
346c8f5e6e
test case for ReactTextComponent rootID escaping
2013-12-17 05:05:28 -05:00
Nicholas Bergson-Shilcock
93eb6a5637
Fix typo in comments (ot -> to)
2013-12-15 12:12:38 -05:00
Nicholas Bergson-Shilcock
760cdd35c9
Fix typo (ot -> to)
2013-12-15 12:11:47 -05:00
Pete Hunt
3ad2938dfa
Merge pull request #657 from zpao/grunt-version-check-cleanup
...
Grunt version check cleanup
2013-12-15 01:45:30 -08:00
Paul O’Shannessy
5a5137ded4
Merge pull request #651 from fabiomcosta/patch-2
...
Improving never seen error message
2013-12-13 10:23:46 -08:00
Paul O’Shannessy
c2920ba84c
Merge pull request #653 from fabiomcosta/patch-3
...
match -> test
2013-12-12 15:33:31 -08:00
Fabio M. Costa
39037eedd1
URL -> url
2013-12-12 15:29:29 -08:00
Ben Newman
7c95194ec0
Merge pull request #637 from cpojer/use-rest-params
...
Use Rest Parameters where it makes sense
2013-12-12 14:53:50 -08:00
Paul O’Shannessy
8fda127748
Check src file for version-check task
...
This lets the task run stand-alone without building
2013-12-11 17:06:06 -08:00
Paul O’Shannessy
54bac2f07f
Move version-check task into own file
...
Gruntfile.js is really messy :(
2013-12-11 17:01:18 -08:00
Josh Duck
8b0af9b5de
Fix SelectEventPlugin
...
mouseup was not fired when context menu showed, so select events stopped being fired.
2013-12-11 13:46:11 -08:00
Tim Yung
02de96f012
Fix Merging propTypes, contextTypes, and childContextTypes
...
This fixes merging of `propTypes`, `contextTypes`, and `childContextTypes` so that we actually merge (instead of only taking the component or last mixin).
2013-12-11 13:45:55 -08:00
Ben Alpert
e92ce38cf1
Add loop property
2013-12-11 11:46:16 -08:00
cpojer
decb49a202
Use rest parameters whenever it makes sense.
2013-12-11 10:30:10 -08:00
Fabio M. Costa
c7129fd377
match -> test
...
Using RegExp method `test` because this is what is wanted
2013-12-11 00:43:31 -08:00
Fabio M. Costa
4b3fa413a1
Improving never seen error message
...
Removing repeating "support it" and fixing camelCase method name
2013-12-10 21:07:41 -08:00
Jared Forsyth
043a986ba9
fixing capitalization
2013-12-10 11:59:29 -07:00
Jared Forsyth
7640e53102
rename this tip to be less confusing
...
Using props to initialize state is completely fine; the issue is using state as a "cache" for values calculated based off of props. This title makes it more clear.
2013-12-10 11:50:44 -07:00
Paul O’Shannessy
b268f95e1f
Merge pull request #648 from bricooke/patch-1
...
Update highlighted lines in tutorial
2013-12-09 23:44:51 -08:00
Paul O’Shannessy
8dfdd1d106
Make travis quieter on IRC
2013-12-09 16:03:47 -08:00
Paul O’Shannessy
80e0e2a13f
Clean trailing space and lint
2013-12-09 15:54:16 -08:00
Paul O’Shannessy
5c65abfbac
Merge remote-tracking branch 'syranide/textarearows'
2013-12-09 15:51:38 -08:00
Paul O’Shannessy
904cf15972
Merge pull request #646 from spicyj/lint2
...
Fix lint error (unused variable)
2013-12-09 15:49:02 -08:00
Brian Cooke
42dee34146
Update highlighted lines in tutorial
...
Minor issue, but I found it distracting that the highlighted lines were not accurate. I *believe* this fixes them up.
2013-12-09 15:16:37 -08:00
Ben Alpert
277abbfe7b
Fix lint error (unused variable)
2013-12-09 12:29:03 -08:00
Thomas Aylott
00c8160f8e
Merge pull request #628 from subtleGradient/subtlegradient/travis-task-cleanup
...
add browser testing to travis
2013-12-09 12:19:33 -08:00
Thomas Aylott
feeebfbc51
removed complexity report until it's fixed
2013-12-09 14:55:21 -05:00
Thomas Aylott
55f50ca4d1
enable code coverage and code complexity reports
2013-12-09 14:55:21 -05:00
Thomas Aylott
0c366ce648
fix lint
2013-12-09 14:55:21 -05:00
Thomas Aylott
1b477fa40c
move sauce labs config out of the Gruntfile
2013-12-09 14:55:21 -05:00
Thomas Aylott
a41c20d43b
sets each IE separately for now
2013-12-09 14:55:20 -05:00
Thomas Aylott
fe8008e67c
PICK ALL THE NITS!!!1!
2013-12-09 14:55:20 -05:00
Thomas Aylott
4af362b751
combine iOS and IE matrix tests
2013-12-09 14:55:20 -05:00
Thomas Aylott
8e3cb7bd9d
tests fail in Safai now. unblocking for now.
...
Add these back in as build blockers once those issues are fixed.
2013-12-09 14:55:20 -05:00
Thomas Aylott
c6f99c3a84
iOS is failing again. Will debug separately
2013-12-09 14:55:20 -05:00
Thomas Aylott
b8ee94d999
define public saucelabs info for everything to use
2013-12-09 14:55:20 -05:00
Thomas Aylott
3308137d8d
run tests in old iOS, but allow failures
2013-12-09 14:55:20 -05:00
Thomas Aylott
e944b68e8c
new grunt test:full task tests in many browsers
...
Moved the travis specific stuff back into the travis file
2013-12-09 14:55:20 -05:00
Thomas Aylott
e560229c83
secure tokens aren't available for pull requests
...
Now you can use the saucelabs jazz locally also.
2013-12-09 14:55:20 -05:00
Thomas Aylott
18459deb77
enable IE browser testing in travis
2013-12-09 14:55:20 -05:00
Thomas Aylott
a13bd1e251
simplify travis script
2013-12-09 14:55:20 -05:00
Ben Alpert
7325189890
Fix scrollLeft/scrollTop warning in latest Chrome
...
Chrome gives the warnings
```
body.scrollLeft is deprecated in strict mode. Please use 'documentElement.scrollLeft' if in strict mode and 'body.scrollLeft' only if in quirks mode.
body.scrollTop is deprecated in strict mode. Please use 'documentElement.scrollTop' if in strict mode and 'body.scrollTop' only if in quirks mode.
```
the first time getUnboundedScrollPosition is invoked. This fixes it. (All modern browsers support `pageYOffset`; IE 8 doesn't but works properly with `document.documentElement.scrollTop` except in quirks mode which React doesn't support.)
2013-12-07 15:57:23 -08:00
Paul O’Shannessy
153b75f186
Bump version to 0.9.0-alpha
...
This is trunk, which will be 0.9. We'll have to cherry-pick this whole
thing into a 0.8 branch.
2013-12-06 15:11:25 -08:00
Paul O’Shannessy
a42b61fa85
Fix botched rebase
2013-12-06 15:10:57 -08:00
Paul O’Shannessy
ce0f244c54
Move npm-react-core to npm-react, fix tasks accordingly
2013-12-06 15:10:15 -08:00
Paul O’Shannessy
9fdf589976
Update react package readme
2013-12-06 12:03:16 -08:00
petehunt
ef339c9cc4
Version bump, make tests work
2013-12-06 11:56:30 -08:00
petehunt
e5c4a3c7d5
update README
2013-12-06 11:56:30 -08:00
petehunt
036e621467
version bump to 0.8 to get on top of react.js
2013-12-06 11:56:30 -08:00
petehunt
0b97c6438e
rename to with associated warnings
2013-12-06 11:56:30 -08:00
petehunt
6269cbf482
rename to with associated warnings
2013-12-06 11:56:30 -08:00
petehunt
82f211f6b8
revert muffinize :(
2013-12-06 11:56:30 -08:00
petehunt
90e2258791
response to code review
2013-12-06 11:56:30 -08:00
petehunt
d197992dc8
update npm-react-core package.json
2013-12-06 11:56:30 -08:00
Paul O’Shannessy
9162cb8abe
react-core npm module
2013-12-06 11:56:29 -08:00
petehunt
e839405202
muffinification
2013-12-06 11:56:29 -08:00
petehunt
5466d0a063
first work: __DEV__
...
fix invariant
Get browserify working
remove dead code elimination step since it is not needed due to minifier
use industry standard NODE_ENV
2013-12-06 11:56:29 -08:00
Paul O’Shannessy
9270d3d56e
Merge pull request #592 from spicyj/guard-fn
...
ReactErrorUtils: In prod, just return the original
2013-12-06 11:31:02 -08:00
Cartas
7d8190f56e
Updated the animation-fix to account for transitionEnter being false.
2013-12-06 15:37:38 +01:00
Cartas
c313a1045d
Nodes that have had their child removed already, but then get given a new one no longer bug-out.
...
In the case of having an animated node which is, after the leave-transition has been activated, then re-added in a render call causes React to 'break'. This is especially noticeable if you spam to removal and re-addition of an item in a ReactTransitionGroup.
This fix simply stops the leave transition and restarts the enter transition.
2013-12-06 14:46:33 +01:00
Ben Alpert
1be9a9e986
Bump version of wd
...
wd 0.2.2 gives `TypeError: Cannot call method 'jsCondition' of undefined` since #551 ; 0.2.6 is the latest and works so switch to that.
2013-12-05 17:13:52 -08:00
Paul Shen
12e765dd27
Revert "Don't mutate passed-in props"
...
This reverts https://github.com/facebook/react/pull/576
This approach mutates the default props for the instance on each update,
which causes incorrect behavior. discussed with @balpert. can look into
cloning but this unbreaks.
2013-12-05 16:53:43 -08:00
Paul O’Shannessy
a7f6082c9c
Merge pull request #636 from cpojer/rest-parameters-react
...
Add more useful ES6 transforms to jsx-internal.
2013-12-05 16:47:31 -08:00
Paul O’Shannessy
2ebbbc5145
Followup fix for lint
2013-12-05 15:55:49 -08:00
Paul O’Shannessy
7db8f818bc
Merge remote-tracking branch 'spicyj/depth-not-owner'
2013-12-05 15:51:39 -08:00
Thomas Aylott
55e3b64ff4
Merge pull request #635 from subtleGradient/subtlegradient/fixes-webdriver-test
...
fixes webdriver issues
2013-12-05 14:55:52 -08:00
Thomas Aylott
d035268c41
Merge pull request #617 from subtleGradient/subtlegradient/complexity-task
...
NEW `grunt complexity` reporting task
2013-12-05 14:55:17 -08:00
Ben Alpert
d0883c8cc7
Use depth (not owner) to check for root components
...
Fixes #557 .
2013-12-05 13:36:29 -08:00
Thomas Aylott
2807202ee7
bump webdriver timeouts
...
fixes #634
fixes #551
2013-12-05 16:27:26 -05:00
Thomas Aylott
60f2e45d2d
fixes test runner for IE8
2013-12-05 16:27:26 -05:00
Thomas Aylott
c222c46146
filter out tests from complexity report
2013-12-05 16:27:10 -05:00
Thomas Aylott
2b3e97b5a4
NEW grunt complexity reporting task
2013-12-05 16:27:10 -05:00
Andreas Svensson
27b8e7a6f4
corrections
2013-12-05 19:40:48 +01:00
cpojer
31359e9962
Add more useful ES6 transforms to jsx-internal.
2013-12-05 10:20:24 -08:00
Andreas Svensson
4d6d4b54d6
Fix ReactDOMTextarea missing "rows" and "cols" attribute, incorrect "size" property
2013-12-05 18:36:48 +01:00
Andreas Svensson
e060eabb01
Add HAS_POSITIVE_NUMERIC_VALUE to DOMProperty and normalize behavior of null values
...
Uniformly remove null values, rather than sometimes set/remove, could potentially assign 'null' or 'undefined'
2013-12-05 18:36:46 +01:00
Paul O’Shannessy
09bdcefd4f
Notify travis build results in IRC channel
...
If this gets noisy, we can change to only notify on change.
2013-12-04 21:19:24 -08:00
Paul O’Shannessy
2bbc42ce41
Update package devDependencies
2013-12-04 21:07:16 -08:00
Marshall Roch
d17bd176a2
Remove support for putting mixins, propTypes, etc. in 'statics'
...
This leaves statics as a way to define static methods and properties
that will be accessible on the return value of `React.createClass`
without changing the current spec.
2013-12-04 20:27:44 -08:00
Sean Kinsey
c2e48740fc
[ReactTransitionGroup] Add onTransitionEnter and onTransitionLeave
...
It is valuable to know when the number of children in a TransitionGroup is going
to increase or decrease, since we might want to apply extra animations.
For instance, when used with overflow:auto, we might want to apply different css
based on it overflowing or not - to do this we need to calculate this after new
nodes has entered and after nodes has been removed.
2013-12-04 20:27:28 -08:00
John Watson
bf24dc33f7
Separate replaceState invariant violations
...
It'd be nice if we knew which error we were hitting when this invariant hit.
2013-12-04 20:27:24 -08:00
Marshall Roch
e3ad088ff3
Remove deprecation warning for React statics
2013-12-04 20:27:19 -08:00
Paul O'Shannessy
1b8bdbe177
Remove deprecated React.unmountAndReleaseReactRootNode
2013-12-04 20:27:15 -08:00
Marshall Roch
79b9d5af62
Introduce 'statics' for class specification
...
This moves the static properties off of the root object and into
a 'statics' property. Then they are made available on the constructor so
they can be used directly and in mixins.
2013-12-04 18:39:44 -08:00
Ben Newman
66f6cbad56
Merge pull request #535 from benjamn/commoner-cache-buster
...
Establish a convention for forcing jsx rebuilds.
2013-12-04 13:54:29 -08:00
Ben Newman
057c88ce52
s/jsxConfig/commonerConfig/g
2013-12-04 16:47:13 -05:00
Ben Newman
3527d9d91c
Establish a convention for forcing jsx rebuilds.
...
Pull request #526 updated the behavior of vendor/constants.js without
changing any source files or the bin/jsx-internal script, so files that
should have been rebuilt (like utils/__tests__/ImmutableObject-test.js)
were not automatically rebuilt (unless you knew to do `grunt clean` or
`rm -rf .module-cache` manually).
This commit allows us to bump a version number when we know the transform
toolchain has been altered in a way that will not be visible to
commoner/jsx.
With this convention, if we reset to an older revision (e.g. during a git
bisect) and the appropriate cached module files are still in the
.module-cache/, they can be used without rebuilding. That's why I prefer
this approach to just deleting the .module-cache/.
Closes #104 .
Closes #496 .
Closes #530 .
2013-12-04 16:36:59 -05:00
Ben Newman
affe7f98b5
Merge pull request #367 from benjamn/findComponentRoot-memory-usage-improvements
...
Space optimizations for ReactMount.findComponentRoot.
2013-12-04 13:20:29 -08:00
Paul O’Shannessy
bcd7b5d194
Merge pull request #630 from spicyj/remove-updatePropertiesByID
...
Remove unused updatePropertiesByID
2013-12-04 10:34:35 -08:00
Ben Alpert
9d443542f9
Remove unused updatePropertiesByID
2013-12-03 19:22:36 -08:00
Ben Newman
87db648f3e
Address pull request feedback.
2013-12-03 16:43:37 -05:00
Ben Newman
6b9fc81b64
Space optimizations for ReactMount.findComponentRoot.
2013-12-03 16:43:37 -05:00
Vjeux
e4909d0f2e
Add video at the bottom of the front page
2013-12-03 12:11:12 -08:00
Paul O’Shannessy
9d18956b09
Merge pull request #624 from spicyj/remove-registrationNamesKeys
...
Remove unused event plugin registrationNamesKeys
2013-12-02 16:03:36 -08:00
Paul O’Shannessy
cd3bfe64d4
Fix blog pagination
...
I missed this in the Jekyll upgrade.
2013-12-02 15:46:20 -08:00
Paul O’Shannessy
241f4d29b2
[docs] Fix download links to addons builds
2013-12-02 15:13:49 -08:00
Pete Hunt
3851462b80
Fix lint warnings
2013-12-02 13:32:09 -08:00
Paul O’Shannessy
76e3294c8f
Merge pull request #609 from subtleGradient/subtlegradient/fixes-ios-crasher
...
fixes iOS crasher
2013-12-02 13:25:40 -08:00
Paul O’Shannessy
d64256fb65
Merge pull request #626 from spicyj/getUnboundedScrollPosition-license
...
Add missing license header
2013-12-02 09:07:07 -08:00
petehunt
00adabc20d
Fix frontpage example to retain selection
2013-12-02 04:04:45 -08:00
Ben Alpert
1cb402c410
Add missing license header
2013-12-02 01:12:20 -08:00
Pete Hunt
e923e22c16
Merge pull request #625 from spicyj/patch-3
...
Tweaks to README
2013-12-01 23:06:51 -08:00
Ben Alpert
55cd8bee35
Tweaks to README
...
Most significant change is updating the leading copy to match #440 .
2013-12-01 22:49:46 -08:00
Ben Alpert
4323ab095f
Remove unused event plugin registrationNamesKeys
2013-12-01 22:28:19 -08:00
Pete Hunt
22dc8fa765
Merge pull request #602 from chenglou/tips-bind
...
docs tips pass arguments to callbacks
2013-12-01 19:07:14 -08:00
Cheng Lou
e98244adb5
docs tips parent-child communication
2013-12-01 21:39:22 -05:00
Pete Hunt
92b62bf1fe
Merge pull request #576 from spicyj/immutable-props
...
Don't mutate passed-in props
2013-12-01 18:26:41 -08:00
Pete Hunt
2a84b6c6b2
Merge pull request #537 from hojberg/dont_animate_undefined_children
...
ReactTransitions: Don't animate undefined children
2013-12-01 14:21:11 -08:00
Pete Hunt
285e3a8929
Merge pull request #440 from petehunt/new-taglines
...
New marketing copy
2013-12-01 14:00:13 -08:00
Pete Hunt
ab36b114fc
Merge pull request #581 from chenglou/docs-select-value
...
docs `select` `value` to control chosen option
2013-12-01 13:53:12 -08:00
Paul O’Shannessy
d8a1dbb19c
Merge pull request #618 from chenglou/didmout-didUpdate-new
...
docs remove rootNode for componentDidMount/Update
2013-11-27 18:50:10 -08:00
Cheng Lou
cffb115480
docs remove rootNode for componentDidMount/Update
2013-11-27 21:46:02 -05:00
Paul O’Shannessy
98b9e2faeb
Merge pull request #599 from chenglou/dl-addons
...
docs add download links for react-with-addons
2013-11-27 14:48:42 -08:00
Cheng Lou
11638b7824
docs add download links for react-with-addons
2013-11-27 17:31:27 -05:00
Paul O’Shannessy
8fbdb50a9d
Merge pull request #597 from spicyj/gh-527
...
Don't use .returnValue if .defaultPrevented exists
2013-11-27 14:28:26 -08:00
Paul O’Shannessy
5fbd8109f8
Merge pull request #598 from spicyj/gh-516
...
Be resilient to fn.name not existing in IE
2013-11-27 14:28:02 -08:00
Paul O’Shannessy
126ef094fc
Merge pull request #593 from spicyj/run-lint
...
Run lint on Travis in a matrix
2013-11-27 14:14:33 -08:00
Thomas Aylott
916ee6b394
jsx & JSDOM support
2013-11-27 17:04:40 -05:00
Ben Alpert
2104327ba1
Run lint automatically on Travis (in a matrix)
2013-11-27 16:53:57 -05:00
Paul O’Shannessy
42eef0e9d6
Merge pull request #610 from chenglou/jsx-js
...
make docs jsx compiler highlight transpiled js code
2013-11-27 12:22:51 -08:00
Paul O’Shannessy
e31fdfd0b3
Merge pull request #616 from davidhellsing/patch-1
...
Backbone example: changed key from Math.random() to todo.cid
2013-11-27 12:14:40 -08:00
Marshall Roch
697a9113c0
ReactPropTypes: add oneOfType to support union types
...
Summary:
e.g.
propTypes: {
foo: React.PropTypes.oneOfType([
React.PropTypes.string,
React.PropTypes.number
]);
}
to do this, I exposed a `.weak` chainable validator that returns instead of throws, e.g.
React.PropTypes.string.isRequired.weak
React.PropTypes.string.weak
which returns true or false. Technically, `React.PropTypes.string.weak.isRequired` also exists, but `oneOfType` will never call it. Might be useful to people creating custom validators though.
2013-11-27 12:10:50 -08:00
Marshall Roch
351dcfed01
Validate propTypes, contextTypes, childContextTypes
...
who watches the watchmen?
2013-11-27 12:10:50 -08:00
Pete Hunt
fcfe516a2e
Less verbose ReactPropTypeLocations logging
...
Since we use keyMirror() and invariant() messages are only shown in __DEV__, we don't have to do manual constant->string translation. Also fixes a few
undefined keys that just happened to work before.
2013-11-27 12:10:50 -08:00
Paul O’Shannessy
9886e40395
Merge pull request #594 from spicyj/skip-spec
...
Allow running one spec/suite in the web interface
2013-11-27 11:54:31 -08:00
Paul O’Shannessy
a7811fb75b
Merge pull request #595 from spicyj/old-logger
...
Remove reference to old browser logger
2013-11-27 11:46:15 -08:00
David Hellsing
a79ef7fc29
Changed key from Math.random() to todo.cid
...
It doesn’t make much sense to generate a random key for each todo render, because it will re-draw all todo’s DOM nodes on each model change. I changed it to the unique identifier ``todo.cid`` already supplied by the backbone model.
2013-11-26 18:07:56 +01:00
Andreas Svensson
15ce8ecfe9
Polyfill and normalize HTML5 "key", deprecates which and keyCode
2013-11-26 10:09:50 +01:00
Cheng Lou
92ea31c7b7
make docs jsx compiler highlight transpiled js code
2013-11-25 19:04:28 -05:00
Thomas Aylott
f4753030a2
IE support
2013-11-25 16:02:01 -05:00
Thomas Aylott
3bfb687de3
remove warning comment about createHTMLDocument
2013-11-25 15:08:00 -05:00
Thomas Aylott
eebad16636
Use an iframe to create a testDocument…
...
instead of `createHTMLDocument` since it isn't fully support by the browsers we care about.
fixes #606
fixes #454
2013-11-25 15:05:35 -05:00
Thomas Aylott
564c8669f8
Merge pull request #596 from spicyj/gh-532
...
'getElementsByClassName' doesn't exist in IE8
2013-11-25 09:29:52 -08:00
Pete Hunt
a7f0afceec
Merge pull request #589 from balanceiskey/master
...
Minor spelling correction in docs
2013-11-24 20:53:35 -08:00
Ben Newman
1f8f0ae2d6
Merge pull request #601 from spicyj/commoner-088
...
Update commoner to 0.8.8 for Windows support.
2013-11-24 13:06:59 -08:00
Ben Alpert
0e2840abce
Update commoner to 0.8.8 for Windows support
...
benjamn/commoner#44 fixed commoner to work on Windows when module path relativization isn't used; with this, the `jsx` binary should work properly on Windows (though `jsx-internal` still won't).
Fixes #316 , fixes #391 , fixes #567 .
2013-11-24 16:02:01 -05:00
Ben Alpert
685dec022a
Be resilient to fn.name not existing in IE
...
Fixes #516 .
2013-11-24 01:53:53 -05:00
Ben Alpert
e6e71a4953
ReactErrorUtils: In prod, just return the original
...
This will save a stack frame (nice when in a debugger) and presumably be a bit faster.
2013-11-24 01:47:15 -05:00
Ben Alpert
4bd0a40037
Don't use .returnValue if .defaultPrevented exists
...
`.defaultPrevented` exists in IE9+. I checked in IE9, Chrome, and Firefox that it does default to `false`.
Fixes #527 .
2013-11-24 01:35:49 -05:00
Ben Alpert
b99fd93684
'getElementsByClassName' doesn't exist in IE8
...
Fixes #532 .
2013-11-24 01:22:00 -05:00
Ben Alpert
67c851792a
Remove reference to old browser logger
...
The file was removed in 37bb9b76aba0deb445874273b93955ffb1c18bf8; this was giving a 404.
2013-11-24 01:04:09 -05:00
Ben Alpert
3a75d70501
Allow running one spec/suite in the web interface
...
This is the proper way to make it filter the spec list:
https://github.com/pivotal/jasmine/blob/1_3_x/spec/runner.html
I submitted the jasmine-jsreporter change as a pull request here:
https://github.com/detro/jasmine-jsreporter/pull/2
Fixes #563 .
2013-11-24 00:53:29 -05:00
Sundeep Malladi
b7ef221b27
Minor spelling correction in docs
2013-11-22 14:32:53 -06:00
Pete Hunt
d51ae6b8bc
Merge pull request #575 from spicyj/owner
...
Move __owner__ off of props
2013-11-21 17:44:48 -08:00
Ben Alpert
61abc645e5
Move __owner__ off of props
2013-11-21 17:34:52 -08:00
Ben Newman
2a66c9b089
Merge pull request #586 from benjamn/reinstate-ReactEventEmitter-mocking
...
Add back mocking removed to make ReactEventTopLevelCallback-test pass.
2013-11-21 11:07:57 -08:00
Ben Newman
52d3b47f48
Add back mocking removed to make ReactEventTopLevelCallback-test pass.
...
This is a partial reversion of commit 9937f0c8bd .
2013-11-21 10:57:24 -08:00
Ben Newman
97bbd852b2
Merge pull request #584 from spicyj/mock
...
Mock modules properly in test runner.
2013-11-21 10:31:59 -08:00
Ben Alpert
af95b35f27
Have faith in var hoisting
2013-11-21 10:31:20 -08:00
Ben Alpert
c7bb3af760
Mock modules properly in test runner
...
As an added bonus, the jasmine web interface now groups tests by file.
Test Plan:
grunt test passes on b2507066 , the parent of 566f8b2e (which committed a workaround for buggy module mocking).
2013-11-21 00:39:37 -08:00
Cheng Lou
0a3d0163d0
docs select value to control chosen option
2013-11-20 22:34:53 -05:00
Ben Newman
566f8b2e85
Merge pull request #573 from spicyj/tests
...
Make ReactEventTopLevelCallback-test pass
2013-11-20 16:54:15 -08:00
Paul O’Shannessy
b2507066b6
Don't call utils.traverse in transform
...
Accidental change we missed in review of #495 .
2013-11-20 15:36:54 -08:00
Christopher Chedeau
e73900dad4
Remove rootNode from componentDidMount and componentDidUpdate
...
We can already access the DOM node using `this.getDOMNode()`. Passing it as an argument was a bad decision.
Previous API:
```
componentDidMount(DOMElement rootNode)
componentDidUpdate(object prevProps, object prevState, object prevContext, DOMElement rootNode)
```
Next API:
```
componentDidMount()
componentDidUpdate(object prevProps, object prevState, object prevContext)
```
2013-11-20 14:20:35 -08:00
Christoph Pojer
2fe2cd5337
Ensure ReactPerf always uses a string as a URL
2013-11-20 14:19:13 -08:00
Tim Yung
04c3e2e407
Add nextContext to componentWillReceiveProps
...
Add `nextContext` as an argument to `componentWillReceiveProps`. We can figure out what to rename the method to later.
2013-11-20 14:19:01 -08:00
Christopher Chedeau
a23d43bf05
Use this.getDOMNode() instead of last argument of componentDidMount
2013-11-20 14:18:49 -08:00
Marshall Roch
934ef1d4c2
Fix context in callbacks
...
callbacks like shouldComponentUpdate, componentDidUpdate, etc. were getting the full, unsanitized context, instead of the one that's been filtered down to only the fields allowed to be visible by contextTypes.
2013-11-20 14:18:28 -08:00
Christopher Chedeau
c8b6fe51d9
Use this.getDOMNode() instead of last argument of componentDidUpdate
...
Context is adding another argument that shifts all of them by one. Since we can already use this.getDOMNode(), it doesn't really make sense to pass it as an argument to that function.
2013-11-20 14:18:07 -08:00
Marshall Roch
3fd3341ab9
remove transaction argument from componentWillReceiveProps
2013-11-20 14:17:23 -08:00
Paul O'Shannessy
060118c7e4
order object properties consistently
2013-11-20 14:17:13 -08:00
Pete Hunt
3651b8892f
Merge pull request #578 from spicyj/patch-2
...
autoBind -> Autobinding
2013-11-20 11:47:22 -08:00
Ben Alpert
d49d84b250
autoBind -> Autobinding
...
We don't use the term autoBind anywhere any more.
2013-11-20 11:42:05 -08:00
Pete Hunt
0df4be849f
Merge pull request #577 from stillmotion/master
...
Add explination of autoBind to DOM Event Listener tip
2013-11-20 11:41:11 -08:00
Levi McCallum
ceaf3fba32
Add explination of autoBind to DOM Event Listener tip
2013-11-20 11:29:05 -08:00
Ben Alpert
42c14b8078
Don't mutate passed-in props
...
Depends on #575 ; fixes #570 . Now we'll be in trouble if someone tries to share objects between calls to getDefaultProps but that was already true of getInitialState and I haven't heard any complaints there.
This is the same number of allocations as before; we're just copying props in the other direction. (In any case, the copy happens only on mount and there are a couple dozen costlier things we're doing already at that time.)
2013-11-20 01:17:10 -08:00
Ben Alpert
9937f0c8bd
Make ReactEventTopLevelCallback-test pass
...
This module-level mock() seems to have been interfering with other tests (26 specs failing). We don't have any other tests that do a module-level mock() so I'm going to assume it isn't supported in the open-source test runner right now. I changed it so only ReactEventEmitter.handleTopLevel is mocked; doing so made ReactEventEmitter complain that TopLevelCallbackCreator wasn't defined so I switched the ReactMount references to use React directly so that ReactDefaultInjection would kick in properly.
With this, all the tests pass.
2013-11-19 23:46:32 -08:00
Paul O’Shannessy
bd1f5e7e16
Put nav data in "_data"
...
New in Jekyll 1.3 - http://jekyllrb.com/docs/datafiles/
2013-11-19 15:52:42 -08:00
Paul O’Shannessy
f37fd7a7a3
Fix pagination
2013-11-19 15:25:00 -08:00
Paul O’Shannessy
378a49bf3c
Update jekyll to 1.3
2013-11-19 15:18:15 -08:00
Vjeux
96e97c1a87
Community round-up #11
2013-11-19 22:56:34 +01:00
Paul O’Shannessy
5f22259964
Merge pull request #565 from chenglou/className-htmlFor
...
docs highlight className and htmlFor transforms
2013-11-19 11:01:10 -08:00
Jeff Morrison
ab47e99215
Merge pull request #495 from syranide/fixutils
...
utils.* is now used everywhere
2013-11-19 10:59:16 -08:00
Cheng Lou
1fcd6412fb
docs highlight className and htmlFor transforms
2013-11-18 21:42:51 -05:00
Cheng Lou
ce0eec97db
docs classSet semicolons missing
2013-11-18 21:22:14 -05:00
Paul O’Shannessy
5d2f0b4e07
Merge branch 'chenglou-classSet'
...
closes #463
2013-11-18 18:00:24 -08:00
Paul O’Shannessy
e79079d174
Merge pull request #539 from spicyj/doc-anchors-again
...
Make doc headers clickable again
2013-11-18 17:45:39 -08:00
Ben Alpert
e94ebee15e
Make doc headers clickable again
...
...without preventing clicks on other things.
Just use an `<a name="...">` tag that doesn't take up any space to make sure that we're not covering up something else.
For whatever reason, doing `position: relative; top: -$navHeight;` doesn't work and causes the anchor target not to be moved up. This solution works in both Chrome and Firefox.
2013-11-18 17:34:44 -08:00
Ben Newman
5d878ce914
Merge pull request #550 from subtleGradient/subtlegradient/code-coverage
...
Code coverage grunt tasks.
2013-11-18 14:03:56 -08:00
Thomas Aylott
5ae152cdcf
simplified the sort function
2013-11-18 16:37:47 -05:00
Thomas Aylott
c6f7fe00fa
Lines too long; reformatted
2013-11-18 16:37:47 -05:00
Thomas Aylott
45063aed44
picked all the lint
2013-11-18 16:37:47 -05:00
Thomas Aylott
5feb745b02
fixes the case when coverage isn't turned on
2013-11-18 16:37:47 -05:00
Thomas Aylott
eda56b7af2
new grunt test:coverage task
2013-11-18 16:37:47 -05:00
Thomas Aylott
8f96ec255b
new grunt browserify:withCodeCoverageLogging task
2013-11-18 16:37:47 -05:00
Thomas Aylott
ad0d9e4761
consoleLoggerMiddleware handles coverage logs
2013-11-18 16:37:47 -05:00
Thomas Aylott
b5b60a6acf
speed up server middleware slightly
2013-11-18 16:37:46 -05:00
Thomas Aylott
cb6b7f37e7
fixes an issue where the list of files to test isn't complete
2013-11-18 16:37:46 -05:00
Thomas Aylott
ef5a02c164
enable coverage logging from the worker
2013-11-18 16:37:46 -05:00
Thomas Aylott
646421f71f
batch logs until the end unless ran with --debug
2013-11-18 16:37:46 -05:00
Thomas Aylott
4c881d8487
require coverify
2013-11-18 16:37:46 -05:00
Thomas Aylott
5aa901336c
ignore logs and testing stuff
2013-11-18 16:37:46 -05:00
Thomas Aylott
61c1bf0a41
fixes browserify task transforms support
2013-11-18 16:37:46 -05:00
Daniel Lo Nigro
d853c8568e
Propagate events to parent components when nested
...
When events are captured, the nearest React-rendered ancestor is found and events are propagated to its tree. This causes issues when components are nested as only the innermost component receives the events.
This change modifies this behaviour so events propagate all the way up the DOM hierarchy. To reduce the performance cost, this DOM traversal is only done if the component is actually nested (determined by the `containerIsNested` map which is lazily initialised).
2013-11-18 10:56:29 -08:00
Marshall Roch
b91396be8e
Contexts
...
Summary:
adds `this.context` which you can think of as implicit props, which are passed automatically down the //ownership// hierarchy.
Contexts should be used sparingly, since they essentially allow components to communicate with descendants (in the ownership sense, not parenthood sense), which is not usually a good idea. You probably would only use contexts in places where you'd normally use a global, but contexts allow you to override them for certain view subtrees which you can't do with globals.
The context starts out `null`:
var RootComponent = React.createClass({
render: function() {
// this.context === null
}
});
You should **never** mutate the context directly, just like props and state.
You can change the context of your children (the ones you own, not `this.props.children` or via other props) using the new `withContext` method on `React`:
var RootComponent = React.createClass({
render: function() {
// this.context === null
var children = React.withContext({foo: 'a', bar: 'b'}, () => (
// In ChildComponent#render, this.context === {foo: 'a', bar: 'b'}
<ChildComponent />
));
// this.context === null
}
});
Contexts are merged, so a component can override its owner's context **for its children**:
var ChildComponent = React.createClass({
render: function() {
// this.context === {foo: 'a', bar: 'b'} (for the caller above)
var children = React.withContext({foo: 'c'},() => (
// In GrandchildComponent#render,
// this.context === {foo: 'c', bar: 'b'}
<GrandchildComponent />
));
// this.context === {foo: 'a', bar: 'b'}
}
});
2013-11-18 10:56:24 -08:00
Pete Hunt
7df127db31
Better error message for renderComponentToString()
...
Reported on Twitter by AirBnb (who are integrating React into their open-source JS framework). They made a mistake and passed a string in as the
component. We should have a better error message for that.
2013-11-18 10:54:05 -08:00
Tim Yung
8529f1b053
Remove Obsolete IE8 Compatibility Code
...
See the TODO comment. Synthetic events have shipped and this is no longer necessary.
2013-11-18 10:54:03 -08:00
Marshall Roch
381a3392c6
Rename receiveProps to receiveComponent
...
This renames receiveProps and changes it to take the next component to copy props from instead of just the props. That is,
component.receiveComponent(nextComponent, transaction)
instead of
component.receiveProps(nextComponent.props, transaction)
This is a precursor to adding contexts, which will also need to get propagated just like props. This change allows ReactCompositeComponent to override `receiveProps` and do something like
this._pendingContext = nextComponent.context;
2013-11-18 10:53:58 -08:00
Andreas Svensson
a39b8fda70
utils.* is now used everywhere
2013-11-15 11:17:24 +01:00
Pieter Vanderwerff
1e1d7fe770
Set docs menu item to active when viewing a “tips” page
2013-11-15 15:27:31 +13:00
Paul O’Shannessy
e6010bf75e
Merge pull request #362 from mcsheffrey/feat-documentation-cookbook
...
React Tips documentation
2013-11-14 14:59:41 -08:00
Paul O’Shannessy
d1fa53ca03
Cleanup lint warnings from recent testing changes
...
Also, relaxed a rule for dot notation (and unrelaxed it in src).
2013-11-14 11:24:06 -08:00
Connor McSheffrey
26c142df82
Merge pull request #20 from zpao/tips
...
Updates to tips
2013-11-14 11:17:34 -08:00
Ben Newman
b61eacd3c5
Explicitly require the assert module in vendor/constants.js.
2013-11-14 13:48:08 -05:00
Paul O’Shannessy
1324eb5556
"use strict" in shouldUpdateReactComponent
2013-11-14 10:37:33 -08:00
Paul O’Shannessy
9cb3a3a182
Remove modules cache with grunt clean
2013-11-14 10:37:07 -08:00
Ben Newman
f9423241d9
Merge pull request #510 from subtleGradient/subtlegradient/run-the-browser-tests-on-saucelabs
...
Make it easy to run the browser tests on saucelabs.
2013-11-14 10:08:51 -08:00
Simon Højberg
5b1e4c0324
Transitions: Handle undefined input to mergeKeySet
...
Gracefully handle undefined input to mergeKeySet.
2013-11-13 23:02:06 -05:00
Simon Højberg
acbddd2641
ReactTransitions: Don't animate undefined children
2013-11-13 20:54:22 -05:00
Paul O’Shannessy
c821887160
formatting and syntax on false in JSX tip
2013-11-13 17:43:17 -08:00
Paul O’Shannessy
4367dad669
Update wording on AJAX tip
2013-11-13 17:43:17 -08:00
Paul O’Shannessy
0ebd3d92ba
Fix broken link, spacing on events tip
2013-11-13 17:43:17 -08:00
Paul O’Shannessy
80ab7bf4e1
s/Zuck/Rogers/
2013-11-13 17:43:17 -08:00
Paul O’Shannessy
4a9ed4a204
Fix broken link on componentWillReceiveProps tip
2013-11-13 17:43:16 -08:00
Paul O’Shannessy
f6f3d4262b
fix broken link on controlled input tip
2013-11-13 17:43:16 -08:00
Paul O’Shannessy
75383c5c99
Children props tip tweak
2013-11-13 17:43:16 -08:00
Paul O’Shannessy
49261c9392
Fix broken link, formatting on px style tip
2013-11-13 17:43:16 -08:00
Paul O’Shannessy
fe52e059b9
Tweak for self closing tag tip
2013-11-13 17:43:16 -08:00
Paul O’Shannessy
684e5922e8
Tweaks to if-else tip
2013-11-13 17:43:16 -08:00
Paul O’Shannessy
7c1cf0a2dc
Small cleanup to style tips
2013-11-13 17:43:16 -08:00
Pete Hunt
dab167c0e3
Merge pull request #460 from chenglou/opacity-1
...
fix doc & example transition opacity from .99 to 1
2013-11-13 17:31:08 -08:00
Thomas Aylott
326e3a33ac
Merge pull request #529 from benjamn/upgrade-populist
...
Upgrade populist version to v0.1.5 for better error reporting
2013-11-13 14:50:36 -08:00
Ben Newman
d44c07b9a7
Upgrade populist version to v0.1.5 for better error reporting.
2013-11-13 17:42:17 -05:00
Thomas Aylott
22829b5529
remove unnecessary task config
2013-11-13 16:49:08 -05:00
Thomas Aylott
c4cd02efc5
fixes #513
2013-11-13 16:22:11 -05:00
Thomas Aylott
d1fd4058da
sauce labs browser configs for running manually
2013-11-13 16:22:11 -05:00
Thomas Aylott
08bd1f98e5
wait a little longer for the page to load
2013-11-13 16:22:11 -05:00
Thomas Aylott
2d6eb3d8fc
don't log your password to the console
2013-11-13 16:22:11 -05:00
Thomas Aylott
4daeda1490
log individual test results when in --debug mode
2013-11-13 16:22:11 -05:00
Thomas Aylott
c1925db067
cleanup
2013-11-13 16:22:11 -05:00
Thomas Aylott
cd24cbdbf4
name local saucelabs tests too
2013-11-13 16:22:11 -05:00
Thomas Aylott
d9b7e47824
sped up the webdriver tests
2013-11-13 16:22:11 -05:00
Thomas Aylott
b845134151
user JSON encoding for browser logger
...
Fixes a strange issue in IE
2013-11-13 16:22:11 -05:00
Thomas Aylott
37bb9b76ab
remove old browser logger
2013-11-13 16:22:10 -05:00
Thomas Aylott
39ba5f90b1
no need to pass jasmine through jsx
2013-11-13 16:22:10 -05:00
Thomas Aylott
e3ced21c9d
postDataToURL using ajax instead of DOM
2013-11-13 16:22:10 -05:00
Thomas Aylott
66a0f2e7bd
Suppress encoding warning in Firefox
2013-11-13 16:22:10 -05:00
Thomas Aylott
7c8b70eedb
better error handling for jasmine task
2013-11-13 16:22:10 -05:00
Thomas Aylott
f12c428c78
NEW saucelabs webdriver task
2013-11-13 16:22:10 -05:00
Thomas Aylott
7ee30554ad
ignore tunnel logs
2013-11-13 16:22:10 -05:00
Thomas Aylott
6b1042a6f9
fixup sauce-tunnel
2013-11-13 16:22:10 -05:00
Thomas Aylott
ff857efdd2
desiredCapabilities webdriver config
2013-11-13 16:22:10 -05:00
Thomas Aylott
0401a0a67c
NEW sauce-tunnel grunt task
2013-11-13 16:22:10 -05:00
Ben Newman
5873ee7691
Merge pull request #526 from benjamn/rewrite-vendor/constants.js
...
Rewrite vendor/constants.js to use require("recast").types.traverse.
2013-11-13 12:39:53 -08:00
Ben Newman
da717977ed
Better comments for vendor/constants.js.
2013-11-13 15:33:10 -05:00
Ben Newman
2b763fc452
Rewrite vendor/constants.js to use require("ast-types").traverse.
...
Most notably, this new style of transformation gives us access to
this.parent.node, which allows us to avoid replacing identifiers that are
not actually free variables, such as member expression properties.
Closes #496 .
2013-11-13 15:33:10 -05:00
Ben Newman
b137a3326e
Merge pull request #524 from brainkim/suchfailing-wow-sotest
...
Fix failing tests
2013-11-13 12:33:00 -08:00
Paul O’Shannessy
970445fc48
Merge pull request #522 from pieter-vanderwerff/blog-footer-position-fix
...
Added clearfix to blog content holder
2013-11-13 12:28:34 -08:00
Paul O’Shannessy
e716c2ee35
Merge pull request #493 from guidobouman/master
...
Prevent header anchors from interfering with clickable content in docs.
2013-11-13 12:23:57 -08:00
Brian Kim
e707ec0b1e
Fix failing tests
...
Two of your tests were failing because of commit
1e71df5399
I fixed them by:
1) Using jasmine's spyOn in ReactCompositeComponentError-test.js
2) Inverting the function wrapping in the above commit.
Godspeed.
2013-11-13 05:07:52 -05:00
Pieter Vanderwerff
05d44b2152
Added clearfix to blog content holder
2013-11-13 15:01:32 +13:00
Paul O’Shannessy
797577576e
Small cleanup to tips intro
2013-11-12 13:22:55 -08:00
Connor McSheffrey
bd535bd51c
Renamed Cookbook references to tips. Reworded intro (sounded weird because it still referenced cookbooks. Updated some entry ID's (some side nav links didn't match entry permalinks)
2013-11-11 21:00:53 -08:00
Connor McSheffrey
166043593d
Merge pull request #19 from chenglou/title-case
...
fix title case for tips everywhere
2013-11-11 20:19:33 -08:00
Tim Yung
9fd28f44df
Rename nodeContains to containsNode
2013-11-11 16:39:25 -08:00
Mouad Debbar
1ffe2d0927
Add support for oncontextmenu in React.
2013-11-11 16:39:25 -08:00
Marshall Roch
735b4f0b7c
Remove transaction from componentWillUpdate
...
It wasn't documented and I think the transaction is supposed to be internal.
2013-11-11 16:39:25 -08:00
Felix Kling
1e71df5399
Improve error logging for event handlers of React components.
...
This guards every auto-bound method and uses the name of the component and method as guard name.
2013-11-11 16:39:25 -08:00
Paul O’Shannessy
48948c91c3
Merge pull request #506 from syranide/wheelie8
...
Fix wheelDelta misspelled
2013-11-11 14:28:25 -08:00
Fabio M. Costa
1d73efee10
Fixes the name of the component on documentation
...
AvatarImage -> Avatar
2013-11-10 11:52:41 -08:00
Andreas Svensson
62f7cd213f
Fix wheelDelta misspelled
2013-11-10 16:58:55 +01:00
Paul O’Shannessy
91f6684fbf
Merge pull request #484 from syranide/jsxie8
...
IE8 support for JSXTransformer
2013-11-08 14:38:51 -08:00
Andreas Svensson
595b482478
JSXTransformer now supports IE8
2013-11-08 23:04:43 +01:00
Cheng Lou
ff51a23aea
update add-ons docs based on feedbacks
...
- Overview of add-ons for the add-ons page.
- Better title for `ReactLink`.
- Nicer code format for classSet example.
- Better explanation for `classSet`.
2013-11-08 16:55:14 -05:00
petehunt
f7103a8629
Make state immutable in tutorial (eek)
2013-11-08 13:27:20 -08:00
Guido Bouman
4c9f9dafa6
Prevents header anchors from interfering with clickable content.
2013-11-08 15:52:46 +01:00
Pete Hunt
b65e6a0453
Merge pull request #492 from chenglou/move-tooling
...
move docs tooling from JSX in Depth
2013-11-07 11:36:19 -08:00
Cheng Lou
ca95c8c3a3
move docs tooling from JSX in Depth
...
Also removes the code wrap around the syntax highlighting link.
2013-11-07 14:25:54 -05:00
Thomas Aylott
3b8af033cd
don't try to loadNpmTasks grunt-cli
2013-11-07 13:57:34 -05:00
Ben Newman
b3c87ea017
Merge pull request #451 from subtleGradient/subtlegradient/browser-testing
...
Browser testing.
2013-11-07 10:20:58 -08:00
Thomas Aylott
241d57aa9e
allow directory browsing
2013-11-07 13:12:31 -05:00
Ben Newman
ee8bb07122
Merge pull request #486 from benjamn/jsx-version
...
Make bin/jsx --version output the React version according to package.json.
2013-11-07 07:52:54 -08:00
Ben Newman
c2ef6e343d
Make bin/jsx --version output the React version according to package.json.
...
Closes #329 .
2013-11-07 10:52:02 -05:00
Paul O’Shannessy
192af01952
Merge pull request #488 from spicyj/gh-473
...
Make submit button default value appear correctly
2013-11-06 22:56:19 -08:00
Paul O’Shannessy
5293a2ab1c
Merge pull request #487 from spicyj/multi-proptypes
...
Make propTypes DEFINE_MANY_MERGED
2013-11-06 22:55:58 -08:00
Ben Alpert
d5c2d5f291
Make submit button default value appear correctly
...
Fixes #473 .
2013-11-06 21:19:44 -08:00
Ben Alpert
4fe784de1f
Make propTypes DEFINE_MANY_MERGED
2013-11-06 17:13:25 -08:00
Thomas Aylott
f289e9862a
rename sauce-harness to index
2013-11-06 17:29:00 -05:00
Thomas Aylott
5fa707534a
ignore generated file
...
Running the tests shouldn't make git status dirty.
2013-11-06 17:15:38 -05:00
Thomas Aylott
0a120bb5d0
cleanup loadNpmTasks
2013-11-06 17:12:20 -05:00
Thomas Aylott
19a5505c50
making phantomjs version less specific
2013-11-06 17:00:25 -05:00
Thomas Aylott
c9401be38e
replace phantom-harness runner with webdriver
2013-11-06 16:44:03 -05:00
Thomas Aylott
b922d8d8a6
move browser test libs to lib folder
2013-11-06 16:43:20 -05:00
Vjeux
b8cf7068c4
Community round-up #10
2013-11-06 12:36:30 -08:00
Thomas Aylott
2d6a8391bf
Not necessary anymore
2013-11-06 15:32:39 -05:00
Thomas Aylott
f4d487fb59
removed compiled build files
...
Not necessary now that we aren't supporting testling.
2013-11-06 15:30:52 -05:00
Thomas Aylott
be7ee1ee65
start a local webdriver server before using it
2013-11-06 15:30:52 -05:00
Thomas Aylott
3e2d3e4837
add logging to webdriver config
2013-11-06 15:30:52 -05:00
Thomas Aylott
dfb4dde8fd
keep track of incomplete
2013-11-06 15:30:52 -05:00
Thomas Aylott
159d64ddd3
cleanup
2013-11-06 15:30:52 -05:00
Thomas Aylott
1368b29596
cleanup webdriver jasmine task
2013-11-06 15:30:52 -05:00
Thomas Aylott
c780985d3e
wait for all results to finish sending
2013-11-06 15:30:52 -05:00
Thomas Aylott
71772e763a
grunt task launch phantomjs as a webdriver server
2013-11-06 15:30:52 -05:00
Thomas Aylott
2d979a9ce9
cleanup
2013-11-06 15:30:52 -05:00
Thomas Aylott
2b273d8568
remove saucelabs for now
2013-11-06 15:30:51 -05:00
Thomas Aylott
b725097409
log using grunt
2013-11-06 15:30:51 -05:00
Thomas Aylott
772af52f4a
safer bind
2013-11-06 15:30:51 -05:00
Thomas Aylott
db299ed761
remove sauce labs stuff for now
2013-11-06 15:30:51 -05:00
Thomas Aylott
0f274e5b22
new webdriver-jasmine task and config
2013-11-06 15:30:51 -05:00
Thomas Aylott
e086cbb44b
separate grunt task for saucelabs browser testing
2013-11-06 15:30:51 -05:00
Thomas Aylott
93c0a46a1d
upgraded sauce harness
...
Lost jasmine directly instead of using a module builder because it was failing in IE8
2013-11-06 15:30:51 -05:00
Thomas Aylott
2cd663940a
don't double-log test results
2013-11-06 15:30:51 -05:00
Thomas Aylott
7bbf6cbfd1
browser support for jasmine-support
2013-11-06 15:30:51 -05:00
Thomas Aylott
46e86df420
move html reporter and its requirements
2013-11-06 15:30:51 -05:00
Thomas Aylott
d64f34b5d8
inserted iframes can be targeted after a delay
2013-11-06 15:30:50 -05:00
Thomas Aylott
f65f7b3bbd
IE8 support in jasmine-support
2013-11-06 15:30:50 -05:00
Thomas Aylott
c4727944df
Simple test result logger
2013-11-06 15:30:50 -05:00
Thomas Aylott
694cd6e9e8
test runner requires es5-shim
2013-11-06 15:30:50 -05:00
Thomas Aylott
465b8dc646
test server middleware for receiving test results
2013-11-06 15:30:50 -05:00
Thomas Aylott
284d8d67bd
Upgrade to the latest version of jasmine
...
Necessary for IE8 support
2013-11-06 15:30:50 -05:00
Thomas Aylott
b111521f40
Correct SauceLabs tokens
2013-11-06 15:30:50 -05:00
Thomas Aylott
6a7a15cf30
disable testling
2013-11-06 15:30:50 -05:00
Thomas Aylott
3df6942cde
SauceLabs Browser testing via Travis
2013-11-06 15:30:50 -05:00
Thomas Aylott
fc572832b1
Absolute urls for less flakiness
2013-11-06 15:30:49 -05:00
Thomas Aylott
46c0aeea67
Fixed paths for phantomjs
2013-11-06 15:30:49 -05:00
Thomas Aylott
a447f53b00
Make it easier to repro tests in the wild
2013-11-06 15:30:49 -05:00
Thomas Aylott
24ec78fd52
Testing-ci can't handle spaces in filenames?
2013-11-06 15:30:49 -05:00
Thomas Aylott
1393e55d53
include the built files for testling
2013-11-06 15:30:49 -05:00
Thomas Aylott
5640d641d6
skip Worker test unless the browser supports them
2013-11-06 15:30:49 -05:00
Thomas Aylott
ecd847cad7
enable testling-ci browser testing
2013-11-06 15:30:49 -05:00
Thomas Aylott
b867aa0410
Format test results as TAP
2013-11-06 15:30:49 -05:00
Thomas Aylott
8205c681eb
serve worker.js from its actual relative path
2013-11-06 15:30:49 -05:00
Thomas Aylott
c4ba8f8997
Browser test runner
2013-11-06 15:30:49 -05:00
Thomas Aylott
001bda28d9
Generate the browser test list at built time
2013-11-06 15:30:49 -05:00
Paul O’Shannessy
1e7f3f1aac
Merge pull request #483 from spicyj/sm-img
...
Use smaller blog images and host directly
2013-11-06 10:16:31 -08:00
Pete Hunt
28eddd1670
XML->HTML, because people are fickle.
2013-11-05 19:22:47 -08:00
Ben Alpert
a65f60a008
Use smaller blog images and host directly
2013-11-05 18:54:29 -08:00
Pete Hunt
091425058b
Merge pull request #482 from chenglou/data-lowercase
...
add docs lowercase mention for data- and aria-
2013-11-05 18:10:56 -08:00
Cheng Lou
e89ad6c960
add docs lowercase mention for data- and aria-
2013-11-05 21:02:06 -05:00
Paul Shen
0fed861424
Move merge utility functions from utils to vendor/core
2013-11-05 17:17:47 -08:00
Tim Yung
e78d580c06
Include Ownership in the Ship of Theseus
...
When we determine whether a React component should be updated (as opposed to destroyed or replaced), we currently only look at whether they share the same constructor. This adds a check for whether they share the same owner component.
I've also consolidated this logic (I cannot believe this was not already done).
2013-11-05 17:14:57 -08:00
Pete Hunt
e78d5b5462
Merge pull request #481 from andreypopp/master
...
"Thinking in React": fix list formatting
2013-11-05 15:52:53 -08:00
Andrey Popp
20b7faaab7
"Thinking in React": fix list formatting
2013-11-06 03:50:28 +04:00
Paul O’Shannessy
5dad5e92a9
Merge pull request #476 from SanderSpies/unused-onselect
...
Removing unused useSelect variable.
2013-11-05 15:17:45 -08:00
Paul O’Shannessy
1553bad73a
Move header link styling out of documentation only
...
It's used in blog posts too. I also constrained it to just the anchor
class to avoid any other headers we have.
2013-11-05 15:04:57 -08:00
Pete Hunt
aadb65166d
Merge pull request #453 from petehunt/blogpost2
...
"Thinking in React" blog post
2013-11-05 14:26:25 -08:00
petehunt
c8bc605f9e
rename
2013-11-05 14:25:46 -08:00
petehunt
486b60486a
rename
2013-11-05 14:23:12 -08:00
petehunt
13f0644aaa
make props/state section less intense
2013-11-05 14:21:15 -08:00
petehunt
780442f0b3
blogify
2013-11-05 14:21:15 -08:00
SanderSpies
27fa1f5c9c
Removing 'isEventSupported'
2013-11-05 22:53:50 +01:00
SanderSpies
dede55d27d
Removing unused useSelect variable.
2013-11-05 22:45:02 +01:00
Paul O’Shannessy
5c6c02fe03
Merge pull request #472 from lrowe/patch-4
...
Script async and defer properties
2013-11-05 11:48:54 -08:00
Paul O’Shannessy
9f3ef1b6ac
Remove jQuery version number from tutorial docs
2013-11-05 11:29:00 -08:00
Ben Alpert
5386cd9665
tutorial: Simplify ajax options
...
dataType was unnecessary; mimeType was both unnecessary and wrong in this case. Also removed an unnecessary bind and changed pollInterval to 2000 ms for consistency with https://github.com/petehunt/react-tutorial (faster is nicer if you actually try it out!).
2013-11-05 11:17:37 -08:00
Cheng Lou
f2ee3c53a9
fix title case for docs tips everywhere
2013-11-05 09:57:00 -05:00
Laurence Rowe
1bcca22719
Script async and defer properties
2013-11-04 20:40:53 -08:00
petehunt
6c1e8e8a66
Update tutorial to use className
2013-11-04 17:04:25 -08:00
petehunt
9f69b12e5b
get rid of composition
2013-11-04 12:22:43 -08:00
Ben Newman
ff3c8ccbe6
Merge pull request #458 from chenglou/rm-wrapup
...
Remove support for the wrapup packager.
2013-11-04 11:41:59 -08:00
Paul O’Shannessy
da5c61afe4
Oxford comma
2013-11-04 11:34:56 -08:00
Josh Duck
18bf0b80bc
Fix ReactDOMSelection for IE 11
...
IE 11 no longer supports the legacy document.selection API.
Their implementation of window.getSelection() doesn't support
the extend() method, which we were relying on.
If the selection is RTL and selection extend is missing, then just
flip the selection.
2013-11-04 11:34:39 -08:00
Cheng Lou
d220ce71b5
Merge branch 'rm-wrapup' of github.com:chenglou/react into rm-wrapup
...
Conflicts:
package.json
2013-11-03 15:43:56 -05:00
Cheng Lou
d6cbc710bd
remove examples/wrapup
...
Apparently it's no longer relevant.
2013-11-03 15:41:40 -05:00
Paul O’Shannessy
10ccd9f103
Merge pull request #465 from matnel/bug388
...
Clear error message when rendering a nonvalid component
2013-11-01 18:35:50 -07:00
Matti Nelimarkka
9e24257a4e
Clear error message when rendering a nonvalid component
2013-11-01 17:32:09 -07:00
Paul O’Shannessy
aedf580a33
[docs] Clarify when getInitialState is called.
2013-11-01 15:29:10 -07:00
petehunt
f713f06c62
less aggro
2013-11-01 11:47:38 -07:00
Cheng Lou
899ae83acb
add docs on classSet add-on
2013-10-31 21:59:35 -04:00
Cheng Lou
3c1e0f0a8c
split add-ons into subsections
...
In preparation for documenting `classSet` add-on.
2013-10-31 21:10:19 -04:00
Tim Yung
0dc011c40c
Better getUnboundedScrollPosition for windows
...
Instead of using browser sniffing, `getUnboundedScrollPosition` can do
better and not have to depend on the `getDocumentScrollElement` module.
2013-10-31 15:24:58 -07:00
Cheng Lou
e455e28ff8
fix doc & example transition opacity from .99 to 1
...
The initial thought was that an opacity animation from 0.01 to 1 causes trouble on some browser. But after testing on opera 12.15, ff 23, ie 10, chrome 30, desktop/mobile safari 7 and chrome android I confirm this works.
2013-10-31 17:35:38 -04:00
JeffMo
a4f8ad1bb0
Switch utility function calls -> namespaced calls
2013-10-31 13:45:16 -07:00
Cheng Lou
0acf5e22bd
remove examples/wrapup
...
Apparently it's no longer relevant.
2013-10-31 15:49:37 -04:00
Ben Newman
df1099649c
Merge pull request #457 from benjamn/upgrade-populist
...
Bump populist version to v0.1.4
2013-10-31 10:22:14 -07:00
Ben Newman
d1ad4a3ff0
Bump populist version to v0.1.4.
...
The new version includes a fix for this IE8 issue reported by
@subtleGradient: https://github.com/benjamn/populist/issues/4
Closes #456 .
2013-10-31 13:03:31 -04:00
Paul O'Shannessy
2cf7d943df
Reorder DefaultDOMPropertyConfig
...
`autoCorrect` belongs with the non-standard properties list.
2013-10-30 16:58:05 -07:00
Mark Richardson
9b44ad6ce5
Add autoCorrect to list of supported DOM properties
2013-10-30 16:57:53 -07:00
Tim Yung
7789a32438
Forward Compatibility w/ WebKit & Blink
...
Newer versions of WebKit and Blink will support both `document.body.scrollTop` and `document.documentElement.scrollTop`. Therefore, implementing cross-browser compatibility by summing the two will no longer work.
This changes React to use `getUnboundedScrollPosition` so we get the fix and consistency in one change!
See: https://rniwa.com/2013-10-29/web-compatibility-story-of-scrolltop-and-scrollleft/
2013-10-30 16:56:55 -07:00
Connor McSheffrey
551cc01430
Update nav config with new entry names/permalinks
2013-10-30 12:29:38 -07:00
Connor McSheffrey
22058d09da
Merge pull request #18 from chenglou/title-case
...
title case for entry titles; fix two entry names
2013-10-30 12:24:50 -07:00
Cheng Lou
80efa9a33e
title case for entry titles; fix two entry names
2013-10-30 15:06:16 -04:00
Connor McSheffrey
6a0976ca9d
Merge pull request #17 from chenglou/feat-documentation-cookbook
...
fix 3 more entries
2013-10-29 18:10:56 -07:00
Connor McSheffrey
5847536c9d
Removed grunt task for building live edits and removed js link conditional at bottom of layout since we're no longer conditionally loading live edit js for cookbook pages
2013-10-29 18:04:29 -07:00
Paul O’Shannessy
a5d1e2fd90
blog post for 0.5.1
2013-10-29 13:16:53 -07:00
Paul O’Shannessy
d8e3779010
Update everything for v0.5.1
...
Cherry-picked from f3db0006e8 , excluding
version changes.
2013-10-29 13:15:33 -07:00
Cheng Lou
7d50ab600f
ex for entry 7
2013-10-29 14:55:11 -04:00
Connor McSheffrey
e3ec6f5292
Removed JS for live edit
2013-10-29 11:28:28 -07:00
Cheng Lou
9471287794
Merge branch 'feat-documentation-cookbook' of https://github.com/mcsheffrey/react into feat-documentation-cookbook
2013-10-29 14:23:17 -04:00
Cheng Lou
cbec8c1a89
fix 2 more entries
2013-10-29 14:20:04 -04:00
Connor McSheffrey
4a7d8f628e
Removed .js extension from Cookbook Introduction description
2013-10-29 11:09:57 -07:00
Connor McSheffrey
b025e4c576
Merge pull request #16 from chenglou/feat-documentation-cookbook
...
new line at end of nac_docs; update to entry 4
2013-10-29 11:06:14 -07:00
Cheng Lou
ee8fa3760d
new line at end of nac_docs; update to entry 4
2013-10-29 14:02:20 -04:00
Connor McSheffrey
efaba68663
Removed Q&A format
2013-10-29 10:42:47 -07:00
Connor McSheffrey
33effd31d5
Removing the grunt task generated live edit JS files since we're holding off on the inline edit feature for now
2013-10-29 10:15:45 -07:00
Cheng Lou
271e7d50cf
better grammar
2013-10-29 10:15:45 -07:00
Cheng Lou
c235ec7421
entry on false behavior
2013-10-29 10:15:45 -07:00
Connor McSheffrey
6e28818ba9
Remove cb prefix from cookbook entries since they're already in /cookbook/ directory
2013-10-29 10:15:45 -07:00
Connor McSheffrey
95f3caaaa4
removed cookbook prefix from filenames
2013-10-29 10:15:45 -07:00
Connor McSheffrey
a7dd6e7c70
better regex for filename
2013-10-29 10:15:45 -07:00
Connor McSheffrey
30ab347b78
undo changes to extractCode, using grunt task instead
2013-10-29 10:15:45 -07:00
Connor McSheffrey
9585c407e2
added function that write to the output html file
2013-10-29 10:15:45 -07:00
Connor McSheffrey
9efd1f5e9b
added seperate cookbook layout (since URL base of next/prev is hardcoded in layout), added next/prev yaml meta to each cookbook entry until I can find a way of generating them dynamically
2013-10-29 10:15:45 -07:00
Connor McSheffrey
21c5c2a54e
update cookbook nav
2013-10-29 10:15:45 -07:00
Cheng Lou
a970957eef
remove entry 13 jquery animation; react has animation
2013-10-29 10:14:21 -07:00
Cheng Lou
119e29ff1d
one single child in ternary
2013-10-29 10:14:21 -07:00
Cheng Lou
7db760427c
add lib integration entry; tweak 1 sentence
2013-10-29 10:14:20 -07:00
Cheng Lou
6d2ea9a200
ajax ex
2013-10-29 10:14:20 -07:00
Cheng Lou
0475834470
fix all links to point to /react as root
2013-10-29 10:14:20 -07:00
Cheng Lou
48f1ee4940
change some wording, add tip for events entry
...
- No need to mention React, you know you're working with it =).
- Wrap code elements in back ticks, so that they get the "box" styling for md.
- You'd want the snippet to work inside the live editor, so you need to `renderComponent`. As per wiki specification, the DOM element on which to mount is `mountNode`, just like on the front page.
- Don't forget the JSX pragma, or else your `render` fails.
- Nitpick: empty line after the end of md.
- No need for jQuery reference since
1. The general mood around React is that you don't need jQuery.
2. The syntax' still clear without jQuery.
3. We're doing a jQuery integration entry =).
- `getInitialState` was absent.
- You don't need `componentWillMount` here. fetch them in `getInitialState`.
- The non-spoken convention seems to call the event handler `"handle" + eventName`. So `handleResize` clearly indicates it's a `resize` handler while `updateDimensions` might do something else. This latter name might actually be better under circumstances where you use call the method directly somewhere, but since we removed the only direct usage in `componentWillMount` this is fine.
- Went OCD again and tried to keep the code short. `width` is enough of a demo. Removed `height`.
- Distinguish between DOM events and React events. Wish we go full React events in a near future.
2013-10-29 10:14:20 -07:00
Cheng Lou
fb5f69f44e
modify some wording
2013-10-29 10:14:20 -07:00
Connor McSheffrey
e0df9cbb01
Add event listeners cookbook entry
2013-10-29 10:14:20 -07:00
Cheng Lou
1e56800543
shrink working on props in state entry
2013-10-29 10:14:20 -07:00
Cheng Lou
28f30b7ef0
props in getInitialState as anti-pattern
2013-10-29 10:14:20 -07:00
Connor McSheffrey
86355eb1ba
added grunt task for generating live samples JS
2013-10-29 10:14:20 -07:00
Cheng Lou
bfbcb5362b
tip format for intro
2013-10-29 10:14:20 -07:00
Cheng Lou
8d2b4a9a25
all typos
2013-10-29 10:14:20 -07:00
Connor McSheffrey
da722b92c0
Added backgroundImage example to "inline styles" cookbook entry
2013-10-29 10:14:20 -07:00
Connor McSheffrey
a4d7f3f907
minor spelling change on the "controlled input null value" cookbook entry
2013-10-29 10:14:20 -07:00
Cheng Lou
6377b2ed95
entry on willReceiveProps not triggered on mounting
2013-10-29 10:14:19 -07:00
Cheng Lou
dd52ef92a8
entry on controlled input with value null
2013-10-29 10:14:19 -07:00
Cheng Lou
9ed72b43e8
add line-height to unitless css props
2013-10-29 10:14:19 -07:00
Cheng Lou
f4bbe9c296
style prop value shorthand, children prop manip warning
2013-10-29 10:14:19 -07:00
Cheng Lou
814126dc52
entry on returning only one node from render
2013-10-29 10:14:19 -07:00
Cheng Lou
ff9246316f
fix permalink, temporarily remove script field of Jekyll
2013-10-29 10:14:19 -07:00
Cheng Lou
b92c433c50
small typo and code tag is now js highlight
...
Was html before bc github screws up the js highlighting for jsx.
2013-10-29 10:14:19 -07:00
Cheng Lou
7144ba1c10
new entry on self-closing tag
2013-10-29 10:14:19 -07:00
Cheng Lou
0fad22512a
new entry for ternary expression in jsx
2013-10-29 10:14:19 -07:00
Cheng Lou
4d9cde43be
add tip format for comparison
2013-10-29 10:14:19 -07:00
Cheng Lou
dc24bb63d6
add tip style to style entry
2013-10-29 10:14:19 -07:00
Connor McSheffrey
5f296768a5
Moved cookbook recipes into separate directory. Updated nav_docs to loop through cookbook yaml. Added cookbook directory to js/ to add live editing of code samples
2013-10-29 10:14:19 -07:00
Connor McSheffrey
dd5fbc5859
Added docs for React cookbook section Introduction and Inline Styles React recipe
2013-10-29 10:14:18 -07:00
Laurence Rowe
280eff41f3
Make 'disabled' MUST_USE_ATTRIBUTE for compatibility with CSS [disabled] selectors.
...
When a ReactDOMComponent is created with the property `disabled: true` subsequently setting the property to `disabled: false` the HTML attribute `disabled="true"` was being left in the DOM.
2013-10-28 18:53:19 -07:00
Paul O’Shannessy
214e9103bf
Merge pull request #423 from andreypopp/master
...
Re-rendering components into a document leaks components
2013-10-28 17:00:19 -07:00
Andrey Popp
ac9dd92272
Fix unmounting components mounted into doc element
...
If we are to unmount a component mounted into a document element we should
unmount it from document.documentElement and not from document.firstChild which
is a doctype element in this specific case.
2013-10-29 02:49:00 +04:00
Ben Alpert
25ba629098
Move heading anchors 50px up to avoid nav bar
...
Fixes #447 .
We do this by moving the actual anchored element up in the page without moving the actual text. (Apple uses a similar trick in their framed docs.) Now this looks a bit sillier on smaller screens but it's better overall.
2013-10-28 13:52:58 -07:00
petehunt
91d23ffc58
typo
2013-10-28 10:21:11 -07:00
Paul O’Shannessy
10f3d93df7
Update API docs for unmountAndReleaseReactRootNode
2013-10-26 17:42:34 -07:00
Pete Hunt
1c77e1a492
Merge pull request #446 from brianr/master
...
ReactTransitionGroup example: fix typo and logic bug in handleRemove
2013-10-25 18:13:46 -07:00
Ian Obermiller
fbb741febb
Fix ReactTransitionEvents detectEvents
2013-10-25 18:11:58 -07:00
Brian Rue
c5cc145538
ReactTransitionGroup example: fix typo and logic bug in handleRemove
2013-10-25 18:03:31 -07:00
Cat Chen
0ef1ca0024
fixed %d in invariant call
2013-10-25 18:03:26 -07:00
petehunt
0a75a52b4a
Changes based on feedback
2013-10-25 11:40:54 -07:00
Josh Duck
0d2d3360d0
Don't reset mouseDown in focus handlers
...
Focus fires after mouse down on initial click, so we lost the
flag when the user initially began dragging on the input.
2013-10-22 14:09:33 -07:00
petehunt
15de778587
New marketing copy
2013-10-21 22:08:43 -07:00
Keito Uchiyama
eeefe95958
docs: Delete Mutation Events (onCharacterDOMModified)
2013-10-21 19:56:49 -07:00
Paul O’Shannessy
5e65c186aa
docs: remove OUTLINE
2013-10-21 15:20:01 -07:00
Cheng Lou
99dcdb87e3
Add clickable anchors to docs headers
...
Closes #434
2013-10-21 14:27:31 -07:00
Tim Yung
58b3ae3136
Use Default Value for Undefined Props
...
Currently, default props as defined by `getDefaultProps` are only used if a prop is not specified (using `X in Y` check).
However, this makes it difficult for composing components to pass along the state of not being defined, for example:
render: function() {
// If `this.props.someProp` is not set, `InnerThing` should use the default value.
return <InnerThing someProp={this.props.someProp} />;
}
This changes the requirement for falling back to the default value to an undefined check (using `typeof X === 'undefined'`).
2013-10-21 13:17:44 -07:00
Pete Hunt
7d6b0dd613
Merge pull request #438 from spicyj/select-range
...
Make SelectEventPlugin not throw for range inputs
2013-10-21 09:39:39 -07:00
Ben Alpert
893fba8373
Make SelectEventPlugin not throw for range inputs
...
Accessing .selectionStart on a non-text input will throw (see http://www.w3.org/TR/2009/WD-html5-20090423/editing.html#textFieldSelection ), so check that the input has selection capabilities before accessing the property.
Fixes #437 .
2013-10-20 14:39:37 -07:00
Paul O’Shannessy
b46b6a8db9
Fix live editor examples on home page.
...
Remember that one time I wrote release notes and said:
> This is a breaking change - if you were using class, you must change
> this to className or your components will be visually broken.
Good thing I didn't listen to myself!
2013-10-16 17:56:51 -07:00
Paul O’Shannessy
44ad2b55e6
0.5.0 release
...
Updated README, CHANGELOG, blog post
2013-10-16 11:43:09 -07:00
Paul O’Shannessy
820532b7aa
Fix grunt npm:test
2013-10-16 11:42:02 -07:00
Paul O’Shannessy
48281a17e4
bump version to 0.6.0-alpha
2013-10-15 22:39:28 -07:00