Jorge Cabiedes
18cd49daad
Merge f9d13007bf into sapling-pr-archive-jorge-cab
2025-09-23 14:12:41 -07:00
Jorge Cabiedes
b5531938a9
Merge 1430e808cd into sapling-pr-archive-jorge-cab
2025-09-23 14:12:30 -07:00
Jorge Cabiedes Acosta
f9d13007bf
[compiler] Improve error for calculate in render useEffect validation
...
Summary:
Change error and update snapshots
2025-09-23 14:10:08 -07:00
Jorge Cabiedes Acosta
1430e808cd
[compiler] Change ValidateNoDerivedComputationsInEffect logic to track prop and local state derived values variables and add extra tests
...
Summary:
Biggest change of the stack, we track how values prop and local state values are derived throughout the entire component.
This PR also adds a couple tests we will work towards fixing
Test Plan:
Added:
ref-conditional-in-effect-no-error
effect-contains-prop-function-call-no-error
derived-state-from-ref-and-state-no-error
2025-09-23 14:10:08 -07:00
Jorge Cabiedes Acosta
4dbb857bea
[compiler] Don't throw calculate in render if the blamed setter is used outside of the effect
2025-09-23 14:10:08 -07:00
Jorge Cabiedes Acosta
984cd6d3e3
[compiler] Don't throw calculate in render when there is a global function call in the effect
2025-09-23 14:10:08 -07:00
Jorge Cabiedes Acosta
22904687d8
[compiler] Don't throw calculate in render when there is a ref in the effect
2025-09-23 14:10:08 -07:00
Jorge Cabiedes Acosta
2fa703de55
[compiler] Don't throw calculate in render when there is a prop function call in effects
2025-09-23 14:10:08 -07:00
Jorge Cabiedes
c0c7e406c0
Merge 958b537761 into sapling-pr-archive-jorge-cab
2025-09-23 14:09:19 -07:00
Jorge Cabiedes Acosta
632bb60b1a
merge commit for archive created by Sapling
2025-09-23 14:09:01 -07:00
Jorge Cabiedes Acosta
958b537761
[compiler] Change ValidateNoDerivedComputationsInEffect logic to track prop and local state derived values variables and add extra tests
...
Summary:
Biggest change of the stack, we track how values prop and local state values are derived throughout the entire component.
This PR also adds a couple tests we will work towards fixing
Test Plan:
Added:
ref-conditional-in-effect-no-error
effect-contains-prop-function-call-no-error
derived-state-from-ref-and-state-no-error
2025-09-23 14:08:48 -07:00
Jorge Cabiedes Acosta
f5634cd894
[compiler] ValidateNoDerivedComputationsInEffects test cases
...
Summary:
This creates the test cases we expect this first iteration of calculate in render to catch
Test Plan:
Test cases
2025-09-23 14:08:47 -07:00
Jorge Cabiedes Acosta
c845fea959
merge commit for archive created by Sapling
2025-09-23 14:04:06 -07:00
Jorge Cabiedes Acosta
8b42510619
[compiler] Change ValidateNoDerivedComputationsInEffect logic to track prop and local state derived values variables and add extra tests
...
Summary:
Biggest change of the stack, we track how values prop and local state values are derived throughout the entire component.
This PR also adds a couple tests we will work towards fixing
Test Plan:
Added:
ref-conditional-in-effect-no-error
effect-contains-prop-function-call-no-error
derived-state-from-ref-and-state-no-error
2025-09-23 14:03:43 -07:00
Jorge Cabiedes
dbbaeec7d9
Merge 0aec469b5c into sapling-pr-archive-jorge-cab
2025-09-23 13:57:06 -07:00
Jorge Cabiedes Acosta
85afeda10e
merge commit for archive created by Sapling
2025-09-23 13:56:52 -07:00
Jorge Cabiedes
3609880c6d
Merge c4cdad81c9 into sapling-pr-archive-jorge-cab
2025-09-23 13:56:39 -07:00
Jorge Cabiedes Acosta
0aec469b5c
[compiler] Improve error for calculate in render useEffect validation
...
Summary:
Change error and update snapshots
2025-09-23 13:55:32 -07:00
Jorge Cabiedes Acosta
03e169d7f5
[compiler] Don't throw calculate in render if the blamed setter is used outside of the effect
2025-09-23 13:54:22 -07:00
Jorge Cabiedes Acosta
be37341724
[compiler] Don't throw calculate in render when there is a global function call in the effect
2025-09-23 13:53:13 -07:00
Jorge Cabiedes Acosta
dfc21cf3bb
[compiler] Don't throw calculate in render when there is a ref in the effect
2025-09-23 13:52:16 -07:00
Jorge Cabiedes Acosta
2b9eef668c
[compiler] Don't throw calculate in render when there is a prop function call in effects
2025-09-23 13:51:12 -07:00
Jorge Cabiedes Acosta
1df56ebbee
[compiler] Change ValidateNoDerivedComputationsInEffect logic to track prop and local state derived values variables and add extra tests
...
Summary:
Biggest change of the stack, we track how values prop and local state values are derived throughout the entire component.
This PR also adds a couple tests we will work towards fixing
Test Plan:
Added:
ref-conditional-in-effect-no-error
effect-contains-prop-function-call-no-error
derived-state-from-ref-and-state-no-error
2025-09-23 13:50:25 -07:00
Jorge Cabiedes Acosta
c4cdad81c9
[compiler] ValidateNoDerivedComputationsInEffects test cases
...
Summary:
This creates the test cases we expect this first iteration of calculate in render to catch
Test Plan:
Test cases
2025-09-23 13:44:31 -07:00
Jorge Cabiedes
c6a3355a55
Merge 6d527701f1 into sapling-pr-archive-jorge-cab
2025-09-23 11:26:29 -07:00
Jorge Cabiedes
6b350fa719
Merge f989af23f9 into sapling-pr-archive-jorge-cab
2025-09-23 11:25:49 -07:00
Jorge Cabiedes Acosta
6d527701f1
[compiler] Improve error for calculate in render useEffect validation
2025-09-23 11:25:43 -07:00
Jorge Cabiedes Acosta
f989af23f9
[compiler] ValidateNoDerivedComputationsInEffects test cases
...
Summary:
This creates the test cases we expect this first iteration of calculate in render to catch
Test Plan:
Test cases:
2025-09-23 11:25:43 -07:00
Jorge Cabiedes Acosta
d5ae21089b
[compiler] Don't throw calculate in render if the blamed setter is used outside of the effect
2025-09-23 11:25:43 -07:00
Jorge Cabiedes Acosta
3de91b886f
[compiler] Don't throw calculate in render when there is a global function call in the effect
2025-09-23 11:25:43 -07:00
Jorge Cabiedes Acosta
1c86aa6da9
[compiler] Don't throw calculate in render when there is a ref in the effect
2025-09-23 11:25:43 -07:00
Jorge Cabiedes Acosta
687ab1f3b0
[compiler] Don't throw calculate in render when there is a prop function call in effects
2025-09-23 11:25:43 -07:00
Jorge Cabiedes Acosta
2d26ba5483
[compiler] Change ValidateNoDerivedComputationsInEffect logic to track prop and local state derived values variables
2025-09-23 11:25:43 -07:00
Jorge Cabiedes
5d796e01d4
Merge 0d0f05feb2 into sapling-pr-archive-jorge-cab
2025-09-23 11:24:44 -07:00
Jorge Cabiedes Acosta
0d0f05feb2
[compiler] Improve error for calculate in render useEffect validation
2025-09-23 11:24:27 -07:00
Jorge Cabiedes Acosta
66cce5f823
[compiler] Don't throw calculate in render if the blamed setter is used outside of the effect
2025-09-23 11:24:27 -07:00
Jorge Cabiedes Acosta
114b019520
[compiler] Don't throw calculate in render when there is a global function call in the effect
2025-09-23 11:24:27 -07:00
Jorge Cabiedes Acosta
cbeada50da
[compiler] Don't throw calculate in render when there is a ref in the effect
2025-09-23 11:24:27 -07:00
Jorge Cabiedes Acosta
78e46830df
[compiler] Don't throw calculate in render when there is a prop function call in effects
2025-09-23 11:24:27 -07:00
Jorge Cabiedes Acosta
0009e33caf
[compiler] Change ValidateNoDerivedComputationsInEffect logic to track prop and local state derived values variables
2025-09-23 11:24:27 -07:00
Jorge Cabiedes Acosta
46b0ffcd2b
[compiler] ValidateNoDerivedComputationsInEffects test cases
...
Summary:
This creates the test cases we expect this first iteration of calculate in render to catch
Test Plan:
Test cases:
{F1982202767}
2025-09-23 11:24:27 -07:00
Jorge Cabiedes Acosta
0e761867ad
merge commit for archive created by Sapling
2025-09-23 10:48:38 -07:00
Jorge Cabiedes Acosta
86d2cff0bc
[compiler] Improve error for calculate in render useEffect validation
2025-09-23 10:47:59 -07:00
Jorge Cabiedes
920be26c17
Merge a87612d762 into sapling-pr-archive-jorge-cab
2025-09-23 10:44:31 -07:00
Jorge Cabiedes Acosta
a87612d762
[compiler] Improve error for calculate in render useEffect validation
2025-09-23 10:44:14 -07:00
Jorge Cabiedes Acosta
b8054a1aca
merge commit for archive created by Sapling
2025-09-22 16:40:50 -07:00
Jorge Cabiedes Acosta
60bcd767eb
[compiler] Don't throw calculate in render if the blamed setter is used outside of the effect
2025-09-22 16:40:35 -07:00
Jorge Cabiedes Acosta
f9a81e3308
[compiler] Don't throw calculate in render when there is a global function call in the effect
2025-09-22 16:39:45 -07:00
Jorge Cabiedes Acosta
edb636f64d
[compiler] Don't throw calculate in render when there is a ref in the effect
2025-09-22 16:39:45 -07:00
Jorge Cabiedes Acosta
9a42b90c16
[compiler] Don't throw calculate in render when there is a prop function call in effects
2025-09-22 16:39:45 -07:00
