bahman/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Redact external_id field (#1152)

Browse Source 
---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This commit is contained in:
Benjamin Pracht
2025-08-08 09:25:08 +02:00
committed by GitHub
parent 82ec7d7473
commit 3460265b84
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/ninety-dolls-wait.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@livekit/protocol": patch
---
Redact external_id field

1
egress/redact.go
View File

@@ -9,6 +9,7 @@ func RedactUpload(req UploadRequest) {
if s3 := req.GetS3(); s3 != nil {
s3.AccessKey = utils.Redact(s3.AccessKey, "{access_key}")
s3.Secret = utils.Redact(s3.Secret, "{secret}")
s3.AssumeRoleExternalId = utils.Redact(s3.AssumeRoleExternalId, "{external_id}")
return
}

6
egress/redact_test.go
View File

@@ -13,8 +13,9 @@ var (
file = &livekit.EncodedFileOutput{
Output: &livekit.EncodedFileOutput_S3{
S3: &livekit.S3Upload{
AccessKey: "ACCESS_KEY",
Secret: "LONG_SECRET_STRING",
AccessKey: "ACCESS_KEY",
Secret: "LONG_SECRET_STRING",
AssumeRoleExternalId: "EXTERNAL_ID",
},
},
}
@@ -52,6 +53,7 @@ func TestRedactUpload(t *testing.T) {
require.Equal(t, "{access_key}", cl.(*livekit.EncodedFileOutput).Output.(*livekit.EncodedFileOutput_S3).S3.AccessKey)
require.Equal(t, "{secret}", cl.(*livekit.EncodedFileOutput).Output.(*livekit.EncodedFileOutput_S3).S3.Secret)
require.Equal(t, "{external_id}", cl.(*livekit.EncodedFileOutput).Output.(*livekit.EncodedFileOutput_S3).S3.AssumeRoleExternalId)
cl = proto.Clone(image)
RedactUpload(cl.(UploadRequest))