Files
scylla/gms/feature_service.hh
Kamil Braun 5397524875 feature_service: make COMPUTED_COLUMNS feature unconditionally true
The feature is assumed to be true, it was introduced in 2019.
It's still advertised in gossip, but it's assumed to always be present.

The `schema_feature` enum class still contains `COMPUTED_COLUMNS`,
and the `all_tables` function in schema_tables.cc still checks for the
schema feature when deciding if `computed_columns()` table should be
included. This is necessary because digest calculation tests contain
many digests calculated with the feature disabled, if we wanted to make
it unconditional in the schema_tables code we'd have to regenerate
almost all digests in the tests. It is simpler to leave the possibility
for the tests to disable the feature.
2023-10-24 13:30:13 +02:00

154 lines
6.7 KiB
C++

/*
* Copyright (C) 2018-present ScyllaDB
*/
/*
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
#pragma once
#include <seastar/core/sstring.hh>
#include <seastar/core/future.hh>
#include <seastar/core/shared_future.hh>
#include <seastar/core/sharded.hh>
#include <unordered_map>
#include <functional>
#include <exception>
#include <set>
#include <any>
#include "seastarx.hh"
#include "db/schema_features.hh"
#include "gms/feature.hh"
namespace db {
class config;
class system_keyspace;
}
namespace service { class storage_service; }
namespace gms {
class gossiper;
class feature_service;
struct feature_config {
bool use_raft_cluster_features = false;
private:
std::set<sstring> _disabled_features;
feature_config();
friend class feature_service;
friend feature_config feature_config_from_db_config(const db::config& cfg, std::set<sstring> disabled);
};
feature_config feature_config_from_db_config(const db::config& cfg, std::set<sstring> disabled = {});
class unsupported_feature_exception : public std::runtime_error {
public:
unsupported_feature_exception(std::string what)
: runtime_error(std::move(what))
{}
};
using namespace std::literals;
/**
* A gossip feature tracks whether all the nodes the current one is
* aware of support the specified feature.
*
* A pointer to `cql3::query_processor` can be optionally supplied
* if the instance needs to persist enabled features in a system table.
*/
class feature_service final : public peering_sharded_service<feature_service> {
void register_feature(feature& f);
void unregister_feature(feature& f);
friend class feature;
std::unordered_map<sstring, std::reference_wrapper<feature>> _registered_features;
feature_config _config;
future<> enable_features_on_startup(db::system_keyspace&);
public:
explicit feature_service(feature_config cfg);
~feature_service() = default;
future<> stop();
future<> enable(std::set<std::string_view> list);
db::schema_features cluster_schema_features() const;
std::set<std::string_view> supported_feature_set() const;
// Key in the 'system.scylla_local' table, that is used to
// persist enabled features
static constexpr const char* ENABLED_FEATURES_KEY = "enabled_features";
public:
gms::feature user_defined_functions { *this, "UDF"sv };
gms::feature md_sstable { *this, "MD_SSTABLE_FORMAT"sv };
gms::feature me_sstable { *this, "ME_SSTABLE_FORMAT"sv };
gms::feature view_virtual_columns { *this, "VIEW_VIRTUAL_COLUMNS"sv };
gms::feature digest_insensitive_to_expiry { *this, "DIGEST_INSENSITIVE_TO_EXPIRY"sv };
gms::feature cdc { *this, "CDC"sv };
gms::feature nonfrozen_udts { *this, "NONFROZEN_UDTS"sv };
gms::feature hinted_handoff_separate_connection { *this, "HINTED_HANDOFF_SEPARATE_CONNECTION"sv };
gms::feature lwt { *this, "LWT"sv };
gms::feature per_table_partitioners { *this, "PER_TABLE_PARTITIONERS"sv };
gms::feature per_table_caching { *this, "PER_TABLE_CACHING"sv };
gms::feature digest_for_null_values { *this, "DIGEST_FOR_NULL_VALUES"sv };
gms::feature correct_idx_token_in_secondary_index { *this, "CORRECT_IDX_TOKEN_IN_SECONDARY_INDEX"sv };
gms::feature alternator_streams { *this, "ALTERNATOR_STREAMS"sv };
gms::feature alternator_ttl { *this, "ALTERNATOR_TTL"sv };
gms::feature range_scan_data_variant { *this, "RANGE_SCAN_DATA_VARIANT"sv };
gms::feature cdc_generations_v2 { *this, "CDC_GENERATIONS_V2"sv };
gms::feature user_defined_aggregates { *this, "UDA"sv };
// Historically max_result_size contained only two fields: soft_limit and
// hard_limit. It was somehow obscure because for normal paged queries both
// fields were equal and meant page size. For unpaged queries and reversed
// queries soft_limit was used to warn when the size of the result exceeded
// the soft_limit and hard_limit was used to throw when the result was
// bigger than this hard_limit. To clean things up, we introduced the third
// field into max_result_size. It's name is page_size. Now page_size always
// means the size of the page while soft and hard limits are just what their
// names suggest. They are no longer interepreted as page size. This is not
// a backwards compatible change so this new cluster feature is used to make
// sure the whole cluster supports the new page_size field and we can safely
// send it to replicas.
gms::feature separate_page_size_and_safety_limit { *this, "SEPARATE_PAGE_SIZE_AND_SAFETY_LIMIT"sv };
// Replica is allowed to send back empty pages to coordinator on queries.
gms::feature empty_replica_pages { *this, "EMPTY_REPLICA_PAGES"sv };
gms::feature supports_raft_cluster_mgmt { *this, "SUPPORTS_RAFT_CLUSTER_MANAGEMENT"sv };
gms::feature tombstone_gc_options { *this, "TOMBSTONE_GC_OPTIONS"sv };
gms::feature parallelized_aggregation { *this, "PARALLELIZED_AGGREGATION"sv };
gms::feature keyspace_storage_options { *this, "KEYSPACE_STORAGE_OPTIONS"sv };
gms::feature typed_errors_in_read_rpc { *this, "TYPED_ERRORS_IN_READ_RPC"sv };
gms::feature schema_commitlog { *this, "SCHEMA_COMMITLOG"sv };
gms::feature uda_native_parallelized_aggregation { *this, "UDA_NATIVE_PARALLELIZED_AGGREGATION"sv };
gms::feature aggregate_storage_options { *this, "AGGREGATE_STORAGE_OPTIONS"sv };
gms::feature collection_indexing { *this, "COLLECTION_INDEXING"sv };
gms::feature large_collection_detection { *this, "LARGE_COLLECTION_DETECTION"sv };
gms::feature secondary_indexes_on_static_columns { *this, "SECONDARY_INDEXES_ON_STATIC_COLUMNS"sv };
gms::feature tablets { *this, "TABLETS"sv };
gms::feature uuid_sstable_identifiers { *this, "UUID_SSTABLE_IDENTIFIERS"sv };
gms::feature table_digest_insensitive_to_expiry { *this, "TABLE_DIGEST_INSENSITIVE_TO_EXPIRY"sv };
// A feature just for use in tests. It must not be advertised unless
// the "features_enable_test_feature" injection is enabled.
// This feature MUST NOT be advertised in release mode!
gms::feature test_only_feature { *this, "TEST_ONLY_FEATURE"sv };
public:
const std::unordered_map<sstring, std::reference_wrapper<feature>>& registered_features() const;
static std::set<sstring> to_feature_set(sstring features_string);
future<> enable_features_on_join(gossiper&, db::system_keyspace&);
future<> on_system_tables_loaded(db::system_keyspace& sys_ks);
// Performs the feature check.
// Throws an unsupported_feature_exception if there is a feature either
// in `enabled_features` or `unsafe_to_disable_features` that is not being
// currently supported by this node.
void check_features(const std::set<sstring>& enabled_features, const std::set<sstring>& unsafe_to_disable_features);
};
} // namespace gms