Files
scylla/index/secondary_index_manager.cc
Duarte Nunes aa476cd6c9 index/secondary_index_manager: Add virtual columns to MV
Virtual columns are MV-specific columns that contribute to the
liveness of view rows. However, we were not adding those columns when
creating an index's underlying MV, causing indexes to miss base rows.

Fixes #4144
Branches: master, branch-3.0

Signed-off-by: Duarte Nunes <duarte@scylladb.com>
2019-01-27 22:30:12 +00:00

168 lines
6.1 KiB
C++

/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/*
* Copyright (C) 2017 ScyllaDB
*
* Modified by ScyllaDB
*/
/*
* This file is part of Scylla.
*
* Scylla is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Scylla is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
*/
#include "index/secondary_index_manager.hh"
#include "cql3/statements/index_target.hh"
#include "cql3/util.hh"
#include "index/target_parser.hh"
#include "db/query_context.hh"
#include "schema_builder.hh"
#include "database.hh"
#include <boost/range/adaptor/map.hpp>
namespace secondary_index {
index::index(const sstring& target_column, const index_metadata& im)
: _target_column{target_column}
, _im{im}
{}
bool index::depends_on(const column_definition& cdef) const {
return cdef.name_as_text() == _target_column;
}
bool index::supports_expression(const column_definition& cdef, const cql3::operator_type& op) const {
return cdef.name_as_text() == _target_column && op == cql3::operator_type::EQ;
}
const index_metadata& index::metadata() const {
return _im;
}
secondary_index_manager::secondary_index_manager(column_family& cf)
: _cf{cf}
{}
void secondary_index_manager::reload() {
const auto& table_indices = _cf.schema()->all_indices();
auto it = _indices.begin();
while (it != _indices.end()) {
auto index_name = it->first;
if (table_indices.count(index_name) == 0) {
it = _indices.erase(it);
} else {
++it;
}
}
for (const auto& index : _cf.schema()->all_indices()) {
add_index(index.second);
}
}
void secondary_index_manager::add_index(const index_metadata& im) {
sstring index_target_name = im.options().at(cql3::statements::index_target::target_option_name);
_indices.emplace(im.name(), index{index_target_name, im});
}
sstring index_table_name(const sstring& index_name) {
return format("{}_index", index_name);
}
static bytes get_available_token_column_name(const schema& schema) {
bytes base_name = "idx_token";
bytes accepted_name = base_name;
int i = 0;
while (schema.get_column_definition(accepted_name)) {
accepted_name = base_name + to_bytes("_")+ to_bytes(std::to_string(++i));
}
return accepted_name;
}
view_ptr secondary_index_manager::create_view_for_index(const index_metadata& im) const {
auto schema = _cf.schema();
sstring index_target_name = im.options().at(cql3::statements::index_target::target_option_name);
schema_builder builder{schema->ks_name(), index_table_name(im.name())};
auto target = target_parser::parse(schema, im);
const auto* index_target = std::get<const column_definition*>(target);
auto target_type = std::get<cql3::statements::index_target::target_type>(target);
if (target_type != cql3::statements::index_target::target_type::values) {
throw std::runtime_error(format("Unsupported index target type: {}", to_sstring(target_type)));
}
builder.with_column(index_target->name(), index_target->type, column_kind::partition_key);
// Additional token column is added to ensure token order on secondary index queries
bytes token_column_name = get_available_token_column_name(*schema);
builder.with_column(token_column_name, bytes_type, column_kind::clustering_key);
for (auto& col : schema->partition_key_columns()) {
if (col == *index_target) {
continue;
}
builder.with_column(col.name(), col.type, column_kind::clustering_key);
}
for (auto& col : schema->clustering_key_columns()) {
if (col == *index_target) {
continue;
}
builder.with_column(col.name(), col.type, column_kind::clustering_key);
}
if (index_target->is_primary_key()) {
for (auto& def : schema->regular_columns()) {
db::view::create_virtual_column(builder, def.name(), def.type);
}
}
const sstring where_clause = format("{} IS NOT NULL", cql3::util::maybe_quote(index_target_name));
builder.with_view_info(*schema, false, where_clause);
return view_ptr{builder.build()};
}
std::vector<index_metadata> secondary_index_manager::get_dependent_indices(const column_definition& cdef) const {
return boost::copy_range<std::vector<index_metadata>>(_indices
| boost::adaptors::map_values
| boost::adaptors::filtered([&] (auto& index) { return index.depends_on(cdef); })
| boost::adaptors::transformed([&] (auto& index) { return index.metadata(); }));
}
std::vector<index> secondary_index_manager::list_indexes() const {
return boost::copy_range<std::vector<index>>(_indices | boost::adaptors::map_values);
}
bool secondary_index_manager::is_index(view_ptr view) const {
for (auto& i : list_indexes()) {
if (view->cf_name() == index_table_name(i.metadata().name())) {
return true;
}
}
return false;
}
}