In that level no io_priority_class-es exist. Instead, all the IO happens in the context of current sched-group. File API no longer accepts prio class argument (and makes io_intent arg mandatory to impls). So the change consists of - removing all usage of io_priority_class - patching file_impl's inheritants to updated API - priority manager goes away altogether - IO bandwidth update is performed on respective sched group - tune-up scylla-gdb.py io_queues command The first change is huge and was made semi-autimatically by: - grep io_priority_class | default_priority_class - remove all calls, found methods' args and class' fields Patching file_impl-s is smaller, but also mechanical: - replace io_priority_class& argument with io_intent* one - pass intent to lower file (if applicatble) Dropping the priority manager is: - git-rm .cc and .hh - sed out all the #include-s - fix configure.py and cmakefile The scylla-gdb.py update is a bit hairry -- it needs to use task queues list for IO classes names and shares, but to detect it should it checks for the "commitlog" group is present. Signed-off-by: Pavel Emelyanov <xemul@scylladb.com> Closes #13963
33 lines
1.0 KiB
C++
33 lines
1.0 KiB
C++
/*
|
|
* Copyright (C) 2021-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <seastar/util/noncopyable_function.hh>
|
|
|
|
#include "feed_writers.hh"
|
|
|
|
namespace mutation_writer {
|
|
|
|
struct segregate_config {
|
|
// Maximum amount of memory to be used by the in-memory segregation
|
|
// (sorting) structures. Partitions can be split across partitions
|
|
size_t max_memory;
|
|
};
|
|
|
|
// Given a producer that may contain partitions in the wrong order, or even
|
|
// contain partitions multiple times, separate them such that each output
|
|
// stream keeps the partition ordering guarantee. In other words, repair
|
|
// a stream that violates the ordering requirements by splitting it into output
|
|
// streams that honor it.
|
|
// This is useful for scrub compaction to split sstables containing out-of-order
|
|
// and/or duplicate partitions into sstables that honor the partition ordering.
|
|
future<> segregate_by_partition(flat_mutation_reader_v2 producer, segregate_config cfg, reader_consumer_v2 consumer);
|
|
|
|
} // namespace mutation_writer
|