From d48aff5789176f257845f06d2f0f9672a8a5b73d Mon Sep 17 00:00:00 2001 From: Pavel Emelyanov Date: Tue, 12 Sep 2023 15:03:10 +0300 Subject: [PATCH] batchlog_manager: Remove start() method It's now a no-op, can be dropped. Signed-off-by: Pavel Emelyanov --- db/batchlog_manager.cc | 4 ---- db/batchlog_manager.hh | 1 - main.cc | 1 - 3 files changed, 6 deletions(-) diff --git a/db/batchlog_manager.cc b/db/batchlog_manager.cc index 10a74addec..65adc4058b 100644 --- a/db/batchlog_manager.cc +++ b/db/batchlog_manager.cc @@ -111,10 +111,6 @@ future<> db::batchlog_manager::batchlog_replay_loop() { } } -future<> db::batchlog_manager::start() { - return make_ready_future<>(); -} - future<> db::batchlog_manager::drain() { if (_stop.abort_requested()) { co_return; diff --git a/db/batchlog_manager.hh b/db/batchlog_manager.hh index 32b9a3af58..4ea668ad01 100644 --- a/db/batchlog_manager.hh +++ b/db/batchlog_manager.hh @@ -75,7 +75,6 @@ public: // shard qp (which is what you feed here). batchlog_manager(cql3::query_processor&, db::system_keyspace& sys_ks, batchlog_manager_config config); - future<> start(); // abort the replay loop and return its future. future<> drain(); future<> stop(); diff --git a/main.cc b/main.cc index 5148c432dd..6f0e828bf3 100644 --- a/main.cc +++ b/main.cc @@ -1718,7 +1718,6 @@ To start the scylla server proper, simply invoke as: scylla server (or just scyl auto stop_batchlog_manager = defer_verbose_shutdown("batchlog manager", [&bm] { bm.stop().get(); }); - bm.invoke_on_all(&db::batchlog_manager::start).get(); supervisor::notify("starting load meter"); load_meter.init(db, gossiper.local()).get();