From bae6f3387fd79fe902816d1783760d2952419d2a Mon Sep 17 00:00:00 2001 From: Nadav Har'El Date: Thu, 30 Nov 2023 16:48:24 +0200 Subject: [PATCH] CODEOWNERS: remove some entries The ".github/CODEOWNERS" is used by github to recommend reviewers for pull requests depending on the directories touched in the pull request. Github ignores entries on that file who are not **maintainers**. Since Jan is no longer a Scylla maintainer, I remove his entries in the list. Additionally, I am removing *myself* from *some* of the directories. For many years, it was an (unwritten) policy that experienced Scylla developers are expected to help in reviewing pieces of the code they are familiar with - even if they no longer work on that code today. But as ScyllaDB the company grew, this is no longer true; The policy is now that experienced developers are requested review only code in their own or their team's area of responsibility - experienced developers should help review *designs* of other parts, but not the actual code. For this reason I'm removing my name from various directories. I can still help review such code if asked specifically - but I will no longer be the "default" reviewer for such code. Signed-off-by: Nadav Har'El Closes scylladb/scylladb#16239 --- .github/CODEOWNERS | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 41f7efa3f6..5bafde3921 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -19,13 +19,13 @@ db/batch* @elcallio service/storage_proxy* @gleb-cloudius # COMPACTION -compaction/* @raphaelsc @nyh +compaction/* @raphaelsc # CQL TRANSPORT LAYER transport/* # CQL QUERY LANGUAGE -cql3/* @tgrabiec @cvybhu @nyh +cql3/* @tgrabiec # COUNTERS counters* @jul-stas @@ -45,44 +45,44 @@ dist/docker/* utils/logalloc* @tgrabiec # MATERIALIZED VIEWS -db/view/* @nyh @cvybhu @piodul -cql3/statements/*view* @nyh @cvybhu @piodul -test/boost/view_* @nyh @cvybhu @piodul +db/view/* @nyh @piodul +cql3/statements/*view* @nyh @piodul +test/boost/view_* @nyh @piodul # PACKAGING dist/* @syuu1228 # REPAIR -repair/* @tgrabiec @asias @nyh +repair/* @tgrabiec @asias # SCHEMA MANAGEMENT -db/schema_tables* @tgrabiec @nyh -db/legacy_schema_migrator* @tgrabiec @nyh -service/migration* @tgrabiec @nyh -schema* @tgrabiec @nyh +db/schema_tables* @tgrabiec +db/legacy_schema_migrator* @tgrabiec +service/migration* @tgrabiec +schema* @tgrabiec # SECONDARY INDEXES -index/* @nyh @cvybhu @piodul -cql3/statements/*index* @nyh @cvybhu @piodul -test/boost/*index* @nyh @cvybhu @piodul +index/* @nyh @piodul +cql3/statements/*index* @nyh @piodul +test/boost/*index* @nyh @piodul # SSTABLES -sstables/* @tgrabiec @raphaelsc @nyh +sstables/* @tgrabiec @raphaelsc # STREAMING streaming/* @tgrabiec @asias service/storage_service.* @tgrabiec @asias # ALTERNATOR -alternator/* @nyh @havaker @nuivall -test/alternator/* @nyh @havaker @nuivall +alternator/* @havaker @nuivall +test/alternator/* @havaker @nuivall # HINTED HANDOFF db/hints/* @piodul @vladzcloudius @eliransin # REDIS -redis/* @nyh @syuu1228 -test/redis/* @nyh @syuu1228 +redis/* @syuu1228 +test/redis/* @syuu1228 # READERS reader_* @denesb