From 9400b7965866f26ae4944b0b32fa07cbe75fad53 Mon Sep 17 00:00:00 2001 From: "Raphael S. Carvalho" Date: Mon, 14 Aug 2023 18:26:07 -0300 Subject: [PATCH] gce_snitch: Fix use-after-move in load_config() The use-after-move is not very harmful as it's only used when handling exception. So user would be left with a bogus message. Signed-off-by: Raphael S. Carvalho Closes #15054 --- locator/gce_snitch.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/locator/gce_snitch.cc b/locator/gce_snitch.cc index c587504efe..0c888bffe1 100644 --- a/locator/gce_snitch.cc +++ b/locator/gce_snitch.cc @@ -40,7 +40,7 @@ future<> gce_snitch::load_config() { meta_server_url = _meta_server_url; } - return gce_api_call(std::move(meta_server_url), ZONE_NAME_QUERY_REQ).then([this, meta_server_url] (sstring az) { + return gce_api_call(meta_server_url, ZONE_NAME_QUERY_REQ).then([this, meta_server_url] (sstring az) { if (az.empty()) { return make_exception_future(std::runtime_error(format("Got an empty zone name from the GCE meta server {}", meta_server_url))); }