bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

db,view: pass base token by value to mutate_MV

Browse Source 
The base token is passed cross-continuations, so the current way
of passing it by const reference probably only works because the token
copying is cheap enough to optimize the reference out.
Fix by explicitly taking the token by value.
This commit is contained in:
Piotr Sarna
2021-06-14 09:28:49 +02:00
parent 846f0bd16e
commit 88d4a66e90
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
db/view/view.cc
View File

@@ -1194,7 +1194,7 @@ static future<> apply_to_remote_endpoints(gms::inet_address target, inet_address
// appropriate paired replicas. This is done asynchronously - we do not wait // appropriate paired replicas. This is done asynchronously - we do not wait
// for the writes to complete. // for the writes to complete.
future<> mutate_MV( future<> mutate_MV(
const dht::token& base_token, dht::token base_token,
std::vector<frozen_mutation_and_schema> view_updates, std::vector<frozen_mutation_and_schema> view_updates,
db::view::stats& stats, db::view::stats& stats,
cf_stats& cf_stats, cf_stats& cf_stats,

2
db/view/view.hh
View File

@@ -151,7 +151,7 @@ query::clustering_row_ranges calculate_affected_clustering_ranges(
struct wait_for_all_updates_tag {}; struct wait_for_all_updates_tag {};
using wait_for_all_updates = bool_class<wait_for_all_updates_tag>; using wait_for_all_updates = bool_class<wait_for_all_updates_tag>;
future<> mutate_MV( future<> mutate_MV(
const dht::token& base_token, dht::token base_token,
std::vector<frozen_mutation_and_schema> view_updates, std::vector<frozen_mutation_and_schema> view_updates,
db::view::stats& stats, db::view::stats& stats,
cf_stats& cf_stats, cf_stats& cf_stats,