treewide: reduce header interdependencies

Use forward declarations wherever possible.

Signed-off-by: Pavel Solodovnikov <pa.solodovnikov@scylladb.com>

Closes #8813

db/view/row_locking.cc

@@ -21,6 +21,7 @@
 
 #include "row_locking.hh"
 #include "log.hh"
+#include "utils/latency.hh"
 
 #include <seastar/core/when_all.hh>
 

db/view/row_locking.hh

@@ -43,8 +43,6 @@
 #include "dht/i_partitioner.hh"
 #include "query-request.hh"
 #include "utils/estimated_histogram.hh"
-#include "utils/histogram.hh"
-#include "utils/latency.hh"
 
 class row_locker {
 public:

db/view/view.cc

@@ -59,6 +59,7 @@
 #include "clustering_bounds_comparator.hh"
 #include "cql3/statements/select_statement.hh"
 #include "cql3/util.hh"
+#include "cql3/restrictions/statement_restrictions.hh"
 #include "db/view/view.hh"
 #include "db/view/view_builder.hh"
 #include "db/view/view_updating_consumer.hh"
@@ -80,6 +81,7 @@
 #include "types/list.hh"
 #include "types/map.hh"
 #include "utils/error_injection.hh"
+#include "utils/exponential_backoff_retry.hh"
 
 using namespace std::chrono_literals;
 

db/view/view.hh

@@ -21,16 +21,12 @@
 
 #pragma once
 
-#include "view_stats.hh"
 #include "dht/i_partitioner.hh"
 #include "gc_clock.hh"
 #include "query-request.hh"
 #include "schema_fwd.hh"
-#include "mutation_fragment.hh"
 #include "flat_mutation_reader.hh"
 
-#include <seastar/core/semaphore.hh>
-
 class frozen_mutation_and_schema;
 struct cf_stats;
 
@@ -43,6 +39,8 @@ namespace db {
 
 namespace view {
 
+class stats;
+
 // Part of the view description which depends on the base schema version.
 //
 // This structure may change even though the view schema doesn't change, so

db/view/view_builder.hh

@@ -22,11 +22,8 @@
 #pragma once
 
 #include "dht/i_partitioner.hh"
-#include "keys.hh"
 #include "query-request.hh"
 #include "service/migration_listener.hh"
-#include "service/migration_manager.hh"
-#include "utils/exponential_backoff_retry.hh"
 #include "utils/serialized_action.hh"
 #include "utils/UUID.hh"
 #include "database.hh"
@@ -56,7 +53,12 @@ class view_build_progress;
 
 }
 
+namespace service {
+    class migration_manager;
+} // namespace service
+
 class database;
+class exponential_backoff_retry;
 
 namespace db::view {
 

db/view/view_update_generator.cc

@@ -23,6 +23,7 @@
 #include "view_update_generator.hh"
 #include "service/priority_manager.hh"
 #include "utils/error_injection.hh"
+#include "db/view/view_updating_consumer.hh"
 
 static logging::logger vug_logger("view_update_generator");
 

db/view/view_update_generator.hh

@@ -22,8 +22,7 @@
 #pragma once
 
 #include "database.hh"
-#include "sstables/sstables.hh"
-#include "db/view/view_updating_consumer.hh"
+#include "sstables/shared_sstable.hh"
 
 #include <seastar/core/abort_source.hh>
 #include <seastar/core/condition-variable.hh>