bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

treewide: use coroutine::maybe_yield() instead of co_await make_ready_future()

Browse Source 
The dedicated API shows the intent, and may be a tiny bit faster.

Closes #9382
This commit is contained in:
Avi Kivity
2021-09-23 12:32:36 +03:00
committed by Piotr Sarna
parent 6702711d9c
commit 369afe3124
11 changed files with 29 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
db/view/view.cc
View File

@@ -55,6 +55,7 @@
#include <seastar/core/future-util.hh>
#include <seastar/core/coroutine.hh>
#include <seastar/coroutine/maybe_yield.hh>
#include "database.hh"
#include "clustering_bounds_comparator.hh"
@@ -1138,7 +1139,7 @@ future<query::clustering_row_ranges> calculate_affected_clustering_ranges(const
}
for (auto&& r : v.view->view_info()->partition_slice().default_row_ranges()) {
view_row_ranges.push_back(r.transform(std::mem_fn(&clustering_key_prefix::view)));
co_await make_ready_future<>(); // yield if needed
co_await coroutine::maybe_yield();
}
}
}
@@ -1155,7 +1156,7 @@ future<query::clustering_row_ranges> calculate_affected_clustering_ranges(const
if (overlap) {
row_ranges.push_back(std::move(overlap).value());
}
co_await make_ready_future<>(); // yield if needed
co_await coroutine::maybe_yield();
}
}
}
@@ -1164,7 +1165,7 @@ future<query::clustering_row_ranges> calculate_affected_clustering_ranges(const
if (update_requires_read_before_write(base, views, key, row)) {
row_ranges.emplace_back(row.key());
}
co_await make_ready_future<>(); // yield if needed
co_await coroutine::maybe_yield();
}
// Note that the views could have restrictions on regular columns,