bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

snitch: Mark get_datacenter/_rack methods const

Browse Source 
They are in fact such, but wasn't marked as const before because they
wanted to talk to non-const gossiper and system_keyspaces methods and
updated snitch internal caches

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
This commit is contained in:
Pavel Emelyanov
2022-08-30 16:49:06 +03:00
parent e9bd912f79
commit 26f9472f21
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
locator/production_snitch_base.cc
View File

@@ -33,11 +33,11 @@ production_snitch_base::production_snitch_base(snitch_config cfg)
}
sstring production_snitch_base::get_rack() {
sstring production_snitch_base::get_rack() const {
return _my_rack;
}
sstring production_snitch_base::get_datacenter() {
sstring production_snitch_base::get_datacenter() const {
return _my_dc;
}

4
locator/production_snitch_base.hh
View File

@@ -42,8 +42,8 @@ public:
explicit production_snitch_base(snitch_config);
virtual sstring get_rack() override;
virtual sstring get_datacenter() override;
virtual sstring get_rack() const override;
virtual sstring get_datacenter() const override;
virtual void set_backreference(snitch_ptr& d) override;
private:

4
locator/rack_inferring_snitch.hh
View File

@@ -32,12 +32,12 @@ struct rack_inferring_snitch : public snitch_base {
set_snitch_ready();
}
virtual sstring get_rack() override {
virtual sstring get_rack() const override {
auto endpoint = utils::fb_utilities::get_broadcast_address();
return std::to_string(uint8_t(endpoint.bytes()[2]));
}
virtual sstring get_datacenter() override {
virtual sstring get_datacenter() const override {
auto endpoint = utils::fb_utilities::get_broadcast_address();
return std::to_string(uint8_t(endpoint.bytes()[1]));
}

4
locator/simple_snitch.hh
View File

@@ -29,11 +29,11 @@ struct simple_snitch : public snitch_base {
set_snitch_ready();
}
virtual sstring get_rack() override {
virtual sstring get_rack() const override {
return "rack1";
}
virtual sstring get_datacenter() override {
virtual sstring get_datacenter() const override {
return "datacenter1";
}

4
locator/snitch_base.hh
View File

@@ -63,12 +63,12 @@ public:
/**
* returns a String representing the rack local node belongs to
*/
virtual sstring get_rack() = 0;
virtual sstring get_rack() const = 0;
/**
* returns a String representing the datacenter local node belongs to
*/
virtual sstring get_datacenter() = 0;
virtual sstring get_datacenter() const = 0;
/**
* returns whatever info snitch wants to gossip