bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

configure.py: reenable -Wnarrowing

Browse Source 
it seems that the tree builds just fine with this warning enabled.
and narrowing is a potentially unsafe numeric conversion. so let's
enable this warning option.

this change also helps to reduce the difference between the rules
generated by configure.py and those generated by CMake.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#16929
This commit is contained in:
Kefu Chai
2024-01-23 10:52:12 +08:00
committed by Botond Dénes
parent 5005e0a156
commit 26004071b3
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
configure.py
View File

@@ -1536,7 +1536,6 @@ def get_warning_options(cxx):
'-Wno-unsupported-friend', '-Wno-unsupported-friend',
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77728 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77728
'-Wno-psabi', '-Wno-psabi',
'-Wno-narrowing',
'-Wno-enum-constexpr-conversion', '-Wno-enum-constexpr-conversion',
] ]