bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

view_update_generator: Dump throughput and duration for view update from staging

Browse Source 
Very helpful for user to understand how fast view update generation
is processing the staging sstables. Today, logs are completely
silent on that. It's not uncommon for operators to peek into
staging dir and deduce the throughput based on removal of files,
which is terrible.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
This commit is contained in:
Raphael S. Carvalho
2023-06-19 15:39:21 -03:00
parent 83c70ac04f
commit 1ff8645eaa
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
db/view/view_update_generator.cc
View File

@@ -16,6 +16,7 @@
#include "sstables/progress_monitor.hh" #include "sstables/progress_monitor.hh"
#include "readers/evictable.hh" #include "readers/evictable.hh"
#include "dht/partition_filter.hh" #include "dht/partition_filter.hh"
#include "utils/pretty_printers.hh"
static logging::logger vug_logger("view_update_generator"); static logging::logger vug_logger("view_update_generator");
@@ -127,9 +128,9 @@ future<> view_update_generator::start() {
auto& [t, sstables] = *table_it; auto& [t, sstables] = *table_it;
schema_ptr s = t->schema(); schema_ptr s = t->schema();
vug_logger.trace("Processing {}.{}: {} sstables", s->ks_name(), s->cf_name(), sstables.size());
const auto num_sstables = sstables.size(); const auto num_sstables = sstables.size();
auto start_time = db_clock::now();
uint64_t input_size = 0;
try { try {
// Exploit the fact that sstables in the staging directory // Exploit the fact that sstables in the staging directory
@@ -138,8 +139,12 @@ future<> view_update_generator::start() {
auto ssts = make_lw_shared<sstables::sstable_set>(sstables::make_partitioned_sstable_set(s, false)); auto ssts = make_lw_shared<sstables::sstable_set>(sstables::make_partitioned_sstable_set(s, false));
for (auto& sst : sstables) { for (auto& sst : sstables) {
ssts->insert(sst); ssts->insert(sst);
input_size += sst->data_size();
} }
vug_logger.info("Processing {}.{}: {} in {} sstables",
s->ks_name(), s->cf_name(), utils::pretty_printed_data_size(input_size), sstables.size());
auto permit = _db.obtain_reader_permit(*t, "view_update_generator", db::no_timeout, {}).get0(); auto permit = _db.obtain_reader_permit(*t, "view_update_generator", db::no_timeout, {}).get0();
auto ms = mutation_source([this, ssts] ( auto ms = mutation_source([this, ssts] (
schema_ptr s, schema_ptr s,
@@ -184,6 +189,12 @@ future<> view_update_generator::start() {
vug_logger.warn("Moving {} from staging failed: {}:{}. Ignoring...", s->ks_name(), s->cf_name(), std::current_exception()); vug_logger.warn("Moving {} from staging failed: {}:{}. Ignoring...", s->ks_name(), s->cf_name(), std::current_exception());
} }
_registration_sem.signal(num_sstables); _registration_sem.signal(num_sstables);
auto end_time = db_clock::now();
auto duration = std::chrono::duration<float>(end_time - start_time);
vug_logger.info("Processed {}.{}: {} sstables in {}ms = {}", s->ks_name(), s->cf_name(), sstables.size(),
std::chrono::duration_cast<std::chrono::milliseconds>(duration).count(),
utils::pretty_printed_throughput(input_size, duration));
} }
// For each table, move the processed staging sstables into the table's base dir. // For each table, move the processed staging sstables into the table's base dir.
for (auto it = _sstables_to_move.begin(); it != _sstables_to_move.end(); ) { for (auto it = _sstables_to_move.begin(); it != _sstables_to_move.end(); ) {