From 17ee1a2eeda14941dc641cdaf7faf15156a813ba Mon Sep 17 00:00:00 2001 From: Tomasz Grabiec Date: Thu, 18 Jun 2020 13:01:22 +0200 Subject: [PATCH] utils: cached_file: Fix compilation error Fix field initialization order problem. In file included from ./sstables/mc/bsearch_clustered_cursor.hh:28, from sstables/index_reader.hh:32, from sstables/sstables.cc:49: ./utils/cached_file.hh: In constructor 'cached_file::stream::stream(cached_file&, const seastar::io_priority_class&, tracing::trace_state_ptr, cached_file::page_idx_type, cached_file::offset_type)': ./utils/cached_file.hh:119:34: error: 'cached_file::stream::_trace_state' will be initialized after [-Werror=reorder] 119 | tracing::trace_state_ptr _trace_state; | ^~~~~~~~~~~~ ./utils/cached_file.hh:117:23: error: 'cached_file::page_idx_type cached_file::stream::_page_idx' [-Werror=reorder] 117 | page_idx_type _page_idx; | ^~~~~~~~~ ./utils/cached_file.hh:127:9: error: when initialized here [-Werror=reorder] 127 | stream(cached_file& cf, const io_priority_class& pc, tracing::trace_state_ptr trace_state, | ^~~~~~ Message-Id: <1592478082-22505-1-git-send-email-tgrabiec@scylladb.com> --- utils/cached_file.hh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/utils/cached_file.hh b/utils/cached_file.hh index 6581cf8512..ac8229a451 100644 --- a/utils/cached_file.hh +++ b/utils/cached_file.hh @@ -128,10 +128,9 @@ public: page_idx_type start_page, offset_type start_offset_in_page) : _cached_file(&cf) , _pc(&pc) - , _trace_state(std::move(trace_state)) , _page_idx(start_page) , _offset_in_page(start_offset_in_page) - + , _trace_state(std::move(trace_state)) { } // Yields the next chunk of data.