bahman/scylla
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

schema: rename column accessors to be in line with origin

Browse Source 
More pointedly: Expose columns as is (currently
all_columns_in_select_order), expose name->column mapping more
appropriately named. 

Renaming like this is not strictly neccesary, but there is a point to
trying to keep nomenclature similar-ish with origin, esp. when select
order column need to become filtered (spoiler alert).
This commit is contained in:
Calle Wilund
2017-04-10 15:14:15 +00:00
parent d2dc7898aa
commit 0e6ae8dec2
7 changed files with 36 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
db/view/view.cc
View File

@@ -63,8 +63,8 @@ cql3::statements::select_statement& view_info::select_statement() const {
if (!_select_statement) {
std::vector<sstring_view> included;
if (!include_all_columns()) {
included.reserve(_schema.all_columns_in_select_order().size());
boost::transform(_schema.all_columns_in_select_order(), std::back_inserter(included), std::mem_fn(&column_definition::name_as_text));
included.reserve(_schema.all_columns().size());
boost::transform(_schema.all_columns(), std::back_inserter(included), std::mem_fn(&column_definition::name_as_text));
}
auto raw = cql3::util::build_select_statement(base_name(), where_clause(), std::move(included));
raw->prepare_keyspace(_schema.ks_name());