From 0ad940bfc3de37cd56b808382c341eecc3e8025b Mon Sep 17 00:00:00 2001 From: Yoav Kleinberger Date: Thu, 30 Jun 2016 16:41:57 +0300 Subject: [PATCH] tools/scyllatop: fix crash due to mouse events due to an urwid-library technicality, some mouse events like scroll or click would crash scyllatop. This patch fixes this problem. closes issue #1396. Signed-off-by: Yoav Kleinberger Message-Id: <1467294117-19218-1-git-send-email-yoav@scylladb.com> --- tools/scyllatop/userinput.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/scyllatop/userinput.py b/tools/scyllatop/userinput.py index 9a3ccb4d5b..684fd47031 100644 --- a/tools/scyllatop/userinput.py +++ b/tools/scyllatop/userinput.py @@ -1,4 +1,5 @@ import urwid +import logging class UserInput(object): @@ -13,8 +14,11 @@ class UserInput(object): self._mainLoop = loop def __call__(self, keypress): + logging.debug('keypress={}'.format(keypress)) if keypress in ('q', 'Q'): raise urwid.ExitMainLoop() + if type(keypress) is not str: + return if keypress.upper() not in self._viewMap: return